Re: [dev-servo] Merging mozjs and rust-mozjs

This seems good to me. On Fri, Jan 10, 2020, 9:59 PM Josh Matthews wrote: > Given how closely intertwined the two repositories are, and especially > given we can no longer publish them to crates.io and have a pinned git > revision in rust-mozjs's Cargo.toml, I propose that we merge the >

Re: [dev-servo] The future of irc.mozilla.org/#servo

with staying. -Manish Goregaokar On Thu, Dec 19, 2019 at 10:27 AM Alan Jeffrey wrote: > I've been using the IRC <-> Matrix bridge and the matrix client, and I've > been quite happy with them. I'd be in favour of moving to matrix, it seems > pretty decent, the ToS / CPG will be easi

Re: [dev-servo] Last week for testing potential IRC replacements

I never used it, I have a screen session on a server running irssi. I wouldn't recommend it unless you like terminal UIs. On Wed, Oct 9, 2019, 4:40 AM Paul Rouget wrote: > Now that irccloud is gone, what do you people do? Use a IRC client? Moved > to one of these platforms? > > On Fri, Oct 4,

Re: [dev-servo] Question About the Merging Process

Yep! On Mon, Apr 29, 2019, 4:33 PM Maria Sable wrote: > Hi Manish, > > Thank you! By ping, do you mean @them in the pull request conversation? > > Kind regards, > Maria Sable > > On Mon, Apr 29, 2019 at 7:26 PM Manish Goregaokar > wrote: > > > The reviewer

Re: [dev-servo] Question About the Merging Process

The reviewer has to leave a comment saying `@bors-servo r+` to inform our bot that the pull request needs merging. Once that happens, you can wait. If you have an approving Github review but no r+, make sure you've addressed any straggling issues and ping the reviewer. -Manish Goregaokar

Re: [dev-servo] How to Run Servo/Media/Examples?

one reporting similar issues on servo/media. > > > > Do you have any suggestions on how to fix this? > > > > Kind regards, > > Maria > > > > On Sat, Apr 27, 2019 at 3:54 PM Manish Goregaokar > > > wrote: > > > > > Ah. The params.rs te

Re: [dev-servo] How to Run Servo/Media/Examples?

he PKG_CONFIG_PATH environment variable by following these > instructions: https://github.com/sdroege/gstreamer-rs#installation . I > did > not see anyone reporting similar issues on servo/media. > > Do you have any suggestions on how to fix this? > > Kind regards, > Maria > >

Re: [dev-servo] Doubts regarding the subsequent steps.

Yeah, please leave a todo comment. Currently there's no way to validate this, in the future the DOM side will also have a timeline struct so that it can do this. Thanks, -Manish Goregaokar On Sat, Apr 27, 2019 at 6:52 AM Josh Bowman-Matthews wrote: > It's not clear to me how to obt

Re: [dev-servo] How to Run Servo/Media/Examples?

different to get it work with servo/media? When I run > "cargo build" in servo/media, it works fine. > > Kind regards, > Maria > > On Sat, Apr 27, 2019 at 3:13 PM Manish Goregaokar > wrote: > > > `cargo ex name_of_example` > > > > In the case of Ste

Re: [dev-servo] How to Run Servo/Media/Examples?

. Thanks, -Manish Goregaokar On Sat, Apr 27, 2019 at 12:06 PM Maria Sable wrote: > Hi all, > > I'm working on finishing up our final project at NCSU, and I need to create > a runnable example for StereoPannerNode based on the example for > PannerNode. However, it would be immensely help

Re: [dev-servo] println!("Hello from NCSU");

Yes, that is correct. This is mostly a matter of hooking up your new servo-media additions into the JS DOM apis. -Manish Goregaokar On Sat, Apr 6, 2019 at 2:02 PM BAlaji wrote: > Hi Josh > Appears to be libgstreamer0.10-dev is outdated in Ubuntu 18.04. > > Running the below in te

Re: [dev-servo] rust-webvr and media repositories now use homu

The webhooks weren't set up. Fixed. -Manish Goregaokar On Thu, Feb 21, 2019 at 2:07 AM Fernando Jiménez Moreno < ferjmor...@gmail.com> wrote: > It does not seem to be working for servo/media. The queue is empty while > there's an open PR [1]. And bors-servo does not seem to b

Re: [dev-servo] Error during compilation

Not in the example you're using. -Manish Goregaokar On Thu, Dec 6, 2018 at 5:09 PM Avanthikaa Ravichandran wrote: > Is it necessary to send any message to the GainNode? > > > On Dec 6, 2018, at 11:04 AM, Manish Goregaokar > wrote: > > > > Sorry, to clarify: this was

Re: [dev-servo] Error during compilation

Sorry, to clarify: this was a bug in the existing code, not your code. -Manish Goregaokar On Thu, Dec 6, 2018 at 11:04 AM Manish Goregaokar wrote: > I pushed a fix, please rebase your pull request to master to pull it in. > > Thanks, > -Manish Goregaokar > > > On Wed, De

Re: [dev-servo] Error during compilation

I pushed a fix, please rebase your pull request to master to pull it in. Thanks, -Manish Goregaokar On Wed, Dec 5, 2018 at 10:08 PM Avanthikaa Ravichandran wrote: > We pushed the final changes in the code and we have the same issue still. > On running with backtrace, I got the fol

Re: [dev-servo] Implementing periodic wave options for Oscillator node

It doesn't matter for normalization. The second half of that segment is what's relevant: you need to calculate the maximum value of a single cycle of the wave, and then scale the wave down by that. No need to worry about N. It's fine if you don't implement this for now, though. Thanks, -Manish

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

> However, for channelsum.rs and channel.rs, clone() is not allowed since options is created with Default::default(); This is because of inference, use OscillatorOptions::default() instead, *or* just construct it twice instead of reusing it -Manish Goregaokar On Sat, Nov 17, 2018 at 4:15

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

Just remove the Copy requirement on the OscillatorOptions type, it's not necessary. -Manish Goregaokar On Thu, Nov 15, 2018 at 4:15 PM Avanthikaa Ravichandran wrote: > Thank you so much. > We are also trying to implement the periodic wave option for the oscillator > node.

Re: [dev-servo] Rustfmt now checked on CI

Directly run rustfmt on the file, with `rustfmt foo.rs`. you may need to install it with `rustup component add rustfmt` On Thu, Nov 8, 2018, 6:50 PM Avanthikaa Ravichandran We are working on the media crate for servo and we were asked to run the > rustfmt to format the code. However, in the

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

No, that creates an empty (silent) buffer for the oscillator generation to write to. The code that needs rewriting is the code that calls sin(). -Manish Goregaokar On Wed, Nov 7, 2018 at 3:27 PM Avanthikaa Ravichandran wrote: > Thank you for your response. > I was also won

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

Yeah, it is fine to remove the Copy. On Tue, Nov 6, 2018, 5:09 PM Avanthikaa Ravichandran Hi, > I am trying to write an implementation for the PeriodicWaveOptions in the > oscillator node. The parameters for this - real and imaginary, do not have > fixed sizes at compile time since they depend

Re: [dev-servo] Trychooser support now live!

yesterday when doing infra upgrades. Thanks, -Manish Goregaokar On Thu, Aug 9, 2018 at 3:31 PM Manish Goregaokar wrote: > > Trychooser support <https://github.com/servo/homu/pull/167> is now live > on homu! > > This means that instead of `@bors-servo try`, you can run `@bo

[dev-servo] Trychooser support now live!

w if there are any issues! Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] ./mach build vs. cargo build

IMO those reasons do not apply to toplevel flags; and given that Cargo profiles are a thing we really should have a rustflags key there. I've always had trouble with getting IDEs working with servo because of this. -Manish Goregaokar On Wed, Apr 4, 2018 at 6:12 AM, Lars Bergstrom <la

Re: [dev-servo] RFC: Require rustup.rs to build Servo with mach

We can explicitly call `cargo +stable build` for geckolib, and have a min version check in mach. We'll only get the rust-toolchain file pinning for one of the two and will have to build some mach stuff for the other, but it will be considerably simpler than what we have right now. I think we

Re: [dev-servo] Should commits landed in servo individually pass all tests?

t's also expensive); because as-is I'm quite certain that bisect without first-parent would *regularly* break tests on the way; and that's not just because *I*'ve not been following that rule. I'm pretty sure nobody runs try on every commit they make; so I'd expect to see lots of test-broken commit

[dev-servo] Should commits landed in servo individually pass all tests?

gle commit Thoughts? -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Memory reporting in Servo: the next step

If we do impls in the mallocsizeof crate is we can't make use of the custom derive functionality and have to manually write out impls (which in many cases won't be possible). So I'm not sure if we can completely get rid of the dependency problem. -Manish Goregaokar On Thu, Oct 5, 2017 at 10:11

Re: [dev-servo] Memory reporting in Servo: the next step

ute MallocSizeOfOps as would be good. -Manish Goregaokar On Thu, Oct 5, 2017 at 9:05 PM, Nicholas Nethercote <n.netherc...@gmail.com> wrote: > On Fri, Oct 6, 2017 at 2:33 PM, Xidorn Quan <m...@upsuper.org> wrote: > > > > > There are multiple Servo dependencies on crates.i

Re: [dev-servo] Categorizing Stylo reftest failures

https://gist.github.com/Manishearth/086118c940ff86a6cfc573f53c508279 I've now gone through the failures and categorized them as yes/no/maybe based on whether they should block shipping. I've filed bugs for and partially investigated all of the "yes" ones (and fixed some of them). Some of these

Re: [dev-servo] Zhitin Zhu's intern presentation on Magic DOM

Update: Simran's presentation is now at 3:15pm – 3:30pm PDT -Manish Goregaokar On Tue, Jul 25, 2017 at 3:37 PM, Manish Goregaokar <manishsm...@gmail.com> wrote: > Servo has a whole block of intern presentations then! > > Starting at 2PM PDT: > > >- 2PM: Liz Lucas on

Re: [dev-servo] Zhitin Zhu's intern presentation on Magic DOM

Servo has a whole block of intern presentations then! Starting at 2PM PDT: - 2PM: Liz Lucas on detecting interstitials via machine learning - 2:15PM: Simran Gujral on TLS in Servo - 2:30PM: Zhiting Zhu on Magic DOM Hope you join us for all of these! Thanks, -Manish Goregaokar

Re: [dev-servo] Categorizing Stylo reftest failures

We aren't! I'm just not seeing that bug in the reftests outside of audio and video, and TYLin is already looking into it anyway. Thanks, -Manish Goregaokar On Mon, Jul 24, 2017 at 8:20 AM, Boris Zbarsky <bzbar...@mit.edu> wrote: > On 7/24/17 1:53 AM, Manish Goregao

Re: [dev-servo] Categorizing Stylo reftest failures

are first-line and the styloVsGecko / issue (which does not block landing since it's a slight discrepancy between stylo and gecko) -Manish Goregaokar On Thu, May 11, 2017 at 5:19 PM, Manish Goregaokar <manishsm...@gmail.com> wrote: > And, it's done! All reftest failures classified. >

[dev-servo] All properties implemented in Stylo!

property is supported but not some specific value), or may have bugs, but that will get fixed as we attack the reftests. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Categorizing Stylo reftest failures

to investigate things which still fail when their corresponding bug lands. Thanks, -Manish Goregaokar On Wed, May 10, 2017 at 5:14 PM, Manish Goregaokar <manishsm...@gmail.com> wrote: > So I took a try push with all expectations set as passing and went about > categorizing the reft

Re: [dev-servo] Categorizing Stylo reftest failures

First link in the file! https://treeherder.mozilla.org/#/jobs?repo=try=bff0878649f10db8946d50e760b0d13f0f3be9be Also, each section in the file already links to the analyzer results for that subset of the tests. -Manish Goregaokar ___ dev-servo mailing

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

FWIW gps planned to strip @mentions in the autosync service, so most of the pain here could go away. It already strips the boilerplate. -Manish Goregaokar On Wed, Mar 1, 2017 at 9:35 AM, Jack Moffitt <j...@metajack.im> wrote: > I agree that seems noisy and irrelevant I could have

[dev-servo] Useful tools for current Stylo workflow

0c003bd3db4bf6e58 for quickly setting test expectations. You can just copy the error summary into a file and feed it to the script, which will update all the relevant list files. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Quantum CSS (stylo) builds now on m-c

will run CI as usual so Firefox can't introduce bugs. Servo may uncover a bug that needs Firefox changes to fix, in which case you have to submit the unified change via the Firefox contribution process. -Manish Goregaokar On Mon, Feb 13, 2017 at 1:40 PM, Anthony Ramine <n.ox...@gmail.com>

Re: [dev-servo] stylo: Consider spliting gecko bindings (style/gecko_{bindings, string_cache}) into a separate crate / component?

as possible :) -Manish Goregaokar On Thu, Dec 15, 2016 at 12:50 AM, Xidorn Quan <m...@upsuper.org> wrote: > Oh, I see what did you mean. ElementData and AtomicRefCell would be a > problem. I don't see anything else, though. > > - Xidorn > > On Thu, Dec 15, 2016, at 05:29 PM,

Re: [dev-servo] stylo: Consider spliting gecko bindings (style/gecko_{bindings, string_cache}) into a separate crate / component?

to it with the types replaced. Generating it would still require the bindings build step to write code for the style crate however. I wasn't sure if we could trust manually writing it. On Dec 14, 2016 10:45 PM, "Simon Sapin" <simon.sa...@exyr.org> wrote: > On 15/12/16 02:01, Mani

Re: [dev-servo] stylo: Consider spliting gecko bindings (style/gecko_{bindings, string_cache}) into a separate crate / component?

The sugar stuff is just helpers. The crossover happens in the bindings file itself, where gets replaced with , etc. On Dec 14, 2016 5:13 PM, "Xidorn Quan" <m...@upsuper.org> wrote: > On Thu, Dec 15, 2016, at 12:01 PM, Manish Goregaokar wrote: > > They used to be a diffe

Re: [dev-servo] stylo: Consider spliting gecko bindings (style/gecko_{bindings, string_cache}) into a separate crate / component?

They used to be a different crate. I merged them so that we can do replacements with safer wrappers and have fewer coherence issues. Perhaps we can make triggering local build time bindgen regen more explicit? On Dec 14, 2016 2:57 PM, "Xidorn Quan" wrote: > I'm thinking about

Re: [dev-servo] CSSOM ownership woes

need to be wrapped in a cleaner API (haven't had a chance to properly look through that yet, and most of the parsing is just parsing of PropertyDeclarationBlocks). -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mo

Re: [dev-servo] CSSOM ownership woes

> Or probably asserting that we're not in a Servo Layout thread when we > `borrow_mut`? Not perfect, but... Extra runtime check and I'm not fond of this solution in general, since it's runtime. The token thing is a pure compile time option. Making it !Send+!Sync means that it's hard to make it

[dev-servo] CSSOM ownership woes

ruct.MediaRule.html Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

[dev-servo] Servo is a featured project on Hacktoberfest!

folks to contribute to. I got Servo added to the list -- expect an uptick in new contributors in this month. I'll start filing more easy issues. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listin

Re: [dev-servo] Weekly status updates

on X", with standups this might become cluttered. But this is minor, and probably could be fixed by being more descriptive of the subtasks. Thanks, -Manish Goregaokar On Thu, Sep 22, 2016 at 9:37 PM, Lars Bergstrom <larsb...@mozilla.com> wrote: > I've noticed that while so

Re: [dev-servo] Filterable list of all CSS properties and their syntax

Goregaokar On Mon, Aug 29, 2016 at 4:41 PM, Manish Goregaokar <manishsm...@gmail.com> wrote: > On Mon, Aug 29, 2016 at 2:23 PM, Chris Peterson <cpeter...@mozilla.com> > wrote: > > Stylo has implemented exactly one property Gecko has not: column-width. > > Oh, that's because

Re: [dev-servo] Filterable list of all CSS properties and their syntax

because I don't know how to prioritize most of these properties. The Alexa numbers will certainly help, though. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Moving style out of tree as an alternative to frankenbuild?

> Your proposal scares me in the sense that (if I read it well) it would > be at least temporarily allowing changing the style system without > gating on Servo. There are architectural changes to the style system > that work for Gecko, but would completely break Servo. > Right now landing a

Re: [dev-servo] Moving style out of tree as an alternative to frankenbuild?

> The other proposal includes making sure Gecko related stylo changes > don't break Servo, but this does not. It seems easy enough to add > Servo's test suite to the m-c side CI, so I would propose to add that > to your proposal. That means we only have to resolve conflicts until > CI is fully

[dev-servo] Moving style out of tree as an alternative to frankenbuild?

Hi, The current situation with the m-c vendoring for stylo is to put all of stylo in-tree and have an autolander dance between homu (or at least Servo buildbot) and the Gecko autolander that ensures that changes to servo/servo or m-c are always mirrored and fully tested, on both ends. There are

Re: [dev-servo] Problem compiling servo

rm -rf target/*/build/mozjs* should do the trick. There was a spidermonkey update and the old build artefacts mess the build up. Sorry! -Manish Goregaokar On Sat, Aug 13, 2016 at 7:18 PM, Peter Hall <peterj...@gmail.com> wrote: > Hi, > I upgraded OSX this week (to 10.11.6), but al

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

ct of trying to marry two opposite CI models together. But like I said it's expected to be rare so it shouldn't be an issue. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Feature detector detector for Servo debugging

It triggers for all, but the python script filters for accesses to properties that actually should be there. I wanted it to be easy to change the filtering logic without recompiling everything. -Manish Goregaokar ___ dev-servo mailing list dev-servo

[dev-servo] Feature detector detector for Servo debugging

a cleaned-up version of this might be something we can merge into the main codebase. Let me know if there are sites you'd like to see this run against! Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

these aren't bootstrapping compilers :) Rust finally went with manual rollups -- they used to be really time consuming but now it's mostly okay. Intermittents were a big problem then, too, and would have broken this model completely. Currently Servo has a pretty high rate of intermittents, -Manish

Re: [dev-servo] Stacks reported in automated panic reports cannot be trusted

Right. I think we should do both -- Servo should report these errors in a truncated form (single line with error contents and location), and bhtml can either filter these out or include them in the error reporting box until it gets a real backtrace -Manish Goregaokar On Sun, Jul 3, 2016 at 9:11

Re: [dev-servo] Stacks reported in automated panic reports cannot be trusted

At one point we were silencing MPSC and IPC errors so that the main backtrace is the only thing you see. Perhaps we should do that again? dev-servo@lists.mozilla.org wrote: > Is it possible to get the correct stack somehow? > > jack. > > On Sat, Jul 2, 2016 at 3:33 PM, Josh Matthews

[dev-servo] New github milestone: Tech Demo

I've created a new milestone on GitHub, Tech Demo <https://github.com/servo/servo/milestones/Tech%20Demo>. Please use it for issues or pull requests that are related to or must be landed before the tech demo. Thanks, -Manish Goregaokar ___ dev

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

Coordinating rollups across two repos will be a pain. The proposed automation sounds better to me. -Manish Goregaokar On Thu, Jun 23, 2016 at 10:08 AM, Michael Howell <michaelhowell...@gmail.com > wrote: > If the model you're proposing is "almost isomorphic" to roll ups, then

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

make it sound like refactorings don't introduce bugs. ;) > Sure they can, but they should be less likely to :) We will still have the full CI run on a sync so these will get caught, just not immediately. -Manish Goregaokar ___ dev-servo mailing li

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

me less of a pain, while actual changes affecting both will still be tested. The reverse can also exist, as a checkbox in the trychooser interface. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

will trigger a m-c CI build in Servo. Do lockfile changes cause this build? What about edits to util? Thanks, -Manish Goregaokar On Tue, Jun 21, 2016 at 4:16 PM, Manish Goregaokar <manishsm...@gmail.com> wrote: > My main issue is that backouts aren't addressed. They are reasonably > c

Re: [dev-servo] Proposed work for upcoming sharing of Servo components with Firefox

e best to not split style out. Thanks, -Manish Goregaokar On Mon, Jun 20, 2016 at 8:31 PM, Lars Bergstrom <larsb...@mozilla.com> wrote: > As many of you may have seen from the document > ( > https://docs.google.com/document/d/1uubYE7JXaVY10PoAY9BVx8A-T11ZxP1RYqNOrFJwdcU/edit

Re: [dev-servo] Servo without Bluetooth

It seems like it's still checking the git repo for the feature. Might be worth landing your devices changes and proceeding from there. -Manish Goregaokar On Thu, Jun 2, 2016 at 12:56 PM, Dirkjan Ochtman <dirk...@ochtman.nl> wrote: > On Wed, Jun 1, 2016 at 10:53 AM, Manish Goregaokar &g

Re: [dev-servo] Servo without Bluetooth

Oh, interesting. I have had strange errors when not fully specifying the features but the reason might have been something else. We should just do that, then, agreed. -Manish Goregaokar On Tue, May 31, 2016 at 8:21 PM, Simon Sapin <simon.sa...@exyr.org> wrote: > On 31/05/16 16:4

Re: [dev-servo] Servo without Bluetooth

y paths do not have it enabled). If this turns out to be working reliably I'd prefer to do this, though it may unexpectedly break in the future. -Manish Goregaokar On Tue, May 31, 2016 at 8:04 PM, Jack Moffitt <j...@metajack.im> wrote: > > Doing it via Cargo features sounds like the be

Re: [dev-servo] Difficulty getting access to Rust nightly build while building Servo.

This is the folder you want: https://static.rust-lang.org/dist/2016-05-14/index.html -Manish Goregaokar On Mon, May 16, 2016 at 3:17 PM, <sow...@gmail.com> wrote: > Hi, > > I am trying to port Servo to Power8/LE platform (ref thread: > https://groups.google.com/forum/#!topic

Re: [dev-servo] Pull request template

It might also be nice to have bors' approval message note travis failures (only travis for now, appveyor isn't always passing) if a travis-failing PR is approved. -Manish Goregaokar On Fri, May 6, 2016 at 8:43 PM, Josh Matthews <j...@joshmatthews.net> wrote: > Github introduced t

Re: [dev-servo] Moving away from merge commits

it > doesn't. If there is a bad merge commit, `git bisect` will clearly point > to it as the culprit; while problems introduced in a rebase will in no > way indicate the rebase as the cause. > note that git bisect gets rather muddled with merge commits unless you teach it to only bisect

Re: [dev-servo] Moving away from merge commits

Yeah, it does, that's what homu does currently. -Manish Goregaokar On Wed, Apr 27, 2016 at 9:08 PM, Nick Fitzgerald <nfitzger...@mozilla.com> wrote: > On Wed, Apr 27, 2016 at 8:34 AM, Matt Brubeck <mbrub...@mozilla.com> > wrote: > > > On Wed, Apr 27, 2016 at

Re: [dev-servo] Moving away from merge commits

st and skip. But it's possible; I recall doing this once. Thanks, -Manish Goregaokar On Tue, Apr 26, 2016 at 11:50 PM, Gregory Szorc <g...@mozilla.com> wrote: > Servo developers, > > I noticed that Servo and a number of other Servo related Git repos have > tons of merge com

Re: [dev-servo] Questions about GSoC File Support project

-Manish Goregaokar On Wed, Mar 16, 2016 at 1:37 AM, Manish Goregaokar <manishea...@gmail.com> wrote: > > On Tue, Mar 15, 2016 at 3:13 PM, Zhen Zhang <izgz...@gmail.com> wrote: > >> >> 1. About FileList API, It is said to be *at risk* to be replaced by >>

Re: [dev-servo] PSA: incoming Windows CI (AppVeyor)

This has been deployed. https://github.com/servo/servo/pull/9884#issuecomment-192805671 The builder is called "status-appveyor" and behaves similar to Travis. I'll be watching the queue today and tomorrow. Revert the salt deployment if anything goes wrong. Thanks, -Manish

Re: [dev-servo] Fwd: Re: Suggested code review workflow

R messages since nobody wants to retype what the issue says. -Manish Goregaokar On Sun, Feb 21, 2016 at 5:58 AM, Lars Bergstrom <larsb...@mozilla.com> wrote: > This may also be less of a big deal here at Mozilla, where there's > (presumably?) only been one bug database since 1998 and will

Re: [dev-servo] IndexDB project

probably start implementing necessary things too, not only focusing on new experiments :) Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] IndexDB project

More or less. If you're going to pick leveldb it would be better to use rocksdb (which is a leveldb fork, IIRC) since there is a Rust wrapper that's in use by others. -Manish Goregaokar On Tue, Dec 15, 2015 at 11:03 AM, Shing Lyu <s...@mozilla.com> wrote: > Thank you guys. > > So

Re: [dev-servo] IndexDB project

Apparently SQlite4 has a good kv store included, but nox knows it better and understands the justification. I think firefox uses sqlite (3?); it uses sqlite for everything. -Manish Goregaokar On Tue, Dec 15, 2015 at 9:12 AM, Jack Moffitt <j...@metajack.im> wrote: > Why would we use

Re: [dev-servo] Mozlando meeting notes

ic DOM probably will change the landscape. -Manish Goregaokar On Sat, Dec 12, 2015 at 11:41 PM, Anthony Ramine <n.ox...@gmail.com> wrote: > > Le 12 déc. 2015 à 09:56, Lars Bergstrom <larsb...@mozilla.com> a écrit : > > > > Thanks to everybody for a fantastic workweek

Re: [dev-servo] Question about webidl files and old versions of servo

you'll also need to add the webidl file (as well as a dom module) for ImageData <https://html.spec.whatwg.org/multipage/scripting.html#imagedata>. Do you have a link to the spec for ImageRequest? I couldn't find it after some quick searching. Let me know if you

Re: [dev-servo] PSA: Review delegation enabled for homu

Bit late to the party, but I think there are a couple of core issues causing this debate: There are actually two kinds of trust involved. First is the trust to not botnet the CI, basically everyone here (at least everyone with try) has that. But that's not the actual one being discussed here. The

[dev-servo] PSA: Review delegation enabled for homu

re <https://github.com/servo/saltfs/pull/160>. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Handling cases where the spec is inefficient and not followed by anyone

Oh, yeah, in that case we should just mimic the other browsers and file bugs. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Handling cases where the spec is inefficient and not followed by anyone

mimicing it) and filing a bug -- if it's not too hard to do so -- is what we should do. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Meeting notes 11/2 (review carry-over; test coverage; 2016 roadmap; rebase/autosquash; PR queue; debug logging; CSSWG reftests)

We probably can't do it in an automated way; tests being converted to WPT need to match spec and usually also need a spec link in the top. We could, however, import them wholesale into Servo's tests/wpt/mozilla/foo, and then manually pick through them. -Manish Goregaokar On Wed, Nov 4, 2015

[dev-servo] Handling cases where the spec is inefficient and not followed by anyone

as is (which require major changes and affect perf or complexity), or we can hope that nobody relies on this behaviour (given that it's not followed by major browsers) and implement it as logically as possible, keeping in line with other browsers (and leaving a bug open about the spec issue). Thoug

Re: [dev-servo] "Hacking Servo for noobs" moving it to servo repo or to wiki?

CONTRIBUTING sgtm -Manish Goregaokar On Thu, Oct 22, 2015 at 4:51 PM, Paul Rouget <p...@mozilla.com> wrote: > Maybe I could merge it into CONTRIBUTING.md? Or README.md? > What would you recommend? > > On Thu, Oct 22, 2015 at 12:54 PM, Josh Matthews <j...@joshmatthews.net&g

Re: [dev-servo] (no subject)

, ./mach rustc) instead. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] WPT Tests

by the CI (there was an incident when this stopped working, IIRC). It's not an "actual" web platform test. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] (no subject)

Delete your Cargo.lock -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] (no subject)

I'll get around to updating all of the deps to work with it later. @Divya try a fresh checkout of rust-layers. I tweaked the crates so that they don't need plugin support when being built standalone (since the plugins are only needed for Servo integration to work) -Manish Goregaokar On Sun, Oct

Re: [dev-servo] (no subject)

ithub.com/brson/multirust> is a way of maintaining multiple Rust installs in parallel, if you don't want to uninstall your nightly. I'll let you know when stuff is working again. -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozil

Re: [dev-servo] Turning on autoloader rebasing and/or autosquashing

Barosl just verified in chat that it makes an empty commit with the merge information even when rebasing. I'm now pretty ambivalent towards this. I don't mind linear histories, but ... I can handle graphy ones too. -Manish Goregaokar On Fri, Oct 16, 2015 at 2:08 AM, Manish Goregaokar <manis

Re: [dev-servo] Travis, Rust Nightlies Aster

That sounds doable. I'm open to helping maintain aster's nightlyness. -Manish Goregaokar On Thu, Aug 20, 2015 at 9:47 PM, Simon Sapin simon.sa...@exyr.org wrote: On 20/08/15 17:50, Ms2ger wrote: Hi all, Recently, homu has regularly rejected PRs to rust-layers because of a mismatch between

[dev-servo] Allowing occasional rollups?

linear history is okay, especially when most of the PRs being rolled up are minor ones. Thanks, -Manish Goregaokar ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] mac3

, we can bisect if necessary. -Manish Goregaokar On Fri, Aug 7, 2015 at 3:10 PM, Ms2ger ms2...@gmail.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, The last mac3 run (http://build.servo.org/builders/mac3/builds/829) took 1 hrs, 13 mins, 57 secs, of which it spent 45

Re: [dev-servo] (Not) using wildcard version when declaring dependencies

Yes, I was talking about Crates crates too :) My plan is to upgrade Rust often now that it's pretty stable, which automatically keeps our libraries up to date too. But if we don't want to do that I guess pinning to semver is okay. -Manish Goregaokar On Tue, Jun 16, 2015 at 2:52 AM, Simon Sapin

  1   2   >