Review Request 51514: [ATLAS-1144] Create/update entity API call should return more definitions

ava/org/apache/atlas/web/resources/EntityResource.java 82016d0 Diff: https://reviews.apache.org/r/51514/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 51514: [ATLAS-1144] Create/update entity API call should return more definitions

d, the API response remains unaffected. Diffs (updated) - webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 82016d0 Diff: https://reviews.apache.org/r/51514/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 51514: [ATLAS-1144] Create/update entity API call should return more definitions

ity will get repeated since the first one > > has already been added in DEFINITION Same as above - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51514/#review147267 --- On Aug. 30

Re: Review Request 51514: [ATLAS-1144] Create/update entity API call should return more definitions

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51514/#review147407 ------- On Aug. 30, 2016, 3:44 p.m., Apoorv Naik wrote: > > --

Re: Review Request 51514: [ATLAS-1144] Create/update entity API call should return more definitions

t have its own 'uriInfo' object? If not, how does this > > method differentiate requests that include "responseType" query parameter > > from the ones that don't? > > Apoorv Naik wrote: > Yes, every request has it's own UriInfo object. &g

Re: Review Request 51514: [ATLAS-1144] Create/update entity API call should return more definitions

o reply, visit: https://reviews.apache.org/r/51514/#review147451 --- On Aug. 30, 2016, 3:44 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 51514: [ATLAS-1144] Create/update entity API call should return more definitions

eld called "definitionList" which is of type JsonArray. If the parameter is unspecified, the API response remains unaffected. Diffs (updated) - webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 82016d0 Diff: https://reviews.apache.org/r/51514/diff/ Testing --- Thanks, Apoorv Naik

Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

/51660/diff/ Testing --- Tested with all possible keywords specified in the QueryParser, the UI shows a red exception message stating that the type being created is a keyword Thanks, Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

://reviews.apache.org/r/51660/diff/ Testing --- Tested with all possible keywords specified in the QueryParser, the UI shows a red exception message stating that the type being created is a keyword Thanks, Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

://reviews.apache.org/r/51660/diff/ Testing --- Tested with all possible keywords specified in the QueryParser, the UI shows a red exception message stating that the type being created is a keyword Thanks, Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

r each loops - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review147940 --- On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wr

Current use cases for POST /entities

Is anyone relying on the definition object within the response of a create entity call ? If not, let’s remove it from the response as it can be inferred from the request body itself and the only useful piece seems to be the GUIDs.

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review148651 ------- On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote: > > --

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

t; > > > Can you also add tests for this? Working on adding the tests - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review148465 ---

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

heck - typename equals keyword. Does it work if > > typename contains keyword e.g., if typename is 'isa PII'? > > > > Not sure if keywords in DSL is case sensitive. You may want to verify > > Apoorv Naik wrote: > Right now this will go through. I

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

heck - typename equals keyword. Does it work if > > typename contains keyword e.g., if typename is 'isa PII'? > > > > Not sure if keywords in DSL is case sensitive. You may want to verify > > Apoorv Naik wrote: > Right now this will go through. &

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

https://mvnrepository.com/artifact/com.fasterxml.jackson.jaxrs/jackson-jaxrs-json-provider - Apoorv Naik On Sept. 14, 2016, 5:33 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 51939: Framework to apply updates to types in the type-system

d vice-versa repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 85) <https://reviews.apache.org/r/51939/#comment216696> Can we preserve the specific imports instead of wildcards ? - Apoorv Naik On Sept. 15, 2016, 11:03 p.m., Sarath Kumar

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

that the type being created is a keyword Thanks, Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

/DefaultMetadataServiceTest.java (line 202) <https://reviews.apache.org/r/51660/#comment216706> Need to delete this unwanted code. Doesn't correspond to the actual test Please ignore. - Apoorv Naik On Sept. 16, 2016, 5:40 a.m., Apoorv

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

dsl search gives results Thanks, Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

--- Tested with all possible keywords specified in the QueryParser, the UI loads up the trait definition. UnitTests create the traitDef and the dsl search gives results Thanks, Apoorv Naik

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 21, 2016, 11:47 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 279 > > > > > > Instead of having multiple checks its better to abstract ou

Gremlin console with underlying Titan DB

Has anyone ever attempted this ? I followed the titandb guides and was able to connect to the hbase storage backend with the table name “apache_atlas_titan” but the traversal is showing zero vertex. Here’s how I (supposedly) connected to the graph via the console graph = TitanFactory.build().se

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 2:38 a.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 35 > > > > > > updateEntity() is for full-update of an entity. A new API would be > >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

(line 50) <https://reviews.apache.org/r/51896/#comment218934> e.get(0) on map ? Getting NPEs because of this. - Apoorv Naik On Sept. 29, 2016, 4:08 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically gener

Review Request 52585: Implementation of the new TypesREST API

-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

t; Need to revert this. repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java (line 35) <https://reviews.apache.org/r/52585/#comment220043> This needs to be fixed - Apoorv Naik On Oct. 6, 2016, 12:14 a.m.,

Re: Review Request 52585: Implementation of the new TypesREST API

/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

g.io/spring-data/jpa/docs/1.11.0.M1/api/ - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151673 -----

Re: Review Request 52585: Implementation of the new TypesREST API

n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151761 --- On Oct. 6, 2016, 12:45 a.m., Apoorv Naik wrote: > > --- > This is an a

Re: Review Request 52585: Implementation of the new TypesREST API

/errorMessages.properties PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/errorMessages.properties PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/util/TypeValidator.java PRE-CREATION webapp/src/main/resources/errorMessages.properties PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

133line33> > > > > These are defined in Constants as well Will change. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151767

Re: Review Request 52585: Implementation of the new TypesREST API

/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

actor. Was next on my list. > On Oct. 7, 2016, 10 a.m., Shwetha GS wrote: > > webapp/src/main/java/org/apache/atlas/web/util/TypeValidator.java, line 38 > > <https://reviews.apache.org/r/52585/diff/7/?file=1526214#file1526214line38> > > > > There is a lot of valid

Re: Review Request 52585: Implementation of the new TypesREST API

think I can concurrently iterate and modify the map to achieve this. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151774 ----

Re: Review Request 52585: Implementation of the new TypesREST API

/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

f the behavior is not valid here. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151774 ------- On Oct. 7, 2016, 9:23 p.m., Apoorv Naik wrote: > > --

Re: Review Request 52585: Implementation of the new TypesREST API

e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review152161 ------- On Oct. 8, 2016, 5:28 a.m., Apoorv Naik wrote: > > ---

Re: Review Request 52585: Implementation of the new TypesREST API

--- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/rest/module/RestModule.java PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 58333: TypesREST to support creation in an update call

cially for types - so > > we can explicitly understand the intent of the operation as create or > > update for governance. > > Apoorv Naik wrote: > Yes that's correct. Let me revisit this and see if it makes more sense to > introduce a new endpoint for thi

Re: Review Request 58419: ATLAS-1707 : Atlas WUI on continues loading behind FireWall

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58419/#review172343 --- Ship it! Ship It! - Apoorv Naik On April 13, 2017, 3:20 p.m

Re: Review Request 57655: Javadocs and comment changes for Enunciate/Swagger

On April 19, 2017, 10:50 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57655/ > ---

Re: Review Request 58588: [ATLAS-1742] : Provide option in server side to exclude deleted entities in basic and fulltext search

/DiscoveryREST.java Lines 117 (patched) <https://reviews.apache.org/r/58588/#comment245687> Maybe just excludeDeleted - Apoorv Naik On April 20, 2017, 7:23 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e

Re: Review Request 58588: [ATLAS-1742] : Provide option in server side to exclude deleted entities in basic and fulltext search

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58588/#review172592 --- Ship it! Ship It! - Apoorv Naik On April 20, 2017, 7:23 p.m

Review Request 58746: ATLAS-1736: Type validations with special character handling

repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 7037d1eb Diff: https://reviews.apache.org/r/58746/diff/1/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 56724: ATLAS-1390: Add IBM Graph Support

this change. - Apoorv Naik On March 2, 2017, 10:17 p.m., Jeff Hagelberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 58746: ATLAS-1736: Type validations with special character handling

/GraphBackedTypeStoreTest.java c08bb881 Diff: https://reviews.apache.org/r/58746/diff/2/ Changes: https://reviews.apache.org/r/58746/diff/1-2/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Review Request 58833: Typedef validations during create/update

- repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 82465bfc Diff: https://reviews.apache.org/r/58833/diff/1/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Review Request 58803: ATLAS-1390: IBM graph implementation

, Apoorv Naik

Re: Review Request 58833: Typedef validations during create/update

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58833/#review173308 --- On April 28, 2017, 5:03 a.m., Apoorv Naik wrote: > > ---

Re: Review Request 58746: ATLAS-1736: Type validations with special character handling

/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java c08bb881 Diff: https://reviews.apache.org/r/58746/diff/2/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 58746: Type validations with special character handling

/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java c08bb881 Diff: https://reviews.apache.org/r/58746/diff/3/ Changes: https://reviews.apache.org/r/58746/diff/2-3/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 58833: Typedef validations during create/update

Diff: https://reviews.apache.org/r/58833/diff/2/ Changes: https://reviews.apache.org/r/58833/diff/1-2/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 58833: Typedef validations during create/update

gt; > It does not seem right to change the eror code like this - wouldn't it > > be better to set the code correctly when it is originally created - rather > > than fix it up later. > > Apoorv Naik wrote: > As per my experience with REST APIs I never saw a 404 during

Re: Review Request 58746: Type validations with special character handling

/repository/typestore/GraphBackedTypeStore.java 7037d1eb Diff: https://reviews.apache.org/r/58746/diff/4/ Changes: https://reviews.apache.org/r/58746/diff/3-4/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 58746: Type validations with special character handling

/diff/5/ Changes: https://reviews.apache.org/r/58746/diff/4-5/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 3161a0da Diff: https://reviews.apache.org/r/58945/diff/1/ Testing --- mvn clean package was successful with a 5 min speedup on my local mac laptop. Thanks, Apoorv Naik

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

--- mvn clean package was successful with a 5 min speedup on my local mac laptop. Thanks, Apoorv Naik

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

reply, visit: https://reviews.apache.org/r/58945/#review173702 ------- On May 3, 2017, 6:04 a.m., Apoorv Naik wrote: > > --- > This is an automatically

Review Request 58985: Type deletion should invalidate property key in titan

clean package and mvn clean install run successfully. Thanks, Apoorv Naik

Re: Review Request 58985: Type deletion should invalidate property key in titan

--- mvn clean package and mvn clean install run successfully. Thanks, Apoorv Naik

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

/58945/diff/2-3/ Testing --- mvn clean package was successful with a 5 min speedup on my local mac laptop. Thanks, Apoorv Naik

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

o generate > > the names with incrementing numbers would be more determinisic. > > Apoorv Naik wrote: > Makes sense, will add some deterministic logic here. Updated the code David. - Apoorv --- This is an automatical

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

ctTypeDef; > > === > > >>>>>>> theirs > > > > I also had other build problems - e.g. that (abstract class) > > GremlinExpressionFactory is not found. > > > > I hope this is helpful - if you need more information or i

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

/SecureEmbeddedServerTestBase.java 5d4ca972 Diff: https://reviews.apache.org/r/58803/diff/2/ Changes: https://reviews.apache.org/r/58803/diff/1-2/ Testing --- See https://reviews.apache.org/r/56724/ Thanks, Apoorv Naik

Re: Review Request 56724: ATLAS-1390: Add IBM Graph Support

> On May 4, 2017, 5:31 p.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java > > Line 84 (original) > > > > > > why was this removed? The executeGremlin call has cha

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

sit: https://reviews.apache.org/r/58945/#review173935 --- On May 4, 2017, 4:28 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated

Re: Review Request 58985: Type deletion should invalidate property key in titan

y bad, typo for the comparison. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58985/#review173954 --- On May 4, 2017, 4:26 p.m

Re: Review Request 58985: Type deletion should invalidate property key in titan

or cases map/array/entity. Let me check with Suma too. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58985/#review173954 ------- On May 4, 2017, 4:26 p.m., Apoorv Naik wrote: >

Re: Review Request 58985: Type deletion should invalidate property key in titan

/ Changes: https://reviews.apache.org/r/58985/diff/1-2/ Testing --- mvn clean package and mvn clean install run successfully. Thanks, Apoorv Naik

Re: Review Request 58985: Type deletion should invalidate property key in titan

apache.org/r/58985/#review174009 --- On May 4, 2017, 10:07 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.ap

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

/3-4/ Testing --- mvn clean package was successful with a 5 min speedup on my local mac laptop. Thanks, Apoorv Naik

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

is supposed to work. Good to know that you were able to get past the initial hurdles. The profile activation issue is a bit strange as on my system (mac os) I'm able to build titan1 and ibm-graph just by using JDK8. As per the Gremlin 2 syntax issue, your obser

Re: Review Request 58985: Type deletion should invalidate property key in titan

84ad72c8 Diff: https://reviews.apache.org/r/58985/diff/2/ Testing --- mvn clean package and mvn clean install run successfully. Thanks, Apoorv Naik

Re: Review Request 59264: ATLAS-1787: Replace explicit type with diamond operator

consistency ? - Apoorv Naik On May 14, 2017, 4:58 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls

modules and check if any unused dependency declaration exists. - Apoorv Naik On May 14, 2017, 3:57 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module

findbugs errors. Could you check on that too ? - Apoorv Naik On May 14, 2017, 12:20 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59261: ATLAS-1784: Use explicit imports instead of wildcards

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59261/#review174964 --- Ship it! Ship It! - Apoorv Naik On May 14, 2017, 11:56 a.m

Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module

> On May 15, 2017, 4:13 p.m., Apoorv Naik wrote: > > I think there are other modules too where there are quite a few findbugs > > errors. Could you check on that too ? > > Jan Hentschel wrote: > I already created a list, but it seems that there are too much errors

Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59262/#review174973 --- Ship it! Ship It! - Apoorv Naik On May 14, 2017, 12:20 p.m

Re: Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls

> On May 15, 2017, 4:12 p.m., Apoorv Naik wrote: > > Similarly here, would it be possible for you to go through all modules and > > check if any unused dependency declaration exists. > > Jan Hentschel wrote: > Thanks for the review. It seems that SLF4J is duplicat

Re: [QUESTION] Change Findbugs to fail a build on error

I think Nixon has a good point. I think it’s possible to configure apache Jenkins instance to fail any builds that add new issues. Let’s follow up with a PMC or Infra to make necessary changes to the Jenkins build job. On 5/15/17, 11:27 PM, "Nixon Rodrigues" wrote: >Jan, > >Appreciate your

Re: Review Request 59321: [ATLAS-1807] : Enhance DSL query to support "like" operator for wildcard searches

- > > (Updated May 16, 2017, 8:06 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1807 > https://issues.apache.org/jira/browse/ATLAS-1807 > > > Repository: atlas > &

Re: Review Request 59321: [ATLAS-1807] : Enhance DSL query to support "like" operator for wildcard searches

/GremlinExpressionFactory.java Line 313 (original), 317 (patched) <https://reviews.apache.org/r/59321/#comment248524> Is this intentional ? - Apoorv Naik On May 16, 2017, 8:06 p.m., Sarath Subramanian wrote: > > --- > This is a

Re: Review Request 59378: Basic Search Performance Improvement

/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java Lines 102 (patched) <https://reviews.apache.org/r/59378/#comment248894> Let's not use Whitebox in UT, ideally you never want to test the private methods directly only via a public method route. - Apoorv Naik On

Re: Review Request 56959: Import API: Added Support for Transforming Entities During Import

ypo repalce -> replace intg/src/main/java/org/apache/atlas/model/impexp/ImportTransform.java Lines 20 (patched) <https://reviews.apache.org/r/56959/#comment249201> I think it's better to use the Guava Function interface or java.util.Function interface as it's ex

  1   2   3   4   5   6   7   >