[BEAM-6862] Adding pyhamcrest library to python container

2019-03-21 Thread Mikhail Gryzykhin
Hi everyone, Recently, there was added a test for verifying metrics in python SDK ( PR-8038 ). This PR causes beam_PostCommit_Py_ValCont job to fail due to lack of pyhamcrest libr

Re: [PROPOSAL] commit granularity in master

2019-03-22 Thread Mikhail Gryzykhin
I agree with keeping history clean. Although, Small commits like address PR comments are useful during review process. They allow reviewer to see only new changes, not review whole diff again. Best to squash then before/on merge though. On Fri, Mar 22, 2019, 07:34 Ismaël Mejía wrote: > > I like

Re: Frequent failures on beam8

2019-03-25 Thread Mikhail Gryzykhin
Yifan is looking into this. On Mon, Mar 25, 2019 at 1:55 PM Boyuan Zhang wrote: > Hey all, > > Could anyone help take a look at beam8 > ? Seems like there are > many tests failed on beam8 owing to infra problems. > > Thanks! >

Re: Build blocking on

2019-03-26 Thread Mikhail Gryzykhin
I believe what happens is that testPy2Gcp actually runs integration tests that try to connect to GCP. Without having GCP cluster and configuration on your machine I'd expect these tests to fail. I'd say we should remove testPy2Gcp task from "build" task and explicitly keep it as integration test.

Debugging :beam-sdks-java-io-hadoop-input-format:test

2019-03-27 Thread Mikhail Gryzykhin
Hi everyone, I have a pre-commit job that fails on *:beam-sdks-java-io-hadoop-input-format:test* . Relevant PR. Target doesn't have any explicit log associated with it. Running sam

Re: New contributor

2019-03-27 Thread Mikhail Gryzykhin
Welcome Niklas. This is another location with useful resources for contributors: https://cwiki.apache.org/confluence/display/BEAM/Developer+Guides (contributor guide has link to this as well though) On Wed, Mar 27, 2019 at 10:54 AM Connell O'Callaghan wrote: > Welcome Niklas - given your backgr

Re: Frequent failures on beam8

2019-03-27 Thread Mikhail Gryzykhin
And another one. beam14 OOMs On Mon, Mar 25, 2019 at 5:54 PM Yifan Zou wrote: > the beam8 is disabled by now. > > On Mon, Mar 25, 2019 at 2:06 PM Mikhail Gryzykhin > wrote: > >> Yifan is looking into this. >> >> On Mon, Mar 25, 2019 at 1:55 PM Boyuan Zhang wro

Re: Debugging :beam-sdks-java-io-hadoop-input-format:test

2019-03-28 Thread Mikhail Gryzykhin
several times already? > > [1] https://github.com/apache/beam/pull/8000 > > On 27 Mar 2019, at 22:24, Mikhail Gryzykhin wrote: > > Hi everyone, > > I have a pre-commit job that fails on > *:beam-sdks-java-io-hadoop-input-format:test* > <https://builds.apache.org/

Re: Removing :beam-website:testWebsite from gradle build target

2019-04-01 Thread Mikhail Gryzykhin
+1 on this. I'd prefer to have this as pre-commit only. On Mon, Apr 1, 2019 at 9:09 AM Andrew Pilloud wrote: > +1 on this, particularly removing the dead link checker from default > tests. It is effectively testing that ~20 random websites are up. I wonder > if there is a way to limit it to loca

Re: Debugging :beam-sdks-java-io-hadoop-input-format:test

2019-04-02 Thread Mikhail Gryzykhin
Hi everyone, I created BEAM-6974 <https://issues.apache.org/jira/browse/BEAM-6974>. This test and beam-sdks-java-io-cassandra tests fail often in our Pre-Commit jobs. Can someone look into this? Thank you, Mikhail. On Thu, Mar 28, 2019 at 12:31 PM Mikhail Gryzykhin wrote: > I&#

Re: Quieten javadoc generation

2019-04-02 Thread Mikhail Gryzykhin
+1 to suppress warnings globally. If we care about an issue, it should be error. On Tue, Apr 2, 2019 at 5:38 AM Alexey Romanenko wrote: > +1 to suppress such warnings globally. IMO, usually, meaningful Javadoc > description is quite enough to understand what this method does. > > On 1 Apr 2019,

Re: ParDo Execution Time stat is always 0

2019-04-04 Thread Mikhail Gryzykhin
Hi everyone, Quick summary on python and Dataflow Runner: Python SDK already reports: - MSec - User metrics (int64 and distribution) - PCollection Element Count - Work on MeanByteCount for pcollection is ongoing here . Dataflow Runner: - all metrics liste

Comparison of Beam on X vs X

2019-04-15 Thread Mikhail Gryzykhin
Hi everyone, I've recently got curious of what are benefits/drawbacks for Beam on X vs X, where X is relevant runner (Spark, Hadoop, etc). I wonder, if anyone did similar research already and might have some documents/tables/references available? Sample topics of curiosity: * performance of simi

Re: New contributor to Beam

2019-04-17 Thread Mikhail Gryzykhin
Welcome! --Mikhail On Wed, Apr 17, 2019 at 9:58 AM Melissa Pashniak wrote: > > Welcome Cyrus! > > > On Wed, Apr 17, 2019 at 7:31 AM Jean-Baptiste Onofré > wrote: > >> Welcome ! >> >> Regards >> JB >> >> On 17/04/2019 16:05, Cyrus Maden wrote: >> > Hi all! >> > >> > My name's Cyrus and I'd like

Re: Removing Java Reference Runner code

2019-04-26 Thread Mikhail Gryzykhin
+1 to remove overall. We removed all tests for ULR already and when we did that, tests were red. Removing code base is a natural next step. It is a valid point that we should have a way to run portable pipelines locally with Python ULR. I don't believe that a Java person working with Java SDK sho

Re: [ANNOUNCE] New committer announcement: Mark Liu

2019-05-09 Thread Mikhail Gryzykhin
Congratulations Mark! *From: *Kenneth Knowles *Date: *Sun, Mar 24, 2019 at 9:40 PM *To: *dev Hi all, > > Please join me and the rest of the Beam PMC in welcoming a new committer: > Mark Liu. > > Mark has been contributing to Beam since late 2016! He has proposed 100+ > pull requests. Mark was in

Re: [ANNOUNCE] New PMC Member: Pablo Estrada

2019-05-14 Thread Mikhail Gryzykhin
Congratulations Pablo! On Tue, May 14, 2019, 20:25 Kenneth Knowles wrote: > Hi all, > > Please join me and the rest of the Beam PMC in welcoming Pablo Estrada to > join the PMC. > > Pablo first picked up BEAM-722 in October of 2016 and has been a steady > part of the Beam community since then. I

Re: Postcommit kiosk dashboard

2019-05-17 Thread Mikhail Gryzykhin
;>>> I suppose those are important if this may eventually replace the >>>> README as Thomas suggests. >>>> >>>> On Fri, Mar 15, 2019 at 2:18 AM Thomas Weise wrote: >>>> > >>>> > This is very nice! >>>> > >&

Proposal: Add permanent url to community metrics dashboard

2019-05-17 Thread Mikhail Gryzykhin
Hello everyone, Some time ago we started community metrics dashboard. However we never had added a permanent URL for it. This is really inconvenient to use, since only available way to access dashboard is by IP-address. In this tread I'd like to: 1. V

Re: Proposal: Add permanent url to community metrics dashboard

2019-05-17 Thread Mikhail Gryzykhin
wrote: > Hi Mikhail, > > I think this dashboard is amazing, and would love to have an easy access > to it. So here is my non binding +1. > > On the side note, how easy is to recreate it for other Apache projects? ;) > > Thanks, > Aizhamal > > *From: *Mikhail Gryzykhin

Re: Proposal: Add permanent url to community metrics dashboard

2019-05-20 Thread Mikhail Gryzykhin
t;beam metrics". I believe there is some > value in having a single domain and linking to various things from there. > This would be similar to how we link to jira, wiki, mailing list archives. > > Ahmet > > On Fri, May 17, 2019 at 9:26 PM Mikhail Gryzykhin < > gry

Re: Proposal: Add permanent url to community metrics dashboard

2019-05-21 Thread Mikhail Gryzykhin
will be good to check that we can set robots.txt properly from the > begging if we go down this path. > > On Mon, May 20, 2019 at 10:54 AM Mikhail Gryzykhin > wrote: > >> @Ahmet Altay >> Thank you for the comment. >> >> Point on search engines is really go

Re: Beam dashboards

2019-05-21 Thread Mikhail Gryzykhin
ting dashboards (IO tests, nexmark, currently developed load tests) with > this tool leveraging its more advanced features such as dynamic data > ranges, alerts, ad-hoc filters etc[1]? > > [1] https://grafana.com/grafana > > pon., 17 wrz 2018 o 19:14 Mikhail Gryzykhin > napisa

Quota: In use IP-adresses

2019-05-23 Thread Mikhail Gryzykhin
Hello everybody, Some of our jobs fail with 1/0 in use IP-addresses quota exception. Seems that we spin-up too many VMs and run out of IP-addresses. Should we bump the quota to mitigate the issue? Regards, Mikhail. --- https://issues.apache.org/jira/browse/BEAM-7410

Re: PubSubIT tests topic cleanup?

2019-05-24 Thread Mikhail Gryzykhin
Last time it was decided to manually cleanup topics and postpone fix. My estimate was that we need to cleanup topics about every two months. I think, we should cleanup topics manually to mitigate issue and prioritize proper fix. On Fri, May 24, 2019, 12:00 Pablo Estrada wrote: > Seems like Mikh

Re: [ANNOUNCE] New committer: Mikhail Gryzykhin

2019-06-24 Thread Mikhail Gryzykhin
nko@gmail.com> wrote: >>>>>>> >>>>>>>> Congrats, Mikhail! >>>>>>>> >>>>>>>> On 21 Jun 2019, at 18:01, Anton Kedin wrote: >>>>>>>> >>>>>>>> Con

Re: Using Grafana to display test metrics and alert anomalies

2019-06-26 Thread Mikhail Gryzykhin
Hi Łukasz, See answers inline. Regard, Mikhail. On Wed, Jun 26, 2019 at 7:47 AM Łukasz Gajowy wrote: > Hi Mikhail! > > Together with Kamil we're investigating the possibilities of creating > alerts for anomalies for the metrics collected from various tests (load, IO > tests, other performance

BQ IO GC thrashing when specifying .withMethod(STREAMING_INSERTS)

2019-07-01 Thread Mikhail Gryzykhin
Hello everybody, This question is regarding user post on StackOverflow . My understanding of problem is that setting .withMethod(STREAMING_INSERTS) on BigQueryIO sink causes GC thrashi

Re: [ANNOUNCE] New committer: Robert Burke

2019-07-16 Thread Mikhail Gryzykhin
Congratulations! On Tue, Jul 16, 2019 at 10:36 AM Ankur Goenka wrote: > Congratulations Robert! > > Go GO! > > On Tue, Jul 16, 2019 at 10:34 AM Rui Wang wrote: > >> Congrats! >> >> >> -Rui >> >> On Tue, Jul 16, 2019 at 10:32 AM Udi Meiri wrote: >> >>> Congrats Robert B.! >>> >>> On Tue, Jul 16

Re: Proposal: Add permanent url to community metrics dashboard

2019-07-17 Thread Mikhail Gryzykhin
gt;> >>> I suggest asking infra about the best way to proceed, so that we don't >>> vote on something that doesn't work for them. This might be something handy >>> to spin up easily for any Apache project using similar tools. >>> >>> Kenn >&g

Re: Proposal: Add permanent url to community metrics dashboard

2019-07-18 Thread Mikhail Gryzykhin
ut for eg. IOIT or load tests > resutls. > > Thanks! > > czw., 18 lip 2019 o 00:48 Mikhail Gryzykhin > napisał(a): > >> Thank you Alan, that's an interesting link. >> >> Latest Grafana version in docker is v6.2.5, so issues on that list are >> not app

Re: Proposal: Add permanent url to community metrics dashboard

2019-07-22 Thread Mikhail Gryzykhin
> Hi all, > I've filed https://issues.apache.org/jira/browse/INFRA-18786 for this. > Thanks! > -P. > > On Thu, Jul 18, 2019 at 1:38 PM Mikhail Gryzykhin > wrote: > >> +1 explicitly >> >> On Thu, Jul 18, 2019 at 1:46 AM Łukasz Gajowy &

Beam metrics update

2019-07-26 Thread Mikhail Gryzykhin
Hello everybody, I'm working on improving deployment scripts for beam metrics site and going to do some updates over the weekend. This might bring site down for short periods of time. Please respond to this message if you require metrics dashboards up

Re: [DISCUSS] Moving FakeBigQueryServices to main/ rather than test/

2019-07-30 Thread Mikhail Gryzykhin
+1 It is completely worth it. On Tue, Jul 30, 2019 at 8:50 PM Rui Wang wrote: > +1. > > I did something similar before: move TestBoundedTable to BeamSQL main to > allow another module tests use it. > > > -Rui > > On Tue, Jul 30, 2019 at 6:13 PM Pablo Estrada wrote: > >> Hello all, >> I found so

Dataflow worker overview graphs

2019-08-08 Thread Mikhail Gryzykhin
Hello everybody, Just wanted to share that I have found some graphs for dataflow worker I created while starting working on it. They cover specific scenarios, but may be useful for newcomers, so I put them into this wiki page

Re: Dataflow worker overview graphs

2019-08-08 Thread Mikhail Gryzykhin
able (fn_api) based streaming pipelines. > > > On Thu, Aug 8, 2019 at 2:08 PM Mikhail Gryzykhin > wrote: > >> Hello everybody, >> >> Just wanted to share that I have found some graphs for dataflow worker I >> created while starting working on it. They cover sp

Re: Hackathon @BeamSummit @ApacheCon

2019-09-06 Thread Mikhail Gryzykhin
I'll be in most of the week and will join gladly. On Thu, Sep 5, 2019, 14:32 Chad Dombrova wrote: > Has a date and time been picked for this? I'll be there for part of the > week and would love to join. > > On Tue, Sep 3, 2019 at 11:31 AM Brian Hulette wrote: > >> I will be around all week as

Re: Jenkins queue times steadily increasing for a few months now

2019-09-19 Thread Mikhail Gryzykhin
Hi Daniel, Generally this looks feasible since jobs wait for new worker to be available to start. Over time we added more tests and did not deprecate enough, this increases load on workers. I wonder if we can add something like total runtime of all running jobs? This will be a safeguard metric th

Re: Collecting feedback for Beam usage

2019-09-24 Thread Mikhail Gryzykhin
I'm with Luke on this. We can add a set of flags to send home stats and crash dumps if user agrees. If we keep code isolated, it will be easy enough for user to check what is being sent. One more heavy-weight option is to also allow user configure and persist what information he is ok with sharing

Re: [ANNOUNCE] New committer: Alan Myrvold

2019-09-30 Thread Mikhail Gryzykhin
Congratulations! On Mon, Sep 30, 2019 at 9:47 AM David Cavazos wrote: > Congratulations Alan! > > On Mon, Sep 30, 2019 at 7:57 AM Connell O'Callaghan > wrote: > >> Congratulations Alan - well done!!! Ahmet thank you for sharing this >> great news!!! >> >> On Mon, Sep 30, 2019 at 7:34 AM Łukasz

Beam failing tests digest

2018-08-27 Thread Mikhail Gryzykhin
Hi everyone, Heads up for everyone regarding currently open Jira tickets for post-commit tests failures.

Re: JB's back

2018-08-27 Thread Mikhail Gryzykhin
Welcome back JB! On Mon, Aug 27, 2018 at 11:10 PM Reuven Lax wrote: > Welcome back! > > On Mon, Aug 27, 2018 at 10:44 PM Jean-Baptiste Onofré > wrote: > >> Hi guys, >> >> Maybe you saw that I took some days off last week. I landed back last >> night, so, just time to unstack my e-mails and I'm

Get SSL certificate for dashboards

2018-08-29 Thread Mikhail Gryzykhin
Hi everyone, I have set up dashboards at https://104.154.241.245:80/d/D81lW0pmk/post-commit-jobs However now I want to add https for it. Can someone share knowledge on how can I get valid certificates? The self-signed one causes browser to show security alert. Regards, --Mikhail Have feedback <

Re: Get SSL certificate for dashboards

2018-08-29 Thread Mikhail Gryzykhin
t for https). You also need a hostname for a CA signed certificate. > Once you have those things setup, you should be able to get a certificate > from Let's Encrypt using certbot: https://certbot.eff.org/ > > Happy to help you get all this going, > > Andrew > > On W

Re: Get SSL certificate for dashboards

2018-08-29 Thread Mikhail Gryzykhin
ommon tool to use and refer to, we can look into extending the infrastructure. --Mikhail Have feedback <http://go/migryz-feedback>? On Wed, Aug 29, 2018 at 12:06 PM Mikhail Gryzykhin wrote: > Thank you Andrew, > > I've got same suggestion from Udi. Will follow that way.

Test set fails: beam_PostCommit_Python_PortableValidatesRunner_Flink_Gradle

2018-09-05 Thread Mikhail Gryzykhin
Hi everyone, We have added beam_PostCommit_Python_PortableValidatesRunner_Flink_Gradle job to Jenkins several days ago. However all of its runs have failed so far. Are we working on the fix, or can we dis

Failing: beam_PerformanceTests_Python

2018-09-06 Thread Mikhail Gryzykhin
Hi everyone, I see that beam_PerformanceTests_Python job is failing during last several days. Corresponding errors: 2 days ago it was failure in beam_integration_benchmark(1/1)

Re: Failing: beam_PerformanceTests_Python

2018-09-06 Thread Mikhail Gryzykhin
rized in > PR-6321 <https://github.com/apache/beam/pull/6321#issuecomment-418339689> > . > > But I didn't realize test failed in different error now. > > Mark > > On Thu, Sep 6, 2018 at 10:28 AM Mikhail Gryzykhin > wrote: > >> Hi everyone, >> >&

Java postcommit tests timeout due to flink jobs

2018-09-12 Thread Mikhail Gryzykhin
Hi everyone, We have ~50% java post-commit jobs timeout due to Flink tests. Can someone help look into the issue [BEAM-5337] ? Sample Job . More links available on the tic

Re: Java postcommit tests timeout due to flink jobs

2018-09-12 Thread Mikhail Gryzykhin
+Aljoscha for real. On Wed, Sep 12, 2018 at 10:25 AM Mikhail Gryzykhin wrote: > Hi everyone, > > We have ~50% java post-commit jobs timeout due to Flink tests. Can someone > help look into the issue [BEAM-5337] > <https://issues.apache.org/jira/browse/BEAM-5337>? &g

Re: Java postcommit tests timeout due to flink jobs

2018-09-13 Thread Mikhail Gryzykhin
gryz-feedback>? On Wed, Sep 12, 2018 at 10:47 AM Maximilian Michels wrote: > Missed that issue. I can look into this tomorrow. > > On 12.09.18 19:27, Mikhail Gryzykhin wrote: > > +Aljoscha for real. > > > > On Wed, Sep 12, 2018 at 10:25 AM Mikhail Gryzykhin > <

Beam dashboards

2018-09-13 Thread Mikhail Gryzykhin
Hi everyone, Huygaa and me are working on creating dashboards for Beam. So far I created a POC dashboard for post-commit greenness that includes a list of latest failed jobs and dashboard for pre-commits

Re: Beam dashboards

2018-09-17 Thread Mikhail Gryzykhin
il for sharing this and to everyone involved in these > > improvements!!! It will be great to hear about progress and any blockers > > encountered with this work. > > > > On Thu, Sep 13, 2018 at 11:12 AM Mikhail Gryzykhin > <mailto:mig...@google.com>> wrote: >

Re: [ANNOUNCEMENT] New Beam chair: Kenneth Knowles

2018-09-20 Thread Mikhail Gryzykhin
Contratulations Kenn! --Mikhail Have feedback ? On Thu, Sep 20, 2018 at 11:19 AM Scott Wegner wrote: > Congrats, Kenn! > > On Thu, Sep 20, 2018 at 10:46 AM Daniel Oliveira > wrote: > >> Congrats Kenn! Sounds like you deserve it! >> >> On Thu, Sep 20, 2018 at 10:20

Re: Beam Dependency Check Report (2018-10-01)

2018-10-01 Thread Mikhail Gryzykhin
Hi everyone, Is this report supposed to be empty? Regards, --Mikhail Have feedback ? On Mon, Oct 1, 2018 at 5:07 AM Apache Jenkins Server < jenk...@builds.apache.org> wrote: >

Re: Does anyone have a strong intelliJ setup?

2018-10-03 Thread Mikhail Gryzykhin
@Scott Wegner Would be really great if we can get good hints. However I would suggest to update corresponding page on cwiki, not website. It will be easier to maintain that one up-to-date. Some of tips already present there. https://cwiki.apache.org/confluence/display/BEAM/IntelliJ+Tips Regards

Re: A new contributor

2018-10-04 Thread Mikhail Gryzykhin
I believe this list will also require: * Access to: https://cwiki.apache.org/confluence/display/BEAM/ \ Sam, please create account, then ping here so that committer grants you access rights. (I believe this is correct order) * Refresh link to join Slack. I've invited Sam directly. Since we

Re: A new contributor

2018-10-04 Thread Mikhail Gryzykhin
UPD: I've assembled this list here, so that this becomes a reference for docs update. --Mikhail Have feedback <http://go/migryz-feedback>? On Thu, Oct 4, 2018 at 4:43 PM Mikhail Gryzykhin wrote: > I believe this list will also require: > > * Access to: https://cwiki.a

Re: python post-commit failures

2018-10-08 Thread Mikhail Gryzykhin
Is it possible to add component/unit test for this case? I believe we should aim for all precommits to be executable on isolated singlebox. Regards, --Mikhail On Mon, Oct 8, 2018, 09:27 Udi Meiri It's the current status: I believe having a basic wordcount integration > test in precommit would h

Re: [DISCUSS] - Separate JIRA notifications to a new mailing list

2018-10-11 Thread Mikhail Gryzykhin
+1. Should we separate Jenkins notifications as well? On Thu, Oct 11, 2018, 08:59 Scott Wegner +1, commits@ is too noisy to be useful currently. > > On Thu, Oct 11, 2018 at 8:04 AM Maximilian Michels wrote: > >> +1 >> >> I guess most people have already filters in place to separate commits >> an

Java compilation errors

2018-10-11 Thread Mikhail Gryzykhin
Hi everyone, Just a heads up: I see that Java builds have compilation failures. Can someone help look into this please? Unfortunately, I don't have time to look into it myself atm. Regards, --Mikhail Have feedback ?

Java postcommits duration almost hit 4 hours

2018-10-12 Thread Mikhail Gryzykhin
Hi everyone, I just wanted to highlight an interesting fact: Our java postcommits duration almost *doubled* since last week rising from 2.2 to nearly 4 hours. (See bottom-left graph on this dashboard ) We might want to check on the te

Re: [DISCUSS] Separate Jenkins notifications to a new mailing list

2018-10-15 Thread Mikhail Gryzykhin
+1 also suggested that in another thread. --Mikhail Have feedback ? On Mon, Oct 15, 2018 at 11:10 AM Rui Wang wrote: > +1 > > Agree that people might be only interested in JIRA activities but not in > the build. > > > -Rui > > On Mon, Oct 15, 2018 at 10:27 AM Andrew

Re: python tests run as part of 'javaPreCommit'

2018-10-16 Thread Mikhail Gryzykhin
Can we do a separate targets for integration, component and unittests? Ideally with different locations of test code. Bundling things together makes it hard to navigate. It also makes it cleaner when we separate relevant code. --Mikhail Have feedback ? On Tue, Oct 16

Re: [DISCUSS] Committer Guidelines / Hygene before merging PRs

2018-10-16 Thread Mikhail Gryzykhin
+1 in general. However, I'd suggest to use "rebase and merge" more often. Otherwise reading history is really inconvenient. Like in attached screenshot. You can never easily understand what is included in any of previous commits of remotes/upstream/master, unless you do explicit git log on those a

INSTANCE_GROUP_MANAGERS quota limit exceeded

2018-11-02 Thread Mikhail Gryzykhin
Hi everyone, I was looking through (now 33) tickets open based on our post-commit tests failures and noticed one interesting. Test failed due to INSTANCE_GROUP_MANAGERS quota exceeding. BEAM-5938 Thank you Daniel for triaging failure. Even though

Re: [DISCUSS] Reverting commits on green post-commit status

2018-11-20 Thread Mikhail Gryzykhin
Following the discussion, we are discussing as how to address failures on external projects caused by changes to Beam project. I believe that that rollback first in case of red pre/postcommit tests is a valid option, since it blocks Beam development process. In case if downstream project has test

Add code quality checks to pre-commits.

2019-01-03 Thread Mikhail Gryzykhin
Hi everyone, In our current builds we (can) run multiple code quality checks tools like checkstyle, findbugs, code test coverage via cubertura. However we do not utilize many of those signals. I suggest to add requirements to code based on those tools. Specifically, I suggest to add pre-commit ch

Re: Add code quality checks to pre-commits.

2019-01-03 Thread Mikhail Gryzykhin
repo: >> https://scan.coverity.com/projects/11881 >> >> On Thu, Jan 3, 2019 at 1:27 PM Reuven Lax wrote: >> >>> checkstyle and findbugs are already run as precommit checks, are they >>> not? >>> >>> On Thu, Jan 3, 2019 at 7:19 PM Mik

Re: workspace cleanups needed on jenkins master

2019-01-03 Thread Mikhail Gryzykhin
; A few weeks back I suggested removing the --info flag passed to Gradle. > I haven't done that yet, but it might help reduce the size of logs. (which > I assume are all stored on master?) > > Short-term, we could reduce retention back down to 14 instead of the current >

Re: Add code quality checks to pre-commits.

2019-01-07 Thread Mikhail Gryzykhin
also import data into >>> > s.apache.org/beam-community-metrics < >>> http://s.apache.org/beam-community-metrics> >>> > >>> > > 4. Tool should encorporate code coverage and static analysis >>> reports. (Or >>> >

Re: Add code quality checks to pre-commits.

2019-01-08 Thread Mikhail Gryzykhin
gt;> wrote: >> > >> > I am pretty sure the build cache is not in use on Jenkins. It would >> have to >> > live somewhere persisted across runs, which I don't think is >> default. And >> > we'd be seeing much lower build times.

Re: [DISCUSS] (Forked thread) Beam issue triage & assignees

2019-01-10 Thread Mikhail Gryzykhin
+1 to keep issues unassigned and reevaluate backlog from time to time. We can also auto-unassign if there was no activity on ticket for N days. Or we can have auto-mailed report that highlights stale assigned issues. On Thu, Jan 10, 2019 at 12:10 AM Robert Bradshaw wrote: > On Thu, Jan 10, 2019

Re: Add all tests to release validation

2019-01-10 Thread Mikhail Gryzykhin
+1 Although we should be cautious when enabling this policy. We have decent backlog of bugs that we need to plumb through. --Mikhail Have feedback ? On Thu, Jan 10, 2019 at 11:44 AM Scott Wegner wrote: > +1, this sounds good to me. > > I believe the next step would

:beam-sdks-python:docs fails with docs invocation failure

2019-01-22 Thread Mikhail Gryzykhin
Hi everyone, I see python precommit tests fail with no such option: --process-dependency-links Supposedly when invoking pip install. Examples: https://builds.apache.org/job/beam_PreCommit_Python_Commit/3752/console https://builds.apache.org/job/beam_PreCommit_Python_Phrase/152/console More ca

Re: Findbugs -> Spotbugs ?

2019-01-31 Thread Mikhail Gryzykhin
+1 for spotbugs On Thu, Jan 31, 2019, 10:38 Udi Meiri wrote: > +1 for spotbugs > > On Thu, Jan 31, 2019 at 5:09 AM Gleb Kanterov wrote: > >> Agree, spotbugs brings static checks that aren't covered in error-prone, >> it's a good addition. There are few conflicts between error-prone and >> spotb

Re: Another new contributor!

2019-01-31 Thread Mikhail Gryzykhin
Welcome to the community! On Thu, Jan 31, 2019, 16:50 Alex Amato wrote: > Great to start working with you Brian, welcome. > > On Thu, Jan 31, 2019 at 4:23 PM Brian Hulette wrote: > >> Can I get bhulette@ added to the BEAM project in Jira? >> >> Gleb - I'd definitely be interested in seeing that

Resource usage exceeded: topics-per-project

2019-02-06 Thread Mikhail Gryzykhin
Hi everyone, Our python pipelines failed with limit exceeded error : ResourceExhausted: 429 Your project has exceeded a limit: (type="topics-per-project", current=1, maximum=1). Does anyone know if there were new

Re: Resource usage exceeded: topics-per-project

2019-02-06 Thread Mikhail Gryzykhin
Minor UPD: As expected it fails most of our test jobs, since we use Pub/Subs in many tests. --Mikhail Have feedback <http://go/migryz-feedback>? On Wed, Feb 6, 2019 at 7:38 AM Mikhail Gryzykhin wrote: > Hi everyone, > > Our python pipelines failed with limit exceeded

Re: Resource usage exceeded: topics-per-project

2019-02-06 Thread Mikhail Gryzykhin
teg-test-PubsubJsonIT-testSQLLimit-2018-08-27-16-55-44-342-start-7392789257486934721?project=apache-beam-testing>. Seems we do not cleanup properly. Is it safe to cleanup topics with this name? --Mikhail Have feedback <http://go/migryz-feedback>? On Wed, Feb 6, 2019 at 7:46 AM Mikhail

Re: Resource usage exceeded: topics-per-project

2019-02-06 Thread Mikhail Gryzykhin
e. > > Andrew > > On Wed, Feb 6, 2019, 8:01 AM Mikhail Gryzykhin wrote: > >> +Kenneth Knowles you're working on SQL recently, so >> might provide some info. >> >> I see a lot of topics of format >> rojects/apache-beam-testing/topics/integ-t

Re: master broken (findBugs)

2019-02-08 Thread Mikhail Gryzykhin
created BEAM-6637 <https://issues.apache.org/jira/browse/BEAM-6637> to track this. --Mikhail Have feedback <http://go/migryz-feedback>? On Fri, Feb 8, 2019 at 1:52 PM Mikhail Gryzykhin wrote: > +Ismael (commit author) explicitly > > --Mikhail > > Have feedback

Re: master broken (findBugs)

2019-02-08 Thread Mikhail Gryzykhin
+Ismael (commit author) explicitly --Mikhail Have feedback ? On Fri, Feb 8, 2019 at 10:47 AM Michael Luckey wrote: > Hi, > > currently PRs are failing due to > > *19:14:30* FAILURE: Build completed with 2 failures.*19:14:30* *19:14:30* 1: > Task failed with an exce

FYI: beam11 bad worker

2019-02-11 Thread Mikhail Gryzykhin
Hi everyone, Small update: We have a bad jenkins executor that fails all builds. You might experience pre/post commit failures. Yifan follows up on this. Regards, --Mikhail Have feedback ?

Re: Searching Jenkins for particular test failures

2019-02-13 Thread Mikhail Gryzykhin
You can look at this url: https://builds.apache.org/job/beam_PreCommit_Java_Phrase/718/testReport/junit/org.apache.beam.runners.fnexecution.data/GrpcDataServiceTest/testMessageReceivedBySingleClientWhenThereAreMultipleClients/history/ to get there failed job -> test result -> navigate to failed te

Re: Beam Community Metrics

2019-02-19 Thread Mikhail Gryzykhin
Hi everyone, Regarding empty list of dashboards: Most likely you're looking at recently viewed dashboards. Top-left corner has a drop-down menu with full list of available dashboards. I've added explicit ticket to add landing page. Regarding hardc

Re: Beam Jenkins job summary available in .test-infra/jenkins/REAMDE.md

2019-02-26 Thread Mikhail Gryzykhin
This looks nice. Would also be great if we can add links to docs on how to re-run relevant job/tests on local machine. Regards, --Mikhail Have feedback ? On Mon, Feb 25, 2019 at 9:38 AM Mark Liu wrote: > Glad to hear that! > > Thanks, > Mark > > On Sat, Feb 16, 201

Re: New Contributor

2019-03-05 Thread Mikhail Gryzykhin
Welcome to the community! --Mikhail Have feedback ? On Tue, Mar 5, 2019 at 1:53 PM Ruoyun Huang wrote: > Welcome Boris! > > On Tue, Mar 5, 2019 at 1:34 PM Ahmet Altay wrote: > >> Welcome Boris! >> >> On Mon, Mar 4, 2019 at 5:40 PM Ismaël Mejía wrote: >> >>> Done,

Python precommit duration is above 1hr

2019-03-08 Thread Mikhail Gryzykhin
Hi everyone, Seems that our python pre-commits grow up in time really fast . Did anyone follow trend or know what are the biggest changes that happened with python lately? I don't see a single jump, but durat

Re: Python precommit duration is above 1hr

2019-03-11 Thread Mikhail Gryzykhin
r at least most) previously >>> existing tests for running under Python 3. I agree that this is excessive; >>> we should probably split out Py2, Py3, and the linters into separate >>> targets. >>> >>> We could look into using detox or retox to parallelize the

Re: Build broken: repo.spring.io is down

2019-03-12 Thread Mikhail Gryzykhin
I tried to replace repo.sprint.io with mavenCentral() that seem to have relevant plugin (propdeps-plugin in my case), but gradle still fails to

Re: Build broken: repo.spring.io is down

2019-03-12 Thread Mikhail Gryzykhin
this line and it built fine: > https://github.com/apache/beam/blob/c41e4fbbeb6ec622a0072e01afcba95428faafb9/buildSrc/src/main/groovy/org/apache/beam/gradle/Repositories.groovy#L44 > > Kyle Weaver | Software Engineer | kcwea...@google.com | +1650203 > > > On Tue, Mar 12, 2019 a

Postcommit kiosk dashboard

2019-03-14 Thread Mikhail Gryzykhin
Hi everyone, I've added a kiosk style post-commit status dashboard that can help decorate your office space with green

Re: Postcommit kiosk dashboard

2019-03-14 Thread Mikhail Gryzykhin
that you've added. > > Let's make these more discoverable. How about adding a shortlink? > s.apache.org/beam-dash ? : ) > Best > -P. > > On Thu, Mar 14, 2019 at 10:58 AM Mikhail Gryzykhin > wrote: > >> Hi everyone, >> >> I've added

Python PVR Reference post-commit tests failing

2019-03-14 Thread Mikhail Gryzykhin
Hi everyone, We have Python PVR Reference post-commit tests failing for quite some time now. These are tests for java reference runner. According to this thread , we are decidi

Re: JIRA hygiene

2019-03-14 Thread Mikhail Gryzykhin
I believe that there are too many scenarios that we have to cover if we are to design a generic approach. Common pattern I've seen most times is when assignee on the ticket, who's usually author of relevant PR, is expected to either resolve ticket or pass it to the feature owner for verification.

Re: Postcommit kiosk dashboard

2019-03-14 Thread Mikhail Gryzykhin
about adding a shortlink? >> s.apache.org/beam-dash ? : ) >> Best >> -P. >> >> On Thu, Mar 14, 2019 at 10:58 AM Mikhail Gryzykhin >> wrote: >> >>> Hi everyone, >>> >>> I've added a kiosk style >>> <http://104.154

Re: Postcommit kiosk dashboard

2019-03-14 Thread Mikhail Gryzykhin
ar 14, 2019 at 12:03 PM Michael Luckey wrote: > Very nice! > > Two questions though: > - the links on the left should point somewhere? > - where are the beam_PostCommit_[Java|GO]_GradleBuild coming from? Cant > find them on Jenkins... > > On Thu, Mar 14, 2019 at 7:20 PM

Re: Python PVR Reference post-commit tests failing

2019-03-14 Thread Mikhail Gryzykhin
How about this compromise: >> >> 1. disable the test since clearly no one is relying on the functionality >> that is broken >> 2. leave the Java ULR as-is for now, and a volunteer can pick it up and >> make it work if they want >> >> Kenn >> >> On

Re: [VOTE] Sign a pledge to discontinue support of Python 2 in 2020.

2019-10-02 Thread Mikhail Gryzykhin
+1 On Tue, Oct 1, 2019 at 6:24 PM Ankur Goenka wrote: > +1 > > On Tue, Oct 1, 2019 at 4:27 PM Ruoyun Huang wrote: > >> +1 >> >> On Tue, Oct 1, 2019 at 3:52 PM Rui Wang wrote: >> >>> +1 >>> >>> I needed to use https://python3statement.org to access the website BTW >>> (https, not http). >>> >>>

  1   2   >