[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127645880 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# -- #

[GitHub] jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127652015 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# --

[GitHub] sigee opened a new issue #247: Missing JavaDoc for classes

sigee opened a new issue #247: Missing JavaDoc for classes URL: https://github.com/apache/bookkeeper/issues/247 **JavaDoc needed** The classes should have JavaDoc comment. There are a couple of places where it is missing. Those places are marked by @TODO: Write JavaDoc comment. ---

Re: Regarding the configuration in BK docker image # PR 197

Thanks Jia for bringing the discussion on the list. In my opinion, the script could be useful in order to having a flexible way to altering bk_server.conf at container creation. It currently lacks commented out properties handling, so in order to be effective we need to fix that. Maybe we can e

[GitHub] eolivelli commented on issue #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file

eolivelli commented on issue #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/pull/246#issuecomment-315707485 @sijie take too long to complete and Travis is not happy. Maybe we should eork on making tests faster on re

Bookie Http Endpoint

Hi all, A discussion has been started about introducing an HTTP endpoint to the bookie. There has been a proposal from Twitter and this is the patch https://github.com/apache/bookkeeper/pull/210 On Salesforce there is an ongoing implementation too. I have added that we should provide a Servlet base

[GitHub] ivankelly commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

ivankelly commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127737596 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= ca

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127750910 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= caiok/

[GitHub] sijie commented on a change in pull request #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA

sijie commented on a change in pull request #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA URL: https://github.com/apache/bookkeeper/pull/238#discussion_r127797369 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java ## @@ -47,6 +47

[GitHub] sijie commented on issue #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file

sijie commented on issue #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/pull/246#issuecomment-315854380 a few comments: 1) currently we only used travis ci for verifying pull requests (e.g. findbugs and checkst

[GitHub] sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127800142 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLedgerTest

[GitHub] sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127800976 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ##

Re: Bookie Http Endpoint

+ Yiming I would suggest the people who already started the implementations (either from Twitter or Salesforce) taking the lead. because they either already had the implementation or are working on the implementation. I think the goal is to consolidate existing implementations to see if we can hav

Re: BookKeeper and code-coverage - JaCoco

On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli wrote: > I have just committed coveralls.io and cobertura plugins into main pom.xml > (as DistributedLog does) > The next step is to enable cobertura and tests in Travis. > Currently we do not run tests on Travis because it is very slow. > any

Re: BookKeeper and code-coverage - JaCoco

Adding Dustin to the thread. On Wed, Jul 5, 2017 at 12:57 AM, Enrico Olivelli wrote: > I am attaching a report (I am using Google Drive as most email clients will > block attachments with html inside) . > Just untar and play with your browser > > > 2017-07-04 18:18 GMT+02:00 Dávid Szigecsán : >

Re: Bookie Http Endpoint

+ Dustin On Mon, Jul 17, 2017 at 12:30 PM, Sijie Guo wrote: > + Yiming > > I would suggest the people who already started the implementations (either > from Twitter or Salesforce) taking the lead. because they either already > had the implementation or are working on the implementation. I think

Re: Bookie Http Endpoint

Hey all, So I did define a little endpoint that can be used for multiple things on our end. Basically it spins up a jetty server, attaches a handler, and then maps that handler to a class. Within that class, you can add methods and map them using the Jersey API where you'd "decorate" methods wit

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124877448 ## File path: bookkeeper-server/bin/bookkeeper ## @@ -207,9 +207,9 @@ if [ $COMMAND == "bookie" ]; then eli

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124879315 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@ -167,14 +1

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124881795 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java ## @@

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124879149 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@ -142,11 +1

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124881543 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java ## @@ -272

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124879742 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@ -317,10 +3

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124883612 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/auth/TestAuth.java ## @@ -585,8 +583,7

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124878483 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -509,9 +509,12

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124879701 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@ -303,12 +3

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124883485 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/auth/TestAuth.java ## @@ -529,7 +526,7

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124883532 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/auth/TestAuth.java ## @@ -549,6 +546,7

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124877839 ## File path: bookkeeper-server/certs/keyStoreClientPassword.txt ## @@ -0,0 +1 @@ +client Review comment:

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124879507 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@ -272,28 +2

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124879648 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@ -303,12 +3

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124883909 ## File path: bookkeeper-server/certs/keyStoreServerPassword.txt ## @@ -0,0 +1 @@ +server Review comment:

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124878773 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java ## @@ -255,7 +

[GitHub] eolivelli commented on a change in pull request #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA

eolivelli commented on a change in pull request #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA URL: https://github.com/apache/bookkeeper/pull/238#discussion_r127816511 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java ## @@ -47,6

[GitHub] sijie commented on a change in pull request #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA

sijie commented on a change in pull request #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA URL: https://github.com/apache/bookkeeper/pull/238#discussion_r127816716 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java ## @@ -47,6 +47

[GitHub] eolivelli commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

eolivelli commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127819418 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

Re: BookKeeper and code-coverage - JaCoco

Il lun 17 lug 2017, 21:34 Sijie Guo ha scritto: > On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli > wrote: > > > I have just committed coveralls.io and cobertura plugins into main > pom.xml > > (as DistributedLog does) > > The next step is to enable cobertura and tests in Travis. > > Currently

[GitHub] sijie closed issue #208: Improve fencing logic

sijie closed issue #208: Improve fencing logic URL: https://github.com/apache/bookkeeper/issues/208 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL ab

[GitHub] sijie closed pull request #205: Issue 208: Improve ledger fence logic

sijie closed pull request #205: Issue 208: Improve ledger fence logic URL: https://github.com/apache/bookkeeper/pull/205 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] sijie commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth

sijie commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth URL: https://github.com/apache/bookkeeper/pull/229#discussion_r127821482 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.

[GitHub] sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127822352 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ##

[GitHub] sijie closed pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth

sijie closed pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth URL: https://github.com/apache/bookkeeper/pull/229 This is an automated message from the Apache Git Service. To respond to th

[GitHub] sijie closed issue #228: BookKeeper Server: Index Page Management Memory Growth

sijie closed issue #228: BookKeeper Server: Index Page Management Memory Growth URL: https://github.com/apache/bookkeeper/issues/228 This is an automated message from the Apache Git Service. To respond to the message, please

Re: BookKeeper and code-coverage - JaCoco

On Tue, Jul 18, 2017 at 4:46 AM, Enrico Olivelli wrote: > Il lun 17 lug 2017, 21:34 Sijie Guo ha scritto: > > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli > > wrote: > > > > > I have just committed coveralls.io and cobertura plugins into main > > pom.xml > > > (as DistributedLog does) > >

[GitHub] sijie commented on issue #231: Add Checkstyle to the build process (Part 1)

sijie commented on issue #231: Add Checkstyle to the build process (Part 1) URL: https://github.com/apache/bookkeeper/pull/231#issuecomment-315882164 FYI. I changed the title of this pull request to avoid closing #230 (since #230 is a master ticket). --

Build failed in Jenkins: bookkeeper-master #1818

See -- [...truncated 781.25 KB...] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.127 sec - in org.apache.bookkeeper.bookie.TestLedgerDirsManager Running org.apache.

[GitHub] sijie closed pull request #231: Add Checkstyle to the build process (Part 1)

sijie closed pull request #231: Add Checkstyle to the build process (Part 1) URL: https://github.com/apache/bookkeeper/pull/231 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] sijie commented on issue #230: Add Checkstyle to the build process

sijie commented on issue #230: Add Checkstyle to the build process URL: https://github.com/apache/bookkeeper/issues/230#issuecomment-315883164 #231 is merged. This is an automated message from the Apache Git Service. To respo

[GitHub] sijie commented on issue #234: Issue 230: Add Checkstyle to the build process (Part 2)

sijie commented on issue #234: Issue 230: Add Checkstyle to the build process (Part 2) URL: https://github.com/apache/bookkeeper/pull/234#issuecomment-315884303 @sigee do you mind rebasing this pull request? after that, we can merge it.

[GitHub] sijie closed issue #237: Upgrade to ZooKeeper 3.5.3-BETA

sijie closed issue #237: Upgrade to ZooKeeper 3.5.3-BETA URL: https://github.com/apache/bookkeeper/issues/237 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] sijie closed pull request #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA

sijie closed pull request #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA URL: https://github.com/apache/bookkeeper/pull/238 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie commented on issue #224: BOOKKEEPER-772: Reorder Read Sequence

sijie commented on issue #224: BOOKKEEPER-772: Reorder Read Sequence URL: https://github.com/apache/bookkeeper/pull/224#issuecomment-315887331 @jiazhai ah, this change was based on #220 so we need #220 to be merged first. but anyway, I am going to address the comments as part of #220. ---

[GitHub] sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127828574 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java #

[GitHub] sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127828548 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java #

[GitHub] sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127828802 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.jav

[GitHub] sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127829034 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntr

[GitHub] sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

sijie commented on a change in pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220#discussion_r127829654 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java #

Re: Question regarding Synchronization in InterleavedLedgerStorage

On Fri, Jul 14, 2017 at 6:00 PM, Sijie Guo wrote: > > > On Sat, Jul 15, 2017 at 8:06 AM, Charan Reddy G > wrote: > >> Hey, >> >> In InterleavedLedgerStorage, since the initial version of it ( >> https://github.com/apache/bookkeeper/commit/4a94ce1d8184f5f >> 38def015d80777a8113b96690 and https://

[GitHub] sijie closed pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes

sijie closed pull request #220: BOOKKEEPER-1095: Long Poll - Server and Client Side Changes URL: https://github.com/apache/bookkeeper/pull/220 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] eolivelli commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

eolivelli commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127830794 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

[jira] [Resolved] (BOOKKEEPER-670) Longpoll Read & Piggyback Support

[ https://issues.apache.org/jira/browse/BOOKKEEPER-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-670. -- Resolution: Fixed all the long poll changes are merged. > Longpoll Read & Piggyback Support

[jira] [Resolved] (BOOKKEEPER-1094) Long Poll - Server and Client Side Changes

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-1094. --- Resolution: Fixed This is merged at master 1b79adaae7ffd4736530bd1088b45de8ac049f98 and

[jira] [Commented] (BOOKKEEPER-1016) Create documentation for JAAS and Kerberos configuration

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090602#comment-16090602 ] Sijie Guo commented on BOOKKEEPER-1016: --- [~eolivelli] are you working on this?

[jira] [Resolved] (BOOKKEEPER-981) NullPointerException in RackawareEnsemblePlacementPolicy while running in Docker Container

[ https://issues.apache.org/jira/browse/BOOKKEEPER-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-981. -- Resolution: Won't Fix Assignee: (was: Enrico Olivelli) Close it because it seems t

[jira] [Assigned] (BOOKKEEPER-915) Auto replication should honor ensemble placement policy

[ https://issues.apache.org/jira/browse/BOOKKEEPER-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo reassigned BOOKKEEPER-915: Assignee: Sijie Guo (was: Siddharth Sunil Boobna) > Auto replication should honor ense

[jira] [Assigned] (BOOKKEEPER-853) Use integer for entry log id

[ https://issues.apache.org/jira/browse/BOOKKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo reassigned BOOKKEEPER-853: Assignee: (was: Ankur Garg) > Use integer for entry log id > --

[jira] [Updated] (BOOKKEEPER-853) Use integer for entry log id

[ https://issues.apache.org/jira/browse/BOOKKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-853: - Fix Version/s: (was: 4.5.0) > Use integer for entry log id >

[jira] [Commented] (BOOKKEEPER-853) Use integer for entry log id

[ https://issues.apache.org/jira/browse/BOOKKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090604#comment-16090604 ] Sijie Guo commented on BOOKKEEPER-853: -- removed it from 4.5.0 and unassigned sinc

[jira] [Assigned] (BOOKKEEPER-1016) Create documentation for JAAS and Kerberos configuration

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned BOOKKEEPER-1016: --- Assignee: Enrico Olivelli > Create documentation for JAAS and Kerberos c

[jira] [Commented] (BOOKKEEPER-929) In ReadOnlyLedgerHandle, metadata gets updated in the event of writeclose but lastAddConfirmed and length is not getting updated.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090607#comment-16090607 ] Sijie Guo commented on BOOKKEEPER-929: -- [~jujjuri] do you guys have any patch for

[jira] [Commented] (BOOKKEEPER-31) Need a project logo

[ https://issues.apache.org/jira/browse/BOOKKEEPER-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090615#comment-16090615 ] Sijie Guo commented on BOOKKEEPER-31: - [~breed] [~fpj] [~ikelly] by any chance, do

[jira] [Comment Edited] (BOOKKEEPER-31) Need a project logo

[ https://issues.apache.org/jira/browse/BOOKKEEPER-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090615#comment-16090615 ] Sijie Guo edited comment on BOOKKEEPER-31 at 7/17/17 9:39 PM: ---

[jira] [Commented] (BOOKKEEPER-1016) Create documentation for JAAS and Kerberos configuration

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090626#comment-16090626 ] Enrico Olivelli commented on BOOKKEEPER-1016: - Sure i will finish the ZK

Re: BookKeeper and code-coverage - JaCoco

Il lun 17 lug 2017, 22:55 Sijie Guo ha scritto: > On Tue, Jul 18, 2017 at 4:46 AM, Enrico Olivelli > wrote: > > > Il lun 17 lug 2017, 21:34 Sijie Guo ha scritto: > > > > > On Sun, Jul 16, 2017 at 8:06 PM, Enrico Olivelli > > > wrote: > > > > > > > I have just committed coveralls.io and cobertu

[GitHub] sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

sijie commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127842876 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ##

[jira] [Assigned] (BOOKKEEPER-1027) Cleanup main README and main website page

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo reassigned BOOKKEEPER-1027: - Assignee: Sijie Guo (was: Enrico Olivelli) > Cleanup main README and main website p

[GitHub] sijie opened a new pull request #248: BOOKKEEPER-1027: Cleanup README

sijie opened a new pull request #248: BOOKKEEPER-1027: Cleanup README URL: https://github.com/apache/bookkeeper/pull/248 Descriptions of the changes in this PR: - Move README to README.md (written it in markdown syntax) - Organized the README as below: - what is bookkeeper and

[GitHub] sijie commented on issue #248: BOOKKEEPER-1027: Cleanup README

sijie commented on issue #248: BOOKKEEPER-1027: Cleanup README URL: https://github.com/apache/bookkeeper/pull/248#issuecomment-315905536 This is the attempt to improve current documentation. The content is based on current website and documentation. We can improve README later on after we

[GitHub] sijie opened a new issue #249: Organize findbugs and checkstyle files in buildtools module

sijie opened a new issue #249: Organize findbugs and checkstyle files in buildtools module URL: https://github.com/apache/bookkeeper/issues/249 **FEATURE REQUEST** 1. Please describe the feature you are requesting. currently the findbugs files and checkstyle files spread over

[GitHub] sijie opened a new pull request #250: Issue 249: Organize findbugs and checkstyle files in buildtools module

sijie opened a new pull request #250: Issue 249: Organize findbugs and checkstyle files in buildtools module URL: https://github.com/apache/bookkeeper/pull/250 Descriptions of the changes in this PR: Organize findbugs and checkstyle files in buildtools module --

[GitHub] sijie opened a new issue #251: Define dependency versions in root pom

sijie opened a new issue #251: Define dependency versions in root pom URL: https://github.com/apache/bookkeeper/issues/251 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Currently some dependencies' versions are defined in root pom, some are not. We s

[jira] [Commented] (BOOKKEEPER-1044) Entrylogger is not readding rolled logs back to the logChannelsToFlush list when exception happens while trying to flush rolled logs

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090820#comment-16090820 ] Sijie Guo commented on BOOKKEEPER-1044: --- [~reddychara...@gmail.com] do you have

[jira] [Commented] (BOOKKEEPER-869) Add documentation on how to tune performance on bookies

[ https://issues.apache.org/jira/browse/BOOKKEEPER-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090821#comment-16090821 ] Sijie Guo commented on BOOKKEEPER-869: -- removed from 4.5.0 now, would like to do

[jira] [Updated] (BOOKKEEPER-869) Add documentation on how to tune performance on bookies

[ https://issues.apache.org/jira/browse/BOOKKEEPER-869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-869: - Fix Version/s: (was: 4.5.0) > Add documentation on how to tune performance on bookies > --

[jira] [Assigned] (BOOKKEEPER-980) BookKeeper Tools doesn't process the argument correctly

[ https://issues.apache.org/jira/browse/BOOKKEEPER-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo reassigned BOOKKEEPER-980: Assignee: Sijie Guo (was: Sijie Guo) > BookKeeper Tools doesn't process the argument c

[GitHub] jvrao commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

jvrao commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127857203 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java

[GitHub] sijie opened a new issue #252: Enable four-letter-words zookeeper commands in localbookie

sijie opened a new issue #252: Enable four-letter-words zookeeper commands in localbookie URL: https://github.com/apache/bookkeeper/issues/252 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Run localbookie - What did you expect to se

[GitHub] sijie opened a new pull request #253: Issue 252: Enable four-letter-words zookeeper commands in localbookie

sijie opened a new pull request #253: Issue 252: Enable four-letter-words zookeeper commands in localbookie URL: https://github.com/apache/bookkeeper/pull/253 Descriptions of the changes in this PR: Enable four-letter-words zookeeper commands in localbookie

[GitHub] sijie opened a new issue #254: Remove BookKeeperTools

sijie opened a new issue #254: Remove BookKeeperTools URL: https://github.com/apache/bookkeeper/issues/254 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Currently all the bookkeeper commands are listed in BookieShell. BookKeeperTools is not really used

[GitHub] sijie opened a new pull request #255: BOOKKEEPER-980: BookKeeper Tools doesn't process the argument correctly

sijie opened a new pull request #255: BOOKKEEPER-980: BookKeeper Tools doesn't process the argument correctly URL: https://github.com/apache/bookkeeper/pull/255 Descriptions of the changes in this PR: Fix the issue described in [BOOKKEEPER-980](https://issues.apache.org/jira/browse/

[GitHub] jiazhai closed pull request #234: Issue 230: Add Checkstyle to the build process (Part 2)

jiazhai closed pull request #234: Issue 230: Add Checkstyle to the build process (Part 2) URL: https://github.com/apache/bookkeeper/pull/234 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] jiazhai closed issue #230: Add Checkstyle to the build process

jiazhai closed issue #230: Add Checkstyle to the build process URL: https://github.com/apache/bookkeeper/issues/230 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] jvrao commented on issue #255: BOOKKEEPER-980: BookKeeper Tools doesn't process the argument correctly

jvrao commented on issue #255: BOOKKEEPER-980: BookKeeper Tools doesn't process the argument correctly URL: https://github.com/apache/bookkeeper/pull/255#issuecomment-315958465 +1 LGTM This is an automated message from the A

[GitHub] jvrao commented on issue #253: Issue 252: Enable four-letter-words zookeeper commands in localbookie

jvrao commented on issue #253: Issue 252: Enable four-letter-words zookeeper commands in localbookie URL: https://github.com/apache/bookkeeper/pull/253#issuecomment-315958557 @reddycharan This is an automated message from t

[jira] [Commented] (BOOKKEEPER-929) In ReadOnlyLedgerHandle, metadata gets updated in the event of writeclose but lastAddConfirmed and length is not getting updated.

[ https://issues.apache.org/jira/browse/BOOKKEEPER-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091128#comment-16091128 ] Venkateswararao Jujjuri (JV) commented on BOOKKEEPER-929: - I d

[GitHub] sigee opened a new issue #230: Add Checkstyle to the build process

sigee opened a new issue #230: Add Checkstyle to the build process URL: https://github.com/apache/bookkeeper/issues/230 **Add Checkstyle to the build process** [Ruleset](https://github.com/apache/incubator-distributedlog/blob/master/distributedlog-build-tools/src/main/resources/distribut

[GitHub] sijie commented on issue #230: Add Checkstyle to the build process

sijie commented on issue #230: Add Checkstyle to the build process URL: https://github.com/apache/bookkeeper/issues/230#issuecomment-315967339 reopened this. it is a master ticket. This is an automated message from the Apache