[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner-mapr commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145572262 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java --- @@ -20,22 +20,58 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145575588 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java --- @@ -116,6 +116,14 @@ public void clear() {

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145575310 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java --- @@ -335,20 +336,42 @@ private void purge() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner-mapr commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145571158 --- Diff: common/src/test/java/org/apache/drill/test/DirTestWatcher.java --- @@ -32,23 +32,50 @@ public class DirTestWatcher extends TestWatcher {

[GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/993#discussion_r145565896 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java --- @@ -204,9 +217,15 @@ public WebUserConnection provide() {

[GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/993#discussion_r145565968 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java --- @@ -260,8 +282,14 @@ public WebUserConnection provide() {

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145574915 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java --- @@ -335,20 +336,42 @@ private void purge() throws

[jira] [Created] (DRILL-5892) Distinguish between states for query statistics exposed via JMX

Kunal Khatua created DRILL-5892: --- Summary: Distinguish between states for query statistics exposed via JMX Key: DRILL-5892 URL: https://issues.apache.org/jira/browse/DRILL-5892 Project: Apache Drill

Re: Excessive review comments

With all due respect, I did start a review. Is something broken? - Paul > On Oct 18, 2017, at 3:36 PM, julianhyde wrote: > > Github user julianhyde commented on a diff in the pull request: > >https://github.com/apache/drill/pull/984#discussion_r145561518 > >---

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145574026 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java --- @@ -20,22 +20,58 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145575781 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -247,7 +248,7 @@ drill.exec: { } }, sort: { -

[GitHub] drill issue #1001: JIRA DRILL-5879: Like operator performance improvements

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1001 Paul, - I think you misunderstood the proposal - Let me use an example - select .. c1 like '%pattern1%' OR c1 like '%pattern2'.. - Assume c1 has 3 values [v1, v2, v3] - The

[GitHub] drill pull request #1002: DRILL-5888: Remove dependency of SSLConfig on hado...

Github user parthchandra closed the pull request at: https://github.com/apache/drill/pull/1002 ---

[GitHub] drill pull request #1002: DRILL-5888: Remove dependency of SSLConfig on hado...

GitHub user parthchandra reopened a pull request: https://github.com/apache/drill/pull/1002 DRILL-5888: Remove dependency of SSLConfig on hadoop.security package… …. This allows jdbc-all-jar to be built without hadoop dependencies. The original code used Hadoop's

[GitHub] drill issue #1002: DRILL-5888: Remove dependency of SSLConfig on hadoop.secu...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1002 Yes. The property is consumed by SSLConfig which uses that to construct a key name that is looked up in the hadoop config. ---

[GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/993#discussion_r145495729 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java --- @@ -204,9 +217,15 @@ public WebUserConnection provide() {

[GitHub] drill issue #997: DRILL-5882: C++ Client: [Threat Modeling] Drillbit may be ...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/997 +1. ---

[GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/993#discussion_r145566366 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebSessionResources.java --- @@ -68,16 +68,19 @@ public SocketAddress

[GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/993#discussion_r145571583 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/WebSessionResourcesTest.java --- @@ -0,0 +1,146 @@ +/* + * Licensed to the

[GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/993#discussion_r145568772 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java --- @@ -124,6 +124,13 @@ public void

[GitHub] drill pull request #993: DRILL-5874: NPE in AnonWebUserConnection.cleanupSes...

Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/993#discussion_r145565944 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java --- @@ -204,9 +217,15 @@ public WebUserConnection provide() {

[GitHub] drill issue #1001: JIRA DRILL-5879: Like operator performance improvements

Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1001 @sachouche Do you have a breakdown of how much gain we got with 1 vs 2. Since the changes for 2 are not straightforward and easy to maintain, I am thinking performance gain vs. maintainability of

[GitHub] drill issue #1001: JIRA DRILL-5879: Like operator performance improvements

Github user sachouche commented on the issue: https://github.com/apache/drill/pull/1001 - It was 50% for 1) and 50% for 2) - Notice this breakdown depends on o The number of Contains pattern for the same value (impacts 1)) o The pattern length (impacts both 1) and

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145575975 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java --- @@ -21,29 +21,25 @@ import

[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1001#discussion_r145577808 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -17,36 +17,133 @@ */ package

[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1001#discussion_r145574785 --- Diff: exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLenTargetVarLen.java --- @@ -73,6 +73,9 @@ public void eval() {

[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1001#discussion_r145578320 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -17,36 +17,133 @@ */ package

[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1001#discussion_r145575103 --- Diff: exec/java-exec/src/main/codegen/templates/CastFunctionsSrcVarLenTargetVarLen.java --- @@ -73,6 +73,9 @@ public void eval() {

[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1001#discussion_r145577107 --- Diff: exec/vector/src/main/codegen/templates/ValueHolders.java --- @@ -33,34 +33,40 @@ * This class is generated using freemarker and the

[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1001#discussion_r145576718 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -17,36 +17,133 @@ */ package

[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1001#discussion_r145577894 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/SqlPatternContainsMatcher.java --- @@ -17,36 +17,133 @@ */ package

[GitHub] drill issue #1001: JIRA DRILL-5879: Like operator performance improvements

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1001 @sachouche, thanks for the first PR to Drill! Thanks for the detailed explanation! Before reviewing the code, a comment on the design: > Added a new integer variable "asciiMode"

[GitHub] drill pull request #998: DRILL-5887: Display process user/groups info in Dri...

Github user prasadns14 commented on a diff in the pull request: https://github.com/apache/drill/pull/998#discussion_r145584186 --- Diff: exec/java-exec/src/main/resources/rest/index.ftl --- @@ -112,6 +112,14 @@ Admin User Groups

[GitHub] drill pull request #998: DRILL-5887: Display process user/groups info in Dri...

Github user prasadns14 commented on a diff in the pull request: https://github.com/apache/drill/pull/998#discussion_r145584181 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -85,21 +86,33 @@ public ClusterInfo getClusterInfoJSON() {

[GitHub] drill pull request #998: DRILL-5887: Display process user/groups info in Dri...

Github user prasadns14 commented on a diff in the pull request: https://github.com/apache/drill/pull/998#discussion_r145584184 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -85,21 +86,33 @@ public ClusterInfo getClusterInfoJSON() {

[GitHub] drill pull request #998: DRILL-5887: Display process user/groups info in Dri...

Github user prasadns14 commented on a diff in the pull request: https://github.com/apache/drill/pull/998#discussion_r145584179 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -85,21 +86,33 @@ public ClusterInfo getClusterInfoJSON() {

[GitHub] drill pull request #998: DRILL-5887: Display process user/groups info in Dri...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/998#discussion_r145569370 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -85,21 +86,33 @@ public ClusterInfo getClusterInfoJSON()

[GitHub] drill pull request #998: DRILL-5887: Display process user/groups info in Dri...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/998#discussion_r145569034 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -85,21 +86,33 @@ public ClusterInfo getClusterInfoJSON()

Re: Date Conversion Question

A question on StackOverflow asks how to do this using Oracle’s TO_TIMESTAMP function, and there is a solution[1]. So, I tried SELECT to_timestamp ('2017-08-10T09:12:26.000Z', '-MM-DD"T"HH24:MI:SS.FF3"Z"') FROM DUAL on http://rextester.com/l/oracle_online_compiler

Re: Date Conversion Question

Hi Julian, Alas, this doesn’t work in Drill since Drill uses Joda time formats. However, you got me thinking about this and I actually got it to work w/o using the substring or other weird string manipulation functions. SELECT to_timestamp ('2017-08-10T09:12:26.000Z',

Re: Date Conversion Question

FWIW I was doing very similar substring (etc) machinations until we started converting output from back-end data-generation tools directly into parquet (using other tools). IMO it's a common enough format (at least in the types of data you and I likely have to work with :-) that it'd be great if

[GitHub] drill pull request #1000: DRILL-5845: Columns returned by select with "ORDER...

GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/1000 DRILL-5845: Columns returned by select with "ORDER BY" and "LIMIT" cl… …auses are not in correct order. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill issue #1000: DRILL-5845: Columns returned by select with "ORDER BY" an...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1000 +1, LGTM. ---

[GitHub] drill issue #904: DRILL-5717: change some date time test cases with specific...

Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/904 @weijietong which problems did you have when tried to mock `System.getProperty()` method? As the example of nice mock of this method, you may use [this

Date Conversion Question

Hello Drillers, I have a silly question which I’m a little stuck with. I have some data in CSV format with dates in the following format: 2017-08-10T09:12:26.000Z. I’m trying to convert this into a date time data field so that I have both the date and the hours, however I keep running into

[GitHub] drill issue #999: DRILL-5881:Java Client: [Threat Modeling] Drillbit may be ...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/999 +1. You need a newline at the end :) ---

[GitHub] drill pull request #1001: JIRA DRILL-5879: Like operator performance improve...

GitHub user sachouche opened a pull request: https://github.com/apache/drill/pull/1001 JIRA DRILL-5879: Like operator performance improvements - Recently, custom code has been added to handle common search patterns (Like operator) - Contains, Starts With, and Ends With -

[GitHub] drill pull request #997: DRILL-5882: C++ Client: [Threat Modeling] Drillbit ...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/997#discussion_r145510774 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -595,6 +611,12 @@ connectionStatus_t

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user julianhyde commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145561518 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -584,11 +492,14 @@ public static void defineWorkspace(Drillbit

[GitHub] drill pull request #996: DRILL-5878: TableNotFound exception is being report...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/996#discussion_r145565023 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java --- @@ -121,6 +137,9 @@ public static String

[GitHub] drill pull request #996: DRILL-5878: TableNotFound exception is being report...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/996#discussion_r145565621 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java --- @@ -149,6 +168,16 @@ public static void

[GitHub] drill pull request #996: DRILL-5878: TableNotFound exception is being report...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/996#discussion_r145564952 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java --- @@ -77,6 +77,22 @@ public static SchemaPlus

[GitHub] drill pull request #996: DRILL-5878: TableNotFound exception is being report...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/996#discussion_r145564522 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUtilites.java --- @@ -77,6 +77,22 @@ public static SchemaPlus

[GitHub] drill pull request #1002: DRILL-5888: Remove dependency of SSLConfig on hado...

GitHub user parthchandra opened a pull request: https://github.com/apache/drill/pull/1002 DRILL-5888: Remove dependency of SSLConfig on hadoop.security package… …. This allows jdbc-all-jar to be built without hadoop dependencies. The original code used Hadoop's

Re: describe query support? (catalog metadata, etc)

I’d like to second Alfredo’s request. I’ve been trying to get Drill to work with some open source visualization tools such as SqlPad and Metabase and the issue I keep running into is that Drill doesn’t have a convenient way to describe how it interprets flat files. This is really frustrating

[jira] [Created] (DRILL-5889) sqlline loses RPC connection with executing query with HashAgg

Robert Hou created DRILL-5889: - Summary: sqlline loses RPC connection with executing query with HashAgg Key: DRILL-5889 URL: https://issues.apache.org/jira/browse/DRILL-5889 Project: Apache Drill

[jira] [Created] (DRILL-5890) Tests Leak Many Open File Descriptors

Timothy Farkas created DRILL-5890: - Summary: Tests Leak Many Open File Descriptors Key: DRILL-5890 URL: https://issues.apache.org/jira/browse/DRILL-5890 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #997: DRILL-5882: C++ Client: [Threat Modeling] Drillbit ...

Github user bitblender commented on a diff in the pull request: https://github.com/apache/drill/pull/997#discussion_r145567205 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -595,6 +611,12 @@ connectionStatus_t

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145298677 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggrSpill.java --- @@ -43,146 +44,122 @@ import static

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145556819 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -908,6 +908,15 @@ public void generateTestData(int count) { }

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145518566 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145520129 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -226,43 +217,16 @@ private void createConfig(FixtureBuilder

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145508960 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestExternalSort.java --- @@ -138,34 +141,34 @@ public void

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145292655 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -247,7 +248,7 @@ drill.exec: { } }, sort: { -

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145505747 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java --- @@ -76,43 +78,50 @@

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145516858 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145519174 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -213,7 +204,7 @@ private void configureZk(FixtureBuilder builder)

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145297931 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java --- @@ -0,0 +1,179 @@ +/* + * Licensed to the

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145521268 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java --- @@ -584,11 +492,14 @@ public static void defineWorkspace(Drillbit

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145515947 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseDirTestWatcher.java --- @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145522737 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/TableFileBuilder.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145516134 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BaseDirTestWatcher.java --- @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145523267 --- Diff: exec/java-exec/src/test/resources/topN/one_key_sort.json --- @@ -12,11 +12,11 @@ pop:"mock-scan", url:

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145509549 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java --- @@ -147,7 +152,7 @@ public void

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145505524 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java --- @@ -76,43 +78,50 @@

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145516665 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145522320 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ExampleTest.java --- @@ -59,6 +59,9 @@ @Ignore public class ExampleTest {

[GitHub] drill pull request #997: DRILL-5882: C++ Client: [Threat Modeling] Drillbit ...

Github user bitblender commented on a diff in the pull request: https://github.com/apache/drill/pull/997#discussion_r145568130 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -595,6 +611,12 @@ connectionStatus_t

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145292505 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java --- @@ -116,6 +116,14 @@ public void clear() {

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145294641 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java --- @@ -33,8 +35,11 @@ @Category(UnlikelyTest.class) public class

[jira] [Created] (DRILL-5891) When Drill runs out of memory for a HashAgg, it should tell the user how much memory to allocate

Robert Hou created DRILL-5891: - Summary: When Drill runs out of memory for a HashAgg, it should tell the user how much memory to allocate Key: DRILL-5891 URL: https://issues.apache.org/jira/browse/DRILL-5891

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144943882 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java --- @@ -20,22 +20,58 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144946834 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java --- @@ -335,20 +336,42 @@ private void purge() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145292776 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java --- @@ -21,29 +21,25 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145297229 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java --- @@ -559,7 +563,7 @@ public void testRankWithGroupBy() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144945381 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java --- @@ -20,22 +20,58 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145294835 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java --- @@ -59,48 +58,48 @@ public void withDistribution() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145294064 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java --- @@ -19,24 +19,33 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144944018 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java --- @@ -20,22 +20,58 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145293197 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java --- @@ -61,10 +57,8 @@ public void testHashAggNullableColumns() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144936263 --- Diff: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144936994 --- Diff: common/src/test/java/org/apache/drill/test/DirTestWatcher.java --- @@ -32,23 +32,50 @@ public class DirTestWatcher extends TestWatcher {

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145517411 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/BatchUtils.java --- @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145292056 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java --- @@ -335,20 +336,42 @@ private void purge() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144943191 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java --- @@ -90,12 +89,11 @@ private String generatedCode;

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144935089 --- Diff: common/src/main/java/org/apache/drill/common/util/TestTools.java --- @@ -17,15 +17,28 @@ */ package org.apache.drill.common.util;

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

Github user ilooner-mapr commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145561373 --- Diff: common/src/main/java/org/apache/drill/common/util/TestTools.java --- @@ -17,15 +17,28 @@ */ package org.apache.drill.common.util;