Cool, I'll do the review.
Kind regards,
Arina
On Fri, Oct 12, 2018 at 9:31 AM Paul Rogers
wrote:
> Hi Arina,
>
> Just did another PR towards completing the scan operator revision to work
> with the "result set loader." This one is mostly plumbing to implement
> projection with the scan
Hi Jean-Claude!
You should use logback-test.xml for tests.
Paul has documented it very well in [1] and [2].
[1]
https://github.com/apache/drill/blob/master/docs/dev/TestLogging.md#default-test-log-levels
[2]
KazydubB commented on issue #1307: DRILL-6473: Update MapR Hive
URL: https://github.com/apache/drill/pull/1307#issuecomment-429338760
Removed MapR release and OJAI versions update so this and
https://github.com/apache/drill/pull/1489 PRs are independent. This PR may be
merged as is.
weijie.tong created DRILL-6792:
--
Summary: Find the right probe side fragment to any storage plugin
Key: DRILL-6792
URL: https://issues.apache.org/jira/browse/DRILL-6792
Project: Apache Drill
sohami opened a new pull request #1502: DRILL-6785: DataClient is using
RootAllocator in the bootstrap instea…
URL: https://github.com/apache/drill/pull/1502
…d of dataPool
This is an automated message from the Apache Git
Volodymyr Vysotskyi created DRILL-6793:
--
Summary: FragmentExecutor cannot send its final state for the case
when RootExec root wasn't initialized
Key: DRILL-6793
URL:
Yes I want to debug a junit test case I have. Thanks Paul and Vitalii.
On Fri, Oct 12, 2018 at 2:28 PM Paul Rogers
wrote:
> Hi JC,
>
> Your are asking how to use logs with unit tests. Let's talk about the two
> ways you might be using logging, because each has a different answer.
>
> In
Attached is a PDF version of the slides. Unfortunately, I don't have a
recording.
thanks,
Aman
On Thu, Oct 11, 2018 at 9:39 AM Pritesh Maker wrote:
> Divya - anyone is welcome to join the hangout! Aman will be sharing the
> slides shortly. We use Google Hangouts which doesn't have the
Hi JC,
Your are asking how to use logs with unit tests. Let's talk about the two ways
you might be using logging, because each has a different answer.
In general, a unit test should use JUnit assert calls to verify that behavior
is as expected. No-one ever looks at output from tests unless a
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224918663
##
File path:
kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224944120
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
Drill enforces two hard limits:
1. The maximum number of rows in a batch is 64K.
2. The maximum size of any vector is 4 GB.
We have found, however, that fragmentation occurs in our memory allocator for
any vector larger than 16 MB. (This is, in fact the original reason for the
result set loader
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224921473
##
File path:
kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224942957
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224943823
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224926241
##
File path:
kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224942740
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224918663
##
File path:
kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224943573
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224916314
##
File path:
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224917712
##
File path:
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224921316
##
File path:
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224928601
##
File path:
kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224942492
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224942418
##
File path: exec/java-exec/src/main/resources/ace.mode-sql.template.js
##
@@ -0,0 +1,121
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224925023
##
File path:
amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224925146
##
File path:
kkhatua commented on issue #1250: DRILL-5270: Improve loading of profiles
listing in the WebUI
URL: https://github.com/apache/drill/pull/1250#issuecomment-429493831
@priteshm this required some more rework, which I'm hoping I've addressed.
We can review and try to get this in as part of
I've changed my batch size record reader to be larger. All my test cases
still work as I would expect them, except for 1 and I have no idea why? I'v
turned on tracing in the hopes of getting a hint. I now see it is in a
generated projection class but I'm not sure why.. Can anyone speculate why
a
kkhatua commented on a change in pull request #1491: DRILL-6084: Show Drill
functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224943081
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
vdiravka commented on a change in pull request #1501: DRILL-6791: Scan
projection framework
URL: https://github.com/apache/drill/pull/1501#discussion_r224684940
##
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/ScanTestUtils.java
##
@@
Hi Arina,
Just did another PR towards completing the scan operator revision to work with
the "result set loader." This one is mostly plumbing to implement projection
with the scan operator. It generalizes lots of code that already exists into a
single, unified mechanism.
Basically, this one
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224741116
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224741116
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224742597
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL
functions with constant values
URL: https://github.com/apache/drill/pull/1481#issuecomment-429264607
In order to collect setter methods of nested class, some changes will be
made:
1. `public void
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224742056
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224740139
##
File path: exec/java-exec/src/main/resources/ace.mode-sql.template.js
##
@@
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224742597
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224741116
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224742597
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224741210
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224741551
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224742213
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
arina-ielchiieva commented on a change in pull request #1491: DRILL-6084: Show
Drill functions in WebUI for autocomplete
URL: https://github.com/apache/drill/pull/1491#discussion_r224741648
##
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of
SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#issuecomment-429280849
@lushuifeng, I meant to replace
`Map> setters`
with something like this:
`Map>>
setters`,
Vitalii,
in this case I think it's ok to merge CircleCI configs. Could you please
share how to setup CircleCI for custom builds?
Also could you follow up with INFRA ticket there would be any response?
Kind regards,
Arina
On Thu, Oct 11, 2018 at 2:20 PM Vitalii Diravka wrote:
> Hi all!
>
> I
vvysotskyi commented on issue #1481: DRILL-6763: Codegen optimization of SQL
functions with constant values
URL: https://github.com/apache/drill/pull/1481#issuecomment-429280849
@lushuifeng, I meant to replace
`Map> setters`
with something like this:
`Map>>
setters`,
where
The CircleCI + GitHub integration as simple as it's shown in [1].
Just need to click "Start Building Now" and to proceed with "Sign Up with
GitHub".
You can find more complicated tuning in [2].
Once there will be an update from INFRA, I will inform this thread.
[1]
lushuifeng commented on issue #1481: DRILL-6763: Codegen optimization of SQL
functions with constant values
URL: https://github.com/apache/drill/pull/1481#issuecomment-429313733
I think it is the way I'm doing besides you wrap two params (DrillBuf and
String) into a Pair for the first
I'm trying to output trace information in my junit test cases. I'm using
the ClusterFixture
startCluster(ClusterFixture.builder(dirTestWatcher).maxParallelization(1));
I've put my logback.xml in src/test/resources
and feed in these environment variables at the command mvn launch.
mvn --offline
51 matches
Mail list logo
