GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/76
Update 020-core-modules.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinfengni/incubator-drill patch-1
Alternatively you can review
Github user jinfengni closed the pull request at:
https://github.com/apache/drill/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/126
Calcite1.4.0 rebase
The Drill's forked version, after rebasing on today's Calcite 1.4.0 master
branch, is currently located here:
https://github.com/jinfengni/incubator-optiq/tree
Github user jinfengni closed the pull request at:
https://github.com/apache/drill/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/103#discussion_r36149446
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
@@ -217,8 +218,21 @@ public Void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/103#discussion_r36213289
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
@@ -217,8 +218,21 @@ public Void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/103#discussion_r36244389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
---
@@ -217,8 +218,21 @@ public Void
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/97
DRILL-3533: Fix incorrect query result when querying parquet for fielâ¦
â¦ds that do not exists.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/96
DRILL-1651: Push filter past project with ITEM operator into HBase scan.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinfengni/incubator
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/89
Drill 3156: Fix Calcite trace by registering RelMetadataProvider with
HepPlanner used for window function planning.
You can merge this pull request into a Git repository by running:
$ git
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/193#issuecomment-151987787
Please modify the title of JIRA DRILL-3623, since the new pull request is
using a completely different approach to address the performance issue for
"LI
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/209#discussion_r42679515
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
---
@@ -305,6 +313,105 @@ public SqlNode
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/214#issuecomment-150038654
Is there a public JIRA created for PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/193#issuecomment-152034091
Sudheesh and I feel this new approach is more like a big optimization step
towards solving the performance issue for "limit 0" query, rather than hack
sol
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/253#discussion_r44845244
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
---
@@ -36,6 +36,19 @@ public static void setupOptions
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/255
DRILL-3765: Move partitioning pruning to HepPlanner to avoid the perfâ¦
â¦ormance overhead for redundant rule execution.
Add fall back option in planner.
Run the regression/unit
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/253#issuecomment-156584940
Overall LGTM.
In case that only constants are used and no column is required from scan
operator, the scan operator still has to go through the data source
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/255#discussion_r44974839
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -116,20 +117,32 @@ public DrillSqlWorker(QueryContext
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45010657
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillDirectScanRel.java
---
@@ -0,0 +1,111 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/189#discussion_r43714617
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -218,11 +220,16 @@ public HoldingContainer addExpr
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/189#issuecomment-153236066
The revised code(adds MappingSet to ExpressionHolder) looks good to me.
---
If your project is set up for it, you can reply to this email and have your
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/209
DRILL-3802: Throw unsupported error for Rollup, Cube, Grouping_Sets, â¦
â¦Grouping, Grouping_ID, Group_ID.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/189#issuecomment-149385017
Seems to me this pull request would remove the common subexpression
elimination(CSE) for Project and Filter only; it would not do CSE for other
operators, like Join
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/189#discussion_r42534375
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java ---
@@ -0,0 +1,322 @@
+/**
+ * Licensed to the Apache
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/189#discussion_r42557389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EqualityVisitor.java ---
@@ -0,0 +1,322 @@
+/**
+ * Licensed to the Apache
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/187#issuecomment-148230900
I pushed the patches to master, after rebasing & run regression. I realized
that the master branch is actually open while the vote for 1.2.0 is g
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r41682242
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveTable.java
---
@@ -179,4 +179,9 @@ private void
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/187#issuecomment-147597855
PS: Once apache/drill master branch opens again for 1.3 release, would you
please merge those patches into master branch? I run the unit test / regression
suite
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/187#issuecomment-147580729
@jaltekruse , the simple fix in this PR seems to break the case of
flatten() used in a regular expression tree, such as flatten(a.b) + 1.
On the dev list
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/187#issuecomment-147597511
Sounds good to me. Getting the simple yet most common used use case faster
makes sense to me, even though this is not the right way to fix the problem in
the long term
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/120#discussion_r39193879
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentManager.java
---
@@ -38,36 +37,43 @@
* @return True
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/152#discussion_r39189463
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java ---
@@ -165,49 +258,182 @@ public void testWindowGroupByOnView
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/152#issuecomment-139324948
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/153
Drill 3754: Remove redundancy in run-time generated code for common column
references
Test done:
unit test
pre-commit test.
You can merge this pull request into a Git repository
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/156#discussion_r39464031
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -176,81 +177,103 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/156#discussion_r39465039
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java
---
@@ -125,4 +117,16 @@ private String
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/156#discussion_r39463695
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -168,6 +168,7 @@ protected void doOnMatch
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/156#discussion_r39463605
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -176,81 +177,103 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/156#discussion_r39478410
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java
---
@@ -125,4 +117,16 @@ private String
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/156#discussion_r39528358
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java
---
@@ -125,4 +117,16 @@ private String
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/120#issuecomment-139083251
+1
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/120#discussion_r39114713
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java ---
@@ -211,8 +220,11 @@ public TransferPair makeTransferPair(ValueVector
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/120#discussion_r39214700
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BitVector.java ---
@@ -211,8 +220,11 @@ public TransferPair makeTransferPair(ValueVector
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/169
DRILL-1457: Push Limit past through UnionExchange.
Aman, could you please review this pull request?
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40484512
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -26,4 +30,34 @@
public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40484389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLimitRelBase.java
---
@@ -36,11 +36,17 @@
public abstract class
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40484523
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -26,4 +30,34 @@
public void
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/169#issuecomment-143375295
Revise the code based on comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/169#discussion_r40484865
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitUnionExchangeTransposeRule.java
---
@@ -0,0 +1,64
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r39984380
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
---
@@ -107,7 +117,7 @@ public SqlNode
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/286#issuecomment-162982945
Address venki's comments in the revised patches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/286#issuecomment-161335544
@vkorukanti , the patches pass the unit test, pre-commit test, and
impersonation test.
---
If your project is set up for it, you can reply to this email
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/286
Drill 4127: Reduce Hive metastore client API call in HiveSchema
Also, it has commit for DRILL-4126: Add cache to HiveSchema in order to
reduce long planning time or execution time caused by slow
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/286#issuecomment-162665850
@vkorukanti , could you please take a look at the revised patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/300#discussion_r47582011
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java
---
@@ -91,20 +91,24 @@ public void
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/300#issuecomment-164609559
+1. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/301#issuecomment-164657881
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/305#issuecomment-165567570
@amansinha100 , could you please review the patch for DRILL-4201? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/305
DRILL-4201 : Allow partial filter to be pushed down project for betteâ¦
â¦r performance.
Partial filter pushdown has performance benefits because:
1) enable partition pruning
Github user jinfengni closed the pull request at:
https://github.com/apache/drill/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/318
DRILL-4250: Fix directory-based partition pruning when directory has â¦
â¦both subdirectory and file.
@amansinha100 , could you please review this small patch for
directory-based
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/285#issuecomment-161017412
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45406832
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/FindLimit0Visitor.java
---
@@ -36,16 +48,62 @@
* executing a schema
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/193#issuecomment-158212142
Overall, looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45407282
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
---
@@ -42,6 +43,25 @@ public void hiveReadWithDb
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r45406939
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
---
@@ -42,6 +43,25 @@ public void hiveReadWithDb
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/512
@jcmcote , thanks for the new PR. I'll take a look tomorrow, and let you
know my feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-221648222
@jcmcote , just wanna to check the current status of your latest fix.
FYI, you may consider using couple of existing methods [1] [2], when you
decode
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/521
DRILL-4715: Fix java compilation error in run-time generated code wheâ¦
â¦n query has large number of expressions.
You can merge this pull request into a Git repository by running:
$ git
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/521
@jacques-n @amansinha100 , can you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/512
@jcmcote ,
Overall the patch looks good to me. Once you revise the code, I'll run the
regression and merge the code if no problem is found. Thanks for your patch!
---
If your project
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/515
DRILL-4707: Fix memory leak or incorrect query result in case two colâ¦
â¦umn names are case-insensitive identical
Fix is mainly in CALCITE-528.
You can merge this pull request
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/512#discussion_r65994802
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
---
@@ -114,6 +114,19 @@ public void testRegexpMatches
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/508#issuecomment-221749835
LGGM.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/512#discussion_r66894665
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java
---
@@ -17,13 +17,52 @@
*/
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/512#discussion_r66894981
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
---
@@ -114,6 +114,19 @@ public void testRegexpMatches
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/531#discussion_r68070931
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestImplicitFileColumns.java
---
@@ -110,4 +111,20 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68102305
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -86,14 +88,16 @@ public static MappingSet getDefaultMapping
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68102519
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/SizedJBlock.java ---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68102435
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -215,22 +219,47 @@ public JVar
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67567993
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67567343
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67567703
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java
---
@@ -151,7 +152,7 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67709299
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -320,7 +377,17 @@ protected void doOnMatch
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67711244
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67716686
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -47,16 +47,25 @@
private List statuses
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68148064
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestCastFunctions.java
---
@@ -17,18 +17,16 @@
*/
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68148042
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -186,4 +186,9 @@ public boolean
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68148021
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -247,11 +275,13 @@ void flushCode() {
outer._throws
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68147991
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -215,22 +218,47 @@ public JVar
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/512
I did the following small changes to this PR, and I'm going to rebase and
re-run the regression suite before merge this PR.
1) fix one bug which causes regression failure (IOBE).
2) add
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/521
@sudheeshkatkam , do you want to take a quick look and see if I have
addressed your comments? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/328
Drill 2517: Apply directory-based partition pruning before reading files in
planning.
1. Run the pre-commit tests and unit tests. Some queries in pre-commit
suites have changed plan. Most
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/515
I cherry-picked CALCITE-528 from Calcite master branch, and put it into
Drill forked version.
@amansinha100 , could you please review this PR? thanks!
---
If your project is set up
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52476961
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52498045
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52539112
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52564032
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java
---
@@ -0,0 +1,108 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52565738
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -485,12 +486,14 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/371#discussion_r52563924
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -791,6 +799,43 @@ public FileGroupScan clone
1 - 100 of 539 matches
Mail list logo
