Re: [FlexJS] super method calls broken?

2016-10-13 Thread Alex Harui
Oh, make sure you've deleted the frameworks/js/FlexJS/generated-sources folder from your repo working copy. The build may not delete or overwrite it, so maybe you have stale JS files in it that your old script copied. -Alex On 10/13/16, 9:21 AM, "Harbs" wrote: >It could

Re: [FlexJS] super method calls broken?

2016-10-13 Thread Alex Harui
On 10/13/16, 8:26 AM, "Harbs" wrote: >We tried restarting FB multiple times. It didn’t help. > >Copying the SWCs did not help either. It still took the JS from the >original location. Ah yes, the generated-sources folder of JS files has priority so folks can monkey

Re: [FlexJS] super method calls broken?

2016-10-13 Thread Alex Harui
On 10/13/16, 6:49 AM, "yishayw" wrote: >The key was indeed to recompile all packages, which generates the correct >get/set functions along the chain of inheritance. The hard part was >understanding where the js files were being generated but I'll elaborate >on >a

Re: [FlexJS] super method calls broken?

2016-10-13 Thread Alex Harui
Sorry about breaking your workflow. It didn't occur to me that folks were trying to update a FlexJS SDK by copying in JS files from a repo. That would only work if you know you didn't change any AS code paths. IMO, there are only two workflows I can think of that should work in all cases: 1)

Re: [FlexJS] super method calls broken?

2016-10-13 Thread yishayw
The key was indeed to recompile all packages, which generates the correct get/set functions along the chain of inheritance. The hard part was understanding where the js files were being generated but I'll elaborate on a different thread. -- View this message in context:

Re: [FlexJS] super method calls broken?

2016-10-13 Thread Harbs
We finally managed to get our project to build by extracting the js files from the SWC and copying them to where the JS files used to be in the nightly which we are building against. That’s a pretty poor work-around. We need instructions on how to get the new SWCs to work in Flash Builder.

Re: [FlexJS] super method calls broken?

2016-10-13 Thread Harbs
It doesn’t “just work”. We’re having a lot of trouble figuring out everything that changed. This is really frustrating. We’ve wasted a couple of days chasing our tails dues to things changing. I don’t see any js files being generated in the latest version of develop. I know there as some

Re: [FlexJS] super method calls broken?

2016-10-13 Thread Alex Harui
On 10/12/16, 11:12 PM, "Harbs" wrote: >I obviously have not been following well enough. > >What was the reason for this change? Lizhi found that the previous way of accessing the super setter or getter was significantly slower. But if everything was compiled with the

Re: [FlexJS] super method calls broken?

2016-10-13 Thread Harbs
I obviously have not been following well enough. What was the reason for this change? On Oct 13, 2016, at 8:52 AM, Alex Harui wrote: > Getters and Setters should now generate a get__ and set__ method. So on > your class A if you have: > > override public function set

Re: [FlexJS] super method calls broken?

2016-10-12 Thread Alex Harui
Getters and Setters should now generate a get__ and set__ method. So on your class A if you have: override public function set visible(value:Boolean):void You should get: A.prototype.set__visible(value) Super calls should then generate calls to base so super.visible = value; Should