Re: Re: Re: [VOTE] Accept Flink CDC into Apache Flink

2024-01-11 Thread godfrey he
+1 (binding) Thanks, Godfrey Zhu Zhu 于2024年1月12日周五 14:10写道: > > +1 (binding) > > Thanks, > Zhu > > Hangxiang Yu 于2024年1月11日周四 14:26写道: > > > +1 (non-binding) > > > > On Thu, Jan 11, 2024 at 11:19 AM Xuannan Su wrote: > > > > > +1 (non-binding) > > > > > > Best, > > > Xuannan > > > > > > On Thu

Re: [DISCUSS] FLIP-91 - Support SQL Client Gateway

2020-02-05 Thread godfrey he
king this a standalone project? This seems like > > unit of functionality that would be useful to have separately, and it > would > > have a few advantages: > > > >- Flink codebase is already very large and hard to maintain > >- A separate project is simple

Re: [DISCUSS] FLIP-84: Improve & Refactor execute/sqlQuery/sqlUpdate APIS of TableEnvironment

2020-02-13 Thread godfrey he
hi kurt,jark,jingsong Regarding to "fromQuery", I agree with kurt. In addition, I think `Table from(String tableName)` should be renamed to `Table fromCatalog(String tableName)`. Regarding to the "DmlBatch", DML contains "INSERT", "UPDATE", "DELETE", and they can be executed in a same batch in th

Re: [DISCUSS] FLIP-84: Improve & Refactor execute/sqlQuery/sqlUpdate APIS of TableEnvironment

2020-02-18 Thread godfrey he
introduced `sqlQuery(query)`, we removed > > > `scan(tableName)` and introduced `from(tableName)`, > > > and now we want to remove them again. Users will feel like the > interface > > is > > > very unstable, that really frustrates users. > > > I think w

Re: [ANNOUNCE] Jingsong Lee becomes a Flink committer

2020-02-20 Thread godfrey he
Congrats Jingsong! Well deserved. Best, godfrey Jeff Zhang 于2020年2月21日周五 上午11:49写道: > Congratulations!Jingsong. You deserve it > > wenlong.lwl 于2020年2月21日周五 上午11:43写道: > >> Congrats Jingsong! >> >> On Fri, 21 Feb 2020 at 11:41, Dian Fu wrote: >> >> > Congrats Jingsong! >> > >> > > 在 2020年2月21

[VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-26 Thread godfrey he
Hi everyone, I'd like to start the vote of FLIP-84[1], which proposes to deprecate some old APIs and introduce some new APIs in TableEnvironment. This FLIP is discussed and reached consensus in the discussion thread[2]. The vote will be open for at least 72 hours. Unless there is an objection, I

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-27 Thread godfrey he
urt > > > > > > On Fri, Feb 28, 2020 at 9:15 AM Terry Wang wrote: > > > > > I look through the whole design and it’s a big improvement of usability > > on > > > TableEnvironment’s api. > > > > > > +1 (non-binding) > > > >

Re: [DISCUSS] FLIP-84: Improve & Refactor execute/sqlQuery/sqlUpdate APIS of TableEnvironment

2020-02-28 Thread godfrey he
atement accepts DML, what if it's a streaming DML ? > does it submit the job to cluster directly and blocks forever? what's > the behavior for the next statements? > > nit: there's a typo in "the table describing the result for each kind of > statement",

Re: [DISCUSS] FLIP-84: Improve & Refactor execute/sqlQuery/sqlUpdate APIS of TableEnvironment

2020-03-01 Thread godfrey he
planation. > > Do we need to clarify this in the FLIP? Maybe this confuses other users as > well. > > godfrey he 于2020年2月28日周五 下午4:54写道: > > > Hi Benchao, > > > > > I have one question about this FLIP: > > > executeStatement accepts DML, what if

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-03-01 Thread godfrey he
0:10 PM Benchao Li wrote: > > > +1 (non-binding) > > > > Jark Wu 于2020年2月28日周五 下午5:11写道: > > > > > +1 from my side. > > > > > > Best, > > > Jark > > > > > > On Fri, 28 Feb 2020 at 15:07, kant kodali wrote: > > > >

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-03-01 Thread godfrey he
Thanks all for the votes. So far, we have - 3 binding +1 votes (Kurt, Jark, Jingsong) - 2 non-binding +1 votes (Terry, Benchao) - No -1 votes The voting time has past and there is enough +1 votes to consider the FLIP-84 approved. Thank you all. Best, Godfrey godfrey he 于2020年3月2日周一

Re: [DISCUSS] FLIP-114: Support Python UDF in SQL Client

2020-03-09 Thread godfrey he
Hi Wei, thanks for the proposal. I think it's better to give two more examples, one is how to use python UDF in SQL, another is how to start sql-client.sh with full python dependencies. Best, Godfrey Wei Zhong 于2020年3月9日周一 下午10:09写道: > Hi everyone, > > I would like to start discussion about ho

Re: [DISCUSS] Features of Apache Flink 1.11

2020-03-11 Thread godfrey he
Hi Zhijiang and Piotr, I think we can remove "FLIP-91 Introduce SQL client gateway and provide JDBC driver" from the list, because we have decided the first step to support sql gateway and jdbc driver as ecosystem in ververica, we are not going to put more effort on it now. Thanks for updating th

[DISCUSS] FLIP-84 Feedback Summary

2020-03-25 Thread godfrey he
Hi community, Timo, Fabian and Dawid have some feedbacks about FLIP-84[1]. The feedbacks are all about new introduced methods. We had a discussion yesterday, and most of feedbacks have been agreed upon. Here is the conclusions: *1. about proposed methods in `TableEnvironment`:* the original propo

Re: [DISCUSS] FLIP-84 Feedback Summary

2020-03-25 Thread godfrey he
s, I suggest to update the FLIP-84 again and > have another voting process. > > Thanks, > Timo > > > On 25.03.20 11:17, godfrey he wrote: > > Hi community, > > Timo, Fabian and Dawid have some feedbacks about FLIP-84[1]. The > feedbacks > > are all about n

Re: [DISCUSS] FLIP-84 Feedback Summary

2020-03-26 Thread godfrey he
design already. However, I would rather go for > non-blocking streaming queries. Also with the `EMIT STREAM` key word in > mind that we might add to SQL statements soon. > > Regards, > Timo > > [1] https://issues.apache.org/jira/browse/FLINK-16761 > [2] https://issues.apache.o

Re: [DISCUSS] FLIP-84 Feedback Summary

2020-03-30 Thread godfrey he
ything should be async > async because everything should be async > async because everything should be async > > What we should not start for executeAsyncMultilineSql(): > > sync because DDL > async because everything should be async > async because everything should be

Re: [DISCUSS] FLIP-84 Feedback Summary

2020-03-30 Thread godfrey he
unblock > > executeSql() and multiline statements. > > > > Having a `executeSqlAsync()` is useful for batch. However, I don't want > > `sync/async` be the new batch/stream flag. The execution behavior should > > come from the query itself. > > > > Regards

[VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-03-30 Thread godfrey he
Hi everyone, I'd like to start the vote of FLIP-84[1] again, because we have some feedbacks. The feedbacks are all about new introduced methods, here is the discussion thread [2]. The vote will be open for at least 72 hours. Unless there is an objection, I will try to close it by Apr 3, 2020 06:3

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-03-31 Thread godfrey he
ct feedback from all stakeholders. > > Thanks, > Timo > > On 31.03.20 08:31, godfrey he wrote: > > Hi everyone, > > > > I'd like to start the vote of FLIP-84[1] again, because we have some > > feedbacks. The feedbacks are all about new introduced methods,

Re: [DISCUSS] FLIP-84 Feedback Summary

2020-04-01 Thread godfrey he
> > > > It would be great if we can add these findings to the FLIP before we > > start voting. > > > > One minor thing: some `execute()` methods still throw a checked > > exception; can we remove that from the FLIP? Also the above mentioned > > `Iterator#

Re: [DISCUSS] FLIP-84 Feedback Summary

2020-04-01 Thread godfrey he
execute()` methods still throw a checked > exception; can we remove that from the FLIP? Also the above mentioned > `Iterator#next()` would trigger an execution without throwing a checked > exception. > > Thanks, > Timo > > [1] > > https://docs.google.com/document/d/1ueLjQWRPdLTF

Re: [ANNOUNCE] New Committers and PMC member

2020-04-01 Thread godfrey he
Congratulations to all of you~ Best, Godfrey Ismaël Mejía 于2020年4月2日周四 上午6:42写道: > Congrats everyone! > > On Thu, Apr 2, 2020 at 12:16 AM Rong Rong wrote: > > > > Congratulations to all!!! > > > > -- > > Rong > > > > On Wed, Apr 1, 2020 at 2:27 PM Thomas Weise wrote: > > > > > Congratulations

Re: [DISCUSS] FLIP-84 Feedback Summary

2020-04-01 Thread godfrey he
teMultilineSql`, I'm afraid sometimes user might > >> forget to > >> iterate the returned iterators, e.g. user submits a bunch of DDLs and > >> expect the > >> framework will execute them one by one. But it didn't. > >> > >> Best, > >

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-03 Thread godfrey he
[1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878 [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html Bests, Godfrey godfrey he 于2020年3月31日周二 下午8:42写道: > Hi, Timo > > So sorry about that, I

Re: [DISCUSS] FLIP-84 Feedback Summary

2020-04-06 Thread godfrey he
n we rephrase this part to: > > The FLIP says: > "For DML and DQL, this method returns TableResult once the job has been > submitted. For DDL and DCL statements, TableResult is returned once the > operation has finished." > > Regards, > Timo > > > On 0

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-06 Thread godfrey he
ets resolved. > > Thanks, > Timo > > On 03.04.20 15:12, Terry Wang wrote: > > +1 (non-binding) > > Looks great to me, Thanks for driving on this. > > > > Best, > > Terry Wang > > > > > > > >> 2020年4月3日 21:07,godfrey he 写道: >

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-06 Thread godfrey he
> +1 (binding) for this FLIP > > > > Regards, > > Timo > > > > > > On 06.04.20 16:47, godfrey he wrote: > > > Hi Timo, > > > > > > Sorry for late reply, and thanks for your correction. I have fixed the > > typo > >

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-07 Thread godfrey he
年4月7日周二 下午2:29写道: > +1 > > Best, > > Dawid > > On 07/04/2020 07:44, godfrey he wrote: > > Hi, Kurt > > > > yes. `TableEnvironement#executeSql` also could execute `SELECT` > statement, > > which is similar to `Table#execute`. > > I add this t

Re: [VOTE] FLIP-71: E2E View support in Flink SQL

2020-04-12 Thread godfrey he
+1 (non-binding) Best, Godfrey Benchao Li 于2020年4月12日周日 下午12:28写道: > +1 (non-binding) > > zoudan 于2020年4月12日周日 上午9:52写道: > > > +1 (non-binding) > > > > Best, > > Dan Zou > > > > > > > 在 2020年4月10日,09:30,Danny Chan 写道: > > > > > > +1 from my side. > > > > > > Best, > > > Danny Chan > > > 在 202

Re: [DISCUSS] Releasing "fat" and "slim" Flink distributions

2020-04-15 Thread godfrey he
Big +1. This will improve user experience (special for Flink new users). We answered so many questions about "class not found". Best, Godfrey Dian Fu 于2020年4月15日周三 下午4:30写道: > +1 to this proposal. > > Missing connector jars is also a big problem for PyFlink users. Currently, > after a Python us

Re: [DISCUSS] Releasing Flink 1.10.1

2020-04-16 Thread godfrey he
Thanks a lot for driving this, Yu! Some users are already asking "where to download release-1.10.1?" Looking forward to the rc. Best, Godfrey Hequn Cheng 于2020年4月16日周四 下午12:45写道: > Thanks a lot for your great work Yu! Looking forward to the RC. > > Best, Hequn > > On Thu, Apr 16, 2020 at 10:35

Re: [ANNOUNCE] New Apache Flink PMC Member - Hequn Chen

2020-04-17 Thread godfrey he
Congratulations, Hequn! Best, Godfrey Leonard Xu 于2020年4月17日周五 下午4:30写道: > Congratulations! > > Best, > Leonard Xu > > 在 2020年4月17日,15:46,Benchao Li 写道: > > > > Congratulations Hequn! > > > > Stephan Ewen 于2020年4月17日周五 下午3:42写道: > > > >> Congrats! > >> > >> On Fri, Apr 17, 2020 at 9:40 AM Jar

Re: What is the suggested way to validate SQL?

2020-01-08 Thread godfrey he
hi kaibo, As we discuss offline, I think it's a clean way that flink-table provides an interface (or a tool) to do the sql validation for platform users. `tEnv.sqlUpdate` or `tEnv.explain(false)` is a temporary solution which contains too many unrelated logic (just consider the functionality whethe

Re: [DISCUSS] FLIP-91 - Support SQL Client Gateway

2020-01-17 Thread godfrey he
Hi devs, I've updated the FLIP-91 [0] according to feedbacks. Please take another look. Best, godfrey [0] https://docs.google.com/document/d/1DKpFdov1o_ObvrCmU-5xi-VrT6nR2gxq-BbswSSI9j8/

Re: [jira] [Created] (FLINK-15644) Add support for SQL query validation

2020-01-18 Thread godfrey he
hi Flavio, TableEnvironment.getCompletionHints maybe already meet the requirement. Flavio Pompermaier 于2020年1月18日周六 下午3:39写道: > Why not adding also a suggest() method (also unimplemented initially) that > would return the list of suitable completions/tokens on the current query? > How complex eo

Re: Re: [ANNOUNCE] New Apache Flink Committer - Igal Shilman

2020-09-17 Thread godfrey he
Congratulations! Best, Godfrey Igal Shilman 于2020年9月16日周三 下午4:35写道: > Thank you all very much for your kind welcome :-) > > Thanks, > Igal. > > On Wed, Sep 16, 2020 at 8:50 AM Kostas Kloudas wrote: > > > Congratulations Igal and welcome! > > > > Kostas > > > > On Wed, Sep 16, 2020 at 6:37 AM G

Re: [ANNOUNCE] New Apache Flink Committer - Niels Basjes

2020-09-17 Thread godfrey he
Congratulations! Best, Godfrey Guowei Ma 于2020年9月16日周三 下午12:38写道: > Congratulations :) > > Best, > Guowei > > > On Tue, Sep 15, 2020 at 6:14 PM Matthias Pohl > wrote: > > > Congrats! > > > > Best, > > Matthias > > > > On Tue, Sep 15, 2020 at 9:26 AM Dawid Wysakowicz > > > wrote: > > > > > Wel

Re: [ANNOUNCE] New Apache Flink Committer - Yun Tang

2020-09-17 Thread godfrey he
Congratulations! Regards, Godfrey Yun Tang 于2020年9月17日周四 下午2:22写道: > Thanks for all your kind welcome and very glad to be one of the > committers of Flink community. > > Best > Yun Tang > > > From: Congxian Qiu > Sent: Wednesday, September 16, 2020 13:10 > To:

Re: Re: [ANNOUNCE] New Apache Flink Committer - Godfrey He

2020-09-20 Thread godfrey he
gt; >> >> >> --Original Mail -- >> Sender:Dawid Wysakowicz >> Send Date:Thu Sep 17 14:45:55 2020 >> Recipients:Flink Dev , 贺小令 >> Subject:Re: [ANNOUNCE] New Apache Flink Committer - Godfrey He >> Congratulations! >> >> On 16/09/20

[DISCUSS] Support Multiple Input for Blink Planner

2020-10-13 Thread godfrey he
Hi devs, I would like to start the discussion about supporting multiple input for blink planner. As FLIP-92[1] introduces multiple-input stream operator, we can merge the operators connected by forward shuffle into multiple input operator. So that the network shuffle can be changed to local funct

Re: [ANNOUNCE] New PMC member: Zhu Zhu

2020-10-15 Thread godfrey he
Congratulations, Zhu Godfrey, Best 刘 芃成 于2020年10月10日周六 下午1:03写道: > Congratulations, Zhu! > > Best, > Pengcheng > > 在 2020/10/10 上午11:14,“Kurt Young” 写入: > > Congratulations, Zhu Zhu! > > Best, > Kurt > > > On Sat, Oct 10, 2020 at 11:03 AM Yang Wang > wrote: > > > Congratul

Re: [VOTE] FLIP-146: Improve new TableSource and TableSink interfaces

2020-10-18 Thread godfrey he
+1 Jingsong Li 于2020年10月19日周一 上午10:54写道: > +1 > > On Fri, Oct 16, 2020 at 2:33 PM Leonard Xu wrote: > > > +1 > > > > Best, > > Leonard > > > > > 在 2020年10月16日,11:01,Jark Wu 写道: > > > > > > +1 > > > > > > On Fri, 16 Oct 2020 at 10:27, admin <17626017...@163.com> wrote: > > > > > >> +1 > > >> >

Re: [ANNOUNCE] New Apache Flink Committer - Congxian Qiu

2020-11-03 Thread godfrey he
Congratulations! Congxian Best, Godfrey Fabian Hueske 于2020年11月2日周一 下午7:00写道: > Congrats Congxian! > > Cheers, Fabian > > Am Mo., 2. Nov. 2020 um 10:33 Uhr schrieb Yang Wang >: > > > Congratulations Congxian! > > > > Best, > > Yang > > > > Zhu Zhu 于2020年11月2日周一 下午5:14写道: > > > > > Congrats Co

Re: [DISCUSS] FLIP-275: Support Remote SQL Client Based on SQL Gateway

2022-12-05 Thread godfrey he
Hi Zelin, Thanks for driving this discussion. I have a few comments, > Add RowFormat to ResultSet to indicate the format of rows. We should not require SqlGateway server to meet the display requirements of a CliClient. Because different CliClients may have different display style. The server jus

Re: [DISCUSS] FLIP-275: Support Remote SQL Client Based on SQL Gateway

2022-12-06 Thread godfrey he
ons > I agree, too. This part is moved to the ‘Future Work’. > > Best, > Yu Zelin > > > > 2022年12月5日 18:33,godfrey he 写道: > > > > Hi Zelin, > > > > Thanks for driving this discussion. > > > > I have a few comments, > > > >>

Re: [DISCUSS] Release Flink 1.16.1

2022-12-20 Thread godfrey he
Hi Martijn, Thank you for bringing this up. About Lincoln mentioned 3 commits, +1 to pick them into 1.16.1. AFAIK, several users have encountered this kind of data correctness problem so far, they are waiting a fix release as soon as possible. Best, Godfrey ConradJam 于2022年12月20日周二 15:08写道: >

Re: [VOTE] FLIP-275: Support Remote SQL Client Based on SQL Gateway

2022-12-20 Thread godfrey he
+1 (binding) Best, Godfrey Hang Ruan 于2022年12月21日周三 15:21写道: > > +1 (non-binding) > > Best, > Hang > > Paul Lam 于2022年12月20日周二 17:36写道: > > > +1 (non-binding) > > > > Best, > > Paul Lam > > > > > 2022年12月20日 11:35,Shengkai Fang 写道: > > > > > > +1(binding) > > > > > > Best, > > > Shengkai > > >

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-02 Thread godfrey he
Thanks for driving this discussion. Do we really need to expose `PlanAnalyzerFactory` as public interface? I prefer we only expose ExplainDetail#ANALYZED_PHYSICAL_PLAN and the analyzed result. Which is enough for users and consistent with the results of `explain` method. The classes about plan an

Re: [DISCUSS] Adding a option for planner to decide which join reorder rule to choose

2023-01-08 Thread godfrey he
Hi Yunhong, Thanks for driving this discuss! This option looks good to me, and looking forward to contributing this rule back to Apache Calcite. Best, Godfrey yh z 于2023年1月5日周四 15:32写道: > > Hi Benchao, > > Thanks for your reply. > > Since our existing test results are based on multiple perfo

Re: [VOTE] FLIP-280: Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-01-09 Thread godfrey he
+1 (binding) Best, Godfrey Jingsong Li 于2023年1月10日周二 09:56写道: > > +1 (binding) > > On Mon, Jan 9, 2023 at 6:19 PM Jane Chan wrote: > > > > Hi all, > > > > Thanks for all the feedback so far. > > Based on the discussion[1], we have come to a consensus, so I would like to > > start a vote on FLIP

Re: [VOTE] FLIP-279 Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-16 Thread godfrey he
+1 (binding) Best, Godfrey Shammon FY 于2023年1月12日周四 23:27写道: > > +1 (no-binding) > > > Best, > Shammon > > On Thu, Jan 12, 2023 at 8:11 PM Shengkai Fang wrote: > > > +1(binding) > > > > Best, > > Shengkai > > > > Jark Wu 于2023年1月12日周四 19:22写道: > > > > > +1 (binding) > > > Thank you for driving

[ANNOUNCE] New Apache Flink Committer - Jing Ge

2023-02-13 Thread godfrey he
Hi everyone, On behalf of the PMC, I'm very happy to announce Jing Ge as a new Flink committer. Jing has been consistently contributing to the project for over 1 year. He authored more than 50 PRs and reviewed more than 40 PRs with mainly focus on connector, test, and document modules. He was ver

Re: [External] [DISCUSS] FLIP-292: Support configuring state TTL at operator level for Table API & SQL programs

2023-04-03 Thread godfrey he
Hi Jane, Thanks for driving this FLIP. I think the compiled plan solution and the hint solution do not conflict, the two can exist at the same time. The compiled plan solution can address the need of advanced users and the platform users which all stateful operators' state TTL can be defined by u

Re: [VOTE] FLIP-292: Enhance COMPILED PLAN to support operator-level state TTL configuration

2023-04-10 Thread godfrey he
+1 (binding) Best, Godfrey Jing Ge 于2023年4月10日周一 18:42写道: > > +1 (binding) > > Best Regards, > Jing > > On Mon, Apr 10, 2023 at 12:27 PM Lincoln Lee wrote: > > > +1 (binding) > > > > Best, > > Lincoln Lee > > > > > > Jane Chan 于2023年4月10日周一 18:06写道: > > > > > Hi developers, > > > > > > Thanks

Re: [ANNOUNCE] New PMC member: Yuan Mei

2022-03-14 Thread godfrey he
Congratulations, Yuan! Best, Godfrey Lijie Wang 于2022年3月15日周二 09:18写道: > > Congratulations, Yuan! > > Best, > Lijie > > Benchao Li 于2022年3月15日周二 08:18写道: > > > Congratulations, Yuan! > > > > Yun Gao 于2022年3月15日周二 01:37写道: > > > > > Congratulations, Yuan! > > > > > > Best, > > > Yun Gao > > > >

Re: [VOTE] FLIP-214: Support Advanced Function DDL

2022-04-21 Thread godfrey he
hi Ron, I don't see any section mentioned `delete jar`, could you update it? Best, Godfrey Jing Zhang 于2022年4月21日周四 17:57写道: > > Ron, > +1 (binding) > > Thanks for driving this FLIP. > > Best, > Jing Zhang > > Jark Wu 于2022年4月21日周四 11:31写道: > > > Thanks for driving this work @Ron, > > > > +1 (

Re: Re: [VOTE] FLIP-214: Support Advanced Function DDL

2022-04-21 Thread godfrey he
t; FLIP, we will move the execution to table environment, so here is no public > api change. Moreover, I have updated the description in Core Code Design > section. > > > -原始邮件- > > 发件人: "godfrey he" > > 发送时间: 2022-04-22 12:26:44 (星期五) > >

[DISCUSS] Maintain a Calcite repository for Flink to accelerate the development for Flink SQL features

2022-04-22 Thread godfrey he
Dear devs, I would like to open a discussion on the fact that currently many Flink SQL function development relies on Calcite releases, which seriously blocks some Flink SQL's features release. Therefore, I would like to discuss whether it is possible to solve this problem by creating Flink's own

Re: [DISCUSS] Maintain a Calcite repository for Flink to accelerate the development for Flink SQL features

2022-04-22 Thread godfrey he
> > > more reliable and convenient than the official Apache Calcite that we > > want > > > to depend on. > > > > > > Thank you~ > > > > > > Xintong Song > > > > > > > > > > > > On Fri, Apr 22, 2022 at 4:

Re: [DISCUSS] Maintain a Calcite repository for Flink to accelerate the development for Flink SQL features

2022-04-22 Thread godfrey he
Calcite not creating bugfix releases? > > On 22/04/2022 12:26, godfrey he wrote: > > Thanks for the feedback, guys! > > > > For Jingsong's feedback: > >> ## Do we have the plan to upgrade calcite to 1.31? > > I think we will upgrade Calcite to 1.31 onl

Re: [DISCUSS] Maintain a Calcite repository for Flink to accelerate the development for Flink SQL features

2022-04-24 Thread godfrey he
controlled results, often causing some unexpected problems. > > Thank @Godfrey for driving this discussion in a big scope. > I think it's a good chance to review these problems and find a solution. > > Best, > Jing Zhang > > godfrey he mailto:godfre...@gmail.com>> 于2

Re: [DISCUSS] Maintain a Calcite repository for Flink to accelerate the development for Flink SQL features

2022-04-25 Thread godfrey he
ven central. The community should have permission to > deploy under the groupId. > > Best, > Jark > > > On Sun, 24 Apr 2022 at 16:14, godfrey he wrote: > > > Hi, Jing > > Thanks for sharing the Calcite experiences. > > About Calcite version upgrading, we

Re: [DISCUSS] Planning Flink 1.16

2022-04-26 Thread godfrey he
Hi Konstantin & Chesnay, Thanks for driving this discussion, I am willing to volunteer as the release manager for 1.16. Best, Godfrey Konstantin Knauf 于2022年4月26日周二 18:23写道: > > Hi everyone, > > With Flink 1.15 about to be released, the community has started planning & > developing features fo

Re: [DISCUSS] Maintain a Calcite repository for Flink to accelerate the development for Flink SQL features

2022-05-05 Thread godfrey he
; 3) No compatibility guaranteed from the Calcite community > > > > I disagree here. Many changes are protected by keeping deprecated > > methods/constructors/classes around for years. And many refactoring are > > nice also for the Flink community. E.g. easier optimizer rule d

Re: [ANNOUNCE] Apache Flink 1.15.0 released

2022-05-05 Thread godfrey he
Congratulations~ Thanks Yun, Till and Joe for driving this release and everyone who made this release happen. Best, Godfrey Becket Qin 于2022年5月5日周四 17:39写道: > > Hooray! Thanks Yun, Till and Joe for driving the release! > > Cheers, > > JIangjie (Becket) Qin > > On Thu, May 5, 2022 at 5:20 PM Tim

Re: [DISCUSS] FLIP-91: Support SQL Client Gateway

2022-05-05 Thread godfrey he
Hi Shengkai. Thanks for driving the proposal, it's been silent too long. I have a few questions: about the Architecture > The architecture of the Gateway is in the following graph. Is the TableEnvironment shared for all sessions ? about the REST Endpoint > /v1/sessions Are both local file and re

Re: [ANNOUNCE] New Flink PMC member: Yang Wang

2022-05-05 Thread godfrey he
Congratulations, Yang! Best, Godfrey Yangze Guo 于2022年5月6日周五 10:17写道: > > Congratulations Yang! > > Best, > Yangze Guo > > On Fri, May 6, 2022 at 10:11 AM Forward Xu wrote: > > > > Congratulations, Yang! > > > > > > Best, > > > > Forward > > > > Jingsong Li 于2022年5月6日周五 10:07写道: > > > > > Cong

Re: [DISCUSS] FLIP-91: Support SQL Client Gateway

2022-05-06 Thread godfrey he
> > > > > > > > > > > a) it will not be possible to have separate releases of the Gateway, > > > > they will be tied to individual Flink releases > > > > I don't think it's a problem. On the contrary, maintaining a separate > >

Re: Re: 【Could we support distribute by For FlinkSql】

2022-05-10 Thread godfrey he
Hi, Ipengdream. I will drive this work. We will support this functionality via hints, because "distribute by" is not in the sql standard. But it will be supported in hive dialect. I will post the FLIP doc recently. Best, Godfrey Jark Wu 于2022年5月9日周一 16:03写道: > > We will start a FLIP discussion

[DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-13 Thread godfrey he
Hi all, I would like to open a discussion on FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors. Statistics are one of the most important inputs to the optimizer. Accurate and complete statistics allows the optimizer to be more powerful. Currently,

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-16 Thread godfrey he
nd the partition prune happen before the stats reporting. > - only partition prune happens > - only filter pushdown happens > - both filter pushdown and partition prune happen > > Best, > Jingsong > > On Fri, May 13, 2022 at 6:57 PM godfrey he wrote: > > >

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-05-17 Thread godfrey he
Hi Paul, Thanks for driving this, LGTM overall. I have a few minor comments: >SHOW QUERIES I want to clear the scope the command, does the command show the queries submitted via SqlClient, or all queries in current cluster (submitted via other CLI)? History queries are included? What's the behav

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-17 Thread godfrey he
Hi Mang, Thanks for driving this FLIP. Please follow the FLIP template[1] style, and the `Syntax ` is part of the `Public API Changes` section. ‘Program research’ and 'Implementation Plan' are part of the `Proposed Changes` section, or move ‘Program research’ to the appendix. > Providing methods

Re: [VOTE] FLIP-229: Introduces Join Hint for Flink SQL Batch Job

2022-05-17 Thread godfrey he
Thanks Xuyang for driving this, +1(binding) Best, Godfrey Xuyang 于2022年5月17日周二 10:21写道: > > Hi, everyone. > Thanks for your feedback for FLIP-229: Introduces Join Hint for Flink SQL > Batch Job[1] on the discussion thread[2]. > I'd like to start a vote for it. The vote will be open for at least

Re: [VOTE] FLIP-91: Support SQL Gateway

2022-05-22 Thread godfrey he
+1 Best, Godfrey LuNing Wang 于2022年5月23日周一 13:06写道: > > +1 (non-binding) > > Best, > LuNing Wang > > Nicholas Jiang 于2022年5月23日周一 12:57写道: > > > +1 (non-binding) > > > > Best, > > Nicholas Jiang > > > > On 2022/05/20 02:38:39 Shengkai Fang wrote: > > > Hi, everyone. > > > > > > Thanks for your

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-23 Thread godfrey he
Filesystem connector. > > Best, > Jark > > > > > On Tue, 17 May 2022 at 10:52, Jingsong Li wrote: > > > Hi Godfrey, > > > > Thanks for your reply. > > > > Sounds good to me. > > > > > I think we should also introduce a config

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-05-23 Thread godfrey he
WRT ‘DROP QUERY’, > >>> What's the behavior for batch jobs and the non-running jobs? > >> > >> > >> In general, the behavior would be aligned with Flink CLI. Triggering a > >> savepoint for > >> a non-running job would cause errors, and the error message would be > >> printed to > >> the SQL client. Triggering a savepoint for batch(unbounded) jobs in > >> streaming > >> execution mode would be the same with streaming jobs. However, for batch > >> jobs in > >> batch execution mode, I think there would be an error, because batch > >> execution > >> doesn’t support checkpoints currently (please correct me if I’m wrong). > >> > >> WRT ’SHOW SAVEPOINTS’, I’ve thought about it, but Flink clusterClient/ > >> jobClient doesn’t have such a functionality at the moment, neither do > >> Flink CLI. > >> Maybe we could make it a follow-up FLIP, which includes the modifications > >> to > >> clusterClient/jobClient and Flink CLI. WDYT? > >> > >> Best, > >> Paul Lam > >> > >>> 2022年5月17日 20:34,godfrey he 写道: > >>> > >>> Godfrey > >> > >> >

Re: Re: [DISCUSS] FLIP-218: Support SELECT clause in CREATE TABLE(CTAS)

2022-05-23 Thread godfrey he
t; the job can be submitted in > > detached mode. > > > > With this interface, we can easily support LEVEL-2 semantics by calling > > `Catalog#dropTable` in the > > `JobListener#onJobFailed`. We can also support LEVEL-3 by introducing > > `StagingTableCatalog` like Spark,

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-27 Thread godfrey he
FLIP. I prefer a option for > > FileSystemConnector, maybe a enum. > > > > Best, > > Jingsong > > > > On Tue, May 17, 2022 at 10:31 AM godfrey he wrote: > > > > > Hi Jingsong, > > > > > > Thanks for the feedback. > &g

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-31 Thread godfrey he
ics-type" > > is not very straightforward and clean to me. Maybe > > "source.report-statistics" = "none/all/file-size" > > would be better. > > > > We can also change "table.optimizer.source.connect-statistics-enabled" to > > "table.optimizer.source.report-s

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-05-31 Thread godfrey he
ut introducing some kind of > Action/Performer interface with many subclasses and factory class to get > rid of some if-else statements, which could optionally be the next step > provement in the future. > > Best regards, > Jing > > On Tue, May 31, 2022 at 3:42 PM godfrey he

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-05 Thread godfrey he
Hi Shengkai, Thanks for driving this. I have a few comments: Could you give a whole architecture about the Ecosystem of HiveServers and the SqlGateway, such as JDBC driver, Beeline, etc. Which is more clear for users. > Considering the different users may have different requirements to connect

Re: [DISCUSS] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-06-06 Thread godfrey he
Hi, everyone. Thanks for all the inputs. Since there is no feedback any more, I will start the vote tomorrow. Best, Godfrey godfrey he 于2022年6月1日周三 13:30写道: > > Hi, Jing. > > Thanks for the suggestion, I have updated the doc and > will continue to optimize the code in subseque

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-06 Thread godfrey he
gt; "hive.metastore.urls". Here I just mean users can switch to connect to > different metastore instances using the CREATE CATALOG DDL. I updated the > FLIP to make it more clear. > > Best, > Shengkai > > godfrey he 于2022年6月6日周一 13:45写道: > > > Hi Shengkai, > &

[VOTE] FLIP-231: Introduce SupportStatisticReport to support reporting statistics from source connectors

2022-06-06 Thread godfrey he
Hi everyone, Thanks for all the feedback so far. Based on the discussion[1] we seem to have consensus, so I would like to start a vote on FLIP-231 for which the FLIP has now also been updated[2]. The vote will last for at least 72 hours (Jun 10th 12:00 GMT) unless there is an objection or insuffi

Re: [VOTE] FLIP-234: Support Retryable Lookup Join To Solve Delayed Updates Issue In External Systems

2022-06-08 Thread godfrey he
+1 Best, Godfrey Jingsong Li 于2022年6月9日周四 10:26写道: > > +1 (binding) > > Best, > Jingsong > > On Tue, Jun 7, 2022 at 5:21 PM Jark Wu wrote: > > > > +1 (binding) > > > > Best, > > Jark > > > > On Tue, 7 Jun 2022 at 12:17, Lincoln Lee wrote: > > > > > Dear Flink developers, > > > > > > Thanks for

Re: [VOTE] FLIP-223: Support HiveServer2 Endpoint

2022-06-08 Thread godfrey he
+1 Best, Godfrey Jark Wu 于2022年6月7日周二 17:21写道: > > +1 (binding) > > Best, > Jark > > On Tue, 7 Jun 2022 at 13:32, Shengkai Fang wrote: > > > Hi, everyone. > > > > Thanks for all feedback for FLIP-223: Support HiveServer2 Endpoint[1] on > > the discussion thread[2]. I'd like to start a vote for

Re: [DISCUSS] FLIP-222: Support full query lifecycle statements in SQL client

2022-06-08 Thread godfrey he
t;>>>> >>>>> Hi Paul, >>>>> >>>>> I'm still doubting the keyword for the SQL applications. SHOW QUERIES >>>>> could >>>>> imply that this will actually show the query, but we're returning IDs of >>>>> the

[RESULT][VOTE] FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors

2022-06-09 Thread godfrey he
Hi, everyone. FLIP-231: Introduce SupportsStatisticReport to support reporting statistics from source connectors[1] has been accepted. There are 5 binding votes, 1 non-binding votes[2]. - Jing Ge(non-binding) - Jark Wu(binding) - Jingsong Li(binding) - Martijn Visser(binding) - Jing Zhang(binding

[DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-10 Thread godfrey he
Hi all, I would like to open a discussion on FLIP-240: Introduce "ANALYZE TABLE" Syntax. As FLIP-231 mentioned, statistics are one of the most important inputs to the optimizer. Accurate and complete statistics allows the optimizer to be more powerful. "ANALYZE TABLE" syntax is a very common but

Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-12 Thread godfrey he
g 'ANALYZE TABLE' > from the user side? > > nit: There maybe exists a mistake in Examples#partition table > the partition info should be > > Partition1: (ds='2022-06-01', hr=1) > > Partition2: (ds='2022-06-01', hr=2) > > Partition3: (ds=

Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-12 Thread godfrey he
ative? > I could imagine that for many connectors, statistics could be > implemented in a less expensive way by leveraging the underlying system > (e.g. a JDBC connector can get a row count estimate without performing a > SELECT COUNT(1)). > > > Best > Ingo > > > O

Re: [DISCUSS] FLIP-240: Introduce "ANALYZE TABLE" Syntax

2022-06-12 Thread godfrey he
eration I'm OK with doing > that here in principle. However, I wonder what will happen in the > streaming / unbounded case. Do you plan to throw an error? Or do we > complete the command as successful but without doing anything? > > > Best > Ingo > > On 13.06.22 05:5

Re: [ANNOUNCE] New Apache Flink PMC Member - Jingsong Lee

2022-06-13 Thread godfrey he
Congratulations, Jingsong! Best, Godfrey Shuo Cheng 于2022年6月13日周一 16:43写道: > > Congratulations, Jingsong! > > On 6/13/22, Paul Lam wrote: > > Congrats, Jingsong! Well deserved! > > > > Best, > > Paul Lam > > > >> 2022年6月13日 16:31,Lincoln Lee 写道: > >> > >> Congratulations, Jingsong! > >> > >> B

Re: [DISCUSS] FLIP-190: Support Version Upgrades for Table API & SQL Programs

2021-11-22 Thread godfrey he
Hi Timo, Thanks for driving this discussion, the sql job's upgrading compatibility always is a big pain point. In the last version we completed some work, this FLIP will make the whole upgrade story possible. I have a few comments: 1) "EXPLAIN PLAN EXECUTE STATEMENT SET BEGIN ... END" is missing

Re: [VOTE][FLIP-195] Improve the name and structure of vertex and operator name for job

2021-11-23 Thread godfrey he
+1 (binding) Best, Godfrey Jark Wu 于2021年11月24日周三 下午12:02写道: > > +1 (binding) > > Btw, @JingZhang I think your vote can be counted into binding now. > > Best, > Jark > > On Tue, 23 Nov 2021 at 20:19, Jing Zhang wrote: > > > +1 (non-binding) > > > > Best, > > Jing Zhang > > > > Martijn Visser 于

Re: [VOTE] FLIP-188 Introduce Built-in Dynamic Table Storage

2021-11-30 Thread godfrey he
+1 (binding) Best, Godfrey Jark Wu 于2021年11月30日周二 下午5:47写道: > > Thanks for the great discussion and updating. > Still +1 from my side. > > Best, > Jark > > On Tue, 30 Nov 2021 at 17:27, Kurt Young wrote: > > > +1 from my side. > > > > Best, > > Kurt > > > > > > On Tue, Nov 30, 2021 at 5:12 PM

Re: [DISCUSS] FLIP-190: Support Version Upgrades for Table API & SQL Programs

2021-12-06 Thread godfrey he
Hi, Timo, Thanks for the detailed explanation. > We change an operator state of B in Flink 1.16. We perform the change in the > operator of B in a way to support both state layouts. Thus, no need for a new > ExecNode version. I think this design makes thing more complex. 1. If there are multip

Re: [DISCUSS] FLIP-190: Support Version Upgrades for Table API & SQL Programs

2021-12-08 Thread godfrey he
ed for > >> 90% > >>>>> of all changes. > >>>>> > >>>>>> If there are multiple state layouts, which layout the ExecNode > >> should > >>>>> use? > >>>>> > >>>>> It is no

  1   2   3   4   5   >