[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-14 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/259 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-14 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-14 Thread joeymcallister
Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 Tweaked the build instructions to include `build install` before `rackup`. Also moved the README, which focuses on building the docs, to the `geode-book` dir (and pointed to it from

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-14 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/259 @joeymcallister - Ok, the parallel directories makes more sense now. We can always move stuff around after 1.0 if we decide to. I also had to do bundle install in the

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread joeymcallister
Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 @upthewaterspout: > Add the final_app and output directories to the rat excludes, so people don't have rat failures after building the docs. Excellent suggestion.

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread joeymcallister
Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 @metatype 1. Running `bundle install` in the final_app dir isn't something I'm familiar with. We don't usually have to do it, and I'm currently able to build and `rackup`

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread joeymcallister
Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 @upthewaterspout Bookbinder requires the "book" directory to be at the same dir level as the content, so a subdirectory wouldn't work here. If the goal is to clean up the top level,

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/259 I think geode-docs should be a subdirectory of geode-book so we don't have two unrelated directories for these docks. It should probably output to a directory called build

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 I think the README could use a few clarifications: 1) You also need to run `bundle install` in the final_app dir. 2) How do we take the generated html site and merge it into the

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread karensmolermiller
Github user karensmolermiller commented on the issue: https://github.com/apache/incubator-geode/pull/259 +1 I built with bookbinder and viewed with rackup, per the README.md instructions. Running `./gradlew rat` passed the license check: no licensing issues. --- If your

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread joeymcallister
Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 @sbawaska Commit 2b6fec8 corrects the license issues and I was able to build successfully. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread davebarnes97
Github user davebarnes97 commented on the issue: https://github.com/apache/incubator-geode/pull/259 +1 Bookbinder publishing procedure worked for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread joeymcallister
Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 `geode-book` is a source directory containing the pieces (e.g., the `config.yml` that points Bookbinder to content, and the `geode-subnav.erb` that provides the book's table of

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 Is `geode-book` a generated dir or a source directory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread Joey McAllister
Hi Swapnil, Yes, I'm working on that right now and will resubmit. Joey On Thu, Oct 13, 2016 at 1:40 PM sbawaska wrote: > Github user sbawaska commented on the issue: > > https://github.com/apache/incubator-geode/pull/259 > > Hi @joeymcallister The CI failed

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

2016-10-13 Thread sbawaska
Github user sbawaska commented on the issue: https://github.com/apache/incubator-geode/pull/259 Hi @joeymcallister The CI failed because the new files are missing the Apache License header. Can you please fix this and re-submit the pull request? ``` 71 Unknown Licenses