[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-11-30 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-manual/pull/66 GUACAMOLE-363: Add SQL Server documentation to database manual page. This PR adds the documentation for the SQL Server JDBC extensions to the database authentication page. You can

[GitHub] guacamole-manual pull request #67: GUACAMOLE-243: Add documentation for new ...

2017-11-30 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-manual/pull/67 GUACAMOLE-243: Add documentation for new referral parameters Adds documentation for the parameters added for managing how the LDAP extensions behaves regarding referrals. You can merge

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r156173461 --- Diff: src/chapters/jdbc-auth.xml --- @@ -97,9 +97,29 @@ depends on the version of Java you have installed

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r156173539 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +321,60 @@ Type "help" for help. to run any database upgra

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r156173618 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +321,60 @@ Type "help" for help. to run any database upgra

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r156173420 --- Diff: src/chapters/jdbc-auth.xml --- @@ -97,9 +97,29 @@ depends on the version of Java you have installed

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r156173491 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +321,60 @@ Type "help" for help. to run any database upgra

[GitHub] guacamole-manual pull request #66: GUACAMOLE-363: Add SQL Server documentati...

2017-12-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/66#discussion_r156170858 --- Diff: src/chapters/jdbc-auth.xml --- @@ -299,6 +321,60 @@ Type "help" for help. to run any database upgra

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r186860117 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectDirectory.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r186857930 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectionGroup.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r186859701 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,233

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r187981053 --- Diff: extensions/guacamole-auth-quickconnect/src/test/java/org/apache/guacamole/auth/quickconnect/utility/QCParserTest.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r187968051 --- Diff: extensions/guacamole-auth-quickconnect/src/test/java/org/apache/guacamole/auth/quickconnect/utility/QCParserTest.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r187967894 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,232

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-09 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r187026140 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,233

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-28 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r184853372 --- Diff: extensions/guacamole-auth-quickconnect/src/licenses/bundled/aopalliance-1.0/LICENSE --- @@ -0,0 +1,4 @@ +From http

[GitHub] guacamole-client pull request #278: GUACAMOLE-526: Handle absolutely all pro...

2018-04-28 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/278#discussion_r184854136 --- Diff: guacamole/src/main/webapp/app/rest/services/activeConnectionService.js --- @@ -66,68 +65,6 @@ angular.module('rest').factory

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r187771304 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectionGroup.java --- @@ -0,0

[GitHub] guacamole-server pull request #167: GUACAMOLE-565: Add terminal-type paramet...

2018-05-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/167#discussion_r188934035 --- Diff: src/protocols/telnet/settings.c --- @@ -181,6 +182,12 @@ enum TELNET_ARGS_IDX { */ IDX_BACKSPACE

[GitHub] guacamole-client pull request #280: GUACAMOLE-152: Allow zoom/scale to be ma...

2018-05-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/280#discussion_r188652586 --- Diff: guacamole/src/main/webapp/app/client/templates/client.html --- @@ -151,7 +151,12 @@ {{'CLIENT.SECTION_HEADER_DISPLAY' | translate

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-21 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r189586135 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,64 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r190593831 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,64 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r190593972 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,64 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r190594153 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -822,6 +838,32 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r189133551 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -184,6

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-17 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r189133734 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -184,6

[GitHub] guacamole-client pull request #295: GUACAMOLE-565: Add en translations for t...

2018-06-06 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/295#discussion_r193361549 --- Diff: guacamole/src/main/webapp/translations/en.json --- @@ -475,6 +476,14 @@ "FIELD_OPTION_FONT_SIZE_96"

[GitHub] guacamole-manual pull request #87: GUACAMOLE-38: Add chapter for Quickconnec...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/87#discussion_r194400233 --- Diff: src/chapters/quickconnect.xml --- @@ -0,0 +1,90 @@ + + +http://docbook.org/ns/docbook; version="5.0" xm

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194409880 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -236,6 +253,58

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194412245 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -236,6 +253,58

[GitHub] guacamole-manual pull request #87: GUACAMOLE-38: Add chapter for Quickconnec...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/87#discussion_r194417517 --- Diff: src/chapters/quickconnect.xml --- @@ -0,0 +1,90 @@ + + +http://docbook.org/ns/docbook; version="5.0" xm

[GitHub] guacamole-manual pull request #87: GUACAMOLE-38: Add chapter for Quickconnec...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-manual/pull/87#discussion_r194428065 --- Diff: src/chapters/quickconnect.xml --- @@ -0,0 +1,90 @@ + + +http://docbook.org/ns/docbook; version="5.0" xm

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-12 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-client/pull/301 GUACAMOLE-360: Allow users to kill their own sessions This is the first of a few changes related to GUACAMOLE-360 - this one makes a few minor changes that allow users to kill

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194162564 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -26,12 +26,21

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194167124 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -236,6 +253,58

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194167771 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java --- @@ -23,6 +23,10 @@ import java.util.Date

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194164950 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -236,6 +253,58

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194169785 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java --- @@ -74,6 +78,12 @@ */ private

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-08 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194163526 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -221,6 +230,14

[GitHub] guacamole-client pull request #298: GUACAMOLE-571: Fix rootConnectionGroup t...

2018-06-07 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-client/pull/298 GUACAMOLE-571: Fix rootConnectionGroup typo in homeController. Quick fix to typo reported on dev mailing list [1]. [1] - http://mail-archives.apache.org/mod_mbox/guacamole-dev

[GitHub] guacamole-server pull request #173: GUACAMOLE-574: Allow input for SSH/telne...

2018-06-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/173#discussion_r196084299 --- Diff: src/terminal/terminal/terminal.h --- @@ -568,17 +576,97 @@ int guac_terminal_printf(guac_terminal* terminal, const char* format

[GitHub] guacamole-server pull request #173: GUACAMOLE-574: Allow input for SSH/telne...

2018-06-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/173#discussion_r196083987 --- Diff: src/terminal/terminal/terminal.h --- @@ -568,17 +576,97 @@ int guac_terminal_printf(guac_terminal* terminal, const char* format

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196253739 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196258355 --- Diff: guacamole/src/main/webapp/app/navigation/services/userPageService.js --- @@ -257,15 +257,23 @@ angular.module('navigation').factory

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196265369 --- Diff: guacamole/src/main/webapp/app/navigation/services/userPageService.js --- @@ -257,15 +257,23 @@ angular.module('navigation').factory

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196270568 --- Diff: guacamole/src/main/webapp/app/navigation/services/userPageService.js --- @@ -257,15 +257,23 @@ angular.module('navigation').factory

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r194934397 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r194937148 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194879510 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -221,21

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194880927 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/AuthenticatedUser.java --- @@ -53,6 +61,59

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194867108 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AbstractAuthenticatedUser.java --- @@ -41,4 +42,12 @@ public void

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194870590 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -221,21

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194870376 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -189,7 +197,7

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194866630 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/AuthenticatedUser.java --- @@ -53,6 +61,72

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194869441 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java --- @@ -21,9 +21,10 @@ import

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194865378 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java --- @@ -344,4 +344,20

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194864605 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -221,21

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-12 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194866759 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/AuthenticatedUser.java --- @@ -53,6 +61,72

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-13 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r195110827 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/AuthenticatedUser.java --- @@ -20,7 +20,10

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-15 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r195711510 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java --- @@ -74,6 +76,11 @@ */ private

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-15 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r195712691 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-15 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r195743264 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-15 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r195792533 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-15 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r195791116 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user

[GitHub] guacamole-client pull request #300: GUACAMOLE-146: Allow webapp context to b...

2018-06-11 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-client/pull/300 GUACAMOLE-146: Allow webapp context to be specified in Docker Simple change that allows the application context to be specified for Guacamole within the Docker image, or defaults

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194521920 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/AuthenticatedUser.java --- @@ -20,15 +20,19

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194525537 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/AuthenticatedUser.java --- @@ -20,15 +20,19

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194525708 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java --- @@ -126,6 +127,10

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194526230 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -221,21

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194526588 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -22,10 +22,18

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194525160 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java --- @@ -23,6 +23,8 @@ import java.util.Date

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194527078 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -221,21

[GitHub] guacamole-client pull request #299: GUACAMOLE-524: Allow custom LDAP attribu...

2018-06-11 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/299#discussion_r194520899 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java --- @@ -36,6 +36,7

[GitHub] guacamole-client pull request #301: GUACAMOLE-360: Allow users to kill their...

2018-06-19 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/301#discussion_r196613490 --- Diff: guacamole/src/main/webapp/translations/fr.json --- @@ -624,7 +624,9 @@ "FORMAT_STAR

[GitHub] guacamole-client pull request #288: GUACAMOLE-565: Add terminal-type paramet...

2018-05-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/288#discussion_r191073000 --- Diff: guacamole-ext/src/main/resources/org/apache/guacamole/protocols/ssh.json --- @@ -83,6 +83,11 @@ "

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-client/pull/291 GUACAMOLE-566: Replace RESTExceptionWrapper with GuacamoleExceptionMapper Per the discussion on the mailing list ([1]) this change implements the `GuacamoleExceptionMapper` class

[GitHub] guacamole-client pull request #288: GUACAMOLE-565: Add terminal-type paramet...

2018-05-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/288#discussion_r191073017 --- Diff: guacamole-ext/src/main/resources/org/apache/guacamole/protocols/telnet.json --- @@ -66,6 +66,11 @@ "

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191626164 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionWrapper.java --- @@ -1,203 +0,0 @@ -/* - * Licensed

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191626099 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/RESTServiceModule.java --- @@ -83,11 +83,9 @@ protected void configureServlets

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191626020 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/GuacamoleExceptionMapper.java --- @@ -0,0 +1,110 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-30 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191716697 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionMapper.java --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-30 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191715853 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionMapper.java --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #291: GUACAMOLE-566: Replace RESTExceptionWrap...

2018-05-30 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/291#discussion_r191717265 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionMapper.java --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] guacamole-server pull request #169: GUACAMOLE-422: Add support for timezone ...

2018-06-02 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-server/pull/169 GUACAMOLE-422: Add support for timezone redirection These are the server-side changes necessary to support timezone redirection for RDP and SSH. I originally attempted to implement

[GitHub] guacamole-client pull request #292: GUACAMOLE-524: Add attributes to credent...

2018-06-04 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-client/pull/292 GUACAMOLE-524: Add attributes to credentials and token filter This is the first in a set of at least a couple of pull requests that allows user attributes retrieved in various

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r191104171 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,71 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r191086955 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,63 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-client pull request #287: GUACAMOLE-540: Make remote address proce...

2018-07-01 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/287#discussion_r199348882 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/ModeledUserContext.java

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197788208 --- Diff: src/common-ssh/key.c --- @@ -245,3 +246,84 @@ int guac_common_ssh_key_sign(guac_common_ssh_key* key, const char* data

[GitHub] guacamole-manual pull request #88: GUACAMOLE-527: Correct link to Apache JIR...

2018-06-26 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-manual/pull/88 GUACAMOLE-527: Correct link to Apache JIRA tracker. Correct the link to the JIRA issue tracker on the configuration page. You can merge this pull request into a Git repository

[GitHub] guacamole-client pull request #270: GUACAMOLE-527: Client-side changes for S...

2018-06-26 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/270#discussion_r198273481 --- Diff: guacamole/src/main/webapp/translations/en.json --- @@ -364,6 +364,7 @@ "FIELD_HEADER_SECURITY": &quo

[GitHub] guacamole-client pull request #270: GUACAMOLE-527: Client-side changes for S...

2018-06-26 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/270#discussion_r198273111 --- Diff: guacamole-ext/src/main/resources/org/apache/guacamole/protocols/ssh.json --- @@ -12,6 +12,10

[GitHub] guacamole-client pull request #270: GUACAMOLE-527: Client-side changes for S...

2018-06-26 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/270#discussion_r198272676 --- Diff: guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json --- @@ -329,6 +329,10 @@ "

[GitHub] guacamole-client pull request #270: GUACAMOLE-527: Client-side changes for S...

2018-06-26 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/270#discussion_r198272834 --- Diff: guacamole-ext/src/main/resources/org/apache/guacamole/protocols/ssh.json --- @@ -12,6 +12,10

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197887137 --- Diff: src/common-ssh/common-ssh/key.h --- @@ -166,5 +169,52 @@ void guac_common_ssh_key_free(guac_common_ssh_key* key); int

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197887124 --- Diff: src/common-ssh/key.c --- @@ -245,3 +246,86 @@ int guac_common_ssh_key_sign(guac_common_ssh_key* key, const char* data

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197887031 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,40 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197886978 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,40 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197978466 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,43 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-06-25 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r197749922 --- Diff: src/common-ssh/key.c --- @@ -245,3 +246,84 @@ int guac_common_ssh_key_sign(guac_common_ssh_key* key, const char* data

  1   2   3   4   5   >