Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-server/pull/154
---
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r12638
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -165,9 +165,6 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r12472
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.h ---
@@ -35,7 +35,7 @@
* Registers a new printer device within the RDPDR plugin.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r12481
--- Diff: src/protocols/rdp/compat/winpr-stream.h ---
@@ -60,6 +60,7 @@
#define Stream_Buffer stream_get_head
#define
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r12432
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -200,10 +180,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin*
rdpdr) {
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r12453
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_service.h ---
@@ -74,23 +74,43 @@ struct guac_rdpdr_device {
int device_id;
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r11562
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_service.h ---
@@ -74,23 +74,43 @@ struct guac_rdpdr_device {
int device_id;
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r11519
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -200,10 +180,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin*
rdpdr) {
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r11453
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_service.h ---
@@ -74,23 +74,43 @@ struct guac_rdpdr_device {
int device_id;
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r11425
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.h ---
@@ -35,7 +35,7 @@
* Registers a new printer device within the RDPDR plugin.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199947992
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_service.h ---
@@ -74,23 +74,43 @@ struct guac_rdpdr_device {
int device_id;
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199947659
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -200,10 +180,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin*
rdpdr) {
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199946899
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_service.h ---
@@ -74,23 +74,43 @@ struct guac_rdpdr_device {
int device_id;
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199946212
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.h ---
@@ -35,7 +35,7 @@
* Registers a new printer device within the RDPDR plugin.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199945754
--- Diff: src/protocols/rdp/compat/winpr-stream.h ---
@@ -60,6 +60,7 @@
#define Stream_Buffer stream_get_head
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199757015
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -122,20 +124,28 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199685199
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -122,20 +124,28 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199683587
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -122,20 +124,28 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199681225
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -122,20 +124,28 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199681190
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -138,10 +138,10 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199654289
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -200,10 +182,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin*
rdpdr) {
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199628303
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -165,9 +165,6 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625976
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625637
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625565
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625398
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -122,20 +124,28 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625189
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625343
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -200,10 +182,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin*
rdpdr) {
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625085
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625009
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199620515
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -200,10 +182,43 @@ void guac_rdpdr_register_printer(guac_rdpdrPlugin*
rdpdr) {
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199616415
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199615305
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199621521
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -122,20 +124,28 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r178701688
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +143,25 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r178643311
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +143,25 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r178485119
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +143,25 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r176919230
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +143,25 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r176918817
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +143,25 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r175278420
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +143,25 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r175278409
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +143,25 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r172006140
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +142,23 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r172005983
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +142,23 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r170931914
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -273,3 +273,15 @@ void
guac_rdpdr_process_prn_using_xps(guac_rdpdrPlugin* rdpdr,
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r170931972
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -273,3 +273,15 @@ void
guac_rdpdr_process_prn_using_xps(guac_rdpdrPlugin* rdpdr,
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r170931887
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +141,20 @@ static void
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r170829383
--- Diff: src/protocols/rdp/rdp_settings.c ---
@@ -726,6 +732,11 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r170829042
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +141,20 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r170243969
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +141,20 @@ static void
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r170243837
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -273,3 +273,15 @@ void
guac_rdpdr_process_prn_using_xps(guac_rdpdrPlugin* rdpdr,
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r170243694
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -273,3 +273,15 @@ void
guac_rdpdr_process_prn_using_xps(guac_rdpdrPlugin* rdpdr,
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-server/pull/154
GUACAMOLE-445: Make Printer Name Configurable
This adds the parameters and changes to rdpdr to make the printer name
configurable in the RDP session.
I'm not sure if we had
52 matches
Mail list logo
