ashvina commented on a change in pull request #2821: Update Dhalion dependency
version
URL: https://github.com/apache/incubator-heron/pull/2821#discussion_r179617608
##
File path:
heron/healthmgr/src/java/com/twitter/heron/healthmgr/detectors/SkewDetector.java
##
@@
Hi Karthik,
If the purpose of “owners” is to make this change that is fine. Otherwise
having official owners of code is not really the Apache Way. Identifying people
who know a portion best is fine, but the whole project and Apache “own” the
code now for the public good.
A lot of the time
sreev commented on issue #2840: merge rename from com.twitter to org.apache
[apache#2828]
URL: https://github.com/apache/incubator-heron/pull/2840#issuecomment-379096978
redoing the rename from the beginning.
This is an
That’s up to the project to decide. ;)
Mentors are here to help you make sure what you decide upon is consistent with
the Apache Way.
-Taylor
> On Apr 5, 2018, at 7:50 PM, Karthik Ramasamy wrote:
>
> Thanks Dave and Taylor for the advice. Owners is not probably what I
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630500
##
File path: heron/tmaster/src/cpp/manager/tmaster.cpp
##
@@ -758,7
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179627565
##
File path: heron/common/src/cpp/network/client.h
##
@@ -245,7
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630977
##
File path: heron/tmaster/src/cpp/manager/stateful-restorer.cpp
##
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631017
##
File path: heron/tmaster/src/cpp/manager/stateful-controller.cpp
##
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179628026
##
File path: heron/instance/src/cpp/boltimpl/bolt-instance.cpp
##
@@
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631445
##
File path: heron/stmgr/src/cpp/manager/stmgr.cpp
##
@@ -1085,7
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630042
##
File path: heron/stmgr/src/cpp/manager/stmgr-server.cpp
##
@@
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179628759
##
File path: heron/statemgrs/src/cpp/statemgr/heron-zkstatemgr.cpp
##
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179627824
##
File path: heron/common/src/cpp/zookeeper/zkclient.cpp
##
@@
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631189
##
File path: heron/stmgr/src/cpp/util/xor-manager.cpp
##
@@ -59,17
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179626993
##
File path: heron/common/src/cpp/network/baseconnection.cpp
##
@@
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631595
##
File path: heron/stmgr/src/cpp/manager/stmgr.cpp
##
@@ -282,7
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630646
##
File path: heron/tmaster/src/cpp/manager/tmaster.cpp
##
@@ -116,7
Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179632002
##
File path: heron/stmgr/src/cpp/manager/stmgr-clientmgr.cpp
##
@@
ashvina commented on a change in pull request #2821: Update Dhalion dependency
version
URL: https://github.com/apache/incubator-heron/pull/2821#discussion_r179617618
##
File path:
heron/healthmgr/src/java/com/twitter/heron/healthmgr/diagnosers/SlowInstanceDiagnoser.java
sreev commented on issue #2840: merge rename from com.twitter to org.apache
[apache#2828]
URL: https://github.com/apache/incubator-heron/pull/2840#issuecomment-379108685
i am closing this PR, now and will reopen a brand new, later, soon.
Ashvin -
It could be good to designate owners for different areas - let me come up
with a list by the end of the today tonight.
cheers
/karthik
On Thu, Apr 5, 2018 at 11:42 AM, Ning Wang wrote:
> Make sense to me.
>
>
>
> On Thu, Apr 5, 2018 at 9:19 AM, Ashvin A
kramasamy commented on issue #2840: merge rename from com.twitter to org.apache
[apache#2828]
URL: https://github.com/apache/incubator-heron/pull/2840#issuecomment-379090423
It might be easier if you could help test in yarn cluster - since we don't
have access to it at streamlio. Just
As a mentor, I would recommend you avoid any concept of “ownership” like the
plague. It implies a project hierarchy that ASF projects do not have.
In ASF projects committer bits are boolean. Bob’s committer bit is no different
from Alice’s. Their project expertise may lie in different areas of
Thanks Dave and Taylor for the advice. Owners is not probably what I meant.
Instead, I could call them Reviewers - for this PR.
Long term since there are so many different modules and each committer
develop different area of expertise, what is the recommended
way to review the code and merge them
I would be happy to review all of the ECO codebase and examples to verify
that the package change has not caused any issues.
-Josh
On Thu, Apr 5, 2018 at 6:54 PM P. Taylor Goetz wrote:
> That’s up to the project to decide. ;)
>
> Mentors are here to help you make sure what
kramasamy closed pull request #2849: Eco for heron topologies
URL: https://github.com/apache/incubator-heron/pull/2849
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
kramasamy commented on issue #2788: Remove Scribe support?
URL:
https://github.com/apache/incubator-heron/issues/2788#issuecomment-378922511
We are working to see if we can remove scribe support.
Sent from my iPhone
> On Apr 5, 2018, at 1:12 AM, Horatio
ashvina commented on issue #2840: merge rename from com.twitter to org.apache
[apache#2828]
URL: https://github.com/apache/incubator-heron/pull/2840#issuecomment-378989112
Also, I think it will be worthwhile sharing the tests executed to verify the
change. In this case I believe unit
ajorgensen opened a new pull request #2850: Add SSL support for stream manager
connections
URL: https://github.com/apache/incubator-heron/pull/2850
This commit adds ssl support for connection between stream managers. The
main purpose of this change is to protect data that is in-transit
joshfischer1108 opened a new pull request #2851: Joshfischer/eco stateful
topology
URL: https://github.com/apache/incubator-heron/pull/2851
@kramasamy This pull request includes two examples on how to use ECO to
deploy stateful topologies.
To run the two examples execute the
Hey Ali
The ASF Jenkins build system is at https://builds.apache.org/ and setup details
are available at
https://cwiki.apache.org/confluence/display/INFRA/Jenkins . We can not create
release artifacts on those servers as they must go through a voting process. We
can as part of a release
Make sense to me.
On Thu, Apr 5, 2018 at 9:19 AM, Ashvin A wrote:
> Hi Devs,
>
> PR 2840 renames com.twitter package to org.apache. This change touches more
> than *2,127* files. Is there a test strategy for this change which updates
> everything? I believe just depending
Cool. Thanks!
On Thu, Apr 5, 2018 at 11:39 AM, Jake Farrell wrote:
> Hey Ali
> The ASF Jenkins build system is at https://builds.apache.org/ and setup
> details are available at
> https://cwiki.apache.org/confluence/display/INFRA/Jenkins . We can not
> create release
One thing that i've learned through a couple of projects is that the more
we can move into the projects repo for build/test/release scripts along
with release verification helps immensely and reduces any behind the scenes
magic and also enables others in the community to be involved with these
34 matches
Mail list logo