[jira] [Created] (HIVE-18517) Vectorization: Fix VectorMapOperator to accept VRBs to support LLAP Caching

2018-01-23 Thread Matt McCline (JIRA)
Matt McCline created HIVE-18517: --- Summary: Vectorization: Fix VectorMapOperator to accept VRBs to support LLAP Caching Key: HIVE-18517 URL: https://issues.apache.org/jira/browse/HIVE-18517 Project:

Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-18484

Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-18483

Re: Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-23 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/#review195995 --- Thanks a lot Adam for the patch. It looks very good to me. -

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-23 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review195979 --- Thanks a lot Peter for the patch. I looks really good to me, I

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-23 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/#review195980 --- Thanks a lot Peter for the patch. It looks really good to me, I

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-23 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review195981 --- Ship it! Ship It! - Marta Kuczora On Jan. 22, 2018, 2:33

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-23 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review195984 --- Ship it! Ship It! - Marta Kuczora On Jan. 23, 2018, 11:18

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-23 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/ --- (Updated Jan. 23, 2018, 11:48 a.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-23 Thread Peter Vary via Review Board
> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > > Lines 323 (patched) > > > > > > Maybe

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-23 Thread Peter Vary via Review Board
> On Jan. 23, 2018, 10:56 a.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java > > Lines 285 (patched) > > > > > > Might worth to add

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-23 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/ --- (Updated Jan. 23, 2018, 11:18 a.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- (Updated Jan. 23, 2018, 1:38 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-23 Thread Adam Szita via Review Board
> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 223 (patched) > > > > > > When altering a

[jira] [Created] (HIVE-18521) Vectorization: query failing in reducer VectorUDAFAvgDecimalPartial2 java.lang.ClassCastException StructTypeInfo --> DecimalTypeInfo

2018-01-23 Thread Matt McCline (JIRA)
Matt McCline created HIVE-18521: --- Summary: Vectorization: query failing in reducer VectorUDAFAvgDecimalPartial2 java.lang.ClassCastException StructTypeInfo --> DecimalTypeInfo Key: HIVE-18521 URL:

Review Request 65304: HIVE-18513 Query results caching

2018-01-23 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65304/ --- Review request for hive, Ashutosh Chauhan, Gopal V, and Jesús Camacho Rodríguez.

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-23 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196065 --- A few comments, in general the tests look very thorough. Nice

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-23 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/ --- (Updated Jan. 23, 2018, 5:21 p.m.) Review request for hive, Peter Vary and

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-23 Thread Marta Kuczora via Review Board
> On Jan. 22, 2018, 2:12 p.m., Adam Szita wrote: > > Thanks for this patch Marta, it looks good! I've made a few recommendations > > only Thanks a lot Adam for the review. - Marta --- This is an automatically generated e-mail. To

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-23 Thread Marta Kuczora via Review Board
> On Jan. 22, 2018, 2:12 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java > > Lines 678 (patched) > > > > > > For handling future

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-23 Thread Marta Kuczora via Review Board
> On Jan. 22, 2018, 2:21 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java > > Lines 218 (patched) > > > > > > Is this ok to have

Review Request 65296: HIVE-18259

2018-01-23 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65296/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-18259

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-23 Thread Marta Kuczora via Review Board
> On Jan. 22, 2018, 2:21 p.m., Peter Vary wrote: > > Thanks for the patch Marta! Only one question below Thanks a lot Peter for the review. - Marta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-23 Thread kalyan kumar kalvagadda via Review Board
> On Jan. 11, 2018, 9:51 p.m., Andrew Sherman wrote: > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/operation/TestOperationLoggingLayout.java > > Line 162 (original), 163 (patched) > > > > > > This

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-23 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65075/ --- (Updated Jan. 23, 2018, 8:27 p.m.) Review request for hive, Aihua Xu, Andrew

Re: Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-23 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/#review196018 --- Just 2 more test cases I can come up with. Is it worth to create

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-23 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 23, 2018, 4:47 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-23 Thread Peter Vary via Review Board
> On Jan. 23, 2018, 2:07 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 103 (patched) > > > > > > Should we extract > >

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/#review196012 --- Fix it, then Ship it! Looking good, thanks Peter!

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-23 Thread Peter Vary via Review Board
> On Jan. 23, 2018, 4:17 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > > Lines 234-235 (patched) > > > > > > Could

[jira] [Created] (HIVE-18518) Upgrade druid version to 0.11.0

2018-01-23 Thread Nishant Bangarwa (JIRA)
Nishant Bangarwa created HIVE-18518: --- Summary: Upgrade druid version to 0.11.0 Key: HIVE-18518 URL: https://issues.apache.org/jira/browse/HIVE-18518 Project: Hive Issue Type: Bug

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

2018-01-23 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/ --- (Updated Jan. 23, 2018, 1:57 p.m.) Review request for hive, Peter Vary and

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-23 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review195996 --- That is a hugh number of tests. Might add some more. Please check

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196031 --- Ship it! Ship It! - Adam Szita On Jan. 23, 2018, 4:47 p.m.,

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196003 --- Fix it, then Ship it! Looks good Peter, thanks for the patch!

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review196029 --- Ship it! Ship It! - Adam Szita On Jan. 23, 2018, 11:18

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-23 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/ --- (Updated Jan. 23, 2018, 4:54 p.m.) Review request for hive, Marta Kuczora,

[jira] [Created] (HIVE-18519) do not create materialized CTEs with ACID/MM

2018-01-23 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18519: --- Summary: do not create materialized CTEs with ACID/MM Key: HIVE-18519 URL: https://issues.apache.org/jira/browse/HIVE-18519 Project: Hive Issue Type:

[jira] [Created] (HIVE-18520) add current txnid to ValidTxnList

2018-01-23 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18520: - Summary: add current txnid to ValidTxnList Key: HIVE-18520 URL: https://issues.apache.org/jira/browse/HIVE-18520 Project: Hive Issue Type: Improvement