Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-11-29 Thread Naveen Gangam via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review210953 --- Ship it! Ship It! - Naveen Gangam On Nov. 27, 2018, 7:18 a.m

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-11-27 Thread Vihang Karajgaonkar via Review Board
> On Nov. 27, 2018, 10:55 p.m., Naveen Gangam wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java > > Lines 162 (patched) > > > > > > Should

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-11-27 Thread Naveen Gangam via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review210911 --- standalone-metastore/metastore-server/src/main/java/org/apache/ha

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-11-27 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review210893 --- LGTM standalone-metastore/metastore-server/src/test/java/org/apa

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-11-26 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Nov. 27, 2018, 7:18 a.m.) Review request for hive, Andrew Sherman, Ala

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-11-01 Thread Vihang Karajgaonkar via Review Board
> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > > > > > Yo

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-11-01 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Nov. 1, 2018, 8:48 p.m.) Review request for hive, Andrew Sherman, Alan

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-22 Thread Andrew Sherman via Review Board
> On Oct. 16, 2018, 8:59 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 291 (patched) > > > > > > What is someone has s

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-19 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Oct. 19, 2018, 8:54 p.m.) Review request for hive, Andrew Sherman, Ala

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-19 Thread Karthik Manamcheri via Review Board
> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > > > > > Yo

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-18 Thread Vihang Karajgaonkar via Review Board
> On Oct. 18, 2018, 2:33 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 244 (original), 341 (patched) > > > > > > Yo

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-18 Thread Karthik Manamcheri via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209742 --- standalone-metastore/metastore-server/src/main/java/org/apache/ha

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-16 Thread Vihang Karajgaonkar via Review Board
> On Oct. 16, 2018, 8:59 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 291 (patched) > > > > > > What is someone has s

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-16 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Oct. 16, 2018, 10:47 p.m.) Review request for hive, Andrew Sherman, Al

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-16 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209662 --- This all looks good, I just have annoying questions standalone-m