approach would be to do nothing. I'd be happy to
prepare a patch if this approach - to do nothing - is
unacceptable. Of course, suggestions to make the patch
as robust as possible would be enthusiastically welcomed.
Thanks!
--
Joe Schaefer
pool/cookie initializers in Apache::Cookie::set_attr(),
which caused Apache::Cookie::new to segfault. Bug
first reported to modperl list by Wolfgang Kubens.
--
Joe Schaefer
--
Reporting bugs: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
Joe Schaefer [EMAIL PROTECTED] writes:
It looks like apr_proc_other_child_refresh_all(int) is the
replacement, but I've no idea what its argument should be.
Any suggestions?
apr's CHANGES (for 1.0) says that this patch should work
(sorry for the format):
Index: server/mpm/winnt/child.c
the intuitive thing
would yield a 404.
--
Joe Schaefer
this doesn't produce duplicates in the final
response (ie. doesn't httpd add r-err_headers_out itself, in
ap_http_header_filter)?
--
Joe Schaefer
Jim Jagielski [EMAIL PROTECTED] writes:
Joe Schaefer wrote:
But is the err_headers_out logic in proxy_http.c HEAD really ok?
It appears to put a copy of r-err_headers_out into r-headers_out,
so I'm wondering why this doesn't produce duplicates in the final
response (ie. doesn't httpd
Yaqian Shen [EMAIL PROTECTED] writes:
[...]
Where can I find the test cases you developers
are using in testing the whole system before you make an official
release?
httpd-test?
http://httpd.apache.org/test/
--
Joe Schaefer
a pivotal role in
libapreq2's input filter mod_apreq. mod_apreq needs to examine
the entire input filter stack and modify it under certain
conditions. This cannot be done in-flight, during ap_get_brigade.
--
Joe Schaefer
advising output
filter authors that want to get at libapreq2's post data to use
filter_init for that:
http://cvs.apache.org/~joes/libapreq2-2.04-dev/docs/html/apreq_faq.html
If there's a better approach, I'd be glad to update those docs.
--
Joe Schaefer
?
If so, for performance reasons that's not a suitable
solution for folks writing output filters with mod_perl.
--
Joe Schaefer
in the design
which prevents a filter from looping over ap_get_brigade until
it has enough data to return a meaningful brigade to its caller.
APR_NONBLOCK_READ invocations should allow a filter to leave the
returned brigade empty.
--
Joe Schaefer
and the incoming headers? If that were done,
there would be no need for an AP_MODE_GETLINE invocation (hence
no apr_brigade_split_line in core_input_filter).
--
Joe Schaefer
for the current request.
If a protocol filter reads more data than it needs, then that filter
needs to set-aside the excess data for downstream filters to collect.
I see no reason why an imput filter needs to push the excess data
back upstream.
--
Joe Schaefer
and put the excess brigade
in there.
--
Joe Schaefer
Glenn Strauss [EMAIL PROTECTED] writes:
On Fri, Aug 13, 2004 at 03:08:17PM -0400, Joe Schaefer wrote:
Glenn Strauss [EMAIL PROTECTED] writes:
[...]
I'm not sure the answer to this one:
Are protocol filters attached to the request (I think so)
or to the connection? If attached
Joe Schaefer [EMAIL PROTECTED] writes:
Glenn Strauss [EMAIL PROTECTED] writes:
[...]
You suggested always using READBYTES. If a POST used chunked T-E to
send input, then when HTTP_IN is reading chunk trailers, too much data
might be read, i.e. the next request line might be read. What
sounds to me
like moves in the right direction. What do you think?
Sounds good to me, but I'm curious to know what Justin thinks
about it.
--
Joe Schaefer
to
apr_brigade_split_line() also going to cause problems on
lines larger than that value (8K)?
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
[...]
Isn't the core_input_filter's HUGE_STRING_LEN argument to
apr_brigade_split_line() also going to cause problems on
lines larger than that value (8K)?
Scratch that- I see that ap_rgetline_core has enough loops
to handle it.
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
[...]
Or they could all be required to punt on AP_MODE_GETLINE (like
mod_deflate does), which would mean some filters like mod_ext_filter
need a patch.
Here's the patch for mod_ext_filter (untested):
Index: modules/filters/mod_ext_filter.c
;
while (1) {
/* ap_threads_per_child does not include the listener thread */
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
The concept of multiplexing apache's lingering
close comes from lingerd, but I thought it'd be
interesting to try the same thing for worker with
a dedicated closer thread.
The patch is intended to improve worker's scaling
characteristics without
% 3708
100% 4550 (longest request)
--
Joe Schaefer
!= APR_BRIGADE_FIRST(bb))
+APR_BUCKET_INSERT_BEFORE(b, flush);
+else
+APR_BRIGADE_INSERT_HEAD(bb, flush);
}
return ap_pass_brigade(f-next, bb);
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
With mod_logio enabled on a 404 response, the final
output brigade sent down the filter stack consists of
a single EOS bucket. In this circumstance mod_logio's
logio_out_filter() calls APR_BUCKET_INSERT_BEFORE on
the sole eos bucket, which corrupts
always the noexist.txt test in t/compat/send_fd that triggers it.
There are no modperl functions involved in the stacktrace because
the mp2 handler is just returning a 404 for apache to deal with as
usual.
At this point I'm stumped, so any tips would be really appreciated.
--
Joe Schaefer
Cliff Woolley [EMAIL PROTECTED] writes:
On Mon, 20 Sep 2004, Joe Schaefer wrote:
Thanks, Cliff. I guess I was getting confused by the
warnings in the apr_ring.h docs.
If you can be more specific about what part confused you, I'd be happy to
rewrite said docs. If they're confusing
Bill Stoddard [EMAIL PROTECTED] writes:
Joe Schaefer wrote:
[...]
ie 1 server w/ 5 threads. The closer_thread's queue/pollset size
are capped at 100 with this config.
Running ab -n 1 -c $concurrency http://localhost/
concurency requests/sec
unpatched
Sander Striker [EMAIL PROTECTED] writes:
On Mon, 2004-09-27 at 06:13, Joe Schaefer wrote:
[...]
apreq/branches/1.3
and httpd-apreq-2 cvs can go to apreq/trunk.
*nod*
Correction: apreq/branches/1.x
We've already released libapreq-1.3, and since we're
still maintaining that codebase
.
Do you have any tips on where I should look for my problem?
You shouldn't need to clean up anything, the pool cleanup should
take care of everything apreq allocates. How are you handling
the upload brigades? It's possible to leak buckets if you're
not careful.
--
Joe Schaefer
Philip M. Gollucci [EMAIL PROTECTED] writes:
Joe Schaefer wrote:
Until someone teaches apreq_brigade_fwrite about spool buckets,
it probably shouldn't be used for upload brigades. Sorry about that.
I was looking at this a while ago -- APR/U have this function.
Really? What's it called
= APR_BRIGADE_FIRST(tmp)) != e)
+apr_bucket_delete(first);
}
return APR_SUCCESS;
}
--
Joe Schaefer
patch to trunk soonish. I'm glad
you found a solution that seems to be working for you, but I'm
also more than a little skeptical that apreq is working correctly
if you are simply deleting the original buckets passed into
apreq_brigade_fwrite.
--
Joe Schaefer
);
Try adding
$r-discard_request_body;
here, and then see what the body_status is.
(The code didn't croak, so I don't think you're getting
an error, but let's see anyhow).
--
Joe Schaefer
Dave Viner [EMAIL PROTECTED] writes:
removing the enctype makes no difference. still encounter the same error.
OK, I think we're getting somewhere now.
Are you using code that calls CGI.pm from
a different handler (say in the auth phase)?
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
Vinay Y S [EMAIL PROTECTED] writes:
There is a problem with apreq temp file cleanup on win32. For each
POST request with POST body greater than 256KB, TWO temp files of
exact same size get created in temp directory and they are not deleted
even after
() call to close the file, so
I'm wondering why that's not happening in your situation.
--
Joe Schaefer
occasional stray temp files lingering around.
May I suggest that people start posting version numbers of
both libapr and operating system? All we're doing now is
running around blindly tweaking crap that we really
shouldn't be tweaking in the first place.
--
Joe Schaefer
the default state is Allow
==
I'd be happy to provide a patch for all the docs if
folks agree.
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
Issac Goldstand [EMAIL PROTECTED] writes:
The apreq developers are planning a maintenance release of
libapreq1. This version primarily addresses an issue noted
with FireFox 2.0 truncating file uploads in SSL mode.
Please give the tarball at
http
ac_default_prefix=`$APU_CONFIG --prefix`
Does mod_wombat use the apreq2_config script for getting at
apreq2's installation data?
--
Joe Schaefer
. That doesn't stop people from
redistributing candidates, but it doesn't conflate the fact that
the ASF/this PMC has done nothing to endorse them.
[1] - http://www.apache.org/dev/release.html#what
--
Joe Schaefer
the Email.
There were 2 emails from Steffen to prc@ stuck in
moderation. I just moderated them through.
--
Joe Schaefer
. Now if I could only get the svn devs
to include that patch (r23815) in their next release...
--
Joe Schaefer
André Malo [EMAIL PROTECTED] writes:
* Joe Schaefer wrote:
Listed in the TODO section of STATUS is this:
- Implement (some of) RFC 2047 in the multipart parser.
e.g.
Content-Disposition: name=foo filename==?iso-8859-1?q?foo.txt?=
Should we try and decode filename to foo.txt
.
Is there a reason behind the musn't? Ie: are POST subrequests a
problem (assuming there's a valid input_brigade to read and a
corresponding CL)?
I'm not sure what the rationale is behind forbidding it within httpd,
other than it being a complex situation that wasn't really possible
in 1.3.
--
Joe
Bengt-Arne Fjellner [EMAIL PROTECTED] writes:
The documentation for APR::Request ought to mention that atleast jar
and params returns undef if there is no cookie/param
done.
--
Joe Schaefer
a huge
pain in the ass to install.
---End Message---
--
Joe Schaefer
and perl 5.8.5 on RHEL 3
A.
---End Message---
--
Joe Schaefer
31 100.00% 1-31
Failed 1/4 test scripts, 75.00% okay. 31/114 subtests failed, 72.81% okay.
---End Message---
--
Joe Schaefer
with mod_alias.
[...patch...]
Thanks, applied as revision 371540.
--
Joe Schaefer
for providing
access to form data. It's a good match if you can afford the
extra dependency.
--
Joe Schaefer
apreq_handle_apache2 (it's actually a faq, see
URL:http://svn.apache.org/repos/asf/httpd/apreq/trunk/
module/t/c-modules/apreq_output_filter_test/
mod_apreq_output_filter_test.c
for an example output filter with a filter-init function.
--
Joe Schaefer
is export the constant in Error.xs so you can write
if ($error == APR::Request::Error::OVERLIMIT)
--
Joe Schaefer
the perl pmc would be cool with me.
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
Here's a patch against the 2.2.x branch of httpd (you need to
apply the svn:externals properties manually). With it I can
build mod_apreq (no 2) statically or dynamically. Haven't tested
it at all yet tho.
Here's a better patch against httpd/branches
$ ldd Request.so
--
Joe Schaefer
a03eeefee78c01ec24c8671380763860 httpd-2.0.58.tar.gz
+1 for debian-amd64:
All tests successful (1 subtest UNEXPECTEDLY SUCCEEDED),
25 tests and 16 subtests skipped.
--
Joe Schaefer
William A. Rowe, Jr. [EMAIL PROTECTED] writes:
[ ] httpd-2.2.3
+1, tested (live!) on FreeBSD 6.1 and Ubuntu breezy.
--
Joe Schaefer
mod_apreq and importing it to httpd shouldn't be too hard. I think
it would be a bit more work to adjust mod_apreq to support this
behavior without a parser actually being present, but I'm sure we
could do it if there's a real desire for using apreq within httpd.
--
Joe Schaefer
be a
simple thing, because certain functions in the perl api expose the
spool file's name, and people are expecting that to be per-upload
and hard-linkable. Not a showstopper though, it'd just a bit more
work within the perl glue to support the kind of optimization you're
suggesting.
--
Joe
the mime parts into separate data structures. Users
can register hooks within apreq if they want the parser
to process the contents a bit more thoroughly.
--
Joe Schaefer
Graham Leggett [EMAIL PROTECTED] writes:
[...]
Something like an auth module that can do form based auth, in
addition to basic and digest etc would probably be very useful.
apreq does that.
--
Joe Schaefer
Graham Leggett [EMAIL PROTECTED] writes:
Joe Schaefer said:
Something like an auth module that can do form based auth, in
addition to basic and digest etc would probably be very useful.
apreq does that.
What is apreq?
Its an httpd subproject. Basically its a server-side form-parsing
talkabout dropping into
the httpd tree is our apache2 module, which is only a couple of C files.
If you're looking for something to review, I'd suggest
URL: http://svn.apache.org/repos/asf/httpd/
apreq/branches/multi-env-unstable/module/apache2/
--
Joe Schaefer
to include those 4 C files referenced earlier, and configuring
httpd to treat them as optional module.
--
Joe Schaefer
-# define strrchr(s, c) ap_strrchr(s,c)
-#undef strstr
-# define strstr(s, c) ap_strstr(s,c)
-
-#else
-
/** use this instead of strchr */
# define ap_strchr(s, c) strchr(s, c)
/** use this instead of strchr */
--
Joe Schaefer
with this is that
httpd is exporting these helpers, where the change in linkage
(from stdlib to httpd) may be disastrous.
--
Joe Schaefer
=QXBhY2hlLzEuMy4yMw==
URL:
http://www.securityspace.com/s_survey/data/man.200502/
ISPreport.html?plot=hosteurope.de
--
Joe Schaefer
the subrequest's
Transfer-Encoding header as well.
Shouldn't you remove Content-Type also?
--
Joe Schaefer
attached (so no POST data
will ever be available to a subrequest via apreq). I think
this is the original intent, and that the input filter cloning
is just there to prevent segfaults (e.g. the subrequest might
install new filters for itself).
--
Joe Schaefer
the
original brigade passed in by a content handler. IMO
apr_brigade_cleanup should be invoked at most once in
that case.
--
Joe Schaefer
of auto-foo guys floating around
over on [EMAIL PROTECTED] What makes things *very* complicated for apreq, IMO,
is the CPAN distribution channel that mod_perl'ers expect from us.
--
Joe Schaefer
);
apr_allocator_owner_set(allocator, ptrans);
}
else {
--
Joe Schaefer
Jeff Trawick [EMAIL PROTECTED] writes:
On 5/12/05, Joe Schaefer [EMAIL PROTECTED] wrote:
Without this patch, the new apr_pool_join stuff in apr's trunk
segfaults all over the place.
Why? Is worker MPM doing something wrong (creating standalone pool in
that manner), or does APR need some
Jeff Trawick [EMAIL PROTECTED] writes:
On 5/12/05, Joe Schaefer [EMAIL PROTECTED] wrote:
Without this patch, the new apr_pool_join stuff in apr's trunk
segfaults all over the place.
Why? Is worker MPM doing something wrong (creating standalone pool in
that manner), or does APR need some
Ville Skyttä [EMAIL PROTECTED] writes:
On Wed, 2005-05-18 at 09:08 -0400, Joe Schaefer wrote:
Ville Skyttä [EMAIL PROTECTED] writes:
...the size of the receiving httpd process grows by about 260MB after
handler() returns, and stays that big.
Hmm, the brigade_limit directive must
; interested students should check out
all the descriptions at
http://wiki.apache.org/general/SummerOfCode2005
It'd be cool if there was a mod_perl project
listed there also, but I don't see anything there
at the moment and the deadline for listing them is
tomorrow (hint).
--
Joe Schaefer
Markus Wichitill [EMAIL PROTECTED] writes:
Joe Schaefer wrote:
1) grab our svn trunk and apply the attached patch to it.
2) make clean; make
3) cd module; make test
4) ls -l /tmp
No files in /tmp.
WAG: see if this patch helps any
Index: library/util.c
links to
libexpat.a, but it didn't help.
Any suggestions?
./configure --help | grep expat
--
Joe Schaefer
for that.
--
Joe Schaefer
implementation,
or has the tied hash STORE function just not been
implemented yet?
The underlying C implementation is a const apr_table_t *
(see apreq_module.h). So technically we shouldn't implement
a STORE method on that.
--
Joe Schaefer
Philip M. Gollucci [EMAIL PROTECTED] writes:
Fix automake SVN build error:
library/t/Makefile.am:2: invalid unused variable name: `AM_LDFLAGS'
This is not a warning. This is an autojoke.
When you see it, you're supposed to laugh.
--
Joe Schaefer
,
APREQ_VERSION_STRING));
Line wrap.
--
Joe Schaefer
;
+}
+
/* utf8 cases */
else if (c 0xE0) {
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
Marc Gràcia [EMAIL PROTECTED] writes:
The call to:
my @values = $ar-param($parname);
Only returns the params previous to the tilde ended param value (not
included).
Thanks; see if this patch helps
Better yet: please test rc3 at
http
-header-parser hook that
runs when the parser finishes.
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
Jem Berkes [EMAIL PROTECTED] writes:
I think this granularity is required. But I'm not
sure about how the DATA hook would work?
Have you considered using libapreq2 for parsing
the mime headers in there? The header parser
should really convenient
the input filters.
--
Joe Schaefer
into an eos
bucket.
That should give you enough flexibility that someone
else could write a mod_milter and provide most (if not
all) of the milter api.
--
Joe Schaefer
but I now think that's wrong
from a resource identifier standpoint.
--
Joe Schaefer
Joe Schaefer [EMAIL PROTECTED] writes:
Rian Hunter [EMAIL PROTECTED] writes:
I think this requires some more thought considering different
smtp connections and server requirements. The main drawback to
sub- requesting each rcpt to is that we have two different
handlers trying to read data
: libapreq2-2.05-dev and
httpd-2.0.54.
libapreq2-2.06-dev was released this quarter. Nothing else
to report from there, other than increased demand to see it
integrated into the httpd distribution.
--
Joe Schaefer
collection as r-headers_in for data
+ hooks to examine.
--
Joe Schaefer
Rian Hunter [EMAIL PROTECTED] writes:
On Aug 14, 2005, at 1:22 PM, Joe Schaefer wrote:
+RELEASE SHOWSTOPPERS:
+
+
+ smtp_process_connection_internal should take a smtp_proto_rec
+ argument (which is what the current smtp_request_rec struct
+ should be renamed to).
I can easily rename
to work on the filters for mod_smtpd if
you want to delegate that task.
--
Joe Schaefer
choice, which IMO is counter to the
spirit of httpd.
--
Joe Schaefer
command
verbatim. I still feel this needs some thought.
IMO a good bit of code to look at is Qpsmtpd::Transaction,
which is what I think should correspond to a request_rec in mod_smtpd.
Any per-transaction extensions you need can go into r-request_config.
--
Joe Schaefer
*/
+ smtpd_create_server_config, /* create per-server config structure */
+ NULL, /* merge per-server config structures */
+ smtpd_cmds, /* command apr_table_t */
+ register_hooks /* register hooks */
};
--
Joe Schaefer
\r\n, 250, ((char **)sr-extensions-nelts)[i]);
^
That should be elts, shouldn't it?
--
Joe Schaefer
1 - 100 of 386 matches
Mail list logo
