Re: [DISCUSS] Gogo commands completion data

2016-10-19 Thread Guillaume Nodet
I really think the scripts are more flexible and powerful than command metadata. But I agree having to ship them is a pain, so I hope we can find a better way in the future. Your proposal of a known location in the bundle makes sense. 2016-10-19 13:51 GMT+02:00 Christian Schneider

Re: [DISCUSS] Gogo commands completion data

2016-10-19 Thread Christian Schneider
The command metadata service API of course would need to live at felix gogo. So the plain gogo shell could also make use of it. We could then provide an extender at karaf that creates these services out of the karaf specific commands. The problem I see with the scripts is how to add them to

Re: [DISCUSS] Gogo commands completion data

2016-10-19 Thread Christian Schneider
The command metadata service API of course would need to live at felix gogo. So the plain gogo shell could also make use of it. We could then provide an extender at karaf that creates these services out of the karaf specific commands. The problem I see with the scripts is how to add them to

Re: [DISCUSS] Gogo commands completion data

2016-10-19 Thread Guillaume Nodet
I thought about that, but then, the bundles would be tied to Karaf while the goal is to support commands from projects which are not related to karaf. Else, we could just force them to use our own command api if they want to support Karaf ;-) Also remember that scripting offers very nice

Re: [DISCUSS] Gogo commands completion data

2016-10-19 Thread Christian Schneider
Not sure if the script approach is good for the long run. What we could do with it though is to provide a script in a magic location in each bundle. The shell could then dynamically add and remove the scripts as the bundles are started / stopped. Does that make sense ? For the long run I

Re: [DISCUSS] Gogo commands completion data

2016-10-19 Thread Jean-Baptiste Onofré
Awesome. I will take a look. Let me know for the scr commands, I can tackle that. Regards JB On 10/19/2016 11:30 AM, Guillaume Nodet wrote: I have committed my changes. I still need to replace the karaf scr commands with the native ones and write the completion data for it. 2016-10-12 17:57

Re: [DISCUSS] Gogo commands completion data

2016-10-14 Thread Matt Pavlovich
+1 etc/scripts +1 being able to use element On 10/12/16 10:57 AM, Guillaume Nodet wrote: I'm working on trying to nicely integrate gogo commands. The new gogo-jline bundle has a very nice way to allow external configuration for command completion. For example, one need to execute the script

Re: [DISCUSS] Gogo commands completion data

2016-10-13 Thread Achim Nierbeck
fully agree on the scr ones and those posix commands. We don't need to re-invent the wheel a fifth time ;) regards, Achim 2016-10-13 11:47 GMT+02:00 Guillaume Nodet : > 2016-10-13 11:28 GMT+02:00 Achim Nierbeck : > > > Just one question, > > what's

Re: [DISCUSS] Gogo commands completion data

2016-10-13 Thread Guillaume Nodet
2016-10-13 11:28 GMT+02:00 Achim Nierbeck : > Just one question, > what's the effect on already existing Karaf commands and those completions > etc. > If that is not affected at all I've got no complaints ;) > Existing commands are not affected. To achieve the above,

Re: [DISCUSS] Gogo commands completion data

2016-10-13 Thread Achim Nierbeck
Just one question, what's the effect on already existing Karaf commands and those completions etc. If that is not affected at all I've got no complaints ;) regards, Achim 2016-10-12 18:41 GMT+02:00 Guillaume Nodet : > The problem is to obtain the list of scripts that needs

Re: [DISCUSS] Gogo commands completion data

2016-10-12 Thread Guillaume Nodet
The problem is to obtain the list of scripts that needs to be loaded somehow. If we somehow include (using the source command for example), it means we need to copy the script file *and* modify another script, which may be a bit more complicated than necessary. 2016-10-12 18:38 GMT+02:00