Re: [jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

Hi Ishan, I'm sorry for the late reply. I think it makes sense. But can you open a new ticket because SOLR-11795 has been closed already. Thank you for letting me know this! Koji On 2019/04/11 19:31, Ishan Chattopadhyaya (JIRA) wrote: [

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815301#comment-16815301 ] Ishan Chattopadhyaya commented on SOLR-11795: - Does it make sense to add a link about this

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740716#comment-16740716 ] Bill Vandenberk commented on SOLR-11795: I'd love to start using this, but it seems to not

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388911#comment-16388911 ] Minoru Osuka commented on SOLR-11795: - Hi [~ctargett], Thank you for your feedback and the

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387997#comment-16387997 ] Cassandra Targett commented on SOLR-11795: -- Sorry, one more bit of feedback - I didn't realize

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387824#comment-16387824 ] Cassandra Targett commented on SOLR-11795: -- Looking at the patch closer, it seems many of the

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387754#comment-16387754 ] Cassandra Targett commented on SOLR-11795: -- Can we remove the

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387431#comment-16387431 ] Minoru Osuka commented on SOLR-11795: - Hi [~ctargett] and [~koji], I'm sorry to bother you over and

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387417#comment-16387417 ] Minoru Osuka commented on SOLR-11795: - Hi [~ctargett] and [~koji], Sorry, I will make README.txt

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387324#comment-16387324 ] Minoru Osuka commented on SOLR-11795: - Hi [~ctargett] and [~koji], I attached a new patch

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387161#comment-16387161 ] Minoru Osuka commented on SOLR-11795: - Hi [~ctargett], Thanks for letting me know it. I will attach

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386879#comment-16386879 ] Cassandra Targett commented on SOLR-11795: -- A couple of really tiny things I noticed when I was

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385769#comment-16385769 ] Uwe Schindler commented on SOLR-11795: -- Can we resolve the issue? > Add Solr metrics exporter for

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385766#comment-16385766 ] Uwe Schindler commented on SOLR-11795: -- Hi Koji, looks fine now. I hope Windows Jenkins is also happy

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385685#comment-16385685 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385658#comment-16385658 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385552#comment-16385552 ] Koji Sekiguchi commented on SOLR-11795: --- Uwe's suggestion helped us to check this patch working on

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384085#comment-16384085 ] David Smiley commented on SOLR-11795: - Hi. Just curious; why does this issue get its own dedicated

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383524#comment-16383524 ] Uwe Schindler commented on SOLR-11795: -- Hi Koji, I added: https://jenkins.thetaphi.de/job/SOLR-11795/

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383080#comment-16383080 ] Koji Sekiguchi commented on SOLR-11795: --- Hi Uwe, I created the following branches: * SOLR-1175

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383067#comment-16383067 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383020#comment-16383020 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382980#comment-16382980 ] Shinichiro Abe commented on SOLR-11795: --- i made a mistake when looking the patch, please ignore

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382918#comment-16382918 ] Minoru Osuka commented on SOLR-11795: - [~shinichiro abe], Thank you for finding a typo. Argparse4j

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382801#comment-16382801 ] Shinichiro Abe commented on SOLR-11795: --- latest patch, there still be 'yaml' word in adoc. It's just

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381992#comment-16381992 ] Minoru Osuka commented on SOLR-11795: - Hi [~koji] and [~thetaphi] I apologize for the delay. I

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381901#comment-16381901 ] Uwe Schindler commented on SOLR-11795: -- FYI, snakeyaml 1.20, which fixes the Java 9 bug, was released

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376293#comment-16376293 ] Minoru Osuka commented on SOLR-11795: - Hi, [~thetaphi] and [~dsmiley], I'm working on replace YAML to

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376138#comment-16376138 ] David Smiley commented on SOLR-11795: - We don't need another configuration file format (YAML). This

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376031#comment-16376031 ] Uwe Schindler commented on SOLR-11795: -- Hi [~koji] and [~minoru], I verified that the patched

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375749#comment-16375749 ] Uwe Schindler commented on SOLR-11795: -- Hi Koji, the snakeyaml people are fixing the bug with Java 9.

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375582#comment-16375582 ] Koji Sekiguchi commented on SOLR-11795: --- Thanks for the kind suggestion. I'd like to create a branch

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375519#comment-16375519 ] Uwe Schindler commented on SOLR-11795: -- Hi, I'd suggest to create a branch forked from current

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375507#comment-16375507 ] Minoru Osuka commented on SOLR-11795: - [~thetaphi], I apologize for any inconvenience caused, and

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375460#comment-16375460 ] Uwe Schindler commented on SOLR-11795: -- Thanks [~koji]. I think here the main problem is not only

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375256#comment-16375256 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375257#comment-16375257 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375241#comment-16375241 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375242#comment-16375242 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375195#comment-16375195 ] Koji Sekiguchi commented on SOLR-11795: --- I can't apologize enough for this. :( > Now we have XML,

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374866#comment-16374866 ] Erick Erickson commented on SOLR-11795: --- Are the issues here serious enough that we should roll this

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374707#comment-16374707 ] Uwe Schindler commented on SOLR-11795: -- About snakeyaml: The Exception handling is broken in multiple

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374699#comment-16374699 ] Hoss Man commented on SOLR-11795: - Also note that (as of this moment) it seems that most/all of the tests

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374680#comment-16374680 ] Uwe Schindler commented on SOLR-11795: -- Why does it have log4j and slf4j in the contrib's lib/ sub

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374664#comment-16374664 ] Uwe Schindler commented on SOLR-11795: -- Why does the Solr specific collector config uses YAML (80

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374647#comment-16374647 ] Uwe Schindler commented on SOLR-11795: -- Just a complaint: Why are tests written like this:

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374623#comment-16374623 ] Uwe Schindler commented on SOLR-11795: -- See:

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374616#comment-16374616 ] Uwe Schindler commented on SOLR-11795: -- This is Java 9. The SnakeYAML stuff uses reflection in

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373818#comment-16373818 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373805#comment-16373805 ] ASF subversion and git services commented on SOLR-11795: Commit

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373784#comment-16373784 ] Minoru Osuka commented on SOLR-11795: - I attached new patch file (SOLR-11795-dev-tools.patch) for

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373596#comment-16373596 ] Koji Sekiguchi commented on SOLR-11795: --- Thanks for letting us know it. Yes, we discussed about the

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373198#comment-16373198 ] Uwe Schindler commented on SOLR-11795: -- Hi, there is another problem: The pom.xml templates are

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372333#comment-16372333 ] Minoru Osuka commented on SOLR-11795: - I attached new patch file (SOLR-11795-9.patch) that passed `ant

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370228#comment-16370228 ] Minoru Osuka commented on SOLR-11795: - I'm sorry, my patch file has mistakes. - avoid invalid logging

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369726#comment-16369726 ] Minoru Osuka commented on SOLR-11795: - Hi, Thank you for quick reply. Why test code uses these

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369692#comment-16369692 ] Koji Sekiguchi commented on SOLR-11795: --- I can still see several UpdateRequestProcessors in

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369681#comment-16369681 ] Minoru Osuka commented on SOLR-11795: - I replaced luceneMatchVersion to "$ \{tests.luceneMatchVersion:

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369645#comment-16369645 ] Koji Sekiguchi commented on SOLR-11795: --- Thank you for updating the patch. I can see hard coded

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369114#comment-16369114 ] Minoru Osuka commented on SOLR-11795: - Hi [~koji], I attached the latest patch (SOLR-11795-6.patch).

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366903#comment-16366903 ] Koji Sekiguchi commented on SOLR-11795: --- Today I had a meeting with Minoru, the contributor of this

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus to contrib directory

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304229#comment-16304229 ] Minoru Osuka commented on SOLR-11795: - solr-exporter can expose the search results as well as the

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus to contrib directory

[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304127#comment-16304127 ] Koji Sekiguchi commented on SOLR-11795: --- +1 looks nice! > Add Solr metrics exporter for Prometheus