On 17 October 2016 at 01:25, Christian Schulte wrote:
> Am 10/15/16 um 15:20 schrieb Stephen Connolly:
> > * Pom doesn't need to be XML any more... (maybe we want to keep XML
> though... just a less verbose form)
>
> Maybe XML really isn't the way to go. Whenever I look at an XML file, it
> appea
On 17/10/2016 08:32, Peter Levart wrote:
:
Do we need an --exclude-modules (in addition to --add-modules) option
on javac, java and jlink commands?
--exclude-modules would be different to --limit-modules. If some
module requires module M and there is no module M on the module path
or it is
So your approach was to fork some code, instead of trying to fix Gossip? I
haven’t been paying much attention just trying to understand why you would fork
instead of working with Jason Dillon to get that added? Did he not respond or
you couldn’t make a PR?
Jason
> On Oct 17, 2016, at 1:11 AM,
On 16/10/16 19:52, Robert Scholte wrote:
> To enforce the discipline, the java compiler should IMHO at least
> check if all required modules are indeed required and if the
> transitive required modules are indeed transitive.
How can the compiler possibly know this? There are ways of requiring
a
Hi Robert,
On 10/16/2016 08:52 PM, Robert Scholte wrote:
Hi,
with the introduction of the module-info something interesting is
happening. Up until now the scope of a Java project was limited to the
compilation of the classes. In case of Maven the end-user was in full
control regarding the c
The compiler can not detect dead code because it can be a library.
jlink can detect dead code and provide a list of unneeded modules because it
has the view of the whole application.
Rémi
On October 17, 2016 10:45:26 AM GMT+02:00, Andrew Haley wrote:
>On 16/10/16 19:52, Robert Scholte wrote:
I didn't had dead code in mind. And as Remi explained it cannot be
detected on a jar-base, only on an application base. (which reminds me
that we also need to have a look at the minimizeJar option of the
maven-shade-plugin).
My idea was more about collecting all classes required to compile th
Hello Jason,
I do not know about Hervé, I checked out the gossip source to maybe add the
needed documentation for configuring gossip, but found the Maven module
structure, the code structure and the configuration format very confusing
and after spending two hours to figure out how to easily handle
adding some rendering code like supported by Gossip, and eventually adding the
rendering feature to slf4j-simple seemed sufficiently easy to give it a try:
done and was as easy as expected
Now, adding every slf4j-simple feature to Gossip require more work (it's not
simply about rendering: need
On Sun, 16 Oct 2016 05:12:42 +0200, Christian Schulte
wrote:
Am 10/16/16 um 02:03 schrieb Stephen Connolly:
On 16 Oct 2016, at 00:07, Christian Schulte wrote:
Any thoughts about how to name that new build pom?
project.mvn or pom.mvn
But only if we move to a non-xml DSL
If we are still X
just for the records: does not fix any errors reported by Checkstyle
"// CHECKSTYLE_OFF: RegexpHeader" remains in the files to ignore the standard
header check (that cannot be applied to package-info.java)
Regards,
Hervé
Le dimanche 16 octobre 2016 20:25:16 micha...@apache.org a écrit :
> Repo
Am 2016-10-17 um 21:27 schrieb Hervé BOUTEMY:
just for the records: does not fix any errors reported by Checkstyle
"// CHECKSTYLE_OFF: RegexpHeader" remains in the files to ignore the standard
header check (that cannot be applied to package-info.java)
Do you still have errors? I was not able t
On Mon, 17 Oct 2016 12:59:25 +0200, Alan Bateman
wrote:
On 17/10/2016 08:32, Peter Levart wrote:
:
Do we need an --exclude-modules (in addition to --add-modules) option
on javac, java and jlink commands?
--exclude-modules would be different to --limit-modules. If some module
requires
FYI: the JUnit team is working on relicensing their provider code under AL
2.0 so there should not be a problem for us to accept their contribution.
https://github.com/junit-team/junit5/issues/541
BR,
Benedikt
Benedikt Ritter schrieb am Di. 4. Okt. 2016 um 19:41:
> Hello Tibor,
>
> Tibor Digana
Could you at least raise the issues that you see as blocking Gossip against
it. I presume you have them currently in your context and it would be good
to capture them now so that if somebody can add those features to Gossip
(assuming they are aligned with the direction Gossip wants to go) then we
c
Le lundi 17 octobre 2016 21:41:07 Michael Osipov a écrit :
> Am 2016-10-17 um 21:27 schrieb Hervé BOUTEMY:
> > just for the records: does not fix any errors reported by Checkstyle
> >
> > "// CHECKSTYLE_OFF: RegexpHeader" remains in the files to ignore the
> > standard header check (that cannot be
Am 2016-10-17 um 22:16 schrieb Hervé BOUTEMY:
Le lundi 17 octobre 2016 21:41:07 Michael Osipov a écrit :
Am 2016-10-17 um 21:27 schrieb Hervé BOUTEMY:
just for the records: does not fix any errors reported by Checkstyle
"// CHECKSTYLE_OFF: RegexpHeader" remains in the files to ignore the
stand
A little bit off-topic:
the package + newlines are part of the license. That's not exactly correct.
For the module-info(java9) you want to specify the license (and check for
it), but it doesn't have a package.
Better to split this up in 2 rules: license and package-declaration
(module-info exc
FYI, I found the cause of the issue: this could be useful to share...
I defined a ~/.mavenrc file which defined MAVEN_OPTS env variable
since maven-invoker-plugin passed configuration from invoker.properties as
MAVEN_OPTS env variable content, .mavenrc was just overriding
I changed my .mavenrc
uh, why is it ignoring // CHECKSTYLE_OFF: RegexpHeader?
$ git branch
* (détaché de 0dc0cca)
1.0.x
master
$ mvn deploy
...
[INFO] --- maven-jar-plugin:3.0.0:jar (default-jar) @ maven-resolver-api ---
[INFO] Building jar: /home/herve/projets/maven/git/maven-resolver/maven-
resolver-api/target/
20 matches
Mail list logo