Please close MCHECKSTYLE-138

2019-12-13 Thread Benjamin Marwell
Hello all, I just checked https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-138. I am positive that this issue has been resolved for a long time now and can be closed. -- Also, I have three open pull requests at the moment (for the checkstyle plugin). If you'd like me to

Re: Please close MCHECKSTYLE-378

2019-12-14 Thread Benjamin Marwell
arbaise > On 14.12.19 12:29, Benjamin Marwell wrote: > > Dear devs, > > > > I am positive that > > https://issues.apache.org/jira/browse/MCHECKSTYLE-378 can be closed. > > The user tried to use a configuration for the wrong goal, see comment. >

Please close MCHECKSTYLE-378

2019-12-14 Thread Benjamin Marwell
Dear devs, I am positive that https://issues.apache.org/jira/browse/MCHECKSTYLE-378 can be closed. The user tried to use a configuration for the wrong goal, see comment. Proposed resolution: Not a bug. Thanks, Ben - To

Re: Defining EoL for Older Maven Versions

2019-12-14 Thread Benjamin Marwell
I do know companies who still use 3.2.3 and they don't dare to update because of a misconfiguration. Should we care? Or perhaps they should have bought support contracts for such use cases? If we say "support the 3.6 branch fur such amount of time" it also means reacting to vulnerabilities in

MENFORCER-288 - maybe reject?

2019-12-14 Thread Benjamin Marwell
Hi all, I just tried to implement MENFORCER-288 to see how far I could get. As it turned out, the task is not trivial, because you'd have to parse and correctly rewrite a version range. See details in the comments on MENFORCER-288. Because of this, I don't think the recommendation to use

Re: MCHECKSTYLE-373

2019-12-15 Thread Benjamin Marwell
, wrote: > Hi, Ben, > > afaict, the issue *is* closed. > > Jochen > > On Sat, Dec 14, 2019 at 6:09 PM Benjamin Marwell > wrote: > > > > Hi all, > > > > I think issue this can be closed: > >https://issues.apache.org/jira/browse/MCHECKSTYL

Re: Contributing on the maven Checkstyle plugin

2019-12-12 Thread Benjamin Marwell
ss there better for such task. > Feel free to tag me @eolivelli > > Cheers > Enrico > > Il mer 11 dic 2019, 17:19 Benjamin Marwell ha scritto: > > > Hi all, > > > > I'm new to this list and have contributed a single commit to CXF so far and > > would lik

Contributing on the maven Checkstyle plugin

2019-12-11 Thread Benjamin Marwell
Hi all, I'm new to this list and have contributed a single commit to CXF so far and would like to start committing on other apache maven projects as well. I'm this case: https://issues.apache.org/jira/browse/MCHECKSTYLE-356 While I think this issue is really not that important, it seems to be a

Please close MCHECKSTYLE-383

2019-12-12 Thread Benjamin Marwell
Hello, the issue https://issues.apache.org/jira/browse/MCHECKSTYLE-383 can be closed if I read it correctly. I think the issue reporter meant to report this issue over at https://github.com/checkstyle/checkstyle/issues. Ben -

MCHECKSTYLE-373

2019-12-14 Thread Benjamin Marwell
Hi all, I think issue this can be closed: https://issues.apache.org/jira/browse/MCHECKSTYLE-373 The original author is just asking for how to specify a property via command line. Best regards, Ben - To unsubscribe, e-mail:

Re: More checkstyle API changes

2019-12-23 Thread Benjamin Marwell
23 déc. 2019 à 09:27, Benjamin Marwell a > écrit : > > > Hi Enrico, > > > > that would mean a lot of incompatibilities which I wanted to avoid. > > If the checkstyle jar is updated first (8.xx), maven users wouldn't be > able > > to use a current versi

Re: More checkstyle API changes

2019-12-23 Thread Benjamin Marwell
schrieb Romain Manni-Bucau > > >: > > > > > > Point is it is the only way to not break end user since it gives us the > > > control of which version to select depending user config and java > > version. > > > Which we dont ask any change to user im

Re: More checkstyle API changes

2019-12-23 Thread Benjamin Marwell
omain Manni-Bucau < > rmannibu...@gmail.com>: > >> > >> Point is it is the only way to not break end user since it gives us the > >> control of which version to select depending user config and java > version. > >> Which we dont ask any change to user im fi

Re: More checkstyle API changes

2019-12-23 Thread Benjamin Marwell
gt; > > Le lun. 23 déc. 2019 à 16:44, Benjamin Marwell a > écrit : > > > Furthermore, > > > > if we do not drop using that method, maven will throw an exception. Maven > > will, not checkstyle. > > > > I do not think that should be ha

[MCHECKSTYLE] two PRs (Value class and warning for old checkstyle)

2020-02-26 Thread Benjamin Marwell
STYLE-387] emit a warning when using an old version of checkstyle" New PR to fix task https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-387 Thanks and best regards, Benjamin Marwell - To unsubscribe,

Checkstyle: NoSuchMethodError does not catch

2020-03-01 Thread Benjamin Marwell
Hi, might someone please explain why catching a NoSuchMethodError at runtime does not work and we did not see this coming? In my understanding the old 8.29 checkstyle version should only be a compile dependency, but not a runtime dependency. And the patch even was approved by two or three of

Re: Cutting Checkstyle 3.1.1

2020-02-06 Thread Benjamin Marwell
For most users this is the line length check. Other than that, there is an issue on the bug tracker for this. Please close it after merging. On Thu, 6 Feb 2020, 16:02 Elliotte Rusty Harold, wrote: > From that bug it looks like the incompatibilities might be more subtle > than a complete

Abandoned project

2020-01-31 Thread Benjamin Marwell
Hi, someone just found out that some former codehaus projects are abandoned nowadays. Are there any plans to make them an Apache Project? I guess there probably must have been a discussion on this list, but I haven't found any. Recent example:

Re: Profiles, builds, and repositories

2020-01-24 Thread Benjamin Marwell
There are cases where profiles must steer the build output though, although they are rare. For example, look at lmdb-native on GitHub. lmdb uses lots of native methods. As they are building the jars containing the .so files from the very same sources, they control the ci using profiles (Jenkins

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.1

2020-02-11 Thread Benjamin Marwell
In the hope that the approved PRs get merged soon, +1 (non-binding). I'd be happy to contribute more afterwards. Am Di., 11. Feb. 2020 um 13:47 Uhr schrieb Enrico Olivelli : > > Thank you Hervé > > I need two more binding +1 please > > Enrico > > Il Sab 8 Feb 2020, 21:43 Hervé BOUTEMY ha

Re: [MCHECKSTYLE] release for upstream checkstyle

2020-01-15 Thread Benjamin Marwell
> > > > > > > Il dom 12 gen 2020, 08:35 Enrico Olivelli ha > > > scritto: > > > > > >> Ben > > >> It is a good idea. > > >> > > >> Any volunteer? > > >> > > >> Enrico > > >> >

[MCHECKSTYLE] release for upstream checkstyle

2020-01-10 Thread Benjamin Marwell
Hi everyone, since the classloader issue is resolved in the master branch, I'd like to suggest a release before merging the violation class PR. The sooner the better (for the checkstyle team anyway). Thanks, Ben - To

[maven-checkstyle-plugin] unmerged PRs

2020-01-02 Thread Benjamin Marwell
Dear list members, there are currently unmerged PRs for the checkstyle plugin: https://github.com/apache/maven-checkstyle-plugin/pulls Some of them seem to be no-brainers (readme-/pom-url-/site-updates), others have been discussed exhaustively. How do I/we get them merged? I know that Robert

More checkstyle API changes

2019-12-22 Thread Benjamin Marwell
Hi all, The checkstyle team is waiting for my PR: https://github.com/apache/maven-checkstyle-plugin/pull/18 The problem is, that they want to remove a method. If they do this too early, maven users will not be able to update the checkstyle version anymore. Also, the maven Checkstyle plugin

Re: More checkstyle API changes

2019-12-23 Thread Benjamin Marwell
would be that you (or anyone from Checkstyle) create a PR when > you are ready with the new release. > > I will be happy to help you move forward with this change and cut a release > > Cheers > Enrico > > Il lun 23 dic 2019, 07:21 Benjamin Marwell ha > scritto: > &g

Re: More checkstyle API changes

2019-12-29 Thread Benjamin Marwell
Romain Manni-Bucau, wrote: > Le lun. 23 déc. 2019 à 17:51, Benjamin Marwell a > écrit : > > > Sounds good to me. > > > > A new major is not needed for my PR, but needed for future versions of > > checkstyle. Depends on how fast they actually remove that method. &

Re: More checkstyle API changes

2019-12-30 Thread Benjamin Marwell
Can't wait to see it integrated, as I will add another PR based on the previous one to emit a message and deprecate that new method. Do I need to do something to have the PR merged? On Sun, 29 Dec 2019, 17:38 Enrico Olivelli, wrote: > Il dom 29 dic 2019, 16:02 Benjamin Marwell ha > s

Re: [DISCUSS] Merging small plugins

2020-01-05 Thread Benjamin Marwell
Hi, thanks for sharing your idea. While I can see the benefits, I also do see some drawbacks. If only one part of the plugin has an invalid state, it will be impossible to create a release. Also, the Unix philosophy (make a tool which does one thing well) would be broken. If voting is a

Re: source directory layout for multirelease jars

2020-04-30 Thread Benjamin Marwell
Hi, to make the story a bit shorter - for most libraries it would be sufficient to add a way to include a module descriptor at "META-INF/versions/9/module-info.class" while still staying at java 8. Most libraries will stick to java 8 or even 7 for quite a time. Sadly, you cannot just add

Re: (anonymous) github user commits

2020-03-21 Thread Benjamin Marwell
Checkstyle builds will fail of there is more than one commit in a PR. Not saying I like it, but it's an option. On Sat, 21 Mar 2020, 16:17 Elliotte Rusty Harold, wrote: > So it appears that if I do all squashing and merging locally and then > push directly to master, I get listed as

[MCHECKSTYLE] Request for merging PRs #17 and #28 please

2020-08-17 Thread Benjamin Marwell
Hi, PRs #17 and #28 seem to be ready to be merged. They are also approved by reviewers. If they still look good, could they be merged? They are open for a while now. * https://github.com/apache/maven-checkstyle-plugin/pull/17 * https://github.com/apache/maven-checkstyle-plugin/pull/28 Thanks!

[RESULT] [VOTE] Release Maven JLink Plugin version 3.1.0

2020-12-27 Thread Benjamin Marwell
Hi, The vote has passed with the following result: +1: Sylwester Lachiewicz, Romain Manni-Bucau, Karl Heinz Marbaise, Hervé BOUTEMY, Benjamin Marwell, Robert Scholte PMC quorum: reached I will promote the artifacts to the central repo.

Re: [VOTE] [MJLINK] Release Apache Maven JLink Plugin version 3.0.0

2020-12-27 Thread Benjamin Marwell
Hi, The vote has passed with the following result: +1: Sylwester Lachiewicz, Romain Manni-Bucau, Karl Heinz Marbaise, Hervé BOUTEMY, Benjamin Marwell, Robert Scholte PMC quorum: reached I will promote the artifacts to the central repo. Am So., 27. Dez. 2020 um 14:13 Uhr schrieb Robert Scholte

Re: Build windows-jdk15

2021-01-06 Thread Benjamin Marwell
If this happens again, Please add it to the ticket as requested by infra. Link below. Thanks - Ben https://issues.apache.org/jira/browse/INFRA-21244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259498#comment-17259498 On Fri, 1 Jan 2021, 16:54 Benjamin Marwell

[MAVEN-ALL] Restrict imports or API usage by enforcer plugins / other plugins

2020-11-27 Thread Benjamin Marwell
Hello everyone, MJLINK-PR19 [1] removes some plexus imports. In the PR discussion the idea came up to add an enforcer rule to this or even other plugins which forbids imports, e.g. to plexus. There is also a weaker version, the forbidden-api checker [2] can check for specific method calls, e.g.

Re: Maven issue with JDK16 - javac and javadoc

2020-12-14 Thread Benjamin Marwell
we could solve it in a maven release 3.6.4 if you wished, or the next compiler plugin as soon as the next plexus javac dependency is available. I wouldn't mind a 3.6.4 release and cherry picking the change to 4.0.0, as that would be a quick solution. On Sun, 13 Dec 2020, 17:12 Benjamin Marw

Re: Maven issue with JDK16 - javac and javadoc

2020-12-13 Thread Benjamin Marwell
; know we can do the same for all other tools. > If we have a good feeling about the implementation, we could use it at > reference for other plugins as some kind of pattern. > > Robert > On 13-12-2020 11:39:02, Benjamin Marwell wrote: > Robert already suggested to use ToolProvi

Re: Maven issue with JDK16 - javac and javadoc

2020-12-13 Thread Benjamin Marwell
Robert already suggested to use ToolProvider for the JDK9+ builds. I created such a patch for jlink and I could create s similar one for the compiler and javadoc plugin. This would solve the underlying problem from my understanding. As fork mode and fork count would not apply, I would suggest

Re: Maven issue with JDK16 - javac and javadoc

2020-12-13 Thread Benjamin Marwell
JIRA issue (please kindly review): https://issues.apache.org/jira/browse/MCOMPILER-445 Am So., 13. Dez. 2020 um 14:07 Uhr schrieb Benjamin Marwell < bmarw...@apache.org>: > > If is has proven itself for jlink, then we know we can do the same for > all other tools. >

[MJLINK] Move from 3.0.1 to 3.1.0

2020-12-15 Thread Benjamin Marwell
Hello everyone, looking at the issues already solved and soon-be-solved, the next release feels much more like a 3.1.0 release than a 3.0.1 (bugfix) release [1]. If you agree, I would like to update the git repository to 3.1.0 and create a 3.0.x branch from the last release, if needed. I would

Re: [VOTE] [MJLINK] Release Apache Maven JLink Plugin version 3.0.0

2020-12-22 Thread Benjamin Marwell
onfigure > toolchains on my side and afterwards the IT's can be executed... I doubt > that toolchains is configured on CI?? > > > I think we need to reconsider the usage of toolchains within an invoker > test or the support for toolchains in invoker... furthermore the > question

Re: First issue

2020-12-22 Thread Benjamin Marwell
Hi Andrey, Robert suggested this list, which is automatically updated: https://cwiki.apache.org/confluence/display/MAVEN/Maven+JIRA+issues+overview The following link leads to a list which are marked with labels like "beginner", "easyfix", etc. and are maven-related projects:

Re: [Idea] Coding Guidelines for Maven Contribution Newbies

2020-12-22 Thread Benjamin Marwell
Hi Anders, those are outdated – not everything you need is included, at least for IntelliJ. YMMV when using those. There is a lot which could be done. E.g. updating those files, some general code guidelines (like: do not use guard statements, rather use an else), etc., when (not) to use

[VOTE] [MJLINK] Release Apache Maven JLink Plugin version 3.0.0

2020-12-21 Thread Benjamin Marwell
Hi, We solved 12 issues: https://issues.apache.org/jira/projects/MJLINK/versions/12349376 There are three issues left in JIRA:

Re: Maven issue with JDK16 - javac and javadoc

2020-12-14 Thread Benjamin Marwell
cholte < rfscho...@apache.org>: > I'm pretty sure this can be solved without touching the maven startup > scripts. > And I don't like the idea to hack the script because one plugin has issues. > I expect good help on your question on the jigsaw mailinglist. > > Robert > On 14-1

Re: [VOTE] [MJLINK] Release Apache Maven JLink Plugin version 3.0.0

2020-12-27 Thread Benjamin Marwell
Hi, I need one more PMC vote please. :-) Btw, here is my +1 (non-binding). Am Mo., 21. Dez. 2020 um 16:40 Uhr schrieb Benjamin Marwell < bmarw...@apache.org>: > Hi, > > We solved 12 issues: > https://issues.apache.org/jira/projects/MJLINK/versions/12349376 > > The

Re: [Idea] Coding Guidelines for Maven Contribution Newbies

2020-12-27 Thread Benjamin Marwell
Hi Sandra, hi everyone, here’s another subtopic: I recently added a comment like this: // [issue-##]: Do call method x because of side effect x But I got a review "the comment is redundant because of the git log". Is there a policy on where and how to put comments in the code? Reference:

[ALL] Tests on the one other VM: OpenJ9

2020-11-13 Thread Benjamin Marwell
Hi everyone, In the Apache Shiro project I was able to fix a few issues which only occured on the OpenJ9 VM. The OpenJ9 VM is the only big Java VM implementation next to hotspot. All other VMs (or most other relevant VMs) are hotspot forks. This is the only VM that actually differs from the

Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0

2020-11-13 Thread Benjamin Marwell
3.0.0? This is the first release, so 1.0.0 feels right. > > On Fri, Nov 13, 2020 at 4:45 PM Benjamin Marwell wrote: > > > > +1 (non-binding) > > > > On 2020/11/11 22:14:35, Karl Heinz Marbaise wrote: > > > Hi, > > > > > > We solved 37 issues: > &g

Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0

2020-11-18 Thread Benjamin Marwell
Hello Karl Heinz, I am chaning my vote to 0 (neutral / non binding). Reason: I wrote an integration test which uses JDK8 and a Toolchain. There seems to be a clash of asm dependencies. As using maven with JDK/JRE8 and a toolchain is unlikely, I will stand neutral here. The cause is being

Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0

2020-11-18 Thread Benjamin Marwell
Now changing to -1 as this will fail on Java 8 + toolchain, but the site does not mention this. This is clearly visible from the integration test I added in PR 16. On Wed, 18 Nov 2020, 21:59 Robert Scholte, wrote: > +1 > > On 11-11-2020 23:14:51, Karl Heinz Marbaise wrote: > Hi, > > We

[MJLINK] Question about junit4 / junit5

2020-11-13 Thread Benjamin Marwell
Hello, there are currently two PRs for the maven-jlink-plugin. One removes support for junit4. Another one removes support for junit5. On both PRs are discussions with valid points for one or the other. The best one (in my opinion as a contributor) would be to "ask the community first" if a

Re: [VOTE] Release Apache Maven JLink Plugin version 3.0.0

2020-11-13 Thread Benjamin Marwell
+1 (non-binding) On 2020/11/11 22:14:35, Karl Heinz Marbaise wrote: > Hi, > > We solved 37 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321432=12343851 > > There are still a couple of issues left in JIRA: >

Re: Build windows-jdk15

2020-12-31 Thread Benjamin Marwell
Here you go: https://issues.apache.org/jira/browse/INFRA-21244 Already opened a week ago when Hervé tried to merge a PR and suddenly the build failed. Disabling JDK15 might be a valid solution if they don't react soon. On Wed, 30 Dec 2020, 14:59 Elliotte Rusty Harold, wrote: > The Windows

Re: [maven-enforcer-plugin] Any plans on releasing 3.0.0-M4?

2021-01-20 Thread Benjamin Marwell
Hi, in [1] MENFORCER-338, there is a comment that an exclusion/inclusion list might be feasible. If there is a release soon, such an upcoming PR will break the single item in -M5. Should this be altered before release? [1] https://issues.apache.org/jira/browse/MENFORCER-338 Am Mi., 20. Jan.

Fwd: [ANN] Apache Maven JLink Plugin 3.1.0 Released

2021-01-14 Thread Benjamin Marwell
The Maven team is pleased to announce the release of the Apache Maven JLink Plugin, version 3.1.0 The JLink Plugin is intended to create a Modular Java Run-Time Images via jlink. https://maven.apache.org/plugins/maven-jlink-plugin/ You should specify the version in your project's plugin

Re: Loging api in JSR-330 component

2021-01-25 Thread Benjamin Marwell
; > > > > > > > > Le lun. 25 janv. 2021 à 07:41, Mark Struberg > > > > > > > > > > > > > > a > > > > > > > écrit : > > > > > > > > > > > > > > > +1Technically from a

Re: Logging api in plugins

2021-01-22 Thread Benjamin Marwell
https://maven.apache.org/maven-logging.html needs to be updated, but also some plugins where changes were already made. This was from slack: https://issues.apache.org/jira/browse/MNG-6931 And plugins pulling in slf4j directly happen all the time:

Re: Maven issue with JDK16 - javac and javadoc

2021-01-13 Thread Benjamin Marwell
; probably there is no need for a fix on Maven > > Enrico > > Il giorno lun 14 dic 2020 alle ore 22:12 Benjamin Marwell < > bmarw...@apache.org> ha scritto: > > > > I'm pretty sure this can be solved without touching the maven startup > > scripts. > &

Re: Loging api in JSR-330 component

2021-01-23 Thread Benjamin Marwell
Github < > https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > Le sam. 23 janv. 2021 à 17:58, Benjamin Marwell a > écrit :

Re: Loging api in JSR-330 component

2021-01-23 Thread Benjamin Marwell
Robert, that's deprecated! What to use instead? Or was it deprecated in error? https://github.com/apache/maven/blob/master/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging/Log.java On Sat, 23 Jan 2021, 12:10 Robert Scholte, wrote: > See >

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

2021-01-24 Thread Benjamin Marwell
[X] +1 (non binding) sha512 is correct for me Works in a sample project. Am So., 24. Jan. 2021 um 00:02 Uhr schrieb Sylwester Lachiewicz : > > Hi, > > We solved 5 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12347024=Text > > There are still a couple of

Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

2021-01-24 Thread Benjamin Marwell
junit.Test; > > public class ViolationTest > { > > @Test > public void testEquals() { > Violation v1 = new Violation("", null, "", "", "", "", ""); > Violation v2 = new Violation("", n

Re: [maven-enforcer-plugin] Any plans on releasing 3.0.0-M4?

2021-01-24 Thread Benjamin Marwell
inclusion support [1], feel free to > have a look. > > [1] https://github.com/apache/maven-enforcer/pull/86 > > ср, 20 янв. 2021 г. в 22:50, Benjamin Marwell : > > > Hi, > > > > in [1] MENFORCER-338, there is a comment that an exclusion/inclusion > > list mi

Re: Build windows-jdk15

2021-01-01 Thread Benjamin Marwell
Happy new year everyone! Maybe you want to add the links to the ticket, so infra has more jobs to analyse? - Ben On Fri, 1 Jan 2021, 16:16 Elliotte Rusty Harold, wrote: > And the next run everything passed without any code changes: > > >

OpenJ9 arrives in Jenkins

2021-01-02 Thread Benjamin Marwell
Hello everyone! Originally I opened issue INFRA-21061 [1] for Apache Shiro, when I became a committer and found out that OpenJ9 did not implement non-mandatory aliases for some cryptographic algorithms (and was right to omit them as per spec). Anyway, OpenJ9 arrived on the Apache Jenkins

Re: [MJLINK] Move from 3.0.1 to 3.1.0

2020-12-15 Thread Benjamin Marwell
: Those who understand binary, and those who don't. To understand recursion, we must first understand recursion. On Tue, Dec 15, 2020 at 10:38 PM Benjamin Marwell wrote: Hello everyone, looking at the issues already solved and soon-be-solved, the next release feels much more like a 3.1.0 release

Re: [MJLINK] Move from 3.0.1 to 3.1.0

2020-12-15 Thread Benjamin Marwell
have permissions Regards, Hervé Le mardi 15 décembre 2020, 22:37:21 CET Benjamin Marwell a écrit : Hello everyone, looking at the issues already solved and soon-be-solved, the next release feels much more like a 3.1.0 release than a 3.0.1 (bugfix) release [1]. If you agree, I would like

Re: jvm.config and spaces

2021-02-01 Thread Benjamin Marwell
Eval is probably needed, just look at how open liberty merges those lines [1]. As a user, I would expect spaces and comments to be supported. [1]:

Re: APT vs Markdown formats for site docs

2021-02-01 Thread Benjamin Marwell
Markdown is not a "standard" or "standardized". Even worse, different implementations have different feature sets. Thus my -1 for md. But another format might be feasible, really. fml looks verbose. Asciidoc might be a sane choice here. It was specially designed for technical documentation and

Re: Loging api in JSR-330 component

2021-01-26 Thread Benjamin Marwell
; > > > > > > > formatter-like api. > > > > > > > > > > > > > > > > Guillaume Nodet > > > > > > > > > > > > > > > > Le lun. 25 janv. 2021 à 07:41, Mark Struberg > > > > > > > > > >

Re: Supporting building with incompatible JDK versions on a single project

2021-06-15 Thread Benjamin Marwell
Tamás Cservenák, wrote: > Or xstream for that matter... > > ToP > > On Tue, Jun 15, 2021, 20:26 Tamás Cservenák wrote: > > > Just try to run hazelcast 3 (latest of 3.x) on java11. It will log what > it > > needs to be opened up. > > > > T on phone > &g

Re: [VOTE] Import mvndaemon/mvnd project @ Apache

2021-06-16 Thread Benjamin Marwell
+1 (nb) On Wed, 16 Jun 2021, 08:50 Olivier Lamy, wrote: > Hi > As already proposed by Guillaume, it looks to be a good idea to > import mvndaemon/mvnd here at Apache. > > I'd like to propose a vote for this. > +1: import the project here > 0 : no real idea > -1 : no (please explain why) > >

Re: Build windows-jdk11

2021-06-07 Thread Benjamin Marwell
I also opened https://issues.apache.org/jira/browse/INFRA-21954 #asfinfra on slack On Mon, 7 Jun 2021, 14:52 Michael Osipov, wrote: > Am 2021-06-07 um 14:36 schrieb Elliotte Rusty Harold: > > Build windows-jdk11 has been broken for a week+ now. Anyone want to > > take a look? I couldn't find

Re: Build windows-jdk11

2021-06-07 Thread Benjamin Marwell
ged INFRA-21690 to blocker, but still no response. > > Robert > On 7-6-2021 15:32:29, Benjamin Marwell wrote: > I also opened > > https://issues.apache.org/jira/browse/INFRA-21954 > > #asfinfra on slack > > On Mon, 7 Jun 2021, 14:52 Michael Osipov, wrote: > > &g

Re: JPMS, Maven and test jars

2021-06-22 Thread Benjamin Marwell
> So now you would have a maven module with only the main source and no tests, > and a second module > where the “main” source is actually the test classes > and the unit tests test the code in a different Maven > module with a module info that opens the module-info of the main source jar. >

Re: Supporting building with incompatible JDK versions on a single project

2021-06-15 Thread Benjamin Marwell
Tamás, which module do you open? In most cases I have encountered, adding jaxb as a dependency to the project is sufficient. But to be sure, we would need to see an example. I think this would have long been noticed if it was a common problem. Ben On Tue, 15 Jun 2021, 19:18 Tamás Cservenák,

Re: Moving away from Modello

2021-06-02 Thread Benjamin Marwell
> - For some time, JAXB has been bundled with the JRE. > As of this writing, this still applies to Java 8. >In Java 9, and 10, there's --add-modules=java.xml.bind. > As of Java 11, it has been removed from the JDK. > I'd consider that to be a migration problem. You can just include

Re: Maven compiler plugin Unsupported major.minor version

2021-02-10 Thread Benjamin Marwell
the > second doesn't, in my multi-module project with a parent module plus 8 > child modules it fails on the second module with 'mvn clean compile' from > the parent. > > I hope it helps. > Andrea > > Il giorno mar 9 feb 2021 alle ore 21:46 Benjamin Marwell < > bmarw...@apache

Re: Why no mvn daemon?

2021-03-30 Thread Benjamin Marwell
The class cache is also available since Java 8 in the OpenJ9 VM, which also has faster startup times in most cases (for me). Not sure if the scc is portable when using different Java language levels, though. But you can give it a try: https://www.eclipse.org/openj9/docs/shrc/ Other than that, I

Re: [MJLINK] Create JavaFX application runtime

2021-04-01 Thread Benjamin Marwell
Also had troubles, but in the end I got it working. You can use my simple GUI app for ROM manipulation as a template if you like. https://github.com/alttpj/MemeforceHunt It's a bit complicated as multiple OSes need to be supported. HTH Ben On Thu, 1 Apr 2021, 08:16 Abhinay Agarwal, wrote: >

Re: Why no mvn daemon?

2021-03-31 Thread Benjamin Marwell
ep posting your factual returns on experience: that's definitely > > useful > > > > Regards, > > > > Hervé > > > > [1] https://github.com/mvndaemon/mvnd > > > > Le mardi 30 mars 2021, 22:32:37 CEST Romain Manni-Bucau a écrit : > > > Le mar. 30

Re: [MJLINK] Create JavaFX application runtime

2021-04-02 Thread Benjamin Marwell
Glad it helped! I was thinking maybe this should be filed as an issue at the javafx mailing list. On Thu, 1 Apr 2021, 22:59 Abhinay, wrote: > Hi Robert, > > The issue can be reproduced using theJavaFX application hosted on Github >

Re: Core IT failures with AdoptOpenJDK 11 OpenJ9, but not with HotSpot

2021-03-01 Thread Benjamin Marwell
Hi Falko, I regularly work with OpenJ9 and encountered such issues. Sometimes it is a coding error which does not lead to an error in Hotspot, sometimes it is a J9 problem (e.g. JIT problems, class loading, etc.). If you want to dig in, there are a few things you can try: The JVM option

Re: JDeprscan plugin 3.0.0 ?

2021-02-24 Thread Benjamin Marwell
Sounds interesting! Is anyone using this yet? Seems to be a reasonable default plugin for builds, additional to -Dmaven.compiler.showDeprecation=true Probably another (maybe even more useful) goal would be to scan compile- and runtime dependencies as well. Am Di., 23. Feb. 2021 um 20:40 Uhr

Re: JDeprscan plugin 3.0.0 ?

2021-02-26 Thread Benjamin Marwell
e was even added to the issue tracker at some point. > > Cheers, > Andres > > On Wed, Feb 24, 2021 at 12:08 PM Benjamin Marwell > wrote: > > > Sounds interesting! Is anyone using this yet? > > > > Seems to be a reasonable default plugin for builds, additional

Re: Security/Versioning policy proposal

2021-04-19 Thread Benjamin Marwell
> Do we write 3.6 and 4 are active and maintained branches currently or do we > drop 3.x with first 4.x release? Dropping 3.x with the first 4.x release would not make sense from the point you presented earlier. I'd drop 3.x as soon as we reach 4.1.0. > maintenance branches on demands My vote

Re: Security/Versioning policy proposal

2021-04-20 Thread Benjamin Marwell
t keeps pushing this topic. > I noticed that it frustrates some and that it they loose their motivation > to work on Maven. > Please reconsider if it is still worth the discussion or that you can > solve it for yourself. > > thanks, > Robert > On 19-4-2021 20:05:53, Romain Manni

Re: GitHub Actions on Maven projects

2021-09-19 Thread Benjamin Marwell
That won't work for all plugins. The jlink plugin and others are using complicated setups so they can use toolchains on GitHub Actions. It's a little bit complicated there because the plugin does work with java 8 as long as a java 9+ is configured via toolchains. Please make sure those actions

Re: Commandline inheritance

2021-08-09 Thread Benjamin Marwell
Hi Robert, I would like to propose another solution. According to the wiki page and to the documentation, we have user < installation (aka global) < project. where "<" means "is overridden by". >From what I understand from other build systems, a more common approach would >be installation

Re: Commandline inheritance

2021-08-10 Thread Benjamin Marwell
there should be a list of other comparable tools with their order > > > Robert > > > [1] https://git-scm.com/docs/git-config#FILES > On 9-8-2021 15:09:30, Benjamin Marwell wrote: > Hi Robert, > > I would like to propose another solution. > According to the wiki pa

Re: Commandline inheritance

2021-08-11 Thread Benjamin Marwell
Yup, that's what I meant. Big +1! On Tue, 10 Aug 2021, 22:18 Tamás Cservenák, wrote: > A git like behavior sound good for me as well. > > So install/system-wise < user < project > > T > > > On Tue, Aug 10, 2021, 08:22 Benjamin Marwell wrote: > > > I read

Re: system path dependency warning, accurate or not?

2021-09-24 Thread Benjamin Marwell
Hi Michael! Setups like "${project.basedir}/m2/" are a common thing. While "system" scope was probably invented to use system (i.e. jdk-related) jar files, but otoh it is the only way to pull in artifacts which are stored next to the project's directory. If you don't think "system" scope should

Re: [maven-gh-actions-shared] branch main updated: first workflow

2021-10-14 Thread Benjamin Marwell
+1, we also do this in Apache Shiro [1] and the aspectj-maven-plugin (mojohaus) [2]. We don't reuse workflows yet, but what you have is just great! Thanks! - Ben [1]: https://github.com/apache/shiro/blob/df2f5481260bd778226473a658d237c047b7e840/.github/workflows/maven.yml [2]:

Re: Maven Code Style and imports layouts

2021-10-18 Thread Benjamin Marwell
+1! Sandra and I tried similar Suggestions a while back. This will help new contributors a lot. Thanks for your efforts! On Mon, 18 Oct 2021, 07:10 Slawomir Jaranowski, wrote: > Hi, > > In order to help make decisions, I prepared PR [1] with the most used order > layout in Maven Core. > >

Re: Using of Travis

2021-12-17 Thread Benjamin Marwell
+1 to drop Am Fr., 17. Dez. 2021 um 10:24 Uhr schrieb Romain Manni-Bucau : > > +1 to drop > > Romain Manni-Bucau > @rmannibucau | Blog > | Old Blog > | Github

Re: Maven Resolver + Wagon

2021-12-15 Thread Benjamin Marwell
Hi Tamas, this is great news! I agree with you that most protocols are either file:// (project-relative repositories) or https:// based nowadays. Thanks! Am Mi., 15. Dez. 2021 um 14:44 Uhr schrieb Guillaume Nodet : > > Such a massive performance improvement is really nice ! I don't know the >

Switch to Matomo Tracking code

2022-03-05 Thread Benjamin Marwell
Hi everyone! The ASF now runs a public Matomo instance [1]. They are open for more projects now. If it is okay with you, we could add a tracking code to our site.xml file [2]. It is an easy change, just add a body-head section [4]. Even if you do not agree to add Matomo, I will create a PR to

Re: Checkstyle 10.0, Java 11, Maven Checkstyle Plugin, and toolchain support

2022-03-07 Thread Benjamin Marwell
Hi Tim, tbh I did not even notice, because I use Java 11 to compile Java 8 projects. You can either use the properties maven.compiler.source/target or maven.compiler.release (recommended for Java 9+). This would require Java 11+ for your build, but the compiled bytecode will still be Java 8

Re: Switch to Matomo Tracking code

2022-03-06 Thread Benjamin Marwell
estions. On Sun, 6 Mar 2022, 12:04 Olivier Lamy, wrote: > Hi > looks good. > how do we have access to manage tracking id etc? > > On Sat, 5 Mar 2022 at 22:41, Benjamin Marwell wrote: > > > Hi everyone! > > > > The ASF now runs a public Mato

  1   2   >