Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-26 Thread Jason Dillon
Okay, good luck.  Let me know if you change your mind and need improvements to gossip. Cheers, —jason On October 22, 2016 at 10:20:08 AM, Hervé BOUTEMY (herve.bout...@free.fr) wrote: thanks for sharing what you had, this really helped me work on the topic, testing and learning misc approach

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-22 Thread Hervé BOUTEMY
thanks for sharing what you had, this really helped me work on the topic, testing and learning misc approaches. Now, the first feedback we've got on slf4j-simple to Gossip provider change is: - mailing list: some missing features - MNG-6044: missing documentation and integration improvements re

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-21 Thread Jason Dillon
FTR I choose Gossip because it was an slf4j impl I created which had more features than slf4j-simple but was also very small, and I had already previously implemented a ANSI color rendering scheme for it, as it was used by Maven Shell.   Its true that Gossip doesn’t have the same features as sl

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-19 Thread Hervé BOUTEMY
Le mercredi 19 octobre 2016 13:35:52 Stephen Connolly a écrit : > On 19 October 2016 at 12:37, Hervé BOUTEMY wrote: > > Le lundi 17 octobre 2016 20:58:16 Stephen Connolly a écrit : > > > Could you at least raise the issues that you see as blocking Gossip > > > > against > > > > > it. I presume y

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-19 Thread Stephen Connolly
On 19 October 2016 at 12:37, Hervé BOUTEMY wrote: > Le lundi 17 octobre 2016 20:58:16 Stephen Connolly a écrit : > > Could you at least raise the issues that you see as blocking Gossip > against > > it. I presume you have them currently in your context and it would be > good > > to capture them n

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-19 Thread Hervé BOUTEMY
Le lundi 17 octobre 2016 20:58:16 Stephen Connolly a écrit : > Could you at least raise the issues that you see as blocking Gossip against > it. I presume you have them currently in your context and it would be good > to capture them now so that if somebody can add those features to Gossip > (assum

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-17 Thread Stephen Connolly
Could you at least raise the issues that you see as blocking Gossip against it. I presume you have them currently in your context and it would be good to capture them now so that if somebody can add those features to Gossip (assuming they are aligned with the direction Gossip wants to go) then we c

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-17 Thread Hervé BOUTEMY
adding some rendering code like supported by Gossip, and eventually adding the rendering feature to slf4j-simple seemed sufficiently easy to give it a try: done and was as easy as expected Now, adding every slf4j-simple feature to Gossip require more work (it's not simply about rendering: need

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-17 Thread Mirko Friedenhagen
Hello Jason, I do not know about Hervé, I checked out the gossip source to maybe add the needed documentation for configuring gossip, but found the Maven module structure, the code structure and the configuration format very confusing and after spending two hours to figure out how to easily handle

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-17 Thread Jason van Zyl
So your approach was to fork some code, instead of trying to fix Gossip? I haven’t been paying much attention just trying to understand why you would fork instead of working with Jason Dillon to get that added? Did he not respond or you couldn’t make a PR? Jason > On Oct 17, 2016, at 1:11 AM,

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-16 Thread Hervé BOUTEMY
Hi Mirko, short answer: yes more precise answer: Gossip slf4j provider does not have color feature but has extensible Renderer interface which permits to inject Maven colorized renderer [1] with one configuration line [2] In maven-slf4j-simple, I copied the same Maven colorized renderer code [

Re: Maven 3.4.0 color output and default slf4j implementation

2016-10-16 Thread Mirko Friedenhagen
Hello Hervé, I would like a simple approach here. If I understand it correctly, gossip was chosen because of its color capability. If we could have this without switching the log provider it would be a good thing IMO. Gossip seems to be unconfigurable by means of system properties, which is a pity