[GitHub] metron issue #439: METRON-571 add stellar external functions feature - code ...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/439 HI do we have an update on the status of this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron pull request #696: METRON-1109: Indexing topology fails to start afte...

2017-08-14 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/696 METRON-1109: Indexing topology fails to start after Kerberos is enabled ## Contributor Comments There were a couple of syntax errors in indexing_commands.py that keeps the indexing topology

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133052945 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133049087 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133049444 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133037865 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133043905 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133046812 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133051603 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133049372 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133060635 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleSystem.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133035166 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133048319 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133062854 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133050317 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133047499 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133033964 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133061877 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133050916 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[GitHub] metron issue #695: METRON-1108: Metron configuration tabs are not showing up...

2017-08-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/695 +1 by inspection; this one was my bad from an earlier PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/530 @ottobackwards , many good improvements here. A few comments on the singleton idiom, and a couple other details. --- If your project is set up for it, you can reply to this email and have

[GitHub] metron issue #439: METRON-571 add stellar external functions feature - code ...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/439 As pointed out these should be in the management package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 @mattf-horton I really like how this is evolving. One thing I have been thinking of since adding the BundleSystem interface ( which should be the main external interface ) is that I would

[GitHub] metron pull request #680: METRON-1078: Metron Indexing fails to stop during ...

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/680 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] Code Reformatting next steps

2017-08-14 Thread Matt Foley
Sure, my suggestion was intended to minimize or remove project management overhead. If you’re willing to shepherd through the list of 40-ish modules, go for it. The same work gets done at the end. Suggest extracting a checker script from your fixer script, add it to the build utils, and run

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133033031 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[GitHub] metron issue #685: METRON-1087: Adjust license headers to be comments instea...

2017-08-14 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/685 @mmiklavc I'd need to merge in master, but there's a question I raised on the lists about just pairing a license fix ticket + a refactor ticket on a module by module basis. I think that'd be

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133081623 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/util/ImmutableCollectionUtils.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133083369 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleSystem.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-08-14 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/530 I'm seeing this error spinning up topologies in full-dev. ``` 1:50.278 o.a.s.util [ERROR] Async loop died! java.lang.RuntimeException: Grok parser Error: Grok parser unable to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133077758 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133078904 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleSystem.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-14 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r133090339 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,70 @@ +/** + *

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-14 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r133096320 --- Diff: metron-stellar/stellar-common/README.md --- @@ -411,6 +412,14 @@ In the core language functions, we support basic functional programming

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133081975 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleSystem.java --- @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-14 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r133091002 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/TextFunctions.java --- @@ -0,0 +1,70 @@ +/** + *

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079542 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079502 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079554 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079476 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079524 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079584 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079513 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079462 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #690: METRON-1091 Package STELLAR shell as stand alone

2017-08-14 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/690#discussion_r133076804 --- Diff: metron-deployment/packaging/archive/metron-stellar-shell/pom.xml --- @@ -0,0 +1,94 @@ + + +

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133076687 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133078228 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java --- @@ -0,0 +1,540 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079379 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java --- @@ -0,0 +1,213 @@ +/* + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079324 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r133079362 --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java --- @@ -0,0 +1,376 @@ +/* + * Licensed to the Apache

[GitHub] metron issue #681: METRON-1079 Add NaN as a keyword in STELLAR language

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/681 @cestella and I were talking about null variables and how NaN was being used, and that we probably needed NaN as a keyword. So I took a stab at it. --- If your project is set up for it, you

[GitHub] metron issue #697: METRON-1110: REST jvm flags property is being overwritten...

2017-08-14 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/697 Can we normalize this to use the same approach as is done with these 2 properties for enrichment and indexing? ``` enrichment_topology_worker_childopts = client_jaas_arg if security_enabled

[GitHub] metron pull request #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/667#discussion_r133117091 --- Diff: metron-stellar/stellar-common/README.md --- @@ -411,6 +412,14 @@ In the core language functions, we support basic functional programming

[GitHub] metron issue #685: METRON-1087: Adjust license headers to be comments instea...

2017-08-14 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/685 This Travis error with metron-alerts and nodejs is clearly not because of your changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] metron issue #680: METRON-1078: Metron Indexing fails to stop during "Stop A...

2017-08-14 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/metron/pull/680 @justinleet (or anyone really), I'd like to push this today, still good? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] metron issue #680: METRON-1078: Metron Indexing fails to stop during "Stop A...

2017-08-14 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/680 I'm still +1. Thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [DISCUSS] Code Reformatting next steps

2017-08-14 Thread Justin Leet
Unfortunately, I did not getting around to splitting out the changes over the weekend. Matt, it looks like your reply was pretty close to my email, so I'm not sure you saw it. Would you have objections to just doing the license fix and reformat as paired tickets, module-by-module? I think

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-14 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132980465 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44 @@ +/** + *

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 Casey, this adds a new packaging subfolder -> archive, and generates a new artifact ( the tar.gz ). It does not effect the current deployment of the stellar shell as a part of metron.

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

2017-08-14 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/694 METRON-1085: Add REST endpoint to save a user profile for the Alerts UI ## Contributor Comments This PR adds an ORM framework to the REST application. An ORM (object relational mapping)

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132958368 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44 @@ +/** + *

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/692#discussion_r132958347 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java --- @@ -0,0 +1,44 @@ +/** + *

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2017-08-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/690 I just want to make sure that we didn't break backwards compatibility and have the shell not deployed as part of the mpack, I guess ;) --- If your project is set up for it, you can reply to this

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 This is due to our time stuff being java Calendar based. We should have a new jira to convert to the new java.time concepts. --- *Comments from

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java, line 41 at

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/692 > can I ask why? Because that is 9x `9`s in epoch (`9`, assuming seconds). > for < 10, we don't know if it is millis or timestamps, at least that is my thinking. adding a

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 I'm going to close this. We need more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron pull request #692: METRON-1107 add support for handling epoch dates i...

2017-08-14 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/metron/pull/692 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java, line 248 at

[GitHub] metron issue #692: METRON-1107 add support for handling epoch dates in secon...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/692 *[metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/EpochUtils.java, line 36 at

[GitHub] metron issue #641: METRON-539: added HASH function for stellar.

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/641 https://reviewable.io/lgtm.png; height="20" width="61"/> --- *Comments from

[GitHub] metron issue #278: Metron 451 SerDeUtils - java.lang.ClassNotFoundException:...

2017-08-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/278 What is the status of this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled