[GitHub] [incubator-nlpcraft-ui] Akayeshmantha opened a new pull request #1: Modify the readme file.

Akayeshmantha opened a new pull request #1: Modify the readme file. URL: https://github.com/apache/incubator-nlpcraft-ui/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nlpcraft-ui] Akayeshmantha commented on issue #1: Modify the readme file.

Akayeshmantha commented on issue #1: Modify the readme file. URL: https://github.com/apache/incubator-nlpcraft-ui/pull/1#issuecomment-595459445 Hi @aradzinski it's great to see nlpcraft in apache incubator. Just did some minor changes on the readme. If possible open the issues tab

[GitHub] [incubator-nlpcraft-ui] aradzinski commented on issue #1: Modify the readme file.

aradzinski commented on issue #1: Modify the readme file. URL: https://github.com/apache/incubator-nlpcraft-ui/pull/1#issuecomment-595473204 Hi Akayeshmantha, Thank you fort chipping in! This repo is still in the migration phase - so please hold off just for a few days. We've

[GitHub] [incubator-nlpcraft-ui] asfgit merged pull request #1: Modify the readme file.

asfgit merged pull request #1: Modify the readme file. URL: https://github.com/apache/incubator-nlpcraft-ui/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nlpcraft-ui] aradzinski opened a new issue #2: Test

aradzinski opened a new issue #2: Test URL: https://github.com/apache/incubator-nlpcraft-ui/issues/2 test issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nlpcraft-ui] aradzinski closed issue #2: Test

aradzinski closed issue #2: Test URL: https://github.com/apache/incubator-nlpcraft-ui/issues/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nlpcraft-java-client] syermakov opened a new pull request #1: NLPCRAFT-48: Setup automated builds.

syermakov opened a new pull request #1: URL: https://github.com/apache/incubator-nlpcraft-java-client/pull/1 Summary: - Start NLPCraft server before integration tests (maven only, testing from IDE still needs a manually started server) - Fix build failures (JDK 11) - Enable

[GitHub] [incubator-nlpcraft] Ifropc commented on pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models

Ifropc commented on pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-629735553 Hi @skhdl , thanks you for your feedback. 1. Done 2. I think in general it's not very good approach, as it is not following XDG base directory specification. I

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models

skhdl commented on pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-629613105 Hi @Ifropc ! Thank your for your work, I have tried it and results are very impressive! Below some remarks for discussion: 1. start_server.sh - I think that better

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models

skhdl commented on pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-629625313 9. Could you add some base request validation and throw readable errors for such invalid requests? Just for main cases (empty request, invalid indexes range) - now

[GitHub] [incubator-nlpcraft-java-client] syermakov merged pull request #1: NLPCRAFT-48: Setup automated builds.

syermakov merged pull request #1: URL: https://github.com/apache/incubator-nlpcraft-java-client/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nlpcraft] syermakov merged pull request #2: NLPCRAFT-49: Probe hangs on stop.

syermakov merged pull request #2: URL: https://github.com/apache/incubator-nlpcraft/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nlpcraft] syermakov opened a new pull request #2: NLPCRAFT-49: Probe hangs on stop.

syermakov opened a new pull request #2: URL: https://github.com/apache/incubator-nlpcraft/pull/2 This PR should fix NLPCRAFT-49. **Details:** In the current version, an interrupted thread may receive an `InterruptedException` and check the `isInterrupted()` flag while the the

[GitHub] [incubator-nlpcraft] syermakov commented on pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models

syermakov commented on pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-625923342 @Ifropc Thank you very much for sharing, this feature looks very promising! I would suggest the following improvements: - Add Apache license header to all

[GitHub] [incubator-nlpcraft] Ifropc opened a new pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models

Ifropc opened a new pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1 This pull request should resolve [NLPCRAFT-11: auto-enrich user models with synonyms](https://issues.apache.org/jira/projects/NLPCRAFT/issues/NLPCRAFT-11?filter=allopenissues) Proposed approach

[GitHub] [incubator-nlpcraft-website] kamaci opened a new pull request #1: Fix for whimsy warnings.

kamaci opened a new pull request #1: URL: https://github.com/apache/incubator-nlpcraft-website/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nlpcraft-website] aradzinski merged pull request #1: Fix for whimsy warnings.

aradzinski merged pull request #1: URL: https://github.com/apache/incubator-nlpcraft-website/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nlpcraft] aradzinski merged pull request #7: Update NOTICE

aradzinski merged pull request #7: URL: https://github.com/apache/incubator-nlpcraft/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nlpcraft] moein7tl opened a new pull request #9: Correct the examples link in README.md

moein7tl opened a new pull request #9: URL: https://github.com/apache/incubator-nlpcraft/pull/9 Fix the examples broken link This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nlpcraft] Ifropc closed pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models

Ifropc closed pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nlpcraft] Ifropc commented on pull request #1: NLPCRAFT-11: Add auto-enrich using Bert and FastTest models

Ifropc commented on pull request #1: URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-636272081 I'm closing this pull request. Further work would be done in branch NLPCRAFT-67 Let's continue discussion in [related issue](NLPCRAFT-67) on Jira

[GitHub] [incubator-nlpcraft] syermakov merged pull request #8: NLPCRAFT-87: Probe start-up time improvements.

syermakov merged pull request #8: URL: https://github.com/apache/incubator-nlpcraft/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nlpcraft] Ifropc merged pull request #5: NLPRCAFT-67: Python machine learning module

Ifropc merged pull request #5: URL: https://github.com/apache/incubator-nlpcraft/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nlpcraft] asfgit closed pull request #6: NLPCRAFT-85: Maven profiles for Geo and Spell data

asfgit closed pull request #6: URL: https://github.com/apache/incubator-nlpcraft/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nlpcraft] syermakov opened a new pull request #6: NLPCRAFT-85: Maven profiles for Geo and Spell data

syermakov opened a new pull request #6: URL: https://github.com/apache/incubator-nlpcraft/pull/6 - Moved Geo resources to `nlpcraft-geo` module - Moved Spell resources to `nlpcraft-spell` module - Created `geo` and `spell` Maven profiles to include/exclude those modules (excluded

[GitHub] [incubator-nlpcraft] aradzinski commented on pull request #6: NLPCRAFT-85: Maven profiles for Geo and Spell data

aradzinski commented on pull request #6: URL: https://github.com/apache/incubator-nlpcraft/pull/6#issuecomment-650611747 I've made some changes. However, the source build 'prepare 0.6.2' still includes all sources for all modules (standford, spell, geo). It should only do so for the

[GitHub] [incubator-nlpcraft] aradzinski merged pull request #4: NLPCRAFT-73: Add new maven profile for GridGain Control Center Agent.

aradzinski merged pull request #4: URL: https://github.com/apache/incubator-nlpcraft/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nlpcraft] aradzinski commented on pull request #4: NLPCRAFT-73: Add new maven profile for GridGain Control Center Agent.

aradzinski commented on pull request #4: URL: https://github.com/apache/incubator-nlpcraft/pull/4#issuecomment-640289773 Works now. Not sure what was the problem - but can be merged now. This is an automated message from

[GitHub] [incubator-nlpcraft] Ifropc opened a new pull request #5: NLPRCAFT-67: Python machine learning module

Ifropc opened a new pull request #5: URL: https://github.com/apache/incubator-nlpcraft/pull/5 Python part which consists of Bert masked word prediction and FastText synonyms filter This is an automated message from the

[GitHub] [incubator-nlpcraft] syermakov opened a new pull request #3: NLPCRAFT-72: POM fixes (make Stanford dependencies optional).

syermakov opened a new pull request #3: URL: https://github.com/apache/incubator-nlpcraft/pull/3 Summary of changes: - Moved all the source code from the root `src` folder to the `nlpcraft` module - Added new `nlpcraft-stanford` module to store Stanford CoreNLP-related sources

[GitHub] [incubator-nlpcraft] aradzinski commented on pull request #3: NLPCRAFT-72: POM fixes (make Stanford dependencies optional).

aradzinski commented on pull request #3: URL: https://github.com/apache/incubator-nlpcraft/pull/3#issuecomment-639292450 Looks good to me. ```mvn clear package verify``` works. This is an automated message from the Apache

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #3: NLPCRAFT-72: POM fixes (make Stanford dependencies optional).

skhdl commented on pull request #3: URL: https://github.com/apache/incubator-nlpcraft/pull/3#issuecomment-639480763 Looks good to me. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nlpcraft] aradzinski commented on pull request #4: NLPCRAFT-73: Add new maven profile for GridGain Control Center Agent.

aradzinski commented on pull request #4: URL: https://github.com/apache/incubator-nlpcraft/pull/4#issuecomment-640163519 It doesn't seem to work. According to Ignite/GridGain docs, when GridGain Agent is on classpath the ignite should print cluster ID information. Currently - it doesn't

[GitHub] [incubator-nlpcraft] aradzinski edited a comment on pull request #4: NLPCRAFT-73: Add new maven profile for GridGain Control Center Agent.

aradzinski edited a comment on pull request #4: URL: https://github.com/apache/incubator-nlpcraft/pull/4#issuecomment-640163519 It doesn't seem to work. According to Ignite/GridGain docs, when GridGain Agent is on classpath the ignite should print cluster ID information. Currently - it

[GitHub] [incubator-nlpcraft] syermakov opened a new pull request #8: NLPCRAFT-87: Probe start-up time improvements.

syermakov opened a new pull request #8: URL: https://github.com/apache/incubator-nlpcraft/pull/8 Summary of changes: - Add `NCNlpTokenizerFactory` interface in order to bypass initialization of Scala reflections runtime - Change `NCNlpCoreManager` to use tokenizer factory -

[GitHub] [incubator-nlpcraft] aradzinski merged pull request #10: fix javadoc warning and fix build [https://issues.apache.org/jira/bro…

aradzinski merged pull request #10: URL: https://github.com/apache/incubator-nlpcraft/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nlpcraft] sreev opened a new pull request #10: fix javadoc warning and fix build [https://issues.apache.org/jira/bro…

sreev opened a new pull request #10: URL: https://github.com/apache/incubator-nlpcraft/pull/10 …wse/NLPCRAFT-176] Signed-off-by: Sree Vaddi <441385+sr...@users.noreply.github.com> This is an automated message from the

[GitHub] [incubator-nlpcraft-java-client] sreev opened a new pull request #2: fix invalid usage tag & [https://issues.apache.org/jira/browse/NLPCRA…

sreev opened a new pull request #2: URL: https://github.com/apache/incubator-nlpcraft-java-client/pull/2 …FT-175] Signed-off-by: Sree Vaddi <441385+sr...@users.noreply.github.com> This is an automated message from the

[GitHub] [incubator-nlpcraft] paulk-asert opened a new pull request #11: NLPCRAFT-92: Create Groovy-based example for NLPCraft.

paulk-asert opened a new pull request #11: URL: https://github.com/apache/incubator-nlpcraft/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nlpcraft] rahul3 opened a new pull request #14: Nlpcraft 333 - Changed DarkSky Weather API to OpenWeather API

rahul3 opened a new pull request #14: URL: https://github.com/apache/incubator-nlpcraft/pull/14 JIRA: [NLPCRAFT-333](https://issues.apache.org/jira/projects/NLPCRAFT/issues/NLPCRAFT-333) DarkSky Weather API was replaced by the [one-call-api

[GitHub] [incubator-nlpcraft] skhdl closed pull request #13: [NLPCRAFT-327] Fixed .nlpcraft directory not present issue

skhdl closed pull request #13: URL: https://github.com/apache/incubator-nlpcraft/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #13: [NLPCRAFT-327] Fixed .nlpcraft directory not present issue

skhdl commented on pull request #13: URL: https://github.com/apache/incubator-nlpcraft/pull/13#issuecomment-847616099 Fixed in code - look at https://issues.apache.org/jira/browse/NLPCRAFT-327 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nlpcraft-website] rahul3 opened a new pull request #3: fixed ClassNotFoundException in example

rahul3 opened a new pull request #3: URL: https://github.com/apache/incubator-nlpcraft-website/pull/3 https://issues.apache.org/jira/browse/NLPCRAFT-331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nlpcraft-website] aradzinski merged pull request #3: fixed ClassNotFoundException in example

aradzinski merged pull request #3: URL: https://github.com/apache/incubator-nlpcraft-website/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [incubator-nlpcraft] rahul3 opened a new pull request #13: [NLPCRAFT-327] Fixed .nlpcraft directory not present issue

rahul3 opened a new pull request #13: URL: https://github.com/apache/incubator-nlpcraft/pull/13 JIRA: [NLPCRAFT-327](https://issues.apache.org/jira/browse/NLPCRAFT-327) When I first built NLPCraft, the `.nlpcraft` folder did not auto-create. This code fix will make NLPCraft run

[GitHub] [incubator-nlpcraft-website] aradzinski merged pull request #3: fixed ClassNotFoundException in example

aradzinski merged pull request #3: URL: https://github.com/apache/incubator-nlpcraft-website/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [incubator-nlpcraft] rahul3 opened a new pull request #15: Nlpcraft 339 - Added test for PhoneModel example

rahul3 opened a new pull request #15: URL: https://github.com/apache/incubator-nlpcraft/pull/15 Added test for PhoneModel example, per JIRA [NLPCRAFT-339](https://issues.apache.org/jira/projects/NLPCRAFT/issues/NLPCRAFT-339) To test: `bin/nlpcraft.sh test-model

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #15: Nlpcraft 339 - Added test for PhoneModel example

skhdl commented on pull request #15: URL: https://github.com/apache/incubator-nlpcraft/pull/15#issuecomment-877316822 hi! I have few comments 1) Look at weather_example pom.xml. Similar should be for `phone` example pom.xml - junit should be added to pom.xml - test should

[GitHub] [incubator-nlpcraft] rahul3 commented on pull request #15: Nlpcraft 339 - Added test for PhoneModel example

rahul3 commented on pull request #15: URL: https://github.com/apache/incubator-nlpcraft/pull/15#issuecomment-877523986 Hello, Thank you for your comments. Your help is much appreciated. Your comments are addressed below in the same order: 1. I have updated the `pom.xml`. The

[GitHub] [incubator-nlpcraft] skhdl merged pull request #15: Nlpcraft 339 - Added test for PhoneModel example

skhdl merged pull request #15: URL: https://github.com/apache/incubator-nlpcraft/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nlpcraft] skhdl merged pull request #12: Nlpcraft 91

skhdl merged pull request #12: URL: https://github.com/apache/incubator-nlpcraft/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-nlpcraft] aradzinski merged pull request #11: NLPCRAFT-92: Create Groovy-based example for NLPCraft.

aradzinski merged pull request #11: URL: https://github.com/apache/incubator-nlpcraft/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nlpcraft-website] fredster33 opened a new pull request #2: Grammar fixes

fredster33 opened a new pull request #2: URL: https://github.com/apache/incubator-nlpcraft-website/pull/2 This PR includes a grammar fix, as well as aligning the shields and logo to the center. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nlpcraft] Ifropc opened a new pull request #12: Nlpcraft 91

Ifropc opened a new pull request #12: URL: https://github.com/apache/incubator-nlpcraft/pull/12 Example of Minecraft mod, which uses NLPCraft to process some console commands (see list of supported commands in README) -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nlpcraft] rahul3 commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902420616 @skhdl - I have fixed everything except updating the script to start the ctxserver. In my opinion, the script fix to initialize conda depending on the shell, can be part

[GitHub] [incubator-nlpcraft] rahul3 commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902322363 @syermakov - Thank you for your contribution to this discussion. We can do both i.e. installation scripts (for the user), and also have the full build in Maven

[GitHub] [incubator-nlpcraft] skhdl edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-900512842 Hi! I have few questions for discussion: 1) I don't think that we have to install python stuff from maven command. I guess it is not standard way. I think

[GitHub] [incubator-nlpcraft] syermakov commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

syermakov commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-901314341 @rahul3 thank you very much for sharing your excellent work! @skhdl thank you for detailed review! Let me also join the discussion of Ctxserver installation.

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-900512842 Hi! I have few questions for discussion: 1) I don't think that we have to install python stuff from maven command. I guess it is not standard way. I think it

[GitHub] [incubator-nlpcraft] rahul3 commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-900704222 Hello, Thank you for reviewing this thoroughly. To answer your questions (I'm sorry for this being lengthy but I don't know how else to convey this): > I

[GitHub] [incubator-nlpcraft] nivanov commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

nivanov commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902807376 I'll weigh in here. I think we should start with "everything in maven" approach. It should download/install everything when it detects that something Python

[GitHub] [incubator-nlpcraft] rahul3 commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902813969 @nivanov > I think we should start with "everything in maven" approach. It should download/install everything when it detects that something Python related is

[GitHub] [incubator-nlpcraft] nivanov edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

nivanov edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902831986 I think generally the more standard the build process - the better. 99% of people never ready any release notes or docs - they just run standard Maven toolchain

[GitHub] [incubator-nlpcraft] nivanov edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

nivanov edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902831986 I think generally the more standard the build process - the better. 99% of people never read any release notes or docs - they just run standard Maven toolchain

[GitHub] [incubator-nlpcraft] nivanov commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

nivanov commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902831986 I think generally the mode standard the build process - the better. 99% of people never ready any release notes or docs - they just run standard Maven toolchain and

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-901321981 @rahul3 thank you for your reply. I guess I understand conda role, but still doubt in maven. Will try to investigate. -- This is an automated message from the Apache Git

[GitHub] [incubator-nlpcraft] skhdl edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-901321981 @rahul3 thank you for your reply. I guess I undestood conda role, but still doubt in maven. Will try to investigate. -- This is an automated message from the

[GitHub] [incubator-nlpcraft] rahul3 opened a new pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 opened a new pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18 This pull request should achieve the desired objective of the following JIRA tickets: 1. [NLPCRAFT-394](https://issues.apache.org/jira/browse/NLPCRAFT-394) 2.

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-900512842 Hi! I have few questions for discussion: 1) I don't think that we have to install python stuff from maven command. I guess it is not standard way. I think it

[GitHub] [incubator-nlpcraft] skhdl edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-900512842 Hi! I have few questions for discussion: 1) I don't think that we have to install python stuff from maven command. I guess it is not standard way. I think

[GitHub] [incubator-nlpcraft] rahul3 commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-900704222 Hello, Thank you for reviewing this thoroughly. To answer your questions (I'm sorry for this being lengthy but I don't know how else to convey this): > I

[GitHub] [incubator-nlpcraft] rahul3 commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-903029544 @nivanov - Sounds good. The change is complete. `mvn clean package` and `mvn clean package verify` work fine on Mac OS, Linux and Windows for me. Please feel free

[GitHub] [incubator-nlpcraft] skhdl edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-903092819 Hi! I didn't review code yet but tried to test it. 1) I have updated sources 2) I deleted /.nlpcraft-python and all local models which were downloaded

[GitHub] [incubator-nlpcraft] skhdl edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-903092819 Hi! I didn't review code yet but tried to test it. 1) I have updated sources 2) I deleted /.nlpcraft-python and all local models which were downloaded

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-903092819 Hi! I didn't review code yet but tried to test it. 1) I have updated sources 2) I deleted /.nlpcraft-python and all local models which were downloaded into

[GitHub] [incubator-nlpcraft] skhdl edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

skhdl edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-901321981 @rahul3 thank you for your reply. I guess I understood conda role, but still doubt about maven. Will try to investigate. -- This is an automated message from the

[GitHub] [incubator-nlpcraft] rahul3 edited a comment on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 edited a comment on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-903142689 Hello @skhdl , Thank you for the review and the remarks. While all the remarks are certainly valid and need to be worked on, I find that some of them are

[GitHub] [incubator-nlpcraft] rahul3 commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-903142689 Hello @skhdl , Thank you for the review and the remarks. While all the remarks are certainly valid and need to be worked on, I find that some of them are out of

[GitHub] [incubator-nlpcraft] aradzinski commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

aradzinski commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902076384 I'm actually seeing @rahul3 point on maven - maintaining *.sh and *.cmd installation scripts will be a major pain (dev, testing, etc.). So, having a single mvn build

[GitHub] [incubator-nlpcraft] aradzinski commented on pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

aradzinski commented on pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18#issuecomment-902077240 Agree on conda - major plus in separating outselves from system Python installation. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nlpcraft] aradzinski merged pull request #17: Minor template fix. Added quotes.

aradzinski merged pull request #17: URL: https://github.com/apache/incubator-nlpcraft/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nlpcraft] aradzinski merged pull request #16: Nlpcraft 388

aradzinski merged pull request #16: URL: https://github.com/apache/incubator-nlpcraft/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nlpcraft] rahul3 opened a new pull request #16: Nlpcraft 388

rahul3 opened a new pull request #16: URL: https://github.com/apache/incubator-nlpcraft/pull/16 fixed dependency list for ctxserver. - added fasttext and other missing dependencies - added the `en-core-web-sm` model download -- This is an automated message from the Apache Git

[GitHub] [incubator-nlpcraft] rahul3 closed pull request #18: [NLPCRAFT-394] and more - Create a virtual/conda environment for python inside a new .nlpcraft-python folder

rahul3 closed pull request #18: URL: https://github.com/apache/incubator-nlpcraft/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request #20: Update jmh-core, jmh-generator-annprocess to 1.35

scala-steward opened a new pull request #20: URL: https://github.com/apache/incubator-nlpcraft/pull/20 Updates * [org.openjdk.jmh:jmh-core](http://hg.openjdk.java.net/code-tools/jmh/) * [org.openjdk.jmh:jmh-generator-annprocess](http://hg.openjdk.java.net/code-tools/jmh/)

[GitHub] [incubator-nlpcraft] nivanov closed pull request #21: Update jackson-databind to 2.13.2.2

nivanov closed pull request #21: URL: https://github.com/apache/incubator-nlpcraft/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nlpcraft] nivanov merged pull request #20: Update jmh-core, jmh-generator-annprocess to 1.35

nivanov merged pull request #20: URL: https://github.com/apache/incubator-nlpcraft/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nlpcraft] scala-steward closed pull request #19: Update jackson-databind to 2.13.2.1

scala-steward closed pull request #19: URL: https://github.com/apache/incubator-nlpcraft/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nlpcraft] scala-steward commented on pull request #19: Update jackson-databind to 2.13.2.1

scala-steward commented on pull request #19: URL: https://github.com/apache/incubator-nlpcraft/pull/19#issuecomment-1081377186 Superseded by #21. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request #21: Update jackson-databind to 2.13.2.2

scala-steward opened a new pull request #21: URL: https://github.com/apache/incubator-nlpcraft/pull/21 Updates com.fasterxml.jackson.core:jackson-databind from 2.13.2 to 2.13.2.2. I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

[GitHub] [incubator-nlpcraft] dependabot[bot] opened a new pull request, #22: Bump jackson-databind from 2.13.2 to 2.13.2.1

dependabot[bot] opened a new pull request, #22: URL: https://github.com/apache/incubator-nlpcraft/pull/22 Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.13.2 to 2.13.2.1. Commits See full diff in https://github.com/FasterXML/jackson/commits;>compare view

[GitHub] [incubator-nlpcraft] skhdl merged pull request #23: Update antlr4-runtime to 4.10

skhdl merged PR #23: URL: https://github.com/apache/incubator-nlpcraft/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request, #23: Update antlr4-runtime to 4.10

scala-steward opened a new pull request, #23: URL: https://github.com/apache/incubator-nlpcraft/pull/23 Updates [org.antlr:antlr4-runtime](https://github.com/antlr/antlr4/tree/master) from 4.9.3 to 4.10. I'll automatically update this PR to resolve conflicts as long as you don't

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request, #24: Update antlr4-runtime to 4.10.1

scala-steward opened a new pull request, #24: URL: https://github.com/apache/incubator-nlpcraft/pull/24 Updates [org.antlr:antlr4-runtime](https://github.com/antlr/antlr4/tree/master) from 4.9.3 to 4.10.1. I'll automatically update this PR to resolve conflicts as long as you

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request, #25: Update scalatest, scalatest-compatible, ... to 3.2.12

scala-steward opened a new pull request, #25: URL: https://github.com/apache/incubator-nlpcraft/pull/25 Updates * [org.scalatest:scalatest](https://github.com/scalatest/scalatest) * [org.scalatest:scalatest-compatible](https://github.com/scalatest/scalatest) *

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request, #27: Update jackson-dataformat-yaml to 2.13.3

scala-steward opened a new pull request, #27: URL: https://github.com/apache/incubator-nlpcraft/pull/27 Updates [com.fasterxml.jackson.dataformat:jackson-dataformat-yaml](https://github.com/FasterXML/jackson-dataformats-text) from 2.13.2 to 2.13.3. I'll automatically update this

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request, #28: Update jackson-module-scala to 2.13.3

scala-steward opened a new pull request, #28: URL: https://github.com/apache/incubator-nlpcraft/pull/28 Updates [com.fasterxml.jackson.module:jackson-module-scala](https://a...@github.com/FasterXML/jackson-module-scala) from 2.13.2 to 2.13.3. [GitHub Release

[GitHub] [incubator-nlpcraft-java-client] dependabot[bot] opened a new pull request, #3: Bump gson from 2.8.6 to 2.8.9

dependabot[bot] opened a new pull request, #3: URL: https://github.com/apache/incubator-nlpcraft-java-client/pull/3 Bumps [gson](https://github.com/google/gson) from 2.8.6 to 2.8.9. Release notes Sourced from https://github.com/google/gson/releases;>gson's releases. Gson

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request, #29: Update scala-logging to 3.9.5

scala-steward opened a new pull request, #29: URL: https://github.com/apache/incubator-nlpcraft/pull/29 Updates [com.typesafe.scala-logging:scala-logging](https://github.com/lightbend/scala-logging) from 3.9.4 to 3.9.5. [GitHub Release

[GitHub] [incubator-nlpcraft] scala-steward opened a new pull request, #26: Update jackson-annotations, jackson-core, ... to 2.13.3

scala-steward opened a new pull request, #26: URL: https://github.com/apache/incubator-nlpcraft/pull/26 Updates * com.fasterxml.jackson.core:jackson-annotations * com.fasterxml.jackson.core:jackson-core * com.fasterxml.jackson.core:jackson-databind from 2.13.2 to 2.13.3.

  1   2   >