Re: Review Request 56158: [OOZIE-2630] Amend patch for OOZIE-2630

> On Feb. 3, 2017, 12:33 a.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java, > > lines 406-429 > > <https://reviews.apache.org/r/56158/diff/3/?file=1621110#file1621110line406> > > > > This `static`

Re: Review Request 51029: OOZIE 2630 Oozie Coordinator EL Functions to get first day of the week/month

nsitionXCommand.java (line 746) <https://reviews.apache.org/r/51029/#comment234018> You perform too much testing in one single test method. I'd have as many methods as testing use cases with appropriate naming strategy like http://osherove.com/blog/2005/4/3/naming-standards-for-un

Re: Review Request 51029: OOZIE 2630 Oozie Coordinator EL Functions to get first day of the week/month

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51029/#review163188 --- Ship it! Ship It! - András Piros On Jan. 26, 2017, 10:27

Re: Review Request 51029: OOZIE 2630 Oozie Coordinator EL Functions to get first day of the week/month

> On Jan. 25, 2017, 2:14 a.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java, > > lines 572-586 > > <https://reviews.apache.org/r/51029/diff/3-4/?file=1612950#file1612950line572> > > > > F

Re: Review Request 51029: OOZIE 2630 Oozie Coordinator EL Functions to get first day of the week/month

ne(); ... expected.expect(MyOoziException.class); expected.expectMessage(myExceptionMessageString); performAndThrow(); ``` - András Piros On Jan. 24, 2017, 10:49 p.m., Satish Saley wrote: > > --- > Thi

Re: Review Request 55879: OOZIE-2777 Config-default.xml longer than 64k results in java.io.UTFDataFormatException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55879/#review162813 --- Ship it! Ship It! - András Piros On Jan. 24, 2017, 1:25 p.m

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

) - bin/test-patch-11-findbugs-diff PRE-CREATION bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION pom.xml a33d2c5 Diff: https://reviews.apache.org/r/52429/diff/ Testing --- Thanks, András Piros

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

PRE-CREATION pom.xml a33d2c5 Diff: https://reviews.apache.org/r/52429/diff/ Testing --- Thanks, András Piros

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52429/#review151797 ------- On Oct. 7, 2016, 10:39 a.m., András Piros wrote: > > --- > This i

Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

--- Thanks, András Piros

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

SLServerConnectorFactory.java (lines 143 - 146) <https://reviews.apache.org/r/52399/#comment219425> Extract method. server/src/test/java/org/apache/oozie/server/TestSSLServerConnectorFactory.java (lines 148 - 150) <https://reviews.apache.org/r/52399/#comment219428&g

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

(updated) - bin/test-patch-11-findbugs-diff PRE-CREATION bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION pom.xml 29184b2 Diff: https://reviews.apache.org/r/52429/diff/ Testing --- Thanks, András Piros

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review155413 --- Ship it! Ship It! - András Piros On Nov. 8, 2016, 10:50 p.m

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52737/#review152652 --- Ship it! Ship It! - András Piros On Oct. 14, 2016, 10:01

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

distro/src/main/bin/oozie-sys.sh (line 251) <https://reviews.apache.org/r/52399/#comment221902> I'd use `neq` here for `integer` comparison. distro/src/main/bin/oozie-tomcat-server.sh (line 58) <https://reviews.apache.org/r/52399/#comment221903> I'd use

Re: Review Request 52911: OOZIE-2685 OYA: Test new LauncherAM

/apache/oozie/action/hadoop/TestLauncherAM.java (line 475) <https://reviews.apache.org/r/52911/#comment221984> http://junit.sourceforge.net/javadoc/org/junit/Assert.html#assertNull(java.lang.String, java.lang.Object) - András Piros On Oct. 15, 2016, 7:16 p.m., P

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

is used in more than one places, e.g. `versions`, `v0` etc., can and should be put to constants. webapp/src/main/webapp/WEB-INF/web.xml (lines 218 - 221) <https://reviews.apache.org/r/52399/#comment223244> Dead code, pls. remove. - András Piros On Oct.

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

-0.1.0-all.jar.md5 PRE-CREATION bin/test-patch-11-findbugs-diff 0376ab0788644633982bfb099e740566b3b7118e bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 28179b6921d1b3ead4f87fca581b03bd62c0f013 Diff: https://reviews.apache.org/r/52429/diff/ Testing --- Thanks, András Piros

Re: Review Request 54060: Oozie to support Multiple HCatalog URIs

> On Nov. 25, 2016, 8:39 a.m., Peter Cseh wrote: > > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java, line 58 > > > > > > This change breaks backwards compatibility. Is it really needed? > > Abhishek

Re: Review Request 53229: OOZIE-2713 write out jar contents in launcher

s://reviews.apache.org/r/53229/#comment223542> Do we really need the stack trace, or only the `Exception.message`? - András Piros On Oct. 27, 2016, 2:50 p.m., Peter Cseh wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

/diff/ Testing --- Thanks, András Piros

Re: Review Request 52399: OOZIE-2666 Support embedding Jetty into Oozie

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52399/#review153860 --- Ship it! Ship It! - András Piros On Oct. 25, 2016, 3:42 p.m

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

-CREATION bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION pom.xml 83a1d42 Diff: https://reviews.apache.org/r/52429/diff/ Testing --- Thanks, András Piros

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

> > call cleanup_and_exit at the end in the report switch case Done. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52429/#review152302 ----

Re: Review Request 52782: OOZIE-2662 DB migration fails if DB is too big

Diff: https://reviews.apache.org/r/52782/diff/ Testing --- See `TestDBLoadDump` for further reference. Thanks, András Piros

Review Request 52782: OOZIE-2662 DB migration fails if DB is too big

`TestDBLoadDump` for further reference. Thanks, András Piros

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

-diff-0.1.0-all.jar.md5 PRE-CREATION pom.xml 83a1d42 Diff: https://reviews.apache.org/r/52429/diff/ Testing --- Thanks, András Piros

Re: Review Request 52737: OOZIE-2698 OYA: Refactor LauncherAM to make it more testable

n` a `String`? sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsHandler.java (lines 69 - 74) <https://reviews.apache.org/r/52737/#comment221323> `switch case default` would be nicer here. sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsHandler.java

Re: Review Request 52429: OOZIE-1986 Add FindBugs report to pre-commit build

(updated) - bin/test-patch-11-findbugs-diff PRE-CREATION bin/test-patch-11-findbugs-diff-0.1.0-all.jar.md5 PRE-CREATION pom.xml 83a1d42 Diff: https://reviews.apache.org/r/52429/diff/ Testing --- Thanks, András Piros

Re: Review Request 52911: OOZIE-2685 OYA: Test new LauncherAM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52911/#review152874 --- Ship it! Ship It! - András Piros On Oct. 17, 2016, 1:49 p.m

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

n't make any premature optimizations - modern JVMs like HotSpot will probably inline that method call anyway. - András Piros On Dec. 7, 2016, 4:19 a.m., Abhishek Bafna wrote: > > --- > This is an automatically generated e

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

(line 35) <https://reviews.apache.org/r/54383/#comment229690> Please see https://issues.apache.org/jira/secure/attachment/12842828/OOZIE-2751-03.patch for my refactoring thoughts. - András Piros On Dec. 7, 2016, 4:19 a.m., Abhishek Bafna

Re: Review Request 55404: OOZIE-2701: Oozie to support Multiple HCatalog URIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55404/#review161374 --- Ship it! Ship It! - András Piros On Jan. 12, 2017, 8:25 a.m

Re: Review Request 51459: Add an admin command to run the PurgeXCommand

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51459/#review161202 --- Ship it! Ship It! - András Piros On Dec. 19, 2016, 5:36 p.m

Re: Review Request 55404: OOZIE-2701: Oozie to support Multiple HCatalog URIs

ected = ExpectedException.none(); expected.expect(HCatAccessorException.class);` comes to the rescue. sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java (line 56) <https://reviews.apache.org/r/55404/#comment232448> `expected.expectMessage(...)`. Also please do use `Lo

Re: Review Request 53878: OOZIE-2681: fix javadoc to compile on JDK8 again

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53878/#review157595 --- Ship it! Ship It! - András Piros On Dec. 1, 2016, 3:43 p.m

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

g/r/54383/#comment228678> Would be better to extract to an Abstract Factory. core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java (line 49) <https://reviews.apache.org/r/54383/#comment228689> I like it :) - András Piros On Dec. 5, 2016, 5:05 p.m., Abhishek Ba

Re: Review Request 53878: OOZIE-2681: fix javadoc to compile on JDK8 again

mand/coord/CoordCommandUtils.java:183: warning - @param argument "endInst:" is not a parameter name. ``` Can you please address these as well? - András Piros On Nov. 18, 2016, 4:24 p.m., Abhishek Bafna wrote: > > --- > This is an a

Re: Review Request 53229: OOZIE-2713 write out jar contents in launcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53229/#review160702 --- Ship it! Ship It! - András Piros On Oct. 27, 2016, 2:50 p.m

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54383/#review160609 --- Ship it! Ship It! - András Piros On Jan. 5, 2017, 5:34 p.m

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

- 341) <https://reviews.apache.org/r/54383/#comment231715> Why not just call `throwNoOp()` and do not consider its return value? I think we don't need this method, as it is mainly a duplicate of `throwNoOp()`. - András Piros On Jan. 5, 2017, 5:26 a.m., Abhishek Bafna

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54383/#review159454 --- Ship it! Ship It! - András Piros On Dec. 16, 2016, 3:32 p.m

Re: Review Request 54383: LocalOozieClient is missing methods from OozieClient

> On March 24, 2017, 12:24 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java > > Lines 345 (patched) > > > > > > Please refactor these nested classes (make them non-nested).

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

> On March 23, 2017, 11:35 a.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > > Lines 102-105 (patched) > > <https://reviews.apache.org/r/57870/diff/1/?file=1672527#file1672527line102> > > &

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

Extract to separate test method. core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 275-298 (patched) <https://reviews.apache.org/r/57870/#comment242560> Extract to separate test method. core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java Lines 290-2

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/#review170695 --- Ship it! Ship It! - András Piros On March 28, 2017, 5:41

Re: Review Request 57680: OOZIE-2812 SparkConfigurationService should support loading configurations from multiple Spark versions

java Lines 173-175 (patched) <https://reviews.apache.org/r/57680/#comment241461> Maybe use the same Builder here, or `String.format()` w/ the same constant would be less copy-and-paste-error prone. - András Piros On March 16, 2017, 9:32 a.m., Peter Cseh wrote: > > --

Re: Review Request 58171: OOZIE-2844 Increase stability of Oozie actions when log4j.properties is missing or not readable

/java/org/apache/oozie/action/hadoop/SqoopMain.java cb8f56e9b66de0eb2799e68bc56d0ee36d4ba317 Diff: https://reviews.apache.org/r/58171/diff/2/ Changes: https://reviews.apache.org/r/58171/diff/1-2/ Testing --- Relevant unit tests run. Thanks, András Piros

Re: Review Request 58172: OOZIE-2843 Enhance logging inside ZKLocksService and MemoryLocksService

proving logging, I think it's worth to test exactly the logging behavior. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58172/#review171325 -

Re: Review Request 58172: OOZIE-2843 Enhance logging inside ZKLocksService and MemoryLocksService

/58172/diff/1-2/ Testing --- New unit test created, existing ones that matter remained running. Thanks, András Piros

Re: Review Request 57870: OOZIE-2827 More directly view of the coordinator’s history from perspective of workflow action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/#review171870 --- Ship it! Ship It! - András Piros On April 6, 2017, 2:34 p.m

Re: Review Request 58172: OOZIE-2843 Enhance logging inside ZKLocksService and MemoryLocksService

. Thanks, András Piros

Re: Review Request 57107: OOZIE-2815 oozie not always display job log

ursInSeconds` local variable would be more helpful. core/src/test/java/org/apache/oozie/util/TestLogStreamer.java Lines 347 (patched) <https://reviews.apache.org/r/57107/#comment240714> It would be useful to store here the original `XLogService.LOG4J_FILE` and then set it back in `tear

Re: Review Request 57546: OOZIE-2820: Fix typos throughout the codebase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57546/#review168764 --- Ship it! Ship It! - András Piros On March 13, 2017, 3:15

Re: Review Request 57107: OOZIE-2815 oozie not always display job log

> On March 9, 2017, 1:36 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/BaseEngine.java > > Line 192 (original), 197-203 (patched) > > <https://reviews.apache.org/r/57107/diff/1/?file=1659376#file1659376line202> > > > > Code duplic

Re: Review Request 61142: OOZIE-3009 Number of Oozie tests executed dropped

eviews.apache.org/r/61142/#review181794 --- On July 26, 2017, 5:28 p.m., András Piros wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61142/ > ---

Re: Review Request 61142: OOZIE-3009 Number of Oozie tests executed dropped

TestPersistenceExceptionSubclassFilterRetryPredicate TestParallelJPAOperationRetries TestWorkflow TestWorkflowRetries TestJPAService TestRetryAttemptState TestSLACalculatorMemory TestWorkflowJobsDeleteJPAExecutor TestPurgeService TestCoordJobsDeleteJPAExecutor TestBundleJobsDeleteJPAExecutor TestPurgeXCommand ``` Thanks, András Piros

Re: Review Request 61216: Fix of a possible NPE found by AppChecker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61216/#review182852 --- Ship it! Ship It! - András Piros On July 31, 2017, 7:57 a.m

Re: Review Request 52782: OOZIE-2662 DB migration fails if DB is too big

/valid/ooziedb_slareg.json PRE-CREATION tools/src/test/resources/dumpData/valid/ooziedb_slasum.json PRE-CREATION Diff: https://reviews.apache.org/r/52782/diff/6/ Changes: https://reviews.apache.org/r/52782/diff/5-6/ Testing --- See `TestDBLoadDump` for further reference. Thanks, András

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

DriverClassName=..."`, making it more clear. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60544/#review180082 ------- On July 6, 2017, 5:36 p.m., András Piros wrote: > > ---

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

times. Also firewall rules have been modified temporarily to simulate network outages. Thanks, András Piros

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

`extends com.mysql.jdbc.Driver`. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60544/#review180169 ------- O

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

s an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60544/#review180170 ------- On July 6, 2017, 5:36 p.m., András Piros wrote: > > --- > This is an au

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

enTriesOnce()` for details. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60544/#review180182 --- On July 1

Re: Review Request 60963: OOZIE-2984 Parse spark-defaults.conf values with spaces without needing the quotes

` * `TestSparkArgsExtractor` * `TestSparkMain` Thanks, András Piros

Re: Review Request 60963: OOZIE-2984 Parse spark-defaults.conf values with spaces without needing the quotes

: * `TestSparkOptionsSplitter` * `TestSparkArgsExtractor` * `TestSparkMain` Thanks, András Piros

Re: Review Request 60963: OOZIE-2984 Parse spark-defaults.conf values with spaces without needing the quotes

escription. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60963/#review181343 --- On July 25, 2017, 10:03 a.m., András Piro

Re: Review Request 60963: OOZIE-2984 Parse spark-defaults.conf values with spaces without needing the quotes

/60963/diff/5/ Changes: https://reviews.apache.org/r/60963/diff/4-5/ Testing --- Following tests are run: * `TestSparkOptionsSplitter` * `TestSparkArgsExtractor` * `TestSparkMain` Thanks, András Piros

Re: Review Request 60963: OOZIE-2984 Parse spark-defaults.conf values with spaces without needing the quotes

/60963/diff/4/ Changes: https://reviews.apache.org/r/60963/diff/3-4/ Testing --- Following tests are run: * `TestSparkOptionsSplitter` * `TestSparkArgsExtractor` * `TestSparkMain` Thanks, András Piros

Review Request 61142: OOZIE-3009 Number of Oozie tests executed dropped

TestWorkflowJobsDeleteJPAExecutor TestPurgeService TestCoordJobsDeleteJPAExecutor TestBundleJobsDeleteJPAExecutor TestPurgeXCommand ``` Thanks, András Piros

Review Request 60963: OOZIE-2984 Parse spark-defaults.conf values with spaces without needing the quotes

: https://reviews.apache.org/r/60963/diff/1/ Testing --- Following tests are run: * `TestSparkOptionsSplitter` * `TestSparkArgsExtractor` * `TestSparkMain` Thanks, András Piros

Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

to simulate network outages. Thanks, András Piros

Re: Review Request 52782: OOZIE-2662 DB migration fails if DB is too big

re always better than one ;) - András ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52782/#review179086 --- On June 27, 2017, 10:14 a.m., András Piros wrote: > > ---

Re: Review Request 52782: OOZIE-2662 DB migration fails if DB is too big

--- See `TestDBLoadDump` for further reference. Thanks, András Piros

Re: Review Request 52782: OOZIE-2662 DB migration fails if DB is too big

on` should not be open. Adding a check. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52782/#review179560 ------

Re: Review Request 52782: OOZIE-2662 DB migration fails if DB is too big

/diff/5/ Changes: https://reviews.apache.org/r/52782/diff/4-5/ Testing --- See `TestDBLoadDump` for further reference. Thanks, András Piros

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

ay end up adding more `Exception` subclasses for functional testing purposes, e.g. for another DB type. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60544/#r

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

,TestRetryAttemptCounter ``` Functional and stress tests performed on a 4-node MySQL cluster. MySQL daemon has been stopped / killed / restarted several times. Also firewall rules have been modified temporarily to simulate network outages. Thanks, András Piros

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

several times. Also firewall rules have been modified temporarily to simulate network outages. Thanks, András Piros

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

-node MySQL cluster. MySQL daemon has been stopped / killed / restarted several times. Also firewall rules have been modified temporarily to simulate network outages. Thanks, András Piros

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

have been modified temporarily to simulate network outages. Thanks, András Piros

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

temporarily to simulate network outages. Thanks, András Piros

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

led on a > > different thread. Instead modify a volatile boolean flag that something > > wasn't quite right. Using a `private volatile Exception` here. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

t.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) ``` - András

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

,TestRetryAttemptCounter ``` Functional and stress tests performed on a 4-node MySQL cluster. MySQL daemon has been stopped / killed / restarted several times. Also firewall rules have been modified temporarily to simulate network outages. Thanks, András Piros

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

Util(s)` and `Helper(s)` in variable or class names. - András --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60544/#review179575 ---------

Re: Review Request 60544: OOZIE-2854 Oozie should handle transient database problems

network outages. Thanks, András Piros

Review Request 61734: OOZIE-3035 HDFS HA and log aggregation: getting HDFS delegation token from YARN renewer within JavaActionExecutor

dc17950418ada9b4848ed5597702a29e7124ab38 core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java b507c79d44aa2095caf532a5f4d19d20c1a30630 Diff: https://reviews.apache.org/r/61734/diff/1/ Testing --- `TestJavaActionExecutor`, `TestHadoopAccessorService` Thanks, András Piros

Re: Review Request 59134: OOZIE-2854 Oozie should handle transient DB problems

ault.xml Lines 1567 (patched) <https://reviews.apache.org/r/59134/#comment247572> Would be better to name it `oozie.database.retry.initial-wait-time.ms` in order to express Unit of Measure. core/src/main/resources/oozie-default.xml Lines 1576 (patched) <https://revie

Re: Review Request 59906: Coordinator SLA should support to configure EL functions as variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59906/#review178358 --- Ship it! Ship It! - András Piros On June 20, 2017, 2:53 a.m

Re: Review Request 59906: Coordinator SLA should support to configure EL functions as variable

/CoordSubmitXCommand.java Line 870 (original), 870 (patched) <https://reviews.apache.org/r/59906/#comment252150> `LOG.warn("Variable is not defined in job.properties. Here is the message: {0}", e.getMessage());` - András Piros On June 19, 2017, 11:09 a.m

Review Request 59635: OOZIE-2923 Improve Spark options parsing

`, and `TestSparkArgsBuilder` for test cases. Thanks, András Piros

Re: Review Request 59620: This review board request is for an action to provide a Git action for Oozie

rg/apache/oozie/action/hadoop/TestIntegrationGitActionExecutor.java Lines 80 (patched) <https://reviews.apache.org/r/59620/#comment249699> Please cut this into independent test cases, and name these accordingly. sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestIntegrationGit

Re: Review Request 59635: OOZIE-2923 Improve Spark options parsing

/r/59635/diff/3/ Changes: https://reviews.apache.org/r/59635/diff/2-3/ Testing --- Please see the JUnit tests `TestSparkMain`, `TestSparkOptionsSplitter`, and `TestSparkArgsBuilder` for test cases. Thanks, András Piros

Re: Review Request 59635: OOZIE-2923 Improve Spark options parsing

Diff: https://reviews.apache.org/r/59635/diff/5/ Changes: https://reviews.apache.org/r/59635/diff/4-5/ Testing --- Please see the JUnit tests `TestSparkMain`, `TestSparkOptionsSplitter`, and `TestSparkArgsBuilder` for test cases. Thanks, András Piros

Re: Review Request 59635: OOZIE-2923 Improve Spark options parsing

/diff/3-4/ Testing --- Please see the JUnit tests `TestSparkMain`, `TestSparkOptionsSplitter`, and `TestSparkArgsBuilder` for test cases. Thanks, András Piros

Re: Review Request 59906: Coordinator SLA should support to configure EL functions as variable

> It would be nicer to have a separate test case just for testing the new behavior. - András Piros On June 8, 2017, 4:01 a.m., Wen Chi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 59906: Coordinator SLA should support to configure EL functions as variable

` Apart from that, instead of catching an `Exception`, please list all specific `Exception` types that can possibly occcur here. Code will be safer and much more readable. - András Piros On June 19, 2017, 7:11 a.m

Re: Review Request 59635: OOZIE-2923 Improve Spark options parsing

/ Changes: https://reviews.apache.org/r/59635/diff/1-2/ Testing --- Please see the JUnit tests `TestSparkMain`, `TestSparkOptionsSplitter`, and `TestSparkArgsBuilder` for test cases. Thanks, András Piros

Re: Review Request 52782: OOZIE-2662 DB migration fails if DB is too big

: https://reviews.apache.org/r/52782/diff/2-3/ Testing --- See `TestDBLoadDump` for further reference. Thanks, András Piros

  1   2   3   4   >