[jira] [Commented] (PHOENIX-4658) IllegalStateException: requestSeek cannot be called on ReversedKeyValueHeap

[ https://issues.apache.org/jira/browse/PHOENIX-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422606#comment-16422606 ] Toshihiro Suzuki commented on PHOENIX-4658: --- According to stack's comment in HBASE-20219, it

[jira] [Commented] (PHOENIX-4669) NoSuchColumnFamilyException when creating index on views that are built on tables which have named column family

[ https://issues.apache.org/jira/browse/PHOENIX-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422614#comment-16422614 ] Toshihiro Suzuki commented on PHOENIX-4669: --- [~sergey.soldatov] Could you please review the v2

[jira] [Commented] (PHOENIX-2715) Query Log

[ https://issues.apache.org/jira/browse/PHOENIX-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422079#comment-16422079 ] Ankit Singhal commented on PHOENIX-2715: bq. Wondering if we want this to be INFO, or even OFF,

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422902#comment-16422902 ] Andrew Purtell commented on PHOENIX-4682: - So +1 > UngroupedAggregateRegionObserver

[jira] [Comment Edited] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422899#comment-16422899 ] Andrew Purtell edited comment on PHOENIX-4682 at 4/2/18 6:35 PM: - The

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422940#comment-16422940 ] Andrew Purtell commented on PHOENIX-4682: - {quote}can that be extracted from the

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422752#comment-16422752 ] Andrew Purtell commented on PHOENIX-4682: - Patch basically lgtm. Definitely good if Phoenix can

[jira] [Commented] (PHOENIX-4658) IllegalStateException: requestSeek cannot be called on ReversedKeyValueHeap

[ https://issues.apache.org/jira/browse/PHOENIX-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422785#comment-16422785 ] James Taylor commented on PHOENIX-4658: --- Thanks for following up on this, [~brfrn169]. With or

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422935#comment-16422935 ] Vincent Poon commented on PHOENIX-4682: --- [~gjacoby] As I said, in the patch the testcase compacts

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422899#comment-16422899 ] Andrew Purtell commented on PHOENIX-4682: - It would be better to disable the index than throw an

[jira] [Comment Edited] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422899#comment-16422899 ] Andrew Purtell edited comment on PHOENIX-4682 at 4/2/18 6:32 PM: - The

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422881#comment-16422881 ] Vincent Poon commented on PHOENIX-4682: --- Thanks for the reviews.  [~apurtell] There are two

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422919#comment-16422919 ] Geoffrey Jacoby commented on PHOENIX-4682: -- [~vincentpoon] - the issue's not whether your logic

[jira] [Created] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

Vincent Poon created PHOENIX-4683: - Summary: Cap timeouts for stats precompact hook logic Key: PHOENIX-4683 URL: https://issues.apache.org/jira/browse/PHOENIX-4683 Project: Phoenix Issue

[jira] [Assigned] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon reassigned PHOENIX-4683: - Assignee: Vincent Poon > Cap timeouts for stats precompact hook logic >

[jira] [Updated] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4682: -- Attachment: PHOENIX-4682.v2.0.98.patch > UngroupedAggregateRegionObserver

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423133#comment-16423133 ] Vincent Poon commented on PHOENIX-4683: --- [~gjacoby] [~aertoria] mind doing a quick review? > Cap

[jira] [Updated] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4683: -- Attachment: PHOENIX-4683.v1.0.98.patch > Cap timeouts for stats precompact hook logic >

[jira] [Commented] (PHOENIX-4684) Creation of SYSTEM tables should not depend on client-side properties

[ https://issues.apache.org/jira/browse/PHOENIX-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423147#comment-16423147 ] Chinmay Kulkarni commented on PHOENIX-4684: --- [~jamestaylor] [~aertoria] [~apurtell] any

[jira] [Commented] (PHOENIX-2715) Query Log

[ https://issues.apache.org/jira/browse/PHOENIX-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423121#comment-16423121 ] Andrew Purtell commented on PHOENIX-2715: - Since my query is being ignored, I am -1 on this

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423096#comment-16423096 ] James Taylor commented on PHOENIX-4682: --- Thanks, [~vincentpoon]. Patch looks good, but a couple of

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423112#comment-16423112 ] Vincent Poon commented on PHOENIX-4682: --- [~jamestaylor] thanks for the review.  I only ignore

[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

[ https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423069#comment-16423069 ] Vincent Poon commented on PHOENIX-4682: --- v2 patch which also: * changes preCompact() to catch all

[jira] [Created] (PHOENIX-4684) Creation of SYSTEM tables should not depend on client-side properties

Chinmay Kulkarni created PHOENIX-4684: - Summary: Creation of SYSTEM tables should not depend on client-side properties Key: PHOENIX-4684 URL: https://issues.apache.org/jira/browse/PHOENIX-4684

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423293#comment-16423293 ] James Taylor commented on PHOENIX-4683: --- LGTM, but any reason not to create just one

[jira] [Commented] (PHOENIX-4684) Creation of SYSTEM tables should not depend on client-side properties

[ https://issues.apache.org/jira/browse/PHOENIX-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423262#comment-16423262 ] James Taylor commented on PHOENIX-4684: --- Seems there's a bootstrapping problem, as the client

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423285#comment-16423285 ] James Taylor commented on PHOENIX-4683: --- +1 > Cap timeouts for stats precompact hook logic >

[jira] [Updated] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4683: -- Attachment: PHOENIX-4683.v2.0.98.patch > Cap timeouts for stats precompact hook logic >

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423296#comment-16423296 ] James Taylor commented on PHOENIX-4683: --- +1 > Cap timeouts for stats precompact hook logic >

[GitHub] phoenix issue #295: PHOENIX-4579: Add a config to conditionally create Phoen...

Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/295 @aertoria ping. Also, @JamesRTaylor please take a look. I've added an IT to test various cases encountered for system table creation/upgrade. Also filed

[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column

[ https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423194#comment-16423194 ] Chinmay Kulkarni commented on PHOENIX-4668: --- [~aertoria] Please take a look and merge if it

[jira] [Updated] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4683: -- Attachment: PHOENIX-4683.v3.0.98.patch > Cap timeouts for stats precompact hook logic >

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423294#comment-16423294 ] Vincent Poon commented on PHOENIX-4683: --- Thanks :) > Cap timeouts for stats precompact hook logic

[jira] [Comment Edited] (PHOENIX-4616) Move join query optimization out from QueryCompiler into QueryOptimizer

[ https://issues.apache.org/jira/browse/PHOENIX-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423319#comment-16423319 ] James Taylor edited comment on PHOENIX-4616 at 4/3/18 12:31 AM: Is the

[jira] [Commented] (PHOENIX-4616) Move join query optimization out from QueryCompiler into QueryOptimizer

[ https://issues.apache.org/jira/browse/PHOENIX-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423319#comment-16423319 ] James Taylor commented on PHOENIX-4616: --- Is the derived-table the only exception and if so can we

[jira] [Commented] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection

[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423191#comment-16423191 ] ASF GitHub Bot commented on PHOENIX-4579: - Github user ChinmaySKulkarni commented on the issue:

[jira] [Commented] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423306#comment-16423306 ] Vincent Poon commented on PHOENIX-4683: --- [~jamestaylor] when testing this, I'm still seeing a long

[jira] [Commented] (PHOENIX-4658) IllegalStateException: requestSeek cannot be called on ReversedKeyValueHeap

[ https://issues.apache.org/jira/browse/PHOENIX-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423350#comment-16423350 ] Toshihiro Suzuki commented on PHOENIX-4658: --- Thank you for your comment [~jamestaylor]. I

[jira] [Updated] (PHOENIX-4683) Cap timeouts for stats precompact hook logic

[ https://issues.apache.org/jira/browse/PHOENIX-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4683: -- Attachment: PHOENIX-4683.v4.0.98.patch > Cap timeouts for stats precompact hook logic >

[jira] [Commented] (PHOENIX-2715) Query Log

[ https://issues.apache.org/jira/browse/PHOENIX-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423434#comment-16423434 ] Andrew Purtell commented on PHOENIX-2715: - When I said separate log line I meant separate log

[jira] [Commented] (PHOENIX-2715) Query Log

[ https://issues.apache.org/jira/browse/PHOENIX-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423433#comment-16423433 ] Andrew Purtell commented on PHOENIX-2715: - Thank you. My mistake for not seeing the earlier