Re: "Could not resolve external workbook name" after setupReferencedWorkbooks

2018-09-27 Thread Greg Woolsey
I recently got this working, but noticed these points of fragility in doing so with the current released code: 1. If the file names had spaces in them, I had to replace them with "%20" in the map keys passed to setupReferencedWorkbooks(), as that's the value used in the stored formula expressions

Re: svn commit: r1844311 - /poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFFormulaEvaluator.java

2018-10-19 Thread Greg Woolsey
Thanks for fixing that before I got back online. Not sure how I didn't run those tests locally. On Fri, Oct 19, 2018 at 12:43 AM wrote: > Author: fanningpj > Date: Fri Oct 19 07:43:04 2018 > New Revision: 1844311 > > URL: http://svn.apache.org/viewvc?rev=1844311&view=rev > Log: > fix class cast

Re: POI 4.0.1 release

2018-10-30 Thread Greg Woolsey
+1 for next weekend/week as well. Liking the current state of things after the initial 4.0.0 public feedback. On Tue, Oct 30, 2018 at 8:31 AM Alain FAGOT BÉAREZ wrote: > +1 to release 4.0.1 > > The blocking issues related to charts in XDDF are now fixed. Related > Bugzilla issue has also been r

Re: Usage of XmlBeans triggers "clearThreadLocalMap" warnings in Tomcat with XSSF

2018-11-03 Thread Greg Woolsey
+1 for more information, like container type and version, platform, jre, etc. I've been using poi in a tomcat deployed webapp for nearly 15 years and never seen this. On Sat, Nov 3, 2018, 14:10 Dominik Stadler There are many places in XmlBeans where ThreadLocal is used and as far as I > could se

Re: [Bug 62969] HYPERLINK() function needs a way to return link reference when display label is also specified

2018-12-02 Thread Greg Woolsey
That replacement method is no longer available, and the maps appear to be static, so making a change would affect all threads, so I don't like that option. Perhaps a separate override map local to an evaluator instance would be a possibility, but then it would need to be available in the proper fu

Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Greg Woolsey
Good thoughts - I'm glad you are on board and thinking about the hard-to-track-down issues when implementations of interfaces differ in their behavior. I've not used the different hierarchies much, sticking mostly to XSSF, but I can see how this could lead to tricky bugs. I'm personally partial t

Re: Proposal: make HSSF/XSSF/SXSSF behavior consistent

2019-01-04 Thread Greg Woolsey
I like this, but wonder about the change to throwing runtime exceptions (IllegalArgumentException specifically) in new cases, especially where we are deprecating a given _input_ but not an entire function, like setCellFormula(null). That seems like it will break a lot of downstream code, and cause

Re: Poi thread running since a long time

2019-02-25 Thread Greg Woolsey
Which version of POI are you using? That line # is not in that method in the latest version. Many performance and bug fixes have gone into releases over the last couple years. If you have a file we can examine/test, or even better a unit test that shows the issue against the latest release, that

Unit Test failure

2019-03-16 Thread Greg Woolsey
Job POI-DSL-OpenJDK fails, since before my recent change, apparently, with this stack. It passes for me locally, and the other build flavors pass. Anyone know what's going on with this one? javax.imageio.IIOException: Invalid argument to native writeImage at com.sun.imageio.plugins.jpeg.JPEGImag

Re: Next release of POI/XmlBeans?

2019-03-17 Thread Greg Woolsey
I don't notice XMLBeans except when it breaks, and it hasn't been for me, so I'm happy with that. I'd love a new release soon with the change I just made, that would help a lot with some significant changes I'm submitting to the Vaadin UI component that uses POI. And it was my math error in the f

Re: Next release of POI/XmlBeans?

2019-03-19 Thread Greg Woolsey
uot; quotient :) Greg On Mon, Mar 18, 2019 at 12:47 PM Andreas Beeker wrote: > > On 18.03.19 06:11, Greg Woolsey wrote: > > I've not done a release yet, but I'd be willing to read the docs and > > take a stab at it if no one else has time. > > Regarding POI: >

Fwd: svn commit: r1855878 - /poi/site/src/documentation/content/xdocs/changes.xml

2019-03-19 Thread Greg Woolsey
I took a stab at release summary bullets. Feedback welcome, if I missed something or mischaracterized changes. Also realized I'd added some bugs to the list at the top instead of bottom, so I moved them. -- Forwarded message - From: Date: Tue, Mar 19, 2019 at 8:35 PM Subject: sv

Re: Next release of POI/XmlBeans?

2019-03-20 Thread Greg Woolsey
When was the previous regression run? Some of the formula errors mention invalid sheet names, including empty strings. The fix for #60460 committed Dec. 30 handled null sheet names in SheetNameEvaluator, but perhaps that change should also check and handle empty strings? I've never actually touc

XML Beans 3.0.3 candidate build

2019-03-20 Thread Greg Woolsey
I have pushed xmlbeans 3.0.3 release candidate to: https://repository.apache.org/content/repositories/staging/org/apache/xmlbeans/xmlbeans/3.0.3/ https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src If those look good to folks, what do I

Re: XML Beans 3.0.3 candidate build

2019-03-21 Thread Greg Woolsey
... most of it will be > on-purpose, but we should check, I don't know XMLBeans well enough to be > sure > * We should exclude file "build.javacheck.xml" in the packaging, it is used > by CI jobs, but not useful to include > > > Dominik. > > On Thu, Mar 21,

Re: XML Beans 3.0.3 candidate build

2019-03-21 Thread Greg Woolsey
ree, so I don't know where that comes from or why it was included. On Thu, Mar 21, 2019 at 8:25 AM Greg Woolsey wrote: > Removed 3.0.2 artifacts from the dist/dev tree. > > I pulled the zips from the Jenkins build artifacts, and then repackaged > them to *.tgz as well. The buil

Re: XML Beans 3.0.3 candidate build

2019-03-21 Thread Greg Woolsey
important pieces are missing. > > Finally should we use a different version number, e.g. 3.1.0 to indicate > that some more changes in functionality did occur, 3.0.3 would suggest > "drop in replacement", which will not guarantee here? > > Thanks... Dominik. > >

Re: XML Beans 3.0.3 candidate build

2019-03-21 Thread Greg Woolsey
in the src zip 2. bump the version to 3.1.0 and mention the packaging changes in the changelog 3. fix the README version # Then I would do a 3.1.0 XMLBeans build and deploy to staging. How does that sound to folks? On Thu, Mar 21, 2019 at 10:28 AM Greg Woolsey wrote: > I'm OK with chan

Re: XML Beans 3.0.3 candidate build

2019-03-22 Thread Greg Woolsey
sed for, though > > * in the bin-tgz, the README is not updated, it actually still states > > 2.5.0, so it was not updated in a long time > > * The content of the src-tgz/zip is fairly different, libs are moved > > around, the folder "bin" with scripts is missing, .

Re: XML Beans 3.0.3 candidate build

2019-03-22 Thread Greg Woolsey
directory when building, and include it mapped to /bin, like the xmlbeans-bin zip file. Thoughts? I lean toward moving it to /bin in the src zip, to match the bin zip. I'll work on that unless someone has a reason not to. On Thu, Mar 21, 2019 at 10:51 AM Greg Woolsey wrote: > I hard

XMLBeans 3.1.0 candidate build

2019-03-22 Thread Greg Woolsey
I have pushed xmlbeans 3.1.0 release candidate to: https://repository.apache.org/content/repositories/staging/org/apache/xmlbeans/xmlbeans/3.1.0/ https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src This has discussed version # changes,

[VOTE] XMLBeans 3.1.0 release

2019-03-23 Thread Greg Woolsey
Release artifacts: https://repository.apache.org/content/repositories/staging/org/apache/xmlbeans/xmlbeans/3.1.0/ https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src The vote will remain open for 3 days. See the CHANGES.txt file for re

Re: XMLBeans 3.1.0 candidate build

2019-03-26 Thread Greg Woolsey
> > > > It's ok, but not nice to have the bin directory in the src dist > duplicated in (/bin, /src/shell) - we can change that on the next release. > I still think it's better to have the shell scripts not under /bin in the > source tree. > > +1 > I agree, I didn't like it in /bin, but that's whe

Re: [VOTE] XMLBeans 3.1.0 release

2019-03-26 Thread Greg Woolsey
details are in the other thread. > > > On 23.03.19 15:17, Greg Woolsey wrote: > > Release artifacts: > > > > > https://repository.apache.org/content/repositories/staging/org/apache/xmlbeans/xmlbeans/3.1.0/ > > > > https://dist.apache.org/repos/dist/dev/poi

[ANNOUNCE] Apache XMLBeans 3.1.0 released

2019-03-30 Thread Greg Woolsey
this release possible. On behalf of the Apache POI PMC, Greg Woolsey [1] Release notes: https://www.apache.org/dyn/closer.lua/poi/xmlbeans/release/dev/RELEASE-NOTES-3.1.0.txt [2] Changelog: https://xmlbeans.apache.org/status.html#rel_310

Ready for 4.1.0 release?

2019-03-30 Thread Greg Woolsey
Anyone have anything else they want in before I start the build and release process? I just cleaned up the recent issues that mattered to me around formula evaluation and data formatting. Turns out they were somewhat related in code, but unrelated in discovery.

Fwd: Build failed in Jenkins: POI-DSL-1.13 #12

2019-03-30 Thread Greg Woolsey
The failing test is new - it's a stack trace that also showed up new in the regression test run. I was going to put off looking into it, but I guess I'll do that now. Not sure what changed that it started showing up in unit tests, as it isn't related to today's changes. -- Forwarded mess

Fwd: svn commit: r1856655 - in /poi/trunk/src: java/org/apache/poi/ss/formula/SheetNameFormatter.java testcases/org/apache/poi/hssf/usermodel/TestHSSFEvaluationSheet.java

2019-03-30 Thread Greg Woolsey
I handled this similarly to other code that converted missing external sheet info to empty String values, but if someone thinks this should still throw an exception, I'm open to discussing a new "MissingExternalReference" checked exception or something like that. Appears Excel does this to avoid e

Re: Ready for 4.1.0 release?

2019-03-30 Thread Greg Woolsey
wrote: > Would it be possible to also include > https://bz.apache.org/bugzilla/show_bug.cgi?id=61700? I can also provide > a pull request if that is prefered over the patch. > > Best Regards > > Kai Grabfelder > Greg Woolsey schrieb am 30.03.19 um 21:16: > > Anyone have

Re: Ready for 4.1.0 release?

2019-04-01 Thread Greg Woolsey
Dominik, is it worth running the regression corpus again, to verify how many of the new errors are cleaned up? On Sat, Mar 30, 2019 at 9:38 PM Greg Woolsey wrote: > Build working again. Latest fix should also remove most of the > differences in the regression run seen last week. I&#

Re: Ready for 4.1.0 release?

2019-04-03 Thread Greg Woolsey
As the Vaadin developers are waiting for 4.1.0, and no one has responded with additional work worth waiting for or fixes needed, I'll start the release prep Thursday. Best not to do it while I'm offline over the Atlantic today. On Tue, Apr 2, 2019 at 12:15 AM Greg Woolsey wrote: >

Re: Ready for 4.1.0 release?

2019-04-04 Thread Greg Woolsey
8 AM Dominik Stadler wrote: > Sorry for the late reply, I will try to start another run toda, but you > don't to delay release work because of it. > > Dominik > > On Tue, Apr 2, 2019, 00:15 Greg Woolsey wrote: > > > Dominik, is it worth running the regression corpus

Re: Ready for 4.1.0 release?

2019-04-04 Thread Greg Woolsey
nd we find such issues earlier. > > Dominik. > > On Thu, Apr 4, 2019 at 6:49 PM Greg Woolsey > wrote: > > > I get "Access Denied" when I try to run release-prep1 when it tries to > > retrieve this file: > > > > Can't get > > > > &

Fwd: Returned post for annou...@apache.org

2019-04-04 Thread Greg Woolsey
e message or contact a list moderator directly. --- Enclosed, please find the message you sent. -- Forwarded message ------ From: Greg Woolsey To: POI Users List , POI Developers List < dev@poi.apache.org>, gene...@poi.apache.org, annou...@apache.org Cc: Bcc: Date: Sat,

Re: Returned post for annou...@apache.org

2019-04-04 Thread Greg Woolsey
n Thu, Apr 4, 2019 at 6:32 PM Dave Fisher wrote: > You don’t have links to the download or download page. Take a look at > previous announcements. > > Sent from my iPhone > > > On Apr 4, 2019, at 6:09 PM, Greg Woolsey wrote: > > > > Anyone see anything wrong wi

[ANNOUNCE] Apache XMLBeans 3.1.0 released

2019-04-04 Thread Greg Woolsey
The Apache POI project is pleased to announce the release of Apache XMLBeans 3.1.0. This is the 4th release since the POI team took over the ownership of XMLBeans. Featured are a handful of memory, stability, coverage, and security fixes. The release package organization has also been updated to a

Re: Ready for 4.1.0 release?

2019-04-04 Thread Greg Woolsey
cher.java:287) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113) On Thu, Apr 4, 2019 at 11:02 AM Greg Woolsey wrote: > Changed the build.xml URL. > > On Thu, Apr 4, 2019 at 10:56 AM Dominik Stadler > wrote: > >> Try using https://nexus.pentaho.org/, seems the repository moved some >

Re: Ready for 4.1.0 release?

2019-04-05 Thread Greg Woolsey
Ignore the RC2, I will be doing an RC3 after some meetings. Discovered my FORREST_HOME was in Cygwin/Linux path format, which broke documentation creation, meaning the RC2 artifacts are missing site and other documentation folders/files. Turns out the XMLBeans build needs the Cygwin format, but P

[VOTE] Apache POI 4.1.0 release (RC3)

2019-04-05 Thread Greg Woolsey
I've prepared artifacts for Apache POI release 4.1.0 (RC3). Notable changes since 4.0.1: * Improved support/fixes for Java 9+ and IBM JVM * New EMF renderer and support of SVG images in XSLF * Security, stability and memory/resource handling improvements * Various bug fixes across function and co

Re: [VOTE] Apache POI 4.1.0 release (RC3)

2019-04-08 Thread Greg Woolsey
emf.HemfRecord > oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord > > oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture > > On Sun, Apr 7, 2019 at 8:27 AM Yegor Kozlov wrote: > > > > +1 > > > > Looks good to me > > > > сб, 6 а

Re: [VOTE] Apache POI 4.1.0 release (RC3)

2019-04-08 Thread Greg Woolsey
Vote passes with 5 +1 and 1 +0 votes. I'll begin the release process. Thank you all for your help, checks, and discussion. Greg On Mon, Apr 8, 2019 at 2:12 PM Tim Allison wrote: > Hi Andi, > > Y, to be clear, I really like what you’ve done and it is all a bunch > cleaner than my earlier stuff

New JavaDoc folder for 4.1.x?

2019-04-09 Thread Greg Woolsey
Per the release-guide.txt and what I see on the site currently, I think I need to build javadoc and move it to a new folder, plus updating links in the apidocs/index.xml file. That's what I'm working on today, unless anyone has a strong opinion otherwise.

[ANNOUNCE] Apache POI 4.1.0 released

2019-04-09 Thread Greg Woolsey
The Apache POI project is pleased to announce the release of POI 4.1.0. Featured are a handful of new areas of functionality, and numerous bug fixes. See the downloads page for binary and source distributions: https://poi.apache.org/download.html Release Notes Changes The most notab

[ANNOUNCE] Apache POI 4.1.0 released

2019-04-10 Thread Greg Woolsey
The Apache POI project is pleased to announce the release of POI 4.1.0. Featured are a handful of new areas of functionality, and numerous bug fixes. See the downloads page for binary and source distributions: https://poi.apache.org/download.html Release Notes Changes The most notab

[ANNOUNCE] Apache POI 4.1.0 released

2019-04-10 Thread Greg Woolsey
The Apache POI project is pleased to announce the release of POI 4.1.0. Featured are a handful of new areas of functionality, and numerous bug fixes. See the downloads page for binary and source distributions: https://poi.apache.org/download.html Release Notes Changes The most notab

Re: Evaluating expressions outside a cell value context

2017-02-13 Thread Greg Woolsey
which will add the corresponding note to the JavaDocs. On Feb 12, 2017 17:08, "Greg Woolsey" wrote: > Thanks for taking the time to inspect it, and point me to the utilities, I > hadn't found them yet. I'll incorporate them and run all the tests > including my new o

Re: Build failed in Jenkins: POI-DSL-Maven #105

2017-02-14 Thread Greg Woolsey
Fixed with commit r1783022. Eclipse and I didn't notice that even though compliance level was 1.6, there was no 1.6 JRE, and a 1.7 method was being called. Everything compiled, ran, tested, and built successfully. Strange. On Tue, Feb 14, 2017 at 2:04 PM Apache Jenkins Server < jenk...@builds.apac

Re: Build failed in Jenkins: POI-DSL-1.6 #172

2017-02-14 Thread Greg Woolsey
This time it finally wasn't me! I think I fixed both the Ant version issue and the Java 6 compile issues. This test run failed with: java.lang.OutOfMemoryError: unable to create new native thread Similarly, running tests locally failed at a different point with an OOM. Is this a known transient

Re: GSOC mentee

2017-03-02 Thread Greg Woolsey
I'd like to be in the loop too, if anything gets moving, as I have some chart support requirements and ideas I've been considering, and would like to ensure easy integration with the Vaadin Spreadsheet product. On Thu, Mar 2, 2017 at 10:11 AM Javen O'Neal wrote: > Excel Chart support is certainl

Re: Getting and setting cell value

2017-03-10 Thread Greg Woolsey
I especially would like the setter, to avoid annoying code, and the getter would be nice in many cases where the value type doesn't matter or is better handled further downstream. On Fri, Mar 10, 2017, 19:04 Javen O'Neal wrote: > Would it be a good idea to add the following two methods to the ce

Re: bean-free ooxml streaming readers?

2017-04-10 Thread Greg Woolsey
Late to the party as I sift through my Spring Break email backlog. Since it would be read-only, would it just be another option, instead of a full replacement? Would the data model need to be more fully fleshed out to support all the corners of the OOXML spec not currently represented? Is there

Re: [VOTE] Apache POI 3.16-final release (RC1)

2017-04-12 Thread Greg Woolsey
+1 works-for-me (and current Vaadin Spreadsheet) On Wed, Apr 12, 2017 at 1:58 PM Dominik Stadler wrote: > +1 > > Compared the package-content against 3.15 and verified that some projects > that are using POI still work fine. > > Dominik. > > On Wed, Apr 12, 2017 at 7:08 PM, Allison, Timothy B.

Re: [Bug 61033] [PATCH] Add Workbook.setCellFormulaValidation to control whether formulas are validated during Cell.setCellFormula or not

2017-04-25 Thread Greg Woolsey
Test the positive case too, true + invalid formula allowed, test that the default is true, test that flipping it from false to true with an invalid formula in place, resulting in an invalid workbook, is somehow handled so users don't get odd errors later. Maybe validate all formulas then? That wou

Re: Need help in reading large XLSX file using poi 3.16

2017-05-02 Thread Greg Woolsey
What are your jvm parameters? For large workbooks you really need to set -Xmx2g or more. I've gone as high as 16g. If you can break up the data into multiple sheets that helps too. On Tue, May 2, 2017, 01:35 Mubasshar Ahmad wrote: > Hello, > > > I spent a lot of time on searching the solution

Re: svn commit: r1795002 [3/3] - in /poi/trunk: ./ src/java/org/apache/poi/ss/usermodel/ src/ooxml/java/org/apache/poi/xssf/model/ src/ooxml/java/org/apache/poi/xssf/usermodel/ src/ooxml/testcases/org

2017-05-12 Thread Greg Woolsey
Argh, fat fingered it before I could type my comment. This is initial read-only API support for Table Styles, including the specification defined built-in table and pivot table styles, issue #61085. This includes some new SS interfaces, including one to start to bridge common functionality betwee

Re: svn commit: r1795002 [3/3] - in /poi/trunk: ./ src/java/org/apache/poi/ss/usermodel/ src/ooxml/java/org/apache/poi/xssf/model/ src/ooxml/java/org/apache/poi/xssf/usermodel/ src/ooxml/testcases/org

2017-05-12 Thread Greg Woolsey
streaming the XML or even text and checking for style boundaries, but I went with faster and easier to start with. Greg On Fri, May 12, 2017 at 12:12 PM Nick Burch wrote: > On Fri, 12 May 2017, Greg Woolsey wrote: > > Argh, fat fingered it before I could type my comment. > >

Re: svn commit: r1795122 - /poi/trunk/test-data/spreadsheet/~$tableStyle.xlsx

2017-05-14 Thread Greg Woolsey
Thanks for noticing that I totally missed that I checked in the temp file. Perhaps the ignore list needs this as a pattern to avoid it happening again. On Sun, May 14, 2017, 15:24 wrote: > Author: kiwiwings > Date: Sun May 14 22:24:07 2017 > New Revision: 1795122 > > URL: http://svn.apache.org/v

Re: Build failed in Jenkins: POI-DSL-1.6 #312

2017-05-26 Thread Greg Woolsey
Hmm. This test passes for me. Thoughts? On Fri, May 26, 2017 at 4:44 PM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/POI-DSL-1.6/312/display/redirect?page=changes > > > > Changes: > > [gwoolsey] Bug 60898 - XSSFColor's getARGB() method return

Re: XSSF tables - anyone know much about them?

2017-06-08 Thread Greg Woolsey
I'm using XSSF tables all the time, but for reading and updating, not writing. I'll take a look tomorrow at your stuff (meetings all day today). I've recently added support to read table formatting without needing direct access to the CT classes, for example. On Thu, Jun 8, 2017 at 9:21 AM Nick

Excel formula saving oddity

2017-06-08 Thread Greg Woolsey
I ran across this from a user file today, and hadn't seen it before. Chart series definitions default to just cell address ranges, but can be set to named ranges instead with some clicking and typing in the UI, which makes charts more dynamic. However, for unknown reasons not documented in Excel

Re: XSSF tables - anyone know much about them?

2017-06-09 Thread Greg Woolsey
text representation of table headers. On Thu, Jun 8, 2017 at 9:46 AM Greg Woolsey wrote: > I'm using XSSF tables all the time, but for reading and updating, not > writing. I'll take a look tomorrow at your stuff (meetings all day > today). I've recently added support to read table

Re: Excel formula saving oddity

2017-06-09 Thread Greg Woolsey
workbook reference formatted named ranges properly. I don't see anything I need to add/change in POI at this point. On Fri, Jun 9, 2017 at 2:21 AM Nick Burch wrote: > On Fri, 9 Jun 2017, Greg Woolsey wrote: > > However, for unknown reasons not documented in Excel help as far as I can >

DataTables and formula evaluation

2017-06-09 Thread Greg Woolsey
POI doesn't currently support "data table" formulas (a variation on array formulas). However, the implementation of XSSFCell.isFormulaCell() still thinks the "master" cell for a data table is a formula type cell. But the formula is not a stored one, but implied by the definition of a data table a

Re: DataTables and formula evaluation

2017-06-09 Thread Greg Woolsey
ell assume they're working with a cell > containing a regular formula, not a cell that belongs to an array formula > or table. > I'd say it's fair to document this distinction in the JavaDoc and provide a > isArrayFormulaCell and isTableFormulaCell if those concepts are usef

Re: DataTables and formula evaluation

2017-06-09 Thread Greg Woolsey
Also, isFormulaCell() is private. the JavaDoc will go on getCellType(). On Fri, Jun 9, 2017 at 5:45 PM Greg Woolsey wrote: > If we want additional methods, the JavaDoc needs to also note that only > the top left cell has this property, the rest appear as normal cells with > norm

Re: Extracting images from pptx using xslf discarding charts.

2017-06-16 Thread Greg Woolsey
Charts are stored as a definition, not an image, and poi doesn't currently have support for rendering them. On Fri, Jun 16, 2017, 05:10 Anil pawar wrote: > I am using xslf to convert pptx to images but unable to convert slides > which contain charts. > After conversion i can see taht all charts

Re: Extracting images from pptx using xslf discarding charts.

2017-06-16 Thread Greg Woolsey
un 16, 2017 at 7:12 AM Anil pawar wrote: > > > On 2017-06-16 21:48 (+0530), Greg Woolsey wrote: > > Charts are stored as a definition, not an image, and poi doesn't > currently > > have support for rendering them. > > > > On Fri, Jun 16, 2017, 05:10 A

Re: Developing POI with an IDE

2017-06-20 Thread Greg Woolsey
MyEclipse here, because it's familiar, cheap, and simpler to install than stock Eclipse. Haven't bothered learning Gradle yet but it's on my list eventually. Notably I can't run all the unit tests directly from Eclipse, I have to use the Ant tasks. Haven't uncovered why yet. On Tue, Jun 20, 201

Re: Is it time for POI 3.17-beta1?

2017-06-20 Thread Greg Woolsey
+1 from me. Nothing pending atm, table/workbook style/theme changes in and tested. On Tue, Jun 20, 2017 at 12:23 PM Allison, Timothy B. wrote: > +1 -- my few small changes are in. I'll kick off my regression tests > tonight or tomorrow. > > -Original Message- > From: Dominik Stadler [m

Re: Is it time for POI 3.17-beta1?

2017-06-23 Thread Greg Woolsey
I'll take a look at that exception, I touched XSSFTableStyle. On Fri, Jun 23, 2017, 09:14 Allison, Timothy B. wrote: > My run just finished as well. > > http://162.242.228.174/reports/reports_poi-3.17-beta1.zip > > +1 to roll > > I get only one new exception (below) in an xlsx file (there are 7

Re: Is it time for POI 3.17-beta1?

2017-06-23 Thread Greg Woolsey
noring these is a viable option for now. On Fri, Jun 23, 2017 at 10:02 AM Greg Woolsey wrote: > I'll take a look at that exception, I touched XSSFTableStyle. > > On Fri, Jun 23, 2017, 09:14 Allison, Timothy B. > wrote: > >> My run just finished as well. >> >

Re: Is it time for POI 3.17-beta1?

2017-06-23 Thread Greg Woolsey
have a look at XSLFDrawing - if you need help, I > can support. > > So I'm waiting for your modifications (+EMUUtils merge), before preparing > the release candidate. > > Andi > > On 6/23/17 8:44 PM, Greg Woolsey wrote: > > In this particular case, the test file define

Re: Is it time for POI 3.17-beta1?

2017-06-23 Thread Greg Woolsey
The example file with AlternateContent wrappers for table element styles is handled correctly now by r1799733 and added as a unit test. Existing tests still pass for me, plus my own downstream integrations. On Fri, Jun 23, 2017 at 1:07 PM Greg Woolsey wrote: > I checked in the units merge t

Re: [VOTE] Apache POI 3.17-beta1 release (RC1)

2017-06-27 Thread Greg Woolsey
+1 So far so good in my tests, no sudden slow downs in my performance cases. On Tue, Jun 27, 2017, 05:15 Allison, Timothy B. wrote: > +1 > > Checksums and sig are good. Built/tested on Windows. > > Thank you, Andi! > > -Original Message- > From: Dominik Stadler [mailto:dominik.stad...@

Re: Table Formula Manipulation and Matrix Function Implementation in HSSF/XSSF

2017-06-27 Thread Greg Woolsey
I implemented the current table formula handling, based on a patch I found languishing in the bug database. It's been a year or so, but here's what I remember: Data Table syntax works in most cases, but there is definitely room for more test cases looking for bugs in less common scenarios - Unico

Re: Moving to Git

2017-06-28 Thread Greg Woolsey
I'd be all for that. Not particularly proficient, but I can Google like everyone else. On Wed, Jun 28, 2017, 01:35 Javen O'Neal wrote: > A fair increase in Github PR's. Having a git repo might increase the > number of (good) PR's we get, as that seems to be where a lot of > developers are at. >

Re: [Bug 60422] DataFormatter.formatCellValue returns incorrect value for German 'Buchhaltung' format

2017-06-28 Thread Greg Woolsey
I'm suspicious Excel is doing extra work to translate formats for display to match the OS locale display settings even though the underlying storage always uses English standards. On Wed, Jun 28, 2017, 11:24 wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=60422 > > --- Comment #16 from P

Re: svn commit: r1800341 - in /poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/charts: XSSFCategoryAxis.java XSSFChartAxis.java XSSFDateAxis.java XSSFValueAxis.java

2017-06-29 Thread Greg Woolsey
Good point. I rushed it. There were already some like it in that class, but they should all get that treatment. It exists largely to provide common access to axis elements common to the 3 kinds of axis objects. On Thu, Jun 29, 2017, 21:00 Javen O'Neal wrote: > It's probably worth annotating a

Re: [Bug 61182] Invalid signature created for streamed xlsx file

2017-07-25 Thread Greg Woolsey
Unless there is some use case I'm missing, unit tests would be the only place a newly written file hash would need to match a precalculated value, meaning c) should be fine by me. I don't think anyone should expect POI to read a file and have the saved result be binarily equal to the input. The on

Re: Unsynchronize xmlbean calls

2017-07-25 Thread Greg Woolsey
+1, and good find by the SO user. On Tue, Jul 25, 2017, 15:31 Andreas Beeker wrote: > Hi, > > does anyone mind, if we unsynchronize the xmlbean calls? [1] > > Andi > > [1] https://stackoverflow.com/questions/45082014/ > >

Re: Table Formula Manipulation and Matrix Function Implementation in HSSF/XSSF

2017-07-26 Thread Greg Woolsey
ary is 2MB and JAMA is ~20KB. I understand this would be adding > a dependency to the project. Is there a preference on which library would > be used or is the preferred solution to implement the functionality > directly in POI? > > On 2017-06-27 15:51 (-0700), "Javen O'Neal

Re: Table Formula Manipulation and Matrix Function Implementation in HSSF/XSSF

2017-07-26 Thread Greg Woolsey
ests to verify that this dependency is only needed for > certain packages? I hope I'm wrong, but 20 MB is large enough that some > people may not want to update to newer versions of POI. > > On Jul 26, 2017 10:28 AM, "Greg Woolsey" wrote: > > > We aren't av

Re: Build failed in Jenkins: POI-DSL-Maven #289

2017-07-28 Thread Greg Woolsey
The two tests in error pass on my local system (Windows 10). The test log from the build [1] show the failing workbooks used by this test on the build servers had different contents than what I'm seeing locally. Specifically, locally, I'm seeing it pass because the document contains a SummaryInfo

Re: Build failed in Jenkins: POI-DSL-Maven #289

2017-07-28 Thread Greg Woolsey
SVN says I'm fully in sync with HEAD, no local differences. And it passes for me, but the Jenkins build failed. On Fri, Jul 28, 2017 at 3:59 PM Andreas Beeker wrote: > > The two tests in error pass on my local system (Windows 10). > > ... > > Anyone have a clue what is happening? This is appar

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
I'm all for standardizing the API between modules, however I have a large amount of code using the current XSSF API, in conjunction with another library, Vaadin-Spreadsheet. I'm in the process of submitting a large change request to that group , adding my features to their product. They already a

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
That might work for me, I'm not sure. Here's more background. There is much I want to do with the charts API already, but I haven't had time to see if this change goes in directions I'm wanting already. In particular I am constantly having to do variations on "instanceof" and type casting and/or

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
Vaadin7 requires Java 7, Vaadin 8 requires Java 8, so they are OK there. POI 3.17 already has breaking changes, so they have to put off incorporating my work until a larger release anyway, due to possible customer dependencies. Their next release will at least be using 3.16, so users like me can d

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-13 Thread Greg Woolsey
Perhaps then it could be a parallel package to start, marked @Beta, independent of the two existing packages, aside from reusing things like enums perhaps. Projects could then explore it and use it as a common alternative. Once it is deemed stable enough to leave beat status we could then mark th

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-13 Thread Greg Woolsey
You will also need to trace through the code to find the methods and properties referenced indirectly, via reflection, unfortunately. To avoid code duplication, Vaadin chose to access some properties of chart types via reflection where the properties are common to all charts, but not defined in a

3.17-beta2 vs. 3.17 final?

2017-08-17 Thread Greg Woolsey
I could use a new release, don't care what we call it :) Anyone have pending things they want to get finalized first? We had targeted end of summer for 3.17 final, but I don't remember any hard criteria for what folks wanted included in 3.17. I know there's been discussion about a new unified ch

Re: 3.17-beta2 vs. 3.17 final?

2017-08-17 Thread Greg Woolsey
I have a pull request with Vaadin [1] that is currently an echo chamber - I think the key developer I've been in contact with is on summer holiday. I think I found the last bug in my POI code, and the remaining issues with their integration tests relate to picking up a POI release with that fix an

Re: Help with task:

2017-08-17 Thread Greg Woolsey
Excellent! One way to do it would be to submit patches or pull requests [1] against the project that contain the new files and, if possible, updates to the documentation web page sources [2] integrating the new examples. If you don't mind waiting longer for developers to review and integrate chan

Re: Discussions on POI 4.0 / Java7/8 voting

2017-08-22 Thread Greg Woolsey
I'm of two minds regarding 4.0 vs. 3.18. I know there are big changes in discussion, that would warrant a major version, but I'm suspicious I'll find in the next 3 months something else in formula evaluation/conditional formatting/table styles that requires a POI bug fix, and I'd like for that to

Re: [VOTE] Apache POI 3.17 release (RC1)

2017-08-23 Thread Greg Woolsey
Once again legacy xmlbeans disappoints. I would prefer making the old behavior the default, with a setting/flag/property that can change to the faster behavior. Consumers can then test it in their environments. On Wed, Aug 23, 2017, 13:49 Dominik Stadler wrote: > Hi, > > regression results are

Re: POI 4.0 and Java 8

2017-08-28 Thread Greg Woolsey
Vaadin is Java 8. On Mon, Aug 28, 2017, 13:48 Javen O'Neal wrote: > Other stakeholders we should ping? > > > Vaadin, if they're on Java 6 or 7. > > On Aug 28, 2017 8:50 AM, "Allison, Timothy B." wrote: > > Thank you, David! > > Anyone with contacts at/works for Alfresco? > > Other stakeholders

Re: [Bug 61468] Regression: evaluateInCell results in incorrect value for some formulas

2017-08-29 Thread Greg Woolsey
ache.org/bugzilla/show_bug.cgi?id=61468 > > Greg Woolsey changed: > >What|Removed |Added > > >Hardware|Macintosh |All > > --- Commen

Re: [Bug 61469] [PATCH] Support Array Formulas and Matrix Functions

2017-08-29 Thread Greg Woolsey
This looks incredibly promising. Worth considering for a re-opened 3.17, or a short-cycle 3.18? I know we get requests for array formula support on a regular basis, and maybe it's my childhood rocket scientist hero-worship talking, but the facility name attached gives me an initial level of hope

Re: [VOTE] Apache POI 3.17 release (RC2)

2017-08-30 Thread Greg Woolsey
I would like an RC3 (sorry, I know this is a fair bit of work) to pick up r1806623 fixing bug 61468, as I consider that a rather serious calculation bug, and will likely cause a couple months' delay in my attempts to get Vaadin-Spreadsheet updated to use the new conditional formatting and table sty

Re: [VOTE] Apache POI 3.17 release (RC2)

2017-08-30 Thread Greg Woolsey
no-one minds, I would create RC3 tomorrow evening. > > Andi > > > On 8/30/17 7:44 PM, Greg Woolsey wrote: > > I would like an RC3 (sorry, I know this is a fair bit of work) to pick > up r1806623 > fixing bug 61468, as I consider that a rather serious calculation bug, and

Re: [VOTE] Apache POI 3.17 release (RC2)

2017-08-31 Thread Greg Woolsey
Wouldn't shock me to find out it is at the XML level - Word saving the same text in two different ways under the same parent would be completely within my jaded expectations. On Thu, Aug 31, 2017 at 11:37 AM Allison, Timothy B. wrote: > I ran the regression tests against docx, and I'm finding no

  1   2   >