Re: Review Request 56372: The installer does not filter out comments lines for the configuration file when installing the Ranger UserSync Process

2017-02-07 Thread Qiang Zhang
Attachments (updated) The same problem exists in the setup.py for tagsync https://reviews.apache.org/media/uploaded/files/2017/02/07/43ccc1fd-538a-4aa3-b4a4-967b882c2be4__0001-RANGER-1356-The-installer-for-tagssyn.patch Thanks, Qiang Zhang

Re: Review Request 56372: The installer does not filter out comments lines for the configuration file when installing the Ranger UserSync Process

2017-02-07 Thread Qiang Zhang
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56372/#review164485 --- On 二月 7, 2017, 3:59 a.m., Qiang Zhang wrote: > > --- > This is an automa

Review Request 56382: RANGER-1359:Remove unnecessary spring dependency

2017-02-07 Thread Qiang Zhang
of security-admin. Diffs - pom.xml bb48ff0 security-admin/pom.xml 0fcfc5a Diff: https://reviews.apache.org/r/56382/diff/ Testing --- #Test Result: 1.Build ranger success 2.Start Ranger-Admin success Thanks, Qiang Zhang

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-08 Thread Qiang Zhang
> On Feb. 8, 2017, 9:53 a.m., Colm O hEigeartaigh wrote: > > We should go further, and check to see if the JAVA_HOME variable is a > > directory, rather than just checking to see if it's empty (in both scripts) > > Qiang Zhang wrote: > Ok. I agree with your propo

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-08 Thread Qiang Zhang
) - unixauthservice/scripts/setup.sh cf785a1 Diff: https://reviews.apache.org/r/56431/diff/ Testing --- Thanks, Qiang Zhang

Review Request 56432: RANGER-1363:BadCredentialsException when login

2017-02-07 Thread Qiang Zhang
Diff: https://reviews.apache.org/r/56432/diff/ Testing --- git am --signoff < 0001-RANGER-1363-BadCredentialsException-when-login.patch Applying: RANGER-1363:BadCredentialsException when login Thanks, Qiang Zhang

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-08 Thread Qiang Zhang
atch. - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56431/#review164656 --- On 二月 8, 2017, 7:01 a.m., Qi

Review Request 56301: The program can not get the correct version when we installed Ranger KMS based on the latest version

2017-02-04 Thread Qiang Zhang
iff: https://reviews.apache.org/r/56301/diff/ Testing --- Thanks, Qiang Zhang

Review Request 56303: Code block was iterated four times, in fact it should only be executed once during initializing InitD for ranger usersync process

2017-02-04 Thread Qiang Zhang
",initdProgramName) if isfile(ubinScriptName) or os.path.islink(ubinScriptName): os.remove(ubinScriptName) os.symlink(localScriptName,ubinScriptName) Diffs - unixauthservice/scripts/setup.py e20d12e Diff: https://reviews.apache.org/r/56303/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56301: The program can not get the correct version when we installed Ranger KMS based on the latest version

2017-02-05 Thread Qiang Zhang
0e2 kms/scripts/version PRE-CREATION Diff: https://reviews.apache.org/r/56301/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56862: RANGER-1397:Error method name in the printed logs

2017-02-21 Thread Qiang Zhang
<== HiveClient getTableList() " + ret); } return ret; } Diffs (updated) - hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java ec61458 Diff: https://reviews.apache.org/r/56862/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56866: RANGER-1399:Do some code improvement in Java method SolrUtil.searchResources

2017-02-21 Thread Qiang Zhang
cess in Audit Access WebPage Thanks, Qiang Zhang

Review Request 56739: RANGER-1387:Remove unused SQL_CONNECTOR_JAR in install.properties of ranger plugin

2017-02-15 Thread Qiang Zhang
e5cf664 plugin-solr/scripts/install.properties 9073e8e plugin-yarn/scripts/install.properties 3825125 storm-agent/scripts/install.properties f3a0693 Diff: https://reviews.apache.org/r/56739/diff/ Testing --- #Test Result: 1. install hdfs-plugin sucess Thanks, Qiang Zhang

Review Request 56912: Enabling Ranger HDFS Plugins failed when hadoop program and Ranger HDFS Plugin are not in the same path.

2017-02-21 Thread Qiang Zhang
. Diffs - hdfs-agent/scripts/install.properties 148d2ba Diff: https://reviews.apache.org/r/56912/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56862: RANGER-1397:Error method name in the printed logs

2017-02-21 Thread Qiang Zhang
ed e-mail. To reply, visit: https://reviews.apache.org/r/56862/#review166132 --- On 二月 21, 2017, 9:50 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mai

Review Request 56921: There is a problem in buildks class when delete invalid keystore file.

2017-02-21 Thread Qiang Zhang
7978d8d Diff: https://reviews.apache.org/r/56921/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56864: RANGER-1398:Missing the settings for 'ranger.usersync.unix.minGroupId' in ranger usersync module

2017-02-22 Thread Qiang Zhang
the settings for ranger.usersync.unix.minGroupId in ranger usersync module Thanks, Qiang Zhang

Re: Review Request 56700: RANGER-1386:Ranger hdfs-plugin function not revoked after execute disable-hdfs-plugin.sh which cause hadoop-hdfs authorization failed.

2017-02-20 Thread Qiang Zhang
ot revoked This is a serious problem which cause hadoop-hdfs authorization failed. Diffs - hdfs-agent/disable-conf/hdfs-site-changes.cfg PRE-CREATION src/main/assembly/hdfs-agent.xml 63e426a Diff: https://reviews.apache.org/r/56700/diff/ Testing --- Thanks, Qiang Zhang

Review Request 56844: There are error logs in SecureClientLogin class

2017-02-20 Thread Qiang Zhang
/src/main/java/org/apache/hadoop/security/SecureClientLogin.java 3949350 Diff: https://reviews.apache.org/r/56844/diff/ Testing --- Thanks, Qiang Zhang

Review Request 56862: RANGER-1397:Error method name in the printed logs

2017-02-20 Thread Qiang Zhang
ret); } return ret; } Diffs - hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java ec61458 Diff: https://reviews.apache.org/r/56862/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-16 Thread Qiang Zhang
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165866 --- On 二月 17, 2017, 4:58 a.m., Qiang Zhang wrote: > > ---

Review Request 56866: RANGER-1399:Do some code improvement in Java method SolrUtil.searchResources

2017-02-20 Thread Qiang Zhang
--- #Test Result: 1.Start Ranger-Admin success with using solr for audit 2.Search success in Audit Access WebPage Thanks, Qiang Zhang

Re: Review Request 56866: RANGER-1399:Do some code improvement in Java method SolrUtil.searchResources

2017-02-20 Thread Qiang Zhang
://reviews.apache.org/r/56866/diff/ Testing --- #Test Result: 1.Start Ranger-Admin success with using solr for audit 2.Search success in Audit Access WebPage Thanks, Qiang Zhang

Review Request 56864: RANGER-1398:Missing the settings for 'ranger.usersync.unix.minGroupId' in ranger usersync module

2017-02-20 Thread Qiang Zhang
-ugsync-template.xml |4 4 files changed, 15 insertions(+) $ git am --signoff < 0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch Applying: RANGER-1398:Missing the settings for ranger.usersync.unix.minGroupId in ranger usersync module Thanks, Qiang Zhang

Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-14 Thread Qiang Zhang
/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java PRE-CREATION Diff: https://reviews.apache.org/r/56654/diff/ Testing --- Tested it Thanks, Qiang Zhang

Re: Review Request 56528: There are some errors when I used 'sudo ranger-usersync start' command to run the Ranger UserSync Process in ubuntu 16.04.

2017-02-09 Thread Qiang Zhang
ice with pid has started. The 'pid' has no value. 6. Apache Ranger Usersync Service not running. In fact the process was running. Diffs - unixauthservice/scripts/ranger-usersync-services.sh 36eefcd Diff: https://reviews.apache.org/r/56528/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56588: There is Page not found (404) error when clicking Admin tab in Audit.

2017-02-14 Thread Qiang Zhang
uired. View vx_trx_log should exist. My suggestion is to > > investigate the root cause. This change may not be required. > > Qiang Zhang wrote: > Ok. I will further analyze the problem. > > Pradeep Agrawal wrote: > @zhangqiang2 : Please provide MySQL version. M

Review Request 56700: RANGER-1386:Can't disable hdfs plugin after execute disable-hdfs-plugin.sh

2017-02-15 Thread Qiang Zhang
-CREATION src/main/assembly/hdfs-agent.xml 63e426a Diff: https://reviews.apache.org/r/56700/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 55256: RANGER-1289:Error occured in Ranger KMS function

2017-02-12 Thread Qiang Zhang
key0 : cipher: AES/CTR/NoPadding, length: 128, description: , created: Thu Feb 09 09:56:51 CST 2017, version: 1, attributes: [key.acl.name=key0] Thanks, Qiang Zhang

Re: Review Request 55256: RANGER-1289:Error occured in Ranger KMS function

2017-02-12 Thread Qiang Zhang
二月 13, 2017, 2:23 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55256/ > --- > > (Upda

Review Request 56588: There is Page not found (404) error when clicking Admin tab in Audit.

2017-02-12 Thread Qiang Zhang
database. Diffs - security-admin/src/main/java/org/apache/ranger/entity/view/VXXTrxLog.java 28d6f03 Diff: https://reviews.apache.org/r/56588/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56588: There is Page not found (404) error when clicking Admin tab in Audit.

2017-02-13 Thread Qiang Zhang
src/main/java/org/apache/ranger/entity/view/VXXTrxLog.java 28d6f03 Diff: https://reviews.apache.org/r/56588/diff/ Testing --- Thanks, Qiang Zhang

Review Request 56531: The "chown: invalid user: ‘ranger:ranger’" would appear when I run updatepolicymgrpassword.sh. to update policy mgr password.

2017-02-09 Thread Qiang Zhang
ger UserSync Process in install.properties. unix_user=usersync unix_group=usersync 2. Running updatepolicymgrpassword.sh. to update policy mgr password. Thanks, Qiang Zhang

Re: Review Request 56531: The "chown: invalid user: ‘ranger:ranger’" would appear when I run updatepolicymgrpassword.sh and updatepolicymgrpassword.py to update policy mgr password.

2017-02-09 Thread Qiang Zhang
f/ Testing --- 1. Using following configuration to install the Ranger UserSync Process in install.properties. unix_user=usersync unix_group=usersync 2. Running updatepolicymgrpassword.sh. to update policy mgr password. Thanks, Qiang Zhang

Re: Review Request 56429: If the linux user dones not exist, the password is not set after the user is created during installing Ranger Policy Admin. As description it increases the difficulty of the

2017-02-09 Thread Qiang Zhang
-admin/scripts/setup.sh f7e02d9 Diff: https://reviews.apache.org/r/56429/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56531: The "chown: invalid user: ‘ranger:ranger’" would appear when I run updatepolicymgrpassword.sh and updatepolicymgrpassword.py to update policy mgr password.

2017-02-09 Thread Qiang Zhang
policymgrpassword.sh or updatepolicymgrpassword.py to update policy mgr password. Thanks, Qiang Zhang

Review Request 56536: When exceptions occur during using ChangePasswordUtil tool to update admin password, the program doesn't record error messages.

2017-02-10 Thread Qiang Zhang
messages. Diffs - security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java ccdc279 Diff: https://reviews.apache.org/r/56536/diff/ Testing --- Thanks, Qiang Zhang

Review Request 56487: Ranger Kms support default key ACLs and whitelist key ACLs

2017-02-09 Thread Qiang Zhang
-site.xml default.key.acl.DECRYPT_EEK mysql whitelist.key.acl.DECRYPT_EEK * -->test with user xiehh [xiehh@zdh41 ~]$ hdfs dfs -cat /keyZone/a.txt dasdads asdasd ... Thanks, Qiang Zhang

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-09 Thread Qiang Zhang
) - tagsync/scripts/setup.sh d2a4f1b unixauthservice/scripts/setup.sh cf785a1 Diff: https://reviews.apache.org/r/56431/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56431: The installer of the usersync and unixauthservice can be executed when JAVA_HOME environment variable was set empty. The result is that there are many errors when installing

2017-02-09 Thread Qiang Zhang
> On Feb. 8, 2017, 9:53 a.m., Colm O hEigeartaigh wrote: > > We should go further, and check to see if the JAVA_HOME variable is a > > directory, rather than just checking to see if it's empty (in both scripts) > > Qiang Zhang wrote: > Ok. I agree with your propo

Re: Review Request 56477: No log was logged when some errors occurred in classes for the Unix Authentication Service.

2017-02-09 Thread Qiang Zhang
--- Thanks, Qiang Zhang

Review Request 56736: RANGER-1385:UnixAuthenticationService may fails in Widows as the "/" is different from "\"

2017-02-15 Thread Qiang Zhang
ucess in unix system but fail in Windows systems. Diffs - unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java 175307f Diff: https://reviews.apache.org/r/56736/diff/ Testing --- Tested it! Thanks, Qiang Zhang

Review Request 56780: RANGER-1391:Error occurred when use EndDate as Search Filter in Audit Access WebPage

2017-02-16 Thread Qiang Zhang
-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java e0ab372 Diff: https://reviews.apache.org/r/56780/diff/ Testing --- #Test Result: 1.Start Ranger-Admin success 2.Search success to use EndDate as Search Filter in Audit Access WebPage Thanks, Qiang Zhang

Re: Review Request 55616: The SYNC_SOURCE property only supports unix and ldap for ranger usersync at present, it's default value is unix. But It was assigned an empty value in configuration file. Now

2017-01-18 Thread Qiang Zhang
sys.exit(1) Diffs - unixauthservice/scripts/install.properties e784dda Diff: https://reviews.apache.org/r/55616/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 55702: There are two defects in install scripts for ranger usersync process

2017-01-19 Thread Qiang Zhang
review. And I rebuilt patch also. Thanks. - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55702/#review162265 --- On 一月 19, 2

Re: Review Request 55166: There was a logical error in parsing the configuration file when executing the database script.

2017-01-19 Thread Qiang Zhang
------- On 一月 19, 2017, 6:37 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55166/ > --

Re: Review Request 55166: There was a logical error in parsing the configuration file when executing the database script.

2017-01-19 Thread Qiang Zhang
. As a result, there are as follows problems: 1. There are invalid attribute values. 2. Invalid parsing will degrade the performance of program. Diffs (updated) - security-admin/scripts/dba_script.py e5a1f59 Diff: https://reviews.apache.org/r/55166/diff/ Testing --- Thanks, Qiang

Review Request 57084: RANGER-1412:Start hadoop failed after enabling ranger HDFS plugins

2017-02-27 Thread Qiang Zhang
oop. It's path is /var/local/hadoop/hadoop-2.7.3. 2. ranger hdfs plugin path is /usr/local/ranger-1.0.0-SNAPSHOT-hdfs-plugin. Diffs - agents-common/scripts/enable-agent.sh b8b79a9 Diff: https://reviews.apache.org/r/57084/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 57084: RANGER-1412:Start hadoop failed after enabling ranger HDFS plugins

2017-02-27 Thread Qiang Zhang
Testing --- Thanks, Qiang Zhang

Re: Review Request 57017: When the error occurs, the system does not record the error message in RangerServiceService class

2017-02-27 Thread Qiang Zhang
patch. Thanks! - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57017/#review166840 --- On Feb. 27, 2017, 12:15 p.m., Qiang Zhang wrote: > > ---

Review Request 57127: The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing hdfs plugin

2017-02-28 Thread Qiang Zhang
--- Thanks, Qiang Zhang

Re: Review Request 56921: There is a problem in buildks class when delete invalid keystore file.

2017-02-28 Thread Qiang Zhang
master repository. So I reopened it. Please resolved the issue first. After the patch was submitted to the ranger master repository, I'll close it again. Thanks. - Qiang Zhang On 二月 22, 2017, 7:17 a.m., Qiang Zhang wrote

Re: Review Request 57127: The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing hdfs pl

2017-02-28 Thread Qiang Zhang
9334607 Diff: https://reviews.apache.org/r/57127/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 57084: RANGER-1412:Start hadoop failed after enabling ranger HDFS plugins

2017-02-28 Thread Qiang Zhang
ts/enable-agent.sh b8b79a9 Diff: https://reviews.apache.org/r/57084/diff/ Testing --- Thanks, Qiang Zhang

Re: Review Request 56531: The "chown: invalid user: ‘ranger:ranger’" would appear when I run updatepolicymgrpassword.sh and updatepolicymgrpassword.py to update policy mgr password.So changing directo

2017-02-28 Thread Qiang Zhang
=usersync unix_group=usersync 2. Running updatepolicymgrpassword.sh or updatepolicymgrpassword.py to update policy mgr password. Thanks, Qiang Zhang

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-02-28 Thread Qiang Zhang
carefully tested and verified. Thanks! - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review166073 -----

Re: Review Request 56654: RANGER-1348:Atlas Autocompletion not working properly

2017-03-01 Thread Qiang Zhang
/ResourceTermResponse.java PRE-CREATION plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java PRE-CREATION Diff: https://reviews.apache.org/r/56654/diff/4/ Changes: https://reviews.apache.org/r/56654/diff/3-4/ Testing --- Tested it Thanks, Qiang Zhang

Re: Review Request 57873: There is invalid clause in the installer for Install and Configure Solr for Ranger Audits

2017-03-23 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57873/#review169948 --- Ship it! Ship It! - Qiang Zhang On 三月 23, 2017, 2:13 p.m

Re: Review Request 57865: The password is not set after the user is created by install program during installing Ranger Policy Admin. We should set password like db user.

2017-03-25 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57865/#review170079 --- Ship it! Ship It! - Qiang Zhang On 三月 23, 2017, 9:23 a.m

Re: Review Request 57634: RANGER-1456:Fix the spelling error in HDFS plugin

2017-03-15 Thread Qiang Zhang
634/diff/2/ Changes: https://reviews.apache.org/r/57634/diff/1-2/ Testing --- Thanks, Qiang Zhang

Review Request 57679: RANGER-1462:Fix the spelling error in Solr Authorization

2017-03-16 Thread Qiang Zhang
che/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java 6ac0a1f Diff: https://reviews.apache.org/r/57679/diff/1/ Testing --- Thanks, Qiang Zhang

Re: Review Request 57725: RANGER-1465:Parse properties file error for kms

2017-03-20 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57725/#review169396 --- Ship it! Ship It! - Qiang Zhang On 三月 17, 2017, 9:49 a.m

Review Request 57826: RANGER-1468:To make the search tips of Plugin-Status consistent with others

2017-03-21 Thread Qiang Zhang
tatus..." Thanks, Qiang Zhang

Review Request 57827: The user group would be duplicate created if the user group existed during installing Ranger Policy Admin.

2017-03-21 Thread Qiang Zhang
installing Ranger Policy Admin. Diffs - security-admin/scripts/setup.sh bc94874 Diff: https://reviews.apache.org/r/57827/diff/1/ Testing --- Thanks, Qiang Zhang

Re: Review Request 57827: The user group would be duplicate created if the user group existed during installing Ranger Policy Admin.

2017-03-22 Thread Qiang Zhang
created if the user group existed during installing Ranger Policy Admin. Diffs (updated) - security-admin/scripts/setup.sh bc94874 Diff: https://reviews.apache.org/r/57827/diff/2/ Changes: https://reviews.apache.org/r/57827/diff/1-2/ Testing --- Thanks, Qiang Zhang

Re: Review Request 57827: The user group would be duplicate created if the user group existed during installing Ranger Policy Admin.

2017-03-22 Thread Qiang Zhang
pdated the patch. Thanks. - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57827/#review169689 --- On March 22,

Re: Review Request 57127: The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing hdfs pl

2017-03-15 Thread Qiang Zhang
/RangerAdminRESTClient.java 9334607 Diff: https://reviews.apache.org/r/57127/diff/7/ Changes: https://reviews.apache.org/r/57127/diff/6-7/ Testing --- Thanks, Qiang Zhang

Review Request 57634: RANGER-1456:Fix the spelling error in HDFS plugin

2017-03-15 Thread Qiang Zhang
Throwable()); It should be 'service' instead of 'serice'. Diffs - hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsConnectionMgr.java e1985c0 Diff: https://reviews.apache.org/r/57634/diff/1/ Testing --- Thanks, Qiang Zhang

Re: Review Request 57127: The ranger can be opened when the user enters http://localhost:6080/ in the browser address bar. But request policy from hadoop to ranger will failed after installing hdfs pl

2017-03-15 Thread Qiang Zhang
utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57127/#review168892 ------- On March 15, 2017, 6:18 a.m., Qiang Zhang wrote: > > --- > This

Re: Review Request 57587: The install program used SOLR_RANGER_COLLECTION attribute value in Install and Configure Solr for Ranger Audits. But there is no corresponding setting in install.properties.

2017-03-16 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57587/#review169253 --- Ship it! Ship It! - Qiang Zhang On 三月 14, 2017, 4:55 a.m

Re: Review Request 56864: RANGER-1398:Missing the settings for 'ranger.usersync.unix.minGroupId' in ranger usersync module

2017-04-07 Thread Qiang Zhang
.properties |1 + .../scripts/templates/ranger-ugsync-template.xml |4 4 files changed, 15 insertions(+) $ git am --signoff < 0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch Applying: RANGER-1398:Missing the settings for ranger.usersync.unix.minGroupId in ranger usersync

Re: Review Request 56490: RANGER-1369:There is invalid group error when install Solr for Ranger Audits

2017-04-07 Thread Qiang Zhang
the script setup.sh of solr_for_audit_setup as root success 3.Start Solr and Ranger-Admin(use slor for audit) success Thanks, Qiang Zhang

Re: Review Request 56490: RANGER-1369:There is invalid group error when install Solr for Ranger Audits

2017-04-07 Thread Qiang Zhang
SOLR_GROUP=hadoop SOLR_INSTALL=false SOLR_DEPLOYMENT=standalone 2.Execute the script setup.sh of solr_for_audit_setup as root success 3.Start Solr and Ranger-Admin(use slor for audit) success Thanks, Qiang Zhang

Re: Review Request 57638: RANGER-1457 - Move COMPONENT_INSTALL_DIR_NAME to install.properties for Yarn plugin

2017-04-07 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57638/#review171335 --- Ship it! Ship It! - Qiang Zhang On March 15, 2017, 11:17

Re: Review Request 57603: RANGER-1455 - Incorrect conf dir in scripts for Hadoop

2017-04-07 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57603/#review171336 --- Ship it! Ship It! - Qiang Zhang On March 15, 2017, 10:28

Review Request 58285: RANGER-1503: Add tips to make jdbc.url parameter easy for users to use when create hive-plugin service

2017-04-09 Thread Qiang Zhang
: https://reviews.apache.org/r/58285/diff/1/ Testing --- test done! Thanks, Qiang Zhang

Review Request 58291: There are errors information in solr_for_audit_setup installer.

2017-04-10 Thread Qiang Zhang
confused. Diffs - security-admin/contrib/solr_for_audit_setup/setup.sh 41a51d8 Diff: https://reviews.apache.org/r/58291/diff/1/ Testing --- Thanks, Qiang Zhang

Review Request 58301: Some directorys were created repeatedly in code segment that all ownership is given to $SOLR_USER.

2017-04-10 Thread Qiang Zhang
is given to $SOLR_USER. We should check whether the directory exists before created them. Diffs - security-admin/contrib/solr_for_audit_setup/setup.sh 5b6b781 Diff: https://reviews.apache.org/r/58301/diff/1/ Testing --- Thanks, Qiang Zhang

Review Request 58331: RANGER-1507 Do some code improvement in UserSync

2017-04-10 Thread Qiang Zhang
/UserSync.java cab4072 Diff: https://reviews.apache.org/r/58331/diff/1/ Testing --- Thanks, Qiang Zhang

Re: Review Request 57285: RANGER-1421 - Add tag based authorization tests for the supported components

2017-04-11 Thread Qiang Zhang
railing whitespace. * .git/rebase-apply/patch:55: trailing whitespace. .git/rebase-apply/patch:63: trailing whitespace. warning: squelched 74 whitespace errors warning: 79 lines add whitespace errors. - Qiang Zhang On

Re: Review Request 58294: RANGER-1505 - Remove KeyProtector code in KMS

2017-04-11 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58294/#review171528 --- Ship it! Ship It! - Qiang Zhang On April 10, 2017, 11:26

Re: Review Request 58332: The browser returns garbled when we login ranger security admin in non-English environment. We need support the internationalization function to solve this problem

2017-04-11 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58332/#review171550 --- Ship it! Ship It! - Qiang Zhang On 四月 11, 2017, 7:34 a.m

Re: Review Request 58332: The browser returns garbled when we login ranger security admin in non-English environment. We need support the internationalization function to solve this problem

2017-04-16 Thread Qiang Zhang
eartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1508 > https://issues.apache.org/jira/browse/RANGER-1508 > > > Repository: ranger > > > Description > --- >

Re: Review Request 58332: The browser returns garbled when we login ranger security admin in non-English environment. We need support the internationalization function to solve this problem

2017-04-16 Thread Qiang Zhang
gt; > (Updated 四月 11, 2017, 7:34 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGE

Review Request 58472: In RangerBasePlugin.java LOG.debug spelling error

2017-04-16 Thread Qiang Zhang
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang. Bugs: RANGER-1517 https://issues.apache.org/jira/browse/RANGER-1517 Repository: ranger Description --- In RangerBasePlugin.java LOG.debug spelling error for LOG.debug

Review Request 58474: RANGER-1518:Do some code improvement for the error message in PolicyMgrUserGroupBuilder.java

2017-04-16 Thread Qiang Zhang
icate 'add' for this error message. Diffs - ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 070a39b Diff: https://reviews.apache.org/r/58474/diff/1/ Testing --- Thanks, Qiang Zhang

Review Request 58476: RANGER-1520:Some codes do not follow the python language development rules in usersync. They are messy.

2017-04-17 Thread Qiang Zhang
of the rows should be consistent. Some codes do not follow the rule in usersync. They are messy. Diffs - unixauthservice/scripts/setup.py d7872ea Diff: https://reviews.apache.org/r/58476/diff/1/ Testing --- Thanks, Qiang Zhang

Review Request 58475: RANGER-1519:Error occurred after execute enable-hive-plugin.sh

2017-04-17 Thread Qiang Zhang
to find the conf directory of component [hive]; dir [/home/xiehh/rangerplugin/hive/conf] not found. Exiting installation. Diffs - hive-agent/scripts/install.properties 2c109af Diff: https://reviews.apache.org/r/58475/diff/1/ Testing --- Thanks, Qiang Zhang

Review Request 58602: Friendly groups page delete function display, and other pages of the same function in sync

2017-04-20 Thread Qiang Zhang
ect group first to delete.',". Diffs - security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8f7d5d9 Diff: https://reviews.apache.org/r/58602/diff/1/ Testing --- tested it Thanks, Qiang Zhang

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform

2017-04-20 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58529/#review172571 --- Ship it! Ship It! - Qiang Zhang On 四月 19, 2017, 10:40 a.m

Re: Review Request 58301: Some directorys were created repeatedly in code segment that all ownership is given to $SOLR_USER.

2017-04-13 Thread Qiang Zhang
/r/58301/diff/1-2/ Testing --- Thanks, Qiang Zhang

Re: Review Request 58301: Some directorys were created repeatedly in code segment that all ownership is given to $SOLR_USER.

2017-04-13 Thread Qiang Zhang
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/58301/#review171569 --- On 四月 10, 2017, 1:59 p.m., Qiang Zhang wrote: > > --- > This is an automatically gen

Re: Review Request 58331: RANGER-1507 Do some code improvement in UserSync

2017-04-13 Thread Qiang Zhang
) - ugsync/ldapconfigchecktool/ldapconfigcheck/src/main/java/org/apache/ranger/ldapconfigcheck/UserSync.java cab4072 Diff: https://reviews.apache.org/r/58331/diff/2/ Changes: https://reviews.apache.org/r/58331/diff/1-2/ Testing --- Thanks, Qiang Zhang

Re: Review Request 58414: Different global variable saved the same configuration file path in unixauthservice. The code logic is inconsistent.

2017-04-13 Thread Qiang Zhang
://reviews.apache.org/r/58414/#review171858 --- On 四月 13, 2017, 9:39 a.m., Qiang Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 58455: Run updatepolicymgrpassword.sh and updatepolicymgrpassword.py to update policy mgr password failed.

2017-04-16 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58455/#review172057 --- Ship it! Ship It! - Qiang Zhang On April 14, 2017, 12:42

Re: Review Request 58457: RANGER-1516 - Remove remaining *-plugin-install.properties

2017-04-16 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58457/#review172058 --- Ship it! Ship It! - Qiang Zhang On 四月 14, 2017, 2:54 p.m

Re: Review Request 57285: RANGER-1421 - Add tag based authorization tests for the supported components

2017-04-16 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57285/#review172059 --- Ship it! Ship It! - Qiang Zhang On 四月 11, 2017, 3:17 p.m

Re: Review Request 58476: RANGER-1520:Some codes do not follow the python language development rules in usersync. They are messy.

2017-04-19 Thread Qiang Zhang
-3/ Testing --- Thanks, Qiang Zhang

Re: Review Request 58476: RANGER-1520:Some codes do not follow the python language development rules in usersync. They are messy.

2017-04-19 Thread Qiang Zhang
the patch. Thanks. - Qiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58476/#review172330 --- On April 20, 2017, 3:52 a.m., Qiang Zhang wrote: > > --- >

Re: Review Request 58530: RANGER-1527 - Make curator dependencies consistent

2017-04-19 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58530/#review172334 --- Ship it! Ship It! - Qiang Zhang On 四月 19, 2017, 10:39 a.m

  1   2   3   4   5   6   7   8   9   10   >