Re: Review Request 50987: SQOOP-2913: Make sqoop fail if user uses --direct connector for case when --direct connector is not available

, Anna Szonyi

Review Request 50987: SQOOP-2913

-CREATION Diff: https://reviews.apache.org/r/50987/diff/ Testing --- Added new test cases Thanks, Anna Szonyi

Re: Review Request 50987: SQOOP-2913: Make sqoop fail if user uses --direct connector for case when --direct connector is not available

/manager/TestDefaultManagerFactory.java PRE-CREATION src/test/org/apache/sqoop/tool/TestValidateImportOptions.java PRE-CREATION Diff: https://reviews.apache.org/r/50987/diff/ Testing --- Added new test cases Thanks, Anna Szonyi

Re: Review Request 50987: SQOOP-2913: Make sqoop fail if user uses --direct connector for case when --direct connector is not available

PRE-CREATION src/test/org/apache/sqoop/manager/TestDefaultManagerFactory.java PRE-CREATION src/test/org/apache/sqoop/tool/TestValidateImportOptions.java PRE-CREATION Diff: https://reviews.apache.org/r/50987/diff/ Testing --- Added new test cases Thanks, Anna Szonyi

Re: Review Request 50987: SQOOP-2913: Make sqoop fail if user uses --direct connector for case when --direct connector is not available

sqoop/tool/TestExportToolValidateOptions.java PRE-CREATION src/test/org/apache/sqoop/tool/TestValidateImportOptions.java PRE-CREATION Diff: https://reviews.apache.org/r/50987/diff/ Testing --- Added new test cases Thanks, Anna Szonyi

Re: Review Request 51180: Sqoop ClassNotFoundException (org.apache.commons.lang3.StringUtils) is thrown when executing Oracle direct import map task

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51180/#review146320 --- Ship it! Ship It! - Anna Szonyi On Aug. 17, 2016, 3:09 p.m

Re: Review Request 50987: SQOOP-2913: Make sqoop fail if user uses --direct connector for case when --direct connector is not available

/TestValidateImportOptions.java PRE-CREATION Diff: https://reviews.apache.org/r/50987/diff/ Testing --- Added new test cases Thanks, Anna Szonyi

Re: Review Request 50987: SQOOP-2913: Make sqoop fail if user uses --direct connector for case when --direct connector is not available

/TestValidateImportOptions.java PRE-CREATION Diff: https://reviews.apache.org/r/50987/diff/ Testing --- Added new test cases Thanks, Anna Szonyi

Re: Review Request 52212: SQOOP-3013: Configuration "tmpjars" is not checked for empty strings before passing to MR

ng on its parameters. Hey Liz, Thanks for the patch, this is great, I just have a few minor comments :), please check and see if it makes sense to incorporate them. /Anna - Anna Szonyi On Oct. 19, 2016, 3:16 p.m., Erzsebet Szilagyi wrote: > > -

Review Request 53169: Minor convenience feature: Added flag (remoteDebug) to ant test to enable remote debuging

sting --- ran ant test without any flag, ant test with -DremoteDebug=true, -DremoteDebug=false, ant compile, etc. Thanks, Anna Szonyi

Review Request 53374: SQOOP-3038 export to table with "value" column causes all null values in the "value" column

ortTest.java 8aa0725 src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java f4b1ea9 Diff: https://reviews.apache.org/r/53374/diff/ Testing --- ran tests, created a new test to cover the "value" column case. Thanks, Anna Szonyi

Re: Review Request 53374: SQOOP-3038 export to table with "value" column causes all null values in the "value" column

est/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725 src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java f4b1ea9 Diff: https://reviews.apache.org/r/53374/diff/ Testing (updated) --- ran tests, created a new test to cover the "value" column case Thanks, Anna Szonyi

Re: Review Request 53423: SQOOP-2349 Transaction isolation level for metadata queries should be mutable

e sense to write a test case for this? Thanks, /Anna - Anna Szonyi On Nov. 3, 2016, 12:37 p.m., Attila Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 53423: SQOOP-2349 Transaction isolation level for metadata queries should be mutable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53423/#review154745 --- Ship it! Ship It! - Anna Szonyi On Nov. 3, 2016, 1:56 p.m

Re: Review Request 53423: SQOOP-2349 Transaction isolation level for metadata queries should be mutable

, /Anna - Anna Szonyi On Nov. 4, 2016, 3:52 a.m., Attila Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 53471: SQOOP-3044 missing/incorrect Apache license headers fix

testdata/hcatalog/conf/hive-site.xml 52b2fff Diff: https://reviews.apache.org/r/53471/diff/ Testing --- ran unit tests. Thanks, Anna Szonyi

Re: Review Request 53134: HBase import should fail fast if using anything other than as-textfile

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53134/#review155306 --- Ship it! Ship It! - Anna Szonyi On Nov. 8, 2016, 2:53 p.m

Review Request 53600: SQOOP-3027 Create check/fail fast for Sqoop export and import with --hcatalog-table , as it's not supported by Hive + MR

53600/diff/ Testing --- Added unit tests for import, export and view check. Ran ant test. Thanks, Anna Szonyi

Re: Review Request 53600: SQOOP-3027 Create check/fail fast for Sqoop export and import with --hcatalog-table , as it's not supported by Hive + MR

t/org/apache/sqoop/hcat/HCatalogImportTest.java fe5295a src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java fb4a200 Diff: https://reviews.apache.org/r/53600/diff/ Testing --- Added unit tests for import, export and view check. Ran ant test. Thanks, Anna Szonyi

Re: Review Request 53600: SQOOP-3027 Create check/fail fast for Sqoop export and import with --hcatalog-table , as it's not supported by Hive + MR

test. Thanks, Anna Szonyi

Re: Review Request 53600: SQOOP-3027 Create check/fail fast for Sqoop export and import with --hcatalog-table , as it's not supported by Hive + MR

test. Thanks, Anna Szonyi

Re: Review Request 53600: SQOOP-3027 Create check/fail fast for Sqoop export and import with --hcatalog-table , as it's not supported by Hive + MR

Added unit tests for import, export and view check. Ran ant test. Thanks, Anna Szonyi

Re: Review Request 53946: Include stack trace in the logging of exceptions in ExportTool

everywhere :) /Anna - Anna Szonyi On Nov. 21, 2016, 2:18 p.m., Boglarka Egyed wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53600: SQOOP-3027 Create check/fail fast for Sqoop export and import with --hcatalog-table , as it's not supported by Hive + MR

xport and view check. Ran ant test. Thanks, Anna Szonyi

Review Request 54030: SQOOP-3055 MySQL tests are failing due to the tests ignoring specified username, password and dbname, trying to connect to specified db using "currentUser"

t_url=mysqlhost -Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop Thanks, Anna Szonyi

Re: Review Request 54030: SQOOP-3055 MySQL tests are failing due to the tests ignoring specified username, password and dbname, trying to connect to specified db using "currentUser"

t.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop Thanks, Anna Szonyi

Re: Review Request 54030: SQOOP-3055 MySQL tests are failing due to the tests ignoring specified username, password and dbname, trying to connect to specified db using "currentUser"

name=sqoop_repo -Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop Thanks, Anna Szonyi

Re: Review Request 54030: SQOOP-3055 MySQL tests are failing due to the tests ignoring specified username, password and dbname, trying to connect to specified db using "currentUser"

-Dhbaseprofile=95 -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=3rdpartylibdir -Dsqoop.test.mysql.connectstring.host_url=mysqlhost -Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop Thanks, Anna Szonyi

Review Request 54156: SQOOP-3056 Add report ivy report target to build

ncies come from. Diffs - build.xml 6e8d393 Diff: https://reviews.apache.org/r/54156/diff/ Testing --- ran ant report and checked the output html & graph (with yEd), ran ant clean test, ant compile Thanks, Anna Szonyi

Re: Review Request 54030: SQOOP-3055 MySQL tests are failing due to the tests ignoring specified username, password and dbname, trying to connect to specified db using "currentUser"

le 95: ant test -Dhadoopversion=260 -Dhbaseprofile=95 -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=3rdpartylibdir -Dsqoop.test.mysql.connectstring.host_url=mysqlhost -Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop Thanks, Anna Szonyi

Review Request 54168: SQOOP-3057 3rd party Oracle tests are failing

RTY_LIB -Dmaxmemory=2048m -DtargetJavaVersion=1.7 -DjavaVersion=1.7 -Djava.security.egd=file:///dev/./urandom -Dsqoop.test.oracle.connectstring=$ORACLE_CONN -Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=100 -Dtestcase=Oracle*Test Thanks, Anna Szonyi

Re: Review Request 54206: Create a cmd line argument for sqoop.throwOnError and use it through SqoopOptions

ting a method or a ternary operator for this assignment? - Anna Szonyi On Dec. 2, 2016, 10:59 a.m., Boglarka Egyed wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 47110: Proposed changes to make the local ivy resolver faster

ivy resolves significantly faster, thank you!! Thanks, /Anna - Anna Szonyi On May 9, 2016, 7:26 a.m., Attila Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 54325: SQOOP-3051 Remove all old profiles, configurations from build.xml and ivy.xml and consolidate them to a single working one

verify that it overrides the defaults. Thanks, Anna Szonyi

Re: Review Request 54325: SQOOP-3051 Remove all old profiles, configurations from build.xml and ivy.xml and consolidate them to a single working one

rties 8e14624 Diff: https://reviews.apache.org/r/54325/diff/ Testing --- ant jar-all, ant package, ant compile, ant eclipse, tried with specifying -Dhadoop.version, -Davro.version, -Dhbase.version, -Dhcatalog.version, etc. to verify that it overrides the defaults. Thanks, Anna Szonyi

Re: Review Request 54325: SQOOP-3051 Remove all old profiles, configurations from build.xml and ivy.xml and consolidate them to a single working one

rsion, etc. to verify that it overrides the defaults. Thanks, Anna Szonyi

Re: Review Request 54325: SQOOP-3051 Remove all old profiles, configurations from build.xml and ivy.xml and consolidate them to a single working one

://reviews.apache.org/r/54325/diff/ Testing --- ant jar-all, ant package, ant compile, ant eclipse, tried with specifying -Dhadoop.version, -Davro.version, -Dhbase.version, -Dhcatalog.version, etc. to verify that it overrides the defaults. Thanks, Anna Szonyi

Re: Review Request 54373: SQOOP-3066: Introduce an option + env variable to enable/disable SQOOP-2737 feature

ifier(column.getColumnName(), false) and use that in these cases instead? Hi Attila, Thanks for the super fast turnaround for this bug, there have been quite a few users opening escalations for this! Please see the few questions/suggestions we have. Thanks, /Anna - Anna Szo

Re: Review Request 54373: SQOOP-3066: Introduce an option + env variable to enable/disable SQOOP-2737 feature

a/org/apache/sqoop/manager/oracle/OracleUtils.java (line 32) <https://reviews.apache.org/r/54373/#comment228703> Please remove the trailing spaces - Anna Szonyi On Dec. 5, 2016, 6:52 p.m., Attila Szabo wrote: > > --- > Thi

Re: Review Request 54373: SQOOP-3066: Introduce an option + env variable to enable/disable SQOOP-2737 feature

(line 516) <https://reviews.apache.org/r/54373/#comment228718> See line 174 Hi, just a small thing to nitpick, otherwise seems great! - Anna Szonyi On Dec. 5, 2016, 7:09 p.m., Attila Szabo wrote: > > --- > This is an au

Re: Review Request 54416: SQOOP-3069: Get OracleExportTest#testUpsertTestExport in line with SQOOP-3066

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54416/#review158150 --- Ship it! Ship It! - Anna Szonyi On Dec. 6, 2016, 12:41 p.m

Re: Review Request 54427: SQOOP-3071: Fix OracleManager to apply localTimeZone correctly in case of Date objects too

che.org/r/54427/#comment228921> Do we necessarily want to set this with the Oracle session timezone? - Anna Szonyi On Dec. 6, 2016, 4:14 p.m., Attila Szabo wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 54429: SQOOP-3072: Reenable escaping in ImportTest#testProductWithWhiteSpaceImport for proper execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54429/#review158180 --- Ship it! Ship It! - Anna Szonyi On Dec. 6, 2016, 4:44 p.m

Re: Review Request 54427: SQOOP-3071: Fix OracleManager to apply localTimeZone correctly in case of Date objects too

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54427/#review158181 --- Ship it! Thanks for the explanation! - Anna Szonyi On Dec

Re: Review Request 54540: SQOOP-3074: Fix Avro import not to fail with Javac errors in case of non UTF-8 locale

comments out of code, however as this is a very particular use-case and the solution is non-trivial, in my opinion it would be useful to add a line or two of comments on why/in which case the unescape and escape is necessary. Thanks, /Anna - Anna Szonyi On Dec. 8, 2016, 6:25 p.m., Attila

Re: Review Request 54540: SQOOP-3074: Fix Avro import not to fail with Javac errors in case of non UTF-8 locale

e ran ant clean test and thirdparty tests with configured server names and everything seems to be running correctly! Thanks, /Anna - Anna Szonyi On Dec. 8, 2016, 9:53 p.m., Attila Szabo wrote: > > --- > This is an automatically ge

Re: Review Request 54575: SQOOP-3075: Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

line 174) <https://reviews.apache.org/r/54575/#comment229444> please also extract this into a constant. - Anna Szonyi On Dec. 9, 2016, 5:57 a.m., Attila Szabo wrote: > > --- > This is an automatically generated e

Re: Release 1.5 (maybe 1.4.7 ? ), CI, build system, etc.

llowing: > > > > > >- A few weeks ago I've opened three JIRAs (depending on each other > > >linearly) upstream (SQOOP-3050, SQOOP-3051 and SQOOP-3052). > > >- SQOOP-3050 is about fix the current test cases (mainly failing > > because &g

Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to OracleExportTest#testUpsertTextExport Thanks, Anna Szonyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

this, as right now the escaping logic is all over the code... - Anna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159010 -------

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to OracleExportTest#testUpsertTextExport Thanks, Anna Szonyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to OracleExportTest#testUpsertTextExport Thanks, Anna Szonyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

tps://reviews.apache.org/r/54699/#comment230100> If this is an acceptable solution, we could change the code so that all of the escaping/decisions about escaping are handled by the escapeIdentifier method. - Anna Szonyi On Dec. 14, 2016, 10:14 a.m., Anna Szonyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

tention to OracleExportTest#testUpsertTextExport Thanks, Anna Szonyi

Review Request 54745: SQOOP-3084 bug fix in aop.xml, org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed after SQOOP-3051

-inject Thanks, Anna Szonyi

Review Request 54746: SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource

/test/aop/build/aop.xml 77320aa Diff: https://reviews.apache.org/r/54746/diff/ Testing --- ant compile, ant test, ant jar-fault-inject Thanks, Anna Szonyi

Re: Review Request 54746: SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource

try with resource Diffs (updated) - ivy/libraries.properties e2c2516 src/test/aop/build/aop.xml 77320aa Diff: https://reviews.apache.org/r/54746/diff/ Testing --- ant compile, ant test, ant jar-fault-inject Thanks, Anna Szonyi

Re: Review Request 54746: SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource

SQOOP-2983 due to introducing try with resource Diffs (updated) - ivy/libraries.properties e2c2516 src/test/aop/build/aop.xml 77320aa Diff: https://reviews.apache.org/r/54746/diff/ Testing --- ant compile, ant test, ant jar-fault-inject Thanks, Anna Szonyi

Re: Review Request 54746: SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54746/#review159313 --- On Dec. 15, 2016, 7:37 p.m., Anna Szonyi wrote: > > ---

Re: Review Request 54575: SQOOP-3075: Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54575/#review159426 --- Ship it! Ship It! - Anna Szonyi On Dec. 16, 2016, 10:46 a.m

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

tention to OracleExportTest#testUpsertTextExport Thanks, Anna Szonyi

Re: Review Request 55001: Clean up expected exception logic in tests - part I.

tests, it's been quite annyoing :) I've opened a jira to remove all junit3 related classes, conventions from the code as well. Thanks, /Anna - Anna Szonyi On Dec. 28, 2016, 3:57 p.m., Boglarka Egyed wrote: > > --- > This

Re: Review Request 55103: Clean up expected exception logic in tests - part II.

this way! Thanks, Anna - Anna Szonyi On Dec. 30, 2016, 3:29 p.m., Boglarka Egyed wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Review Request 55142: SQOOP-3099 Remove all junit3 TestCase extension and test suites

=cubridserver -Dsqoop.test.cubrid.connectstring.username=sqoop -Dsqoop.test.cubrid.connectstring.database=sqoop -Dsqoop.test.cubrid.connectstring.password=sqoop -Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=100 Thanks, Anna Szonyi

Re: Review Request 54421: Enhance error (tool.ImportTool: Encountered IOException running import job: java.io.IOException: Expected schema) to suggest workaround (--map-column-java)

ExpectedLogMessage utility, that will be super helpful :)) Thanks, /Anna - Anna Szonyi On Dec. 22, 2016, 3:50 p.m., Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 55142: SQOOP-3099 Remove all junit3 TestCase extension and test suites

an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55142/#review161201 --- On Jan. 3, 2017, 4:58 p.m., Anna Szonyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 55142: SQOOP-3099 Remove all junit3 TestCase extension and test suites

unit4 also support suites. > > I would be abel to raise pros and cons also, so I'd like to understand your > > motivation here first. > > > > Thanks for the calrification! > > > > Attila > > Anna Szonyi wrote: > Hi Attila, > > W

Re: Review Request 55142: SQOOP-3099 Remove all junit3 TestCase extension and test suites

unit4 also support suites. > > I would be abel to raise pros and cons also, so I'd like to understand your > > motivation here first. > > > > Thanks for the calrification! > > > > Attila > > Anna Szonyi wrote: > Hi Attila, > > W

Re: Review Request 55142: SQOOP-3099 Remove all junit3 TestCase extension and test suites

ut=100 Thanks, Anna Szonyi

Re: Review Request 55142: SQOOP-3099 Remove all junit3 TestCase extension and test suites

-Dsqoop.test.cubrid.connectstring.username=sqoop -Dsqoop.test.cubrid.connectstring.database=sqoop -Dsqoop.test.cubrid.connectstring.password=sqoop -Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=100 Thanks, Anna Szonyi

Re: Import more than 10 million records from MySQL to HDFS

Hi Wenxing, I tested the scenario with a simple table (10 million rows, but only 3 columns) and it seems to work perfectly for me (with super simple types: int, varchar, timestamp). Could you please share the full create table statement (doesn't have to be the same column names just the same types

Review Request 56949: SQOOP-3140: mapred.map.max.attempts, mapred.reduce.max.attempts are deprecated

Thanks, Anna Szonyi

Re: Review Request 55769: Import tables with special characters

Szabolcs's comment that it would be good to add a test case that covers the "backwards compatibility": using the cleaned column name for mapping with non-avro cases - we checked it out and it shouldn't be a problem, but it would be great to have automated test cases for it. T

Re: Review Request 56949: SQOOP-3140: mapred.map.max.attempts, mapred.reduce.max.attempts are deprecated

/mapreduce/ExportJobBase.java 27f84da src/java/org/apache/sqoop/mapreduce/JobBase.java 256d4f7 src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java c0c6039 Diff: https://reviews.apache.org/r/56949/diff/ Testing --- ant test Thanks, Anna Szonyi

Review Request 56984: SQOOP-3139: change default of mapreduce.map.maxattempts to 1 for import (so it's consistent with export)

- src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 105917c Diff: https://reviews.apache.org/r/56984/diff/ Testing --- ant test Thanks, Anna Szonyi

Re: Review Request 55769: Import tables with special characters

> On March 8, 2017, 12:40 p.m., Attila Szabo wrote: > > Hey Dimitry, Szabolcs, Anna, > > > > First of all I'd like to thank Dimitry for opening this ticket, and > > providing a contribution idea how to solve this problem. > > I'd like to also thank to Anna and Szabi to review the code of Dimitr

Re: Review Request 57659: SQOOP-3143: Restore fail messages removed in SQOOP-3091

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57659/#review169185 --- Ship it! Ship It! - Anna Szonyi On March 16, 2017, 6:23 p.m

Sqoop CI changes

Hi All, I would like to make the following changes to the Sqoop CI system: Disable the SCM polling for the Sqoop-hadoop23 Sqoop-hadoop20 and Sqoop-hadoop100 jobs (and later delete the jobs themselves), as the current trunk version of sqoop no longer contains these profiles, so these runs are redun

Re: Review Request 57876: Sqoop (export + --table) with Oracle table_name having '$' fails with error (ORA-00942 or java.lang.NoClassDefFoundError)

Would it make sense to extract this into a method, like isInnerClass to make it more explicit? - Anna Szonyi On March 23, 2017, 2:21 p.m., Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 57876: Sqoop (export + --table) with Oracle table_name having '$' fails with error (ORA-00942 or java.lang.NoClassDefFoundError)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57876/#review170140 --- Ship it! Ship It! - Anna Szonyi On March 24, 2017, 1:20 p.m

Re: Review Request 58233: SQOOP-3167: Evalutation and automation of SQLServer Manual tests

hod, do you think it would make sense to rename it to getTypes or something similar? src/test/com/cloudera/sqoop/hive/TestHiveImport.java Line 463 (original), 463 (patched) <https://reviews.apache.org/r/58233/#comment244089> Why was the AsParquet removed from the method name? - Anna

Re: Sqoop CI changes

t; > > > Thank you, > > Liz > > > > On Fri, Mar 24, 2017 at 9:39 AM, Szabolcs Vasas > > wrote: > > > > > Hi Anna, > > > > > > Removing the redundant test execution jobs sounds great, I think you > can > > go > >

Running 3rd party test on the CI

Hi All, We started a discussion about running thirdparty integration tests in our CI on separate threads (another e-mail chain and a review), and I thought it might make sense to bring these threads together. We were discussing the best way of running the thirdparty tests on the apache CI, as we

Re: Review Request 58295: SQOOP-3169: Evaluate and fix SQLServer Manual tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58295/#review171576 --- Ship it! Ship It! - Anna Szonyi On April 10, 2017, 12:47

Re: Review Request 51912: SQOOP 816 - Scoop and support for external Hive tables

rc/test/org/apache/sqoop/hive/TestTableDefWriter.java Lines 82 (patched) <https://reviews.apache.org/r/51912/#comment245842> Thanks for creating a new test class! Would you please also add test cases that cover the "default path", where we're not creating external tables, to ensure

Creating feature branches

Hi @devs, We would like to start the preparation for upgrading to hive 2 (upgrade version, migrate off of hive cli and onto beeline, etc.). As we anticipate there being a few patches we were thinking it would make sense to create a feature branch (sqoop_hive2) for this, as we do not want trunk to

Re: Review Request 51912: SQOOP 816 - Scoop and support for external Hive tables

ure and we want to make sure it gets committed with all the necessary classes/features! Thanks, Anna - Anna Szonyi On April 30, 2017, 7:48 a.m., Chris Teoh wrote: > > --- > This is an automatically generated e-mail. To re

Re: SQOOP 1.4.7 Release by end of June

Hi Attila, This would be really great! Please let me know if I can help with anything! Thanks, Anna On Thu, May 25, 2017 at 6:20 PM, Attila Szabó wrote: > Hello everyone, > > In the past few months we've mentioned it a few times that it would make > sense to create a new release of Sqoop from

Re: Review Request 57499: Sqoop incremental import - NULL column updates are not pulled into HBase table

.apache.org/r/57499/#comment250724> Quite a bit of this function is already in the original getArgv function in the HBaseTestCase class, please reuse/extract-refactor that part of the method. - Anna Szonyi On April 9, 2017, 5:49 p.m., Jilani Shaik wrote: > > ---

Re: Review Request 59690: SQOOP-59690 : UPGRADE PARQUET TO NEW VERSION

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59690/#review177297 --- Ship it! Ship It! - Anna Szonyi On May 31, 2017, 8:21 p.m

Re: Review Request 58466: SQOOP-3158 - Columns added to Mysql after initial sqoop import, export back to table with same schema fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58466/#review177351 --- Ship it! Ship It! - Anna Szonyi On May 30, 2017, 9:36 a.m

Re: Review Request 57499: Sqoop incremental import - NULL column updates are not pulled into HBase table

he code a bit more clean and extensible. Please let me know your thoughts on this! - Anna Szonyi On June 11, 2017, 8:21 p.m., Jilani Shaik wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 59844: Database credentials cannot be configured in PostgreSQL third party tests

DirectPostgreSQLExportManualTest along with the other Postgres tests? Thanks, Anna - Anna Szonyi On June 6, 2017, 4:59 p.m., Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57499: Sqoop incremental import - NULL column updates are not pulled into HBase table

> > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57499/ > ------- > > (Updated July 12, 2017, 5:20 a.m.) > > &

Greetings and Reviews

Hi @devs, We've recently noticed that there is an increase in contributions to the Sqoop project which has us super excited! I would like to welcome all the new contributors to the project! However due to this increased contribution activity we find ourselves short on active reviewers. This cause

Re: Review Request 59346: SQOOP-3178 : Incremental Merging for Parquet File Format

e to refactor them, so we wouldn't have to repeat the code again. src/test/com/cloudera/sqoop/TestMerge.java Lines 57 (patched) <https://reviews.apache.org/r/59346/#comment256110> this seems to be an unused import. -

Re: Review Request 59346: SQOOP-3178 : Incremental Merging for Parquet File Format

you please reorder the lines as they were? src/java/org/apache/sqoop/mapreduce/MergeJob.java Line 128 (original) <https://reviews.apache.org/r/59346/#comment256197> another tiny nit-pick: it makes merging/backporting easier if we do not make unnecesary whitespace/new line changes

Re: Review Request 59346: SQOOP-3178 : Incremental Merging for Parquet File Format

lot! I found a missing semicolon, other than that the tests seem to be running and everything is green. Thanks, Anna src/java/org/apache/sqoop/mapreduce/MergeJob.java Lines 82 (patched) <https://reviews.apache.org/r/59346/#comment256494> this line is missing a ; - Anna Szonyi On J

Re: Review Request 59346: SQOOP-3178 : Incremental Merging for Parquet File Format

> On July 20, 2017, 5:40 p.m., Anna Szonyi wrote: > > Hi Sandish, > > > > Thanks for all the changes, they aid readability a lot! I found a missing > > semicolon, other than that the tests seem to be running and everything is > > green. > > > >

Changing behavior on trunk

Hi @dev list, Jilani has created a great patch for SQOOP-3149 : Sqoop incremental import - NULL column updates are not pulled into HBase table. This is a patch that (in my opinion) corrects previously incorrect behavior in sqoop, however it can al

  1   2   3   >