[GitHub] qin4zhang opened a new issue #4840: ldap configuration

qin4zhang opened a new issue #4840: ldap configuration URL: https://github.com/apache/incubator-superset/issues/4840 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text

[GitHub] abowden-spotx commented on issue #4747: [WiP] Download Dashboards as PDF

abowden-spotx commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-382427457 Ultimately, the goal of this addition is so that we can integrate it with an emailing feature that will run independently on the

Re: Setting up SLAs at DAG and Job level

This is the Superset mailing list, not the Airflow one... On Tue, Apr 17, 2018 at 5:53 PM, Yogesh Kumar wrote: > Hi Devs, > Is there any way to do that based on actual start-date of DAG instance > rather than based on execution_date? I have multiple scenarios of >

[GitHub] abowden-spotx commented on issue #4747: [WiP] Download Dashboards as PDF

abowden-spotx commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-382427457 Ultimately, the goal of this addition is so that we can integrate it with an emailing feature that will run independently on the

[GitHub] mistercrunch commented on issue #4205: Ability to save default values to Dashboard filter

mistercrunch commented on issue #4205: Ability to save default values to Dashboard filter URL: https://github.com/apache/incubator-superset/issues/4205#issuecomment-382434755 @sevalo8 are you using an old version? This is

[GitHub] mistercrunch commented on issue #4840: ldap configuration

mistercrunch commented on issue #4840: ldap configuration URL: https://github.com/apache/incubator-superset/issues/4840#issuecomment-382434085 This is really a FAB (Flask-AppBuilder) question. This is an automated message

[GitHub] mistercrunch opened a new pull request #4841: Move a few JS files

mistercrunch opened a new pull request #4841: Move a few JS files URL: https://github.com/apache/incubator-superset/pull/4841 `src/explore/stores/store` - > `src/explore/store` `src/explore/stores/visTypes` -> `src/explore/visTypes` `src/visualizations/main.js` ->

[GitHub] codecov-io commented on issue #4520: Allow users to view dashboards they own

codecov-io commented on issue #4520: Allow users to view dashboards they own URL: https://github.com/apache/incubator-superset/pull/4520#issuecomment-382471867 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4520?src=pr=h1) Report > Merging

Re: Setting up SLAs at DAG and Job level

my bad. apologize for inconvenience. On Wed, Apr 18, 2018 at 8:25 AM, Maxime Beauchemin < maximebeauche...@gmail.com> wrote: > This is the Superset mailing list, not the Airflow one... > > On Tue, Apr 17, 2018 at 5:53 PM, Yogesh Kumar > wrote: > > > Hi Devs, > > Is

[GitHub] timifasubaa commented on issue #4829: [import csv] ensure directory exists before saving csv file

timifasubaa commented on issue #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829#issuecomment-382529887 @john-bodley Succeeded. Ready for merge

[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-382532775 Okay, I will change the logic to set all pengind or running queries more than 6 hours old to failed.

[GitHub] codecov-io commented on issue #4833: [sqllab] Help sqllab forget query history

codecov-io commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-382534692 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4833?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4833: [sqllab] Help sqllab forget query history

john-bodley commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-382543787 @timifasubaa I wonder if `timedout` is more descriptive that `failed` since the later can mean multiple things.

[GitHub] hughhhh commented on a change in pull request #4836: Refactoring on exploreReducer.js

hug commented on a change in pull request #4836: Refactoring on exploreReducer.js URL: https://github.com/apache/incubator-superset/pull/4836#discussion_r182546092 ## File path: superset/assets/javascripts/explore/reducers/exploreReducer.js ## @@ -5,77 +5,118 @@

[GitHub] timifasubaa commented on issue #4834: [WIP] Load async sql lab results early for Presto

timifasubaa commented on issue #4834: [WIP] Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-382529350 @john-bodley Updated both This is an automated

[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-382532775 Okay, I will change the logic to set all pending or running queries older than 6 hours old to failed.

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182575745 ## File path: superset/assets/javascripts/dashboard/actions/dashboard.js ## @@ -0,0

[GitHub] betodealmeida commented on a change in pull request #4821: Fix time granularity-related issues

betodealmeida commented on a change in pull request #4821: Fix time granularity-related issues URL: https://github.com/apache/incubator-superset/pull/4821#discussion_r182581875 ## File path: superset/models/core.py ## @@ -786,7 +786,12 @@ def grains(self):

[GitHub] john-bodley closed pull request #4829: [import csv] ensure directory exists before saving csv file

john-bodley closed pull request #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] john-bodley closed issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'

john-bodley closed issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576 This is an automated message from

[GitHub] abowden-spotx commented on issue #4747: [WiP] Download Dashboards as PDF

abowden-spotx commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-382427457 Ultimately, the goal of this addition is so that we can integrate it with an emailing feature that will run independently on the

[GitHub] hughhhh commented on issue #4836: Refactoring on exploreReducer.js

hug commented on issue #4836: Refactoring on exploreReducer.js URL: https://github.com/apache/incubator-superset/pull/4836#issuecomment-382525145 I was following the same pattern for the Object.assign which is merging state and controls together. I've refactored it using the spread

[GitHub] hughhhh commented on issue #4836: Refactoring on exploreReducer.js

hug commented on issue #4836: Refactoring on exploreReducer.js URL: https://github.com/apache/incubator-superset/pull/4836#issuecomment-382525145 I was following the same pattern for the Object.assign which is merging state and controls together. I've refactored it using the spread

[GitHub] Tresdon commented on issue #4725: [WIP] Add "Published" feature to dashboards

Tresdon commented on issue #4725: [WIP] Add "Published" feature to dashboards URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-382530870 Hey @daniel5001 , This feature is still in the works and hasn't been forgotten, I'm currently working on ironing out a

[GitHub] john-bodley commented on issue #4833: [sqllab] Help sqllab forget query history

john-bodley commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-382543787 @timifasubaa I wonder if `timeout` or maybe `timedout`(past tense) is more descriptive that `failed` since the later can mean

[GitHub] john-bodley commented on issue #4834: [WIP] Load async sql lab results early for Presto

john-bodley commented on issue #4834: [WIP] Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-382476044 @timifasubaa if you update your description the following [keywords](

[GitHub] hughhhh commented on a change in pull request #4836: [WIP] Refactoring on exploreReducer.js

hug commented on a change in pull request #4836: [WIP] Refactoring on exploreReducer.js URL: https://github.com/apache/incubator-superset/pull/4836#discussion_r182546092 ## File path: superset/assets/javascripts/explore/reducers/exploreReducer.js ## @@ -5,77 +5,118

[GitHub] codecov-io commented on issue #4836: [WIP] Refactoring on exploreReducer.js

codecov-io commented on issue #4836: [WIP] Refactoring on exploreReducer.js URL: https://github.com/apache/incubator-superset/pull/4836#issuecomment-382512749 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4836?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4833: [sqllab] Help sqllab forget query history

john-bodley commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-382474470 I agree with @mistercrunch it would be great to change the state in the `queries` table for clarity and auditing purposes.

[GitHub] codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file

codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829#issuecomment-381390257 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4829?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4829: [import csv] ensure directory exists before saving csv file

john-bodley commented on issue #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829#issuecomment-382473280 @timifasubaa if you rebase your change the CI should succeed.

[GitHub] john-bodley commented on issue #4834: [WIP] Load async sql lab results early for Presto

john-bodley commented on issue #4834: [WIP] Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-382475362 @timifasubaa would you mind including screenshots and/or an animated gif (you can use LICEcap to record a video) to

[GitHub] john-bodley commented on issue #4834: [WIP] Load async sql lab results early for Presto

john-bodley commented on issue #4834: [WIP] Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-382475362 @timifasubaa would you mind including screenshots and/or an animated gif (you can use LICEcap to record a video) to

[GitHub] deshpand commented on issue #3312: Proposal: make single sign on and other auth/authn easier by removing Flask AppBuilder

deshpand commented on issue #3312: Proposal: make single sign on and other auth/authn easier by removing Flask AppBuilder URL: https://github.com/apache/incubator-superset/issues/3312#issuecomment-382481725 I have researching both superset and airflow for adoption at my enterprise

[GitHub] deshpand commented on issue #3312: Proposal: make single sign on and other auth/authn easier by removing Flask AppBuilder

deshpand commented on issue #3312: Proposal: make single sign on and other auth/authn easier by removing Flask AppBuilder URL: https://github.com/apache/incubator-superset/issues/3312#issuecomment-382481725 I have been researching both superset and airflow for adoption at my enterprise

[GitHub] sevalo8 commented on issue #4205: Ability to save default values to Dashboard filter

sevalo8 commented on issue #4205: Ability to save default values to Dashboard filter URL: https://github.com/apache/incubator-superset/issues/4205#issuecomment-382323853 Hi @graceguo-supercat , i try as the animation that you share, but why the filter still not set as when i klik di

[GitHub] sekikn opened a new pull request #4844: [docs] minor fix for the setup document

sekikn opened a new pull request #4844: [docs] minor fix for the setup document URL: https://github.com/apache/incubator-superset/pull/4844 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] codecov-io commented on issue #4844: [docs] minor file name and format fix for the setup document

codecov-io commented on issue #4844: [docs] minor file name and format fix for the setup document URL: https://github.com/apache/incubator-superset/pull/4844#issuecomment-382605435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4844?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4844: [docs] minor file name and format fix for the setup document

codecov-io commented on issue #4844: [docs] minor file name and format fix for the setup document URL: https://github.com/apache/incubator-superset/pull/4844#issuecomment-382605435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4844?src=pr=h1) Report > Merging

[GitHub] vnnw commented on issue #4734: Issue with Group by and columns in Pivot Table Viz

vnnw commented on issue #4734: Issue with Group by and columns in Pivot Table Viz URL: https://github.com/apache/incubator-superset/issues/4734#issuecomment-382604509 Same problem here. This is an automated message from the

[GitHub] codecov-io commented on issue #4844: [docs] minor file name and format fix for the setup document

codecov-io commented on issue #4844: [docs] minor file name and format fix for the setup document URL: https://github.com/apache/incubator-superset/pull/4844#issuecomment-382605435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4844?src=pr=h1) Report > Merging

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182587270 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -3,81

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182590121 ## File path: superset/assets/javascripts/dashboard/reducers/sliceEntities.js ## @@ -0,0

[GitHub] mistercrunch closed pull request #4821: Fix time granularity-related issues

mistercrunch closed pull request #4821: Fix time granularity-related issues URL: https://github.com/apache/incubator-superset/pull/4821 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] codecov-io commented on issue #4842: Cleaning html tags from text

codecov-io commented on issue #4842: Cleaning html tags from text URL: https://github.com/apache/incubator-superset/pull/4842#issuecomment-382559635 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4842?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4842: Cleaning html tags from text

codecov-io commented on issue #4842: Cleaning html tags from text URL: https://github.com/apache/incubator-superset/pull/4842#issuecomment-382559635 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4842?src=pr=h1) Report > Merging

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182586938 ## File path: superset/assets/javascripts/dashboard/actions/sliceEntities.js ## @@ -0,0

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182589479 ## File path: superset/assets/javascripts/dashboard/reducers/initState.js ## @@ -0,0

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182589375 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,29 @@

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182589335 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,29 @@

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182589899 ## File path: superset/assets/javascripts/dashboard/reducers/initState.js ## @@ -0,0

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182590044 ## File path: superset/assets/javascripts/dashboard/reducers/initState.js ## @@ -0,0

[GitHub] michellethomas opened a new pull request #4842: Cleaning html tags from text

michellethomas opened a new pull request #4842: Cleaning html tags from text URL: https://github.com/apache/incubator-superset/pull/4842 There are a few cases where we are using d3.html() which intentionally doesn't escape html. In these cases if a user has data with html tags we are not

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182590483 ## File path: superset/assets/javascripts/dashboard/util/dashboardLayoutConverter.js ##

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182586821 ## File path: superset/assets/javascripts/dashboard/actions/sliceEntities.js ## @@ -0,0

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182587996 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182587996 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r18251 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,37 +8,19 @@ import

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182588953 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,37 +8,19 @@ import

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182589180 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182590412 ## File path: superset/assets/javascripts/dashboard/util/dashboardLayoutConverter.js ##

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182594611 ## File path: superset/assets/stylesheets/dashboard.less ## @@ -0,0 +1,260 @@ +@import

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182594505 ## File path: superset/assets/stylesheets/dashboard.less ## @@ -0,0 +1,260 @@ +@import

[GitHub] williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments

williaster commented on a change in pull request #4839: Dashboard builder: fixed 1st round comments URL: https://github.com/apache/incubator-superset/pull/4839#discussion_r182594611 ## File path: superset/assets/stylesheets/dashboard.less ## @@ -0,0 +1,260 @@ +@import

[GitHub] Neuliaus closed issue #4818: Viz Plugins and Widget Set

Neuliaus closed issue #4818: Viz Plugins and Widget Set URL: https://github.com/apache/incubator-superset/issues/4818 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] williaster opened a new pull request #4843: [formats] add better defaults for time + number formatting

williaster opened a new pull request #4843: [formats] add better defaults for time + number formatting URL: https://github.com/apache/incubator-superset/pull/4843 This PR is all about making better default for time + number formatting  It adds: - a more concise multi-format tick

[GitHub] qin4zhang commented on issue #4840: ldap configuration

qin4zhang commented on issue #4840: ldap configuration URL: https://github.com/apache/incubator-superset/issues/4840#issuecomment-382585378 OK, thanks. This is an automated message from the Apache Git Service. To respond to