[GitHub] codecov-io commented on issue #4909: [Explore] Adding Adhoc Filters

codecov-io commented on issue #4909: [Explore] Adding Adhoc Filters URL: https://github.com/apache/incubator-superset/pull/4909#issuecomment-385514806 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4909?src=pr=h1) Report > Merging

[GitHub] ttannis commented on a change in pull request #4760: URL shortner for dashboards

ttannis commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r185122682 ## File path: superset/assets/javascripts/explore/components/ExploreViewContainer.jsx ## @@ -157,27 +151,6

[GitHub] john-bodley commented on issue #4740: Add extraction function support for Druid queries

john-bodley commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385579265 @mistercrunch I don't believe we use extraction functions in any of the Druid clusters connected to Superset (per a

[GitHub] codecov-io commented on issue #4910: Use React.PureComponent everywhere

codecov-io commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385572529 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=h1) Report > Merging

[GitHub] mistercrunch opened a new pull request #4910: Use React.PureComponent everywhere

mistercrunch opened a new pull request #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910 s/React.Component/React.PureComponent/g Did a bit of manual testing but I think we've had good hygiene of not mutating props. This should

[GitHub] betodealmeida opened a new pull request #4911: Fix for week_start_sunday and week_ending_saturday

betodealmeida opened a new pull request #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911 The granularity options `week_ending_saturday` ("truncate forward til next Saturday") and `week_start_sunday` ("truncate back til

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

mistercrunch commented on a change in pull request #4760: URL shortner for dashboards URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r185149117 ## File path: superset/assets/javascripts/explore/components/ExploreViewContainer.jsx ## @@ -157,27

[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries

jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385596164 We currently don't use extraction functions either. This may have already been answered, but I'm curious why

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

mistercrunch commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385571371 @fabianmenges @john-bodley I'm identifying this PR as something that could break things in your environment but I

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging

[GitHub] fabianmenges commented on issue #4740: Add extraction function support for Druid queries

fabianmenges commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385575931 Ack, will do. This is an automated message from the

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4740: Add extraction function support for Druid queries

codecov-io commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-378676086 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=h1) Report > Merging

[GitHub] mistercrunch opened a new issue #4912: Missing predefined metrics options in MetricsControls

mistercrunch opened a new issue #4912: Missing predefined metrics options in MetricsControls URL: https://github.com/apache/incubator-superset/issues/4912 @GabeLoins I noticed that many of the basic predefined metrics are not showing up in the dropdowns. This is easy to reproduce with

[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday

codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging

[GitHub] mistercrunch closed pull request #4907: translations: rename pt_BR gettext files

mistercrunch closed pull request #4907: translations: rename pt_BR gettext files URL: https://github.com/apache/incubator-superset/pull/4907 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mistercrunch closed pull request #4906: requirements: bump gunicorn to 19.8.0

mistercrunch closed pull request #4906: requirements: bump gunicorn to 19.8.0 URL: https://github.com/apache/incubator-superset/pull/4906 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mistercrunch commented on a change in pull request #4908: Replace NaN/Infinity with null

mistercrunch commented on a change in pull request #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#discussion_r185031456 ## File path: superset/views/core.py ## @@ -2435,7 +2436,7 @@ def sql_json(self):

[GitHub] williaster commented on issue #4893: add sticky to sidepane

williaster commented on issue #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#issuecomment-385475575 Going through the code now but some UI/UX thoughts (cc @elibrumbaugh): - the sidebar should always be the full height of the screen (see

[GitHub] SpyderRivera commented on issue #4812: Filter by lookup

SpyderRivera commented on issue #4812: Filter by lookup URL: https://github.com/apache/incubator-superset/issues/4812#issuecomment-382020998 Did you check the "filter" box in the dimension creation screen? This is an

[GitHub] williaster commented on issue #4905: [wip][missing values] Removing replacing missing values

williaster commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385473973 I think that option 1 above is the best^ it's super misleading to have nulls replaced with 0s, and if you

[GitHub] williaster commented on issue #4893: add sticky to sidepane

williaster commented on issue #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#issuecomment-385475575 Going through the code now but some UI/UX thoughts (cc @elibrumbaugh): - the sidebar should always be the full height of the screen (see

[GitHub] williaster commented on issue #4893: add sticky to sidepane

williaster commented on issue #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#issuecomment-385480121 - the builder pane Title should be `"Insert components"` instead of `"Add"` - the transition on the css also seems off a bit, when you go back

[GitHub] GabeLoins opened a new pull request #4909: [Explore] Adding Adhoc Filters

GabeLoins opened a new pull request #4909: [Explore] Adding Adhoc Filters URL: https://github.com/apache/incubator-superset/pull/4909 Here I'm following a similar design pattern as Adhoc Metrics (https://github.com/apache/incubator-superset/pull/4663 and

[GitHub] SpyderRivera commented on issue #4812: Filter by lookup

SpyderRivera commented on issue #4812: Filter by lookup URL: https://github.com/apache/incubator-superset/issues/4812#issuecomment-385459832 I am getting similar results for Druid data sources only I didn't realize it until I tried to look at the == results instead on !=. I'm on version

[GitHub] SpyderRivera commented on issue #4812: Filter by lookup

SpyderRivera commented on issue #4812: Filter by lookup URL: https://github.com/apache/incubator-superset/issues/4812#issuecomment-385459832 I am getting similar results for Druid data sources only I didn't realize it until I tried to look at the == results instead on !=. I'm on version

[GitHub] betodealmeida commented on issue #4819: Visualization for multiple line charts

betodealmeida commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-385463031 @mistercrunch, I removed the SQL and filter controls in the last commit. I'll do a separate PR handling them properly,

[GitHub] john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values

john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385464671 @mistercrunch this PR is very much WIP as I need to go through each visualization type and update the logic

[GitHub] mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values

mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385468553 Glad you're taking this on! I've had some conversations with @betodealmeida about sorting some of this out.

[GitHub] mistercrunch closed pull request #4897: Heatmap improvements

mistercrunch closed pull request #4897: Heatmap improvements URL: https://github.com/apache/incubator-superset/pull/4897 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] codecov-io commented on issue #4908: Replace NaN/Infinity with null

codecov-io commented on issue #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#issuecomment-385454285 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on a change in pull request #4905: [wip][missing values] Removing replacing missing values

mistercrunch commented on a change in pull request #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#discussion_r185045726 ## File path: superset/viz.py ## @@ -961,7 +936,6 @@ def as_floats(field):

[GitHub] SpyderRivera commented on issue #4812: Filter by lookup

SpyderRivera commented on issue #4812: Filter by lookup URL: https://github.com/apache/incubator-superset/issues/4812#issuecomment-385459832 I am getting similar results for Druid data sources only I didn't realize it until I tried to look at the == results instead on !=. I'm on version

[GitHub] codecov-io commented on issue #4908: Replace NaN/Infinity with null

codecov-io commented on issue #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#issuecomment-385454285 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4908: Replace NaN/Infinity with null

codecov-io commented on issue #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#issuecomment-385454285 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4908: Replace NaN/Infinity with null

codecov-io commented on issue #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#issuecomment-385454285 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=h1) Report > Merging

[GitHub] mistercrunch closed pull request #4883: Add note about 0.25.0 upgrade in UPDATING.md

mistercrunch closed pull request #4883: Add note about 0.25.0 upgrade in UPDATING.md URL: https://github.com/apache/incubator-superset/pull/4883 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] mistercrunch commented on a change in pull request #4905: [wip][missing values] Removing replacing missing values

mistercrunch commented on a change in pull request #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#discussion_r185045338 ## File path: superset/viz.py ## @@ -123,24 +122,6 @@ def

[GitHub] mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values

mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385461702 Some visualizations may not handle NULL properly, I'd double check that they do prior to pushing this.

[GitHub] calve commented on issue #4390: Fix 4 security vulnerabilities

calve commented on issue #4390: Fix 4 security vulnerabilities URL: https://github.com/apache/incubator-superset/pull/4390#issuecomment-385464980 hi, would you consider requesting a CVE for those vulnerabilities to inform users ?

[GitHub] betodealmeida commented on a change in pull request #4908: Replace NaN/Infinity with null

betodealmeida commented on a change in pull request #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#discussion_r185049884 ## File path: superset/views/core.py ## @@ -2435,7 +2436,7 @@ def sql_json(self):

[GitHub] ghulands commented on issue #4875: Add support for druid in cache flushing handler

ghulands commented on issue #4875: Add support for druid in cache flushing handler URL: https://github.com/apache/incubator-superset/pull/4875#issuecomment-385466729 The warm_up_cache handler only supported the sql connector. This implements support for the native druid connector.

[GitHub] john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values

john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385464671 @mistercrunch this PR is very much WIP as I need to go through each visualization type and update the logic

[GitHub] john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values

john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385464671 @mistercrunch this PR is very much WIP as I need to go through each visualization type and update the logic