GitHub user stain opened a pull request:
https://github.com/apache/incubator-taverna-maven-parent/pull/1
Update README.md
this pull request is meant to test github/apache integration.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-language/pull/2#issuecomment-112598857
Could you resolve the merge conflict first? You will need to do something
like:
```
git remote add upstream
https://github.com/apache
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-language/pull/20#issuecomment-128065222
Thanks!
Are you able to modify `ValidatorTest` a bit?
Instead of:
private Path path =
Paths.get(src/test/resources
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/23#discussion_r36632957
--- Diff:
taverna-robundle/src/test/java/org/apache/taverna/robundle/validator/ValidatorTest.java
---
@@ -21,23 +21,45
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/23#discussion_r36632858
--- Diff:
taverna-robundle/src/test/java/org/apache/taverna/robundle/validator/ValidatorTest.java
---
@@ -21,23 +21,45
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-language/pull/13#issuecomment-120924797
Great! Could you see if you are able to avoid these errors, and I'll accept.
Instead of `/home/menaka`, try to use `src/test/resources
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-language/pull/15#issuecomment-121197604
This was merged, but @asfgit somehow forgot to close this issue. Could you
close it for me, @binfalse ?
---
If your project is set up for it, you can
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/4
Looks good! You are adding cwl-logo-header.png, which has an [incompatible
license](https://github.com/common-workflow-language/logo/blob/master/LICENSE.md).
Could
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/4#discussion_r65908799
--- Diff:
taverna-cwl-activity-ui/src/test/java/org/apache/taverna/cwl/ui/TestWorkBench.java
---
@@ -0,0 +1,11 @@
+package
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/4#discussion_r65908687
--- Diff:
taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProviderConfig.java
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/6
@ThilinaManamgoda, as I merged #7, could you close this pull request?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/3
@NadeeshDilanga if this pull request is now superseded by the merged #5,
could you close this? Thanks!
---
If your project is set up for it, you can reply to this email
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/6
Thanks!
Could you do the pull request against the `cwl-browse` branch on the
apache-side? Now I get all the earlier commits as well as a branch conflict
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/8#discussion_r68400482
--- Diff:
taverna-docker-activity/src/test/java/org/apache/taverna/activities/docker/test/TestDockerCommands.java
---
@@ -0,0
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/18#discussion_r68405092
--- Diff: app/build.gradle ---
@@ -59,4 +61,7 @@ dependencies {
exclude module: 'stax-api'
exclude module: 'xpp3
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/18#discussion_r68405148
--- Diff: app/build.gradle ---
@@ -40,6 +40,8 @@ dependencies {
compile 'com.squareup.retrofit2:retrofit:2.0.2
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/8
Thanks!
Checking docker-java license:
https://github.com/docker-java/docker-java/blob/master/LICENSE
Apache License 2.0
(OK)
---
If your project is set
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/3
Hi, I'm OK with incremental pull requests, but the problem is that if you
have multiple open pull requests from the same branch, then they are
effectively the same pull
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/8
Thanks! Merged into the `docker` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-language/pull/26#issuecomment-177878788
Thanks - also I've updated the [jenkins
job](https://builds.apache.org/job/incubator-taverna-language-pull-requests/4/)
- the error was not caused
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-server/pull/1#issuecomment-194788068
Well spotted! Thank you for the pull request, @gmlewis! I've raised it as
https://issues.apache.org/jira/browse/TAVERNA-934 as I think we need to upgrade
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/1#issuecomment-216285700
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/1#issuecomment-216285840
Remember to pull as I also merged latest `master`
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/1#issuecomment-215347367
Yes, this looks OK - except you are committing an extra `Readme.md~` -
Emacs backup file?
Now could you try to remove that locally
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-commandline/pull/1#issuecomment-217624611
Right, we will have to make those download pages, so they should work by
the time the release is out. Perhaps prepare them on staging? We don't
Github user stain closed the pull request at:
https://github.com/apache/incubator-taverna-plugin-gis/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r72437990
--- Diff:
taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProvider.java
---
@@ -16,72
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70511985
--- Diff:
taverna-cwl-activity/src/main/java/org/apache/taverna/cwl/CwlActivityFactory.java
---
@@ -0,0 +1,102
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70512153
--- Diff:
taverna-cwl-activity/src/main/java/org/apache/taverna/cwl/CwlActivityFactory.java
---
@@ -0,0 +1,102
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70512455
--- Diff:
taverna-cwl-activity/src/main/java/org/apache/taverna/cwl/CwlActivityFactory.java
---
@@ -0,0 +1,102
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70512633
--- Diff:
taverna-cwl-activity/src/main/resources/META-INF/spring/cwl-activity-context.xml
---
@@ -0,0 +1,29
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70512846
--- Diff: taverna-cwl-utilities/CWLFiles/customtool1.cwl ---
@@ -0,0 +1,67
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70512965
--- Diff:
taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/CWLUtil.java
---
@@ -0,0 +1,216 @@
+package
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70513304
--- Diff:
taverna-cwl-utilities/src/test/java/org/apache/taverna/cwl/utilities/CWLUtilTest.java
---
@@ -0,0 +1,122
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/13
Thank you for showing your progress!
I've left lots of comments under "Files changed" in the pull request -
don't be discouraged! Sorry I hadn't rev
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/10
As this pull request seems to be a smaller part of #9, see my comments
there.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/12
As this pull request seems to be a smaller part of #9, see my comments
there.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/11
As this pull request seems to be a smaller part of #9, see my comments
there.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-workbench/pull/5
Thanks! Merged.
@ThilinaManamgoda, would you be OK to close
https://issues.apache.org/jira/browse/TAVERNA-989 and reference this pull
request in the comments
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70509151
--- Diff:
taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceDesc.java
---
@@ -16,79
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70511457
--- Diff:
taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/Testing.java
---
@@ -18,141 +18,63
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70508895
--- Diff: taverna-cwl-activity-ui/pom.xml ---
@@ -65,27 +60,45
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70509966
--- Diff:
taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceDesc.java
---
@@ -16,79
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70511075
--- Diff:
taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProvider.java
---
@@ -16,72
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/9#discussion_r70264628
--- Diff: taverna-docker-activity/pom.xml ---
@@ -108,19 +124,14 @@
org.apache.taverna.engine
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-workbench/pull/5#discussion_r70263887
--- Diff: taverna-activity-palette-impl/pom.xml ---
@@ -92,7 +94,7 @@
org.apache.taverna.osgi
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/9
This fails `mvn clean install` with:
```
testLogin(org.apache.taverna.activities.docker.test.TestDockerCommands)
Time elapsed: 0.025 sec <<&
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/20
Thanks, @mr-c! But does this not mean that
https://github.com/common-workflow-language/common-workflow-language/blob/master/site/CWL-Logo-Header.png
is a redistribution
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/20
@ThilinaManamgoda if the
https://github.com/common-workflow-language/common-workflow-language/blob/master/site/CWL-Logo-Header.png
logo is truly still under LGPL and CC
GitHub user stain opened a pull request:
https://github.com/apache/incubator-taverna-language/pull/35
TAVERNA-1011 Add DataBundles.resolve() and DataBundles.resolveAsStream()
As suggested in
[TAVERNA-1011](https://issues.apache.org/jira/browse/TAVERNA-1011):
Adds two
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-workbench/pull/6#discussion_r78780176
--- Diff: NOTICE ---
@@ -118,3 +118,14 @@
taverna-ui/src/main/java/org/apache/taverna/lang/ui/treetable/
for use in the design
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-language/pull/34
Thanks! Sorry for the delay.. now merged both pull requests.
Perhaps you would like to tell
[dev@taverna](https://lists.apache.org/list.html?d...@taverna.apache.org) about
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-workbench/pull/6#discussion_r78481938
--- Diff:
taverna-perspective-biocatalogue/src/main/resources/net/sf/taverna/t2/ui/perspectives/biocatalogue/biocatalogue_styles.css
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-workbench/pull/6#discussion_r78482070
--- Diff: NOTICE ---
@@ -118,3 +118,14 @@
taverna-ui/src/main/java/org/apache/taverna/lang/ui/treetable/
for use in the design
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-workbench/pull/7
This pull request includes changes that are no longer relevant after we
moved out biocatalogue perspective. (Also I am not sure how we found it was
the WTF license for those gifs
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/21
Conclusion from general@incubator seems to be that we need to license it as
CC-SA only - but that we could add a note that it's also available as LGPL from
upstream
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-workbench/pull/6#discussion_r79946640
--- Diff:
taverna-perspective-biocatalogue/src/main/resources/net/sf/taverna/t2/ui/perspectives/biocatalogue/biocatalogue_styles.css
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-workbench/pull/6
I merged this after reverting some of the files so it can appear in
https://github.com/taverna-extras/taverna-perspective-biocatalogue.
Please check your global git config
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/21#discussion_r80018066
--- Diff: LICENSE ---
@@ -210,3 +210,16 @@
http://www.w3.org/Consortium/Legal/copyright-software-19980720
is Public Domain
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/21
Thanks!
I've asked on
[general@incubator](https://lists.apache.org/thread.html/301c38a3d779d53d3a070b36f7df8c483f2dd3cdcb9e374fc3f83dae
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/28#discussion_r81539219
--- Diff:
app/src/main/java/org/apache/taverna/mobile/data/local/PreferencesHelper.java
---
@@ -49,11 +52,19 @@
private
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112027060
--- Diff:
taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/preprocessing/ImportData.java
---
@@ -0,0 +1,26
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112638582
--- Diff: .gitignore ---
@@ -8,3 +8,101 @@ Testing.java
# remove emacs
*~
+
+# Created by https
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112027115
--- Diff:
taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/preprocessing/ImportNode.java
---
@@ -0,0 +1,31
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112638360
--- Diff:
taverna-cwl-utilities/src/test/resources/preprocessing/ImportResoultionUtil-processNode-Method/processNode.yaml
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112030157
--- Diff:
taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/preprocessing/LinkedResolutionUtil.java
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112638431
--- Diff:
taverna-cwl-utilities/src/test/resources/preprocessing/serverContent/import.yaml
---
@@ -0,0 +1,3 @@
+hello
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112029624
--- Diff:
taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/preprocessing/LinkedResolutionUtil.java
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112027630
--- Diff:
taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/preprocessing/ImportNodeImpl.java
---
@@ -0,0
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112638183
--- Diff: taverna-cwl-utilities/src/test/resources/log4j.properties ---
@@ -0,0 +1,16 @@
+# Root logger option
--- End
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112027195
--- Diff:
taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/preprocessing/CwlPreprocessor.java
---
@@ -0,0
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112637921
--- Diff:
taverna-cwl-utilities/src/test/java/org/apache/taverna/cwl/utilities/preprocessing/ImportResolutionUtilTest.java
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/24#discussion_r112029419
--- Diff:
taverna-cwl-utilities/src/main/java/org/apache/taverna/cwl/utilities/preprocessing/ImportViaHTTP.java
---
@@ -0,0
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-engine/pull/4
Thanks, Chalana! Sorry this got missed earlier.
I have merged and closed TAVERNA-977. I added fixed plugin versions for the
archetype to silence the remaining warnings.
---
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-server/pull/5
@justinmclean suggest this PR is good solution [on
legal-discuss](https://lists.apache.org/thread.html/c789d855ad60a0fecec0681b600a2710549c2c2a8d162421b2728884@%3Clegal
GitHub user stain opened a pull request:
https://github.com/apache/incubator-taverna-server/pull/5
Moved copyright notices to META-INF/LICENSE.*
On genera@incubator, [Justin
commented](https://lists.apache.org/thread.html/78aa01f01b377e0d1fae38706ab94c51380ee10fad89cd2ee5c8a5a0
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-language/pull/37
This is a workaround for
[JENA-1462](https://issues.apache.org/jira/browse/JENA-1462) - as that is
present in jena 3.3 --> 3.6 I think this is the best solution for now.
---
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-server/pull/4
Thanks. I am not sure why we even need persistence_1_.0.xsd - everything
works without it and it's not present in the final WAR. So I removed this file
and will close this PR.
---
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/38#discussion_r196754088
--- Diff:
taverna-scufl2-cwl/src/test/java/org/apache/taverna/scufl2/cwl/TestParser.java
---
@@ -0,0 +1,96 @@
+package
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/38#discussion_r196747756
--- Diff:
taverna-scufl2-cwl/src/test/java/org/apache/taverna/scufl2/cwl/TestParser.java
---
@@ -0,0 +1,96 @@
+package
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/38#discussion_r196753530
--- Diff:
taverna-scufl2-cwl/src/test/java/org/apache/taverna/scufl2/cwl/TestParser.java
---
@@ -0,0 +1,96 @@
+package
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/38#discussion_r196753724
--- Diff:
taverna-scufl2-cwl/src/test/java/org/apache/taverna/scufl2/cwl/TestParser.java
---
@@ -0,0 +1,96 @@
+package
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/38#discussion_r196754260
--- Diff: taverna-scufl2-cwl/src/test/resources/1st-tool.cwl ---
@@ -0,0 +1,10 @@
+cwlVersion: v1.0
--- End diff
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/41#discussion_r208318505
--- Diff:
taverna-scufl2-api/src/main/java/org/apache/taverna/scufl2/api/common/Scufl2Tools.java
---
@@ -764,6 +764,12 @@ public
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/41#discussion_r208319161
--- Diff:
taverna-scufl2-api/src/test/java/org/apache/taverna/scufl2/api/common/TestScufl2Tools.java
---
@@ -63,6 +64,25 @@ public void
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/41#discussion_r208521372
--- Diff:
taverna-scufl2-api/src/test/java/org/apache/taverna/scufl2/api/common/TestScufl2Tools.java
---
@@ -81,19 +82,13 @@ public void
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/41#discussion_r208521155
--- Diff:
taverna-scufl2-api/src/test/java/org/apache/taverna/scufl2/api/common/TestScufl2Tools.java
---
@@ -51,6 +51,7 @@
import
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/41#discussion_r208521198
--- Diff:
taverna-scufl2-api/src/test/java/org/apache/taverna/scufl2/api/common/TestScufl2Tools.java
---
@@ -63,6 +64,25 @@ public void
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/41#discussion_r207914837
--- Diff:
taverna-scufl2-api/src/test/java/org/apache/taverna/scufl2/api/common/TestScufl2Tools.java
---
@@ -63,6 +64,25 @@ public void
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/41#discussion_r207915625
--- Diff:
taverna-scufl2-api/src/main/java/org/apache/taverna/scufl2/api/common/Scufl2Tools.java
---
@@ -752,6 +753,30 @@ public Activity
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/41#discussion_r207896106
--- Diff:
taverna-scufl2-api/src/main/java/org/apache/taverna/scufl2/api/common/Scufl2Tools.java
---
@@ -752,6 +753,30 @@ public Activity
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/42#discussion_r209235462
--- Diff:
taverna-scufl2-cwl/src/main/java/org/apache/taverna/scufl2/cwl/CWLParser.java
---
@@ -22,16 +22,10 @@
import java.util.Set
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/42#discussion_r209235950
--- Diff:
taverna-scufl2-cwl/src/main/java/org/apache/taverna/scufl2/cwl/components/CommandLineTool.java
---
@@ -17,7 +17,7
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-language/pull/40
I think you meant to raise the pull request against branch `cwlparser` so I
have merged it there. However I think the new module is at a good stage to add
into `master` anyway, so
Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-language/pull/39
Sorry, as I saw Jenkins fail this test (for no reason) I merged #40 first.
Would you be able to merge against `upstream/master` and fix the conflict?
BTW, Can you delete
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/39#discussion_r204713920
--- Diff: taverna-scufl2-cwl/taverna-scufl2-cwl.iml ---
@@ -0,0 +1,11 @@
+
--- End diff --
What is this file needed
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/39#discussion_r204712907
--- Diff:
taverna-scufl2-cwl/src/test/java/org/apache/taverna/scufl2/cwl/TestWorkflowProcess.java
---
@@ -0,0 +1,135
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/39#discussion_r204713406
--- Diff: taverna-scufl2-cwl/workflow.t2flow.txt ---
@@ -0,0 +1,10 @@
+WorkflowBundle 'bundle1'
--- End diff --
I don't
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/39#discussion_r204713856
--- Diff: taverna-scufl2-cwl/workflow.wfbundle ---
@@ -0,0 +1,10 @@
+WorkflowBundle 'bundle1'
--- End diff --
This file
Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-language/pull/39#discussion_r201983894
--- Diff:
taverna-scufl2-cwl/src/main/java/org/apache/taverna/scufl2/cwl/components/CommandLineTool.java
---
@@ -0,0 +1,80
1 - 100 of 108 matches
Mail list logo
