[Bug 62670] driverManagerProtection in JreMemoryLeakPreventionListener results in java.sql.SQLException: No suitable driver found

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62670 --- Comment #7 from Padmanarayanan --- (In reply to Mark Thomas from comment #5) > Getting back to the original bug report... > > The behaviour described is expected when a JDBC driver is packaged in > WEB-INF/lib. The behaviour (and

Re: tomcat-native trunk

2018-09-03 Thread Mark Thomas
On 03/09/18 09:38, jean-frederic clere wrote: > Hi, > > I am working on a jar to laod the libraries in tomcat-native. I have > noted that the examples don't compile and that the test directory is > empty. I am planning to clean that and go for maven build for the new jar. > > Comments? Odd. The

[Bug 62670] driverManagerProtection in JreMemoryLeakPreventionListener results in java.sql.SQLException: No suitable driver found

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62670 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1839929 - /tomcat/native/trunk/java/org/apache/tomcat/

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 09:50:00 2018 New Revision: 1839929 URL: http://svn.apache.org/viewvc?rev=1839929=rev Log: Update external to latest 9.0.x jni code Modified: tomcat/native/trunk/java/org/apache/tomcat/ (props changed) Propchange: tomcat/native/trunk/java/org/apache/tomcat/

tomcat-native trunk

2018-09-03 Thread jean-frederic clere
Hi, I am working on a jar to laod the libraries in tomcat-native. I have noted that the examples don't compile and that the test directory is empty. I am planning to clean that and go for maven build for the new jar. Comments? -- Cheers Jean-Frederic

svn commit: r1839922 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml webapps/docs/jndi-datasource-ex

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 09:24:24 2018 New Revision: 1839922 URL: http://svn.apache.org/viewvc?rev=1839922=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62670 Adjust the memory leak protection for the DriverManager so that JDBC drivers located in $CATALINA_HOME/lib and

svn commit: r1839925 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml webapps/docs/jndi-da

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 09:27:33 2018 New Revision: 1839925 URL: http://svn.apache.org/viewvc?rev=1839925=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62670 Adjust the memory leak protection for the DriverManager so that JDBC drivers located in $CATALINA_HOME/lib and

svn commit: r1839923 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml webapps/docs/jndi-da

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 09:25:20 2018 New Revision: 1839923 URL: http://svn.apache.org/viewvc?rev=1839923=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62670 Adjust the memory leak protection for the DriverManager so that JDBC drivers located in $CATALINA_HOME/lib and

svn commit: r1839930 - in /tomcat/native/trunk: native/os/netware/ native/src/proc.c xdocs/miscellaneous/changelog.xml

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 09:54:19 2018 New Revision: 1839930 URL: http://svn.apache.org/viewvc?rev=1839930=rev Log: Remove Netware support Removed: tomcat/native/trunk/native/os/netware/ Modified: tomcat/native/trunk/native/src/proc.c

svn commit: r1839928 - in /tomcat/trunk: java/org/apache/tomcat/jni/OS.java java/org/apache/tomcat/jni/Procattr.java webapps/docs/changelog.xml

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 09:47:49 2018 New Revision: 1839928 URL: http://svn.apache.org/viewvc?rev=1839928=rev Log: Remove Netware support. Deprecate the public API that refers to Netware. Modified: tomcat/trunk/java/org/apache/tomcat/jni/OS.java

Tagging 9.0.x

2018-09-03 Thread Mark Thomas
Hi all, As the start of September is here I'm planning to tag 9.0.x (and 8.5.x) shortly and roll the next monthly release. I've a couple of things I want to look at first so I'll probably be tagging in the next day or two. What is the view on BZ 62667 (the rewrite issue). Is that a bug or an

[Bug 62670] driverManagerProtection in JreMemoryLeakPreventionListener results in java.sql.SQLException: No suitable driver found

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62670 --- Comment #8 from Mark Thomas --- Sure. I can include that in the doc updates. The short version is: - endorsed (where the JRE still supports it) is effectively the same as the system class path - using the shared loader (where it has been

Re: Tagging 9.0.x

2018-09-03 Thread Rémy Maucherat
On Mon, Sep 3, 2018 at 12:19 PM Mark Thomas wrote: > Hi all, > > As the start of September is here I'm planning to tag 9.0.x (and 8.5.x) > shortly and roll the next monthly release. > > I've a couple of things I want to look at first so I'll probably be > tagging in the next day or two. > > What

svn commit: r1839935 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 10:52:16 2018 New Revision: 1839935 URL: http://svn.apache.org/viewvc?rev=1839935=rev Log: On balance, I think keeping these methods separate is the better option due to: - easier to follow code - simpler maintenance - subtle differences between

[Bug 62667] RewriteMap not working with %{HTTP_HOST}

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62667 --- Comment #5 from Rainer Jung --- httpd mod_rewrite code seems to be recursive, but it contains the following a little cryptic comment: To make rewrite maps useful, the lookup key and default values must be expanded, so we make recursive

[Bug 62667] RewriteMap not working with %{HTTP_HOST}

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62667 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: tomcat-native trunk

2018-09-03 Thread Emmanuel Bourg
Le 03/09/2018 à 11:41, Mark Thomas a écrit : > No strong views on which build system to use but I will say that Gradle > might be worth a look. With my Debian maintainer hat on I have to say that Gradle is a real hindrance and I hope the Tomcat components will stay out of it. Gradle itself is a

[Bug 62667] RewriteMap not working with %{HTTP_HOST}

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62667 --- Comment #6 from Remy Maucherat --- Ok, so adding recursion works. I suppose maps are the only thing that need it, right ? -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1839955 - in /tomcat/trunk: java/org/apache/catalina/valves/rewrite/Substitution.java test/org/apache/catalina/valves/rewrite/TestRewriteValve.java webapps/docs/changelog.xml

2018-09-03 Thread remm
Author: remm Date: Mon Sep 3 12:54:34 2018 New Revision: 1839955 URL: http://svn.apache.org/viewvc?rev=1839955=rev Log: 62667: Add recursion for the parsing and evaluation of map keys and values. Modified: tomcat/trunk/java/org/apache/catalina/valves/rewrite/Substitution.java

Re: tomcat-native trunk

2018-09-03 Thread Rainer Jung
Am 03.09.2018 um 11:41 schrieb Mark Thomas: On 03/09/18 09:38, jean-frederic clere wrote: Hi, I am working on a jar to laod the libraries in tomcat-native. I have noted that the examples don't compile and that the test directory is empty. I am planning to clean that and go for maven build for

buildbot success in on tomcat-trunk

2018-09-03 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3554 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1839963 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/rewrite/ test/org/apache/catalina/valves/rewrite/ webapps/docs/

2018-09-03 Thread remm
Author: remm Date: Mon Sep 3 13:42:25 2018 New Revision: 1839963 URL: http://svn.apache.org/viewvc?rev=1839963=rev Log: 62667: Add recursion for the parsing and evaluation of map keys and values. Modified: tomcat/tc8.5.x/trunk/ (props changed)

[Bug 62408] (New feature) Make configurable the number of retries in case of upstream failures

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62408 --- Comment #4 from Frederik --- (Sorry for the late reply, just back from vacations) Thanks for the corrections, I'll keep your suggestions in mind for future submitions. Thanks again, F -- You are receiving this mail because: You are the

[Bug 62667] RewriteMap not working with %{HTTP_HOST}

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62667 --- Comment #8 from Rainer Jung --- (In reply to Remy Maucherat from comment #6) > Ok, so adding recursion works. I suppose maps are the only thing that need > it, right ? Yes, I think so. I didn't find another way to trigger recursion in

svn commit: r1839960 - in /tomcat/trunk/test/org/apache/catalina/valves/rewrite: TestRewriteValve.java TesterRewriteMapA.java

2018-09-03 Thread remm
Author: remm Date: Mon Sep 3 13:09:27 2018 New Revision: 1839960 URL: http://svn.apache.org/viewvc?rev=1839960=rev Log: Also add a test for the map key. Modified: tomcat/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java

Re: tomcat-native trunk

2018-09-03 Thread Mark Thomas
On 03/09/18 11:31, Rainer Jung wrote: > Am 03.09.2018 um 11:41 schrieb Mark Thomas: >> No strong views on which build system to use but I will say that Gradle >> might be worth a look. I do think that a build system should either be >> supported or completely removed. Having files lying around

Re: Tagging 9.0.x

2018-09-03 Thread Mark Thomas
On 03/09/18 11:40, Rémy Maucherat wrote: > On Mon, Sep 3, 2018 at 12:19 PM Mark Thomas wrote: > >> Hi all, >> >> As the start of September is here I'm planning to tag 9.0.x (and 8.5.x) >> shortly and roll the next monthly release. >> >> I've a couple of things I want to look at first so I'll

buildbot failure in on tomcat-trunk

2018-09-03 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3553 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Tagging 9.0.x

2018-09-03 Thread Rémy Maucherat
On Mon, Sep 3, 2018 at 12:53 PM Mark Thomas wrote: > On 03/09/18 11:40, Rémy Maucherat wrote: > > On Mon, Sep 3, 2018 at 12:19 PM Mark Thomas wrote: > > > >> Hi all, > >> > >> As the start of September is here I'm planning to tag 9.0.x (and 8.5.x) > >> shortly and roll the next monthly release.

svn commit: r1839989 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ssi/ResponseIncludeWrapper.java java/org/apache/catalina/ssi/SSIFilter.java java/org/apache/catalina/ssi/SSIServletExternal

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 19:20:36 2018 New Revision: 1839989 URL: http://svn.apache.org/viewvc?rev=1839989=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62669 When using the SSIFilter and a resource does not specify a content type, do not force the content type to

svn commit: r1839990 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/ssi/ResponseIncludeWrapper.java

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 19:20:54 2018 New Revision: 1839990 URL: http://svn.apache.org/viewvc?rev=1839990=rev Log: Simplify Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ssi/ResponseIncludeWrapper.java Modified:

[Bug 62669] ResponseIncludeWrapper.getContentType() never returns NULL and sets the field

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62669 --- Comment #2 from Mark Thomas --- I'm currently struggling to see why ResposneIncludeWrapper goes to the trouble it does to capture the content type and the last modified date. I worry I am missing something so I want to look at this some

[Bug 62669] ResponseIncludeWrapper.getContentType() never returns NULL and sets the field

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62669 --- Comment #3 from Sven --- I am not a maintainer or contributor to this project yet but I also suggestion to remove the wrapper. Currently I simply add another filter after SSIFilter that wraps the ResponseIncludeWrapper again and return

svn commit: r1839977 - in /tomcat/trunk/java/org/apache/catalina: Globals.java ssi/SSIFilter.java ssi/SSIServlet.java

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 17:58:46 2018 New Revision: 1839977 URL: http://svn.apache.org/viewvc?rev=1839977=rev Log: Remove / deprecate code originally added to enable the CGI Servlet to work as an include with SSI. The CGI servlet has generic handling for the include case and this flag is

Re: Tagging 9.0.x

2018-09-03 Thread Mark Thomas
On 03/09/18 14:47, Rémy Maucherat wrote: > On Mon, Sep 3, 2018 at 12:53 PM Mark Thomas wrote: > >> On 03/09/18 11:40, Rémy Maucherat wrote: >>> On Mon, Sep 3, 2018 at 12:19 PM Mark Thomas wrote: >>> Hi all, As the start of September is here I'm planning to tag 9.0.x (and 8.5.x)

Re: tomcat-native trunk

2018-09-03 Thread jean-frederic clere
On 03/09/18 12:31, Rainer Jung wrote: > Am 03.09.2018 um 11:41 schrieb Mark Thomas: >> On 03/09/18 09:38, jean-frederic clere wrote: >>> Hi, >>> >>> I am working on a jar to laod the libraries in tomcat-native. I have >>> noted that the examples don't compile and that the test directory is >>>

Re: Tagging 9.0.x

2018-09-03 Thread Eric Lilja
On 2018-09-03 12:19, Mark Thomas wrote: Hi all, As the start of September is here I'm planning to tag 9.0.x (and 8.5.x) shortly and roll the next monthly release. Hi! Will there be a new release of tomcat native to go with 9.0.x? - Eric L

Re: Tagging 9.0.x

2018-09-03 Thread Mark Thomas
On 03/09/18 17:30, Eric Lilja wrote: > On 2018-09-03 12:19, Mark Thomas wrote: >> Hi all, >> >> As the start of September is here I'm planning to tag 9.0.x (and 8.5.x) >> shortly and roll the next monthly release. >> > > Hi! Will there be a new release of tomcat native to go with 9.0.x? There is

svn commit: r1839983 - in /tomcat/trunk: java/org/apache/catalina/ssi/ResponseIncludeWrapper.java java/org/apache/catalina/ssi/SSIFilter.java java/org/apache/catalina/ssi/SSIServletExternalResolver.ja

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 19:08:53 2018 New Revision: 1839983 URL: http://svn.apache.org/viewvc?rev=1839983=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62669 When using the SSIFilter and a resource does not specify a content type, do not force the content type to

svn commit: r1839988 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/Globals.java java/org/apache/catalina/ssi/SSIFilter.java java/org/apache/catalina/ssi/SSIServlet.java

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 19:16:34 2018 New Revision: 1839988 URL: http://svn.apache.org/viewvc?rev=1839988=rev Log: Remove / deprecate code originally added to enable the CGI Servlet to work as an include with SSI. The CGI servlet has generic handling for the include case and this flag is

svn commit: r1839985 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/Globals.java java/org/apache/catalina/ssi/SSIFilter.java java/org/apache/catalina/ssi/SSIServlet.java

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 19:12:26 2018 New Revision: 1839985 URL: http://svn.apache.org/viewvc?rev=1839985=rev Log: Remove / deprecate code originally added to enable the CGI Servlet to work as an include with SSI. The CGI servlet has generic handling for the include case and this flag is

[Bug 62669] ResponseIncludeWrapper.getContentType() never returns NULL and sets the field

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62669 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1839986 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/ssi/ResponseIncludeWrapper.java java/org/apache/catalina/ssi/SSIFilter.java java/org/apache/catalina/ssi/SSIServletExternal

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 19:14:07 2018 New Revision: 1839986 URL: http://svn.apache.org/viewvc?rev=1839986=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62669 When using the SSIFilter and a resource does not specify a content type, do not force the content type to

svn commit: r1839987 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/ssi/ResponseIncludeWrapper.java

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 19:14:31 2018 New Revision: 1839987 URL: http://svn.apache.org/viewvc?rev=1839987=rev Log: Simplify Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/ssi/ResponseIncludeWrapper.java Propchange:

svn commit: r1839984 - /tomcat/trunk/java/org/apache/catalina/ssi/ResponseIncludeWrapper.java

2018-09-03 Thread markt
Author: markt Date: Mon Sep 3 19:10:08 2018 New Revision: 1839984 URL: http://svn.apache.org/viewvc?rev=1839984=rev Log: Simplify code Modified: tomcat/trunk/java/org/apache/catalina/ssi/ResponseIncludeWrapper.java Modified:

[Bug 62667] RewriteMap not working with %{HTTP_HOST}

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62667 --- Comment #9 from Felix Schumacher --- (In reply to Remy Maucherat from comment #7) > I added the "feature"/bugfix for 9.0.12 and 8.5.34. > > I have no idea what the language from the comment "For security reasons we > must never expand a

[Bug 62667] RewriteMap not working with %{HTTP_HOST}

2018-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62667 --- Comment #10 from Remy Maucherat --- Ok, then it's fine as there's no dynamic parsing. If "%{HTTP_HOST}" evaluates to "%{HTTP_HOST}", then it's the final result. -- You are receiving this mail because: You are the assignee for the bug.