Re: I would like to send a PR related to zookeeper C client
On Tue, Dec 6, 2022 at 11:50 AM Enrico Olivelli wrote: > > Christopher, > > Il giorno dom 4 dic 2022 alle ore 19:34 Christopher > ha scritto: > > > > It might be worth reconsidering the contributing "requirement" to make a > > JIRA ticket. A lot of JIRA tickets don't have useful information in them > > anyway... they are just being created because it's required, which is just > > extra work without benefits. The PR usually has more relevant information > > and can serve as its own ticket, in my opinion. > > I agree with you. > > Currently we require a JIRA because we can easily create release notes. > We could switch to GH issues, but that would require some help/work to > prepare a new > release procedure. (in my projects I am participating we switched to > GH issues, and actually > create release notes is quite a pain, even with some automation) I think the "release notes" that are generated by JIRA are not very valuable. At best, they are hardly better than the git history since the last release (`git log release-3.7.0..release-3.7.1 --oneline`) At worst, they are misleading because they are out of sync with the work that was actually committed, because the fixVersion in JIRA isn't always correct, or because the summary in JIRA doesn't reflect the final work that was done in the repository after code reviews and feedback. For more useful release notes, I prefer a human-curated list of important bits, with brief narratives explaining why users might care, and refer to the git history for the comprehensive list. This is what Apache Accumulo attempts to do (for example: https://accumulo.apache.org/release/accumulo-2.1.0/) > > Namjae > This is the guide to create a JIRA account > https://infra.apache.org/jira-guidelines.html#who > > We can create a JIRA account for you as soon as you provide the > requested information as reported in the document > > in the meantime I create a JIRA ticket for you, this is all you need > to tag your commit message propertly > https://issues.apache.org/jira/browse/ZOOKEEPER-4640 > > Enrico > > > > > On Sun, Dec 4, 2022, 12:12 Enrico Olivelli wrote: > > > > > Il Sab 3 Dic 2022, 18:57 Namjae Kim ha scritto: > > > > > > > Hi, I am Namjae Kim. > > > > > > > > I want to add version information to the file names of the libraries of > > > > zookeeper C client. I tried to create a JIRA ticket but it was not > > > > possible. > > > > > > > > My suggestion is to change the filename from `libzookeeper_mt.so.2` to > > > > `libzookeeper_mt-3.8.0.so.2`. > > > > > > > > How do I create a ticket or get a JIRA account? > > > > > > > > > > This is a good question. > > > Recently ASF JIRA disabled self subscribe due to too much spam. > > > > > > I can help you. > > > In the meantime (that I figure out how to crate your JIRA account) you can > > > send the PR > > > > > > Thanks > > > Enrico > > > > > > > > > > Thanks. > > > > > > > > Namjae Kim > > > > > > >
Re: I would like to send a PR related to zookeeper C client
This reminds me - I saw recently that Infra is sunsetting TravisCI. I think we added support for that a while back? I'm not sure clear on the details tbh. Whoever was involved - can you take a look? It seems like it's behind a gated page on cwiki, which lists ZK explicitly, if you can't access the page checkout this public ref I saw (the quoted section) https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA=Travis+Migrations https://www.mail-archive.com/dev@calcite.apache.org/msg19987.html Regards, Patrick On Tue, Dec 6, 2022 at 8:50 AM Enrico Olivelli wrote: > Christopher, > > Il giorno dom 4 dic 2022 alle ore 19:34 Christopher > ha scritto: > > > > It might be worth reconsidering the contributing "requirement" to make a > > JIRA ticket. A lot of JIRA tickets don't have useful information in them > > anyway... they are just being created because it's required, which is > just > > extra work without benefits. The PR usually has more relevant information > > and can serve as its own ticket, in my opinion. > > I agree with you. > > Currently we require a JIRA because we can easily create release notes. > We could switch to GH issues, but that would require some help/work to > prepare a new > release procedure. (in my projects I am participating we switched to > GH issues, and actually > create release notes is quite a pain, even with some automation) > > Namjae > This is the guide to create a JIRA account > https://infra.apache.org/jira-guidelines.html#who > > We can create a JIRA account for you as soon as you provide the > requested information as reported in the document > > in the meantime I create a JIRA ticket for you, this is all you need > to tag your commit message propertly > https://issues.apache.org/jira/browse/ZOOKEEPER-4640 > > Enrico > > > > > On Sun, Dec 4, 2022, 12:12 Enrico Olivelli wrote: > > > > > Il Sab 3 Dic 2022, 18:57 Namjae Kim ha scritto: > > > > > > > Hi, I am Namjae Kim. > > > > > > > > I want to add version information to the file names of the libraries > of > > > > zookeeper C client. I tried to create a JIRA ticket but it was not > > > > possible. > > > > > > > > My suggestion is to change the filename from `libzookeeper_mt.so.2` > to > > > > `libzookeeper_mt-3.8.0.so.2`. > > > > > > > > How do I create a ticket or get a JIRA account? > > > > > > > > > > This is a good question. > > > Recently ASF JIRA disabled self subscribe due to too much spam. > > > > > > I can help you. > > > In the meantime (that I figure out how to crate your JIRA account) you > can > > > send the PR > > > > > > Thanks > > > Enrico > > > > > > > > > > Thanks. > > > > > > > > Namjae Kim > > > > > > > >
Re: I would like to send a PR related to zookeeper C client
Christopher, Il giorno dom 4 dic 2022 alle ore 19:34 Christopher ha scritto: > > It might be worth reconsidering the contributing "requirement" to make a > JIRA ticket. A lot of JIRA tickets don't have useful information in them > anyway... they are just being created because it's required, which is just > extra work without benefits. The PR usually has more relevant information > and can serve as its own ticket, in my opinion. I agree with you. Currently we require a JIRA because we can easily create release notes. We could switch to GH issues, but that would require some help/work to prepare a new release procedure. (in my projects I am participating we switched to GH issues, and actually create release notes is quite a pain, even with some automation) Namjae This is the guide to create a JIRA account https://infra.apache.org/jira-guidelines.html#who We can create a JIRA account for you as soon as you provide the requested information as reported in the document in the meantime I create a JIRA ticket for you, this is all you need to tag your commit message propertly https://issues.apache.org/jira/browse/ZOOKEEPER-4640 Enrico > > On Sun, Dec 4, 2022, 12:12 Enrico Olivelli wrote: > > > Il Sab 3 Dic 2022, 18:57 Namjae Kim ha scritto: > > > > > Hi, I am Namjae Kim. > > > > > > I want to add version information to the file names of the libraries of > > > zookeeper C client. I tried to create a JIRA ticket but it was not > > > possible. > > > > > > My suggestion is to change the filename from `libzookeeper_mt.so.2` to > > > `libzookeeper_mt-3.8.0.so.2`. > > > > > > How do I create a ticket or get a JIRA account? > > > > > > > This is a good question. > > Recently ASF JIRA disabled self subscribe due to too much spam. > > > > I can help you. > > In the meantime (that I figure out how to crate your JIRA account) you can > > send the PR > > > > Thanks > > Enrico > > > > > > > Thanks. > > > > > > Namjae Kim > > > > >
Re: I would like to send a PR related to zookeeper C client
It might be worth reconsidering the contributing "requirement" to make a JIRA ticket. A lot of JIRA tickets don't have useful information in them anyway... they are just being created because it's required, which is just extra work without benefits. The PR usually has more relevant information and can serve as its own ticket, in my opinion. On Sun, Dec 4, 2022, 12:12 Enrico Olivelli wrote: > Il Sab 3 Dic 2022, 18:57 Namjae Kim ha scritto: > > > Hi, I am Namjae Kim. > > > > I want to add version information to the file names of the libraries of > > zookeeper C client. I tried to create a JIRA ticket but it was not > > possible. > > > > My suggestion is to change the filename from `libzookeeper_mt.so.2` to > > `libzookeeper_mt-3.8.0.so.2`. > > > > How do I create a ticket or get a JIRA account? > > > > This is a good question. > Recently ASF JIRA disabled self subscribe due to too much spam. > > I can help you. > In the meantime (that I figure out how to crate your JIRA account) you can > send the PR > > Thanks > Enrico > > > > Thanks. > > > > Namjae Kim > > >
Re: I would like to send a PR related to zookeeper C client
Il Sab 3 Dic 2022, 18:57 Namjae Kim ha scritto: > Hi, I am Namjae Kim. > > I want to add version information to the file names of the libraries of > zookeeper C client. I tried to create a JIRA ticket but it was not > possible. > > My suggestion is to change the filename from `libzookeeper_mt.so.2` to > `libzookeeper_mt-3.8.0.so.2`. > > How do I create a ticket or get a JIRA account? > This is a good question. Recently ASF JIRA disabled self subscribe due to too much spam. I can help you. In the meantime (that I figure out how to crate your JIRA account) you can send the PR Thanks Enrico > Thanks. > > Namjae Kim >