[edk2-devel] [PATCH v2] [edk2-platforms] Silicon/Intel/FitGen: Fix CheckOverlap would do incorrect split BiosModule action in corner case

From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3922 [Description] CheckOverlap function would do incorrect split on the BiosModule which not happen overlap. This would cause incorrect value locate in FIT entry record. [Condition] - This BiosModule base address is lower

Re: [edk2-devel] [PATCH v1] [edk2-platforms] Silicon/Intel/FitGen: Fix CheckOverlap would do incorrect split BiosModule action in corner case

Hi Bob, Agree. Check the size first is more readable than do the type conversion. That would be align with the address check. I would send out patch v2 based on this change. Thanks, Jason. -Original Message- From: Feng, Bob C Sent: Saturday, June 4, 2022 12:08 To: Lin, Jason1 ;

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/07/2022 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 06/07/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Reviewed-by: Heng Luo > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, June 7, 2022 6:51 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Sinha, Ankit > ; Kubacki, Michael ; > Luo, Heng > Subject: [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg:

Re: [edk2-devel] [edk2-platforms] [PATCH V2 1/4] KabylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Reviewed-by: Michael Kubacki On 6/6/2022 7:16 PM, Nate DeSimone wrote: Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Cc: Jeremy Soller

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 06/06/2022 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* 06/06/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1496538 ) *Description:* TianoCore community,

[edk2-devel] [edk2-platforms] [PATCH V2 2/4] WhiskeylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Chasel Chiu Cc: Michael Kubacki Signed-off-by: Nate DeSimone --- .../WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc | 9 -

[edk2-devel] [edk2-platforms] [PATCH V2 4/4] TigerlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Sai Chaganty Cc: Michael Kubacki Cc: Heng Luo Signed-off-by: Nate DeSimone --- .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 10 +- 1

[edk2-devel] [edk2-platforms] [PATCH V2 3/4] CometlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Chasel Chiu Cc: Michael Kubacki Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Nate DeSimone ---

[edk2-devel] [edk2-platforms] [PATCH V2 0/4] Enable CPU pwr mgmt in FADT for Intel client boards

Changes in V2: - Moved FSP dispatch mode PCD additions for GalagoPro3 to a seperate patch series This patch series sets the DUTY_OFFSET and DUTY_WIDTH fields in the ACPI FADT to 1 and 3 respectively. This will enable OS power management to set the CPU clock speed in the P_CNT register on these

Re: [edk2-devel] [edk2-platforms] [PATCH V1 1/4] KabylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Thanks for the feedback Michael. This has been addressed in the new V2 series. -Original Message- From: Michael Kubacki Sent: Monday, June 6, 2022 3:56 PM To: devel@edk2.groups.io; Desimone, Nathaniel L Cc: Chiu, Chasel ; Sinha, Ankit ; Kubacki, Michael ; Benjamin Doron ; Soller,

[edk2-devel] [edk2-platforms] [PATCH V2 1/4] KabylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Chasel Chiu Cc: Michael Kubacki Cc: Benjamin Doron Cc: Jeremy Soller Signed-off-by: Nate DeSimone --- .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: Add FSP Dispatch Mode PCDs

Reviewed-by: Ankit Sinha > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, June 6, 2022 4:09 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Sinha, Ankit > ; Kubacki, Michael > ; Soller, Jeremy > > Subject: [edk2-platforms] [PATCH V1]

Re: [edk2-devel] [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Reviewed-by: Ankit Sinha > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, June 6, 2022 3:51 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Sinha, Ankit > ; Kubacki, Michael > ; Luo, Heng > Subject: [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg:

Re: [edk2-devel] [edk2-platforms] [PATCH V1 3/4] CometlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Reviewed-by: Ankit Sinha > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, June 6, 2022 3:50 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Sinha, Ankit > ; Kubacki, Michael > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > > Subject:

Re: [edk2-devel] [edk2-platforms] [PATCH V1 2/4] WhiskeylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Reviewed-by: Ankit Sinha > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, June 6, 2022 3:50 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Sinha, Ankit > ; Kubacki, Michael > > Subject: [edk2-platforms] [PATCH V1 2/4] WhiskeylakeOpenBoardPkg: > Indicate width of

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: Add FSP Dispatch Mode PCDs

Adds missing FSP dispatch mode PCDs to the Galago Pro 3. Cc: Chasel Chiu Cc: Ankit Sinha Cc: Michael Kubacki Cc: Jeremy Soller Signed-off-by: Nate DeSimone --- .../GalagoPro3/OpenBoardPkgPcd.dsc| 46 +-- 1 file changed, 42 insertions(+), 4 deletions(-) diff

Re: [edk2-devel] [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Reviewed-by: Michael Kubacki On 6/6/2022 6:50 PM, Nate DeSimone wrote: Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Sai Chaganty Cc: Ankit Sinha Cc: Michael Kubacki Cc: Heng Luo Signed-off-by: Nate

Re: [edk2-devel] [edk2-platforms] [PATCH V1 3/4] CometlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Reviewed-by: Michael Kubacki On 6/6/2022 6:50 PM, Nate DeSimone wrote: Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Chasel Chiu Cc: Ankit Sinha Cc: Michael Kubacki Cc: Sai Chaganty Cc: Deepika

Re: [edk2-devel] [edk2-platforms] [PATCH V1 2/4] WhiskeylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Reviewed-by: Michael Kubacki On 6/6/2022 6:50 PM, Nate DeSimone wrote: Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Chasel Chiu Cc: Ankit Sinha Cc: Michael Kubacki Signed-off-by: Nate DeSimone ---

Re: [edk2-devel] [edk2-platforms] [PATCH V1 1/4] KabylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

It seems the FSP changes should at least be in a separate commit even if a part of this overall series. Regards, Michael On 6/6/2022 6:50 PM, Nate DeSimone wrote: Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power

[edk2-devel] [edk2-platforms] [PATCH V1 2/4] WhiskeylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Chasel Chiu Cc: Ankit Sinha Cc: Michael Kubacki Signed-off-by: Nate DeSimone --- .../WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc | 9 -

[edk2-devel] [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Sai Chaganty Cc: Ankit Sinha Cc: Michael Kubacki Cc: Heng Luo Signed-off-by: Nate DeSimone --- .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 10

[edk2-devel] [edk2-platforms] [PATCH V1 1/4] KabylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Merged missing PCD settings into GalagoPro3 Cc: Chasel Chiu Cc: Ankit Sinha Cc: Michael Kubacki Cc: Benjamin Doron Cc: Jeremy Soller Signed-off-by: Nate

[edk2-devel] [edk2-platforms] [PATCH V1 3/4] CometlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the width of the clock duty cycle to OS power management Cc: Chasel Chiu Cc: Ankit Sinha Cc: Michael Kubacki Cc: Sai Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Nate DeSimone ---

[edk2-devel] [edk2-platforms] [PATCH V1 0/4] Enable CPU pwr mgmt in FADT for Intel client boards

This patch series sets the DUTY_OFFSET and DUTY_WIDTH fields in the ACPI FADT to 1 and 3 respectively. This will enable OS power management to set the CPU clock speed in the P_CNT register on these platforms. Cc: Chasel Chiu Cc: Ankit Sinha Cc: Sai Chaganty Cc: Michael Kubacki Cc: Heng Luo

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

The series has been pushed as ~3018b1f..61af470 -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, April 11, 2022 1:58 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/3]

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, April 11, 2022 1:58 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty

Re: [edk2-devel] [PATCH V1 1/1] .pytool: UncrustifyCheck: Set IgnoreFiles path relative to package path

Reviewed-by: Michael Kubacki On 6/6/2022 3:52 PM, Kun Qin wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3942 `IgnoreFiles` tag is specified in the CI YAML files in each individual packages. The current logic for UncrustifyCheck script bases specified file paths from workspace,

[edk2-devel] [PATCH V1 1/1] .pytool: UncrustifyCheck: Set IgnoreFiles path relative to package path

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3942 `IgnoreFiles` tag is specified in the CI YAML files in each individual packages. The current logic for UncrustifyCheck script bases specified file paths from workspace, which requires the package name to be included in each entry. This

[edk2-devel] [PATCH V1 0/1] UncrustifyCheck ignore file list paths reduction

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3942 When UncrustifyCheck plugin checks against "IgnoreFiles" tag, the script references the files relative to the workspace. This will require all files listed under such category to specify the package name in the corresponding package CI

Re: [edk2-devel] [GSOC 2022] Adding Rust support to EDK II: Introducing Myself

Hi Ayush, We will be meeting weekly on Microsoft Teams. We're finalizing proposed meeting times given the three mentor time zones. I will be sending you a meeting series invitation this week when that is done to check your availability as well. Regards, Michael On 6/6/2022 7:54 AM, Ayush

[edk2-devel][PATCH v1 1/2] MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907 This commit introduces EDKII_PCI_DEVICE_PPI. The purpose of this PPI is to provide a way of accessing PCI devices to drvice drivers such as NvmExpressPei or AhciPei. Cc: Hao A Wu Cc: Ray Ni Cc: Liming Gao Signed-off-by: Maciej

[edk2-devel][PATCH v1 2/2] MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907 This change modifies AhciPei library to allow usage both EDKII_PCI_DEVICE_PPI and EDKII_PEI_ATA_AHCI_HOST_CONTROLLER_PPI to manage ATA HDD working under AHCI mode. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Maciej Czajkowski ---

[edk2-devel][PATCH v1 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907 The purpose of those changes is to introduce the way to enumerate and assign resources in PEI for the systems with more than one PCI root. Here is a need to have an interface that will support such a mechanizm. For now, the part that

Re: [edk2-devel] [GSOC 2022] Adding Rust support to EDK II: Introducing Myself

Hi Michael, I was wondering when we can start the discussions about the project. After doing some more research, I would like to make some changes to the proposed schedule and iron out some implementation details. So it would be great if you can clarify how and where the discussions should take

Re: [edk2-devel] [PATCH 5/5] CpuException: Add InitializeSeparateExceptionStacks

Acked-by: Eric Dong -Original Message- From: Ni, Ray Sent: Friday, May 20, 2022 10:16 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Wang, Jian J Subject: [PATCH 5/5] CpuException: Add InitializeSeparateExceptionStacks Today InitializeCpuExceptionHandlersEx is called from three

Re: [edk2-devel] [PATCH 4/5] CpuException: Remove InitializeCpuInterruptHandlers

Acked-by: Eric Dong eric.d...@intel.com From: Ni, Ray Sent: Tuesday, May 24, 2022 4:04 PM To: Wang, Jian J ; devel@edk2.groups.io Cc: Dong, Eric Subject: Re: [edk2-devel] [PATCH 4/5] CpuException: Remove InitializeCpuInterruptHandlers Jian, I think we need

Re: [edk2-devel] [PATCH 3/5] CpuException: Avoid allocating page but using global variables

Acked-by: Eric Dong -Original Message- From: Ni, Ray Sent: Friday, May 20, 2022 10:16 PM To: devel@edk2.groups.io Cc: Dong, Eric Subject: [PATCH 3/5] CpuException: Avoid allocating page but using global variables Signed-off-by: Ray Ni Cc: Eric Dong ---

Re: [edk2-devel] [PATCH 2/5] CpuException: Init global variables in-place

Acked-by: Eric Dong -Original Message- From: Ni, Ray Sent: Friday, May 20, 2022 10:16 PM To: devel@edk2.groups.io Cc: Dong, Eric Subject: [PATCH 2/5] CpuException: Init global variables in-place Additionally removed two useless global variables: "SPIN_LOCK mDisplayMessageSpinLock"

Re: [edk2-devel] [PATCH 1/5] CpuException: Avoid allocating code pages for DXE instance

Acked-by: Eric Dong From: Ni, Ray Sent: Tuesday, May 24, 2022 4:02 PM To: Wang, Jian J ; devel@edk2.groups.io Cc: Dong, Eric Subject: Re: [edk2-devel] [PATCH 1/5] CpuException: Avoid allocating code pages for DXE instance Jian, Ia32/ExceptionHandlerAsm.nasm is used by 32bit