Re: [ovirt-devel] Engine's jvm stats via jmx and metrics
- Original Message - From: Piotr Kliczewski piotr.kliczew...@gmail.com To: devel@ovirt.org Sent: Friday, February 6, 2015 3:53:54 PM Subject: [ovirt-devel] Engine's jvm stats via jmx and metrics Hi, During my work I found myself in situation when I realized that I have no clue what engine or engine's jvm is doing. I wanted to use visualvm [1] to monitor engine's jvm. There are two ways to monitor jvm. One of them is by using jstatd which is limited and the second one is jmx. I found a blog [2] which helped me to understand how to connect to the engine. In order to connect you need to run visualvm using attached script. Please modify JBOSS_HOME. Once visualvm is up and running you can click Add jmx connection In connection text box please enter (assuming that your iptables allows 8706): service:jmx:remoting-jmx://engine_ip:8706 and click OK. Now you can understand what is going on with engine's jvm. I am able see jvm level information but I still have no clue how well high level engine commands are running. I have been looking for a while how to integrate Metrics [3] with the engine to understand how engine behaves over time. I wonder if there is anyone except me interested in understanding how well engine is running. Thanks, Piotr a. I think it is important b. I would like to add that with Widfly + Java EE 7, and the introduction of managed java.util.concurrent I think we should consider to move our threading infra to managed java.util.concurrent (once we use widlfly in the project) and then you will be able to monitor threads as well. I can think of an interim solution for now until we do. c. JMX is great, but what about the event notifier and the work done on SNMP traps? why not utilize this furthermore? Or do you see this as completely two different things and two supplementary tools? Cheers, Yair [1] http://visualvm.java.net/ [2] http://blog.akquinet.de/2012/11/01/connecting-visualvm-with-a-remote-jboss-as-7-eap6-jvm-process/ [3] https://github.com/dropwizard/metrics ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [ENGINE][SLA] from time to time I'm getting the folowwing exception when running on master
- Original Message - From: Doron Fediuck dfedi...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Doron Fediuck do...@redhat.com, Gilad Chaplik gchap...@redhat.com, devel@ovirt.org Sent: Wednesday, January 14, 2015 9:22:55 AM Subject: Re: [ENGINE][SLA] from time to time I'm getting the folowwing exception when running on master IS this on master or 3.5 branch? master On 01/14/2015 03:30 AM, Yair Zaslavsky wrote: 2015-01-14 03:30:27,407 INFO [org.ovirt.engine.core.bll.scheduling.SchedulingManager] (MSC service thread 1-6) [] Initializing Scheduling manager 2015-01-14 03:30:27,438 ERROR [org.ovirt.engine.core.bll.InitBackendServicesOnStartupBean] (MSC service thread 1-6) [] Failed to initialize backend: org.apache.commons.lang.NotImplementedException: policyUnit: Migration at org.ovirt.engine.core.bll.scheduling.PolicyUnitImpl.getPolicyUnitImpl(PolicyUnitImpl.java:116) [bll.jar:] at org.ovirt.engine.core.bll.scheduling.SchedulingManager.loadPolicyUnits(SchedulingManager.java:178) [bll.jar:] at org.ovirt.engine.core.bll.scheduling.SchedulingManager.init(SchedulingManager.java:101) [bll.jar:] at org.ovirt.engine.core.bll.InitBackendServicesOnStartupBean.create(InitBackendServicesOnStartupBean.java:104) [bll.jar:] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_45] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [rt.jar:1.7.0_45] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_45] at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_45] at org.jboss.as.ee.component.ManagedReferenceLifecycleMethodInterceptorFactory$ManagedReferenceLifecycleMethodInterceptor.processInvocation(ManagedReferenceLifecycleMethodInterceptorFactory.java:130) [jboss-as-ee-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.invocation.WeavedInterceptor.processInvocation(WeavedInterceptor.java:53) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.as.weld.injection.WeldInjectionInterceptor.processInvocation(WeldInjectionInterceptor.java:73) [jboss-as-weld-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.as.ee.component.ManagedReferenceInterceptorFactory$ManagedReferenceInterceptor.processInvocation(ManagedReferenceInterceptorFactory.java:95) [jboss-as-ee-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.invocation.WeavedInterceptor.processInvocation(WeavedInterceptor.java:53) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.as.ee.component.NamespaceContextInterceptor.processInvocation(NamespaceContextInterceptor.java:50) [jboss-as-ee-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.as.ejb3.tx.CMTTxInterceptor.invokeInOurTx(CMTTxInterceptor.java:228) [jboss-as-ejb3-7.1.1.Final.jar:7.1.1.Final] at org.jboss.as.ejb3.tx.CMTTxInterceptor.requiresNew(CMTTxInterceptor.java:333) [jboss-as-ejb3-7.1.1.Final.jar:7.1.1.Final] at org.jboss.as.ejb3.tx.SingletonLifecycleCMTTxInterceptor.processInvocation(SingletonLifecycleCMTTxInterceptor.java:56) [jboss-as-ejb3-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(Intercep Can someone explain me how to resolve? Cheers, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] [ENGINE][SLA] from time to time I'm getting the folowwing exception when running on master
2015-01-14 03:30:27,407 INFO [org.ovirt.engine.core.bll.scheduling.SchedulingManager] (MSC service thread 1-6) [] Initializing Scheduling manager 2015-01-14 03:30:27,438 ERROR [org.ovirt.engine.core.bll.InitBackendServicesOnStartupBean] (MSC service thread 1-6) [] Failed to initialize backend: org.apache.commons.lang.NotImplementedException: policyUnit: Migration at org.ovirt.engine.core.bll.scheduling.PolicyUnitImpl.getPolicyUnitImpl(PolicyUnitImpl.java:116) [bll.jar:] at org.ovirt.engine.core.bll.scheduling.SchedulingManager.loadPolicyUnits(SchedulingManager.java:178) [bll.jar:] at org.ovirt.engine.core.bll.scheduling.SchedulingManager.init(SchedulingManager.java:101) [bll.jar:] at org.ovirt.engine.core.bll.InitBackendServicesOnStartupBean.create(InitBackendServicesOnStartupBean.java:104) [bll.jar:] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_45] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [rt.jar:1.7.0_45] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_45] at java.lang.reflect.Method.invoke(Method.java:606) [rt.jar:1.7.0_45] at org.jboss.as.ee.component.ManagedReferenceLifecycleMethodInterceptorFactory$ManagedReferenceLifecycleMethodInterceptor.processInvocation(ManagedReferenceLifecycleMethodInterceptorFactory.java:130) [jboss-as-ee-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.invocation.WeavedInterceptor.processInvocation(WeavedInterceptor.java:53) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.as.weld.injection.WeldInjectionInterceptor.processInvocation(WeldInjectionInterceptor.java:73) [jboss-as-weld-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.as.ee.component.ManagedReferenceInterceptorFactory$ManagedReferenceInterceptor.processInvocation(ManagedReferenceInterceptorFactory.java:95) [jboss-as-ee-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.invocation.WeavedInterceptor.processInvocation(WeavedInterceptor.java:53) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.as.ee.component.NamespaceContextInterceptor.processInvocation(NamespaceContextInterceptor.java:50) [jboss-as-ee-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:288) [jboss-invocation-1.1.1.Final.jar:1.1.1.Final] at org.jboss.as.ejb3.tx.CMTTxInterceptor.invokeInOurTx(CMTTxInterceptor.java:228) [jboss-as-ejb3-7.1.1.Final.jar:7.1.1.Final] at org.jboss.as.ejb3.tx.CMTTxInterceptor.requiresNew(CMTTxInterceptor.java:333) [jboss-as-ejb3-7.1.1.Final.jar:7.1.1.Final] at org.jboss.as.ejb3.tx.SingletonLifecycleCMTTxInterceptor.processInvocation(SingletonLifecycleCMTTxInterceptor.java:56) [jboss-as-ejb3-7.1.1.Final.jar:7.1.1.Final] at org.jboss.invocation.InterceptorContext.proceed(Intercep Can someone explain me how to resolve? Cheers, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] [ENGINE] Question about refresh parameter of GetConfigurationValueQuery
Hi all, Can anyone think of an issue with changing the default value of the refresh parameter to false for the query mentioned at $Subject? Cheers, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Certain questions about Quartz based scheduling in oVirt
- Original Message - From: Sahina Bose sab...@redhat.com To: Moti Asayag masa...@redhat.com, Shubhendu Tripathi shtri...@redhat.com Cc: devel@ovirt.org Sent: Tuesday, November 25, 2014 1:13:06 PM Subject: Re: [ovirt-devel] Certain questions about Quartz based scheduling in oVirt On 11/24/2014 06:27 PM, Moti Asayag wrote: Hi Shubhendu, - Original Message - From: Shubhendu Tripathi shtri...@redhat.com To: devel@ovirt.org Sent: Monday, November 24, 2014 8:58:34 AM Subject: [ovirt-devel] Certain questions about Quartz based scheduling in oVirt Hi All, We are in a requirement where we need to schedule jobs at certain time interval, hourly, daily, weekly and monthly (i.e. repetitive and cron kind of scheduling). I was trying to understand quartz based scheduling mechanism in oVirt to achieve the scenarios. Have some basic questions regarding the same - 1. Is there is mechanism to persist the scheduling data in oVirt ? In ovirt we do not persist the jobs. The application reschedule the jobs when it starts and programmatically triggers jobs when required. On packaging/services/ovirt-engine/ovirt-engine.xml.in we specify the job store configuration as RAMJobStore, which is a volatile: property name=org.quartz.jobStore.class value=org.quartz.simpl.RAMJobStore/ You may select other implementation. See: http://quartz-scheduler.org/api/2.2.0/org/quartz/spi/JobStore.html Would the correct approach then be to have multiple scheduler instances? Please bare in mind that quartz has the ability to perform Cron like scheduling (with cron expressions). http://www.quartz-scheduler.org/documentation/quartz-1.x/tutorials/crontrigger 1. - that uses the in memory job store 2. that uses DB to persist the jobs. The second instance would be used to schedule and manage any dynamic jobs, for instance like the ones required for gluster volume snapshot scheduling Using a separate instance also would mean there's no change to existing jobs that are scheduled in Backend bean. 2. How to tackle edit and rescheduling of jobs ? You can have a look at org.ovirt.engine.core.utils.timer.SchedulerUtil interface in the 'scheduler' project which provides that functionality, and the related classes. But if not special requirements, i guess the shipped quartz implementation should be enough: http://quartz-scheduler.org/documentation/quartz-2.x/tutorials/tutorial-lesson-05 Kindly guide on how to achieve these. Thanks and Regards, Shubhendu ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Transactions handling in commands
Hello all, During some chasing after some locks issues, I have encountered some commands that are not using the transaction framework properly (IMHO). For example, ExportRepoImageCommand - has no annotation indicating it should not be run in transaction. It contains IMHO a classic flow of - a. get from db (and potential update) b. send a call to VDSM - this may be long !!! c. update results in DB. IMHO, ExportRepoImageCommand should be annotated with @NonTransactive(forceCompensation=true) and should include compensation code. If I am wrong with the specific command, please add a nice comment indicating why this was not done, so the next person who reads the code and deals with locks, transactions and all these interesting issues should be aware. Transactions should be kept as short as possible, as they are an expensive , limited resource. This is not the first time I encountered this issue with developers in the last weeks, and maybe I sound angry or something - this is not the intention, I can't say I know all engine code myself (and even around the infra side), and I think that one of the good things in the way we work is we can learn from each other. If any of of you feel like they need some reminding on our transactions framework (and yes, I believe there is room to improvement in it, I already spoke with Oved about at least one idea) - feel free to address me, with enough audience I might even run a session when I visit TLV (I would have done it form home, but my internet condition is pretty bad, I'm afraid). Cheers, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Thoughts on modularization
- Original Message - From: Alon Bar-Lev alo...@redhat.com To: Vojtech Szocs vsz...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Mark Proctor mdproc...@gmail.com, devel@ovirt.org Sent: Friday, November 7, 2014 5:17:56 PM Subject: Re: [ovirt-devel] Thoughts on modularization Hi, I can summarized that you want again to go into the Java way and not the Simple/primitive way. I think it is a mistake and will not have any benefit, API can be a wrapper over primitive interaction. We were there at past discussions, and as there is no leader of project we can discuss this to death, and I am not intend to do this yet another time (we have done this at branding, we have done this for aaa, partially for ui plugins [there we should kill gwt], and ...). I will make this short... 1. the current extension api is sufficient to construct a very complex implementation using very simple and primitive interface. 2. the current extension api enable implementing extensions using non java technologies, such as javascript/jpython. 3. the current extension api enable to not have any difference if core or extension interacts with extensions. 4. the current extension api enable forward and backward compatibility in simple methodology,. 5. a wrapper over the extension api can provide whatever high level api that is preferred by developer as an optional utility. we can always over engineer solution or have java specific solutions, I always vote for simplicity. Hmm, I think that going the Java way will be a bit sad, especially since objects in JS are maps. I understand that GWT stuff gets compiled from Java, and since Java is more strongly typed and we have Java classes to work with, Vojtech is looking probably to a solution which is more the java way. Having said that, I still see no reason why we can't use ExtAPI in GWT, yes, maybe we will need to do some porting so it matches the GWT java limitations, and yeah - we cannot use JBoss modules there, we need something else (and we can't use JS either, as JS is the compilation result) - but still, if possible I would consider to try use EXTAPI in GWT as well. Yair Alon - Original Message - From: Vojtech Szocs vsz...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Alon Bar-Lev alo...@redhat.com, Mark Proctor mdproc...@gmail.com, devel@ovirt.org Sent: Friday, November 7, 2014 4:53:49 PM Subject: Re: [ovirt-devel] Thoughts on modularization - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: Vojtech Szocs vsz...@redhat.com, Mark Proctor mdproc...@gmail.com, devel@ovirt.org Sent: Wednesday, November 5, 2014 9:40:05 PM Subject: Re: [ovirt-devel] Thoughts on modularization - Original Message - From: Alon Bar-Lev alo...@redhat.com To: Vojtech Szocs vsz...@redhat.com Cc: Mark Proctor mdproc...@gmail.com, devel@ovirt.org Sent: Wednesday, November 5, 2014 6:16:15 PM Subject: Re: [ovirt-devel] Thoughts on modularization - Original Message - From: Vojtech Szocs vsz...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: devel@ovirt.org, Mark Proctor mdproc...@gmail.com Sent: Wednesday, November 5, 2014 6:07:50 PM Subject: Re: [ovirt-devel] Thoughts on modularization - Original Message - From: Alon Bar-Lev alo...@redhat.com To: Vojtech Szocs vsz...@redhat.com Cc: devel@ovirt.org, Mark Proctor mdproc...@gmail.com Sent: Wednesday, November 5, 2014 4:32:31 PM Subject: Re: [ovirt-devel] Thoughts on modularization - Original Message - From: Vojtech Szocs vsz...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: devel@ovirt.org, Mark Proctor mdproc...@gmail.com Sent: Wednesday, November 5, 2014 5:24:14 PM Subject: Re: [ovirt-devel] Thoughts on modularization - Original Message - From: Alon Bar-Lev alo...@redhat.com To: Vojtech Szocs vsz...@redhat.com Cc: devel@ovirt.org, Mark Proctor mdproc...@gmail.com Sent: Wednesday, November 5, 2014 4:12:06 PM Subject: Re: [ovirt-devel] Thoughts on modularization - Original Message - From: Vojtech Szocs vsz...@redhat.com To: devel@ovirt.org Cc: Mark Proctor mdproc...@gmail.com Sent: Wednesday, November 5, 2014 5:04:24 PM Subject: [ovirt-devel] Thoughts on modularization Hi guys, I've discussed this recently with Yair and Mark, I just wanted to share some more thoughts on this topic -- in particular, how modularization problem can be approached (regardless of implementation details). I see two
Re: [ovirt-devel] GWT-Platform MVP tech session - anyone interested?
Yes please. - Original Message - From: Vojtech Szocs vsz...@redhat.com To: devel@ovirt.org Sent: Friday, November 7, 2014 9:13:17 PM Subject: [ovirt-devel] GWT-Platform MVP tech session - anyone interested? Hi guys, few days ago, I gave my ancient (Dec 2011!) GWT-Platform [1] Model-View-Presenter tech session to a couple of colleagues so that they better understand our frontend infra/structure. [1] https://github.com/ArcBees/GWTP This session was meant to explain the core concepts of GWTP framework. Would anyone from community be interested in this session? Regards, Vojtech ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Thoughts on modularization
- Original Message - From: Sven Kieske s.kie...@mittwald.de To: devel@ovirt.org Sent: Wednesday, November 5, 2014 6:36:39 PM Subject: Re: [ovirt-devel] Thoughts on modularization On 05/11/14 17:07, Vojtech Szocs wrote: This way, you'd have one core module, providing most general functionality/abstractions. Then you'd have more specific modules, plugged into core module's API etc. In other words, hierarchy of modules. This is essentially modularization taken to extreme :) Welcome to dependency hell or circular dependencies etc. would you like to code your own dependency resolver? I assume dependency resolving can be based on Topological sorting of Graph theory. I assume the extensions that will participate as nodes in the graph will be those who are enabled in their configuration I like modularization, but you can overengineer everything. -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Thoughts on modularization
- Original Message -
From: Alon Bar-Lev alo...@redhat.com
To: Vojtech Szocs vsz...@redhat.com
Cc: Mark Proctor mdproc...@gmail.com, devel@ovirt.org
Sent: Wednesday, November 5, 2014 6:16:15 PM
Subject: Re: [ovirt-devel] Thoughts on modularization
- Original Message -
From: Vojtech Szocs vsz...@redhat.com
To: Alon Bar-Lev alo...@redhat.com
Cc: devel@ovirt.org, Mark Proctor mdproc...@gmail.com
Sent: Wednesday, November 5, 2014 6:07:50 PM
Subject: Re: [ovirt-devel] Thoughts on modularization
- Original Message -
From: Alon Bar-Lev alo...@redhat.com
To: Vojtech Szocs vsz...@redhat.com
Cc: devel@ovirt.org, Mark Proctor mdproc...@gmail.com
Sent: Wednesday, November 5, 2014 4:32:31 PM
Subject: Re: [ovirt-devel] Thoughts on modularization
- Original Message -
From: Vojtech Szocs vsz...@redhat.com
To: Alon Bar-Lev alo...@redhat.com
Cc: devel@ovirt.org, Mark Proctor mdproc...@gmail.com
Sent: Wednesday, November 5, 2014 5:24:14 PM
Subject: Re: [ovirt-devel] Thoughts on modularization
- Original Message -
From: Alon Bar-Lev alo...@redhat.com
To: Vojtech Szocs vsz...@redhat.com
Cc: devel@ovirt.org, Mark Proctor mdproc...@gmail.com
Sent: Wednesday, November 5, 2014 4:12:06 PM
Subject: Re: [ovirt-devel] Thoughts on modularization
- Original Message -
From: Vojtech Szocs vsz...@redhat.com
To: devel@ovirt.org
Cc: Mark Proctor mdproc...@gmail.com
Sent: Wednesday, November 5, 2014 5:04:24 PM
Subject: [ovirt-devel] Thoughts on modularization
Hi guys,
I've discussed this recently with Yair and Mark, I just wanted to
share
some more thoughts on this topic -- in particular, how
modularization
problem can be approached (regardless of implementation details).
I see two approaches here. The typical one is to define APIs for
modules
to consume. For example, oVirt Engine extension API has API for
auth
stuff; oVirt UI plugin API has API for showing tabs and dialogs,
etc.
The advantage is strict consistency, disadvantage is burden of
having
to maintain the whole API. With this approach, you tell modules:
This
is the API to work with system, defining how you can plug into it.
Now turn 180 degrees. The other approach, which is really
interesting,
is to let modules themselves export API. This naturally leads to
module
hierarchies. Ultimately, this leads to micro-kernel-style
development,
where all logic resides in modules. Now you might ask: What if we
want
to employ some consistent work flow across multiple modules? For
example,
have some pluggable *auth* infra? -- this can be done via some
higher
level module, that exports API and lower level modules consume
that
API.
If you have any ideas, please share!
Both solutions can be applied using existing extension api, an
extension
can
locate other extension and interact with it the same way the core
interacts
with extensions.
But how does core interact with extensions? I assume via well-defined
API, i.e. in accordance with first approach mentioned above.
presentation:
http://www.ovirt.org/File:Ovirt_3.5_-_aaa.pdf
Thanks for sharing!
package org.ovirt.engine.api.extensions;
/**
* Interface of an extension.
*/
public interface Extension {
/**
* Invoke operation.
* @param input input parameters.
* @param output output parameters.
*
* p
* Interaction is done via the parameters.
* Exceptions are not allowed.
* /p
* p
* Basic mappings available at {@link Base}.
* /p
*
* @see Base
*/
void invoke(ExtMap input, ExtMap output);
}
OK, so it was my lack of knowledge of AAA implementation :)
Since Extension interface is invoke-based, I assume that Engine
core (backend) invokes extensions on specific occasions, right?
correct, and nothing prevents extension to invoke other extensions.
With second approach mentioned above, core would not interact with
extensions at all (or in a very limited way), instead - extensions
would interact with each other. In other words, extension would not
need to implement core-specific API (there would be none), instead
it would inject its dependencies (other modules/extensions) and
consume their APIs. This is the difference I wanted to point out :)
The extension interface is primitive to enable exactly that, provided
java
people will open their minds :)
Simple interface means great flexibility, now I understand the
rationale behind
Re: [ovirt-devel] Thoughts on modularization
- Original Message - From: Alon Bar-Lev alo...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Vojtech Szocs vsz...@redhat.com, Mark Proctor mdproc...@gmail.com, devel@ovirt.org Sent: Wednesday, November 5, 2014 10:45:53 PM Subject: Re: [ovirt-devel] Thoughts on modularization - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: Vojtech Szocs vsz...@redhat.com, Mark Proctor mdproc...@gmail.com, devel@ovirt.org Sent: Wednesday, November 5, 2014 10:40:05 PM Subject: Re: [ovirt-devel] Thoughts on modularization 4. there must be core model to trigger the entire thing, core cannot be just a loader. Alon, can you elaborate here on number 4? In an ideal world, wouldn't you want to have the engine core be a small as something that goes over the extensions and loads them? and maybe let each extension expose somehow its relevant part of rest-api (besides of using ext-api to interact between extension and of course each extension should have the relevant logic implementerd within) Well, there is a balance between generic and specific. If you go this route, can the Java JRE be the core you are looking for? No, you need some loader/starter to enumerate your extensions and load them. Maybe a thin service that uses ExtensionsManager. The wisdom is to draw the line where the building blocks serves the purpose of building the application you need. I agree. Alon ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [RFC] oVirt mobile client
- Original Message - From: Greg Sheremeta gsher...@redhat.com To: users us...@ovirt.org, devel@ovirt.org Sent: Friday, October 31, 2014 3:49:11 AM Subject: [ovirt-devel] [RFC] oVirt mobile client Hi, The focus of our OPW internship program starting in December will be mobile and/or lightweight engine clients -- hopefully integrating the new ovirt.js project. +100 Sorry for the ignorant question - does this mean the technology will be web based or native? (i.e - java on top of android, Swift/Objective-C on top of IOS) I see that there are some already existing mobile clients for oVirt. I'm trying to grasp what we have and what the needs are. moVirt: https://github.com/matobet/moVirt (mbetak) This appears to be more of a lightweight webadmin. No console access, but I believe it's planned as part of OPW. (?) I spoke with mbetak about this a few months ago. When you speak of console, you mean to actually view the VM using spice? sounds very interesting. If I recall, Alon levy (a former red hatter) worked on some spice implementation for html5 or something like that. Anyway, back in TLV I also had some ideas around that. Do you have some IRC meetings or something that I can join? Cheers, Yair nomad: http://www.ovirt.org/Project_Proposal_-_Nomad and https://github.com/Vizuri/ovirt-nomad Looks dead -- last commit 3 years ago. Anyone know more about this one? That's all I see on the first few pages of google. When I think of a mobile client for oVirt, I think the most useful part would be the user portal -- simple operations for start, stop, and the ability to view the console of vms. moVirt mentions it wants to support some basic management operations, though. I think it would be difficult to do complex management in a mobile client. (I'm biased towards huge screens, though.) I'd like to see an official subproject started that coordinates our mobile efforts. Is this possible? What would it take to start it? What would people like to see in such an app? Greg Sheremeta Red Hat, Inc. Sr. Software Engineer, RHEV Cell: 919-807-1086 gsher...@redhat.com ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [ATN] Migration to slf4j finished
- Original Message -
From: Martin Perina mper...@redhat.com
To: devel@ovirt.org
Sent: Monday, October 27, 2014 4:58:27 PM
Subject: [ovirt-devel] [ATN] Migration to slf4j finished
Hi,
patch which removes oVirt logger was just merged. So in all
your current and future patches for oVirt engine please use
only slf4j as logging framework.
Alon already posted some slf4j guidelines [1].
During logging refactoring we also started to quote parameter
values in logging messages. Here are current rules for
quoting:
1. Quote parameter values ONLY using single quote character
2. Quote non number attribute values
3. Don't quote primitive type numbers
4. Don't quote error messages, because they are the last part
of message string after ':', so there's no need to quote
5. Don't quote strings which creates sentence of log message,
for example
log.info(Feature was {}, enabled ? enabled : disabled);
6. For the rest of cases use common sense :)
+1 , and I would say that quoting also should be used for descriptive
information.
For example - VM 'my-vm' was stopped
Please feel free to write any comments to the quote guidelines.
For example we may decide to alter rule 2. to not quote value
which cannot be null or empty.
Once agreed we could add those into some engine Java code
convention guide :)
+1 on the convention, thank you for thinking about this.
Thanks
Martin Perina
[1] http://lists.ovirt.org/pipermail/devel/2014-October/009028.html
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] DAO tests are failing on master
Looks like a hashcode/equals problem. I tried git log on VmNumaNode.java - doesnt look like it changed for a while. Same for VdsNumaNode, and same for the DAOs and the SPs. This is strange. Are you sure you don't have some dirt on your environment? Yair - Original Message - From: Idan Shaby ish...@redhat.com To: devel@ovirt.org Sent: Wednesday, October 22, 2014 11:07:40 AM Subject: [ovirt-devel] DAO tests are failing on master Hi, Two tests are failing on class VmNumaNodeDAOTest: - testGetAllPinnedVmNumaNodeByVdsNumaNodeId - testGetAllVmNumaNodeByVdsNumaNodeId The relevant part of the output: Failed tests: testGetAllPinnedVmNumaNodeByVdsNumaNodeId(org.ovirt.engine.core.dao.VmNumaNodeDAOTest): expected:3c2b81e6-5080-4ad1-86a1-cf513b15b515 but was:3c2b81e6-5080-4ad1-86a1-cf513b15b516 testGetAllVmNumaNodeByVdsNumaNodeId(org.ovirt.engine.core.dao.VmNumaNodeDAOTest): expected:3c2b81e6-5080-4ad1-86a1-cf513b15b515 but was:3c2b81e6-5080-4ad1-86a1-cf513b15b516 Tests run: 1386, Failures: 2, Errors: 0, Skipped: 0 My mvn -version output: Apache Maven 3.1.1 (NON-CANONICAL_2013-11-08_14-32_mockbuild; 2013-11-08 16:32:41+0200) Maven home: /usr/share/maven Java version: 1.7.0_45, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.60-2.4.3.0.fc20.x86_64/jre Default locale: en_US, platform encoding: UTF-8 OS name: linux, version: 3.15.10-200.fc20.x86_64, arch: amd64, family: unix Anyone knows something about this? Thanks, Idan ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [ATN] [ovirt-engine] engine master logging
- Original Message -
From: Mooli Tayer mta...@redhat.com
To: Roy Golan rgo...@redhat.com
Cc: devel@ovirt.org
Sent: Wednesday, October 22, 2014 11:07:00 PM
Subject: Re: [ovirt-devel] [ATN] [ovirt-engine] engine master logging
- Original Message -
On 10/20/2014 01:40 PM, Martin Perina wrote:
- Original Message -
From: Alon Bar-Lev alo...@redhat.com
To: Moti Asayag masa...@redhat.com
Cc: devel@ovirt.org
Sent: Monday, October 20, 2014 12:22:25 PM
Subject: Re: [ovirt-devel] [ATN] [ovirt-engine] engine master logging
Kudos !
Another improvement is the usage of {} and not of {SOME_NUMBER}} - which is
prone to bugs (copy paste, removal of parameter from the formatting, etc..)
Well done!
Yair
- Original Message -
From: Moti Asayag masa...@redhat.com
To: Alon Bar-Lev alo...@redhat.com
Cc: devel@ovirt.org
Sent: Monday, October 20, 2014 1:14:51 PM
Subject: Re: [ovirt-devel] [ATN] [ovirt-engine] engine master logging
- Original Message -
From: Alon Bar-Lev alo...@redhat.com
To: devel@ovirt.org
Sent: Sunday, October 19, 2014 9:02:52 PM
Subject: [ovirt-devel] [ATN] [ovirt-engine] engine master logging
Hello All,
Thanks to Martin Perina efforts[1] the ovirt-engine logging was
cleaned
up
significantly throughout the engine.
1. Logging Facade is slf4j.
2. Logging backend is jboss logging at jboss and java.util.logging at
standalone.
3. No more commons-logging, log4j, combinations nor proprietary
loggers.
Nice work. I was about to write I guess the next step will be clearing
the
ThreadLocalParametersContainer - but noticed it was already removed.
The org.ovirt.engine.core.utils.log.LogFactory and
org.ovirt.engine.core.utils.log.Log are depreciated now, the
correlation
id
is managed using logging MDC, so no need to use wrapper, and
correlation
has
much wider effect, as also 3rd parties log records are attached with
correlation id.
Would you consider extending the declaration of @Depracated for those
classes
with more information for the sake of those who might miss this email
and
should
know what is the proper replacement for the deprecated logging method ?
as I wrote we will remove this classes soon using mass changes.
in few days there will be no reference for these.
Yes, I'm currently preparing patches for this, so hopefully within week
or
two
those classes will be removed from project
+1 nice work
+1 noticeable improvement - less time to figure out how to do logging
different
for each component.
We will start to push changes to remove the usage of these classes in
favor
of plain slf4j loggers.
Quick lineup...
1. Usage:
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
class x {
private static final Logger log =
LoggerFactory.getLogger(x.class);
}
2. slf4j logger javadoc is here[2].
3. Crash course:
// simple string
log.info(string);
// string with exception and stack trace
log.info(string, exception);
// string with vars, logger will call argN.toString() for each {}.
log.info(string {} {} {}, arg1, arg2, arg3);
4. *NOTICE* Major difference than what we had:
Exception arguments are not magically detected.
// previous (utils Log): exception magically detected.
log.infoFormat(string {0}, arg1, exception);
// new (slf4j):
log.info(string {}, arg1);
log.info(Exception, exception);
// better new (slf4j):
log.info(string {}, arg1);
log.debug(Exception, exception);
Please do not hesitate to raise any related issue you may find.
Regards,
Alon Bar-Lev.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1109871
[2] http://www.slf4j.org/api/org/slf4j/Logger.html
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] host installation failed
- Original Message -
From: Alon Bar-Lev alo...@redhat.com
To: Yair Zaslavsky yzasl...@redhat.com
Cc: devel@ovirt.org
Sent: Friday, October 17, 2014 10:07:01 AM
Subject: Re: [ovirt-devel] host installation failed
You probably do not use ovirt-host-deploy-1.3.x within devenv, but have
ovirt-host-deploy-1.2.x.
Thanks, it did help.
Now I'm encountering this -
014-10-17 10:13:14,647 ERROR [org.ovirt.engine.core.uutils.ssh.SSHDialog]
(org.ovirt.thread.pool-8-thread-6) SSH error running command
root@192.168.1.1:'umask 0077; MYTMP=$(TMPDIR=${OVIRT_TMPDIR} mktemp -t
ovirt-XX); trap chmod -R u+rwX \${MYTMP}\ /dev/null 21; rm -fr
\${MYTMP}\ /dev/null 21 0; rm -fr ${MYTMP} mkdir ${MYTMP} tar
--warning=no-timestamp -C ${MYTMP} -x ${MYTMP}/setup
DIALOG/dialect=str:machine DIALOG/customization=bool:True': Command returned
failure code 1 during SSH session 'root@192.168.1.1'
2014-10-17 10:13:14,650 ERROR [org.ovirt.engine.core.uutils.ssh.SSHDialog]
(org.ovirt.thread.pool-8-thread-6) Exception: java.io.IOException: Command
returned failure code 1 during SSH session 'root@192.168.1.1'
at
org.ovirt.engine.core.uutils.ssh.SSHClient.executeCommand(SSHClient.java:527)
[uutils.jar:]
at
org.ovirt.engine.core.uutils.ssh.SSHDialog.executeCommand(SSHDialog.java:312)
[uutils.jar:]
at org.ovirt.engine.core.bll.VdsDeploy.execute(VdsDeploy.java:1118)
[bll.jar:]
My host is fedora core 20, in case I forgot to mention.
- Original Message -
From: Yair Zaslavsky yzasl...@redhat.com
To: devel@ovirt.org
Sent: Friday, October 17, 2014 8:41:41 AM
Subject: Re: [ovirt-devel] host installation failed
I'm using master,
commit hash -
6985aa8ac1b4182e346859082d10e5d542ca2969
- Original Message -
From: Yair Zaslavsky yzasl...@redhat.com
To: devel@ovirt.org
Sent: Friday, October 17, 2014 7:47:42 AM
Subject: [ovirt-devel] host installation failed
HI,
I'm getting the following error when trying to add a host -
.
2014-10-17 06:51:02,522 INFO [org.ovirt.engine.core.bll.VdsDeploy]
(VdsDeploy) Host 192.168.1.1 reports unique id
52402781-53A0-11CB-9BE9-B7E5E5F061A6
2014-10-17 06:51:02,550 INFO [org.ovirt.engine.core.bll.VdsDeploy]
(VdsDeploy) Assigning unique id 52402781-53A0-11CB-9BE9-B7E5E5F061A6 to
Host
192.168.1.1
2014-10-17 06:51:02,817 ERROR [org.ovirt.engine.core.bll.VdsDeploy]
(VdsDeploy) Error during deploy dialog: java.lang.NullPointerException
at
org.ovirt.otopi.dialog.MachineDialogParser.cliEnvironmentGet(MachineDialogParser.java:236)
[otopi.jar:]
at
org.ovirt.engine.core.bll.VdsDeploy$37.call(VdsDeploy.java:580)
[bll.jar:]
at
org.ovirt.engine.core.bll.VdsDeploy$37.call(VdsDeploy.java:579)
[bll.jar:]
at
org.ovirt.engine.core.bll.VdsDeploy._nextCustomizationEntry(VdsDeploy.java:668)
[bll.jar:]
at
org.ovirt.engine.core.bll.VdsDeploy._threadMain(VdsDeploy.java:873)
[bll.jar:]
Can you please assist ?
Yair
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] host installation failed
HI, I'm getting the following error when trying to add a host - . 2014-10-17 06:51:02,522 INFO [org.ovirt.engine.core.bll.VdsDeploy] (VdsDeploy) Host 192.168.1.1 reports unique id 52402781-53A0-11CB-9BE9-B7E5E5F061A6 2014-10-17 06:51:02,550 INFO [org.ovirt.engine.core.bll.VdsDeploy] (VdsDeploy) Assigning unique id 52402781-53A0-11CB-9BE9-B7E5E5F061A6 to Host 192.168.1.1 2014-10-17 06:51:02,817 ERROR [org.ovirt.engine.core.bll.VdsDeploy] (VdsDeploy) Error during deploy dialog: java.lang.NullPointerException at org.ovirt.otopi.dialog.MachineDialogParser.cliEnvironmentGet(MachineDialogParser.java:236) [otopi.jar:] at org.ovirt.engine.core.bll.VdsDeploy$37.call(VdsDeploy.java:580) [bll.jar:] at org.ovirt.engine.core.bll.VdsDeploy$37.call(VdsDeploy.java:579) [bll.jar:] at org.ovirt.engine.core.bll.VdsDeploy._nextCustomizationEntry(VdsDeploy.java:668) [bll.jar:] at org.ovirt.engine.core.bll.VdsDeploy._threadMain(VdsDeploy.java:873) [bll.jar:] Can you please assist ? Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] ovirt-engine master failing build on F21 on kerberosldap code
Was the issue resolved? I manage to compile engine perfectly - Original Message - From: Sandro Bonazzola sbona...@redhat.com To: devel@ovirt.org Sent: Wednesday, October 15, 2014 11:33:58 AM Subject: [ovirt-devel] ovirt-engine master failing build on F21 on kerberosldap code Hi, we're trying to build engine on F21 and got the following error: 06:29:05 [ERROR] COMPILATION ERROR : 06:29:05 [INFO] - 06:29:05 [ERROR] /home/jenkins/workspace/ovirt-engine_master_create-rpms_merged/label/fc21/rpmbuild/BUILD/ovirt-engine-3.6.0/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/ipa/SimpleAuthenticationCheck.java:[61,25] error: cannot access InitializingBean 06:29:05 [ERROR] /home/jenkins/workspace/ovirt-engine_master_create-rpms_merged/label/fc21/rpmbuild/BUILD/ovirt-engine-3.6.0/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java:[141,31] error: cannot access DisposableBean 06:29:05 [INFO] 2 errors Full job console output is available here: http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms_merged/label=fc21/2588/console -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] CDI limited capabilities in jboss-as-7.1.1
- Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: devel@ovirt.org Sent: Monday, October 6, 2014 8:23:17 PM Subject: [ovirt-devel] CDI limited capabilities in jboss-as-7.1.1 Hi All, Recently I started using CDI (thanks to Roy Golan contribution) in bll module code and figured the limitation described in (https://issues.jboss.org/browse/AS7-4567). That was solved 1.5 years ago in jboss-as-7.2. Currently we use jboss-as-7.1.1. Is there a good reason for not moving to jboss-as-7.2 or any newer version? Upgrading will help us solving circular dependency problems by being dependent on a bean interface in the compile time and receiving its implementation in the run-time. +1 My main concern is packaging issues. Regards, Yevgeny ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module
- Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com, devel@ovirt.org Sent: Sunday, October 5, 2014 11:31:18 AM Subject: Re: [ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module Hi Yair and All, As soon as you turned our attention to dependencies problems in oVirt, I guess would worse to mention that vdsbroker is directly dependent on dal (very weird to me). That is because some business logic found its way into vdsbroker code and uses dal directly. Using dal should be allowed to bll module only. Next to allowing ourselves using dal in vdsbroker, we've found very creative way to use bll commands in vdsbroker completing by that a circular dependency ring. The current situation when vdsbroker is directly dependent on dal and in fact dependent on bll is sever violation of a good design practice IMHO. I'm in favor solving that dependency mesh asap prior it become more difficult. We should strive to extract the business logic from vdsbroker (and any other module) and move that to bll module where its natural place is, then fix the dependencies chain (that have to be a tree and not any geometric figure). When that will happen, we'd be able to figure more easily what the natural place for AuditLogDirector should be, I guess that'll be utils package. Regards, Yevgeny git grep will show you that it is in VdsBrokerObjectsBuilder which creates the entities from the XMlRpcStruct maps. The calls to AuditLogDirector simply report of various issues during the transformation to the audit log, to be presented at UI. The objects builder class already involves business entities. I agre usage of AuditLogDirector there seems ackward. On 03/10/14 20:03, Yair Zaslavsky wrote: Hi all, I just reviewed a patch regarding AuditLogDirector and I thought to myself - why is it located in DAL? Our maven dependencies are built in a way that both bll and vdsbroker depend on DAL, and if you perform git grep AuditLogDirector you will see it is used by bll and vdsbroker. But that this is not necessary a reason to include AuditlogDirector in DAL. I think DAL should be our Data Access Layer, and for audit log (which is a class that uses our DAOs) we should have a separate module. Thoughts on this are welcome, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] GWT vs. Java
- Original Message - From: Vojtech Szocs vsz...@redhat.com To: devel@ovirt.org Sent: Friday, October 3, 2014 4:29:15 PM Subject: [ovirt-devel] GWT vs. Java Hi guys, I've had a discussion with Roy about GWT vs. Java plans, he asked me to share this information, so here we go. GWT 2.6 === - patch pending merge: http://gerrit.ovirt.org/#/c/32135/ - support for Java 7 language syntax like operator etc. - once patch ^^ is merged, we can consolidate Java language compliance for whole Engine - both frontend and backend can use Java 7 (yey!) GWT 2.7 === - planned support for *only* Java 8 language syntax like lambdas etc. but *without* emulating new Java 8 APIs like streams etc. (Java 8 API emulation should come in GWT 3.0) Likely, GWT 2.7 will remove GWT deRPC implementation on which we currently rely on. (@Martin, can you please share details?) This means that until we move UI to REST API, we can't upgrade post GWT 2.6, so this will put more pressure to work on oVirtJS project in consequence. GWT 3.0 === - ETA early next year? - planned to fully support Java 8 - both language and APIs - one of key highlights is better integration with JavaScript, which fits the scenario where GWT application is one module that's part of bigger application (hybrid approach) Thanks for sharing with us! Can you please elabroate more on this hybrid approach? Cheers, Yair Regards, Vojtech ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] [ENGINE] splitting AuditLogDirector to its own module
Hi all, I just reviewed a patch regarding AuditLogDirector and I thought to myself - why is it located in DAL? Our maven dependencies are built in a way that both bll and vdsbroker depend on DAL, and if you perform git grep AuditLogDirector you will see it is used by bll and vdsbroker. But that this is not necessary a reason to include AuditlogDirector in DAL. I think DAL should be our Data Access Layer, and for audit log (which is a class that uses our DAOs) we should have a separate module. Thoughts on this are welcome, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] ovirt.js OPW project
- Original Message - From: Jenny Kang jennykan...@gmail.com To: devel@ovirt.org Sent: Sunday, September 28, 2014 10:21:57 AM Subject: [ovirt-devel] ovirt.js OPW project Hello! I'm a student and I'm interested in the OPW project, which funds women into open source projects. oVirt is one of the supported projects. I'm really interested in working on the new ovirt.js library which uses the ovirt rest api. I need a mentor for this project. Any suggestions if it's a good idea to work on this? And also anyone interested in mentoring me in this project? I'm not selected yet but I would love to commit some contributions to get a feel of what it's like to work on ovirt.js beforehand. Cheers, Jenny Hi Jenny, In my humble opinion you should be looking for two things - Usage of ovirt.js, but also understanding the oVirt project, and the API itself, regardless of ovirt.js. For example, you can play with the API without ovirt.js , using curl or any other tool of your preference that can send HTTP calls. I cc'ed Juan Hernandez, the API maintainer, and Vojtech Szocs which worked on ovirt.js, but with our questions regarding ovirt, feel free to use both devel@ovirt.org and us...@ovirt.org Hope I could help you a bit, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] ovirt.js OPW project
- Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Jenny Kang jennykan...@gmail.com Cc: devel@ovirt.org Sent: Monday, September 29, 2014 5:09:44 AM Subject: Re: [ovirt-devel] ovirt.js OPW project - Original Message - From: Jenny Kang jennykan...@gmail.com To: devel@ovirt.org Sent: Sunday, September 28, 2014 10:21:57 AM Subject: [ovirt-devel] ovirt.js OPW project Hello! I'm a student and I'm interested in the OPW project, which funds women into open source projects. oVirt is one of the supported projects. I'm really interested in working on the new ovirt.js library which uses the ovirt rest api. I need a mentor for this project. Any suggestions if it's a good idea to work on this? And also anyone interested in mentoring me in this project? I'm not selected yet but I would love to commit some contributions to get a feel of what it's like to work on ovirt.js beforehand. Cheers, Jenny CCed Juan as well. I also recommend to go over feature pages of ovirt to better understand the features. Hi Jenny, In my humble opinion you should be looking for two things - Usage of ovirt.js, but also understanding the oVirt project, and the API itself, regardless of ovirt.js. For example, you can play with the API without ovirt.js , using curl or any other tool of your preference that can send HTTP calls. I cc'ed Juan Hernandez, the API maintainer, and Vojtech Szocs which worked on ovirt.js, but with our questions regarding ovirt, feel free to use both devel@ovirt.org and us...@ovirt.org Hope I could help you a bit, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
- Original Message - From: Roy Golan rgo...@redhat.com To: devel@ovirt.org Sent: Wednesday, September 3, 2014 9:07:47 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils On 08/29/2014 02:52 AM, Yair Zaslavsky wrote: Thanks everyone for your thoughts. I would like to sum things up (as I understood from this thread) - a. We will defer the move to commons collections4. b. We should introduce some class renaming, not have LinqXXX I think those renaming and general refactoring of compat should be a series of bugzilla's we should communicate as entry-level,low-hanging-fruits,you-name-it for new comers to ovirt. c. Later on we can shift to an already maintained package. I wonder how close we are to moving to java8 where all these dependencies (commonsX, LinqWhatever) could go to the waste bin. probably a mix of jboss/rhel/gwt. During one of my lastest patches, I disovered there is also Linq in GWT code. sweet. - Original Message - From: Vojtech Szocs vsz...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, devel@ovirt.org Sent: Thursday, August 28, 2014 4:49:57 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Greg Sheremeta gsher...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: devel@ovirt.org Sent: Monday, August 25, 2014 1:52:44 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: Greg Sheremeta gsher...@redhat.com, Itamar Heim ih...@redhat.com, devel@ovirt.org Sent: Sunday, August 24, 2014 9:51:31 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Alon Bar-Lev alo...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Itamar Heim ih...@redhat.com, devel@ovirt.org Sent: Friday, August 22, 2014 11:36:31 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Greg Sheremeta gsher...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Itamar Heim ih...@redhat.com, devel@ovirt.org Sent: Friday, August 22, 2014 11:33:09 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Alon Bar-Lev alo...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Itamar Heim ih...@redhat.com, devel@ovirt.org Sent: Friday, August 22, 2014 4:20:19 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Greg Sheremeta gsher...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Itamar Heim ih...@redhat.com, devel@ovirt.org, Alon Bar-Lev alo...@redhat.com Sent: Friday, August 22, 2014 8:39:54 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Itamar Heim ih...@redhat.com Cc: devel@ovirt.org Sent: Thursday, August 21, 2014 8:39:31 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Itamar Heim ih...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com, Yevgeny Zaspitsky yzasp...@redhat.com Cc: devel@ovirt.org Sent: Friday, August 22, 2014 12:25:52 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils On 08/21/2014 09:55 AM, Yair Zaslavsky wrote: - Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Moti Asayag masa...@redhat.com, Allon Mureinik amure...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 4:35:33 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils On 21/08/14 12:08, Yair Zaslavsky wrote: - Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: Moti Asayag masa...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Allon Mureinik amure...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 11:26:40 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils It seems like we can try moving to common-collections4. Yum on my Fedora20 computer finds apache-commons-collections4 package. Fortunately somebody packed the jar into for a rpm for us. :-) What about RHEL 6.5? Can you please run a quick check? Unfortunately my happiness was too hasty. Only Fedora people care to be in the forward of the technology... The RHEL ones do not care about that... This is what I remembered. When you responded to the email for the first time , I had a strong deja vu that you tried addressing this issue yourself in the past (commons-collectios4) - due
Re: [ovirt-devel] [ENGINE] - failure to debug GWT
- Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: devel@ovirt.org Sent: Tuesday, September 2, 2014 9:03:19 AM Subject: Re: [ovirt-devel] [ENGINE] - failure to debug GWT Hi, I think you just need to add your hostname where you start the dev mode to /etc/hosts somehow like this: $ hostname myHost than /etc/hosts is: 127.0.0.1 localhost localhost.localdomain localhost4 localhost4.localdomain4 myHost ::1 localhost localhost.localdomain localhost6 localhost6.localdomain6 myHost BTW, any reason you use the -Dgwt.persistentunitcache=false flag explicitly? False should be the default value for persistentunitcache. I'm runnning my debug mode only like this: make gwt-debug DEBUG_MODULE=webadmin Have a nice day, Tomas Many thanks Thomas, it worked! - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: devel@ovirt.org Sent: Tuesday, September 2, 2014 4:14:01 AM Subject: [ovirt-devel] [ENGINE] - failure to debug GWT Hi all, Maybe one can help me in strange debugging issues I have? I am running the debug server using the following line - make gwt-debug DEBUG_MODULE=webadmin DEV_EXTRA_BUILD_FLAGS=-Dgwt.persistentunitcache=false The server listens on port 8000 as expected. I then connect from Eclipse (using remote debug) to port 8000 - and the server crashes, this is what I see - http://pastebin.com/twapYa9N Can anyone help with this? Thanks, Yair (I will also paste here the output) - ERROR] [AppClassLoader@7ffe] info AspectJ Weaver Version 1.6.11 built on Tuesday Mar 15, 2011 at 15:31:04 GMT [ERROR] [AppClassLoader@7ffe] info register classloader sun.misc.Launcher$AppClassLoader@7ffe [ERROR] [AppClassLoader@7ffe] info using configuration file:/home/yzaslavs/.m2/upstream_repository/org/ovirt/engine/ui/gwt-extension/3.6.0-SNAPSHOT/gwt-extension-3.6.0-SNAPSHOT.jar!/META-INF/aop.xml [ERROR] [AppClassLoader@7ffe] info using configuration file:/home/yzaslavs/.m2/upstream_repository/org/ovirt/engine/ui/gwt-extension/3.6.0-SNAPSHOT/gwt-extension-3.6.0-SNAPSHOT-sources.jar!/META-INF/aop.xml [ERROR] [AppClassLoader@7ffe] info register aspect org.ovirt.engine.ui.gwtextension.DontPrune [ERROR] [AppClassLoader@7ffe] info register aspect org.ovirt.engine.ui.gwtextension.DontPrune [ERROR] -bindAddress host 0.0.0.0 unknown [ERROR] Google Web Toolkit 2.5.1 [ERROR] DevMode [-noserver] [-port port-number | auto] [-whitelist whitelist-string] [-blacklist blacklist-string] [-logdir directory] [-logLevel level] [-gen dir] [-bindAddress host-name-or-address] [-codeServerPort port-number | auto] [-server servletContainerLauncher[:args]] [-startupUrl url] [-war dir] [-deploy dir] [-extra dir] [-workDir dir] module[s] [ERROR] [ERROR] where [ERROR] -noserverPrevents the embedded web server from running [ERROR] -portSpecifies the TCP port for the embedded web server (defaults to ) [ERROR] -whitelist Allows the user to browse URLs that match the specified regexes (comma or space separated) [ERROR] -blacklist Prevents the user browsing URLs that match the specified regexes (comma or space separated) [ERROR] -logdir Logs to a file in the given directory, as well as graphically [ERROR] -logLevelThe level of logging detail: ERROR, WARN, INFO, TRACE, DEBUG, SPAM, or ALL [ERROR] -gen Debugging: causes normally-transient generated types to be saved in the specified directory [ERROR] -bindAddress Specifies the bind address for the code server and web server (defaults to 127.0.0.1) [ERROR] -codeServerPort Specifies the TCP port for the code server (defaults to 9997) [ERROR] -server Specify a different embedded web server to run (must implement ServletContainerLauncher) [ERROR] -startupUrl Automatically launches the specified URL [ERROR] -war The directory into which deployable output files will be written (defaults to 'war') [ERROR] -deploy The directory into which deployable but not servable output files will be written (defaults to 'WEB-INF/deploy' under the -war directory/jar, and may be the same as the -extra directory/jar) [ERROR] -extra The directory into which extra files, not intended for deployment, will be written [ERROR] -workDir The compiler's working directory for internal use (must be writeable; defaults to a system temp dir) [ERROR] and [ERROR] module[s]Specifies the name(s) of the module(s) to host [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 6:07.100s [INFO] Finished at: Tue Sep
[ovirt-devel] [ENGINE] - failure to debug GWT
Hi all, Maybe one can help me in strange debugging issues I have? I am running the debug server using the following line - make gwt-debug DEBUG_MODULE=webadmin DEV_EXTRA_BUILD_FLAGS=-Dgwt.persistentunitcache=false The server listens on port 8000 as expected. I then connect from Eclipse (using remote debug) to port 8000 - and the server crashes, this is what I see - http://pastebin.com/twapYa9N Can anyone help with this? Thanks, Yair (I will also paste here the output) - ERROR] [AppClassLoader@7ffe] info AspectJ Weaver Version 1.6.11 built on Tuesday Mar 15, 2011 at 15:31:04 GMT [ERROR] [AppClassLoader@7ffe] info register classloader sun.misc.Launcher$AppClassLoader@7ffe [ERROR] [AppClassLoader@7ffe] info using configuration file:/home/yzaslavs/.m2/upstream_repository/org/ovirt/engine/ui/gwt-extension/3.6.0-SNAPSHOT/gwt-extension-3.6.0-SNAPSHOT.jar!/META-INF/aop.xml [ERROR] [AppClassLoader@7ffe] info using configuration file:/home/yzaslavs/.m2/upstream_repository/org/ovirt/engine/ui/gwt-extension/3.6.0-SNAPSHOT/gwt-extension-3.6.0-SNAPSHOT-sources.jar!/META-INF/aop.xml [ERROR] [AppClassLoader@7ffe] info register aspect org.ovirt.engine.ui.gwtextension.DontPrune [ERROR] [AppClassLoader@7ffe] info register aspect org.ovirt.engine.ui.gwtextension.DontPrune [ERROR] -bindAddress host 0.0.0.0 unknown [ERROR] Google Web Toolkit 2.5.1 [ERROR] DevMode [-noserver] [-port port-number | auto] [-whitelist whitelist-string] [-blacklist blacklist-string] [-logdir directory] [-logLevel level] [-gen dir] [-bindAddress host-name-or-address] [-codeServerPort port-number | auto] [-server servletContainerLauncher[:args]] [-startupUrl url] [-war dir] [-deploy dir] [-extra dir] [-workDir dir] module[s] [ERROR] [ERROR] where [ERROR] -noserverPrevents the embedded web server from running [ERROR] -portSpecifies the TCP port for the embedded web server (defaults to ) [ERROR] -whitelist Allows the user to browse URLs that match the specified regexes (comma or space separated) [ERROR] -blacklist Prevents the user browsing URLs that match the specified regexes (comma or space separated) [ERROR] -logdir Logs to a file in the given directory, as well as graphically [ERROR] -logLevelThe level of logging detail: ERROR, WARN, INFO, TRACE, DEBUG, SPAM, or ALL [ERROR] -gen Debugging: causes normally-transient generated types to be saved in the specified directory [ERROR] -bindAddress Specifies the bind address for the code server and web server (defaults to 127.0.0.1) [ERROR] -codeServerPort Specifies the TCP port for the code server (defaults to 9997) [ERROR] -server Specify a different embedded web server to run (must implement ServletContainerLauncher) [ERROR] -startupUrl Automatically launches the specified URL [ERROR] -war The directory into which deployable output files will be written (defaults to 'war') [ERROR] -deploy The directory into which deployable but not servable output files will be written (defaults to 'WEB-INF/deploy' under the -war directory/jar, and may be the same as the -extra directory/jar) [ERROR] -extra The directory into which extra files, not intended for deployment, will be written [ERROR] -workDir The compiler's working directory for internal use (must be writeable; defaults to a system temp dir) [ERROR] and [ERROR] module[s]Specifies the name(s) of the module(s) to host [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 6:07.100s [INFO] Finished at: Tue Sep 02 04:51:20 IDT 2014 [INFO] Final Memory: 56M/653M [INFO] [WARNING] The requested profile gwt-user could not be activated because it does not exist. [ERROR] Failed to execute goal org.codehaus.mojo:gwt-maven-plugin:2.4.0:debug (default-cli) on project webadmin: Command [[ [ERROR] /bin/sh -c /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.25.x86_64/jre/bin/java -javaagent:/home/yzaslavs/.m2/upstream_repository/org/aspectj/aspectjweaver/1.6.11/aspectjweaver-1.6.11.jar -Xms1024M -Xmx4096M -XX:PermSize=512M -XX:MaxPermSize=1024M \ [ERROR] -Dgwt.jjs.permutationWorkerFactory=com.google.gwt.dev.ThreadedPermutationWorkerFactory \ [ERROR] -Dgwt.jjs.maxThreads=4 \ [ERROR] -Djava.io.tmpdir=/home/yzaslavs/work/ovirt_git/ovirt-engine/frontend/webadmin/modules/webadmin/target/tmp \ [ERROR] -Djava.util.prefs.systemRoot=/home/yzaslavs/work/ovirt_git/ovirt-engine/frontend/webadmin/modules/webadmin/target/tmp/.java \ [ERROR] -Djava.util.prefs.userRoot=/home/yzaslavs/work/ovirt_git/ovirt-engine/frontend/webadmin/modules/webadmin/target/tmp/.java '-Dgwt.dontPrune=org\.ovirt\.engine\.core\.(common|compat)\..*' -Xdebug -Xnoagent
Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
- Original Message - From: Alon Bar-Lev alo...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Itamar Heim ih...@redhat.com, devel@ovirt.org Sent: Friday, August 22, 2014 11:36:31 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Greg Sheremeta gsher...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Itamar Heim ih...@redhat.com, devel@ovirt.org Sent: Friday, August 22, 2014 11:33:09 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Alon Bar-Lev alo...@redhat.com To: Greg Sheremeta gsher...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Itamar Heim ih...@redhat.com, devel@ovirt.org Sent: Friday, August 22, 2014 4:20:19 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Greg Sheremeta gsher...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Itamar Heim ih...@redhat.com, devel@ovirt.org, Alon Bar-Lev alo...@redhat.com Sent: Friday, August 22, 2014 8:39:54 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Itamar Heim ih...@redhat.com Cc: devel@ovirt.org Sent: Thursday, August 21, 2014 8:39:31 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Itamar Heim ih...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com, Yevgeny Zaspitsky yzasp...@redhat.com Cc: devel@ovirt.org Sent: Friday, August 22, 2014 12:25:52 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils On 08/21/2014 09:55 AM, Yair Zaslavsky wrote: - Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Moti Asayag masa...@redhat.com, Allon Mureinik amure...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 4:35:33 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils On 21/08/14 12:08, Yair Zaslavsky wrote: - Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: Moti Asayag masa...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Allon Mureinik amure...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 11:26:40 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils It seems like we can try moving to common-collections4. Yum on my Fedora20 computer finds apache-commons-collections4 package. Fortunately somebody packed the jar into for a rpm for us. :-) What about RHEL 6.5? Can you please run a quick check? Unfortunately my happiness was too hasty. Only Fedora people care to be in the forward of the technology... The RHEL ones do not care about that... This is what I remembered. When you responded to the email for the first time , I had a strong deja vu that you tried addressing this issue yourself in the past (commons-collectios4) - due to different reason. is there a specific conflict or problem (or a huge chain of dependencies) ? To me it seems the answer to both is no - This is the requirement list - java = 1.5 jpackage-utils rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(FileDigests) = 4.6.0-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 rpmlib(PayloadIsXz) = 5.2-1 Probably a matter of packaging? IIRC, Alon was the one who replied, and the issue was that Jboss included an old version (and we don't have classpath isolation, I guess) Greg We would like to avoid maintaining and package components that are not provider either by el6 or jboss distribution. But based on other threads, it seems that I am the only one who remained trying to push compliance to the old ways, people feel that can maintain anything anywhere with no effort. Regards, Alon Alon, I disagree with your comment (about the you're the only one part :) ) As I wrote - I had a strong deja-vu about that the issue was already brought up. Now that you reminded , I don't think you're the only person who feels this way. I would also like to understand more what it means before jumping to conclusions and upgrading to collections4. At past I had some issues with another commons project (commons-configuration) that had different versions upstream and downstream. I am sure the changes include not just move to generics
Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
- Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: Moti Asayag masa...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Allon Mureinik amure...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 11:26:40 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils It seems like we can try moving to common-collections4. Yum on my Fedora20 computer finds apache-commons-collections4 package. Fortunately somebody packed the jar into for a rpm for us. :-) What about RHEL 6.5? Can you please run a quick check? - Original Message - From: Moti Asayag masa...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Allon Mureinik amure...@redhat.com, devel@ovirt.org, Yevgeny Zaspitsky yzasp...@redhat.com Sent: Thursday, August 21, 2014 11:18:53 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Allon Mureinik amure...@redhat.com Cc: Moti Asayag masa...@redhat.com, devel@ovirt.org, Yevgeny Zaspitsky yzasp...@redhat.com Sent: Thursday, August 21, 2014 11:04:13 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Allon Mureinik amure...@redhat.com To: Moti Asayag masa...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 10:53:01 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils IMO, we have too many classes that do the same (useless) thing - org.ovirt.engine.core.utils.linq.LinqUtils and org.ovirt.engine.core.common.utils.ListUtils, which both have no place in oVirt-engine. Why not scrap both of them, upgrade commons-collections to the modern 4.0 and use org.apache.commons.collections4.CollectionUtils which has all of their functionality, fully-tested, and maintained by someone else? Regarding upgrade to 4.0 - IMHO there was some packaging issue. I think Yevgeny Zaspitsky raised the issue at the past. This is the mentioned thread: http://lists.ovirt.org/pipermail/devel/2014-April/007050.html But yeah, if there is no issue there, I'm in favor. - Original Message - From: Moti Asayag masa...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: devel@ovirt.org Sent: Thursday, August 21, 2014 9:04:05 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: devel@ovirt.org Sent: Thursday, August 21, 2014 5:50:44 AM Subject: [ovirt-devel] [ENGINE] thoughts about LinqUtils Hi Engine developers (and others :) ), I would like to share some thoughts questions with you about the future of LinqUtils 1. Location of LinqUtils Currently LinqUtils resides at utils. However, as LinqUtils contains some non engine related code, I think it should be moved to the new uutils (universal utils) project. uutils was introduced during the work on AAA, in order to provide a set of utilities that are not engine related, and hopefully in the future will be published as a separate artifcat on maven central (Alon, feel free to correct me here :) ) +1 You'd probably have to address the entire org.ovirt.engine.core.utils.linq package and not just that specific class. A sort of a clean-up is also required (i.e. remove IDE generated comments), seems like a good chance to do it. 2. The name LinqUtils - Linq comes from c#. I think these days are way behind us (3 years or so now?) i would like to suggest renaming the class. CollectionUtils? Any other suggestions are more than welcome +1 Thanks, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
- Original Message - From: Tal Nisan tni...@redhat.com To: devel@ovirt.org Sent: Thursday, August 21, 2014 12:42:43 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils In general I think that LinqUtils should be deleted as soon as we move to Java 8 and be replaced by standard lambda expressions, that's what most of this class is doing anyway so it pretty much depends on when will we move to Java 8 to decide if it worth the effort now. I like your idea Tal, that's an interesting thought. Yes, indeed you can see some of the code could have been written more elegantly with Lambda On 08/21/2014 05:50 AM, Yair Zaslavsky wrote: Hi Engine developers (and others :) ), I would like to share some thoughts questions with you about the future of LinqUtils 1. Location of LinqUtils Currently LinqUtils resides at utils. However, as LinqUtils contains some non engine related code, I think it should be moved to the new uutils (universal utils) project. uutils was introduced during the work on AAA, in order to provide a set of utilities that are not engine related, and hopefully in the future will be published as a separate artifcat on maven central (Alon, feel free to correct me here :) ) 2. The name LinqUtils - Linq comes from c#. I think these days are way behind us (3 years or so now?) i would like to suggest renaming the class. CollectionUtils? Any other suggestions are more than welcome Thanks, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils
- Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Moti Asayag masa...@redhat.com, Allon Mureinik amure...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 4:35:33 PM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils On 21/08/14 12:08, Yair Zaslavsky wrote: - Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: Moti Asayag masa...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Allon Mureinik amure...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 11:26:40 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils It seems like we can try moving to common-collections4. Yum on my Fedora20 computer finds apache-commons-collections4 package. Fortunately somebody packed the jar into for a rpm for us. :-) What about RHEL 6.5? Can you please run a quick check? Unfortunately my happiness was too hasty. Only Fedora people care to be in the forward of the technology... The RHEL ones do not care about that... This is what I remembered. When you responded to the email for the first time , I had a strong deja vu that you tried addressing this issue yourself in the past (commons-collectios4) - due to different reason. - Original Message - From: Moti Asayag masa...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Allon Mureinik amure...@redhat.com, devel@ovirt.org, Yevgeny Zaspitsky yzasp...@redhat.com Sent: Thursday, August 21, 2014 11:18:53 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Allon Mureinik amure...@redhat.com Cc: Moti Asayag masa...@redhat.com, devel@ovirt.org, Yevgeny Zaspitsky yzasp...@redhat.com Sent: Thursday, August 21, 2014 11:04:13 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Allon Mureinik amure...@redhat.com To: Moti Asayag masa...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, devel@ovirt.org Sent: Thursday, August 21, 2014 10:53:01 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils IMO, we have too many classes that do the same (useless) thing - org.ovirt.engine.core.utils.linq.LinqUtils and org.ovirt.engine.core.common.utils.ListUtils, which both have no place in oVirt-engine. Why not scrap both of them, upgrade commons-collections to the modern 4.0 and use org.apache.commons.collections4.CollectionUtils which has all of their functionality, fully-tested, and maintained by someone else? Regarding upgrade to 4.0 - IMHO there was some packaging issue. I think Yevgeny Zaspitsky raised the issue at the past. This is the mentioned thread: http://lists.ovirt.org/pipermail/devel/2014-April/007050.html But yeah, if there is no issue there, I'm in favor. - Original Message - From: Moti Asayag masa...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: devel@ovirt.org Sent: Thursday, August 21, 2014 9:04:05 AM Subject: Re: [ovirt-devel] [ENGINE] thoughts about LinqUtils - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: devel@ovirt.org Sent: Thursday, August 21, 2014 5:50:44 AM Subject: [ovirt-devel] [ENGINE] thoughts about LinqUtils Hi Engine developers (and others :) ), I would like to share some thoughts questions with you about the future of LinqUtils 1. Location of LinqUtils Currently LinqUtils resides at utils. However, as LinqUtils contains some non engine related code, I think it should be moved to the new uutils (universal utils) project. uutils was introduced during the work on AAA, in order to provide a set of utilities that are not engine related, and hopefully in the future will be published as a separate artifcat on maven central (Alon, feel free to correct me here :) ) +1 You'd probably have to address the entire org.ovirt.engine.core.utils.linq package and not just that specific class. A sort of a clean-up is also required (i.e. remove IDE generated comments), seems like a good chance to do it. 2. The name LinqUtils - Linq comes from c#. I think these days are way behind us (3 years or so now?) i would like to suggest renaming the class. CollectionUtils? Any other suggestions are more than welcome +1 Thanks, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] What does your oVirt development environment look like?
- Original Message - From: ybronhei ybron...@redhat.com To: Adam Litke ali...@redhat.com, devel@ovirt.org Sent: Friday, August 15, 2014 7:36:23 PM Subject: Re: [ovirt-devel] What does your oVirt development environment look like? On 08/15/2014 09:32 AM, Adam Litke wrote: Ever since starting to work on oVirt around 3 years ago I've been striving for the perfect development and test environment. I was inspired by Yaniv's recent deep dive on Foreman integration and thought I'd ask people to share their setups and any tips and tricks so we can all become better, more efficient developers. My setup consists of my main work laptop and two mini-Dell servers. I run the engine on my laptop and I serve NFS and iSCSI (using targetcli) from this system as well. I use the ethernet port on the laptop to connect it to a subnet with the two Dell systems. Some goals for my setup are: - Easy provisioning of the virt-hosts so I can quickly test on Fedora and CentOS without spending lots of time reinstalling - Ability to test block and nfs storage - Automation of test scenarios involving engine and hosts To help me reach these goals I've deployed cobbler on my laptop and it does a pretty good job at managing PXE boot configurations for my hosts (and VMs) so they can be automatically intalled as needed. After viewing Yaniv's presentation, it seems that Forman/Puppet are the way of the future but it does seem a bit more involved to set up. I am definitely curious if others are using Foreman in their personal dev/test environment and can offer some insight on how that is working out. Thanks, and I look forward to reading about more of your setups! If we get enough of these, maybe this could make a good section of the wiki. Heppy to hear :) for those who missed - https://www.youtube.com/watch?v=gozX891kYAY each one has its own needs and goals I guess, but if you say it might help, I'll never say no for sharing :P I have 3 dells under my desk, I compile the engine a lot and its heavy for my laptop. So I clone my local working directory and build it on the strongest mini-dell using local jenkins server (http://www.ovirt.org/Local_Jenkins_For_The_People). The other 2 I use as hypervisor when needed. provision them is done by me manually :/.. cobbler pxe boot could help with already defined image.. Other then that, I have nfs mount for storage and few vms for compilation and small tests Haven't used Jenkins for the people for quite some time, it's awesome though. Yaniv, does your Jenkins build all your local branches? I don't have much to share, my environment is even simpler. I am sure it's a common knowledge but still a reminder (even if a new developer can benefit from it, it will be good) - you can create a database schema per each branch you work on, and if needed to switch between branches, you don't have to destroy your current database. Quite helpful, I must say , for someone who works 100% on engine related stuff. Yair sorry I can't help with your curiosity .. my env quite simple Regards, Yaniv Bronhaim. ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Management network as a role - design proposal
- Original Message - From: Yevgeny Zaspitsky yzasp...@redhat.com To: devel@ovirt.org Cc: rhevm-network-st...@redhat.com Sent: Thursday, August 14, 2014 6:52:41 PM Subject: [ovirt-devel] Management network as a role - design proposal Hi All, The proposed feature will allow defining an arbitrary network in the DC as the management network for the cluster, which in its turn will allow assigning different VLANs for the management networks in the same DC. Feature page can be found here - http://www.ovirt.org/Features/Management_Network_As_A_Role . Please take a look into the page especially into Open issues section. I'd like to have your opinions on that. Hi, is there no way on getting some default value in case you do not pass the network at RESTFul API? Best regards, Yevgeny Zaspitsky ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Can not run application on last master (again...)
Works for me on master- created a clean deployment directory, commit hash - e6c1d6e6e097c2051518ea3818fdf37c166b72e0 - Original Message - From: Eli Mesika emes...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: devel@ovirt.org Sent: Wednesday, July 23, 2014 12:48:57 PM Subject: Re: [ovirt-devel] Can not run application on last master (again...) - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Eli Mesika emes...@redhat.com Cc: devel@ovirt.org Sent: Wednesday, July 23, 2014 12:33:25 PM Subject: Re: [ovirt-devel] Can not run application on last master (again...) Hi Eli, Did you make clean ? DbUser has moved a package, but it should work... I had build to a new deployment directory so I do not expect old binaries to be at all - Original Message - From: Eli Mesika emes...@redhat.com To: devel@ovirt.org Sent: Wednesday, July 23, 2014 12:02:56 PM Subject: [ovirt-devel] Can not run application on last master (again...) Hi Guys Seems that last master is unstable , please see attached server.log and let me know if you have any idea Thanks Eli Mesika ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] [engine] - merging to ovirt-3.5 branch patches that relate to AsyncDataProvider
Hi all, AsyncDataProvider in master is now a singleton with non-static methods, The patch [1] that introduced this change does not reside in ovirt-3.5 branch. Can we please consider backporting to 3.5 to ease merges to that branch? [1] commit hash - 69e57dc94cc30652caa7b790bd5e9a94816b6d8d ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] ovirt test day1 - report
- Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: devel@ovirt.org Sent: Monday, July 7, 2014 4:06:44 AM Subject: [ovirt-devel] ovirt test day1 - report Hi, I tested https://bugzilla.redhat.com/show_bug.cgi?id=1054241 (http://www.ovirt.org/Feature/OvfOnWantedDomains) The feature worked ok. I have tested with disks located on several storage domains. In addition, I did try to look a abit at the code. I have a question - What happens if we suffer from a placeholder/empty vdsm task id due to a crash of engine? I'm asking as I see that UploadStreamParameters has @JsonIgnore on the input stream. ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Engine - Changes to various issues around commands and queries construction and internal execution - please read
Hi all,
Thanks to the help of Alon, oved, Tal, Moti, Arik and others, the following
changes were introduced:
1. Internal commands invocation -
When invoking an internal command from a command, please use the following :
Instead of Backend.getInstance().runInternalAction...
Use
runInternalAction - a new method that was introdced at CommandBase.
This method has two variants - one that accepts command context, and the other
that does not have a command contet -
runInternalAction(VdcActionType,VdcActionParametersBase,CommandContext)
and
runInternalAction(VdcActionType,VdcActionParametersBase)
If CommandContext is not passed the context at the calling command will be
cloned and set at the child command.
If a Command context is pased - it should be the responsibility of the caller
to clone, however, this will give the caller some degree of freedom to
determine whether various
parts of the context will be cloned, or not.
Examples:
runInternalAction(VdcActionType.AddPermission, permissionParams) has the same
effect as : runInternlAction(VdcActionType.AddPermissiosn, permissionParams,
getContext().clone())
runInternlAction(VdcActionType.AddPermissiosn, permissionParams,
getContext().clone().withoutCompensationContext()) - will cause the
compensation context to be reset, and let the child command determine the value
of compensation context (at handleTransactivity method).
The complete list of context alteration methods are -
withCompensationContext(CompensationContext) , withoutCompensationContext()
withLock(EngineLock), withoutLock()
withExecutionContext(ExecutionContext), withoutExecutionContext() - bare in
mind that all these follow the chaining method design pattern [1] (I would
like to thank Moti for the naming suggestions)
two methods for running InternalAction with context for tasks were created:
runInternalActionWithTasksContext(VdcActionType, VdcActionParametersBase)
runInternalActionWithTasksContext(VdcActionType, VdcActionParametersBase,
EngineLock)
These methods use ExecutionHandler.createDefaultContextForTasks to create the
relevant command context to be passed to the child command.
runInternalMultipleActions was introduced to command base in a similar manner,
with 3 versions:
runInternalMultipleActions(VdcActionType, ArrayListVdcActionParametersBase)
runInternalMultipleActions(VdcActionType, ArrayListVdcActionParametersBase,
ExecutionContext)
runInternalMultipleActions(VdcActionType, ArrayListVdcActionParametersBase,
CommandContext)
2. Queries invocation -
runInternalQuery(VdcQueryType, VdcQueryParametersBase) was introduced to
command base.
Basically it takes the engine context from the current command context, and
runs the internal query with it.
EngineContext is the context which should hold all the common attributes to our
flows at engine - currently it holds the engineSessionId, working towards
moving correlationId to it as well.
3. Commands Queries coding
Each internal query should have a ctor that takes the parameters, and also the
engine context .
As some of the queries are both internal and non internal you may have two
ctors - one with parameters only, one with parameters and EngineContext
for example
public class GetUnregisteredDiskQueryP extends
GetUnregisteredDiskQueryParameters extends QueriesCommandBaseP {
public GetUnregisteredDiskQuery(P parameters) {
this(parameters, null);
}
public GetUnregisteredDiskQuery(P parameters, EngineContext context) {
super(parameters, context);
}
Notice that the ctor without the context calls the one with the context.
Same happens at Commands:
public RemovePermissionCommand(T parameters) {
this(parameters, null);
}
public RemovePermissionCommand(T parameters, CommandContext commandContext)
{
super(parameters, commandContext);
}
4. runVdsCommand was introduced to CommandBase as well
runVdsCommand(VDSCommandType, VdsCommandParameters) - currently this just runs
the vds command on vds broker, working on propagating the engine context via
vds broker as well.
Please use the above in your code. If you see any issues , or places where its
problematic to use, feel free to contact me.
[1]
http://en.wikipedia.org/wiki/Method_chaining
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Annotating internal commands
Hi, Some of you already got or will get emails from me asking if several commands are only internal or not. I basically check usages at rest-api and ui, but I might have missed something. IMHO, we should continue (until we device not to :) ) to annotate internal commands with the @InternalCommandAttribute Thanks, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Testing backported changes
- Original Message - From: Moti Asayag masa...@redhat.com To: Lior Vernia lver...@redhat.com Cc: Kobi Ianko k...@redhat.com, devel@ovirt.org Sent: Monday, June 23, 2014 11:31:33 PM Subject: Re: [ovirt-devel] Testing backported changes - Original Message - From: Lior Vernia lver...@redhat.com To: Kobi Ianko k...@redhat.com Cc: devel@ovirt.org Sent: Monday, June 23, 2014 5:10:04 PM Subject: Re: [ovirt-devel] Testing backported changes I use a different DB for each version I'm backporting to, highly recommended. The only (moderate) pain is to reinstall hosts when moving between versions (assuming you're using the same hosts). +1 In addition, you can use a vm as a host for 3.4 (fakeqemu/nested) instead re-installing the host. Moti, That's a great idea! I would like to add that you might also find the need to have different maven repositories for different versions. You can have it nicely down (IMHO ) with alternatives + symlinks or just symlinks + some script. On 23/06/14 16:47, Kobi Ianko wrote: Hi, Is there a nice way to check changes I backported to 3.4.1 without messing my 3.5 DB? 10x ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] Correct way to run internal actions from commands
- Original Message - From: Gilad Chaplik gchap...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: devel@ovirt.org Sent: Thursday, June 19, 2014 11:14:35 AM Subject: Re: [ovirt-devel] Correct way to run internal actions from commands We should enforce that in code level: getBackend() should be private in CommandBase, and won't need any convention. Using getBackend() is also a convention. Thanks, Gilad. - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: devel@ovirt.org Sent: Wednesday, June 18, 2014 8:44:41 AM Subject: [ovirt-devel] Correct way to run internal actions from commands Hi all, Thanks to the collaboration of some of the maintainers and others I have managed to merge a patch which gives the ability to run internal commands the following way: If you're writing a code in a class that extends CommandBase, please follow the following instructions: Instead of Backend.getInstance().runInternalAction (or MultipleActions) you should use runInternalAction More patches will be added for running internal queries , and probably endAction as well. Thanks, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Question/thoughts about our engine logging framework
Hi all, During my recent work on AAA, I was suggested by Juan Hernandez to use slf4j logging framework which serves as a facade for other logging frameworks (including java utils logging which is now used by jboss), log4j and others. I have accepted Juan's offer, and then when looking at our LogFactory class I have noticed we use commons logging. Several thoughts/questions - A. Why continue use our own wrapper as slf4j is already a facade. b. I think we should move cross java code to slf4j. What do you think on this point? Some reading material - http://javarevisited.blogspot.com.au/2013/08/why-use-sl4j-over-log4j-for-logging-in.html http://stackoverflow.com/questions/3222895/what-is-the-issue-with-the-runtime-discovery-algorithm-of-apache-commons-logging Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] REST-API - supported user name formats
- Original Message - From: Itamar Heim ih...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com, devel@ovirt.org Sent: Tuesday, June 3, 2014 12:19:03 PM Subject: Re: [ovirt-devel] REST-API - supported user name formats On 05/28/2014 05:16 AM, Yair Zaslavsky wrote: Hi, Do we need to support a format of user name like profile\user for REST-API authentication? (if you're not familiar with the term profile, I can ask the same about domain\user I see in the code it exists, but I was wonder whether it is really needed. Thanks for any thoughts on this, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel iirc, we only support the upn format for the rest api. assuming any authentication provider can be treated as a domain, and qualify for the upn format - why would we add the domain\user format? I tend to agree, I was asking to see if someone has other knowledge. ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [ovirt-devel] how to call the SW part of instance type?
- Original Message - From: Lior Vernia lver...@redhat.com To: Tomas Jelinek tjeli...@redhat.com Cc: devel@ovirt.org Sent: Monday, June 2, 2014 1:26:34 AM Subject: Re: [ovirt-devel] how to call the SW part of instance type? On 30/05/14 15:17, Tomas Jelinek wrote: Hey all, in the instance type feature [1] there are two parts, the instance types (HW part of the machine) and the something not sure how to call (which is basically a disk image with some SW related metadata like OS type). It is inspired by the Amazon's Instance Type + AMI. Since it's similar to the existing concept of image maybe the two can be merged; e.g. the existing one could be extended, or another type of image could be added (I think there are quite a few already). If not, then how about Payload? VM Payload? I'm thinking of instance type as a container, and this would be what goes inside the container. IIRC we already have VM payload. Currently, the handling of the HW part is merged upstream (some small parts missing but mostly there) but the software part is not. I'd like to start implementing it and wanted to ask the community how to call it. Normally it would be called image, but since we already have images in oVirt it would be confusing. I see this options how to call it, please feel free to comment on them, vote for some or propose a new name (please keep in mind that the HW part is called Instance Type). - Instance Image - Software Profile +1 on that one (Software profile) - OMI (oVirt Machine Image) - System Image - ITI (Instance Type Image) Thank you, Tomas [1]: http://www.ovirt.org/Features/Instance_Types ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] REST-API - supported user name formats
Hi, Do we need to support a format of user name like profile\user for REST-API authentication? (if you're not familiar with the term profile, I can ask the same about domain\user I see in the code it exists, but I was wonder whether it is really needed. Thanks for any thoughts on this, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Small reminder about 0000_config.sql
Hi all, and happy holidays. I would like to give a small reminder about the contents of _config.sql - We are trying to keep an alphabetical order when it comes to the option names (the keys). Thanks, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
[ovirt-devel] Question about plan/work for javascript SDK
Hi, Unfortunately I could not attend the tech talk Vojtech presented this week (I did attend the 2nd one about UI-Plugins and Anjular JS). I was wondering if 3rd party developers will be able to use the ovirt.js library/framework for developing JS-based tools around oVirt (let's say - using the MEAN stack). Not sure how much we gave thought to this, so I'm asking here Thanks for any insights on this, Yair ___ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
Re: [Engine-devel] Tweaking backup/restore of engine
- Original Message - From: Sven Kieske s.kie...@mittwald.de To: engine-devel@ovirt.org Sent: Tuesday, March 4, 2014 10:25:31 AM Subject: Re: [Engine-devel] Tweaking backup/restore of engine Thanks for the clarification, I couldn't find this change any more, but I knew there was something done. However this makes me think about an RFE: It would be cool if ovirt could provide a way to use the REST-API without always have to login and logout. Maybe something like a hook into some message passing queue like rabbitMQ or zeroMQ or a similar process for receiving and submitting messages. So you could register once with an API consumer and use that. What do you think? CC'ing Juan - the maintainer of the REST API Am 04.03.2014 07:53, schrieb Yair Zaslavsky: Hi Sven, This is not entirely accurate - The solution introduced at commit hash cb56de8808cec33b7599828ead890f52e32bcaea solves the problem for a specific case in which we have a multiple login in a very short interval of time - mainly due to attempt to login from webadmin, while UI plugin tries to login as well. We have an anti flood mechanism for events, allowing us to define an interval, in which an event will not be logged twice. In the case of the login event this is set to 5 seconds, which is enough to solve the above described scenario. -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Tweaking backup/restore of engine
- Original Message - From: Sven Kieske s.kie...@mittwald.de To: engine-devel@ovirt.org Sent: Monday, March 3, 2014 6:25:39 PM Subject: [Engine-devel] Tweaking backup/restore of engine Hi, currently all events are stored in the table audit_log which all gets saved when you use the engine-backup shell script. the event log is full of these login lines (engine 3.3.2): 25652 fdfc627c-d875-11e0-90f0-83df133b58ccadmin@internal ---- \N \N \N \N \N 2014-01-20 06:39:17.222+01 USER_VDC_LOGIN 30 0 User admin@internal logged in.f \N \N ----\N \N \N \N----\N oVirt -1 30 f \N this makes the log and db grow very large when you use the REST-API to query ovirt for various data. Is this necessary for a working restore? It would be cool if we could tweak the engine-backup tool to just dump necessary tables so you don't have to restore events from the past no one is interested in. How does ovirt react, if I do not restore the content of the audit_log table? If this works (restore without audit_log) I would prefer to have this code upstream in ovirt git so I don't have to maintain my own backupscript. Would it be possible to extend the existing backupscript with a switch to not backup logs? Currently it's just all or just db. I also recall that there shouldn't occur multiple login events any more since ovirt 3.3. but it still seems to be the case. Hi Sven, This is not entirely accurate - The solution introduced at commit hash cb56de8808cec33b7599828ead890f52e32bcaea solves the problem for a specific case in which we have a multiple login in a very short interval of time - mainly due to attempt to login from webadmin, while UI plugin tries to login as well. We have an anti flood mechanism for events, allowing us to define an interval, in which an event will not be logged twice. In the case of the login event this is set to 5 seconds, which is enough to solve the above described scenario. I also do not understand how you would manage a stored authentication via REST as REST is stateless. I would appreciate any feedback or thoughts on this topic. -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH Co. KG Königsberger Straße 6 32339 Espelkamp T: +49-5772-293-100 F: +49-5772-293-333 https://www.mittwald.de Geschäftsführer: Robert Meyer St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] proposing Arik Hadas as a maintainer of engine core
+1 - Original Message - From: Michal Skrivanek michal.skriva...@redhat.com To: Itamar Heim ih...@redhat.com, Livnat Peer lp...@redhat.com, Omer Frenkel ofren...@redhat.com, Doron Fediuck dfedi...@redhat.com, Yair Zaslavsky yzasl...@redhat.com, Maor Lipchuk mlipc...@redhat.com, Roy Golan rgo...@redhat.com, Eli Mesika emes...@redhat.com, Mike Kolesnik mkole...@redhat.com, Moti Asayag masa...@redhat.com, Shahar Havivi shav...@redhat.com, ov...@redhat.com, Allon Mureinik amure...@redhat.com Cc: engine-devel@ovirt.org, in...@ovirt.org Sent: Thursday, January 30, 2014 10:47:46 AM Subject: proposing Arik Hadas as a maintainer of engine core Dear engine-core maintainers, I'd like to propose Arik Hadas as a maintainer of oVirt engine backend Since he started with oVirt project in October 2012 he was working in various areas in engine core, demonstrated his abilities with more than 200 patches merged to engine master alone. Tons of migration related fixes, refactoring of legacy code, but also new complex features including complementary patches in UI, REST and VDSM code (e.g. Live Snapshots with RAM, locking improvements for VMTemplate operations) Thanks in advance for your response. Thanks, michal ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] bug-url requirement for stable branch backports
- Original Message - From: Itamar Heim ih...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, January 30, 2014 4:42:17 PM Subject: [Engine-devel] bug-url requirement for stable branch backports I'm inclined to drop the bug-url is required for engine stable branch 3.4, until we GA 3.4, as a lot of the patches are for pre-GA features. 3.3 stable branch still has this requirement of course. thoughts anyone? +1 Thanks, Itamar ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] feature page for Authentication Rewrite
Hi all, I wrote a wiki page for the authentication rewrite effort that Juan Hernandez and I worked on http://www.ovirt.org/Features/Authentication-Rewrite Feel free to share your comments. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Copy reviewer scores on trivial rebase/commit msg changes
- Original Message - From: Itamar Heim ih...@redhat.com To: Dan Kenigsberg dan...@redhat.com Cc: engine-devel engine-devel@ovirt.org, vdsm-de...@lists.fedorahosted.org Sent: Sunday, January 19, 2014 10:20:33 AM Subject: Re: [Engine-devel] Copy reviewer scores on trivial rebase/commit msg changes On 01/19/2014 02:48 AM, Dan Kenigsberg wrote: On Sat, Jan 18, 2014 at 01:48:52AM +0200, Itamar Heim wrote: I'd like to enable these - comments welcome: 1. label.Label-Name.copyAllScoresOnTrivialRebase If true, all scores for the label are copied forward when a new patch set is uploaded that is a trivial rebase. A new patch set is considered as trivial rebase if the commit message is the same as in the previous patch set and if it has the same code delta as the previous patch set. This is the case if the change was rebased onto a different parent. This can be used to enable sticky approvals, reducing turn-around for trivial rebases prior to submitting a change. Defaults to false. 2. label.Label-Name.copyAllScoresIfNoCodeChange If true, all scores for the label are copied forward when a new patch set is uploaded that has the same parent commit as the previous patch set and the same code delta as the previous patch set. This means only the commit message is different. This can be used to enable sticky approvals on labels that only depend on the code, reducing turn-around if only the commit message is changed prior to submitting a change. Defaults to false. https://gerrit-review.googlesource.com/Documentation/config-labels.html I think that the time saved by these copying is worth the dangers. But is there a way to tell a human ack from an ack auto-copied by these options? It's not so fair to blame X for X approved this patch when he only approved a very similar version thereof. I think the ideas are good, regarding a way to mark if this is human ack or not - can the process of copying post a comment that copying occurred? we'll find out when we enable it. Assuming that a clean rebase can do no wrong is sometimes wrong (a recent example is detailed by Nir's http://gerrit.ovirt.org/21649/ ) of course it can do wrong, but that's the exception usually. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] how to change user password in webadmin?
Hi, Are you referring to the internal user or to a user that you added from an LDAP directory? For LDAP-based users, we currently have no option to change the password. - Original Message - From: JustMan wang.tia...@qq.com To: engine-devel engine-devel@ovirt.org Sent: Monday, January 13, 2014 10:42:40 AM Subject: [Engine-devel] how to change user password in webadmin? Hi ALL: I Install oVirt, It's work great, but I can not find where can change user's password. Any suggest？ Many thanks. ike 2014-01-13 ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] IMPORTANT: FindBugs threshold update
- Original Message - From: Allon Mureinik amure...@redhat.com To: Moti Asayag masa...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Oved Ourfalli ov...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Monday, January 6, 2014 6:44:48 PM Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update - Original Message - From: Moti Asayag masa...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Oved Ourfalli ov...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Thursday, January 2, 2014 11:46:29 AM Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Moti Asayag masa...@redhat.com Cc: Oved Ourfalli ov...@redhat.com, Eyal Edri ee...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Thursday, January 2, 2014 11:12:17 AM Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update - Original Message - From: Moti Asayag masa...@redhat.com To: Oved Ourfalli ov...@redhat.com, Eyal Edri ee...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, January 2, 2014 12:08:43 AM Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update - Original Message - From: Oved Ourfalli ov...@redhat.com To: engine-devel engine-devel@ovirt.org, Allon Mureinik amure...@redhat.com, Alissa Bonas abo...@redhat.com Sent: Wednesday, January 1, 2014 4:25:50 PM Subject: [Engine-devel] IMPORTANT: FindBugs threshold update Hi all, Up until now the jenkins jobs on the gerrit patches included a findbugs job, that failed only in case of a warning of level NORMAL or higher. Now we update this threshold to fail on any findbugs warning, including LOW ones. Moti - 1. Aren't use running a local jenkins instance on one of your hosts? Maybe Eyal can publish the findbugs job? Well...that server is on maintenance for quite a while... 2. What about running the findbugs UI? I find it kinda handy... The findbugs UI expects the xml created by findbugs with all of the violations. The question is how those violation are created ? where are the rules by which findbugs verifies the code (can be findbugs jar or jenkins findbugs plugin or other...). Currently by running 'mvn findbugs:findbugs' i don't get a a single xml aggregating all of the violations and the produced ones contain a lot of warnings. So I'd like to know how can i be able to run this test locally ? You're missing the profile with the project's exclusions. What you'd want to do is probably this: mvn findbugs:check -Pfindbugs-general This way you won't have to go over any report, you will just fail the build if you introduce a regression. Thanks Allon, This worked - however - you get a full textual description of the bug and not the code. In some cases one may want to filter out a specific bug report, so the bug code is important. Do you know by any chance how to produce this using mvn findbugs ? Yair Could you provide instructions of running findbugs locally and how to evaluate the result the same as done by the jenkins job ? Please make sure to rebase your current patches and check that the findbugs job finish successfully. It will probably fail without a rebase, as the last patches clearing the warnings were merged a few hours ago. Kodus to everyone involved in clearing all the LOW level warnings... mostly Allon and Alissa, but others helped as well! :-) Well done! Great news - good work guys! Cheers, Oved ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] IMPORTANT: FindBugs threshold update
- Original Message - From: Moti Asayag masa...@redhat.com To: Oved Ourfalli ov...@redhat.com, Eyal Edri ee...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, January 2, 2014 12:08:43 AM Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update - Original Message - From: Oved Ourfalli ov...@redhat.com To: engine-devel engine-devel@ovirt.org, Allon Mureinik amure...@redhat.com, Alissa Bonas abo...@redhat.com Sent: Wednesday, January 1, 2014 4:25:50 PM Subject: [Engine-devel] IMPORTANT: FindBugs threshold update Hi all, Up until now the jenkins jobs on the gerrit patches included a findbugs job, that failed only in case of a warning of level NORMAL or higher. Now we update this threshold to fail on any findbugs warning, including LOW ones. Moti - 1. Aren't use running a local jenkins instance on one of your hosts? Maybe Eyal can publish the findbugs job? 2. What about running the findbugs UI? I find it kinda handy... Could you provide instructions of running findbugs locally and how to evaluate the result the same as done by the jenkins job ? Please make sure to rebase your current patches and check that the findbugs job finish successfully. It will probably fail without a rebase, as the last patches clearing the warnings were merged a few hours ago. Kodus to everyone involved in clearing all the LOW level warnings... mostly Allon and Alissa, but others helped as well! :-) Well done! Great news - good work guys! Cheers, Oved ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Strange findbugs warning for a phantom class
I saw this today as well - findbugs showed new warnings for jsonrpc java client code , but my patches are not rebased against that work (the jsonrpc code is not merged to master). - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Moti Asayag masa...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, January 2, 2014 11:54:28 PM Subject: Re: [Engine-devel] Strange findbugs warning for a phantom class - Original Message - From: Moti Asayag masa...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, January 2, 2014 7:40:47 PM Subject: [Engine-devel] Strange findbugs warning for a phantom class It seems that findbugs complains [1] about a class which never existed in ovirt-engine (a job which is run per pushed patch): org.ovirt.engine.core.authentication.tls.TlsSocketFactoryN I can only say what is the source of this class - the AAA rewrite Juan and I are working on. This produces too much noise in gerrit. I'm not sure what is the origin of the class, but i was under the assumption that findbugs should be run for each patch on a clean env, without leftovers from job on other patches. Any idea how to clear this class/error ? +1 on Moti's question - I think I saw this behavior last week as well. [1] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/3269/findbugsResult/? Thanks, Moti ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Proposal to add Juan Hernandez as maintainer to api/sdk/cli
- Original Message - From: Omer Frenkel ofren...@redhat.com To: Michael Pasternak mpast...@redhat.com Cc: engine-devel engine-devel@ovirt.org, infra in...@ovirt.org Sent: Tuesday, December 17, 2013 11:04:00 AM Subject: Re: Proposal to add Juan Hernandez as maintainer to api/sdk/cli - Original Message - From: Michael Pasternak mpast...@redhat.com To: engine-devel engine-devel@ovirt.org, infra in...@ovirt.org Sent: Monday, December 16, 2013 5:34:36 PM Subject: Proposal to add Juan Hernandez as maintainer to api/sdk/cli Juan has worked on oVirt for a long period of time, developing several features in the different areas (including api and cli), and obviously gained a lot of experience and knowledge, I'd like to propose Juan as a maintainer of the api/sdk/cli projects. +1 -- Michael Pasternak RedHat, ENG-Virtualization RD ___ Infra mailing list in...@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Infra mailing list in...@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] [jenkins] dao tests broken
Worked for me perfectly on master. - Original Message - From: Ohad Basan oba...@redhat.com To: Gilad Chaplik gchap...@redhat.com Cc: engine-devel engine-devel@ovirt.org, infra in...@ovirt.org Sent: Sunday, December 15, 2013 1:44:08 PM Subject: Re: [Engine-devel] [jenkins] dao tests broken this job doesn't do any rebase where do you see it ? http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/5446/console I didn't find rebase in the console log - Original Message - From: Gilad Chaplik gchap...@redhat.com To: Eyal Edri ee...@redhat.com Cc: engine-devel engine-devel@ovirt.org, infra in...@ovirt.org Sent: Sunday, December 15, 2013 1:06:04 PM Subject: Re: [Engine-devel] [jenkins] dao tests broken - Original Message - From: Eyal Edri ee...@redhat.com To: engine-devel engine-devel@ovirt.org Cc: infra in...@ovirt.org, Gilad Chaplik gchap...@redhat.com Sent: Sunday, December 15, 2013 12:10:11 PM Subject: [jenkins] dao tests broken fyi, dao tests are broken for some time now, who can look into it? current failing tests are: Hi Eyal, what fails is unit tests and not dao tests (fails on dao job), it looks like you're trying to rebase ovirt-engine-3.3 on top of master (you can see it even it the log, comparing the last success and first fail jobs). can you check it out? Thanks, Gilad. Tests in error: testAdUserConstrcutor(org.ovirt.engine.core.common.users.VdcUserTest): org.ovirt.engine.core.common.businessentities.LdapUser.setPassword(Ljava/lang/String;)V testAdUserAndFalseBooleanConstrcutor(org.ovirt.engine.core.common.users.VdcUserTest): org.ovirt.engine.core.common.businessentities.LdapUser.setPassword(Ljava/lang/String;)V testAdUserAndTrueBooleanConstrcutor(org.ovirt.engine.core.common.users.VdcUserTest): org.ovirt.engine.core.common.businessentities.LdapUser.setPassword(Ljava/lang/String;)V getUserFQN(org.ovirt.engine.core.common.users.VdcUserTest): org.ovirt.engine.core.common.businessentities.LdapUser.setPassword(Ljava/lang/String;)V http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/5446/console looks like it started after commit : http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/5438/ core: scheduling: handle cpu load duration (detail / gitweb) Eyal. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Adding users and assigning roles in Ovirt
- Original Message - From: Einav Cohen eco...@redhat.com To: Malini Rao m...@redhat.com Cc: Oved Ourfalli ov...@redhat.com, engine-devel@ovirt.org Sent: Monday, December 2, 2013 9:55:45 PM Subject: Re: [Engine-devel] Adding users and assigning roles in Ovirt - Original Message - From: Malini Rao m...@redhat.com Sent: Monday, December 2, 2013 2:20:06 PM Joining in the thread a bit green but wouldn't it be ok to add the new user with the most basic permissions by default ( may be just read only permissions)until the admin goes and deliberately tweaks permissions or assigns a role? this is similar to what Oved has suggested, but I think that it won't really make any difference, since there is very little chance, in my view, that these permissions would be sufficient for anything - the admin would need to assign additional/different permissions at some point anyway, so not much point in allowing that default minimal assignment in the first place - we might as well keep the 'Add User(s)' dialog as is. Also, if we add that roles drop down as Einav mentioned, isn't there a way to only show that drop down if the logged in user is an admin role? the logged in user must be an admin, as the 'Add User(s)' dialog (which is available from the Users main tab) exists only in the web-admin, which is accessible only to admins by definition. +1 on the user adding wizard. I think in general connecting related task flows together will improve the overall UX too. +1 here agreed. Thanks Malini - Original Message - From: Einav Cohen eco...@redhat.com To: Gilad Chaplik gchap...@redhat.com, Ramesh rnach...@redhat.com, Oved Ourfalli ov...@redhat.com Cc: engine-devel@ovirt.org Sent: Monday, December 2, 2013 1:37:57 PM Subject: Re: [Engine-devel] Adding users and assigning roles in Ovirt we should definitely not completely remove the possibility to add permission-less users to the system, due to possible use-cases as Gilad mentioned and/or simply to allow the flexibility of adding the user first, and only then adding the relevant (business entity and) permissions, should the admin choose to do so. the more correct location to add system permissions to a user would probably be a 'Add System Permission' dialog that will be available from the Permissions sub-tab of the Users main tab, however it won't allow to assign system permissions to several users at once, so I understand the need for this ability within the 'Add User(s)' dialog. I think that adding an allow user to login check-box would not be good enough, since once a user would be able to login, he won't be able to do (or even see) anything (well, other than the 'Blank' Template, maybe), so the admin would need to assign additional permissions to this user anyway. The minimal solution in my view is to add a assign these users the following system permissions check-box, with a Roles drop down; as Gilad mentioned - need to be very careful with that, as system-wide permissions are powerful. A more comprehensive solution (more complex for implementation) would probably be, as Oved mentioned, some sort of a user-adding-wizard, that will allow easy permissions-assignment (maybe even not only system-wide permissions) to the newly-added users. Thanks, Einav - Original Message - From: Gilad Chaplik gchap...@redhat.com To: Oved Ourfalli ov...@redhat.com Cc: engine-devel@ovirt.org Sent: Monday, December 2, 2013 3:47:56 AM Subject: Re: [Engine-devel] Adding users and assigning roles in Ovirt Hi Ramesh, You're right, I also think that the 'add users' is a bit pointless, but adding a system permission in that dialog can be dangerous (if admin doesn't fully understand what he's doing, and MLA is complicated enough ;-) ). Currently when adding a permission we can specify a AD-user (regardless to the fact he's added or not), So eventually power users can add users to the system. I can think of a case, that admins will want to manage the users by themselves, i.e- power users can add permissions for the added users only. this way this dialog can be useful. Thanks, Gilad. - Original Message - From: Oved Ourfalli ov...@redhat.com To: Ramesh rnach...@redhat.com Cc: engine-devel@ovirt.org Sent: Monday, December 2, 2013 9:01:52 AM Subject: Re: [Engine-devel] Adding users and assigning roles in Ovirt Your E-mail made me look a bit and check the different flows. I think the only use-case for adding users without giving any permissions is when you add a user for notification reasons. You can add a user, and then in the Event Notifier sub-tab define what events he will get via E-mail. afaik (and I'm not an event notifier expert),
[Engine-devel] How to validate no arg ctor existence in params?
Hi, I saw several patches that fixed serialization (json or gwt) issues that were introduced due to non existence of no-arg CTOR for parameters. Does anyone know a way to validate this using let's say some jenkins plugin? Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] How to validate no arg ctor existence in params?
- Original Message - From: Tal Nisan tni...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Monday, October 7, 2013 4:56:52 PM Subject: Re: [Engine-devel] How to validate no arg ctor existence in params? Perhaps it can be done by writing a custom checkstyle plugin? Allon wrote one for alerting when using a static class members initialization in certain packages, he might know. +1 Martin Perina also remembered something like that. Anyway, I strongly recommend it should be done. Already corresponding with Allon on it. On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: Hi, I saw several patches that fixed serialization (json or gwt) issues that were introduced due to non existence of no-arg CTOR for parameters. Does anyone know a way to validate this using let's say some jenkins plugin? Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] How to validate no arg ctor existence in params?
Yes, The patch by Vojtech should do this, can we push this forward? - Original Message - From: Tal Nisan tni...@redhat.com To: Einav Cohen eco...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Monday, October 7, 2013 5:06:52 PM Subject: Re: [Engine-devel] How to validate no arg ctor existence in params? On 10/07/2013 05:04 PM, Einav Cohen wrote: - Original Message - From: Yair Zaslavsky yzasl...@redhat.com Sent: Monday, October 7, 2013 10:02:39 AM - Original Message - From: Tal Nisan tni...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Monday, October 7, 2013 4:56:52 PM Subject: Re: [Engine-devel] How to validate no arg ctor existence in params? Perhaps it can be done by writing a custom checkstyle plugin? Allon wrote one for alerting when using a static class members initialization in certain packages, he might know. +1 Martin Perina also remembered something like that. Anyway, I strongly recommend it should be done. Already corresponding with Allon on it. I might be missing something, but isn't that what patch http://gerrit.ovirt.org/#/c/18910/ does? Seems like it, Yair I saw you also reviewed it, from a brief look at the code it looks like it checks for a default constructor existence as well as some other criterias On 10/07/2013 04:52 PM, Yair Zaslavsky wrote: Hi, I saw several patches that fixed serialization (json or gwt) issues that were introduced due to non existence of no-arg CTOR for parameters. Does anyone know a way to validate this using let's say some jenkins plugin? Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] fake VDSM as oVirt project?
+1 - Original Message - From: Yaniv Bronheim ybron...@redhat.com To: Itamar Heim ih...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Liran Zelkha liran.zel...@gmail.com, infra in...@ovirt.org Sent: Sunday, September 15, 2013 8:11:05 PM Subject: Re: [Engine-devel] fake VDSM as oVirt project? +1 - Original Message - From: Itamar Heim ih...@redhat.com To: Liran Zelkha liran.zel...@gmail.com Cc: engine-devel engine-devel@ovirt.org, infra in...@ovirt.org Sent: Sunday, September 15, 2013 12:57:29 PM Subject: Re: [Engine-devel] fake VDSM as oVirt project? On 09/13/2013 09:52 AM, Liran Zelkha wrote: +1 I use it constantly. +1 adding infra, where new git repo's are usually requested. (we also ask board if a new project scope, but this seems like just a repo for a help/test program) if more +1's and no objections, ping next week to create repo. thanks, Itamar On Fri, Sep 13, 2013 at 8:48 AM, Tomas Jelinek tjeli...@redhat.com mailto:tjeli...@redhat.com wrote: Hi all, some time ago Libor Spevak created a simple web app called vdsm fake: documented: http://www.ovirt.org/VDSM_Fake published: https://github.com/lspevak/ovirt-vdsmfake It is basically a simple hackable java web application which can emulate the VDSM so you can connect the engine to it. It is especially useful for: - having tons of cheap fake hosts on one machine to stress your engine - doing some experiments with VDSM API (e.g. vfeenstr proposes a new VDSM API to lower the network traffic between engine - VDSM and uses the vdsm fake to implement it and do some tests to get some numbers on how does this change the things) Omer came up with an idea of making this app as one of oVirt's project (http://www.ovirt.org/Subprojects) maybe with repository on oVirt's gerrit making it more accessible for getting/contributing for the whole community. What do you think about it? Tomas ___ Engine-devel mailing list Engine-devel@ovirt.org mailto:Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Infra mailing list in...@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Storing command parameters
- Original Message - From: Eli Mesika emes...@redhat.com To: Sahina Bose sab...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Sunday, September 8, 2013 10:44:43 AM Subject: Re: [Engine-devel] Storing command parameters - Original Message - From: Sahina Bose sab...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Tuesday, September 3, 2013 4:16:53 PM Subject: [Engine-devel] Storing command parameters Hi all, As part of the gluster volume asynchronous tasks, we ran into a requirement wherein when we start a command, we need to remember the parameters that the command was started with. Is there any infrastructure available to do this, or should we build something? Hi Sahina There is such a mechanism , it is called Compensation You can look at backend:compensate to see how it is used to rollback commands in the case of failure. Yair can elaborate help on that since he is the owner of this code Eli, I think using compensation here is an abuse. Compensation is used to take snapshots of entities, and snapshots only classes THAT ARE (a plural of the IS A inheritance rule :) ) business entities. The closest thing we have today to what Sahina needs, is IMHO async_tasks table which have command_id and parameters stored. However, storing command parameters at tasks table is somewhat awkward (yes, I know we're doing it until this very moment) and we should revisit this, and have a real table to store commands and associated parameters. Yair thanks sahina ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Java Development Lifecycle
- Original Message - From: Martin Perina mper...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, August 27, 2013 2:54:38 PM Subject: Re: [Engine-devel] Java Development Lifecycle For me the most time consuming problem is GWT compilation. It would be really nice if we can agree to create some clear separation between frontend and backend part, for example if frontend would communicate with backend only through REST API, GWT would have to recompile only if REST API or some frontend code has been changed. It's not something what can be done i short term, but it would be nice if we can find a way how to do it and create a schedule for this task. +100 - Original Message - From: Mooli Tayer mta...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Tuesday, August 27, 2013 1:29:01 PM Subject: [Engine-devel] Java Development Lifecycle Hello, I've been working on the engine for a few month now, And I feel I have not yet been able to find a productive and fast approach for Java development in different engine components. This revolves mainly around: Compiling and deploying artifacts: == If I want to check a small change in the engine, Be it in an artifact that is part of engine.ear or when I am working on one of the side tools that might run as a service (e.g ovirt-engine-notifier) or just a single jar (engine-manage-domains) It is essential to compile only parts of the project and not all of it. This can be achieved usually quite easily with mvn, however afterwards I would like to be able to also deploy and run it locally or even take all jars comprising a project and run them exploded inside my IDE (I use intellij idea) so I can enjoy live code editing and other benefits idea jboss gwt integration offers. I have been using remote debug (which is available by default in the engine and non existent in other jars so I have to tamper manually with a python service file to add debug flags - see next) But it's not as powerful as running inside an IDE and I feel my current development lifecycle is not as fast and productive as it could have been. (I do understand the engine is complex regarding configuration and deployment, so it's a challenge) Configuration: == This might be more of a todo item, I'm not sure.. After deployment of an artifact to run on a machine(again, engine, notifier or whatever) if I want to change it's configuration (configure it for remote debug as mentioned or change it's logging behavior and so on) It seems I always have to do it in a different place which I always spend hours finding. It could be great if for all artifacts configuration could be streamlined and monolithic across different components. These issues might seem obvious to some of you or unneeded to others, but I've decided to shout out in engine-devel because my usual way of approaching individuals has not got me very far, and also because I'm convinced some of you have found ways to be productive I am unaware of - Please share them! Others may have their own good ideas approaches(or their own needs). Thanks, Mooli. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Ideas about engine clustering?
- Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: plysan ply...@gmail.com Cc: engine-devel@ovirt.org Sent: Wednesday, August 21, 2013 6:30:36 PM Subject: Re: [Engine-devel] Ideas about engine clustering? - Original Message - From: plysan ply...@gmail.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, August 21, 2013 5:08:57 PM Subject: Re: [Engine-devel] Ideas about engine clustering? 2013/8/21 Laszlo Hornyak lhorn...@redhat.com Hi, - Original Message - From: plysan ply...@gmail.com To: engine-devel@ovirt.org Sent: Wednesday, August 21, 2013 3:49:31 PM Subject: [Engine-devel] Ideas about engine clustering? Hello, guys: I'm trying to make a jboss clustering environment for engine. But felt the difficuty too. So I want to know if any one is working on this? I googled it and haven't found anything. I know there will be lots of things to do for engine migrating to clustering environment. I just want to know what problem need to be solved? I would like to list the things I think that is needed to do(or solve): 1. run jboss in standalone-ha mode or domain mode. 2. add @Clustered annotation to each EJB, I think this will solve the replication problem in cluster, probably lots of details in it. 3. QuartzScheduler problem, only one node running a scheduler is enough at a time instead of each node running one. 4. use mod_cluster to handle load balancing. 5. postgresql clustering. For failover it sounds like a plan, just wondering if this could solve load balancing problems as well. Ovirt is generating a big load on the DB and I would be really interested if SQL DB clustering could solve the issues. It would be great if it could, big part of the scalablity issue is the evil things we did against that poor database. 6. There should be more, but hope anyone can think about it :D There are tons of data structures that are used in oVirt that store state. You will have to hunt all of these down and replace with a data structure that is shared between the cluster memebers. This may be a big lot of work from many parts of the application. Indeed, and like Yair Zaslavsky said, we can put the data structure in infinispan cache, but clustered EJB can do the same thing for us, right? If all those state values are inside EJBs. (iirc)* * There are only a very small number of real EJB's in oVirt, almost all and everything is done by singletons created by EJBs. (check InitBackendServicesOnStartupBean, Backend they are the biggest factories of these singletons) If you made a deeper research in this recently then your information may be more up to date than mine, but while working in various parts of the app I have found tons of local state. That's right. Not to mention there are some thoughts (at least by some of us) whether we really need EJBs , but that's a totally different discussion ;) Any ideas? Thanks! ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Gluster Volume asynchronous tasks
- Original Message - From: Sahina Bose sab...@redhat.com To: Eli Mesika emes...@redhat.com Cc: engine-devel engine-devel@ovirt.org, a...@ovirt.org Sent: Monday, August 12, 2013 11:51:15 AM Subject: Re: [Engine-devel] Gluster Volume asynchronous tasks On 08/12/2013 01:21 PM, Eli Mesika wrote: - Original Message - From: Sahina Bose sab...@redhat.com To: engine-devel engine-devel@ovirt.org, a...@ovirt.org, Michael Pasternak mpast...@redhat.com Sent: Monday, August 12, 2013 8:41:55 AM Subject: [Engine-devel] Gluster Volume asynchronous tasks Hi all, We are working on a feature to add support to start and monitor gluster volume asynchronous tasks (like rebalancing a gluster volume, removing brick from volume ) from the oVirt engine. The operations can be started from the Volumes tab or the Bricks sub-tab using the Rebalance, Remove options. These are long running operations which can be monitored using a task id returned from Gluster. We are planning to add the monitoring in the existing Task sub tab The feature description and User flows are at http://www.ovirt.org/Features/Gluster_Volume_Asynchronous_Tasks_Management The detailed design (including REST API design) is at http://www.ovirt.org/Features/Detailed_Gluster_Volume_Asynchronous_Tasks_Management. I would really appreciate if you could review and provide your valuable feedback. I Sahina Why not using 6the External Tasks feature introduced for 3.3 for those Gluster tasks ??? http://www.ovirt.org/Features/Design/DetailedExternalTasks Hi Eli, We still want to be able to start and stop these operations from the engine. So, when a user wants to say, rebalance a volume, they would go select the volume and click on Rebalance Start. This would then call the BLL command to start rebalance which will invoke the corresponding vdsm verb to start the rebalance on the volume. This is the same as existing flow for other commands. The only difference is the vdsm verb will return the task id from gluster, for the rebalance operation that was started. And we will monitor the progress of the task using the gluster task id (by calling a gluster command) I'm not sure how ExternalTasks would fit in here? I was thinking of using ExternalTask support for adding Job/Steps to engine when the operation is started outside of engine, that is, from Gluster CLI. Please correct me if I'm missing something. Does this mean that from Gluster CLI you will not try and invoke the rebalance command ? (I mean, I should either use Gluster CLI or Engine's REST API?) thanks sahina ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] LockManager maybe not be really taking locks in your flows...
Hi all, Thanks to Alon Bar Lev's efforts for preventing to concurrent host installation for the same host entity + Roy Golan's check of the code, we saw that for commands that override getExclusiveLocks() or getSharedLocks() the locking mechanism does not work (lock is not being acquired) if there is no annotation of @LockIdNameAttribute on the class. A bug was filed for removing this annotation (leftover from some historical code ) , but until it is fixed - bare in mind you need to add this annotation in current commands you are working on in order to utilize the mechanism. See RemoveVmCommand (has the annotation) vs AddDiskCommand (which doesn't have the annotation) Cheers, Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] users cannot log into userportal
- Original Message - From: Dead Horse deadhorseconsult...@gmail.com To: Itamar Heim ih...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Yair Zaslavsky yzasl...@redhat.com Sent: Wednesday, August 7, 2013 6:14:02 PM Subject: Re: [Engine-devel] users cannot log into userportal BZ994604 (https://bugzilla.redhat.com/show_bug.cgi?id=994604) has been opened. - DHC Thanks for your help DHC, This was already fixed by rnori. On Wed, Aug 7, 2013 at 5:35 AM, Itamar Heim ih...@redhat.com wrote: On 08/07/2013 12:10 AM, Dead Horse wrote: I have found some steps to reproduce this easily. Start the engine bound to an AD for authentication log in to the user portal as an AD user which has been granted a Role (I used PowerUserRole) Result: Login will succeed Data from engine.log: 2013-08-06 15:54:10,088 INFO [org.ovirt.engine.core.bll.**LoginUserCommand] (ajp--127.0.0.1-8702-10) Running command: LoginUserCommand internal: false. 2013-08-06 15:54:10,139 INFO [org.ovirt.engine.core.dal.**dbbroker.auditloghandling.** AuditLogDirector] (ajp--127.0.0.1-8702-10) Correlation ID: 23c4709, Call Stack: null, Custom Event ID: -1, Message: User ovirttest logged in. log out of the user portal Result: log out succeeds Data from engine.log: 2013-08-06 15:54:12,448 INFO [org.ovirt.engine.core.bll.**LogoutUserCommand] (ajp--127.0.0.1-8702-2) Running command: LogoutUserCommand internal: false. 2013-08-06 15:54:12,474 INFO [org.ovirt.engine.core.dal.**dbbroker.auditloghandling.** AuditLogDirector] (ajp--127.0.0.1-8702-2) Correlation ID: 52a89e7d, Call Stack: null, Custom Event ID: -1, Message: User ovirttest logged out. As the same user log in to the user portal again but this purposely input the wrong password. Result: log in will fail Data from engine.log: 2013-08-06 15:54:20,830 ERROR [org.ovirt.engine.core.bll.**adbroker.**GSSAPIDirContextAuthentication** Strategy] (ajp--127.0.0.1-8702-7) Kerberos error: Pre-authentication information was invalid (24) 2013-08-06 15:54:20,832 ERROR [org.ovirt.engine.core.bll.**adbroker.**GSSAPIDirContextAuthentication** Strategy] (ajp--127.0.0.1-8702-7) Authentication Failed. Please verify the username and password. 2013-08-06 15:54:20,843 ERROR [org.ovirt.engine.core.bll.**adbroker.DirectorySearcher] (ajp--127.0.0.1-8702-7) Failed ldap search server LDAP://foodc02.foo.test.com:**389 http://foodc02.foo.test.com:389 http://foodc02.foo.test.com:**389 http://foodc02.foo.test.com:389 using user ovirtt...@foo.test.com mailto:ovirtt...@foo.test.com** due to Authentication Failed. Please verify the username and password.. We should not try the next server 2013-08-06 15:54:20,850 ERROR [org.ovirt.engine.core.bll.**adbroker.**GSSAPIDirContextAuthentication** Strategy] (ajp--127.0.0.1-8702-7) Kerberos error: Pre-authentication information was invalid (24) 2013-08-06 15:54:20,851 ERROR [org.ovirt.engine.core.bll.**adbroker.**GSSAPIDirContextAuthentication** Strategy] (ajp--127.0.0.1-8702-7) Authentication Failed. Please verify the username and password. 2013-08-06 15:54:20,852 ERROR [org.ovirt.engine.core.bll.**adbroker.DirectorySearcher] (ajp--127.0.0.1-8702-7) Failed ldap search server LDAP://foodc01.foo.test.com:**389 http://foodc01.foo.test.com:389 http://foodc01.foo.test.com:**389 http://foodc01.foo.test.com:389 using user ovirtt...@foo.test.com mailto:ovirtt...@foo.test.com** due to Authentication Failed. Please verify the username and password.. We should not try the next server 2013-08-06 15:54:20,853 ERROR [org.ovirt.engine.core.bll.**adbroker.**LdapAuthenticateUserCommand] (ajp--127.0.0.1-8702-7) Failed authenticating user: ovirttest to domain gso.med.ge.com http://gso.med.ge.com. Ldap Query Type is getUserByName 2013-08-06 15:54:20,854 ERROR [org.ovirt.engine.core.bll.**adbroker.**LdapAuthenticateUserCommand] (ajp--127.0.0.1-8702-7) Authentication Failed. Please verify the username and password. 2013-08-06 15:54:20,855 ERROR [org.ovirt.engine.core.bll.**LoginUserCommand] (ajp--127.0.0.1-8702-7) USER_FAILED_TO_AUTHENTICATE_**WRONG_USERNAME_OR_PASSWORD : ovirttest 2013-08-06 15:54:20,856 WARN [org.ovirt.engine.core.bll.**LoginUserCommand] (ajp--127.0.0.1-8702-7) CanDoAction of action LoginUser failed. Reasons:USER_FAILED_TO_**AUTHENTICATE_WRONG_USERNAME_**OR_PASSWORD Try again to log in as the same user this time typing the correct password. Result: Login fails! Data from engine.log: 2013-08-06 15:54:25,186 ERROR [org.ovirt.engine.core.bll.**adbroker.**LdapAuthenticateUserCommand] (ajp--127.0.0.1-8702-7) Failed authenticating user: ovirttest to domain gso.med.ge.com http://gso.med.ge.com. Ldap Query Type is getUserByName 2013-08-06 15:54:25,187 ERROR [org.ovirt.engine.core.bll.**LoginUserCommand] (ajp--127.0.0.1-8702-7) USER_FAILED_TO_AUTHENTICATE : ovirttest 2013
Re: [Engine-devel] users cannot log into userportal
- Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Dead Horse deadhorseconsult...@gmail.com Cc: engine-devel engine-devel@ovirt.org Sent: Wednesday, August 7, 2013 9:00:34 PM Subject: Re: [Engine-devel] users cannot log into userportal - Original Message - From: Dead Horse deadhorseconsult...@gmail.com To: Itamar Heim ih...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Yair Zaslavsky yzasl...@redhat.com Sent: Wednesday, August 7, 2013 6:14:02 PM Subject: Re: [Engine-devel] users cannot log into userportal BZ994604 (https://bugzilla.redhat.com/show_bug.cgi?id=994604) has been opened. - DHC Thanks for your help DHC, This was already fixed by rnori. Of course already fixed comparing with current time. This was indeed a real issue. On Wed, Aug 7, 2013 at 5:35 AM, Itamar Heim ih...@redhat.com wrote: On 08/07/2013 12:10 AM, Dead Horse wrote: I have found some steps to reproduce this easily. Start the engine bound to an AD for authentication log in to the user portal as an AD user which has been granted a Role (I used PowerUserRole) Result: Login will succeed Data from engine.log: 2013-08-06 15:54:10,088 INFO [org.ovirt.engine.core.bll.**LoginUserCommand] (ajp--127.0.0.1-8702-10) Running command: LoginUserCommand internal: false. 2013-08-06 15:54:10,139 INFO [org.ovirt.engine.core.dal.**dbbroker.auditloghandling.** AuditLogDirector] (ajp--127.0.0.1-8702-10) Correlation ID: 23c4709, Call Stack: null, Custom Event ID: -1, Message: User ovirttest logged in. log out of the user portal Result: log out succeeds Data from engine.log: 2013-08-06 15:54:12,448 INFO [org.ovirt.engine.core.bll.**LogoutUserCommand] (ajp--127.0.0.1-8702-2) Running command: LogoutUserCommand internal: false. 2013-08-06 15:54:12,474 INFO [org.ovirt.engine.core.dal.**dbbroker.auditloghandling.** AuditLogDirector] (ajp--127.0.0.1-8702-2) Correlation ID: 52a89e7d, Call Stack: null, Custom Event ID: -1, Message: User ovirttest logged out. As the same user log in to the user portal again but this purposely input the wrong password. Result: log in will fail Data from engine.log: 2013-08-06 15:54:20,830 ERROR [org.ovirt.engine.core.bll.**adbroker.**GSSAPIDirContextAuthentication** Strategy] (ajp--127.0.0.1-8702-7) Kerberos error: Pre-authentication information was invalid (24) 2013-08-06 15:54:20,832 ERROR [org.ovirt.engine.core.bll.**adbroker.**GSSAPIDirContextAuthentication** Strategy] (ajp--127.0.0.1-8702-7) Authentication Failed. Please verify the username and password. 2013-08-06 15:54:20,843 ERROR [org.ovirt.engine.core.bll.**adbroker.DirectorySearcher] (ajp--127.0.0.1-8702-7) Failed ldap search server LDAP://foodc02.foo.test.com:**389 http://foodc02.foo.test.com:389 http://foodc02.foo.test.com:**389 http://foodc02.foo.test.com:389 using user ovirtt...@foo.test.com mailto:ovirtt...@foo.test.com** due to Authentication Failed. Please verify the username and password.. We should not try the next server 2013-08-06 15:54:20,850 ERROR [org.ovirt.engine.core.bll.**adbroker.**GSSAPIDirContextAuthentication** Strategy] (ajp--127.0.0.1-8702-7) Kerberos error: Pre-authentication information was invalid (24) 2013-08-06 15:54:20,851 ERROR [org.ovirt.engine.core.bll.**adbroker.**GSSAPIDirContextAuthentication** Strategy] (ajp--127.0.0.1-8702-7) Authentication Failed. Please verify the username and password. 2013-08-06 15:54:20,852 ERROR [org.ovirt.engine.core.bll.**adbroker.DirectorySearcher] (ajp--127.0.0.1-8702-7) Failed ldap search server LDAP://foodc01.foo.test.com:**389 http://foodc01.foo.test.com:389 http://foodc01.foo.test.com:**389 http://foodc01.foo.test.com:389 using user ovirtt...@foo.test.com mailto:ovirtt...@foo.test.com** due to Authentication Failed. Please verify the username and password.. We should not try the next server 2013-08-06 15:54:20,853 ERROR [org.ovirt.engine.core.bll.**adbroker.**LdapAuthenticateUserCommand] (ajp--127.0.0.1-8702-7) Failed authenticating user: ovirttest to domain gso.med.ge.com http://gso.med.ge.com. Ldap Query Type is getUserByName 2013-08-06 15:54:20,854 ERROR [org.ovirt.engine.core.bll.**adbroker.**LdapAuthenticateUserCommand] (ajp--127.0.0.1-8702-7) Authentication Failed. Please verify the username and password. 2013-08-06 15:54:20,855 ERROR [org.ovirt.engine.core.bll.**LoginUserCommand] (ajp--127.0.0.1-8702-7) USER_FAILED_TO_AUTHENTICATE_**WRONG_USERNAME_OR_PASSWORD : ovirttest 2013-08-06 15:54:20,856 WARN [org.ovirt.engine.core.bll.**LoginUserCommand] (ajp--127.0.0.1-8702-7) CanDoAction of action LoginUser failed. Reasons:USER_FAILED_TO_**AUTHENTICATE_WRONG_USERNAME_**OR_PASSWORD Try again to log in as the same user this time typing
Re: [Engine-devel] cannot login after re-deploying development environment
Can we get server.log as well? - Original Message - From: Einav Cohen eco...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Tuesday, August 6, 2013 8:31:07 PM Subject: [Engine-devel] cannot login after re-deploying development environment Hi, The following scenario already happened to me several times: I created a brand new 'engine' data-base, created / deployed development environment [everything works correctly]. After ^^^, I re-create/deploy development environment, this time without creating a brand new 'engine' data-base (i.e. I utilized the existing one). Everything seems to be working correctly, only I cannot login into the web-admin (I fail on USER_FAILED_TO_AUTHENTICATE CanDoAction). The only workaround I found is to use a brand-new data-base. Any ideas? [attached: engine.log, engine-setup output, engine-setup.log] Thanks in advance. Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] JsonMappingException on create pool
Fixed and merged. - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, July 4, 2013 10:53:48 AM Subject: [Engine-devel] JsonMappingException on create pool Hey all, did anyone experienced problems creating a pool from a template with disk? Currently rebased and built engine throws: Error during CreateTask for command: org.ovirt.engine.core.bll.CreateSnapshotFromTemplateCommand. Exception org.apache.commons.lang.SerializationException: org.codehaus.jackson.map.JsonMappingException: Can not find a (Map) Key deserializer for type [simple type, class org.ovirt.engine.core.common.businessentities.VmDevice]: org.apache.commons.lang.SerializationException: org.codehaus.jackson.map.JsonMappingException: Can not find a (Map) Key deserializer for type [simple type, class org.ovirt.engine.core.common.businessentities.VmDevice] It does not happen when the template has no disks. More logs attached, thank you, Tomas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] SSH Soft Fencing
- Original Message - From: Barak Azulay bazu...@redhat.com To: Martin Perina mper...@redhat.com, Yaniv Bronheim ybron...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, July 3, 2013 5:24:21 PM Subject: Re: [Engine-devel] SSH Soft Fencing - Original Message - From: Martin Perina mper...@redhat.com To: engine-devel@ovirt.org Sent: Wednesday, July 3, 2013 3:39:20 PM Subject: Re: [Engine-devel] SSH Soft Fencing - Original Message - From: Livnat Peer lp...@redhat.com To: Martin Perina mper...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, July 3, 2013 2:32:16 PM Subject: Re: [Engine-devel] SSH Soft Fencing Hi Martin, I have some more questions, - Do we persist the host root password for this feature? - If we do, is this feature limited for new hosts, can I provide it for already existing hosts? - Do we encrypt this value when storing in the DB? Thanks, Livnat Well, SSH connection uses engine default SSH key, no password. So I think this is usable for all hosts. correct, SSH public key is deployed as a part of bootstrap host-deploy from day one. So no need to save the password anywhere. Marin - Where do you take the username (currently only root is supported), but we intend to move away from it, Actually Yaniv.B as added it to the DB as first stage - just making sure you'll use that. Thanks Barak My 2 cents - Actually, Since Martin's work is merged, and Yaniv already has in one of his patches fixes to all relevant places in code he will probably need to add a fix around ssh soft fencing area (or at least coordinate this with Martin). Both Yaniv and Martin are already aware of this. Yair On 07/03/2013 02:55 PM, Martin Perina wrote: Let's summarize again, SSH Soft Fencing patches has been merged yesterday with following functionality: 1) For hosts with power management configured, SSH Soft Fencing is the 1st fencing stage. If it doesn't help, real fencing will be executed. 2) For hosts without power management configured, SSH Soft Fencing is the only fencing stage. If it doesn't help, host will become non responsive. 3) SSH Soft Fencing is enabled by default, there's no configuration option to disable it 4) SshSoftFencingCommand option is used to define what command is executed during SSH Soft Fencing. It can only be changed manually in database. The whole fencing process in oVirt 3.3 is decribed at http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3 Martin Perina - Original Message - From: Michal Skrivanek michal.skriva...@redhat.com To: engine-devel@ovirt.org Sent: Wednesday, July 3, 2013 12:03:13 PM Subject: Re: [Engine-devel] SSH Soft Fencing On Jul 2, 2013, at 10:44 , Eli Mesika emes...@redhat.com wrote: - Original Message - From: Livnat Peer lp...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: engine-devel@ovirt.org Sent: Monday, July 1, 2013 12:57:34 PM Subject: Re: [Engine-devel] SSH Soft Fencing On 07/01/2013 11:27 AM, Yair Zaslavsky wrote: - Original Message - From: Martin Perina mper...@redhat.com To: engine-devel@ovirt.org Sent: Monday, July 1, 2013 11:23:12 AM Subject: Re: [Engine-devel] SSH Soft Fencing So let me summarize it: We have come to agreement in those questions: 1) SSH Soft Fencing logic should be extracted from VdsNotRespondingTreatment command to its own SshSoftFencingCommand 2) VdsNotRespondingCommand should be refactored so it's not inherited from VdsRestartCommand, but it should run SshSoftFencingCommand or VdsRestartCommand based on defined fencing flow These questions has not been resolved yet: 3) Should SSH Soft Fencing be executed also for hosts without PM configured? 4) Should SSH Soft Fencing execution for hosts without PM configured be enabled by default and admin can turn off these feature using configuration options SshSoftFencingWithoutPmEnabled (or something like that)? 5) Should SshSoftFencingWithoutPmEnabled be a global option or a cluster wide option (can be turned off for specific cluster version) or a VDS option (it can be turned off for each host)? Personally I would suggest: ad 3) Yes, SSH Soft Fencing should be executed also for hosts without PM configured +1 ad 4) Yes, SSH Soft Fencing for hosts without PM configured should be enabled by default +1 ad 5) I don't see any significant reason why someone would like to turn off SSH Soft Fencing
Re: [Engine-devel] SSH Soft Fencing
- Original Message - From: Martin Perina mper...@redhat.com To: engine-devel@ovirt.org Sent: Monday, July 1, 2013 11:23:12 AM Subject: Re: [Engine-devel] SSH Soft Fencing So let me summarize it: We have come to agreement in those questions: 1) SSH Soft Fencing logic should be extracted from VdsNotRespondingTreatment command to its own SshSoftFencingCommand 2) VdsNotRespondingCommand should be refactored so it's not inherited from VdsRestartCommand, but it should run SshSoftFencingCommand or VdsRestartCommand based on defined fencing flow These questions has not been resolved yet: 3) Should SSH Soft Fencing be executed also for hosts without PM configured? 4) Should SSH Soft Fencing execution for hosts without PM configured be enabled by default and admin can turn off these feature using configuration options SshSoftFencingWithoutPmEnabled (or something like that)? 5) Should SshSoftFencingWithoutPmEnabled be a global option or a cluster wide option (can be turned off for specific cluster version) or a VDS option (it can be turned off for each host)? Personally I would suggest: ad 3) Yes, SSH Soft Fencing should be executed also for hosts without PM configured ad 4) Yes, SSH Soft Fencing for hosts without PM configured should be enabled by default ad 5) I don't see any significant reason why someone would like to turn off SSH Soft Fencing for hosts without PM configured. But if someone would like to do that, I think he would like to turn it off only for specific hosts, so VDS level option makes sense for me After re-thinking 5 - I agree. +1 on the other suggestions, but of course we need to get more consensus here. Martin ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] Cannot run ovirt engine on master - BrandingServlet issue
I get class not found issue for BrandingManager 013-07-01 12:44:25,273 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-7) MSC01: Failed to start service jboss.deployment.subunit.engine.ear.webadmin.war.POST_MODULE: org.jboss.msc.service.StartException in service jboss.deployment.subunit.engine.ear.webadmin.war.POST_MODULE: Failed to process phase POST_MODULE of subdeployment webadmin.war of deployment engine.ear at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:119) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc.jar:1.0.2.GA] at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc.jar:1.0.2.GA] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_25] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_25] at java.lang.Thread.run(Thread.java:724) [rt.jar:1.7.0_25] Caused by: java.lang.RuntimeException: Error getting reflective information for class org.ovirt.engine.ui.frontend.server.gwt.BrandingServlet with ClassLoader ModuleClassLoader for Module deployment.engine.ear.webadmin.war:main from Service Module Loader at org.jboss.as.server.deployment.reflect.DeploymentReflectionIndex.getClassIndex(DeploymentReflectionIndex.java:70) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] at org.jboss.as.ee.metadata.MethodAnnotationAggregator.runtimeAnnotationInformation(MethodAnnotationAggregator.java:58) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.handleAnnotations(InterceptorAnnotationProcessor.java:85) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.processComponentConfig(InterceptorAnnotationProcessor.java:70) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.deploy(InterceptorAnnotationProcessor.java:55) at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:113) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] ... 5 more Caused by: java.lang.NoClassDefFoundError: Lorg/ovirt/engine/core/utils/branding/BrandingManager; at java.lang.Class.getDeclaredFields0(Native Method) [rt.jar:1.7.0_25] at java.lang.Class.privateGetDeclaredFields(Class.java:2377) [rt.jar:1.7.0_25] I am rebased against 2a590891ea1adc5eed0c4cd43577049fb77f3752 Can someone please advise? Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Cannot run ovirt engine on master - BrandingServlet issue
I am using the development environment introduced by Albonl. I do have ovirt-engine/etc/ovirt-engine/branding Directory after installation. Yair - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, July 1, 2013 12:48:13 PM Subject: [Engine-devel] Cannot run ovirt engine on master - BrandingServlet issue I get class not found issue for BrandingManager 013-07-01 12:44:25,273 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-7) MSC01: Failed to start service jboss.deployment.subunit.engine.ear.webadmin.war.POST_MODULE: org.jboss.msc.service.StartException in service jboss.deployment.subunit.engine.ear.webadmin.war.POST_MODULE: Failed to process phase POST_MODULE of subdeployment webadmin.war of deployment engine.ear at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:119) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc.jar:1.0.2.GA] at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc.jar:1.0.2.GA] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_25] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_25] at java.lang.Thread.run(Thread.java:724) [rt.jar:1.7.0_25] Caused by: java.lang.RuntimeException: Error getting reflective information for class org.ovirt.engine.ui.frontend.server.gwt.BrandingServlet with ClassLoader ModuleClassLoader for Module deployment.engine.ear.webadmin.war:main from Service Module Loader at org.jboss.as.server.deployment.reflect.DeploymentReflectionIndex.getClassIndex(DeploymentReflectionIndex.java:70) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] at org.jboss.as.ee.metadata.MethodAnnotationAggregator.runtimeAnnotationInformation(MethodAnnotationAggregator.java:58) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.handleAnnotations(InterceptorAnnotationProcessor.java:85) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.processComponentConfig(InterceptorAnnotationProcessor.java:70) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.deploy(InterceptorAnnotationProcessor.java:55) at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:113) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] ... 5 more Caused by: java.lang.NoClassDefFoundError: Lorg/ovirt/engine/core/utils/branding/BrandingManager; at java.lang.Class.getDeclaredFields0(Native Method) [rt.jar:1.7.0_25] at java.lang.Class.privateGetDeclaredFields(Class.java:2377) [rt.jar:1.7.0_25] I am rebased against 2a590891ea1adc5eed0c4cd43577049fb77f3752 Can someone please advise? Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Cannot run ovirt engine on master - BrandingServlet issue
Issue of dirty clone of git repo. Had an old version of utils.jar that was copied to $HOME/ovirt-engine after git clean -dfx issue got resolved. Thanks for all those who tried to help. - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, July 1, 2013 12:48:13 PM Subject: [Engine-devel] Cannot run ovirt engine on master - BrandingServlet issue I get class not found issue for BrandingManager 013-07-01 12:44:25,273 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-7) MSC01: Failed to start service jboss.deployment.subunit.engine.ear.webadmin.war.POST_MODULE: org.jboss.msc.service.StartException in service jboss.deployment.subunit.engine.ear.webadmin.war.POST_MODULE: Failed to process phase POST_MODULE of subdeployment webadmin.war of deployment engine.ear at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:119) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc.jar:1.0.2.GA] at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc.jar:1.0.2.GA] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_25] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_25] at java.lang.Thread.run(Thread.java:724) [rt.jar:1.7.0_25] Caused by: java.lang.RuntimeException: Error getting reflective information for class org.ovirt.engine.ui.frontend.server.gwt.BrandingServlet with ClassLoader ModuleClassLoader for Module deployment.engine.ear.webadmin.war:main from Service Module Loader at org.jboss.as.server.deployment.reflect.DeploymentReflectionIndex.getClassIndex(DeploymentReflectionIndex.java:70) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] at org.jboss.as.ee.metadata.MethodAnnotationAggregator.runtimeAnnotationInformation(MethodAnnotationAggregator.java:58) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.handleAnnotations(InterceptorAnnotationProcessor.java:85) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.processComponentConfig(InterceptorAnnotationProcessor.java:70) at org.jboss.as.ee.component.deployers.InterceptorAnnotationProcessor.deploy(InterceptorAnnotationProcessor.java:55) at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:113) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final] ... 5 more Caused by: java.lang.NoClassDefFoundError: Lorg/ovirt/engine/core/utils/branding/BrandingManager; at java.lang.Class.getDeclaredFields0(Native Method) [rt.jar:1.7.0_25] at java.lang.Class.privateGetDeclaredFields(Class.java:2377) [rt.jar:1.7.0_25] I am rebased against 2a590891ea1adc5eed0c4cd43577049fb77f3752 Can someone please advise? Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Guid improvements
Well done, should have been done ages ago :) Now, for the painful rebase of async_task_mgr changes :) - Original Message - From: Allon Mureinik amure...@redhat.com To: engine-devel engine-devel@ovirt.org, Barak Azulay bazu...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, Michael Pasternak mpast...@redhat.com, Tal Nisan tni...@redhat.com, Ayal Baron aba...@redhat.com Sent: Sunday, June 30, 2013 11:11:30 AM Subject: Guid improvements Hi all, I just merged a couple of improvements to the [N]Guid class [1] to improve it's performance both CPU-wise and memory-wise, based on a set of benchmarks presented by Liran. What this patchset achieves: 1. Clean up the code, so it's easier to understand and use 2. Eliminate the inflation in the memory foot print caused by the getValue() method 3. Eliminate all the heavy calls to UUID.fromString when creating a new/empty Guid instance as a default value 4. Note that the cleanups proposed in (1) will have minor performance benefits (e.g., eliminating useless conditional statements), but I doubt this would be anything to write home about. From a developer's perspective, here's what changed: 1. No more NGuid, just Guid. Both static methods to create a Guid from String still exist, and are named createGuidFromString and createGuidFromStringDefaultEmpty. 2. [N]Guid.getValue() was removed, it's no longer needed after (1) was implemented 3. The Guid() constructor was made private, as it forced a redundant call to UUID.fromString(String). If you need an empty Guid instance, just use Guid.Empty 4. The Guid.EMPTY_GUID_VALUE string constant was removed, as it was used for redundant calls to UUID.fromString. If you really, REALLY, need it, just call Guid.Empty.getValue() for a UUID or Guid.Empty.toString() for a String. 5. All sorts of ways to transform Strings to Guids were removed. If you have a literal you trust, just use new Guid(String). If you suspect it may be null, use Guid.createGuidFromString[DefaultEmpty] 6. NewGuid is now called newGuid. We're in Java, not C# :-) Many thanks to everyone who reviewed this patchset. You guys rock! Regards, Allon [1] http://gerrit.ovirt.org/#/q/project:ovirt-engine+branch:master+topic:guid-cleanup,n,z ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] SSH Soft Fencing
- Original Message - From: Barak Azulay bazu...@redhat.com To: Martin Perina mper...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, engine-devel@ovirt.org, Eli Mesika emes...@redhat.com Sent: Thursday, June 27, 2013 8:31:35 PM Subject: Re: SSH Soft Fencing - Original Message - From: Eli Mesika emes...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Martin Perina mper...@redhat.com, engine-devel@ovirt.org, Barak Azulay bazu...@redhat.com Sent: Thursday, June 27, 2013 5:55:29 PM Subject: Re: SSH Soft Fencing - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Eli Mesika emes...@redhat.com Cc: Martin Perina mper...@redhat.com, engine-devel@ovirt.org, Barak Azulay bazu...@redhat.com Sent: Thursday, June 27, 2013 5:43:17 PM Subject: Re: SSH Soft Fencing - Original Message - From: Eli Mesika emes...@redhat.com To: Martin Perina mper...@redhat.com Cc: engine-devel@ovirt.org, Yair Zaslavsky yzasl...@redhat.com, Barak Azulay bazu...@redhat.com Sent: Thursday, June 27, 2013 3:48:39 PM Subject: Re: SSH Soft Fencing - Original Message - From: Martin Perina mper...@redhat.com To: engine-devel@ovirt.org Cc: Yair Zaslavsky yzasl...@redhat.com, Barak Azulay bazu...@redhat.com, Eli Mesika emes...@redhat.com Sent: Thursday, June 27, 2013 1:51:06 PM Subject: SSH Soft Fencing Hi, SSH Soft Fencing is a new feature for 3.3 and it tries to restart VDSM using SSH connection on non responsive hosts prior to real fencing. More info can be found at http://www.ovirt.org/Automatic_Fencing#Automatic_Fencing_in_oVirt_3.3 In current SSH Soft Fencing implementation the restart VDSM using SSH command is part of standard fencing implementation in VdsNotRespondingTreatmentCommand. But this command is executed only if a host has a valid PM configuration. If host doesn't have a valid PM configuration, the execution of the command is disabled and host state is change to Non Responsive. So my question are: 1) Should SSH Soft Fencing be executed on hosts without valid PM configuration? I think that the answer should be yes. The vdsm restart will solve most of problems , so why not using it whether a PM agent is defined or not. I agree. I would like to say that I also don't like the fact that VdsNotRespondingTreatment extends RestartVdsCommand. One should ask if non responding treatment is a restart vds operation or maybe RestartVdsCommand is just a step in the non responding treatment (inheritance vs containment/delegation). I think that VdsNotRespodingTreatment should delegate the call to RestartVdsCommand as the 2nd step after issuing the Soft Fencing command. Thoughts anyone? That would be a nice and needed re-factoring I would say yes - but would add it only with appropriate configuration (enableAutoSoftVdsmRestartWhenNoPMAvailable I hate the name) +1 on configuration. Configuration must reside at host-related entities (i.e - VdsStatic). Yair 2) Should VDSM restart using SSH command be reimplemented as standalone command to be usable also in other parts of engine? If 1) is true, I think it will have to be done anyway. I agree here. +1 On one hand it makes sense, but I have several questions on the above: - Who do we think may want to use such a command ? - Should (or even can) we limit the use of such command to noneResponsiveTreatment ? Having general commands available to all code when there is only one specific case we are using it might be a bit riskey, Especially when we talk about restarting something. Thoughts ? Martin Perina ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] Async task manager changes for oVirt 3.3
Hi all, The following pages describes the changes that we would like to insert/think it's feasible for async tasks at engine for oVirt 3.3. Bare in mind these changes are a part of a bigger of set of changes we would like to introduce http://www.ovirt.org/Features/AsyncTaskManagerChanges_3.3 ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Disk BE very small refactoring
- Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Vered Volansky ve...@redhat.com Cc: engine-devel@ovirt.org Sent: Monday, May 27, 2013 6:22:58 PM Subject: Re: [Engine-devel] Disk BE very small refactoring Vered, VmDevice has isPlugged field, Why not have somehow in your inheritence (either Disk or a subclass) a field : VmDevice device and have isPlugged method called device.isPlugged() ? Then you can also add the readOnly property which is not represented at VmDevice. Does this sound logical to you? Vered, I forgot sharable disk may be associated with two VMs, hence having a field of VmDevice may be problematic. However, maybe we need some interface (i.e - Device) which BothVmDevice and your class (or maybe an object of some class that will be contained in your class) will implement? - Original Message - From: Vered Volansky ve...@redhat.com To: engine-devel@ovirt.org Sent: Monday, May 27, 2013 6:18:58 PM Subject: [Engine-devel] Disk BE very small refactoring Hi All, Please express your opinion if you have any - Currently Disk BE has a plugged property, which should be a property of the relationship between vm(or template) and a disk. I plan to remove this property from the Disk entity, and add new entity, called DeviceDisk. This should inherit from Disk and contain the vm/template guid and the plugged property at first round. At second round it'll also contain the readOnly property, for RO disks, TBD right after. Appreciate any input, Vered ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Any reason to use UUID instead of name or dn?
- Original Message - From: Alon Bar-Lev alo...@redhat.com To: Juan Hernandez jhern...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, May 22, 2013 1:47:42 PM Subject: Re: [Engine-devel] Any reason to use UUID instead of name or dn? - Original Message - From: Juan Hernandez jhern...@redhat.com To: engine-devel@ovirt.org Sent: Wednesday, May 22, 2013 1:35:56 PM Subject: [Engine-devel] Any reason to use UUID instead of name or dn? Hello all, I am working on a series of changes with the objective to simplify the LDAP layer and make it more generic. One of the things that I would like to do is to use the name or dn attributes to identify the users/group instead of the UUIDs as we currently do. Can someone explain me if there is any powerful reason to use the directory specific UUIDs (objectGUID in ActiveDirectory, nsUniqueId in RHDS, etc) instead of user/group names or distinguished names? Hi, If you define an entity and then delete and define an entity at the same name, the new entity should not inherit the permissions of the previous entity. So resource based security always hold unique identifier for entities, it can be UUID, UID or any unique string. Regards, Alon. Indeed, this is due to permissions issue, the UUIDs are used to calculate the effective permissions ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] [ANN] Development environment and Gentoo packaging (preview)
Wanted to point out that today I completed setting up the env. I checked engine-config and manage-domains. We found two issues (worked on Alon's env - not on mine) and now all is fixed and merged upstream. Alon - many thanks on this !! as someone who works on tools, you're really making my life easier!! Yair - Original Message - From: Alon Bar-Lev alo...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Friday, March 29, 2013 1:37:44 AM Subject: [Engine-devel] [ANN] Development environment and Gentoo packaging (preview) Hello All, We[1] are working to rewrite the current installer to something more portable and flexible. Currently two milestones had been reached: 1. Ability to install almost fully functioning ovirt-engine at $HOME for development environment. 2. Porting ovirt-engine to run on different distribution, Gentoo. We will be glad to receive feedback on either. Code is located at github[2] for now, at otopi branch. Instructions for setting up development environment are available[3]. Gentoo overlay for live ebuilds is available[4], the following packages are valid: - app-emulation/otopi - app-emulation/ovirt-host-deploy - app-emulation/ovirt-jboss-bin - app-emulation/ovirt-engine Why Gentoo first? because source based distributions demands the highest level of customization, solving the complex issue ease to continue porting to binary based distributions. Please remember that this is work in progress, and not guarantee to be stable or even work... The installer was re-written from scratch so expect issues at this point. Any feedback is welcomed, we are focusing first in providing the functionality of the existing installer to be able to replace it entirely before going into new adventures. Regards, Alon Bar-Lev. [1] Alex Lourie, Sandro Bonazzola, Alon Bar-Lev [2] https://github.com/alonbl/ovirt-engine [3] https://github.com/alonbl/ovirt-engine/blob/otopi/README.developer [4] https://github.com/alonbl/ovirt-overlay ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] [ANN] New development environment for ovirt-engine
- Original Message - From: Alon Bar-Lev alo...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Eli Mesika emes...@redhat.com, engine-devel engine-devel@ovirt.org, arch a...@ovirt.org Sent: Tuesday, May 14, 2013 8:58:06 AM Subject: Re: [Engine-devel] [ANN] New development environment for ovirt-engine - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Eli Mesika emes...@redhat.com Cc: Alon Bar-Lev alo...@redhat.com, engine-devel engine-devel@ovirt.org, arch a...@ovirt.org Sent: Tuesday, May 14, 2013 5:39:19 AM Subject: Re: [Engine-devel] [ANN] New development environment for ovirt-engine Alon, I have FC17, and followed the steps at the wiki , i defined the ovirt nightly repo [ovirt-nightly] name=ovirt-nightly baseurl=http://resources.ovirt.org/releases/nightly/rpm/Fedora/17/ enabled=1 gpgcheck=0 priority=1 protect=1 And performed yum install according to your guidelines. It fails to find python-m2crypto Has nothing to do with ovirt :) Try m2crypto please. Worked ! I would suggest updating the WIKI However, now I fail at webadmin - commit hash cda607c80a19dd08585fc0271ea7d57e03f9a43f [INFO] javac option: -s [INFO] javac option: /home/yzaslavs/work/ovirt_git/ovirt-engine/frontend/webadmin/modules/webadmin/target/generated-sources/annotations [INFO] diagnostic /home/yzaslavs/work/ovirt_git/ovirt-engine/frontend/webadmin/modules/gwt-common/target/gwt-common-3.3.0-SNAPSHOT.jar(org/ovirt/engine/ui/common/presenter/AbstractPopupPresenterWidget.java):27: error: method getCloseButton() is already defined in interface org.ovirt.engine.ui.common.presenter.AbstractPopupPresenterWidget.ViewDef HasClickHandlers getCloseButton(); ^ [INFO] diagnostic /home/yzaslavs/work/ovirt_git/ovirt-engine/frontend/webadmin/modules/gwt-common/target/gwt-common-3.3.0-SNAPSHOT.jar(org/ovirt/engine/ui/common/presenter/AbstractPopupPresenterWidget.java):32: error: method getCloseIconButton() is already defined in interface org.ovirt.engine.ui.common.presenter.AbstractPopupPresenterWidget.ViewDef HasClickHandlers getCloseIconButton(); Anyone got a clue? Can you please advise on the matter? Many thanks, Yair - Original Message - From: Eli Mesika emes...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: engine-devel engine-devel@ovirt.org, arch a...@ovirt.org Sent: Tuesday, May 14, 2013 3:45:41 AM Subject: Re: [Engine-devel] [ANN] New development environment for ovirt-engine - Original Message - From: Alon Bar-Lev alo...@redhat.com To: engine-devel engine-devel@ovirt.org Cc: arch a...@ovirt.org, Sharad Mishra snmis...@us.ibm.com, Limor Gavish lgav...@gmail.com Sent: Sunday, May 12, 2013 2:52:51 PM Subject: [Engine-devel] [ANN] New development environment for ovirt-engine Hello all ovirt-engine developers, When I first joined the ovirt project, it took me about two weeks to setup a development environment, I needed to work on a bug related to host-deploy so I needed an environment that could use the ssh, PKI, vdsm-bootstrap and communicate with vdsm using SSL, this was virtually impossible to do so without tweaking the product in a way that it is so different from production use, that I cannot guarantee that whatever tested in development will actually work in production. I peeked at the installation script in a hope that I can create partial environment similar to production, but I found that the packaging implementation makes to much assumption and is very difficult to adopt. The fact that I do not use fedora/rhel for my development made it even worse. I had no other option than to create rpms after each of my changes and test each in real production like setup. It was obvious to me that the manual customization of developers to achieve working product will eventually break as product grow and move away from being developer friendly to production friendly. For example, product defaults cannot be these which serve developers, but these which serve production the best, or having a valid PKI setup cannot be optional any more as components do need to use it. Same for location of files and configuration, for example, if we write a pluggable infrastructure for branding, we cannot damage the interface just because developers runs the product in their own manual customization. I took the opportunity handed to me to port the ovirt-engine to other distributions in order to provide a development environment that is similar to production setup. Together with Sandro Bonazzola and Alex Lourie we re-wrote the whole installation of the product which can also be used to setup
Re: [Engine-devel] Engine config and device custom properties
- Original Message - From: Moti Asayag masa...@redhat.com To: Martin Perina mper...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, May 14, 2013 12:14:14 PM Subject: Re: [Engine-devel] Engine config and device custom properties Hi Martin, By looking at the code - there seems no validator for the format provided by the user for the UserDefinedVMProperties. It seems that the engine will write an exception to log specifying the format is invalid, as the format is being validated during engine startup by InitBackendServicesOnStartupBean.create() which invokes VmPropertiesUtils.getInstance().init() Therefore there is a need to validate the format in earlier stage, when setting the values for the properties via the engine-config. 1. Extend the engine-config value helpers with a new type: DevicePropertiesValueHelper extends org.ovirt.engine.core.config.entity.helper.ValueHelper and also a compliant DevicePropertiesValueHelperTest 2. DevicePropertiesValueHelper.validate() should reuse the parsing logic of the device properties from VmPropertiesUtils.parseVMPropertiesRegex() 3. Define the value helper for you new property in packaging/etc/engine-config/engine-config.properties: CustomDeviceProperties.description=your description CustomDeviceProperties.type=DevicePropertiesValueHelper You the new install-dev to easily test you changes. Regards, Moti Moti gave a very good explanation. Actually , the very first question should have been - would we like to have this configurable via engine config? Are we going to defined a predefine set (i.e - in case of SAPAgent af predefined vm custom properties) or not. I actually now think we should go for this. Martin, the new value helper will not be able to validate on a specific key=value pair - the user will have to pass the entire string each time he changes this config value. Moti - any comments here? Anyway, this change can be done in parallel to Moti's work on custom device properties from network side (he will fill relevant values manually in the vdc_options table). Yair - Original Message - From: Martin Perina mper...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, May 14, 2013 10:51:02 AM Subject: [Engine-devel] Engine config and device custom properties Hi, I'm working on a patch to support custom device properties in ovirt-engine. I would like that custom device properties format can be set using engine-config command in a similar way as UserDefinedVMProperties. What is needed to be done to support this? Thanks Martin ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] DB performance optimization
- Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Liran Zelkha lzel...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Monday, May 13, 2013 12:28:59 PM Subject: Re: [Engine-devel] DB performance optimization Hi Liran, Thanks for this patch, I have been asking for caching for a long while and I hope to see caching in the engine soon. Beyond the comments I have made to your patch, I have some questions about the idea just to start the discussion. So your cache solution is caching data based on SQL statements? What will the cache do if we query the same data with two different SQL statements? e.g. you can query from views like vms and sometimes we only query the vm_static and we should get the same vm_static. Also, how will you deal with updates? e.g. when you update the vm_static record, that vm_static record must be updated or invalidated but also the vm record from Thx, Laszlo Laszlo - +1 on your requests for caching. (At least) I am aware to them, and we talked about this issue many times. I am also happy we began this efforts. I would like to state that your questions are good - I also asked Liran about them, and debated about them myself when I was thinking about caching. Liran's approach is to build this caching step by step. You will see (and I'll let Liran elaborate) that even with this simple caching, we have an improvement. - Original Message - From: Liran Zelkha lzel...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Monday, May 13, 2013 10:40:31 AM Subject: [Engine-devel] DB performance optimization Hi all, There is a WIP for caching and DB performance optimization. Please look at - http://gerrit.ovirt.org/#/c/14188/4 To summarize, it includes automatic caching for some business entities (*_static for instance), break up of VDS to VDS_static, VDS_dynamic and VDS_statistics, and support for batch updates. Please share if/where you think batch updates can be used (for a usage scenario, please check InterfaceDaoDbFacadeImpl.massUpdateStatisticsForVds()). Future tasks will include update sensitivity, better Collection caching and trying to minimize getConnection() calls. Would love your comments and ideas. Thanks. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] [ANN] New development environment for ovirt-engine
Alon, I have FC17, and followed the steps at the wiki , i defined the ovirt nightly repo [ovirt-nightly] name=ovirt-nightly baseurl=http://resources.ovirt.org/releases/nightly/rpm/Fedora/17/ enabled=1 gpgcheck=0 priority=1 protect=1 And performed yum install according to your guidelines. It fails to find python-m2crypto Can you please advise on the matter? Many thanks, Yair - Original Message - From: Eli Mesika emes...@redhat.com To: Alon Bar-Lev alo...@redhat.com Cc: engine-devel engine-devel@ovirt.org, arch a...@ovirt.org Sent: Tuesday, May 14, 2013 3:45:41 AM Subject: Re: [Engine-devel] [ANN] New development environment for ovirt-engine - Original Message - From: Alon Bar-Lev alo...@redhat.com To: engine-devel engine-devel@ovirt.org Cc: arch a...@ovirt.org, Sharad Mishra snmis...@us.ibm.com, Limor Gavish lgav...@gmail.com Sent: Sunday, May 12, 2013 2:52:51 PM Subject: [Engine-devel] [ANN] New development environment for ovirt-engine Hello all ovirt-engine developers, When I first joined the ovirt project, it took me about two weeks to setup a development environment, I needed to work on a bug related to host-deploy so I needed an environment that could use the ssh, PKI, vdsm-bootstrap and communicate with vdsm using SSL, this was virtually impossible to do so without tweaking the product in a way that it is so different from production use, that I cannot guarantee that whatever tested in development will actually work in production. I peeked at the installation script in a hope that I can create partial environment similar to production, but I found that the packaging implementation makes to much assumption and is very difficult to adopt. The fact that I do not use fedora/rhel for my development made it even worse. I had no other option than to create rpms after each of my changes and test each in real production like setup. It was obvious to me that the manual customization of developers to achieve working product will eventually break as product grow and move away from being developer friendly to production friendly. For example, product defaults cannot be these which serve developers, but these which serve production the best, or having a valid PKI setup cannot be optional any more as components do need to use it. Same for location of files and configuration, for example, if we write a pluggable infrastructure for branding, we cannot damage the interface just because developers runs the product in their own manual customization. I took the opportunity handed to me to port the ovirt-engine to other distributions in order to provide a development environment that is similar to production setup. Together with Sandro Bonazzola and Alex Lourie we re-wrote the whole installation of the product which can also be used to setup the desired development environment. Within this environment the product is set up using the same tools and configuration as in production, while the process does not require special privileges nor changes the state of the developer machine. A complete documentation is available[1], I preferred to use README within the source tree as wiki tend to quickly become obsolete, while documentation within source tree can be modified by the commit that introduces a change. I will redirect to this file from the current wiki once the site will be up. In a nut shell, after installing prerequisites, build and install the product using: $ make clean install-dev PREFIX=$HOME/ovirt-engine This will run maven and create product installation at $HOME/ovirt-engine Next, a setup phase is required just like in production, to initialize configuration and database: $ $HOME/ovirt-engine/bin/engine-setup-2 You have now fully functional product, including PKI, SSL, host-deploy, tools. No manual database updates are required, no lose of functionality. All that is left is to start the engine service: $ $HOME/ovirt-engine/share/ovirt-engine/services/ovirt-engine.py start Access to application: http://localhost:8080 https://localhost:8443 Debugging port is opened at port 8787. Farther information exists in the documentation[1]. There are several inherit benefits of the new environment, the major one is the ability to manage several environments in parallel on the same host. For example, if we develop two separate features on two branches we can install the product into $HOME/ovirt-engine-feature1 and $HOME/ovirt-engine-feature-2 and have a separate database for each, if we modify the ports jboss is listening to we can run two instances of engine at the same time! It is not clear to me why working on 2 bugs needs 2 installations of the development environment. If you have 2 different git branches and a separate database for each, its enough , am I missing something ? I
Re: [Engine-devel] Device custom properties
- Original Message -
From: Martin Perina mper...@redhat.com
To: Eli Mesika emes...@redhat.com
Cc: engine-devel@ovirt.org
Sent: Thursday, May 9, 2013 2:17:58 PM
Subject: Re: [Engine-devel] Device custom properties
- Original Message -
From: Martin Perina mper...@redhat.com
To: Eli Mesika emes...@redhat.com
Cc: engine-devel@ovirt.org
Sent: Thursday, May 9, 2013 10:31:07 AM
Subject: Re: [Engine-devel] Device custom properties
- Original Message -
From: Eli Mesika emes...@redhat.com
To: Martin Perina mper...@redhat.com
Cc: engine-devel@ovirt.org
Sent: Sunday, May 5, 2013 9:18:07 AM
Subject: Re: [Engine-devel] Device custom properties
- Original Message -
From: Martin Perina mper...@redhat.com
To: engine-devel@ovirt.org
Sent: Saturday, May 4, 2013 8:13:44 AM
Subject: Re: [Engine-devel] Device custom properties
- Original Message -
From: Martin Perina mper...@redhat.com
To: engine-devel@ovirt.org
Sent: Friday, May 3, 2013 11:06:05 AM
Subject: [Engine-devel] Device custom properties
Hi,
I'm currently trying to implement device custom properties
infrastructure
in
ovirt-engine.
During discussion with Yair, we found out, that it's not clear, for
what
type
of devices
custom properties should be available? In engine we have the
VmDeviceType
enum which
contains following values:
FLOPPY(floppy, 14),
DISK(disk, 17),
CDROM(cdrom, 15),
INTERFACE(interface, 10),
BRIDGE(bridge, 3),
VIDEO(video, 20),
USB(usb, 23),
CONTROLLER(controller, 23),
REDIR(redir, 23),
SPICEVMC(spicevmc, 23),
QXL(qxl),
CIRRUS(cirrus),
SOUND(sound),
ICH6(ich6),
AC97(ac97),
MEMBALLOON(memballoon),
SMARTCARD(smartcard),
BALLOON(balloon),
OTHER(other, 0),
UNKNOWN(unknown, -1);
But VmDevice class has two String attributes device and type. So for
example
a disk is a device
which has device set to disk and type set to disk (according to
VmDeviceCommonUtils.isDisk method).
So my question is, if I have a custom properties for disk, will they
be
available for all disk
devices (disk, cdrom, floppy, ...) or only for real disk? So should
we
support custom properties
for all VmDeviceType enum value separately?
Thanks for suggestions
Martin
The reason for that difference is that we had types in the backend code
only
for managed devices . (i.e. devoices that are known and handled by the
backend)
Any other device as balloon etc. is considered as unmanaged device , that
means that VDSM tells us that it exists and therefore tell us its type as
well...
Ok, I understand this.
But there are also OTHER and UNKNOWN device types in backend, but these
types
doesn't
corresponds to ANY type in VDSM. I don't want to refactor VmDevice device
and
type attributes
too much, so is it safe to expect that device attribute of VmDevice can
only
contain
one of VDSM device types ('disk', 'interface', 'video', 'sound',
'controller', 'balloon',
'channel', 'console', 'smartcard')? It's really important question, because
replacing
String type with enum would save a lot of code in device custom properties
implementation.
Sorry, I wrote wrong attribute. Do you think it's safe to expect that type
attribute
of VmDevice can only contain one of VDSM device types ('disk', 'interface',
'video', 'sound',
'controller', 'balloon', 'channel', 'console', 'smartcard')?
That sounds good to me.
I support this apporach.
Martin
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Build ovirt-engine with Eclipse
Why did you fail? Provide info. I use Eclipse Juno. - Original Message - From: leaboy@126 wlblea...@126.com To: engine-devel@ovirt.org Sent: Friday, May 10, 2013 5:06:10 AM Subject: [Engine-devel] Build ovirt-engine with Eclipse Hi, all: I want to know which IDE or environment you are using to develop ovirt-engine, Recently, I want to build and debug ovirt-engine with Eclipse, but when I install all the plugins for build it in eclipse, and install jboss and postgre-sql, and then how can I built it , and deploy it, and debug it . I tried to use eclipse like http://www.ovirt.org/Building_Ovirt_Engine/IDE , but failed. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Error looking up infinispan/ovirt-engine
Hi Alon, I might check this later on today. Did you follow Kublin's email about introducing infinispan? he sent it to engine-devel (you're supposed during the build to perform -P setup) Yair - Original Message - From: Alon Bar-Lev alo...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, May 2, 2013 11:11:03 PM Subject: [Engine-devel] Error looking up infinispan/ovirt-engine Hello, I get these (lots of these) using latest master... anyone knows what was changed? At server.log I see: --- 2013-05-02 19:58:08,046 INFO [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 21) JBAS010280: Activating Infinispan subsystem. snip 2013-05-02 19:58:10,155 INFO [org.jboss.as.controller] (Controller Boot Thread) JBAS014774: Service status report JBAS014775:New missing/unsatisfied dependencies: service jboss.mbean.server (missing) dependents: [service jboss.infinispan.ovirt-engine.config] --- Thanks, Alon --- 2013-05-02 20:02:10,012 ERROR [org.ovirt.engine.core.utils.ejb.EJBUtilsStrategy] (DefaultQuartzScheduler_Worker-7) [4b3a50f7] Failed to lookup resource type: CACHE_CONTAINER. JNDI name: java:jboss/infinispan/ovirt-engine: javax.naming.NameNotFoundException: Error looking up infinispan/ovirt-engine, service service jboss.naming.context.java.jboss.infinispan.ovirt-engine is not started at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:126) at org.jboss.as.naming.ServiceBasedNamingStore.lookup(ServiceBasedNamingStore.java:74) at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:178) at org.jboss.as.naming.InitialContext.lookup(InitialContext.java:123) at org.jboss.as.naming.NamingContext.lookup(NamingContext.java:214) at javax.naming.InitialContext.lookup(InitialContext.java:411) [rt.jar:1.7.0_17] at org.ovirt.engine.core.utils.ejb.EJBUtilsStrategy.findBean(EJBUtilsStrategy.java:104) [utils.jar:] at org.ovirt.engine.core.utils.ejb.EjbUtils.findBean(EjbUtils.java:23) [utils.jar:] at org.ovirt.engine.core.utils.cache.CacheManager.getTimeoutBaseCache(CacheManager.java:12) [utils.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.TimeoutBase.getLegal(TimeoutBase.java:51) [dal.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector.log(AuditLogDirector.java:809) [dal.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector.log(AuditLogDirector.java:803) [dal.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector.log(AuditLogDirector.java:799) [dal.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase.log(AuditLogableBase.java:437) [dal.jar:] at org.ovirt.engine.core.bll.CommandBase.logCommand(CommandBase.java:1208) [bll.jar:] at org.ovirt.engine.core.bll.CommandBase.execute(CommandBase.java:1175) [bll.jar:] at org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:318) [bll.jar:] at org.ovirt.engine.core.bll.Backend.runActionImpl(Backend.java:332) [bll.jar:] at org.ovirt.engine.core.bll.Backend.runInternalAction(Backend.java:534) [bll.jar:] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_17] 2013-05-02 20:02:10,059 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase] (DefaultQuartzScheduler_Worker-7) [4b3a50f7] Error during log command: org.ovirt.engine.core.bll.SetNonOperationalVdsCommand. Exception java.lang.NullPointerException: java.lang.NullPointerException at org.ovirt.engine.core.utils.cache.CacheManager.getTimeoutBaseCache(CacheManager.java:13) [utils.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.TimeoutBase.getLegal(TimeoutBase.java:51) [dal.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector.log(AuditLogDirector.java:809) [dal.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector.log(AuditLogDirector.java:803) [dal.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector.log(AuditLogDirector.java:799) [dal.jar:] at org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase.log(AuditLogableBase.java:437) [dal.jar:] at org.ovirt.engine.core.bll.CommandBase.logCommand(CommandBase.java:1208) [bll.jar:] at
Re: [Engine-devel] VDSM Fake
Great job. I guess you're communicating in in-secure way with fake-vdsm? - Original Message - From: Libor Spevak lspe...@redhat.com To: Liran Zelkha lzel...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, April 30, 2013 2:00:33 PM Subject: Re: [Engine-devel] VDSM Fake I didn't have enough time to make a real stress test, I created 100 hosts running 300 VMs, all-in-one - one server running Engine, DB, VDSM Fake. I put the VMs into running state and tried migration. It was rather responsive. The server had still enough resources. On 30.4.2013 12:48, Liran Zelkha wrote: Awesome. I really need this for the stress tests I'm running. How many hosts were you able to simulate with one web application? - Original Message - From: Libor Spevak lspe...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, April 30, 2013 12:50:52 PM Subject: [Engine-devel] VDSM Fake Hi, let me introduce an experimental project called VDSM Fake. This is a small Java web application simulating selected VDSM features, but only from the Engine point of view. The aim was to get oVirt-Engine top performance characteristics in core features simulating hundreds of fake hosts and VMs, and in ecologic way. More info: http://www.ovirt.org/VDSM_Fake Sources: git clone git://github.com/lspevak/ovirt-vdsmfake.git git clone git://github.com/lspevak/ovirt-restapiconf.git Regards, Libor ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] rewrite the engine-notifier service wrapper
- Original Message - From: Alon Bar-Lev alo...@redhat.com To: engine-devel engine-devel@ovirt.org Cc: Juan Hernandez jhern...@redhat.com, Simon Grinberg si...@redhat.com Sent: Tuesday, April 23, 2013 1:15:01 AM Subject: [Engine-devel] rewrite the engine-notifier service wrapper Hello, After finish to cleanup the engine-service to use downstream services and be portable to other distributions (upstart, openrc), we can use the same infrastructure for the engine notifier script. It is very similar to the engine-service in operation (running java), except it is written in bash instead of python and has no systemd support, and have its own configuration. What I suggest is to rewrite the notifier service in python and reuse the engine-service code. Also, drop the /etc/ovirt-engine/notifier/notifier.conf in favor of variables within the /etc/ovirt-engine/engine.conf[.d/*], this will provide a single point of configuration for all services. And of course proper systemd support and development environment support. Any comments? thoughts? Alon IMHO - +1 , the sooner the better - start with that and move to all the other bash scripts of the tools ;) ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Introducing Infinispan cache and some required actions after change
- Original Message - From: Michael Kublin mkub...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Tuesday, April 23, 2013 10:30:09 AM Subject: [Engine-devel] Introducing Infinispan cache and some required actions after change Hi All, The following commit I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7 will introduce a in memory cache inside ovirt-engine The cache which was chosen is infinispan (http://www.jboss.org/infinispan/) The reasons are following: cache has all required functionality, it is open source project and has built-in integration with JBOSS, all cache configuration can be accessed or edited via JBOSS admin console. By introducing this commit the first stage is finished: 1. Cache implementation is added to project 2. Show example how to add and use a cache in ovirt-engine, if it is required 3. Solved bug with possible memory leak in audit log event The next stages are: 1. Second stage - replace all custom made implementation by standard central cache implementation 2. Third stage - introduce second level cache for work with DB 3. Fourth stage (Future) - make cluster wise cache or make cache as service, if we will have more than one instance of JBOSS Now, after the applying the following commit I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7, everyone who works with ovirt-engine will be required to perform the following operation 1. Run mvn clean install -Pdep,setup in order to replace an old standalone.xml with new version of it Or 1. Use regular deploy: mvn clean install -Pdep 2. Access to $JBOSS_HOME/bin/standalone.xml and replace or add infinispan subsystem: subsystem xmlns=urn:jboss:domain:infinispan:1.1 default-cache-container=ovirt-engine cache-container name=ovirt-engine default-cache=timeout-base jndi-name=java:jboss/infinispan/ovirt-engine start=EAGER local-cache name=timeout-base transaction mode=NONE/ eviction max-entries=1/ expiration interval=6/ /local-cache /cache-container /subsystem 3. Add or check that exists extension module=org.jboss.as.clustering.infinispan/ under extensions element Great! Minor addition - For those of you who are familiar with the term region (exists at JBoss Cache, and IIRC ehcache) - look at the configuration Michael provided for timeout-base. Infinspan supports transactions (see the transaction-mode) and supports distribution (currently at local mode - see the local-cache definition). Yair Thanks and Regards Michael ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] Question about reports generating when running mvn site
Hi all, It seems that generating all the reports when running mvn:site takes quite some time. Do we really need all these reports? Here is a snippet from the execution - [INFO] Generating About report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Project Team report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Dependency Information report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Dependency Management report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Project Plugins report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Continuous Integration report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Issue Tracking report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Source Repository report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Dependency Convergence report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Project License report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Plugin Management report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Distribution Management report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Project Summary report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Mailing Lists report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Dependencies report--- maven-project-info-reports-plugin:2.6 These reports are being generated when I run mvn site in order to generate a find-bugs report. Many thanks, Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Question about reports generating when running mvn site
Mike came up with a simpler solution - mvn findbugs:findbugs - from root pom Works like a charm. Many thanks! - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Mike Kolesnik mkole...@redhat.com Sent: Monday, April 22, 2013 9:35:12 AM Subject: Re: [Engine-devel] Question about reports generating when running mvnsite No, I will try. Thanks. - Original Message - From: Mike Kolesnik mkole...@redhat.com To: Yair Zaslavsky yzasl...@redhat.com Sent: Monday, April 22, 2013 9:30:35 AM Subject: Re: [Engine-devel] Question about reports generating when running mvn site have you tried mvn findbugs:findbugs ? Regards, Mike - Original Message - Hi all, It seems that generating all the reports when running mvn:site takes quite some time. Do we really need all these reports? Here is a snippet from the execution - [INFO] Generating About report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Project Team report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Dependency Information report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Dependency Management report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Project Plugins report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Continuous Integration report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Issue Tracking report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Source Repository report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Dependency Convergence report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Project License report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Plugin Management report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Distribution Management report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Project Summary report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Mailing Lists report--- maven-project-info-reports-plugin:2.6 [INFO] Generating Dependencies report--- maven-project-info-reports-plugin:2.6 These reports are being generated when I run mvn site in order to generate a find-bugs report. Many thanks, Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Location of findbugs filter.xml file
Following this short vote, I have decided to adopt an approach in which we will use findbugs with the maven plugin on a per module basis, as some of you have suggested. An example for bll can be found here - http://gerrit.ovirt.org/#/c/14110/3 - Original Message - From: Michael Pasternak mpast...@redhat.com To: Oved Ourfalli ov...@redhat.com Cc: Yair Zaslavsky yzasl...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Thursday, April 18, 2013 9:33:34 PM Subject: Re: [Engine-devel] Location of findbugs filter.xml file On 04/18/2013 04:58 PM, Oved Ourfalli wrote: - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Thursday, April 18, 2013 4:55:46 PM Subject: [Engine-devel] Location of findbugs filter.xml file Hi all, I sent a patch upstream to add findbugs filter that will filter out bug reports that we decided that are not bugs. We have a debate on whether to have the findbugs filter definition in the root pom.xml or to put it in the jenkins jobs repo and treat it as an external tool. I would like to hear opinions about what you think should be the proper location Putting it in the root pom.xml file will allow running filtered findbugs using maven, without the need to use jenkins, so I'd go with that approach. +1 Thanks, Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- Michael Pasternak RedHat, ENG-Virtualization RD ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] Location of findbugs filter.xml file
Hi all, I sent a patch upstream to add findbugs filter that will filter out bug reports that we decided that are not bugs. We have a debate on whether to have the findbugs filter definition in the root pom.xml or to put it in the jenkins jobs repo and treat it as an external tool. I would like to hear opinions about what you think should be the proper location Thanks, Yair ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] watchdog
- Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 11:33:19 AM Subject: Re: [Engine-devel] watchdog Good that you have come up with this! So we will make sure to keep this info. Thnx for coming up with it! - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Tomas Jelinek tjeli...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 10:25:28 AM Subject: Re: [Engine-devel] watchdog - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 10:02:16 AM Subject: Re: [Engine-devel] watchdog - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Itamar Heim ih...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 11, 2013 9:56:32 AM Subject: Re: [Engine-devel] watchdog Hi, Isnt someone already working on removing the UI distinction between server and desktop? Indeed :) However the desktop/server distinction could be useful for scheduling information, I hope that will remain. There will be a combo box: optimized for server/desktop. That one will set up the dialog like you would open the new server/desktop today. But you will be able to change them - it will be just some sugar. But there is no reason why would we enforce the disabling the e.g. soundcard for server. By default we will, but you can enable it if you want. Ok, so in engine we will still have the VmType in vmStatic? I think it would make sense to use it in scheduling / load balancing - if a VM is a desktop and no user is connected to the console, then the VM is not in use, therefore it is a good candidate for saving power (hibernate, migrate, shutdown, or any other bad things that can happen to a VM) - if a VM is a server, usually no user connected, but it may still be used through its network. Therefore it may not be a good candidate to migrate. is this indeed a valid assumption (if VM is a server... ) that a user will less connect to it? - Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Andrew Cathrow acath...@redhat.com Sent: Wednesday, April 10, 2013 9:38:15 PM Subject: Re: [Engine-devel] watchdog On 04/10/2013 04:59 PM, Laszlo Hornyak wrote: Hi, A new version of the watchdög feature is available in gerrit: http://gerrit.ovirt.org/13057 - db http://gerrit.ovirt.org/13058 - bll http://gerrit.ovirt.org/13059 - frontend http://gerrit.ovirt.org/13060 - rest http://www.ovirt.org/Features/Watchdog_engine_support Since the last update the patchset has gone through major changes to meet the new architectureal and functional requirements. Also because of the rewrite this is again a preview version under testing with some missing functionality, therefore I re-introduced the [wip] flag on it. Thx, Laszlo ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel just a thought after looking at the feature page having different HA dialog for server/desktop - I'd consider removing the distinction between desktop and server in the GUI wrt HA (i.e., just both have same set of options) (not blocking for this patch) ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] watchdog
- Original Message -
From: Laszlo Hornyak lhorn...@redhat.com
To: Yair Zaslavsky yzasl...@redhat.com
Cc: Tomas Jelinek tjeli...@redhat.com, engine-devel
engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 1:57:04 PM
Subject: Re: [Engine-devel] watchdog
No what I meant is that
if the VM is a server {
not having a console connection to it does not mean that it is not used.
Used is a more general term than someone is connected to - for example, you
may have a machine running some internal calculation which takes a considerable
amount of time, and you may have a user
that performs ssh to that machine (let's say once in an hour) and runs some
utility that reports the status of the calculation.
}
Therefore desktops on the same host with no console connection, they may be
better candidates for migration. You can connect to servers.
- Original Message -
From: Yair Zaslavsky yzasl...@redhat.com
To: Tomas Jelinek tjeli...@redhat.com
Cc: Laszlo Hornyak lhorn...@redhat.com, engine-devel
engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 12:26:35 PM
Subject: Re: [Engine-devel] watchdog
- Original Message -
From: Tomas Jelinek tjeli...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 11:33:19 AM
Subject: Re: [Engine-devel] watchdog
Good that you have come up with this! So we will make sure to keep this
info.
Thnx for coming up with it!
- Original Message -
From: Laszlo Hornyak lhorn...@redhat.com
To: Tomas Jelinek tjeli...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 10:25:28 AM
Subject: Re: [Engine-devel] watchdog
- Original Message -
From: Tomas Jelinek tjeli...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 10:02:16 AM
Subject: Re: [Engine-devel] watchdog
- Original Message -
From: Laszlo Hornyak lhorn...@redhat.com
To: Itamar Heim ih...@redhat.com
Cc: engine-devel engine-devel@ovirt.org
Sent: Thursday, April 11, 2013 9:56:32 AM
Subject: Re: [Engine-devel] watchdog
Hi,
Isnt someone already working on removing the UI distinction between
server
and desktop?
Indeed :)
However the desktop/server distinction could be useful for
scheduling
information, I hope that will remain.
There will be a combo box: optimized for server/desktop. That one
will set up the dialog like you would open the new server/desktop
today.
But you will be able to change them - it will be just some sugar. But
there
is no reason
why would we enforce the disabling the e.g. soundcard for server. By
default
we will, but
you can enable it if you want.
Ok, so in engine we will still have the VmType in vmStatic?
I think it would make sense to use it in scheduling / load balancing
- if a VM is a desktop and no user is connected to the console, then
the
VM
is not in use, therefore it is a good candidate for saving power
(hibernate,
migrate, shutdown, or any other bad things that can happen to a VM)
- if a VM is a server, usually no user connected, but it may still be
used
through its network. Therefore it may not be a good candidate to
migrate.
is this indeed a valid assumption (if VM is a server... ) that a user
will
less connect to it?
- Original Message -
From: Itamar Heim ih...@redhat.com
To: Laszlo Hornyak lhorn...@redhat.com
Cc: engine-devel engine-devel@ovirt.org, Andrew Cathrow
acath...@redhat.com
Sent: Wednesday, April 10, 2013 9:38:15 PM
Subject: Re: [Engine-devel] watchdog
On 04/10/2013 04:59 PM, Laszlo Hornyak wrote:
Hi,
A new version of the watchdög feature is available in gerrit:
http://gerrit.ovirt.org/13057 - db
http://gerrit.ovirt.org/13058 - bll
http://gerrit.ovirt.org/13059 - frontend
http://gerrit.ovirt.org/13060 - rest
http://www.ovirt.org/Features/Watchdog_engine_support
Since the last update the patchset has gone through major
changes
to
meet
the new architectureal and functional requirements.
Also because of the rewrite this is again a preview version
under
testing
with some missing functionality, therefore I re-introduced the
[wip]
flag
on it.
Thx,
Laszlo
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman
Re: [Engine-devel] Move SQL out of stored procedures
- Original Message - From: Libor Spevak lspe...@redhat.com To: Juan Hernandez jhern...@redhat.com Cc: engine-devel@ovirt.org Sent: Wednesday, March 27, 2013 10:09:22 AM Subject: Re: [Engine-devel] Move SQL out of stored procedures Hi, I would recommend always to avoid hard coding SQL into Java code. It is very hard to maintain and read. If there is something, which prevents using JPA/Hibernate, e.g. the database relational model doesn't reflect the object-oriented domain very well or we have to live with many stored procedures concurrently, I would choose a framework, which enables to externalize the SQL code (into XML). I worked on a larger project(s) with a lot of PL/SQL code, we moved to myBatis (previously iBatis) very soon for Java backend: https://code.google.com/p/mybatis/ Libor I used a similar approach at past project - not with iBatis though, but a in house implementation of such framework. I think this idea is worth considering. On 26.3.2013 18:34, Juan Hernandez wrote: Hello, I would like to start a discussion about the subject. I think this is something we need to do if one day we want to be able to use any database other than PostgreSQL. I did an small example of what it takes and how it looks like to have the SQL code into the DAOs: http://gerrit.ovirt.org/13347 It isn't rocket science, it isn't an exciting task, it isn't fun, but something I think we should eventually do. I appreciate any comment about how and when to do this, including those saying that instead of this primitive approach we should use this or that ORM framework. Regards, Juan Hernandez ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
