Re: [Development] 'register' not fully removed from Qt?

2014-01-03 Thread Jiergir Ogoerg
Thanks, you never know what's the right thing to do.. On Sat, Jan 4, 2014 at 12:25 AM, Sergio Martins wrote: > On Saturday, January 04, 2014 00:16:26 Jiergir Ogoerg wrote: >> I did file the bug, but what happens after that is entirely up to the >> glibc devs: >> https

Re: [Development] 'register' not fully removed from Qt?

2014-01-03 Thread Jiergir Ogoerg
de dezembro de 2013 17:45:13, Jiergir Ogoerg wrote: >>> return bswap_32(source); >>> >>> >>> So was 'register' reintroduced or not fully removed, or something else? >> >>Something else. bswap_32 is a macro. > > I’m getting this as well.

[Development] Coding style proposal

2014-01-02 Thread Jiergir Ogoerg
st coding style we're talking about here. And we figured out the check box to sort methods out, thank you. Jiergir Ogoerg wrote: > Ironically, not even the IDE (QtCreator) sorts them out, in my example > parse...() is the 1st in the list, and locale() is the last one (16th). Th

Re: [Development] Coding style proposal

2014-01-02 Thread Jiergir Ogoerg
zations, but obviously none of this is an option for Qt for different reasons, so case closed. I get that. On Thu, Jan 2, 2014 at 9:34 PM, Richard Moore wrote: > On 2 January 2014 18:33, Jiergir Ogoerg wrote: >> It's not for documentation purposes (not for those using Qt to create

Re: [Development] Coding style proposal

2014-01-02 Thread Jiergir Ogoerg
, Giuseppe D'Angelo wrote: > On Thu, Jan 2, 2014 at 7:33 PM, Jiergir Ogoerg wrote: >> >> If it was ordered, then you'd know to scroll up to the top if you're >> looking for a method called "awesome()", >> if you got another method "awesomeAndMore()

Re: [Development] Coding style proposal

2014-01-02 Thread Jiergir Ogoerg
, Jan 2, 2014 at 9:34 AM, Konstantin Ritt wrote: > 1. In cpp, we typically use enums for numeric constants. In Qt coding style, > enums are in CamelCase. > 2. Just a wasting of time. Simply use generated documentation rather than > scroll over the header files (Qt docs are very good

[Development] Coding style proposal

2014-01-01 Thread Jiergir Ogoerg
Hi, 1. Constant names Typically constants are named UPPER_CASE which is slightly annoying (looks like shouting) and look like macros which are also named upper case. I'd propose naming constants with a lowercase "k" followed by camel case: const int kMonthCount = 12; It makes it easy to distingu

Re: [Development] Add locale cache for Linux

2014-01-01 Thread Jiergir Ogoerg
te: > On 2 January 2014 09:05, Jiergir Ogoerg wrote: >> >> Thanks, >> On gerrit there are 5 buttons the related to reply: >> Reply... >> Reply Done >> Discard >> Cancel >> Save >> >> Which one actually send the reply so the revie

Re: [Development] Add locale cache for Linux

2014-01-01 Thread Jiergir Ogoerg
ok at the > maintainers page to see whom to add. Or you can even look at commit > log of the file you've touched to figure out a reviewer. > > Also, you might want to fix the sanity failure before adding reviewers! :) > > -mandeep > > > On Wed, Jan 1, 2014 at 8:59 AM

[Development] Add locale cache for Linux

2013-12-31 Thread Jiergir Ogoerg
Hi, I have added for the 1st time code for review, please let me know if it's ready for review or if I have to do some additional work. 2 Submits: 1) https://codereview.qt-project.org/#change,74524 Cosmetic, removes trailing whitespaces: 2) https://codereview.qt-project.org/#change,74525 ___

Re: [Development] git submodules

2013-12-31 Thread Jiergir Ogoerg
I see, thanks. On Wed, Jan 1, 2014 at 3:22 AM, Sze Howe Koh wrote: > On 1 January 2014 09:00, Jiergir Ogoerg wrote: >> >> Thanks a lot, I was about to write I figured it out, but your reply >> gave me further insight. > > You're welcome. > > >> The p

Re: [Development] git submodules

2013-12-31 Thread Jiergir Ogoerg
ng to? For example I pushed (then abandoned) this: https://codereview.qt-project.org/#change,74520 Was it in queue for Qt4 or Qt5, the webpage doesn't mention any of these.. On Wed, Jan 1, 2014 at 2:23 AM, Sze Howe Koh wrote: > On 1 January 2014 04:00, Jiergir Ogoerg wrote: &g

[Development] git submodules

2013-12-30 Thread Jiergir Ogoerg
Hi, the Qt tutorials that explain how to use git don't mention git submodules. Is that why after doing changes to some source file "git diff" doesn't show the changes as expected from reading this: http://qt-project.org/wiki/Git_Introduction I'm working with the files from qt5/qtbase/src/plugins/

Re: [Development] gitorious error

2013-12-30 Thread Jiergir Ogoerg
n 30 December 2013 19:35, Jiergir Ogoerg wrote: >> >> Hi, >> I'm trying to follow the pile of tutorials to be able to contribute code >> to qt. >> >> At >> http://qt-project.org/wiki/Git_Introduction >> at "Getting the Qt source code"

Re: [Development] gitorious error

2013-12-30 Thread Jiergir Ogoerg
20 KDE cause it hangs after updates after reboot while booting) and see if problem gone. On Mon, Dec 30, 2013 at 9:10 PM, Nicolás Alvarez wrote: > 2013/12/30 Jiergir Ogoerg : >> Hi, >> I'm trying to follow the pile of tutorials to be able to contribute code to >> q

[Development] gitorious error

2013-12-30 Thread Jiergir Ogoerg
Hi, I'm trying to follow the pile of tutorials to be able to contribute code to qt. At http://qt-project.org/wiki/Git_Introduction at "Getting the Qt source code" I must do git clone git://gitorious.org/qt/qt.git but it yields this on the command line: Cloning into 'qt'... fatal: unable to connec

Re: [Development] OK to add zero/bulk copy to QVector?

2013-12-29 Thread Jiergir Ogoerg
QVector data = QVector::fromRawData(dataPtr, > dataSize)" costs you near to nothing once again but has a pretty nice, > non-ambiguous "fromRawData" name. > > Regards, > Konstantin > > > 2013/12/30 Jiergir Ogoerg >> >> I would vouch for a non stati

Re: [Development] OK to add zero/bulk copy to QVector?

2013-12-29 Thread Jiergir Ogoerg
nt size)". Though, I'm not sure if we can do this until 6.0. > > Regards, > Konstantin > > > 2013/12/30 Jiergir Ogoerg >> >> QVector is created before I can load the array on the heap, so I can't >> init it to the desired >> it

[Development] OK to add zero/bulk copy to QVector?

2013-12-29 Thread Jiergir Ogoerg
Hi, there are 2 simple options to speed up setting/adding elements to a vector when a heap buffer is filled in in advance: 1) Bulk copy. Assign a bunch of elements at once (from another vector or array), like std::vector::assign() does. A big extra copy happens, but avoids multiple calls to push_ba

[Development] 'register' not fully removed from Qt?

2013-12-25 Thread Jiergir Ogoerg
Hi, Judging by this: https://codereview.qt-project.org/#change,59022 the 'register' keyword has been removed from Qt, but I have a Qt 5.2 build from Dec 22 2013 on amd64 Linux and LLVM 3.4 issues a pile of warnings about the 'register' keyword in QtCore/qendian.h like this: In file included from

Re: [Development] It could be a little bug

2013-11-01 Thread Jiergir Ogoerg
for other people in the future to waste their time discussing the wacky behaviour of the function, it's fun. On Sat, Nov 2, 2013 at 12:40 AM, Nicolás Alvarez wrote: > 2013/11/1 Marc Mutz : > > On Tuesday, October 29, 2013 01:21:08 Jiergir Ogoerg wrote: > >> Hi, > >

Re: [Development] It could be a little bug

2013-11-01 Thread Jiergir Ogoerg
;s pretty much never triggered, let it stay there, it makes the code look professorial and sophisticated. On Fri, Nov 1, 2013 at 4:35 PM, Marc Mutz wrote: > On Tuesday, October 29, 2013 01:21:08 Jiergir Ogoerg wrote: > > Hi, > > There's an enum

Re: [Development] Cut 7+ms of Qt5 startup time on Linux

2013-10-31 Thread Jiergir Ogoerg
Great, of course you're a much better/smarter programmer than me, but how much time of the whole parsing and loading (which is done line by line which is slow) does fromUtf8() take? If it's only like 10-20% then even if it's optimized to work 10 times faster in the end it's a much smaller improveme

Re: [Development] Cut 7+ms of Qt5 startup time on Linux

2013-10-31 Thread Jiergir Ogoerg
ng to a binary format, I’d first like to check whether we can > > further speed up the parsing. I’ve done some work in that area in spring, > > but I know there was still quite some room to improve it. > > > > Cheers, > > Lars > > > > From: Jiergir Ogoerg &

Re: [Development] Cut 7+ms of Qt5 startup time on Linux

2013-10-30 Thread Jiergir Ogoerg
M, Nicolás Alvarez wrote: > 2013/10/31 Jiergir Ogoerg : > > so the idea is to cache the locale file in binary format in the > > home/.kde directory (the binary file is also smaller than the other one), > > Why would Qt store stuff into home/.kde? > > > Since I don't rep

Re: [Development] It could be a little bug

2013-10-28 Thread Jiergir Ogoerg
Forgot to mention, m_state is of type enum TableState. On Tue, Oct 29, 2013 at 2:21 AM, Jiergir Ogoerg wrote: > Hi, > There's an enum: > > //==> code > enum TableState > { > UnsupportedLocale, > EmptyTable, > UnknownSystemCompo

[Development] It could be a little bug

2013-10-28 Thread Jiergir Ogoerg
Hi, There's an enum: //==> code enum TableState { UnsupportedLocale, EmptyTable, UnknownSystemComposeDir, MissingComposeFile, NoErrors }; //<== code and this: //==> code bool cleanState() const { return ((m_state & NoErrors) == NoErrors); } //<== c

Re: [Development] Is Qt allowed caching the home dir path?

2013-10-27 Thread Jiergir Ogoerg
tubro de 2013 00:38:51, Jiergir Ogoerg wrote: > > Probably, but then afaik it either (a) somehow can create barriers or (b) > > implements > > a broken but good enough solution like DCLP (double checked locking > > pattern), > > I couldn't figure out cause it uses Q

Re: [Development] Is Qt allowed caching the home dir path?

2013-10-27 Thread Jiergir Ogoerg
By accident I sent the email to you too, sorry, gmail by default selects both emails. On Mon, Oct 28, 2013 at 12:38 AM, Jiergir Ogoerg wrote: > Probably, but then afaik it either (a) somehow can create barriers or (b) > implements > a broken but good enough solution like DCLP (doubl

Re: [Development] Is Qt allowed caching the home dir path?

2013-10-27 Thread Jiergir Ogoerg
> On segunda-feira, 28 de outubro de 2013 00:12:36, Jiergir Ogoerg wrote: > > Yep, I know, the solution I proposed was also thread safe, but it didn't > > require a lock/unlock > > on each function call or extra memory structs around it. > > Q_GLOBAL_STATIC does n

Re: [Development] Is Qt allowed caching the home dir path?

2013-10-27 Thread Jiergir Ogoerg
lated to this issue) so I'll leave this (non-)issue for later cause the Qt start up time to me is far more important. On Sun, Oct 27, 2013 at 11:55 PM, Thiago Macieira wrote: > On domingo, 27 de outubro de 2013 22:51:59, Jiergir Ogoerg wrote: > > But looking at its source code [1]

Re: [Development] Is Qt allowed caching the home dir path?

2013-10-27 Thread Jiergir Ogoerg
the non-atomic nature of construction, this function may return false for a short time after the construction has completed." On Sun, Oct 27, 2013 at 6:13 PM, Olivier Goffart wrote: > On Sunday 27 October 2013 04:53:41 Jiergir Ogoerg wrote: > > It looks like only the home and temp dir pa

Re: [Development] Is Qt allowed caching the home dir path?

2013-10-26 Thread Jiergir Ogoerg
tion::self = this; // after this line QDirPrivate::initPaths(); } Does it sound plausible? On Sat, Oct 26, 2013 at 10:14 PM, Thiago Macieira wrote: > On sábado, 26 de outubro de 2013 21:58:10, Jiergir Ogoerg wrote: > > That is, it calls other (sub)functions to perform search, copy an

[Development] Is Qt allowed caching the home dir path?

2013-10-26 Thread Jiergir Ogoerg
Hi, I noticed that internally QDir::homePath() does quite some extra work: 1) It returns a copy of the home path string (not a const QString&) 2) Each time QDir::homePath() calls QFileSystemEngine::homePath() which does this: //START QString home = QFile::decodeName(qgetenv("HOME")); if (home.isEm

Re: [Development] QApplication startup is again slower

2013-10-17 Thread Jiergir Ogoerg
t 10:07 PM, Thiago Macieira wrote: > On quinta-feira, 17 de outubro de 2013 20:56:11, Jiergir Ogoerg wrote: > > Thanks, > > at step: > > git checkout 728cd2e1737544c6236c9c9acfb502381c598149 > > it says: > > fatal: reference is not a tree: 728cd2e1737544c6236c9c9acf

Re: [Development] QApplication startup is again slower

2013-10-17 Thread Jiergir Ogoerg
8:46 PM, Thiago Macieira wrote: > On quinta-feira, 17 de outubro de 2013 20:22:32, Jiergir Ogoerg wrote: > > Thanks, what would be the full command, this?: > > git clone git:// > > gitorious.org/qt/qt5.git:728cd2e1737544c6236c9c9acfb502381c598149 > > No. > >

Re: [Development] QApplication startup is again slower

2013-10-17 Thread Jiergir Ogoerg
Thanks, what would be the full command, this?: git clone git:// gitorious.org/qt/qt5.git:728cd2e1737544c6236c9c9acfb502381c598149 On Thu, Oct 17, 2013 at 8:16 PM, Thiago Macieira wrote: > On quinta-feira, 17 de outubro de 2013 19:30:37, Jiergir Ogoerg wrote: > > Hi, > > h

[Development] QApplication startup is again slower

2013-10-17 Thread Jiergir Ogoerg
Hi, how do I get the version of the first qt 5.2 (pre-)beta from Oct 10 2013 (when it was announced)? That is, what's the exact git command and params since I can't figure it out. Why: I recall using that version and QApplication starting up quickly - as it should - in like 70-80ms, now it takes ~

Re: [Development] Qt 5.2 Testing (System tray)

2013-10-14 Thread Jiergir Ogoerg
/+bug/1157213 > > > On Mon, Oct 14, 2013 at 11:17 AM, Jiergir Ogoerg wrote: > >> I see, you guys don't have time (motivation or whatever) to look closer >> into this issue. At least I tried. >> >> As to Ubuntu's popularity - I don't like Canonic

Re: [Development] Qt 5.2 Testing (System tray)

2013-10-14 Thread Jiergir Ogoerg
M, Thiago Macieira wrote: > On segunda-feira, 14 de outubro de 2013 18:55:56, Jiergir Ogoerg wrote: > > To test qt4 I did "sudo apt-get install libqt4-dev", that is, the libs > that > > come with Ubuntu. I'm not a Qt developer so I hope you guys figure out > why

Re: [Development] Qt 5.2 Testing (System tray)

2013-10-14 Thread Jiergir Ogoerg
guess it's worth spending some time investigating this issue, I'm just a Qt user so I don't know how Qt works underneath. On Mon, Oct 14, 2013 at 6:32 PM, Thiago Macieira wrote: > On segunda-feira, 14 de outubro de 2013 18:10:34, Jiergir Ogoerg wrote: > > But the Qt4's s

[Development] Qt 5.2 Testing (System tray)

2013-10-14 Thread Jiergir Ogoerg
But the Qt4's systray works properly in this same version of Unity (I just tested myself). The issue you linked to is a different one, and the post is old and doesn't work - you can't white-list anything any longer in Unity (desktop > unity > panel doesn't exist in dconf), so it's certainly a Qt5+

[Development] Qt 5.2 Testing

2013-10-14 Thread Jiergir Ogoerg
Hi, Is system tray supposed to work under Ubuntu Unity? cause it's been broken ever since Qt 5.0 I guesss, including the recent Qt 5.2 beta release, the problem is: the tray icon doesn't show up - but it does show up (i.e. works) in Kubuntu (same computer, logging out of Unity, logging in into kubu

Re: [Development] QApplication startup is a lot slower in Qt5 than Qt4

2013-08-20 Thread Jiergir Ogoerg
I see, thanks. On Tue, Aug 20, 2013 at 9:14 PM, Thiago Macieira wrote: > On terça-feira, 20 de agosto de 2013 21:04:38, Jiergir Ogoerg wrote: > > Is the patch scheduled for post Qt 5.1.1 or there's been some > > misunderstanding while merging it for Qt 5.1.1? > > It

Re: [Development] QApplication startup is a lot slower in Qt5 than Qt4

2013-08-20 Thread Jiergir Ogoerg
me misunderstanding while merging it for Qt 5.1.1? On Tue, Aug 13, 2013 at 8:25 PM, Jiergir Ogoerg wrote: > Thanks, hoping it won't take a year+ to merge. > > > On Tue, Aug 13, 2013 at 7:07 PM, Thiago Macieira < > thiago.macie...@intel.com> wrote: > >> On

Re: [Development] QApplication startup is a lot slower in Qt5 than Qt4

2013-08-13 Thread Jiergir Ogoerg
Thanks, hoping it won't take a year+ to merge. On Tue, Aug 13, 2013 at 7:07 PM, Thiago Macieira wrote: > On segunda-feira, 12 de agosto de 2013 21:59:18, Jiergir Ogoerg wrote: > > Thanks, I installed both binary and from source qt 5.1.1 that was > announced > > half a

Re: [Development] QApplication startup is a lot slower in Qt5 than Qt4

2013-08-12 Thread Jiergir Ogoerg
g if not a secret? I'm asking because maybe it's an Ubuntu issue, I used Ubuntu amd64 13.04 and 13.10 daily. On Mon, Aug 12, 2013 at 10:55 AM, Rutledge Shawn wrote: > > On 11 Aug 2013, at 6:40 AM, Jiergir Ogoerg wrote: > > > Thanks, I compiled and installed from > > &

Re: [Development] QApplication startup is a lot slower in Qt5 than Qt4

2013-08-10 Thread Jiergir Ogoerg
wrong source files or if the startup time is gonna further improve. On Sun, Aug 11, 2013 at 3:55 AM, Thiago Macieira wrote: > On domingo, 11 de agosto de 2013 02:14:47, Jiergir Ogoerg wrote: > > Did anyone notice that > > QApplication app(argc, argv) > > takes on Qt5 about 220ms (

[Development] QApplication startup is a lot slower in Qt5 than Qt4

2013-08-10 Thread Jiergir Ogoerg
Hi, Did anyone notice that QApplication app(argc, argv) takes on Qt5 about 220ms (warm execution) to execute while on Qt4 only about 50-75ms (warm execution)? Another person confirmed these results on his computer. Can anyone please explain why it happens and if/when it gets fixed? Using Ubuntu a

Re: [Development] QT5 OpenGL question

2013-08-03 Thread Jiergir Ogoerg
QOpenGLFunctions_3_2_Core and other classes would not be providing glClear either, but they do provide it. On Sat, Aug 3, 2013 at 11:48 AM, Sean Harmer wrote: > On 02/08/2013 22:30, Jiergir Ogoerg wrote: > > Also, > QOpenGLFunctions doesn't have a glClear() function while being

Re: [Development] QT5 OpenGL question

2013-08-02 Thread Jiergir Ogoerg
ctions_3_2_Core do have such a function. On Fri, Aug 2, 2013 at 9:35 PM, Jiergir Ogoerg wrote: > Thanks both of you, I see now, GL is old (1993 I guess) and it shows, e.g. > it requires creating a context on windows before even being able to query > GL info etc. > > What do you

Re: [Development] QT5 OpenGL question

2013-08-02 Thread Jiergir Ogoerg
t gl.UseProgram - with Qt5 I'd have to use the former, unfortunately, but not a big deal. On Fri, Aug 2, 2013 at 3:21 PM, Sean Harmer wrote: > Hi, > > On Friday 02 August 2013 15:01:05 Jiergir Ogoerg wrote: > > Thanks, but it's better to use functions wrapped in namesp

Re: [Development] QT5 OpenGL question

2013-08-02 Thread Jiergir Ogoerg
On Friday 02 August 2013 10:05:56 Sze Howe Koh wrote: > > On 2 August 2013 08:16, Jiergir Ogoerg wrote: > > > Hi, > > > I'm willing to switch to QT5 with GL, > > > afaik in Qt5 the GL functions are encapsulated into a class that > extends > > >

[Development] QT5 OpenGL question

2013-08-01 Thread Jiergir Ogoerg
Hi, I'm willing to switch to QT5 with GL, afaik in Qt5 the GL functions are encapsulated into a class that extends QAbstractOpenGLFunctions and you can't use the GL calls outside that class unless you pass each time a reference to this class. Why doesn't it publish the GL functions publicly (not i