On Tuesday, 29 July 2014 at 17:06:55 UTC, Brad Anderson wrote:
Good start. The blocked ones are kind of long which is a slight
problem because Github truncates them in the Pull Request list.
Maybe rename them to awaits decision and awaits dependency.
I think await implies they are blocked
Dicebot wrote in message news:dltkkijmuwhjcchej...@forum.dlang.org...
As far as I can see one needs admin access to the repo to define new
labels. Merge access is not enough - at least I don't seem to be able
define new label for Phobos.
No, you just need commit access. On the pull
Dicebot wrote in message news:krxuctciwangfhiph...@forum.dlang.org...
One useful label I can imagine for both DMD and Phobos repos is
need-decision that will mark pull requests blocked until someone with
authority decides if actual semantics of a change are to be accepted or
rejected. That
On Tuesday, 29 July 2014 at 06:32:15 UTC, Daniel Murphy wrote:
I'm thinking along the lines of:
- Needs review
- Needs work
Makes sense if we agree to add those only if nothing happens with
pull for relatively long time - otherwise it means lot of useless
routine of switching back and forth
On Tuesday, 29 July 2014 at 06:24:26 UTC, Daniel Murphy wrote:
Dicebot wrote in message
news:dltkkijmuwhjcchej...@forum.dlang.org...
As far as I can see one needs admin access to the repo to
define new labels. Merge access is not enough - at least I
don't seem to be able define new label
Dicebot wrote in message news:efrstwsylpujuyycw...@forum.dlang.org...
Makes sense if we agree to add those only if nothing happens with pull for
relatively long time - otherwise it means lot of useless routine of
switching back and forth between needs review and needs work.
Yeah, I just
On Tuesday, 29 July 2014 at 07:18:37 UTC, Daniel Murphy wrote:
Reason why I have named it needs-decision (can't have
whitespaces in labels afaik) is that it is not necessarily an
enhancement stuff - sometimes bug fixes
can be also very controversial.
'Walter-blocked' is the true meaning.
We should consider a label for revivable PRs:
PRs which the original submitter is no longer responding but the
pull can be salvaged if somebody rebases and addresses the
feedback comments.
I tried using the search is:unmerged is:pr is:closed to try and
find candidates but unfortunately it
safety0ff wrote in message news:hvdsdwbvibtuojxvn...@forum.dlang.org...
We should consider a label for revivable PRs:
PRs which the original submitter is no longer responding but the
pull can be salvaged if somebody rebases and addresses the
feedback comments.
Tagged as 'needs work' + open
On Tuesday, 29 July 2014 at 14:12:34 UTC, Daniel Murphy wrote:
Tagged as 'needs work' + open + sort by recently updated should
do it.
Ok, this is workable as long as we remove needs work labels
prior to merging pulls.
PRs which are candidates for rebooting might be closed due to
safety0ff wrote in message news:qwdmzdjdwgqgqfrfc...@forum.dlang.org...
Ok, this is workable as long as we remove needs work labels prior to
merging pulls.
PRs which are candidates for rebooting might be closed due to inactivity.
This isn't too important right now, but I thought I'd toss the
On Tuesday, 29 July 2014 at 16:30:27 UTC, Daniel Murphy wrote:
Yeah. It would be easy enough to automatically add a 'merged'
or 'unmerged' tag to all closed pulls in necessary. I can't
see a way to search for pulls _without_ a certain label
unfortunately.
If you look at the link I
On Tuesday, 29 July 2014 at 10:42:24 UTC, Dicebot wrote:
[...]
I went ahead and have added few labels for Phobos
(https://github.com/D-Programming-Language/phobos/labels):
blocked (awaits decision) == Andrei-blocked but named a bit
more generic just in case
blocked by dependency == depends
Github updated their Issues system (which includes Pull
Requests). You can read about it here:
https://github.com/blog/1866-the-new-github-issues
Bugzilla is here to stay but the newly added Labels feature could
probably help organize Pull Requests. The usual Enhancement,
Bug, etc. are nice
On Monday, 28 July 2014 at 17:31:56 UTC, Brad Anderson wrote:
[...]
A lot of the time it seems like there is confusion over whose
court the ball is in.
I always forget idioms probably aren't a good idea in an
international community like this one.
Brad Anderson wrote in message
news:vtizuccrwzyidddfz...@forum.dlang.org...
Github updated their Issues system (which includes Pull Requests). You can
read about it here:
https://github.com/blog/1866-the-new-github-issues
Oh FINALLY!!!
I've wanted to use assignment and labels for a long
On Mon, Jul 28, 2014 at 05:31:55PM +, Brad Anderson via Digitalmars-d wrote:
Github updated their Issues system (which includes Pull Requests). You
can read about it here:
https://github.com/blog/1866-the-new-github-issues
Bugzilla is here to stay but the newly added Labels feature
Daniel Murphy wrote in message news:lr6249$18pf$1...@digitalmars.com...
Oh FINALLY!!!
I've just labelled all the DDMD pull requests.
On Monday, 28 July 2014 at 18:23:06 UTC, Daniel Murphy wrote:
Daniel Murphy wrote in message
news:lr6249$18pf$1...@digitalmars.com...
Oh FINALLY!!!
I've just labelled all the DDMD pull requests.
Nice.
https://github.com/D-Programming-Language/dmd/pulls?q=is%3Aopen+is%3Apr+label%3ADDMD
On Monday, 28 July 2014 at 18:23:06 UTC, Daniel Murphy wrote:
Daniel Murphy wrote in message
news:lr6249$18pf$1...@digitalmars.com...
Oh FINALLY!!!
I've just labelled all the DDMD pull requests.
This helps understand where the work is going on.
Thanks
Joseph
On 7/28/2014 12:31 PM, Brad Anderson wrote:
Github updated their Issues system (which includes Pull Requests). You
can read about it here:
https://github.com/blog/1866-the-new-github-issues
Bugzilla is here to stay but the newly added Labels feature could
probably help organize Pull Requests
Heh, have written a GitHub feature request about this ~2 weeks
ago, got answer we are already working on this, going to be
release soon. Have been eagerly awaiting announcement since then.
This can be very useful for improving pull request review
process. I think we should not duplicate PR
On Tuesday, 29 July 2014 at 01:35:30 UTC, Orvid King wrote:
How accessible is it possible to make the labels?
As far as I can see one needs admin access to the repo to define
new labels. Merge access is not enough - at least I don't seem to
be able define new label for Phobos.
Can they be
23 matches
Mail list logo
