Simple bug fix for DateTimeField with SplitDateTimeWidget.

2008-10-15 Thread Tai Lee
#8898 is a simple bug fix with tests for DateTime fields with required=False, which currently fail to validate in the admin because the `required` validation is being bypassed when using SplitDateTimeWidget with DateTimeField (which seems questionable to begin with). I'd set it to ready for

Re: GET requests should not alter data?

2008-10-15 Thread Malcolm Tredinnick
On Wed, 2008-10-15 at 13:20 +0530, Amit Upadhyay wrote: > [So far using non > db based session backend, and allowing delete for auth_messages from > "GET machines" and living with "a message appears more than once" is > what I am doing]. By the way, for something like sessions, the scaling

Re: GET requests should not alter data?

2008-10-15 Thread Amit Upadhyay
On Wed, Oct 15, 2008 at 1:20 PM, Amit Upadhyay <[EMAIL PROTECTED]> wrote: > Question: 1. is the expectation that GET request should only do SELECT > reasonable? 2. if 1, then should django enforce it? Clarification, enforce is ambiguous: Question2.1. django, core and contrib apps shipped with

GET requests should not alter data?

2008-10-15 Thread Amit Upadhyay
Usecase: for scaling a website(bottlenecked on database), one of the first thing to do after caching and other optimizations is to split requests to go to master/slave replicated database servers. One way of doing it is based on request.METHOD[1], GET requests going to slave, and POSTs going to

Re: Google maps subclass of GeoModelAdmin

2008-10-15 Thread Jacob Kaplan-Moss
On Wed, Oct 15, 2008 at 8:12 AM, Waylan Limberg <[EMAIL PROTECTED]> wrote: > I'm not really sure, nor am I the one to make such a decision, but I > wonder if perhaps something like this hasn't been included because of > issues with Google's licensing. That's exactly why: Google Maps aren't free

Re: Google maps subclass of GeoModelAdmin

2008-10-15 Thread Benjamin Wohlwend
Hi, > That's exactly why: Google Maps aren't free to use in > non-publicly-accessible areas. Like, say, an admin interface. > I'm not sure if this is really the case. The Google Maps API FAQ[1] says this about the topic: > As long your site is generally accessible to consumers without > charge,

Re: GET requests should not alter data?

2008-10-15 Thread Rajeev J Sebastian
On Wed, Oct 15, 2008 at 6:40 PM, Steve Holden <[EMAIL PROTECTED]> wrote: > While I can see the generic desirability of GET requests not making > database writes there are always going to be exceptions. Let's not > pursue this as a purist goal, but rather for the sound pragmatic reasons > that

readlines + InMemoryUploadedFile

2008-10-15 Thread bo
Hi Guys, Is there a reason why InMemoryUploadedFile does not proxy readlines as well from StringIO? seems like it should (especially if using PIL directly from the uploaded file) bo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the

Re: GET requests should not alter data?

2008-10-15 Thread bo
It seems that what you may want is something like http://softwaremaniacs.org/soft/mysql_replicated/ (its in Russian that i cannot read and one of the links has the source :) master slave DB engine (for Mysql) I modified it to force a master call for everything that was not a "SELECT" in the

Re: GET requests should not alter data?

2008-10-15 Thread Amit Upadhyay
On Wed, Oct 15, 2008 at 1:55 PM, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > By the way, for something like sessions, the scaling solution is not to > use server-side storage at all for the session data. Typically sessions > don't actually hold that much data and even in cases like, say, a >

Re: Google maps subclass of GeoModelAdmin

2008-10-15 Thread Waylan Limberg
I'm not really sure, nor am I the one to make such a decision, but I wonder if perhaps something like this hasn't been included because of issues with Google's licensing. Of course, not everyone is using GeoDjango in a commercial setting, so your code's still useful. Perhaps you could post it on

Re: Google maps subclass of GeoModelAdmin

2008-10-15 Thread Thamsanqa
I suppose I can log both a ticket and place it on djangosnippets.org. Thanks On Oct 15, 4:39 pm, "Benjamin Wohlwend" <[EMAIL PROTECTED]> wrote: > Hi, > > > That's exactly why: Google Maps aren't free to use in > > non-publicly-accessible areas. Like, say, an admin interface. > > I'm not sure if

Re: GET requests should not alter data?

2008-10-15 Thread Steve Holden
Amit Upadhyay wrote: > On Wed, Oct 15, 2008 at 5:17 PM, Ivan Sagalaev > <[EMAIL PROTECTED]> wrote: > >> Amit Upadhyay wrote: >> >>> This is not about specs or what is allowed, rather what is there in >>> actual django. And about implementation goals for django. It is >>> possible to have

Google maps subclass of GeoModelAdmin

2008-10-15 Thread Thamsanqa
Hi I see that only open street maps are supported by GeoDjango in django.contrib.gis.admin through the OSMGeoAdmin class which inherits from GeoModelAdmin. I have discovered that changing this to use Google Maps is a matter of modifying the template files in contrib/gis/ templates/gis/admin and

Re: GET requests should not alter data?

2008-10-15 Thread Luke Plant
On Wednesday 15 October 2008 10:12:35 Amit Upadhyay wrote: > My wish for django would be, either 1. a position that other than > the Session, there is no data changes by entire django if request > method is GET. or 2. a wiki/doc page explaining what all database > changes that can happen as part

Re: GET requests should not alter data?

2008-10-15 Thread Amit Upadhyay
On Wed, Oct 15, 2008 at 4:28 PM, Luke Plant <[EMAIL PROTECTED]> wrote: > It is not desirable to have Django try to enforce this, since GET > requests are allowed to have side effects, just not side effects that > "have the significance of taking an action other than retrieval" [1]. This is not

Re: GET requests should not alter data?

2008-10-15 Thread Ivan Sagalaev
Amit Upadhyay wrote: > This is not about specs or what is allowed, rather what is there in > actual django. And about implementation goals for django. It is > possible to have a django(core+contrib apps shipped with django) with > only SELECT queries in response for GET request. So far I have >

Re: GET requests should not alter data?

2008-10-15 Thread Amit Upadhyay
On Wed, Oct 15, 2008 at 5:17 PM, Ivan Sagalaev <[EMAIL PROTECTED]> wrote: > > Amit Upadhyay wrote: >> This is not about specs or what is allowed, rather what is there in >> actual django. And about implementation goals for django. It is >> possible to have a django(core+contrib apps shipped with

Re: GET requests should not alter data?

2008-10-15 Thread Malcolm Tredinnick
On Wed, 2008-10-15 at 13:20 +0530, Amit Upadhyay wrote: [...] > One way of > doing it is based on request.METHOD[1], GET requests going to slave, > and POSTs going to master. Be careful, though, since that can lead to problems. Every time you write to a master, it takes a finite amount of time

Re: GET requests should not alter data?

2008-10-15 Thread Ivan Sagalaev
bo wrote: > It seems that what you may want is something like > > http://softwaremaniacs.org/soft/mysql_replicated/ > > (its in Russian that i cannot read and one of the links has the > source :) It has a link saying "English" right on top of the page :-). It's

Customizing notification method for internal server errors

2008-10-15 Thread Jesse Young
The built-in behavior for django.core.handlers.base.handle_uncaught_exception calls mail_admins for each internal server error. So if a very high-traffic view has an internal server error, duplicate emails will be sent at a very high rate. This isn't usually desirable... We worked around this

Re: Customizing notification method for internal server errors

2008-10-15 Thread Jeremy Dunck
On Wed, Oct 15, 2008 at 3:58 PM, Jesse Young <[EMAIL PROTECTED]> wrote: ... > I was thinking it would be useful to add a setting like > EXCEPTION_NOTIFIER = 'path.to.custom.notifier' , where the default > would look something like this: > > def mail_exception_to_admins(request, exc_info): >

Custom submit buttons on admin form

2008-10-15 Thread Delta20
What's the cleanest way to customize the submit buttons that appear on an admin change_form? If there's a way to override submit_row on change_form, that would be the simplest approach, I think, but I'm very much a django beginner so I would appreciate some guidance. To provide some context,

Re: Proposal: user-friendly API for multi-database support

2008-10-15 Thread Joey Wilhelm
Hello all, I just wanted to toss in my own $0.02 for my particular use case and my experiences thus far. For all around ease, this is a copy of a comment I made on ticket #1142 yesterday: What is the current status on this issue? There doesn't appear to have been any visible movement in

why is field.related_query_name a method?

2008-10-15 Thread Jesse Young
One thing I noticed while running some performance profiling tests a while ago was that django.db.models.fields.related._get_related_query_name was being called approximately a zillion times, as was _curried from django.utils.functional. Although _get_related_query_name is very simple (return

Re: Custom submit buttons on admin form

2008-10-15 Thread James Bennett
This question belongs on the django-users list; in the future, please keep in mind that this list is for discussion of actually developing Django itself, while django-users is for discussion of how to use Django. -- "Bureaucrat Conrad, you are technically correct -- the best kind of correct."

Re: Customizing notification method for internal server errors

2008-10-15 Thread Jesse Young
I see there is a got_request_exception signal already... so one could effectively do the same thing by adding a signal handler and making settings.ADMINS the empty list so that mail_admins effectively becomes a no-op. Even so, it looks like mail_admins will open a SMTP connection to send an

Re: Google maps subclass of GeoModelAdmin

2008-10-15 Thread Justin Bronn
> I suppose I can log both a ticket and place it on djangosnippets.org. > Thanks This has come up a few times in #geodjango, and I've already written an example on how to use Google's base layer in the admin. I distilled it to a few snippets: http://www.djangosnippets.org/snippets/1144/ It's

Re: Custom submit buttons on admin form

2008-10-15 Thread Delta20
Oops... my apologies; this is what happens when I open two different forums in separate tabs! --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to

Re: Customizing notification method for internal server errors

2008-10-15 Thread Jeremy Dunck
On Wed, Oct 15, 2008 at 6:26 PM, Jesse Young <[EMAIL PROTECTED]> wrote: > > I see there is a got_request_exception signal already... so one could > effectively do the same thing by adding a signal handler and making > settings.ADMINS the empty list so that mail_admins effectively becomes > a

About FireSymfony and Django

2008-10-15 Thread Alvaro Videla
Hi, As you may guess, I'm a symfony develper and the creator of FireSymfony. I read here: http://oebfare.com/logger/django-dev/2008/10/1/1/ that there could be some interest in creating a FireDjango or something similar. If that is the case, just contact me because I think it could be easy to

Re: Customizing notification method for internal server errors

2008-10-15 Thread Malcolm Tredinnick
On Wed, 2008-10-15 at 13:58 -0700, Jesse Young wrote: > The built-in behavior for > django.core.handlers.base.handle_uncaught_exception calls mail_admins > for each internal server error. > > So if a very high-traffic view has an internal server error, duplicate > emails will be sent at a very

Re: Customizing notification method for internal server errors

2008-10-15 Thread Jesse Young
Hi Malcolm, Thanks for explaining the rationale behind this. It'd certainly be possible to do what we want by overriding handle_uncaught_exception in a ModPythonHandler subclass. This method has a higher barrier to entry than I'd like, though. For one, this kind of customization requires

Re: About FireSymfony and Django

2008-10-15 Thread Rajeev J Sebastian
Hi Alvaro, Actually, I've taken a couple of steps in this direction in some modifications I've done to Firebug. One thing I did was to POST any changed CSS (e.g., added rules, changed rules and disabled rules) back to Django. This has helped me considerably in developing web sites. I'd like to

Re: About FireSymfony and Django

2008-10-15 Thread Rajeev J Sebastian
Umm ... Sorry to post that email to the public django-devel list :) I realise it is not for django usage, but core django development. It happened by mistake. Regards Rajeev J Sebastian. --~--~-~--~~~---~--~~ You received this message because you are subscribed

Re: About FireSymfony and Django

2008-10-15 Thread alvaro
Hi Rajeev, Any help that I can provide, just ask. I think with a JSON object containing the debug data with some structure expected by FireSymfony, it should be easy to port it to Django or any other framework. Regards, Alvaro On Oct 16, 2008, at 10:27 AM, Rajeev J Sebastian wrote: > >

Re: Customizing notification method for internal server errors

2008-10-15 Thread oggie rob
Did you try subclassing list (& overriding __iter__) for the ADMINS object? -rob On Oct 15, 1:58 pm, Jesse Young <[EMAIL PROTECTED]> wrote: > The built-in behavior for > django.core.handlers.base.handle_uncaught_exception calls mail_admins > for each internal server error. > > So if a very

Re: Customizing notification method for internal server errors

2008-10-15 Thread Jesse Young
Is your suggestion that, since mail_admins happens to be the only place in Django that uses settings.ADMINS, I could do something like: class AdminsObject(list): def __iter__(self): // do some custom notification // manually write the friendly 500 error page to the output stream