On 10/25/2017 01:34 PM, Sean Paul wrote:
On Wed, Oct 25, 2017 at 11:51:01AM +0800, Nickey Yang wrote:
This patch add dual mipi channel support:
1.add definition of dsi1 register and grf operation.
2.dsi0 and dsi1 will work in master and slave mode
when driving dual mipi panel.
Signed-off-by:
On 10/25/2017 09:21 AM, Nickey Yang wrote:
Configure dsi slave channel when driving a panel
which needs 2 DSI links.
Signed-off-by: Nickey Yang
---
.../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++
1 file changed, 2 insertions(+)
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #22 from Shih-Yuan Lee ---
(In reply to Mike Lothian from comment #19)
> You have to blacklist radeon to use amdgpu as both modules try and claim the
> device
After I blacklist radeon, there is no AMD
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #21 from Shih-Yuan Lee ---
Created attachment 135049
--> https://bugs.freedesktop.org/attachment.cgi?id=135049=edit
blacklist radeon Xorg.0.log
--
You are receiving this mail because:
You are the assignee
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #20 from Shih-Yuan Lee ---
Created attachment 135048
--> https://bugs.freedesktop.org/attachment.cgi?id=135048=edit
blacklist radeon dmesg
--
You are receiving this mail because:
You are the assignee for
Hi,
On 10/26/2017 06:39 AM, Brian Norris wrote:
On Wed, Oct 25, 2017 at 03:57:19AM -0400, Sean Paul wrote:
Archit asked a question about moving to
dw-mipi-dsi
That question made me think though: this approach seems backwards. It
seems like someone did copy/paste/fork, and then we're asking
Hi Dave,
Just a few fixes for 4.15.
The following changes since commit 282dc8322a95b5c6a246fc781d89e5930821d486:
Merge tag 'drm-intel-next-2017-10-12' of
git://anongit.freedesktop.org/drm/drm-intel into drm-next (2017-10-20 10:56:10
+1000)
are available in the git repository at:
Hi Chris,
Sorry I missed adding you in to list while sending the vblank refcount
patch. Hope you saw that.
On 25-Oct-2017 9:55 PM, "PrasannaKumar Muralidharan" <
prasannatsmku...@gmail.com> wrote:
Warn when refcount > 0 in drm_vblank_cleanup.
Signed-off-by: PrasannaKumar Muralidharan
Hi Dave,
Improving Exynos DRM HDMI and Mixer drivers and also adding
HDMI audio support.
Please kindly let me know if there is any problem.
Ps. we are reviewing IPP v2 driver[1] which controls post processor devices
such as FIMC, GScaler and Rotator of Exynos SoC. So I plan
https://bugs.freedesktop.org/show_bug.cgi?id=103130
Adam changed:
What|Removed |Added
Resolution|--- |WORKSFORME
On Wed, Oct 25, 2017 at 03:57:19AM -0400, Sean Paul wrote:
> Archit asked a question about moving to
> dw-mipi-dsi
That question made me think though: this approach seems backwards. It
seems like someone did copy/paste/fork, and then we're asking the
authors of the original driver to un-fork? It
Hi Dave,
Here goes
drm-intel-fixes-2017-10-25:
only 1 fix for stable:
- fix perf enable/disable ioctls for 32bits (lionel)
The following changes since commit bb176f67090ca54869fc1262c913aa69d2ede070:
Linux 4.14-rc6 (2017-10-23 06:49:47 -0400)
are available in the git repository at:
From: Deepak Sharma
Modify vgem_init to take platform dev as parent in drm_dev_init.
This will make drm device available at "/sys/devices/platform/vgem"
in x86 chromebook.
Signed-off-by: Deepak Sharma
---
drivers/gpu/drm/vgem/vgem_drv.c | 15
On Tue, Oct 24, 2017 at 5:44 AM, Dan Carpenter wrote:
> We accidentally inverted an if statement and turned amd_powerplay_reset()
> into a no-op.
>
> Fixes: ae97988fc89e ("drm/amd/powerplay: tidy up ret checks in
> amd_powerplay.c (v3)")
> Signed-off-by: Dan Carpenter
https://bugs.freedesktop.org/show_bug.cgi?id=103370
--- Comment #19 from Mike Lothian ---
You have to blacklist radeon to use amdgpu as both modules try and claim the
device
--
You are receiving this mail because:
You are the assignee for the
Daniel Stone writes:
> I still think putting these behind a client cap is a good idea:
> https://lists.freedesktop.org/archives/dri-devel/2017-October/155616.html
Assuming that everyone eventually catches up, this should be a
short-term issue. So, all we have to do is
On 25 October 2017 at 21:27, Daniel Stone wrote:
> Hi,
>
> On 19 October 2017 at 17:27, Keith Packard wrote:
>> Daniel Stone writes:
>>> Why not add a client cap which hides 'non-standard' displays
>>> completely from non-aware
On 26 October 2017 at 05:24, Dave Airlie wrote:
> On 25 October 2017 at 21:15, Daniel Stone wrote:
>> Hi,
>>
>> On 25 October 2017 at 07:30, Dave Airlie wrote:
>>> This adds the infrastructure needed to quirk displays
>>> using edid
On 25 October 2017 at 21:15, Daniel Stone wrote:
> Hi,
>
> On 25 October 2017 at 07:30, Dave Airlie wrote:
>> This adds the infrastructure needed to quirk displays
>> using edid and to mark them as non-desktop to denote
>> that userspace shouldn't display
https://bugs.freedesktop.org/show_bug.cgi?id=103408
--- Comment #2 from Andy Furniss ---
I can reproduce this on R9 285 with a different setup.
Made a 60fps 1920x1080 from the vid here, lengthened by repeating 4x + added
time counter, removed audio.
Monitor is 60Hz
Warn when refcount > 0 in drm_vblank_cleanup.
Signed-off-by: PrasannaKumar Muralidharan
---
Changes in v3:
* Dropped i915 patch that is used for testing this.
No changes in v2.
drivers/gpu/drm/drm_vblank.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On Wed, Oct 25, 2017 at 05:22:25PM +0200, Noralf Trønnes wrote:
>
> Den 25.10.2017 15.55, skrev Ville Syrjälä:
> > On Wed, Oct 25, 2017 at 02:05:02PM +0200, Noralf Trønnes wrote:
> >> Add debugfs file that dumps info about the framebuffers and its planes.
> >> Also dump info about any connected
Den 25.10.2017 15.55, skrev Ville Syrjälä:
On Wed, Oct 25, 2017 at 02:05:02PM +0200, Noralf Trønnes wrote:
Add debugfs file that dumps info about the framebuffers and its planes.
Also dump info about any connected gem object(s).
Signed-off-by: Noralf Trønnes
---
Changes
Hi All,
On 24 October 2017 at 22:18, PrasannaKumar Muralidharan
wrote:
> In i915 driver unload drm_vblank_get is added to test whether
> drm_vblank_cleanup refcount validation patch is working.
>
> Signed-off-by: PrasannaKumar Muralidharan
https://bugs.freedesktop.org/show_bug.cgi?id=91221
--- Comment #7 from Chí-Thanh Christopher Nguyễn ---
Thanks for the suggestion. However,
mpv -vo opengl --hwdec=vdpau
triggers the problem in the same way as -vo vdpau
--
You are receiving this mail because:
You are the
On Wed, 25 Oct 2017, Kees Cook wrote:
> On Wed, Oct 25, 2017 at 4:16 PM, Chris Wilson
> wrote:
>> Quoting Kees Cook (2017-10-25 15:05:13)
>>> On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson
>>> wrote:
>>> > Quoting Chris
Quoting Kees Cook (2017-10-25 15:05:13)
> On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson
> wrote:
> > Quoting Chris Wilson (2017-10-25 11:24:19)
> >> Quoting Chris Wilson (2017-10-24 17:17:09)
> >> > Quoting Kees Cook (2017-10-24 16:13:44)
> >> > > In preparation for
On Wed, Oct 25, 2017 at 02:05:02PM +0200, Noralf Trønnes wrote:
> Add debugfs file that dumps info about the framebuffers and its planes.
> Also dump info about any connected gem object(s).
>
> Signed-off-by: Noralf Trønnes
> ---
>
> Changes since version 1:
> - Remove const
Hi Dave,
Just two small patches for suspend/resume regressions.
The following changes since commit 2cb3a34abd035756f9ba3cde12f44f4b3e4c234b:
Merge tag 'drm-intel-fixes-2017-10-18-1' of
git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2017-10-19 15:00:47
+1000)
are available in
Quoting Chris Wilson (2017-10-25 11:24:19)
> Quoting Chris Wilson (2017-10-24 17:17:09)
> > Quoting Kees Cook (2017-10-24 16:13:44)
> > > In preparation for unconditionally passing the struct timer_list pointer
> > > to
> > > all timer callbacks, switch to using the new timer_setup() and
> > >
Add debugfs file that dumps info about the framebuffers and its planes.
Also dump info about any connected gem object(s).
Signed-off-by: Noralf Trønnes
---
Changes since version 1:
- Remove const in drm_gem_print() argument (kbuild test robot)
- Print framebuffer modifiers
Hi Alex, Michel & Andrey,
[PATCH] drm/amd/display: assign fb_location only if bo is pinned
[PATCH 2/2] drm/amd/display: cleanup addReq and fix fb_location
should be dropped and instead:
[PATCH] drm/amd/display: fix high part address in dm_plane_helper_prepare_fb()
should be reviewed .
With
Am 24.10.2017 um 21:44 schrieb Bjorn Helgaas:
On Wed, Oct 18, 2017 at 03:58:16PM +0200, Christian König wrote:
Hi everyone,
This is the ninth and hopefully last incarnation of this set of patches. It
enables device drivers to resize and most likely also relocate the PCI BAR of
devices they
Hi,
On 19 October 2017 at 17:27, Keith Packard wrote:
> Daniel Stone writes:
>> Why not add a client cap which hides 'non-standard' displays
>> completely from non-aware clients? That way you can keep the connected
>> status as is, and clients either
Hi,
On 25 October 2017 at 07:30, Dave Airlie wrote:
> This adds the infrastructure needed to quirk displays
> using edid and to mark them as non-desktop to denote
> that userspace shouldn't display a standard desktop on them.
>
> A non-desktop display is one which doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=103365
Chris Wilson changed:
What|Removed |Added
Resolution|--- |FIXED
Quoting Chris Wilson (2017-10-24 17:17:09)
> Quoting Kees Cook (2017-10-24 16:13:44)
> > In preparation for unconditionally passing the struct timer_list pointer to
> > all timer callbacks, switch to using the new timer_setup() and from_timer()
> > to pass the timer pointer explicitly.
> >
> >
On 25/10/17 12:05 PM, S, Shirish wrote:
> Hi Alex, Michel & Andrey,
>
> [PATCH] drm/amd/display: assign fb_location only if bo is pinned
> [PATCH 2/2] drm/amd/display: cleanup addReq and fix fb_location
>
> should be dropped and instead:
Since you pushed the latter to amd-staging-drm-next,
Hi,
On Tue, 17 Oct 2017 14:45:04 +0200 Thierry Reding wrote:
> On Tue, Oct 17, 2017 at 02:25:07PM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > On Tue, 17 Oct 2017 14:14:22 +0200 Thierry Reding wrote:
> > > On Wed, Oct 11, 2017 at 01:23:36PM +0200, Lothar Waßmann wrote:
> > > > The Ka-Ro
> These long email threads are a waste of time
They occur for different topics.
> when we already answered your questions completely
There were some attempts for specific details.
> and over and over.
I hope that further useful adjustments can be achieved for
involved information sources.
https://bugs.freedesktop.org/show_bug.cgi?id=103443
--- Comment #1 from Marta Löfstedt ---
Instead of changing this from pass to fail, why not also fix the whole issue of
no modes available in igt.
--
You are receiving this mail because:
You are the assignee for the
On Wed, Oct 25, 2017 at 09:39:39AM +0200, SF Markus Elfring wrote:
> >> Would you like to support Unicode characters there?
> >
> > Multiple people have answered this question already and I have answered
> > it multiple times.
>
> I found the corresponding feedback not sufficient so far to reach
On 25/10/17 07:18 AM, S, Shirish wrote:
>
> Andrey,
> Till now the get_fb_info() never calculated fb_location(as addrReq was
> always false), but since now its required to program the high part of
> the address structure,
> can you move it back into the commit scope and ensure that fb_location
>
On Wed, Oct 25, 2017 at 11:51:01AM +0800, Nickey Yang wrote:
> This patch add dual mipi channel support:
> 1.add definition of dsi1 register and grf operation.
> 2.dsi0 and dsi1 will work in master and slave mode
> when driving dual mipi panel.
>
> Signed-off-by: Nickey Yang
https://bugs.freedesktop.org/show_bug.cgi?id=91221
--- Comment #6 from Roman Elshin ---
You may try to use vdpau decoding with opengl video out (if it not this case),
for me it much more stable than using vdpau decoding with vdpau video out (at
least with rv730 agp card).
On Wed, Oct 25, 2017 at 11:51:00AM +0800, Nickey Yang wrote:
> This patch correct Feedback divider setting:
> 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN
> 2、Due to the use of a "by 2 pre-scaler," the range of the
> feedback multiplication Feedback divider is limited to even
> division
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
On Wed, Oct 25, 2017 at 11:50:59AM +0800, Nickey Yang wrote:
> As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0>
> should depend on frequency,so fix it.
>
> Reviewed-by: Sean Paul
> Reviewed-by: Matthias Kaehlcke
> Signed-off-by: Nickey Yang
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly. One tracking pointer was added, and
one initialization was cleaned up.
Cc: Bartlomiej Zolnierkiewicz
On 10/24/17 9:01 AM, SF Markus Elfring wrote:
>>> Do you prefer to delegate the proposed software refactoring
>>> only to a corresponding optimiser?
>>
>> yes.
>
> Will any applications around the semantic patch language
> (Coccinelle software) fit also in the preferred tool category?
What do
Hello there,
Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably
up to date.
I did a further check on github.com/torvalds/linux and the code
looks wrong there, too.
So I don't see the fix you mentioned in either of the places I looked.
Regards
David Binderman
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
Hi Peter,
On 2017/10/24 1:34, Peter Griffin wrote:
Hi Xinliang,
On 28 August 2017 at 10:27, Xinliang Liu > wrote:
Hi Daniel,
On 28 August 2017 at 16:51, Daniel Vetter > wrote:
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Patrik Jakobsson
Cc: David Airlie
Cc:
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
Hi,
Just chipping in to leave a couple of additional notes.
As other have said before me, I also think the organization was very
good.
Things mentioned before:
* Tables layout: kind of agree it was not great for following the
talks but they were also making it easier to talk with other
Please don't top post, write shorter lines, and add the odd blank line.
Big blocks of text are hard to read quickly.
> From: Petrosyan, Ludwig [mailto:ludwig.petros...@desy.de]
> Yes I agree it has to be started with the write transaction, according of
> PCIe standard all write
> transaction are
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Eric Anholt
Cc: David Airlie
Cc: dri-devel@lists.freedesktop.org
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
On Wed, Oct 18, 2017 at 03:58:16PM +0200, Christian König wrote:
> Hi everyone,
>
> This is the ninth and hopefully last incarnation of this set of patches. It
> enables device drivers to resize and most likely also relocate the PCI BAR of
> devices they manage to allow the CPU to access all of
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Jani Nikula
Cc: Joonas Lahtinen
Cc:
On Fri, 2017-06-02 at 12:38:47 UTC, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven
> Acked-by: Rob Herring
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/3d2d4339cc326c427638daa67e264d
cheers
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
For drivers which could have multiple instances, it is necessary to
differentiate between which is which in the logs. Since
DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to
make this differentiation. We now have DRM_DEV_* variants of the drm
print macros, so we can start to
On Wed, Oct 25, 2017 at 11:50:58AM +0800, Nickey Yang wrote:
> Replace the hardcoded register address numerical values with macros to
> clarify the code.
>
> Signed-off-by: Nickey Yang
Reviewed-by: Sean Paul
> ---
>
https://bugs.freedesktop.org/show_bug.cgi?id=103401
Sergey Kondakov changed:
What|Removed |Added
Resolution|--- |WORKSFORME
https://bugs.freedesktop.org/show_bug.cgi?id=103443
Petri Latvala changed:
What|Removed |Added
Component|DRM/Intel |IGT
>> Would you like to support Unicode characters there?
>
> Multiple people have answered this question already and I have answered
> it multiple times.
I found the corresponding feedback not sufficient so far to reach
a final consensus.
Will this topic evolve any further?
Regards,
Markus
On Tue, Oct 24, 2017 at 04:56:59PM +0100, Daniel Thompson wrote:
> On 24/10/17 16:38, Sean Paul wrote:
> > On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote:
> > > Rename tinydrm_of_find_backlight to of_find_backlight and move
> > > it to linux/backlight.c so that it can be used
On Wed, Oct 25, 2017 at 08:44:38AM +0200, SF Markus Elfring wrote:
> >> The script “checkpatch.pl” pointed information out like the following.
> >>
> >> Comparison to NULL could be written !…
> >>
> >> Thus fix the affected source code places.
> >>
> >
> > This one is fine
>
> This kind of
On Wed, Oct 25, 2017 at 10:21:14AM +0800, Chih-Wei Huang wrote:
> 2017-10-25 8:06 GMT+08:00 Rob Herring :
> > Linking to libraries will add necessary include paths, so we don't need to
> > list them explicitly.
> >
> > Still need libsync for sw_sync.h until this dependency is
Am 25.10.2017 um 08:42 schrieb Chunming Zhou:
On 2017年10月24日 21:55, Christian König wrote:
From: Christian König
The amdgpu issue to also need signaled fences in the reservation objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet
>> The script “checkpatch.pl” pointed information out like the following.
>>
>> Comparison to NULL could be written !…
>>
>> Thus fix the affected source code places.
>>
>
> This one is fine
This kind of feedback is nice.
> except for the commit message.
Would you like to support Unicode
On 2017年10月24日 21:55, Christian König wrote:
From: Christian König
The amdgpu issue to also need signaled fences in the reservation objects
should be fixed by now.
Optimize the list by keeping only the not signaled yet fences around.
Signed-off-by: Christian König
> But anyways I guess other people sometimes disagree with me.
Am I one of them? ;-)
> Unwinding is for when you allocate five things in a row.
This is a general issue.
I find that it is also needed in this function as usual.
> You have to undo four if the last allocation fails.
Concrete
From: Dave Airlie
We don't want fbcon to get used on non-desktop dislays,
don't pass them as enabled connectors to the fb helper setup.
This prevents my HMD from getting disorted fbcon, and from
affecting other displays console.
Signed-off-by: Dave Airlie
From: Dave Airlie
This uses the EDID info from my HTC Vive to mark it as
non-desktop.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/drm_edid.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c
From: Dave Airlie
This adds the infrastructure needed to quirk displays
using edid and to mark them as non-desktop to denote
that userspace shouldn't display a standard desktop on them.
A non-desktop display is one which doesn't work like
a normal rectangular monitor or
On Tue, Oct 24, 2017 at 06:02:30PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 24 Oct 2017 17:47:37 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The script “checkpatch.pl” pointed
This is a subtle thing but my preference on this type of thing is the
way the original code is written. I'm still slightly annoyed that
someone once made me rewrite a patch using the new style... But anyways
I guess other people sometimes disagree with me.
Unwinding is for when you allocate
88 matches
Mail list logo