Re: [PATCH v4 05/11] drm/atomic: Use drm_framebuffer_print_info()

Hi Noralf, Thank you for the patch. On Monday, 30 October 2017 18:29:39 EET Noralf Trønnes wrote: > Use drm_framebuffer_print_info() to print framebuffer info in > drm_atomic_plane_print_state(). This will give optional GEM info as well. > > Reviewed-by: Daniel Vetter >

Re: [PATCH v4 04/11] drm/framebuffer: Add framebuffer debugfs file

Hi Noralf, Thank you for the patch. On Monday, 30 October 2017 18:29:38 EET Noralf Trønnes wrote: > Add debugfs file that dumps info about the framebuffers and its planes. > Also dump info about any connected gem object(s). > > Reviewed-by: Daniel Vetter >

Re: [PATCH v4 03/11] drm/print: Add drm_printf_indent()

Hi Noralf, Thank you for the patch. On Monday, 30 October 2017 18:29:37 EET Noralf Trønnes wrote: > Add drm_printf_indent() that adds tab indentation according to argument. > Indentation overflow is marked with an X. I wonder if this kind of thing would be useful to add to printk somehow.

Re: [PATCH v4 02/11] drm/framebuffer: drm_framebuffer_read_refcount() constify argument

Hi Noralf, Thank you for the patch. On Monday, 30 October 2017 18:29:36 EET Noralf Trønnes wrote: > Constify argument so functions calling into this take a const argument. > > Reviewed-by: Ville Syrjälä > Signed-off-by: Noralf Trønnes

Re: [PATCH v4 01/11] drm/vma-manager: drm_vma_node_start() constify argument

Hi Noralf, Thank you for the patch. On Monday, 30 October 2017 18:29:35 EET Noralf Trønnes wrote: > Constify argument so functions calling into this take a const argument. > > Reviewed-by: Ville Syrjälä > Signed-off-by: Noralf Trønnes

[Bug 101475] Max Core Profile for OpenGL showing 0.0

https://bugs.freedesktop.org/show_bug.cgi?id=101475 --- Comment #11 from vinf...@gmail.com --- Hello, sorry to reopen this thread. I am still having the same problem i.e. the max core profile is showing at 0.0. glxinfo | grep version returns: server glx version string: 1.4

[Bug 101475] Max Core Profile for OpenGL showing 0.0

https://bugs.freedesktop.org/show_bug.cgi?id=101475 --- Comment #10 from vinf...@gmail.com --- Hello, sorry to reopen this thread. I am still having the same problem i.e. the max core profile is showing at 0.0. glxinfo -- You are receiving this mail because: You are the assignee for the

[pull] amdgpu drm-fixes-4.14

Hi Dave, Just two small patches for stable to fix the driver failing to load on polaris cards with harvested VCE or UVD blocks. The following changes since commit d3daa2c7865cbfa830651b11c8ad1df23465b46e: drm/amd/amdgpu: Remove workaround check for UVD6 on APUs (2017-10-25 09:32:14 -0400)

Re: [PATCH] drm/drm_mm.h: Fix the name of the referenced function in comment

On Wed, Nov 1, 2017 at 10:04 AM, Liviu Dudau wrote: > drm_mm_insert_node_generic() is a simplified version of > drm_mm_insert_node_in_range(), update comment to reflect correct > function name. > > Signed-off-by: Liviu Dudau Reviewed-by: Alex Deucher

Re: [PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment()

On Wed, Nov 1, 2017 at 10:06 AM, Liviu Dudau wrote: > Mappings need to be unmapped by calling dma_buf_unmap_attachment() and > not by calling again dma_buf_map_attachment(). Also fix some spelling > mistakes. > > Signed-off-by: Liviu Dudau Reviewed-by:

Re: [PATCH 0/7] drm/edid and drivers: ELD refactoring

On Wed, Nov 1, 2017 at 10:20 AM, Jani Nikula wrote: > We were recently bitten by drm_edid_to_eld() clearing the connector > type, and us failing to set it back for DP. Here's a few ELD related > patches to try to unify ELD handling and make it a bit simpler for > drivers to

Re: [PATCH v4 1/4] devicetree/bindings: display: Add doucument for RGB panels

On Wed, Nov 01, 2017 at 03:52:38PM +0800, Sandy Huang wrote: > Describe the panel property rgb-mode for parallel and serial > RGB output interface, include the connection relations for each > mode. > > Signed-off-by: Sandy Huang > --- > Changes: >

[PULL] drm-intel-fixes

Hi Dave, Here goes drm-intel-fixes-2017-11-01. Fixes for Stable: - Fix KBL Blank Screen (Jani) - Fix FIFO Underrun on SNB (Maarten) Other fixes: - Fix GPU Hang on i915gm (Chris) - Fix gem_tiled_pread_pwrite IGT case (Chris) - Cancel modeset retry work during modeset clean-up (Manasi) Thanks,

[Bug 103519] wayland egl apps crash on start with mesa 17.2

https://bugs.freedesktop.org/show_bug.cgi?id=103519 --- Comment #5 from Apostolos B. --- Dereks patch was tested on 17.2.4 and 17.3.0-rc2 and solves the problem. EFL apps and weston-simple-egl work fine. Merge and close. -- You are receiving this mail because: You are the

Re: [PATCH v2 01/10] dt-bindings: fix the binding of Allwinner DE2 CCU of A83T and H3

On Fri, Oct 27, 2017 at 11:06:49PM +0800, Icenowy Zheng wrote: > The DE2 CCU is different on A83T and H3 -- the parent of the clocks on > A83T is PLL_DE but on H3 it's the DE module clock. This is not noticed > when I develop the DE2 CCU driver. > > Fix the binding by using different compatibles

Re: [PATCH v2 08/10] dt-bindings: add binding for A64 DE2 CCU SRAM

On Fri, Oct 27, 2017 at 11:06:56PM +0800, Icenowy Zheng wrote: > A64's Display Engine 2.0 needs a section of SRAM (SRAM C) to be claimed, > otherwise the whole DE2 memory zone cannot be accessed (kept to all 0). > > Add binding for this, in order to make the DE2 CCU able to claim the > SRAM and

[PATCH v2 5/5] drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c

From: Ville Syrjälä drm_plane_helper_check_update() isn't a transitional helper, so let's rename it to drm_atomic_helper_check_plane_state() and move it into drm_atomic_helper.c. v2: Fix the WARNs about plane_state->crtc matching crtc_state->crtc Cc: Daniel

[PATCH v2 4/5] drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()

From: Ville Syrjälä drm_plane_helper_check_state() is supposed to do things the atomic way, so it should not be inspecting crtc->enabled. Rather we should be looking at crtc_state->enable. We have a slight complication due to drm_plane_helper_check_update()

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

https://bugs.freedesktop.org/show_bug.cgi?id=103486 --- Comment #11 from Andy Furniss --- Patch is good for me as well, thanks. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

On Tue, Oct 31, 2017 at 12:37:43PM +0800, JeffyChen wrote: > Hi Heiko, > > On 10/31/2017 07:01 AM, Heiko Stuebner wrote: > > As I was just looking at the edp dts change in patch1 again, does this > > series also contain a fix for the issue below [0] ? > > > > I'm still seeing this on 4.14-rc6

[pull] drm/msm: msm-next for 4.15 (take 2)

Hi Dave, Updated pull request, which adds the patch I lost from Arnd to correct a warning on armv7. Original pull req description: Updates for 4.15.. highlights include: + preemption support for a5xx[1][2] + display fixes for 8x96 (snapdragon 820) including fixes for 4k scanout (hwpipe

[PATCH] drm: Print the fb dimensions when the src coord check fails

From: Ville Syrjälä When debugging bad plane source coordinates it helps to have an idea of what the framebuffer dimensions are. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic.c | 5 +++--

[PATCH 5/5] drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c

From: Ville Syrjälä drm_plane_helper_check_update() isn't a transitional helper, so let's rename it to drm_atomic_helper_check_plane_state() and move it into drm_atomic_helper.c. Cc: Daniel Vetter Suggested-by: Daniel Vetter

[PATCH 4/5] drm: Check crtc_state->enable rather than crtc->enabled in drm_plane_helper_check_state()

From: Ville Syrjälä drm_plane_helper_check_state() is supposed to do things the atomic way, so it should not be inspecting crtc->enabled. Rather we should be looking at crtc_state->enable. We have a slight complication due to drm_plane_helper_check_update()

[PATCH 3/5] drm/vmwgfx: Try to fix plane clipping

From: Ville Syrjälä Try to fix the code to actually clip the plane to the crtc bounds instead of the user provided crtc coordinates (which would be a no-op since those are exactly the coordinates before clipping). Cc: VMware Graphics

[PATCH 1/5] drm/vmwgfx: Remove bogus crtc coords vs fb size check

From: Ville Syrjälä Throw away the bugs crtc coords vs. fb size check. Crtc coords don't define the viewport inside the fb, that's a job for the src coords, which have been checked by the core already. Cc: VMware Graphics Cc:

[PATCH 2/5] drm/vmwgfx: Use drm_plane_helper_check_state()

From: Ville Syrjälä Atomic drivers have no reason to use drm_plane_helper_check_update() instead of drm_plane_helper_check_state(). So let's switch over. Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas

[PATCH 0/5] drm: drm_plane_helper_check_state() related stuff

From: Ville Syrjälä While trawling the tree I spotted some issues with the way vmwgfx uses drm_plane_helper_check_state(). Here's my attempt at fixing it. Do note that I haven't actually tested the resulting code at all, but it does build at least. And while

Re: [PATCH hwc] drm_hwcomposer: Add HDMI connector as a valid type

Hi Rob, Pushed to master. Rob. On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote: > From: Robert Foss > > Accept DRM_MODE_CONNECTOR_HDMIA connector type. > > Look for primary DrmConnector amongst external connectors > after looking for primary amongst internal

Re: [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0

Hi Rob, On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote: > On Wed, Nov 1, 2017 at 11:37 AM, Rob Herring wrote: > > If the rotation property is supported for a plane, then the > > rotation > > value must be non-zero. For the case of 0 degree rotation, > > DRM_MODE_ROTATE_0

Re: [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0

On Wed, Nov 1, 2017 at 11:37 AM, Rob Herring wrote: > If the rotation property is supported for a plane, then the rotation > value must be non-zero. For the case of 0 degree rotation, > DRM_MODE_ROTATE_0 needs to be set. > > Signed-off-by: Rob Herring > --- >

[PATCH hwc] drm_hwcomposer: Add HDMI connector as a valid type

From: Robert Foss Accept DRM_MODE_CONNECTOR_HDMIA connector type. Look for primary DrmConnector amongst external connectors after looking for primary amongst internal ones first. Signed-off-by: Robert Foss Signed-off-by: Rob Herring

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

On Wed, Nov 1, 2017 at 1:00 PM, Eric Anholt wrote: > Sean Paul writes: > >> On Wed, Nov 1, 2017 at 7:12 AM, Gustavo Padovan wrote: >>> 2017-10-31 Sean Paul : >>> On Tue, Oct 31, 2017 at 1:31 PM, Daniel

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

Op 01-11-17 om 18:00 schreef Ville Syrjälä: > On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote: >> Op 01-11-17 om 16:29 schreef Ville Syrjälä: >>> On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst wrote: This introduces a slight behavioral change to rmfb. Instead of

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

https://bugs.freedesktop.org/show_bug.cgi?id=103486 Bhawan Lakha changed: What|Removed |Added Attachment #135202|0 |1 is

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

https://bugs.freedesktop.org/show_bug.cgi?id=103486 --- Comment #9 from Michel Dänzer --- (In reply to Bhawan Lakha from comment #8) > Created attachment 135202 [details] [review] > Patch to fix vblank_mode not working properly Tested-by: Michel Dänzer

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

https://bugs.freedesktop.org/show_bug.cgi?id=103486 Bhawan Lakha changed: What|Removed |Added CC|

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

On Wed, Nov 01, 2017 at 04:55:06PM +0100, Maarten Lankhorst wrote: > Op 01-11-17 om 16:29 schreef Ville Syrjälä: > > On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst wrote: > >> This introduces a slight behavioral change to rmfb. Instead of > >> disabling a crtc when the primary plane

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

Sean Paul writes: > On Wed, Nov 1, 2017 at 7:12 AM, Gustavo Padovan wrote: >> 2017-10-31 Sean Paul : >> >>> On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: >>> > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul

Re: [PATCH 6/7] drm/drivers: drop redundant drm_edid_to_eld() calls

Jani Nikula writes: > drm_add_edid_modes() now fills in the ELD automatically, so the calls to > drm_edid_to_eld() are redundant. Remove them. > > All the other places are obvious, but nv50 has detached > drm_edid_to_eld() from the drm_add_edid_modes() call. Nice! For

Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

Boris Brezillon writes: > vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields > and should be printed with a %zd specifier. > > Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") > Signed-off-by: Boris Brezillon

[PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0

If the rotation property is supported for a plane, then the rotation value must be non-zero. For the case of 0 degree rotation, DRM_MODE_ROTATE_0 needs to be set. Signed-off-by: Rob Herring --- drmdisplaycompositor.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

RE: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

> -Original Message- > From: dim-tools [mailto:dim-tools-boun...@lists.freedesktop.org] On Behalf > Of Sean Paul > Sent: Wednesday, November 01, 2017 8:52 AM > To: Gustavo Padovan > Cc: Daniel Vetter; Intel Graphics Development; dim- > to...@lists.freedesktop.org; dri-devel; Daniel Vetter

[PATCH] drm/ttm: Always and only destroy bo->ttm_resv in ttm_bo_release_list

From: Michel Dänzer Fixes a use-after-free due to a race condition in ttm_bo_cleanup_refs_and_unlock, which allows one task to reserve a BO and destroy its ttm_resv while another task is waiting for it to signal in reservation_object_wait_timeout_rcu. Fixes: 0d2bd2ae045d

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

Hi Daniel, On 1 November 2017 at 14:23, Daniel Vetter wrote: > On Wed, Nov 01, 2017 at 09:48:28AM +0530, PrasannaKumar Muralidharan wrote: >> Hi Daniel, >> >> On 31 October 2017 at 21:57, Daniel Vetter wrote: >> > On Tue, Oct 31, 2017 at 08:37:21PM +0530,

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

Op 01-11-17 om 16:29 schreef Ville Syrjälä: > On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst wrote: >> This introduces a slight behavioral change to rmfb. Instead of >> disabling a crtc when the primary plane is disabled, we try to >> preserve it. >> >> Apart from old versions of the

[drm-intel:for-linux-next 3/4] drivers/gpu/drm/i915/intel_engine_cs.c:1620:30: error: 'dev_priv' undeclared

tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: 3265124a2d3744d789ede58452ab6f8a9b454be8 commit: 680273879d125d644831b8de42c66576e6290378 [3/4] drm/i915: Move parking-while-active warning to intel_engines_park() config: i386-randconfig-x003-201744 (attached as .config)

[PATCH v2 2/2] drm/rcar-du: Adjust 14 checks for null pointers

From: Markus Elfring Date: Wed, 1 Nov 2017 16:00:46 +0100 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written !... Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH v2 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

From: Markus Elfring Date: Wed, 1 Nov 2017 15:57:31 +0100 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. * Increase the scope for the variable "ret". This issue was detected by using the Coccinelle

[PATCH v2 0/2] R-Car Display Unit: Fine-tuning for some function implementations

From: Markus Elfring Date: Wed, 1 Nov 2017 16:23:45 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): drm/rcar-du: Use common error handling code in rcar_du_encoders_init() drm/rcar-du: Adjust 14 checks

[Bug 99843] Geometry Shader - Incorrect Output

https://bugs.freedesktop.org/show_bug.cgi?id=99843 --- Comment #12 from Ilia Mirkin --- No one has been able to reproduce, tried on various hardware including a Radeon 6870 (BARTS). Without more information, it's unlikely that anything will happen. At the very least (a)

Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

On Wed, Nov 01, 2017 at 04:04:33PM +0100, Maarten Lankhorst wrote: > This introduces a slight behavioral change to rmfb. Instead of > disabling a crtc when the primary plane is disabled, we try to > preserve it. > > Apart from old versions of the vmwgfx xorg driver, there is > nothing depending

[Bug 99843] Geometry Shader - Incorrect Output

https://bugs.freedesktop.org/show_bug.cgi?id=99843 --- Comment #11 from d...@jerber.co.uk --- Hi, Is it likely this will be looked into or are there no plans to look into issues for older cards? -- You are receiving this mail because: You are the assignee for the

[Bug 97055] Black screens on A10-8780P (Carrizo) + R7 M260/M265 (Topaz) Combo

https://bugs.freedesktop.org/show_bug.cgi?id=97055 --- Comment #20 from Jan Vesely --- (In reply to James Payne from comment #18) > Would be good to get to the bottom of this one as it affects my wife's > laptop :( > > Currently stuck with Windows 10 which is sluggish to

Re: [PATCH 6/7] drm/drivers: drop redundant drm_edid_to_eld() calls

On Wed, Nov 01, 2017 at 04:21:02PM +0200, Jani Nikula wrote: > diff --git a/drivers/gpu/drm/nouveau/nv50_display.c > b/drivers/gpu/drm/nouveau/nv50_display.c > index e4751f92b342..e0a190a0f029 100644 > --- a/drivers/gpu/drm/nouveau/nv50_display.c > +++ b/drivers/gpu/drm/nouveau/nv50_display.c >

[PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.

This introduces a slight behavioral change to rmfb. Instead of disabling a crtc when the primary plane is disabled, we try to preserve it. Apart from old versions of the vmwgfx xorg driver, there is nothing depending on rmfb disabling a crtc. Vmwgfx' and simple kms helper atomic implementation

Re: [Intel-gfx] [PATCH 0/7] drm/edid and drivers: ELD refactoring

On Wed, Nov 01, 2017 at 04:20:56PM +0200, Jani Nikula wrote: > We were recently bitten by drm_edid_to_eld() clearing the connector > type, and us failing to set it back for DP. Here's a few ELD related > patches to try to unify ELD handling and make it a bit simpler for > drivers to get it right.

[Bug 97055] Black screens on A10-8780P (Carrizo) + R7 M260/M265 (Topaz) Combo

https://bugs.freedesktop.org/show_bug.cgi?id=97055 --- Comment #19 from Josh --- (In reply to Thomas J. Moore from comment #17) > Is this the place for AMD-related kernel bugs to die? Yes. Unfortunately, the only solution is to get a computer that is already known to be

Re: [PATCH v2] drm/drm_vma_manager.c: Remove useless goto statement

Quoting Liviu Dudau (2017-11-01 14:44:58) > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > interval-tree in drm_mm") removed a line in drm_vma_offset_add() function that > makes checking the result of calling drm_mm_insert_node() and the goto > call redundant. Rework the

[PATCH v2] drm/drm_vma_manager.c: Remove useless goto statement

Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded interval-tree in drm_mm") removed a line in drm_vma_offset_add() function that makes checking the result of calling drm_mm_insert_node() and the goto call redundant. Rework the function (as suggested by Chris Wilson) to eliminate the

Re: [PATCH] drm: hdlcd: Skip checking the clock provider when CRTC is disabled.

On Wed, Nov 01, 2017 at 02:16:25PM +, Liviu Dudau wrote: Some clock providers (clk-vexpress-osc) trigger a WARN() when the requested rate falls outside its capabilities, as is the case when a CRTC gets disabled. Check if the CRTC's new state is enabled and skip the clk_round_rate() call if

Re: [PATCH 1/2] drm/i915: Reject unknown syncobj flags

Quoting Tvrtko Ursulin (2017-10-31 10:23:25) > From: Tvrtko Ursulin > > We have to reject unknown flags for uAPI considerations, and also > because the curent implementation limits their i915 storage space > to two bits. > > v2: (Chris Wilson) > * Fix fail in ABI

Re: [PATCH] drm: Spelling fixes

On Wed, Nov 1, 2017 at 10:04 AM, Liviu Dudau wrote: > Minor spelling fix for 'monster' and replace 'on' with 'own' in > comments. > > Signed-off-by: Liviu Dudau Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_atomic.c

Re: [PATCH] drm/drm_vma_manager.c: Remove useless goto statement

Quoting Liviu Dudau (2017-11-01 14:20:53) > On Wed, Nov 01, 2017 at 02:11:44PM +, Chris Wilson wrote: > > Quoting Liviu Dudau (2017-11-01 14:04:24) > > > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > > > interval-tree in drm_mm") removed a line in drm_vma_offset_add()

Re: [PATCH] drm/drm_vma_manager.c: Remove useless goto statement

On Wed, Nov 01, 2017 at 02:11:44PM +, Chris Wilson wrote: > Quoting Liviu Dudau (2017-11-01 14:04:24) > > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > > interval-tree in drm_mm") removed a line in drm_vma_offset_add() function > > that makes checking the result of calling

[PATCH 6/7] drm/drivers: drop redundant drm_edid_to_eld() calls

drm_add_edid_modes() now fills in the ELD automatically, so the calls to drm_edid_to_eld() are redundant. Remove them. All the other places are obvious, but nv50 has detached drm_edid_to_eld() from the drm_add_edid_modes() call. Cc: Alex Deucher Cc: Christian König

[PATCH 5/7] drm/edid: build ELD in drm_add_edid_modes()

Call drm_edid_to_eld() from drm_add_edid_modes() to fill in the ELD automatically. There's no harm in doing this for connectors that do not support audio. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH 4/7] drm/edid: abstract connector ELD clearing

Preparation for future work. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[PATCH 3/7] drm/i915: remove redundant ELD connector type update

drm_edid_to_eld() now sets ELD connector type, remove the redundant update. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_modes.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_modes.c

[PATCH 7/7] drm/edid: make drm_edid_to_eld() static

This is no longer needed outside of drm_edid.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 5 ++--- include/drm/drm_edid.h | 1 - include/drm/drm_modeset_helper_vtables.h | 3 --- 3 files changed, 2 insertions(+), 7

[PATCH 0/7] drm/edid and drivers: ELD refactoring

We were recently bitten by drm_edid_to_eld() clearing the connector type, and us failing to set it back for DP. Here's a few ELD related patches to try to unify ELD handling and make it a bit simpler for drivers to get it right. Apologies for the massive Cc list; it's the maintainers of all

[PATCH 2/7] drm/edid: set ELD connector type in drm_edid_to_eld()

Since drm_edid_to_eld() knows the connector type, we can set the type in ELD while at it. Most connectors this gets called on are not DP encoders, and with the HDMI type being 0, this does not change behaviour for non-DP. For i915 having this in place earlier would have saved a considerable

[PATCH 1/7] drm/edid: use macros for ELD offsets and values

We have the macros, use them. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

Re: [PATCH] drm/drm_vma_manager.c: Remove useless goto statement

On Wed, Nov 01, 2017 at 02:11:44PM +, Chris Wilson wrote: > Quoting Liviu Dudau (2017-11-01 14:04:24) > > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > > interval-tree in drm_mm") removed a line in drm_vma_offset_add() function > > that makes checking the result of calling

Re: [PATCH v4 2/9] drm/exynos: ipp: Add IPP v2 framework

Dave Airlie wrote: > On 23 October 2017 at 17:54, Marek Szyprowski > wrote: >> This patch adds Exynos IPP v2 subsystem and userspace API. >> >> New userspace API is focused ONLY on memory-to-memory image processing. >> The two remainging IPP operation modes (framebuffer

[PATCH] drm: hdlcd: Skip checking the clock provider when CRTC is disabled.

Some clock providers (clk-vexpress-osc) trigger a WARN() when the requested rate falls outside its capabilities, as is the case when a CRTC gets disabled. Check if the CRTC's new state is enabled and skip the clk_round_rate() call if it is not. Reported-by: Vladimir Murzin

[PATCH] drm: gem_cma_helper.c: Allow importing of contiguous scatterlists with nents > 1

drm_gem_cma_prime_import_sg_table() will fail if the number of entries in the sg_table > 1. However, you can have a device that uses an IOMMU engine and can map a discontiguous buffer with multiple entries that have consecutive sg_dma_addresses, effectively making it contiguous. Allow for that

[PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.

Make sure only the planes on the active CRTCs get committed and that all planes on the disabled CRTCs get turned off. Reviewed-by: Brian Starkey Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_crtc.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH] drm: mali-dp: Separate static internal data into a read-only structure.

The malidp_hw_device structure that the driver uses to handle the differences between versions of the IP contains both non-changeable data and fields that get updated at probe time. Previously we were copying the read-only part into allocated memory, but that can be completely avoided by splitting

Re: [PATCH] drm/drm_vma_manager.c: Remove useless goto statement

Quoting Liviu Dudau (2017-11-01 14:04:24) > Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded > interval-tree in drm_mm") removed a line in drm_vma_offset_add() function > that makes checking the result of calling drm_mm_insert_node() and the > goto call redundant. Remove them. > >

[PATCH] drm: Spelling fixes

Minor spelling fix for 'monster' and replace 'on' with 'own' in comments. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_atomic.c | 2 +- drivers/gpu/drm/drm_mm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c

[PATCH] drm/drm_vma_manager.c: Remove useless goto statement

Commit db2395eccf08i ("drm: Convert drm_vma_manager to embedded interval-tree in drm_mm") removed a line in drm_vma_offset_add() function that makes checking the result of calling drm_mm_insert_node() and the goto call redundant. Remove them. Fixes: db2395eccf08i ("drm: Convert drm_vma_manager to

[PATCH] drm/drm_mm.h: Fix the name of the referenced function in comment

drm_mm_insert_node_generic() is a simplified version of drm_mm_insert_node_in_range(), update comment to reflect correct function name. Signed-off-by: Liviu Dudau --- include/drm/drm_mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment()

Mappings need to be unmapped by calling dma_buf_unmap_attachment() and not by calling again dma_buf_map_attachment(). Also fix some spelling mistakes. Signed-off-by: Liviu Dudau --- drivers/dma-buf/dma-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH] drm: Require __GFP_NOFAIL for the legacy drm_modeset_lock_all

Quoting Daniel Vetter (2017-10-31 16:38:26) > On Tue, Oct 31, 2017 at 03:28:01PM +0200, Ville Syrjälä wrote: > > On Tue, Oct 31, 2017 at 11:55:35AM +, Chris Wilson wrote: > > > To acquire all modeset locks requires a ww_ctx to be allocated. As this > > > is the legacy path and the allocation

[Bug 103404] HDMI Audio with RX Vega not working on drm-next-4.15-dc (device listed as unconnected)

https://bugs.freedesktop.org/show_bug.cgi?id=103404 Leo Li changed: What|Removed |Added Resolution|--- |FIXED

Re: RFC: Add drm_dev_suspend/resume() ?

Den 01.11.2017 09.47, skrev Daniel Vetter: On Tue, Oct 31, 2017 at 05:37:23PM +0100, Noralf Trønnes wrote: Den 30.10.2017 10.34, skrev Daniel Vetter: Hi Noralf, On Sun, Oct 22, 2017 at 06:52:41PM +0200, Noralf Trønnes wrote: Hi, I've spent some time in the fbdev emulation code and

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

On Wed, Nov 1, 2017 at 7:12 AM, Gustavo Padovan wrote: > 2017-10-31 Sean Paul : > >> On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: >> > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: >> >> On Tue, Oct

Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

Hi Boris, 2017-11-01 Boris Brezillon : > vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields > and should be printed with a %zd specifier. > > Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") > Signed-off-by: Boris

Re: [PATCH] drm/stm: checkpatch strict minor updates

2017-10-26 Philippe Cornu : > Minor fixes detected with "scripts/checkpatch.pl --strict" > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++-- > drivers/gpu/drm/stm/ltdc.c| 2 +- > 2 files changed, 3

Re: [PATCH] drm/stm: dsi: Rename driver name

Hi Philippe, 2017-10-26 Philippe Cornu : > Rename the driver name from "dw_mipi_dsi-stm" to > "stm32-display-dsi" for a better readability > in /sys/bus/platform/drivers entries. > > Signed-off-by: Philippe Cornu > --- >

Re: [PATCH 6/6] drm/msm/mdp5: Don't use async plane update path if plane visibility changes

Hi Archit, 2017-10-27 Archit Taneja : > When a plane moves out of bounds (i.e, outside the crtc clip region), the > plane state's "visible" parameter changes to false. When this happens, we > (a) release the hwpipe resources away from it, and > (b) unstage the

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-10-31 Sean Paul : > On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: > > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: > >> On Tue, Oct 31, 2017 at 4:27 AM, Jani Nikula > >> wrote: > >>> >

[PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields and should be printed with a %zd specifier. Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl") Signed-off-by: Boris Brezillon --- drivers/gpu/drm/vc4/vc4_bo.c | 4 ++--

Re: [PATCH] drm: gma500: Convert timers to use timer_setup()

On Tue, Oct 31, 2017 at 08:08:14AM -0700, Kees Cook wrote: > On Tue, Oct 31, 2017 at 3:18 AM, Daniel Vetter wrote: > > On Mon, Oct 30, 2017 at 03:05:29PM -0700, Kees Cook wrote: > >> On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter wrote: > >> > On Tue, Oct 24,

[Bug 103486] Tonga DC vblank_mode=0 not working as expected fullscreen

https://bugs.freedesktop.org/show_bug.cgi?id=103486 --- Comment #7 from Michel Dänzer --- FWIW, I've been testing with glxgears, either glxgears -fullscreen or making the window fullscreen manually. This may not work depending on the window manager, I'm using xfwm4 with

Re: [PATCH v2 hwc] drm_hwcomposer: provide a common gralloc handle definition

On Tue, Oct 31, 2017 at 04:10:52PM -0500, Rob Herring wrote: > On Tue, Oct 31, 2017 at 11:44 AM, Daniel Vetter wrote: > > On Tue, Oct 31, 2017 at 09:59:20AM -0500, Rob Herring wrote: > >> EGL, gralloc, and HWC must all have a common definition of fd's and int's > >> in

Re: [Intel-gfx] [PATCH v2 2/2] Test case for drm_vblank_cleanup refcount validation patch

On Wed, Nov 01, 2017 at 09:48:28AM +0530, PrasannaKumar Muralidharan wrote: > Hi Daniel, > > On 31 October 2017 at 21:57, Daniel Vetter wrote: > > On Tue, Oct 31, 2017 at 08:37:21PM +0530, PrasannaKumar Muralidharan wrote: > >> My patch is supposed to catch problem with drivers.

Re: RFC: Add drm_dev_suspend/resume() ?

On Tue, Oct 31, 2017 at 05:37:23PM +0100, Noralf Trønnes wrote: > > Den 30.10.2017 10.34, skrev Daniel Vetter: > > Hi Noralf, > > > > On Sun, Oct 22, 2017 at 06:52:41PM +0200, Noralf Trønnes wrote: > > > Hi, > > > > > > I've spent some time in the fbdev emulation code and discovered a > > >

[PATCH 1/2] drm/i915: Reject unknown syncobj flags

From: Tvrtko Ursulin We have to reject unknown flags for uAPI considerations, and also because the curent implementation limits their i915 storage space to two bits. v2: (Chris Wilson) * Fix fail in ABI check. * Added unknown flags and BUILD_BUG_ON. v3: * Use

  1   2   >