[git pull] drm fixes for 4.19 final (part 2)

2018-10-19 Thread Dave Airlie
Hi Greg, Looked like two stragglers snuck in, one very urgent the pageflipping was missing a reference that could result in a GPF on non-i915 drivers, the other is an overflow in the sun4i dotclock calcs resulting in a mode not getting set. Thanks, Dave. drm-fixes-2018-10-20-1: GPF fix in

Re: [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b

2018-10-19 Thread Manasi Navare
Thanks for the review. Pushed to drm-misc Manasi On Tue, Oct 09, 2018 at 04:43:51PM +0300, Ville Syrjälä wrote: > On Mon, Oct 08, 2018 at 05:23:51PM -0700, Manasi Navare wrote: > > VESA eDP 1.4 specification has separate fields defined in > > EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions. > >

Re: omap4: support for manually updated display

2018-10-19 Thread Sebastian Reichel
Hi, On Fri, Oct 19, 2018 at 09:44:50AM -0700, Tony Lindgren wrote: > * Pavel Machek [181018 22:15]: > > Hi! > > > > > > I want to make it clear that I don't want to claim any privilege in > > > > getting > > > > patches merged first. I am however worried that, without an easy way to > > > >

Re: [PATCH v5 24/28] drm/i915/dp: Configure Display stream splitter registers during DSC enable

2018-10-19 Thread Manasi Navare
On Thu, Oct 18, 2018 at 08:02:14PM +0300, Ville Syrjälä wrote: > On Fri, Oct 05, 2018 at 04:23:02PM -0700, Manasi Navare wrote: > > Display Stream Splitter registers need to be programmed to enable > > the joiner if two DSC engines are used and also to enable > > the left and the right DSC

[PATCH v2 2/2] drm/amdgpu: Retire amdgpu_ring.ready flag.

2018-10-19 Thread Andrey Grodzovsky
Start using drm_gpu_scheduler.ready isntead. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c| 6 +++---

[PATCH v2 1/2] drm/sched: Add boolean to mark if sched is ready to work v2

2018-10-19 Thread Andrey Grodzovsky
Problem: A particular scheduler may become unsuable (underlying HW) after some event (e.g. GPU reset). If it's later chosen by the get free sched. policy a command will fail to be submitted. Fix: Add a driver specific callback to report the sched status so rq with bad sched can be avoided in

Re: [PATCH DRM] drm: msm: adreno: Use DRM_DEV_* instead of dev_*

2018-10-19 Thread Sean Paul
On Thu, Oct 18, 2018 at 2:33 PM Mamta Shukla wrote: > > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate > drm-formatted specific log messages so that it will be easy to > differentiate in case of multiple instances of driver. > > Signed-off-by: Mamta Shukla Hi Mamta, Thank

[PATCH 1/2] dt-bindings: drm/bridge: sn65dsi86: Add panel-hpd-delay

2018-10-19 Thread Douglas Anderson
The timing diagram of some eDP panels says that you're supposed to wait for HPD to be asserted before the aux channel is operational. In some cases, however, it's better to just hardcode the max delay instead of trying to use HPD. Why? The sn65dsi86 datasheet says that it only reports the

[PATCH 2/2] drm/bridge: ti-sn65dsi86: Allow DT to set "HPD delay"

2018-10-19 Thread Douglas Anderson
Let's solve the mystery of commit bf1178c98930 ("drm/bridge: ti-sn65dsi86: Add mystery delay to enable()"). Specifically the reason we needed that mystery delay is that we weren't paying attention to HPD. Looking at the datasheet for the same panel that was tested for the original commit, I see

[Bug 107448] [r600g] 2 of 5 piglit sanity tests fail (PCIe, ppc64, mesa-18.2.2)

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107448 erhar...@mailbox.org changed: What|Removed |Added Summary|[r600g] 2 of 5 piglit |[r600g] 2 of 5 piglit

[Bug 107448] [r600g] 2 of 5 piglit sanity tests fail (PCIe, ppc64, mesa-18.1.5)

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107448 --- Comment #6 from erhar...@mailbox.org --- Meanwhile, on another machine (Talos II + Radeon HD 6450), another mesa (18.2.2) and rebuilt piglit from git-master. But same test-failures here. -- You are receiving this mail because: You are the

Re: [PATCH 01/11] drm/msm/dpu: Remove dpu_dbg

2018-10-19 Thread Jordan Crouse
On Fri, Oct 19, 2018 at 02:11:27PM -0400, Bruce Wang wrote: > On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote: > > > > The functions in dpu_dbg.c aren't used. The two main dump functions > > fail after a lookup from dpu_dbg_base.reg_base_list which turns out > > to never be populated and once

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 12:45 PM zhoucm1 wrote: > > > [snip] > >>> Went boom: > >>> > >>> https://bugs.freedesktop.org/show_bug.cgi?id=108490 > >>> > >>> Can we revert pls? > >> Sorry for bug, please. > > In fact, the bug is already caught and fixed, just the fix part isn't > > in patch#1, but in

[Bug 108272] [polaris10] opencl-mesa: Anything using OpenCL segfaults, XFX Radeon RX 580

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108272 --- Comment #9 from Jan Vesely --- hm, I thought I sent this out yesterday... the luxball issue should be fixed by 06bf56725db1827dfcb86b1d0bcd71d195fda1d2 ("radeonsi: Bump number of allowed global buffers to 32") the indigo benchmark might

Re: [PATCH libdrm 2/2] gitignore: add _build

2018-10-19 Thread Lucas De Marchi
On Tue, Oct 16, 2018 at 05:38:15PM +0100, Eric Engestrom wrote: > On Tuesday, 2018-10-16 08:24:02 -0700, Lucas De Marchi wrote: > > On 10/16/18 4:26 AM, Eric Engestrom wrote: > > > On Monday, 2018-10-15 16:48:07 -0700, Lucas De Marchi wrote: > > > > This is the directory used by meson/autotools

Re: [PATCH 06/11] drm/msm/dpu: Cleanup callers of dpu_hw_blk_init

2018-10-19 Thread Jordan Crouse
On Thu, Oct 18, 2018 at 11:53:59PM +0200, Sam Ravnborg wrote: > Hi Jordan. > > On Thu, Oct 18, 2018 at 01:58:31PM -0600, Jordan Crouse wrote: > > Outside of superfluous parameter checks the dpu_hw_blk_init() > > doesn't have any failure paths. Switch it over to be a void > > function and we can

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 magiblot changed: What|Removed |Added Attachment #142102|0 |1 is obsolete|

Re: [PATCH 10/11] drm/msm/gpu: Add trace events for tracking GPU submissions

2018-10-19 Thread kbuild test robot
Hi Jordan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robclark/msm-next] [also build test WARNING on next-20181019] [cannot apply to v4.19-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [PATCH 10/11] drm/msm/dpu: Further cleanups for static inline functions

2018-10-19 Thread Jordan Crouse
On Fri, Oct 19, 2018 at 12:06:20AM +0200, Sam Ravnborg wrote: > Hi Jordan. > > On Thu, Oct 18, 2018 at 01:58:35PM -0600, Jordan Crouse wrote: > > Remove more static inline functions that are lightly used and/or > > very simple and easy to build into the calling functions. > > Please explain the

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 magiblot changed: What|Removed |Added CC||magib...@hotmail.com --- Comment #4 from

Re: [Outreachy kernel] [PATCH DRM] drm: msm: adreno: Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) +PTR_ERR

2018-10-19 Thread Jordan Crouse
On Fri, Oct 19, 2018 at 09:19:32AM +0200, Daniel Vetter wrote: > On Fri, Oct 19, 2018 at 08:18:52AM +0200, Julia Lawall wrote: > > On Fri, 19 Oct 2018, Mamta Shukla wrote: > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR because its > > > better to have inlined function rather than

Re: [PATCH 3/3] drm/amdgpu: Refresh rq selection for job after ASIC reset

2018-10-19 Thread Grodzovsky, Andrey
That my next step. Andrey On 10/19/2018 12:28 PM, Christian König wrote: From my testing looks like we can, compute ring 0 is dead but IB tests pass on other compute rings. Interesting, but I would rather investigate why compute ring 0 is dead while other still work.

[PATCH 4/5] drm/ttm: initialize globals during device init

2018-10-19 Thread Christian König
Make sure that the global BO state is always correctly initialized. This allows removing all the device code to initialize it. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 59 + drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1

[PATCH 5/5] drm: Remove drm_global.{c,h} v2

2018-10-19 Thread Christian König
From: Thomas Zimmermann The content of drm_global.{c,h} is obsolete. v2: rebase on dropping TTM functionality Signed-off-by: Thomas Zimmermann Signed-off-by: Christian König --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_drv.c| 2 - drivers/gpu/drm/drm_global.c

[PATCH 1/5] drm/ttm: use a static ttm_mem_global instance

2018-10-19 Thread Christian König
As the name says we only need one global instance of ttm_mem_global. Drop all the driver initialization and just use a single exported instance which is initialized during BO global initialization. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 44

[PATCH 2/5] drm/ttm: make the device list mutex static

2018-10-19 Thread Christian König
This way it can protect the whole BO global state. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 14 +- include/drm/ttm/ttm_bo_driver.h | 1 - 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 3/5] drm/ttm: use a static ttm_bo_global instance

2018-10-19 Thread Christian König
As the name says we only need one global instance of ttm_bo_global. Just use a single exported instance which is save to initialize multiple times. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 31 +++ include/drm/ttm/ttm_bo_driver.h | 15

Re: [PATCH 3/3] drm/amdgpu: Refresh rq selection for job after ASIC reset

2018-10-19 Thread Christian König
Am 19.10.18 um 17:06 schrieb Grodzovsky, Andrey: On 10/19/2018 03:08 AM, Koenig, Christian wrote: Am 18.10.18 um 20:44 schrieb Andrey Grodzovsky: A ring might become unusable after reset, if that the case drm_sched_entity_select_rq will choose another, working rq to run the job if there is

Re: [PATCH 11/11] drm/msm/dpu: Clean up dpu_media_info.h static inline functions

2018-10-19 Thread Bruce Wang
On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote: > > Do some cleanup in the static inline functions defined in > dpu_media_info.h by cleaning up gotos and unneeded local > variables. > > Signed-off-by: Jordan Crouse Reviewed-by: Bruce Wang > --- >

Re: [PATCH 07/11] drm/msm: Make irq_postinstall optional

2018-10-19 Thread Bruce Wang
On Thu, Oct 18, 2018 at 3:58 PM Jordan Crouse wrote: > > Allow the KMS operation 'irq_postinstall' to be optional > so that the target display drivers don't need to define > a dummy function if they don't need one. > > Signed-off-by: Jordan Crouse Reviewed-by: Bruce Wang > --- >

[PATCH] gpu/drm/virtio/virtgpu_vq.c: Use kmem_cache_zalloc

2018-10-19 Thread Sabyasachi Gupta
Replaced kmem_cache_alloc + memset with kmem_cache_zalloc Signed-off-by: Sabyasachi Gupta --- drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-19 Thread Guenter Roeck
On 10/19/2018 01:53 AM, Daniel Vetter wrote: On Mon, Oct 08, 2018 at 06:13:56PM +, Koenig, Christian wrote: Am 08.10.2018 um 19:46 schrieb Guenter Roeck: On Mon, Oct 08, 2018 at 05:22:24PM +, Koenig, Christian wrote: Am 08.10.2018 um 17:57 schrieb Deucher, Alexander: One thing I

Re: [PATCH 08/11] drm/msm/dpu: Remove dpu_irq and unused functions

2018-10-19 Thread Bruce Wang
On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote: > > dpu_irq.c does some unneeded checks and passes control > to dpu_core_irq.c The simple functions can be defined > in the same file where we use them and the files and > their associated hangers on can be deleted. > > Additionally the

[PATCH] drm/msm/hdmi: Enable HPD after HDMI IRQ is set up

2018-10-19 Thread Todor Tomov
SoCs that contain MDP5 have a top level wrapper called MDSS that manages locks, power and irq for the sub-blocks within it. Irq for HDMI is also routed through the MDSS. Shortly after the Hot Plug Detection (HPD) is enabled in HDMI, HDMI interrupts are recieved by the MDSS interrupt handler.

[Bug 107928] Screen regularly turns black, reboot needed

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107928 --- Comment #13 from Matthew Vaughn --- (In reply to Matthew Vaughn from comment #11) > Downgrading from x11-drivers/xf86-video-amdgpu-18.1.0 to > x11-drivers/xf86-video-amdgpu-18.0.1 has prevented the issue from occurring > on my system.

[Bug 108379] high idle power consumption

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108379 gr...@sub.red changed: What|Removed |Added Attachment #142098|0 |1 is obsolete|

[Bug 108379] high idle power consumption

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108379 --- Comment #3 from gr...@sub.red --- Created attachment 142099 --> https://bugs.freedesktop.org/attachment.cgi?id=142099=edit dmesg output -- You are receiving this mail because: You are the assignee for the

[Bug 108379] high idle power consumption

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108379 --- Comment #2 from gr...@sub.red --- Created attachment 142098 --> https://bugs.freedesktop.org/attachment.cgi?id=142098=edit xorg log -- You are receiving this mail because: You are the assignee for the

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-19 Thread Alex Deucher
On Fri, Oct 19, 2018 at 9:31 AM Guenter Roeck wrote: > > On 10/19/2018 01:53 AM, Daniel Vetter wrote: > > On Mon, Oct 08, 2018 at 06:13:56PM +, Koenig, Christian wrote: > >> Am 08.10.2018 um 19:46 schrieb Guenter Roeck: > >>> On Mon, Oct 08, 2018 at 05:22:24PM +, Koenig, Christian wrote:

Re: [PATCH v5 9/9] drm/selftests: Add tests for drm_format_info* helpers

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 11:57:52AM +0100, Alexandru Gheorghe wrote: > Add selftests for the following newly added functions: > - drm_format_info_block_width > - drm_format_info_block_height > - drm_format_info_min_pitch > > Signed-off-by: Alexandru Gheorghe > --- >

Re: [PATCH v5 8/9] drm/selftest: Refactor test-drm_plane_helper

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 11:57:51AM +0100, Alexandru Gheorghe wrote: > The idea is to split test implementations in different compilation > units, but have one single place where we define the list of tests, > in this case(drm_modeset_selftests.h). > > Signed-off-by: Alexandru Gheorghe > --- >

Re: [PATCH v2] drm/atomic: integrate modeset lock with private objects

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 03:55:03PM +0200, Boris Brezillon wrote: > From: Rob Clark > > Follow the same pattern of locking as with other state objects. This > avoids boilerplate in the driver. > > Signed-off-by: Rob Clark > Signed-off-by: Boris Brezillon > --- > Changes in v2: > - Make sure

Re: [PATCH 3/3] drm/amdgpu: Refresh rq selection for job after ASIC reset

2018-10-19 Thread Grodzovsky, Andrey
On 10/19/2018 03:08 AM, Koenig, Christian wrote: > Am 18.10.18 um 20:44 schrieb Andrey Grodzovsky: >> A ring might become unusable after reset, if that the case >> drm_sched_entity_select_rq will choose another, working rq >> to run the job if there is one. >> Also, skip recovery of ring which

Re: [PATCH 1/3] drm/sched: Add callback to mark if sched is ready to work.

2018-10-19 Thread Grodzovsky, Andrey
Eclipse Andrey On 10/19/2018 03:13 AM, Michel Dänzer wrote: > ... and the new line here. > > Which editor are you using? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk v2

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 03:49:15PM +0200, Hans de Goede wrote: > Hi, > > On 19-10-18 11:20, Jani Nikula wrote: > > On Wed, 17 Oct 2018, Hans de Goede wrote: > > > On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > > > different frequency then the pclk which we've calculated.

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 --- Comment #3 from Daniel Stone --- The fatal bit is probably the GBM surface creation: my guess is that the KMS driver exposes IN_MODIFIERS so we try to use gbm_surface_create_with_modifiers and when it fails because i915 Mesa is blissfully

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 --- Comment #2 from Chris Wilson --- Just realised I missed the "timeline" part of [17:35:45.463] warning: Disabling render GPU timeline due to missing EGL_ANDROID_native_fence_sync extension (read as "disabling render GPU due to missing

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 --- Comment #1 from Daniel Stone --- Chris, how do you make this as missing dma-fence support? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

[PATCH v2] drm/atomic: integrate modeset lock with private objects

2018-10-19 Thread Boris Brezillon
From: Rob Clark Follow the same pattern of locking as with other state objects. This avoids boilerplate in the driver. Signed-off-by: Rob Clark Signed-off-by: Boris Brezillon --- Changes in v2: - Make sure all priv objs are locked from drm_modeset_lock_all_ctx(). This implies adding all

Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel

2018-10-19 Thread Linus Walleij
Hi Andrzej, I was just looking at this (which confused me and was not fixed in v2): On Tue, Oct 9, 2018 at 8:46 PM Linus Walleij wrote: > On Tue, Oct 9, 2018 at 10:29 AM Andrzej Hajda wrote: > > On 08.10.2018 12:58, Linus Walleij wrote: > > > > +static const struct drm_display_mode

Re: [PATCH v2 2/2] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk v2

2018-10-19 Thread Hans de Goede
Hi, On 19-10-18 11:20, Jani Nikula wrote: On Wed, 17 Oct 2018, Hans de Goede wrote: On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) different frequency then the pclk which we've calculated. This commit makes the DSI code read-back the pclk set by the GOP and if that is

[Bug 108498] ir_dereference_record nullptr segfault in radeonsi_dri.so

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108498 Michel Dänzer changed: What|Removed |Added QA Contact|dri-devel@lists.freedesktop |intel-3d-bugs@lists.freedes

Re: [PATCH v5 5/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

2018-10-19 Thread Brian Starkey
Hi Alex, On Fri, Oct 19, 2018 at 11:57:48AM +0100, Alexandru Gheorghe wrote: For formats that are supported only with non-linear modifiers it doesn't make to much sense to define cpp or char_per_block, so that will be set to 0. This patch adds a restriction to force having a modifier attached

[Bug 108487] Wayland compositors are unable to use hardware acceleration on i915: missing EGL_ANDROID_native_fence_sync extension

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108487 Chris Wilson changed: What|Removed |Added Summary|Wayland compositors are |Wayland compositors are

Re: [PATCH v5 4/9] drm: mali-dp: Enable Mali-DP tiled buffer formats

2018-10-19 Thread Brian Starkey
Hi Alex, On Fri, Oct 19, 2018 at 11:57:47AM +0100, Alexandru Gheorghe wrote: Enable the following formats - DRM_FORMAT_X0L0: DP650 - DRM_FORMAT_X0L2: DP550, DP650 Signed-off-by: Alexandru Gheorghe A couple of suggestions below, but with or without you can add my r-b. ---

Re: [PATCH v5 3/9] drm/fourcc: Add fourcc for Mali linear tiled formats

2018-10-19 Thread Brian Starkey
Hi Alex, On Fri, Oct 19, 2018 at 11:57:46AM +0100, Alexandru Gheorghe wrote: Mali-DP implements a number of tiled yuv formats which are not currently described in drm_fourcc.h. This adds those definitions and describes their memory layout by using the newly added char_per_block, block_w,

Re: [PATCH v5 2/9] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-19 Thread Brian Starkey
Hi Alex, On Fri, Oct 19, 2018 at 11:57:45AM +0100, Alexandru Gheorghe wrote: For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add

[Bug 108486] Incompatible result.json generation between igt_runner and piglit summary

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108486 --- Comment #2 from Petri Latvala --- https://patchwork.freedesktop.org/series/51238/ sent for a fix. Won't merge it yet until it gets through the currently overloaded CI. -- You are receiving this mail because: You are the assignee for the

[Bug 108498] ir_dereference_record nullptr segfault in radeonsi_dri.so

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108498 Bug ID: 108498 Summary: ir_dereference_record nullptr segfault in radeonsi_dri.so Product: Mesa Version: 18.1 Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [PATCH v5 1/9] drm: fourcc: Convert drm_format_info kerneldoc to in-line member documentation

2018-10-19 Thread Maxime Ripard
On Fri, Oct 19, 2018 at 11:57:44AM +0100, Alexandru Gheorghe wrote: > In-line member documentation seems to be desired way of documenting > structure members. > > This change had been suggested by Daniel Vetter here: > https://lists.freedesktop.org/archives/dri-devel/2018-October/192176.html > >

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread Christian König
Am 19.10.18 um 14:19 schrieb zhoucm1: On 2018年10月19日 20:08, Koenig, Christian wrote: Am 19.10.18 um 14:01 schrieb zhoucm1: On 2018年10月19日 19:26, zhoucm1 wrote: On 2018年10月19日 18:50, Chris Wilson wrote: Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel

Re: [PULL] drm-intel-next-fixes

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 12:38 PM Joonas Lahtinen wrote: > > Hi Dave, > > Here are the promised MST fixes that were missing due to being > in i915 tree, yet outside i915 directory. > > Further explanation in the previous PR's thread. fwiw, lgtm. Cheers, Daniel > > Regards, Joonas > > *** > >

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread zhoucm1
On 2018年10月19日 20:08, Koenig, Christian wrote: Am 19.10.18 um 14:01 schrieb zhoucm1: On 2018年10月19日 19:26, zhoucm1 wrote: On 2018年10月19日 18:50, Chris Wilson wrote: Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian

[Bug 108496] Non functional -d, --dry-run option for the igt_runner

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108496 Bug ID: 108496 Summary: Non functional -d, --dry-run option for the igt_runner Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread Koenig, Christian
Am 19.10.18 um 14:01 schrieb zhoucm1: > > > On 2018年10月19日 19:26, zhoucm1 wrote: >> >> >> On 2018年10月19日 18:50, Chris Wilson wrote: >>> Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian König ---

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread zhoucm1
On 2018年10月19日 19:26, zhoucm1 wrote: On 2018年10月19日 18:50, Chris Wilson wrote: Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian König ---   drivers/gpu/drm/drm_syncobj.c | 7 +--   1 file changed, 5

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread zhoucm1
On 2018年10月19日 18:50, Chris Wilson wrote: Quoting Chunming Zhou (2018-10-19 11:26:41) Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian König --- drivers/gpu/drm/drm_syncobj.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] MAINTAINERS: Add entry for VKMS

2018-10-19 Thread Rodrigo Siqueira
On 10/17, Joe Perches wrote: > On Wed, 2018-10-17 at 19:51 -0300, Rodrigo Siqueira wrote: > > Add maintainers and reviewers for VKMS driver > > > > Signed-off-by: Rodrigo Siqueira > > --- > > MAINTAINERS | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MAINTAINERS

[PATCH v5 5/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

2018-10-19 Thread Alexandru Gheorghe
For formats that are supported only with non-linear modifiers it doesn't make to much sense to define cpp or char_per_block, so that will be set to 0. This patch adds a restriction to force having a modifier attached when cpp/char_per_block is 0, and to bypass checking the pitch restriction.

[PATCH v5 9/9] drm/selftests: Add tests for drm_format_info* helpers

2018-10-19 Thread Alexandru Gheorghe
Add selftests for the following newly added functions: - drm_format_info_block_width - drm_format_info_block_height - drm_format_info_min_pitch Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 3 +

[PATCH v5 7/9] drm/afbc: Add AFBC modifier usage documentation

2018-10-19 Thread Alexandru Gheorghe
From: Brian Starkey AFBC is a flexible, proprietary, lossless compression protocol and format, with a number of defined DRM format modifiers. To facilitate consistency and compatibility between different AFBC producers and consumers, document the expectations for usage of the AFBC DRM format

[PATCH v5 8/9] drm/selftest: Refactor test-drm_plane_helper

2018-10-19 Thread Alexandru Gheorghe
The idea is to split test implementations in different compilation units, but have one single place where we define the list of tests, in this case(drm_modeset_selftests.h). Signed-off-by: Alexandru Gheorghe --- ...er_selftests.h => drm_modeset_selftests.h} | 0

[PATCH v5 0/9] Add method to describe tile/bit_level_packed formats

2018-10-19 Thread Alexandru Gheorghe
Changes since v4: - Rebased selftests on latest drm-misc-next Changes since v3: - added an utility function that computes the minimum pitch. - switched drm_format_info to in-line member documentation. - Cleanup/Improved the kernel doc. - Added selftests for: drm_format_info* helpers.

[PATCH v5 4/9] drm: mali-dp: Enable Mali-DP tiled buffer formats

2018-10-19 Thread Alexandru Gheorghe
Enable the following formats - DRM_FORMAT_X0L0: DP650 - DRM_FORMAT_X0L2: DP550, DP650 Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_hw.c | 14 +++--- drivers/gpu/drm/arm/malidp_planes.c | 23 +-- 2 files changed, 32 insertions(+), 5

[PATCH v5 3/9] drm/fourcc: Add fourcc for Mali linear tiled formats

2018-10-19 Thread Alexandru Gheorghe
Mali-DP implements a number of tiled yuv formats which are not currently described in drm_fourcc.h. This adds those definitions and describes their memory layout by using the newly added char_per_block, block_w, block_h. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/drm_fourcc.c | 12

[PATCH v5 6/9] drm/fourcc: Add AFBC yuv fourccs for Mali

2018-10-19 Thread Alexandru Gheorghe
From: Brian Starkey As we look to enable AFBC using DRM format modifiers, we run into problems which we've historically handled via vendor-private details (i.e. gralloc, on Android). AFBC (as an encoding) is fully flexible, and for example YUV data can be encoded into 1, 2 or 3 encoded

[PATCH v5 2/9] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-19 Thread Alexandru Gheorghe
For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add three new members to drm_format_info that could describe such formats: -

[PATCH v5 1/9] drm: fourcc: Convert drm_format_info kerneldoc to in-line member documentation

2018-10-19 Thread Alexandru Gheorghe
In-line member documentation seems to be desired way of documenting structure members. This change had been suggested by Daniel Vetter here: https://lists.freedesktop.org/archives/dri-devel/2018-October/192176.html Signed-off-by: Alexandru Gheorghe --- include/drm/drm_fourcc.h | 30

[PULL] drm-misc-fixes

2018-10-19 Thread Maarten Lankhorst
Hey Dave, The GPF issue was serious enough to send a second pull request for drm-misc-fixes. :) Cheers, ~Maarten drm-misc-fixes-2018-10-19: Second pull request for v4.19: - Fix ulong overflow in sun4i - Fix a serious GPF in waiting for flip_done from commit_tail(). The following changes since

Re: [PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread Chris Wilson
Quoting Chunming Zhou (2018-10-19 11:26:41) > Signed-off-by: Chunming Zhou > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: Christian König > --- > drivers/gpu/drm/drm_syncobj.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_syncobj.c

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
[snip] Went boom: https://bugs.freedesktop.org/show_bug.cgi?id=108490 Can we revert pls? Sorry for bug, please. In fact, the bug is already caught and fixed, just the fix part isn't in patch#1, but in patch#2: Have you reverted? If not, I can send that fix in one minute. Regards, David

[PULL] drm-intel-next-fixes

2018-10-19 Thread Joonas Lahtinen
Hi Dave, Here are the promised MST fixes that were missing due to being in i915 tree, yet outside i915 directory. Further explanation in the previous PR's thread. Regards, Joonas *** drm-intel-next-fixes-2018-10-19: - The missing 4 MST patches that tooling didn't pick from drm core/nouveau

[PATCH] drm: fix deadlock of syncobj

2018-10-19 Thread Chunming Zhou
Signed-off-by: Chunming Zhou Cc: Daniel Vetter Cc: Chris Wilson Cc: Christian König --- drivers/gpu/drm/drm_syncobj.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 57bf6006394d..2f3c14cb5156

[Bug 108493] Unigine Heaven at 4K crashes amdgpu and causes a GPU hang

2018-10-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108493 Bug ID: 108493 Summary: Unigine Heaven at 4K crashes amdgpu and causes a GPU hang Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux

Re: [PATCH v2] drm/sun4i: Fix an ulong overflow in the dotclock driver

2018-10-19 Thread Maxime Ripard
On Thu, Oct 18, 2018 at 12:02:50PM +0200, Boris Brezillon wrote: > The calculated ideal rate can easily overflow an unsigned long, thus > making the best div selection buggy as soon as no ideal match is found > before the overflow occurs. > > Fixes: 4731a72df273 ("drm/sun4i: request exact rates

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
On 2018年10月19日 17:20, zhoucm1 wrote: On 2018年10月19日 16:55, Daniel Vetter wrote: On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote: On 2018年10月18日 19:50, Christian König wrote: Am 18.10.18 um 05:11 schrieb zhoucm1: On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018

Re: [PATCH 01/18] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Koenig, Christian
Am 19.10.18 um 11:41 schrieb Thomas Zimmermann: > Hi > > Am 19.10.18 um 11:30 schrieb Christian König: >> In general I'm really graceful that you look into this, but you are just >> moving the complexity around instead of cleaning it up. >> >> This whole global reference stuff is just going into

Re: [PATCH 01/18] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Thomas Zimmermann
Hi Am 19.10.18 um 11:30 schrieb Christian König: > In general I'm really graceful that you look into this, but you are just > moving the complexity around instead of cleaning it up. > > This whole global reference stuff is just going into the wrong direction. > > Please let me clean that up

Re: [PULL] drm-intel-next-fixes

2018-10-19 Thread Joonas Lahtinen
Quoting Daniel Vetter (2018-10-19 10:05:32) > On Fri, Oct 19, 2018 at 8:59 AM Joonas Lahtinen > wrote: > > > > Quoting Daniel Vetter (2018-10-18 22:32:00) > > > On Thu, Oct 18, 2018 at 6:57 PM Joonas Lahtinen > > > wrote: > > > > > > > > Hi Dave, > > > > > > > > Here comes the final set of fixes

Re: [PATCH 01/18] drm/ttm: Provide struct ttm_global for referencing TTM global state

2018-10-19 Thread Christian König
In general I'm really graceful that you look into this, but you are just moving the complexity around instead of cleaning it up. This whole global reference stuff is just going into the wrong direction. Please let me clean that up instead, Christian. Am 19.10.18 um 10:54 schrieb Thomas

Re: [PATCH] drm: Revert "add syncobj timeline support v9"

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 11:27:11AM +0200, Christian König wrote: > From: Christian König > > Still contains some bugs. > > This reverts commit 48197bc564c7a1888c86024a1ba4f956e0ec2300. Thanks for the super-quick handling, much appreciated. > > Bugs:

Re: [PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

2018-10-19 Thread Daniel Vetter
On Fri, Oct 19, 2018 at 11:21 AM Alexandru-Cosmin Gheorghe wrote: > > Hi Deepak, > > Something to consider, with this approach we kind of break the > following behaviour: > "Only tests enabled as module parameters are run, if no test is > explicitly enabled then all of them are run" > > What I

[PATCH] drm: Revert "add syncobj timeline support v9"

2018-10-19 Thread Christian König
From: Christian König Still contains some bugs. This reverts commit 48197bc564c7a1888c86024a1ba4f956e0ec2300. Bugs: https://bugs.freedesktop.org/show_bug.cgi?id=108490 Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 306 +++--

Re: [PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

2018-10-19 Thread Alexandru-Cosmin Gheorghe
Hi Deepak, Something to consider, with this approach we kind of break the following behaviour: "Only tests enabled as module parameters are run, if no test is explicitly enabled then all of them are run" What I think we should do is have just one header where we put the

Re: [PATCH v2 2/2] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk v2

2018-10-19 Thread Jani Nikula
On Wed, 17 Oct 2018, Hans de Goede wrote: > On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > different frequency then the pclk which we've calculated. > > This commit makes the DSI code read-back the pclk set by the GOP and > if that is within a reasonable margin of the

Re: [PATCH 2/7] drm: add syncobj timeline support v8

2018-10-19 Thread zhoucm1
On 2018年10月19日 16:55, Daniel Vetter wrote: On Fri, Oct 19, 2018 at 10:29:55AM +0800, zhoucm1 wrote: On 2018年10月18日 19:50, Christian König wrote: Am 18.10.18 um 05:11 schrieb zhoucm1: On 2018年10月17日 18:24, Daniel Vetter wrote: On Wed, Oct 17, 2018 at 11:29 AM Koenig, Christian wrote: Am

[PATCH 13/18] staging/vboxvideo: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/staging/vboxvideo/vbox_drv.h | 4 +-- drivers/staging/vboxvideo/vbox_ttm.c | 42 +++- 2 files changed, 6

[PATCH 16/18] drm/ttm: Implement struct ttm_global_item and helpers

2018-10-19 Thread Thomas Zimmermann
The data structure struct ttm_global_item is a replacement for struct drm_global_item. While struct drm_global_item depends on global data instances, struct ttm_global_item allows drivers to use their own privat instances. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ttm/ttm_global.c |

[PATCH 18/18] drm: Remove drm_global.{c,h}

2018-10-19 Thread Thomas Zimmermann
The content of drm_global.{c,h} is obsolete. The functionality is provided in ttm_global.{c,h}. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_drv.c| 2 - drivers/gpu/drm/drm_global.c | 137 ---

[PATCH 08/18] drm/mgag200: Replace TTM initialization/release with ttm_global

2018-10-19 Thread Thomas Zimmermann
Unified initialization and release of the global TTM state is provided by struct ttm_global and its interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 7 ++-- drivers/gpu/drm/mgag200/mgag200_ttm.c | 49 +-- 2 files changed, 12

  1   2   >