Re: [git pull] drm tree for 5.4-rc1

2019-09-19 Thread Alexandre Courbot
On Fri, Sep 20, 2019 at 9:11 AM Dave Airlie wrote: > > > Hmm. My merge isn't identical to that. It's close though. Different > > order for one #define which might be just from you and me merging > > different directions. > > > > But I also ended up removing the .gem_prime_export initialization to

[drm-intel:drm-intel-next-queued 5/7] drivers/gpu/drm/i915/display/intel_color.c:1535 i9xx_read_lut_8() error: potential null dereference 'blob'. (drm_property_create_blob returns null)

2019-09-19 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: 4bb6a9d5d9a8289673c4cb0786d44be8a63c21db commit: 1af22383829864299102ca0c2eab458f755a9971 [5/7] drm/i915/display: Extract i9xx_read_luts() If you fix the issue, kindly add following tag Reported-by: kbuild test robot

[PATCH v2] drm: kirin: Fix dsi probe/attach logic

2019-09-19 Thread John Stultz
Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI host at probe time") landed in -next the HiKey board would fail to boot, looping: adv7511 2-0039: failed to find dsi host messages over and over. Andrzej Hajda suggested this is due to a circular dependency issue, and that the

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #53 from Sebastian Meyer --- Just compiled the latest mainline kernel from a few hours ago with the merge of drm-next-2019-09-18 and tried again.

Re: [RFC PATCH v2 04/11] devfreq: exynos-bus: Clean up code

2019-09-19 Thread Chanwoo Choi
Hi Artur, On 19. 9. 19. 오후 11:22, Artur Świgoń wrote: > From: Artur Świgoń > > This patch adds minor improvements to the exynos-bus driver. > > Signed-off-by: Artur Świgoń > Reviewed-by: Krzysztof Kozlowski > --- > drivers/devfreq/exynos-bus.c | 66 ++-- > 1

Re: [PATCH] drm/fourcc: Add Arm 16x16 block modifier

2019-09-19 Thread Qiang Yu
Hi guys, I'd like to know the status of this patch? I expect a v2 adding some comments/macros about the high bit plan would be enough? @Raymond & @Brian do you still need another long process to send out a v2 patch? If so, I can help to prepare a v2 patch according to your previous mail.

Re: [RFC PATCH v2 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init()

2019-09-19 Thread Chanwoo Choi
Hi, As I already replied on v1, patch1/2/3 clean-up code for readability without any behavior changes. I think that you better to merge patch1/2/3 to one patch. On 19. 9. 19. 오후 11:22, Artur Świgoń wrote: > From: Artur Świgoń > > This patch adds a new static function,

Re: [RFC PATCH v2 00/11] Simple QoS for exynos-bus driver using interconnect

2019-09-19 Thread Chanwoo Choi
Hi Artur, I tried to just build this patch on mainline kernel or linux-next. But, when I applied them, merge conflict happens. You didn't develop them on latest version. Please rebase them based on latest mainline kernel. On 19. 9. 20. 오전 10:07, Chanwoo Choi wrote: > Hi Artur, > > On v1, I

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-09-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 Christopher Snowhill (kod...@gmail.com) changed: What|Removed |Added CC|

[Bug 111122] 2500U: Graphics corruption on kernel 5.2

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=22 --- Comment #29 from Brian Schott --- (In reply to Pierre-Eric Pelloux-Prayer from comment #28) > > Could you test this commit > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2016/ >

Re: [RFC PATCH v2 00/11] Simple QoS for exynos-bus driver using interconnect

2019-09-19 Thread Chanwoo Choi
Hi Artur, On v1, I mentioned that we need to discuss how to change the v2 for this. But, I have not received any reply from you on v1. And, without your reply from v1, you just send v2. I think that it is not proper development sequence. I have spent many times to review your patches and also

[Bug 111234] amdgpu bug: kernel NULL pointer dereference during video playback

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111234 --- Comment #4 from jamespharve...@gmail.com --- Just ran into this for my first time. I've had pretty consistent problems with the potentially related bug that Nicholas Kazlauskas mentioned at https://bugzilla.kernel.org/show_bug.cgi?id=204181

Re: [git pull] drm tree for 5.4-rc1

2019-09-19 Thread Dave Airlie
> Hmm. My merge isn't identical to that. It's close though. Different > order for one #define which might be just from you and me merging > different directions. > > But I also ended up removing the .gem_prime_export initialization to > drm_gem_prime_export, because it's the default if none

Re: [PATCH 15/15] drm/amd/display: Trigger modesets on MST DSC connectors

2019-09-19 Thread Lyude Paul
This still needs to be moved into an atomic helper so it can be reused by other drivers ... ... however, I've had this patch series on my mind for a while and something occurred to me that would be a lot easier. Why exactly are we not just enabling DSC wherever it's supported, regardless of

Re: [PATCH 08/15] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-09-19 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2019-09-18 at 16:26 -0400, mikita.lip...@amd.com wrote: > From: David Francis > > Add drm_dp_mst_dsc_aux_for_port. To enable DSC, the DSC_ENABLED > register might have to be written on the leaf port's DPCD, > its parent's DPCD, or the MST manager's DPCD. This

Re: [PATCH 09/15] drm/dp_mst: Add new quirk for Synaptics MST hubs

2019-09-19 Thread Lyude Paul
Great work! Reviewed-by: Lyude Paul On Wed, 2019-09-18 at 16:26 -0400, mikita.lip...@amd.com wrote: > From: David Francis > > Synaptics DP1.4 hubs (BRANCH_ID 0x90CC24) do not > support virtual DPCD registers, but do support DSC. > The DSC caps can be read from the physical aux, > like in SST

Re: [PATCH 03/15] drm/amdgpu: validate mst topology in atomic check

2019-09-19 Thread Lyude Paul
This also needs to be squashed into the previous two patches. There's no point in using drm_dp_atomic_find_vcpi_slots() or drm_dp_atomic_release_vcpi_slots() without drm_dp_mst_atomic_check(), since the VCPI allocations setup by the two functions aren't validated until then. On Wed, 2019-09-18 at

Re: [git pull] drm tree for 5.4-rc1

2019-09-19 Thread pr-tracker-bot
The pull request you sent on Fri, 20 Sep 2019 05:08:55 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2019-09-18 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/574cc4539762561d96b456dbc0544d8898bd4c6e Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH 02/15] drm/amdgpu: Add connector atomic check

2019-09-19 Thread Lyude Paul
On Wed, 2019-09-18 at 16:26 -0400, mikita.lip...@amd.com wrote: > From: Mikita Lipski > > [why] > Complying with new MST atomic check requirements. > The driver needs to call this function on every > atomic check to reset the VCPI slots if new state > disables > [how] > - Verify that it is a MST

Re: [git pull] drm tree for 5.4-rc1

2019-09-19 Thread Linus Torvalds
On Thu, Sep 19, 2019 at 12:09 PM Dave Airlie wrote: > > There are a few merge conflicts across the board, we have a shared > rerere cache which meant I hadn't noticed them until I avoided the > cache. > https://cgit.freedesktop.org/drm/drm/log/?h=drm-5.4-merge > contains what we've done, none of

[radeon-alex:amd-mainline-dkms-5.0 3698/3724] include/linux/dma-fence.h:508:20: sparse: the previous one is here

2019-09-19 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.0 head: a51a5ad4b8daf0dd0a437d51a19c2baa98953675 commit: a5784d79d1577c00e6e81f892cde52593546a5f4 [3698/3724] drm/amdkcl: drop kcl_dma_fence_set_error reproduce: # apt-get install sparse # sparse version:

Re: [PATCH 01/15] drm/amdgpu: Add encoder atomic check

2019-09-19 Thread Lyude Paul
Ok, so reviewing this is kind of difficult because this series doesn't apply to drm-tip, and also doesn't make any mention of what branch it's supposed to apply to. So there's no way for me to apply any of these changes in my tree to get an idea of how things look overall with these patches

Re: [PATCH v2] drm/amd/display: fix struct init in update_bounding_box

2019-09-19 Thread Alex Deucher
On Wed, Aug 28, 2019 at 2:51 PM Raul E Rangel wrote: > > dcn20_resource.c:2636:9: error: missing braces around initializer > [-Werror=missing-braces] > struct _vcs_dpi_voltage_scaling_st > calculated_states[MAX_CLOCK_LIMIT_STATES] = {0}; > ^ > Fixes: 7ed4e6352c16f ("drm/amd/display:

[Bug 111691] inconsistent cursor movement speed when using AMD 5700 XT

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111691 Michael Haworth changed: What|Removed |Added Summary|hardware cursor corruption |inconsistent cursor

[Bug 204227] Visual artefacts and crash from suspend on amdgpu

2019-09-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204227 --- Comment #14 from Mirek Kratochvil (exa@gmail.com) --- Created attachment 285069 --> https://bugzilla.kernel.org/attachment.cgi?id=285069=edit syslog from 5.2.16 with warnings -- You are receiving this mail because: You are watching

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-19 Thread Jernej Škrabec
Dne četrtek, 19. september 2019 ob 22:03:26 CEST je Roman Stratiienko napisal(a): > Hello guys, > > Actually, I beleive this is True solution, and current one is wrong. Let > me explain why. > > De2. 0 was designed to match Android hwcomposer hal requirements IMO. > You can easily agree with

[Bug 204227] Visual artefacts and crash from suspend on amdgpu

2019-09-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204227 --- Comment #13 from Mirek Kratochvil (exa@gmail.com) --- After the BIOS upgrade the kernel parameters can be removed, but the kernel (5.2.16) now locks up when entering XFCE (it survives lightdm though). The error is almost same as as in the

[Bug 111691] hardware cursor corruption w/ AMD 5700 XT

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111691 --- Comment #10 from Michael Haworth --- issue occurs with the closed source drivers too, on kernel 4.15 (linux mint 19.2) but to a much lesser extent -- You are receiving this mail because: You are the assignee for the

Re: [PATCH] drm/amdkfd: fix a potential NULL pointer dereference

2019-09-19 Thread Kuehling, Felix
On 2019-09-18 12:30 p.m., Allen Pais wrote: > alloc_workqueue is not checked for errors and as a result, > a potential NULL dereference could occur. > > Signed-off-by: Allen Pais > --- > drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[Bug 111633] amdgpu driver crash with kernel NULL pointer dereference

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111633 --- Comment #1 from vakevk+freedesktopbugzi...@gmail.com --- Another one, different stacktrace. BUG: kernel NULL pointer dereference, address: 0360 #PF: supervisor write access in kernel mode #PF: error_code(0x0002) - not-present

[Bug 111077] link_shader and deserialize_glsl_program suddenly consume huge amount of RAM

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111077 Matt Turner changed: What|Removed |Added CC|matts...@gmail.com | --- Comment #44 from Matt Turner ---

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #52 from Matthias Müller --- Comment on attachment 145436 --> https://bugs.freedesktop.org/attachment.cgi?id=145436 Log of divide error i just encountered a "random" freeze, too. And because it seems to be something "new", i

[Bug 111481] AMD Navi GPU frequent freezes on both Manjaro/Ubuntu with kernel 5.3 and mesa 19.2 -git/llvm9

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111481 --- Comment #51 from Matthias Müller --- Created attachment 145436 --> https://bugs.freedesktop.org/attachment.cgi?id=145436=edit Log of divide error -- You are receiving this mail because: You are the assignee for the

Re: [PATCH v3] drm/v3d: clean caches at the end of render jobs on request from user space

2019-09-19 Thread Eric Anholt
Iago Toral Quiroga writes: > Extends the user space ioctl for CL submissions so it can include a request > to flush the cache once the CL execution has completed. Fixes memory > write violation messages reported by the kernel in workloads involving > shader memory writes (SSBOs, shader images,

[PATCH v9 3/8] drm: Rename HDMI colorspace property creation function

2019-09-19 Thread Gwan-gyeong Mun
As between HDMI and DP have different colorspaces, in order to distinguish colorspace of DP and HDMI, it renames drm_mode_create_colorspace_property() function to drm_mode_create_hdmi_colorspace_property() function for HDMI connector. In order to apply changed drm api, i915 driver has channged.

[PATCH v9 0/8] drm/i915/dp: Support for DP HDR outputs

2019-09-19 Thread Gwan-gyeong Mun
Support for HDR10 video was introduced in DisplayPort 1.4. On GLK+ platform, in order to use DisplayPort HDR10, we need to support BT.2020 colorimetry and HDR Static metadata. It implements the CTA-861-G standard for transport of static HDR metadata. It enables writing of HDR metadata infoframe

[PATCH v9 4/8] drm: Add DisplayPort colorspace property creation function

2019-09-19 Thread Gwan-gyeong Mun
Because between HDMI and DP have different colorspaces, it adds drm_mode_create_dp_colorspace_property() function for creating of DP colorspace property. v3: Addressed review comments from Ville - Add new colorimetry options for DP 1.4a spec. - Separate set of colorimetry enum values for

[PATCH v9 8/8] drm/i915/dp: Attach HDR metadata property to DP connector

2019-09-19 Thread Gwan-gyeong Mun
It attaches HDR metadata property to DP connector on GLK+. It enables HDR metadata infoframe sdp on GLK+ to be used to send HDR metadata to DP sink. v2: Minor style fix Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_dp.c | 5 + 1 file

[PATCH v9 7/8] drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata

2019-09-19 Thread Gwan-gyeong Mun
Function intel_dp_setup_hdr_metadata_infoframe_sdp handles Infoframe SDP header and data block setup for HDR Static Metadata. It enables writing of HDR metadata infoframe SDP to panel. Support for HDR video was introduced in DisplayPort 1.4. It implements the CTA-861-G standard for transport of

[PATCH v9 2/8] drm/i915/dp: Add support of BT.2020 Colorimetry to DP MSA

2019-09-19 Thread Gwan-gyeong Mun
When BT.2020 Colorimetry output is used for DP, we should program BT.2020 Colorimetry to MSA and VSC SDP. In order to handle colorspace of drm_connector_state, it moves a calling of intel_ddi_set_pipe_settings() function into intel_ddi_pre_enable_dp(). And it also rename

[PATCH v9 5/8] drm/i915/dp: Attach colorspace property

2019-09-19 Thread Gwan-gyeong Mun
It attaches the colorspace connector property to a DisplayPort connector. Based on colorspace change, modeset will be triggered to switch to a new colorspace. And in order to distinguish colorspace bwtween DP and HDMI connector, it adds a handling of drm_mode_create_dp_colorspace_property() to

[PATCH v9 6/8] drm/i915: Add new GMP register size for GEN11

2019-09-19 Thread Gwan-gyeong Mun
According to Bspec, GEN11 and prior GEN11 have different register size for HDR Metadata Infoframe SDP packet. It adds new VIDEO_DIP_GMP_DATA_SIZE for GEN11. And it makes handle different register size for HDMI_PACKET_TYPE_GAMUT_METADATA on hsw_dip_data_size() for each GEN platforms. It addresses

[PATCH v9 1/8] drm/i915/dp: Extend program of VSC Header and DB for Colorimetry Format

2019-09-19 Thread Gwan-gyeong Mun
It refactors and renames a function which handled vsc sdp header and data block setup for supporting colorimetry format. Function intel_dp_setup_vsc_sdp handles vsc sdp header and data block setup for pixel encoding / colorimetry format. In order to use colorspace information of a connector, it

Re: [PATCH v8 6/7] drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata

2019-09-19 Thread Mun, Gwan-gyeong
On Wed, 2019-09-18 at 17:13 +0300, Ville Syrjälä wrote: > On Mon, Sep 16, 2019 at 10:11:49AM +0300, Gwan-gyeong Mun wrote: > > Function intel_dp_setup_hdr_metadata_infoframe_sdp handles > > Infoframe SDP > > header and data block setup for HDR Static Metadata. It enables > > writing of > > HDR

Re: [PATCH v8 3/7] drm: Add DisplayPort colorspace property

2019-09-19 Thread Mun, Gwan-gyeong
On Wed, 2019-09-18 at 17:08 +0300, Ville Syrjälä wrote: > On Mon, Sep 16, 2019 at 10:11:46AM +0300, Gwan-gyeong Mun wrote: > > Because between HDMI and DP have different colorspaces, it renames > > drm_mode_create_colorspace_property() function to > > drm_mode_create_hdmi_colorspace_property()

Re: [PATCH v8 2/7] drm/i915/dp: Add support of BT.2020 Colorimetry to DP MSA

2019-09-19 Thread Mun, Gwan-gyeong
On Wed, 2019-09-18 at 17:15 +0300, Ville Syrjälä wrote: > On Mon, Sep 16, 2019 at 10:11:45AM +0300, Gwan-gyeong Mun wrote: > > When BT.2020 Colorimetry output is used for DP, we should program > > BT.2020 > > Colorimetry to MSA and VSC SDP. It adds output_colorspace to > > intel_crtc_state struct

Re: [PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 7:30 PM Maxime Ripard wrote: > > The newer Allwinner SoCs have a different layers controller than the older > ones. Jernej wrote that support and has been reviewing patches for a while > now, so let's make him a formal reviewer. > > Signed-off-by: Maxime Ripard Haz

[Bug 111244] amdgpu kernel 5.2 blank display after resume from suspend

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111244 --- Comment #30 from Gabriel C --- (In reply to Gabriel C from comment #29) > Michael, > > I see the same on a Ryzen 7 35750H APU + RX 560x Nitro5 Laptop. It is 3750H :-) -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 1/2] MAINTAINERS: Update Allwinner DRM drivers entry

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 7:36 PM Chen-Yu Tsai wrote: > > On Fri, Sep 20, 2019 at 1:30 AM Maxime Ripard wrote: > > > > The DRM drivers are more than about the A10 now, so let's make the entry > > name a bit more generic. > > > > Also, Chen-Yu has been a de-facto maintainer for the DRM driver for a

[Bug 111244] amdgpu kernel 5.2 blank display after resume from suspend

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111244 --- Comment #29 from Gabriel C --- Michael, I see the same on a Ryzen 7 35750H APU + RX 560x Nitro5 Laptop. reverting https://github.com/freedesktop/xorg-xf86-video-amdgpu/commit/a2b32e72fdaff3007a79b84929997d8176c2d512 fixes the problem for

[radeon-alex:amd-mainline-dkms-5.0 3711/3724] drivers/gpu/drm/ttm/ttm_bo_vm.c:137:44: error: 'struct vm_fault' has no member named 'virtual_address'

2019-09-19 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.0 head: a51a5ad4b8daf0dd0a437d51a19c2baa98953675 commit: 5165cd1453625e59650a1ed9b0f269b41529e421 [3711/3724] Revert "Revert "drm/amd/autoconf: Test whether vm_fault->{address/vma} is available"" config:

Re: drm/sun4i: Add missing pixel formats to the vi layer

2019-09-19 Thread Jernej Škrabec
Hi! Dne sreda, 18. september 2019 ob 13:05:41 CEST je roman.stratiie...@globallogic.com napisal(a): > From: Roman Stratiienko > > According to Allwinner DE2.0 Specification REV 1.0, vi layer supports the > following pixel formats: ABGR_, ARGB_, BGRA_, RGBA_ It's true that DE2

Re: [PATCH 02/19] drm/atomic-helper: Make crtc helper funcs optional

2019-09-19 Thread Ville Syrjälä
On Wed, Sep 18, 2019 at 01:42:09PM +, Lisovskiy, Stanislav wrote: > On Mon, 2019-07-08 at 15:53 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Allow drivers to call drm_atomic_helper_check_modeset() without > > having the crtc helper funcs specified. i915 doesn't need those > >

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-19 Thread Jernej Škrabec
Dne četrtek, 19. september 2019 ob 19:17:54 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, Sep 19, 2019 at 03:37:03PM +0300, roman.stratiie...@globallogic.com wrote: > > From: Roman Stratiienko > > > > DE2.0 blender does not take into the account alpha channel of vi layer. > > Thus makes

[Bug 109628] WARNING at dcn10_hw_sequencer.c:868 dcn10_verify_allow_pstate_change_high()

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109628 --- Comment #20 from vlad@ivanov.email --- Still seeing the warning with 5.4.0-0.rc0.git2.2.fc32.x86_64; waking up doesn't work. This is fedora kernel though and there's a possibility those patches aren't integrated there yet; is there a way to

Re: [PATCH] drm/amdgpu: remove excess function parameter description

2019-09-19 Thread Alex Deucher
On Thu, Sep 19, 2019 at 10:03 AM yu kuai wrote: > > Fixes gcc warning: > > drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:431: warning: Excess function > parameter 'sw' description in 'vcn_v2_5_disable_clock_gating' > drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:550: warning: Excess function > parameter 'sw'

Re: [PATCH v5 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-09-19 Thread Guido Günther
Hi Andrzej, thanks for your comments! On Thu, Sep 19, 2019 at 03:56:45PM +0200, Andrzej Hajda wrote: > On 14.09.2019 18:11, Guido Günther wrote: > > Hi Andrzej, > > thanks for having a look! > > > > On Fri, Sep 13, 2019 at 11:31:43AM +0200, Andrzej Hajda wrote: > >> On 09.09.2019 04:25, Guido

Re: [PATCH 1/2] MAINTAINERS: Update Allwinner DRM drivers entry

2019-09-19 Thread Chen-Yu Tsai
On Fri, Sep 20, 2019 at 1:30 AM Maxime Ripard wrote: > > The DRM drivers are more than about the A10 now, so let's make the entry > name a bit more generic. > > Also, Chen-Yu has been a de-facto maintainer for the DRM driver for a > while, is a maintainer of the Allwinner platform for an even

[PATCH 2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

2019-09-19 Thread Maxime Ripard
The newer Allwinner SoCs have a different layers controller than the older ones. Jernej wrote that support and has been reviewing patches for a while now, so let's make him a formal reviewer. Signed-off-by: Maxime Ripard --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 1/2] MAINTAINERS: Update Allwinner DRM drivers entry

2019-09-19 Thread Maxime Ripard
The DRM drivers are more than about the A10 now, so let's make the entry name a bit more generic. Also, Chen-Yu has been a de-facto maintainer for the DRM driver for a while, is a maintainer of the Allwinner platform for an even longer time, and has drm-misc commit access. Let's make it formal

[Bug 111077] link_shader and deserialize_glsl_program suddenly consume huge amount of RAM

2019-09-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111077 --- Comment #43 from rol...@rptd.ch --- Sorry, but this is rude. I waited for an answer on my result of testing the patch (as requested) and that's what I get as answer? I can continue trying to find a reproducible task but then please say that

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-19 Thread Maxime Ripard
Hi, On Thu, Sep 19, 2019 at 03:37:03PM +0300, roman.stratiie...@globallogic.com wrote: > From: Roman Stratiienko > > DE2.0 blender does not take into the account alpha channel of vi layer. > Thus makes overlaying of this layer totally opaque. > Using vi layer as bottom solves this issue. > >

Re: [PATCH] drm/radeon: fix a potential NULL pointer dereference

2019-09-19 Thread Michel Dänzer
On 2019-09-18 6:31 p.m., Allen Pais wrote: > alloc_workqueue is not checked for errors and as a result, > a potential NULL dereference could occur. > > Signed-off-by: Allen Pais > --- > drivers/gpu/drm/radeon/radeon_display.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse

2019-09-19 Thread Rob Herring
On Mon, Sep 9, 2019 at 11:22 AM Steven Price wrote: > > On 09/09/2019 16:41, Rob Herring wrote: > > On Fri, Sep 6, 2019 at 4:23 PM Steven Price wrote: > >> > >> On 04/09/2019 13:30, Mark Brown wrote: > >>> The panfrost driver requests a supply using regulator_get_optional() > >>> but both the

Re: [PATCH v2] drm/panfrost: Prevent race when handling page fault

2019-09-19 Thread Rob Herring
On Fri, Sep 13, 2019 at 11:03 AM Steven Price wrote: > > When handling a GPU page fault addr_to_drm_mm_node() is used to > translate the GPU address to a buffer object. However it is possible for > the buffer object to be freed after the function has returned resulting > in a use-after-free of

Re: [RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION)

2019-09-19 Thread Sumit Semwal
Hello Christoph, everyone, On Sat, 7 Sep 2019 at 00:17, John Stultz wrote: > > Here is yet another pass at the dma-buf heaps patchset Andrew > and I have been working on which tries to destage a fair chunk > of ION functionality. > > The patchset implements per-heap devices which can be opened >

Re: [PATCH] drm/amd/display: hide an unused variable

2019-09-19 Thread Alex Deucher
On Thu, Sep 19, 2019 at 9:45 AM Harry Wentland wrote: > > On 2019-09-18 3:53 p.m., Arnd Bergmann wrote: > > Without CONFIG_DEBUG_FS, we get a warning for an unused > > variable: > > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6020:33: error: > > unused variable 'source'

Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks

2019-09-19 Thread Koenig, Christian
Am 19.09.19 um 16:28 schrieb Sven Van Asbroeck: > Hi Christian, > > On Thu, Sep 19, 2019 at 4:05 AM Koenig, Christian > wrote: >>> +out4: >>> + kfree(i2s_pdata); >>> +out3: >>> + kfree(adev->acp.acp_res); >>> +out2: >>> + kfree(adev->acp.acp_cell); >>> +out1: >>> +

Re: [Intel-gfx] [PATCH] dma-buf: Implement simple read/write vfs ops

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 5:53 PM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-09-19 16:28:41) > > On Thu, Sep 19, 2019 at 5:09 PM Chris Wilson > > wrote: > > > > > > It is expected that processes will pass dma-buf fd between drivers, and > > > only using the fd themselves for mmaping and

[PATCH -next] treewide: remove unused argument in lock_release()

2019-09-19 Thread Qian Cai
Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument in __lock_release"), @nested is no longer used in lock_release(), so remove it from all lock_release() calls and friends. Signed-off-by: Qian Cai --- drivers/gpu/drm/drm_connector.c | 2 +-

Re: [PATCH] dma-buf: Implement simple read/write vfs ops

2019-09-19 Thread Chris Wilson
Quoting Daniel Vetter (2019-09-19 16:28:41) > On Thu, Sep 19, 2019 at 5:09 PM Chris Wilson wrote: > > > > It is expected that processes will pass dma-buf fd between drivers, and > > only using the fd themselves for mmaping and synchronisation ioctls. > > However, it may be convenient for an

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-19 Thread Alex Deucher
On Wed, Sep 18, 2019 at 8:04 AM Liviu Dudau wrote: > > On Wed, Sep 18, 2019 at 09:49:40AM +0100, Daniel Stone wrote: > > Hi all, > > Hi, > > > > > On Tue, 17 Sep 2019 at 13:53, Daniel Vetter wrote: > > > On Mon, Sep 09, 2019 at 01:42:53PM +, Ayan Halder wrote: > > > > Let us ignore how the

[pull] amdgpu drm-fixes-5.4

2019-09-19 Thread Alex Deucher
Hi Dave, Daniel, A few fixes for 5.4. The following changes since commit 945b584c94f8c665b2df3834a8a6a8faf256cd5f: Merge branch 'linux-5.4' of git://github.com/skeggsb/linux into drm-next (2019-09-17 16:31:34 +1000) are available in the Git repository at:

Re: [PATCH v3 3/3] drm: Add self_refresh_state debugfs entry

2019-09-19 Thread Sean Paul
On Thu, Sep 19, 2019 at 11:33:58AM -0400, Sean Paul wrote: > From: Sean Paul > > This patch adds a debugfs entry to surface the entry and exit times as > well as the calculated delay. > > Suggested-by: Daniel Vetter > Signed-off-by: Sean Paul > Link to v2: >

[PATCH v3 3/3] drm: Add self_refresh_state debugfs entry

2019-09-19 Thread Sean Paul
From: Sean Paul This patch adds a debugfs entry to surface the entry and exit times as well as the calculated delay. Suggested-by: Daniel Vetter Signed-off-by: Sean Paul Link to v2: https://patchwork.freedesktop.org/patch/msgid/20190918200734.149876-3-s...@poorly.run Changes in v2: - Added

Re: [PATCH] dma-buf: Implement simple read/write vfs ops

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 5:09 PM Chris Wilson wrote: > > It is expected that processes will pass dma-buf fd between drivers, and > only using the fd themselves for mmaping and synchronisation ioctls. > However, it may be convenient for an application to read/write into the > dma-buf, for instance

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-19 Thread Ayan Halder
On Thu, Sep 19, 2019 at 04:10:42PM +0200, Daniel Vetter wrote: > On Thu, Sep 19, 2019 at 4:03 PM Ayan Halder wrote: > > > > On Wed, Sep 18, 2019 at 10:30:12PM +0100, Daniel Stone wrote: > > > > Hi All, > > Thanks for your suggestions. > > > > > Hi Liviu, > > > > > > On Wed, 18 Sep 2019 at 13:04,

[PATCH] dma-buf: Implement simple read/write vfs ops

2019-09-19 Thread Chris Wilson
It is expected that processes will pass dma-buf fd between drivers, and only using the fd themselves for mmaping and synchronisation ioctls. However, it may be convenient for an application to read/write into the dma-buf, for instance a test case to check the internal dma_buf->ops->kmap interface.

Re: [PATCH v7 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI

2019-09-19 Thread Jernej Škrabec
Hi! Dne četrtek, 19. september 2019 ob 15:54:49 CEST je Cheng-Yi Chiang napisal(a): > Use two dai_links. One for HDMI and one for max98090. > With this setup, audio can play to speaker and HDMI selectively. > > Signed-off-by: Cheng-Yi Chiang > --- >

Re: [PATCH] drm: damage_helper: Fix race checking plane->state->fb

2019-09-19 Thread Sean Paul
On Thu, Sep 05, 2019 at 12:41:27PM +0200, Daniel Vetter wrote: > On Wed, Sep 4, 2019 at 10:29 PM Sean Paul wrote: > > > > From: Sean Paul > > > > Since the dirtyfb ioctl doesn't give us any hints as to which plane is > > scanning out the fb it's marking as damaged, we need to loop through > >

[PATCH] video: pxafb: Use devm_platform_ioremap_resource() in pxafb_probe()

2019-09-19 Thread Markus Elfring
From: Markus Elfring Date: Thu, 19 Sep 2019 16:51:38 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/pxafb.c | 10 +- 1 file changed, 1

Re: [PATCH] drm/msm: include linux/sched/task.h

2019-09-19 Thread Jordan Crouse
On Wed, Sep 18, 2019 at 09:57:07PM +0200, Arnd Bergmann wrote: > Without this header file, compile-testing may run into a missing > declaration: > > drivers/gpu/drm/msm/msm_gpu.c:444:4: error: implicit declaration of function > 'put_task_struct' [-Werror,-Wimplicit-function-declaration] > >

Re: [PATCH] drm/komeda: Fix FLIP_COMPLETE timestamp on CRTC enable

2019-09-19 Thread Mihail Atanassov
On Thursday, 19 September 2019 14:30:02 BST Mihail Atanassov wrote: > When initially turning a crtc on, drm_reset_vblank_timestamp will > set the vblank timestamp to 0 for any driver that doesn't provide > a ->get_vblank_timestamp() hook. > > Unfortunately, the FLIP_COMPLETE event depends on that

[PATCH] video: ocfb: Use devm_platform_ioremap_resource() in ocfb_probe()

2019-09-19 Thread Markus Elfring
From: Markus Elfring Date: Thu, 19 Sep 2019 16:26:56 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/ocfb.c | 9 + 1 file changed, 1

[RFC PATCH v2 00/11] Simple QoS for exynos-bus driver using interconnect

2019-09-19 Thread Artur Świgoń
The following patchset adds interconnect[1][2] framework support to the exynos-bus devfreq driver. Extending the devfreq driver with interconnect capabilities started as a response to the issue referenced in [3]. The patches can be subdivided into four logical groups: (a) Refactoring the existing

[RFC PATCH v2 11/11] drm: exynos: mixer: Add interconnect support

2019-09-19 Thread Artur Świgoń
From: Marek Szyprowski This patch adds interconnect support to exynos-mixer. Please note that the mixer works the same as before when CONFIG_INTERCONNECT is 'n'. Co-developed-by: Artur Świgoń Signed-off-by: Marek Szyprowski Signed-off-by: Artur Świgoń ---

[RFC PATCH v2 07/11] interconnect: Relax condition in apply_constraints()

2019-09-19 Thread Artur Świgoń
From: Artur Świgoń The exynos-bus devfreq driver is extended with interconnect functionality by a subsequent patch. This patch removes a check from the interconnect framework that prevents interconnect from working on exynos-bus, in which every bus is a separate interconnect provider.

[RFC PATCH v2 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic

2019-09-19 Thread Artur Świgoń
From: Artur Świgoń This patch improves code readability by changing the following construct: >if (cond) >goto passive; >foo(); >goto out; >passive: >bar(); >out: into this: >if (cond) >bar(); >else >foo(); Signed-off-by: Artur Świgoń ---

[PATCH 3/3] drm/atomic-helper: Improve drm_atomic_helper_check_plane_state() debugs

2019-09-19 Thread Ville Syrjala
From: Ville Syrjälä Dump out the plane/crtc id/name in the failure debug messages. Makes a bit easier to figure out which plane exactly has failed when you have tons of them. Cc: Sean Paul Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic_helper.c | 9 +++-- 1 file changed, 7

[PATCH 2/3] drm/atomic: Pimp the debugs for scaling fails

2019-09-19 Thread Ville Syrjala
From: Ville Syrjälä When the calculate scaling factors are out of range let's print out the calculated value and the min/max. Should make life a bit less confusing when decoding failure logs. I decided to print them in decimal rather than hex. Not sure which people prefer but maybe this is less

[PATCH 1/3] drm/rect: Return scaling factor and error code separately

2019-09-19 Thread Ville Syrjala
From: Ville Syrjälä We may want to dump out the calculated scaling factor(s) when they exceed the limits. To achieve that we need to return the error code and scaling factor separately. Side note: the code in dpu_plane_validate_multirect_v2() looks rather dubious on account of it not using

[PULL] drm-intel-next-fixes

2019-09-19 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2019-09-19: - Extend old HSW workaround to fix some GPU hangs on Haswell GT2 - Fix return error code on GEM mmap. - White list a chicken bit register for push constants legacy mode on Mesa - Fix resume issue related to GGTT restore - Remove

Re: [PATCH v2 2/3] drm: Measure Self Refresh Entry/Exit times to avoid thrashing

2019-09-19 Thread Sean Paul
On Wed, Sep 18, 2019 at 04:07:29PM -0400, Sean Paul wrote: > From: Sean Paul > > Currently the self refresh idle timer is a const set by the crtc. This > is fine if the self refresh entry/exit times are well-known for all > panels used on that crtc. However panels and workloads can vary quite a

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-19 Thread Daniel Vetter
On Thu, Sep 19, 2019 at 4:03 PM Ayan Halder wrote: > > On Wed, Sep 18, 2019 at 10:30:12PM +0100, Daniel Stone wrote: > > Hi All, > Thanks for your suggestions. > > > Hi Liviu, > > > > On Wed, 18 Sep 2019 at 13:04, Liviu Dudau wrote: > > > On Wed, Sep 18, 2019 at 09:49:40AM +0100, Daniel Stone

Re: [PATCH] drm: tweak drm_print_bits()

2019-09-19 Thread Jani Nikula
On Thu, 19 Sep 2019, Gerd Hoffmann wrote: > There is little reason for the from/to logic, printing a subset of > the bits can be done by simply shifting/masking value if needed. > > Also use for_each_set_bit(). Oh, I don't know why I stumbled upon and reviewed a patch that had already been

[PATCH 3/5] backlight: pwm_bl: drop use of int_pow()

2019-09-19 Thread Rasmus Villemoes
The scheduler uses a (currently private) fixed_power_int() in its load average computation for computing powers of numbers 0 < x < 1 expressed as fixed-point numbers, which is also what we want here. But that requires the scale to be a power-of-2. We could (and a following patch will) change to

[PATCH 2/5] backlight: pwm_bl: eliminate a 64/32 division

2019-09-19 Thread Rasmus Villemoes
lightness*1000 is nowhere near overflowing 32 bits, so we can just use an ordinary 32/32 division, which is much cheaper than the 64/32 done via do_div(). Signed-off-by: Rasmus Villemoes --- drivers/video/backlight/pwm_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/5] backlight: pwm_bl: fix cie1913 comments and constant

2019-09-19 Thread Rasmus Villemoes
The "break-even" point for the two formulas is L==8, which is also what the code actually implements. [Incidentally, at that point one has Y=0.008856, not 0.08856]. Moreover, all the sources I can find say the linear factor is 903.3 rather than 902.3, which makes sense since then the formulas

Re: [RFC PATCH] drm:- Add a modifier to denote 'protected' framebuffer

2019-09-19 Thread Ayan Halder
On Wed, Sep 18, 2019 at 10:30:12PM +0100, Daniel Stone wrote: Hi All, Thanks for your suggestions. > Hi Liviu, > > On Wed, 18 Sep 2019 at 13:04, Liviu Dudau wrote: > > On Wed, Sep 18, 2019 at 09:49:40AM +0100, Daniel Stone wrote: > > > I totally agree. Framebuffers aren't about the underlying

Re: [PATCH v2] drm/ioctl: Add a ioctl to label GEM objects

2019-09-19 Thread Thomas Zimmermann
Hi Am 19.09.19 um 14:53 schrieb Rohan Garg: > DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it > easier to debug issues in userspace applications. > > Changes in v2: > - Hoist the IOCTL up into the drm_driver framework > > Signed-off-by: Rohan Garg > --- >

  1   2   >