Re: [PATCH] fbtft: add tearing signal detect

2021-01-25 Thread Dan Carpenter
On Sun, Jan 24, 2021 at 11:35:37PM +0800, Carlis wrote: > +static irqreturn_t spi_panel_te_handler(int irq, void *data) > +{ > + complete(_panel_te); > + return IRQ_HANDLED; > +} > + > +static void enable_spi_panel_te_irq(struct fbtft_par *par, bool enable) It quite confused me that

Re: [PATCH] drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources()

2021-01-25 Thread Dan Carpenter
On Mon, Jan 25, 2021 at 07:13:43PM +, Zack Rusin wrote: > > > > On Jan 25, 2021, at 03:45, Dan Carpenter wrote: > > > > The devm_memremap() function never returns NULL, it returns error > > pointers so the test needs to be fixed. Also we need to call > > pci_release_regions() to avoid a

Re: [PATCH] drm/i915/gvt: fix uninitialized return in intel_gvt_update_reg_whitelist()

2021-01-25 Thread Zhenyu Wang
On 2021.01.25 09:44:53 +, Chris Wilson wrote: > Quoting Dan Carpenter (2021-01-25 08:48:30) > > Smatch found an uninitialized variable bug in this code: > > > > drivers/gpu/drm/i915/gvt/cmd_parser.c:3191 > > intel_gvt_update_reg_whitelist() > > error: uninitialized symbol 'ret'. > >

[Bug 201957] amdgpu: ring gfx timeout

2021-01-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #44 from MajorGonzo (majorgo...@juno.com) --- Here's another thing I tried which also may have made a difference. Gonna sound weird, but worth a try. I had a 675VA UPS that my system was plugged into. One time, it started shrieking

Re: [PATCH v5 00/21] Host1x/TegraDRM UAPI

2021-01-25 Thread Mikko Perttunen
On 1/20/21 12:29 AM, Dmitry Osipenko wrote: 11.01.2021 15:59, Mikko Perttunen пишет: Hi all, here's the fifth revision of the Host1x/TegraDRM UAPI proposal, containing primarily small bug fixes. It has also been rebased on top of recent linux-next. vaapi-tegra-driver has been updated to

[PATCH v11 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-25 Thread Nicolas Boichat
Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso Reviewed-by: Steven Price --- Changes in v11: None Changes in v10: None Changes in v9: None Changes in v8: None Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts,

[PATCH v11 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-25 Thread Nicolas Boichat
GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling for devfreq, for 2 reasons: 1. The opp core (drivers/opp/core.c:_generic_set_opp_regulator) does not support multiple regulators, so we'll need custom handlers. 2. Generally, platforms

[PATCH v11 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-25 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat --- Changes in v11: - binding: power-domain-names not power-domainS-names Changes in v10: - Fix the binding to make sure sram-supply property can be provided. Changes in v9:

[PATCH v11 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-25 Thread Nicolas Boichat
Hi! Follow-up on the v5 [1], things have gotten significantly better in the last 9 months, thanks to the efforts on Bifrost support by the Collabora team (and probably others I'm not aware of). I've been testing this series on a MT8183/kukui device, with a chromeos-5.10 kernel [2], and got basic

[RFC v2 5/5] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau

2021-01-25 Thread Lyude Paul
This adds support for controlling panel backlights over eDP using VESA's standard backlight control interface. Luckily, Nvidia was cool enough to never come up with their own proprietary backlight control interface (at least, not any that I or the laptop manufacturers I've talked to are aware of),

[RFC v2 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-01-25 Thread Lyude Paul
Since we're about to implement eDP backlight support in nouveau using the standard protocol from VESA, we might as well just take the code that's already written for this and move it into a set of shared DRM helpers. Note that these helpers are intended to handle DPCD related backlight control

[RFC v2 3/5] drm/i915/dp: Remove redundant AUX backlight frequency calculations

2021-01-25 Thread Lyude Paul
Noticed this while moving all of the VESA backlight code in i915 over to DRM helpers: it would appear that we calculate the frequency value we want to write to DP_EDP_BACKLIGHT_FREQ_SET twice even though this value never actually changes during runtime. So, let's simplify things by just caching

[RFC v2 1/5] drm/nouveau/kms/nv40-/backlight: Assign prop type once

2021-01-25 Thread Lyude Paul
Signed-off-by: Lyude Paul Cc: Jani Nikula Cc: Dave Airlie Cc: greg.depo...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c

[RFC v2 2/5] drm/nouveau/kms: Don't probe eDP connectors more then once

2021-01-25 Thread Lyude Paul
eDP doesn't do hotplugging, so there's no reason for us to reprobe it (unless a connection status change is being forced, of course). Signed-off-by: Lyude Paul Cc: Jani Nikula Cc: Dave Airlie Cc: greg.depo...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_connector.c | 6 ++ 1 file

[RFC v2 0/5] drm: Extract DPCD backlight helpers from i915, add support in nouveau

2021-01-25 Thread Lyude Paul
This series: * Cleans up i915's DPCD backlight code a little bit * Extracts i915's DPCD backlight code into a set of shared DRM helpers * Starts using those helpers in nouveau to add support to nouveau for DPCD backlight control v2 series-wide changes: * Rebase Cc: Jani Nikula Cc: Dave Airlie

Re: [RFC 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-01-25 Thread Lyude Paul
On Fri, 2020-12-11 at 17:01 +0200, Jani Nikula wrote: > On Wed, 09 Dec 2020, Lyude Paul wrote: > > Since we're about to implement eDP backlight support in nouveau using the > > standard protocol from VESA, we might as well just take the code that's > > already written for this and move it into a

[Bug 201957] amdgpu: ring gfx timeout

2021-01-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #43 from Randune (randyk...@gmail.com) --- (In reply to Panagiotis Polychronis from comment #41) > (In reply to j.cordoba from comment #40) > > (In reply to Randune from comment #39) > > > There doesn't appear to be any progress on

Re: [PATCH 2/2] dt-bindings: display: Document BOE BF060Y8M-AJ0 panel compatible

2021-01-25 Thread Rob Herring
On Thu, 14 Jan 2021 18:50:24 +0100, AngeloGioacchino Del Regno wrote: > Document the boe,bf060y8m-aj0 panel. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../display/panel/boe,bf060y8m-aj0.yaml | 67 +++ > 1 file changed, 67 insertions(+) > create mode 100644

Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-01-25 Thread Fabio Estevam
Hi Oliver, On Mon, Jan 25, 2021 at 6:29 PM Oliver Graute wrote: > Ok I fixed the pin conflict with regulator-gpio and added a 5V > regulator node in my dts file. Now the display is working fine! That's good news :-) > I'll post the dts files soon and check if there is something to > improve

Re: [PATCH v2 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding

2021-01-25 Thread Rob Herring
On Thu, Jan 14, 2021 at 05:22:09PM +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB). > > Signed-off-by: Liu Ying > --- > v1->v2: > * Use graph schema. (Laurent) > * Side note i.MX8qxp LDB official name 'pixel mapper'. (Laurent) > >

Re: [PATCH v2 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding

2021-01-25 Thread Rob Herring
On Thu, Jan 14, 2021 at 05:22:06PM +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qxp pixel link to DPI(PXL2DPI). > > Signed-off-by: Liu Ying > --- > v1->v2: > * Use graph schema. (Laurent) > > .../display/bridge/fsl,imx8qxp-pxl2dpi.yaml| 105 > + > 1

Re: [PATCH v2 06/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-01-25 Thread Rob Herring
On Thu, 14 Jan 2021 17:22:04 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp display pixel link. > > Signed-off-by: Liu Ying > --- > v1->v2: > * Use graph schema. (Laurent) > * Require all four pixel link output ports. (Laurent) > * Mention pixel link is accessed via SCU

Re: [PATCH v2 04/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-01-25 Thread Rob Herring
On Thu, 14 Jan 2021 17:22:02 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > Signed-off-by: Liu Ying > --- > v1->v2: > * Use graph schema. (Laurent) > * Use enum instead of oneOf + const for the reg property of pixel combiner > channels. (Rob) > >

Re: [PATCH V4] dt-bindings: gpu: Convert v3d to json-schema

2021-01-25 Thread Rob Herring
On Wed, 13 Jan 2021 20:08:37 +0100, Stefan Wahren wrote: > This converts the v3d bindings to yaml format. > > Signed-off-by: Stefan Wahren > --- > > Changes in V4: > - define order for required reg-names > - adapt example > > Changes in V3: > - drop redundant maxItems in case we already have

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-01-25 Thread Mario Kleiner
On Mon, Jan 25, 2021 at 5:05 PM Simon Ser wrote: > ‐‐‐ Original Message ‐‐‐ > > On Monday, January 25th, 2021 at 5:00 PM, Mario Kleiner < > mario.kleiner...@gmail.com> wrote: > > > On Mon, Jan 25, 2021 at 1:14 PM Simon Ser wrote: > > > > > > This is not an uapi defintion anyway so

[PATCH rdma-core v7 0/6] Add user space dma-buf support

2021-01-25 Thread Jianxin Xiong
This is the seventh version of the patch series. Change log: v7: * Rebase to the latest rdma-core master (commit a4885eda9addc4) * Rerun kernel-headers/update against linux-rdma for-next so that the kernel commit id in the commit message is correct v6:

[PATCH rdma-core v7 5/6] tests: Add tests for dma-buf based memory regions

2021-01-25 Thread Jianxin Xiong
Define a set of unit tests similar to regular MR tests and a set of tests for send/recv and rdma traffic using dma-buf MRs. Add a utility function to generate access flags for dma-buf based MRs because the set of supported flags is smaller. Signed-off-by: Jianxin Xiong --- tests/args_parser.py

[PATCH rdma-core v7 3/6] mlx5: Support dma-buf based memory region

2021-01-25 Thread Jianxin Xiong
Implement the new provider method for registering dma-buf based memory regions. Signed-off-by: Jianxin Xiong --- providers/mlx5/mlx5.c | 2 ++ providers/mlx5/mlx5.h | 3 +++ providers/mlx5/verbs.c | 22 ++ 3 files changed, 27 insertions(+) diff --git

[PATCH rdma-core v7 4/6] pyverbs: Add dma-buf based MR support

2021-01-25 Thread Jianxin Xiong
Define a new sub-class of 'MR' that uses dma-buf object for the memory region. Define a new class 'DmaBuf' as a wrapper for dma-buf allocation mechanism implemented in C. Update the cmake function for cython modules to allow building modules with mixed cython and c source files. Signed-off-by:

[PATCH rdma-core v7 1/6] Update kernel headers

2021-01-25 Thread Jianxin Xiong
To commit bfe0cc6eb249 ("RDMA/uverbs: Add uverbs command for dma-buf based MR registration"). Signed-off-by: Jianxin Xiong --- kernel-headers/rdma/ib_user_ioctl_cmds.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/kernel-headers/rdma/ib_user_ioctl_cmds.h

[PATCH rdma-core v7 6/6] tests: Bug fix for get_access_flags()

2021-01-25 Thread Jianxin Xiong
The filter definition is wrong and causes get_access_flags() always returning empty list. As the result the MR tests using this function are effectively skipped (but report success). Signed-off-by: Jianxin Xiong --- tests/utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH rdma-core v7 2/6] verbs: Support dma-buf based memory region

2021-01-25 Thread Jianxin Xiong
Add new API function and new provider method for registering dma-buf based memory region. Update the man page and bump the API version. Signed-off-by: Jianxin Xiong --- debian/libibverbs1.symbols | 2 ++ libibverbs/CMakeLists.txt| 2 +- libibverbs/cmd_mr.c | 38

Re: [PATCH 22/24] dt-bindings: memory: mediatek: update mediatek, smi-larb.yaml references

2021-01-25 Thread Rob Herring
On Wed, 13 Jan 2021 11:59:23 +0100, Mauro Carvalho Chehab wrote: > Changeset 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT > schema") > renamed: > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > to: >

Re: [PATCH 21/24] dt-bindings: display: mediatek: update mediatek, dpi.yaml reference

2021-01-25 Thread Rob Herring
On Wed, 13 Jan 2021 11:59:22 +0100, Mauro Carvalho Chehab wrote: > Changeset 9273cf7d3942 ("dt-bindings: display: mediatek: convert the dpi > bindings to yaml") > renamed: Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > to:

Re: [PATCH 20/24] ASoC: audio-graph-card: update audio-graph-card.yaml reference

2021-01-25 Thread Rob Herring
On Wed, 13 Jan 2021 11:59:21 +0100, Mauro Carvalho Chehab wrote: > Changeset 97198614f6c3 ("ASoC: audio-graph-card: switch to yaml base > Documentation") > renamed: Documentation/devicetree/bindings/sound/audio-graph-card.txt > to: Documentation/devicetree/bindings/sound/audio-graph-card.yaml. >

Re: [PATCH v10 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-25 Thread Rob Herring
On Wed, 13 Jan 2021 14:07:00 +0800, Nicolas Boichat wrote: > Define a compatible string for the Mali Bifrost GPU found in > Mediatek's MT8183 SoCs. > > Signed-off-by: Nicolas Boichat > --- > > Changes in v10: > - Fix the binding to make sure sram-supply property can be provided. > > Changes

Re: [PATCH 2/2] drm/amd/display: Fix HDMI deep color output for DCE 6-11.

2021-01-25 Thread Mario Kleiner
Thanks Alex and Nicholas! Brings quite a bit of extra shiny to those older asics :) Nicholas, any thoughts on my cover-letter wrt. why a similar patch (that I wrote and tested to no good or bad effect) not seem to be needed on DCN, and probably not DCE-11.2+ either? Is what is left in DC for

Re: [PATCH 1/2] drm/dp/mst: Export drm_dp_get_vc_payload_bw()

2021-01-25 Thread Lyude Paul
On Mon, 2021-01-25 at 19:36 +0200, Imre Deak wrote: > This function will be needed by the next patch where the driver > calculates the BW based on driver specific parameters, so export it. > > At the same time sanitize the function params, passing the more natural > link rate instead of the

Re: [PATCH 2/2] drm/amd/display: Fix HDMI deep color output for DCE 6-11.

2021-01-25 Thread Kazlauskas, Nicholas
On 2021-01-25 12:57 p.m., Alex Deucher wrote: On Thu, Jan 21, 2021 at 1:17 AM Mario Kleiner wrote: This fixes corrupted display output in HDMI deep color 10/12 bpc mode at least as observed on AMD Mullins, DCE-8.3. It will hopefully also provide fixes for other DCE's up to DCE-11, assuming

Re: [PATCH] drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources()

2021-01-25 Thread Zack Rusin
> On Jan 25, 2021, at 03:45, Dan Carpenter wrote: > > The devm_memremap() function never returns NULL, it returns error > pointers so the test needs to be fixed. Also we need to call > pci_release_regions() to avoid a memory leak. > > Fixes: be4f77ac6884 ("drm/vmwgfx: Cleanup fifo mmio

[PATCH 5.10 029/199] drm/syncobj: Fix use-after-free

2021-01-25 Thread Greg Kroah-Hartman
From: Daniel Vetter commit a37eef63bc9e16e06361b539e528058146af80ab upstream. While reviewing Christian's annotation patch I noticed that we have a user-after-free for the WAIT_FOR_SUBMIT case: We drop the syncobj reference before we've completed the waiting. Of course usually there's nothing

[PATCH 5.4 16/86] drm/syncobj: Fix use-after-free

2021-01-25 Thread Greg Kroah-Hartman
From: Daniel Vetter commit a37eef63bc9e16e06361b539e528058146af80ab upstream. While reviewing Christian's annotation patch I noticed that we have a user-after-free for the WAIT_FOR_SUBMIT case: We drop the syncobj reference before we've completed the waiting. Of course usually there's nothing

Re: [PATCH] drm/simple-kms: Drop drm_simple_kms_format_mod_supported.

2021-01-25 Thread Mario Kleiner
On Mon, Jan 25, 2021 at 5:34 PM Ville Syrjälä wrote: > On Mon, Jan 25, 2021 at 04:32:48PM +0100, Mario Kleiner wrote: > > On Mon, Jan 25, 2021 at 1:13 PM Ville Syrjälä < > ville.syrj...@linux.intel.com> > > wrote: > > > > > On Sun, Jan 24, 2021 at 09:47:48PM +0100, Mario Kleiner wrote: > > > >

Re: [PATCH 2/2] drm/amd/display: Fix HDMI deep color output for DCE 6-11.

2021-01-25 Thread Alex Deucher
On Thu, Jan 21, 2021 at 1:17 AM Mario Kleiner wrote: > > This fixes corrupted display output in HDMI deep color > 10/12 bpc mode at least as observed on AMD Mullins, DCE-8.3. > > It will hopefully also provide fixes for other DCE's up to > DCE-11, assuming those will need similar fixes, but i

[PATCH 1/2] drm/dp/mst: Export drm_dp_get_vc_payload_bw()

2021-01-25 Thread Imre Deak
This function will be needed by the next patch where the driver calculates the BW based on driver specific parameters, so export it. At the same time sanitize the function params, passing the more natural link rate instead of the encoding of the same rate. Cc: Lyude Paul Cc: Ville Syrjala Cc:

Re: [PATCH] drm/etnaviv: fix NULL check before some freeing functions is not needed

2021-01-25 Thread Lucas Stach
Am Montag, dem 25.01.2021 um 11:27 +0800 schrieb Tian Tao: > fixed the below warning: > drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING: NULL check > before some freeing functions is not needed. Thanks, I've added this patch to my etnaviv/next branch. Regards, Lucas > Signed-off-by:

Re: [PATCH] drm/etnaviv: dump: fix sparse warnings

2021-01-25 Thread Lucas Stach
Am Mittwoch, dem 23.12.2020 um 20:51 +0100 schrieb Marc Kleine-Budde: > This patch fixes the following sparse warnings, by adding the missing > endianess > conversion functions. > > > etnaviv/etnaviv_dump.c:78:26: warning: restricted __le32 degrades to integer > > etnaviv/etnaviv_dump.c:88:26:

Re: [PATCH] drm/etnaviv: provide more ID values via GET_PARAM ioctl.

2021-01-25 Thread Lucas Stach
Am Mittwoch, dem 16.12.2020 um 12:42 +0100 schrieb Christian Gmeiner: > Make it possible for the user space to access these ID values. Thanks, I've added this patch to my etnaviv/next branch. Regards, Lucas > Signed-off-by: Christian Gmeiner > --- >  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12

Re: [PATCH] drm/simple-kms: Drop drm_simple_kms_format_mod_supported.

2021-01-25 Thread Ville Syrjälä
On Mon, Jan 25, 2021 at 04:32:48PM +0100, Mario Kleiner wrote: > On Mon, Jan 25, 2021 at 1:13 PM Ville Syrjälä > wrote: > > > On Sun, Jan 24, 2021 at 09:47:48PM +0100, Mario Kleiner wrote: > > > The check was introduced to make sure that only the > > > DRM_FORMAT_MOD_LINEAR modifier is accepted

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-01-25 Thread Simon Ser
On Monday, January 25th, 2021 at 5:08 PM, Mario Kleiner wrote: > In some way it would even be nice to have all that info exposed in > parsed form as a connector property or such, so all clients can use > the same parsed data instead of reinventing the wheel. So far the policy has more or less

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-01-25 Thread Mario Kleiner
On Mon, Jan 25, 2021 at 1:09 PM Ville Syrjälä wrote: > On Sun, Jan 24, 2021 at 10:04:54PM +0100, Mario Kleiner wrote: > > On Sun, Jan 24, 2021 at 9:24 PM Simon Ser wrote: > > > > > On Sunday, January 24th, 2021 at 9:10 PM, Mario Kleiner < > > > mario.kleiner...@gmail.com> wrote: > > > > > > >

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-01-25 Thread Simon Ser
‐‐‐ Original Message ‐‐‐ On Monday, January 25th, 2021 at 5:00 PM, Mario Kleiner wrote: > On Mon, Jan 25, 2021 at 1:14 PM Simon Ser wrote: > > > > This is not an uapi defintion anyway so fixing should be fine. > > > > Oh, my bad, I thought this was in drm_mode.h, but it's not. Then

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-01-25 Thread Mario Kleiner
On Mon, Jan 25, 2021 at 1:14 PM Simon Ser wrote: > > This is not an uapi defintion anyway so fixing should be fine. > > Oh, my bad, I thought this was in drm_mode.h, but it's not. Then yeah > should be completely fine to fix it. > Good! The beginning of the end of a sad story ;). So i guess i

[PATCH 1/9] drm/dp: add MSO related DPCD registers

2021-01-25 Thread Jani Nikula
Add DPCD register definitions for eDP 1.4 Multi-SST Operation. Cc: Nischal Varide Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

Re: [PATCH] amdgpu: fix clang build warning

2021-01-25 Thread Alex Deucher
On Mon, Jan 25, 2021 at 7:24 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang warns about the -mhard-float command line arguments > on architectures that do not support this: > > clang: error: argument unused during compilation: '-mhard-float' > [-Werror,-Wunused-command-line-argument]

Re: [PATCH] drm/amd/display: change license of color_table.c

2021-01-25 Thread Alex Deucher
On Mon, Jan 25, 2021 at 7:07 AM Jonathan Gray wrote: > > This still needs to be corrected. Applied. Thanks! Alex > > On Thu, Nov 19, 2020 at 01:30:41PM +1100, Jonathan Gray wrote: > > Change the license of color_table.c to match color_table.h granting > > permission to modify and distribute.

Re: [PATCH v3 1/3] dt-bindings:drm/bridge:anx7625:add HDCP support flag and swing reg

2021-01-25 Thread Rob Herring
On Mon, Jan 25, 2021 at 07:12:21PM +0800, Xin Ji wrote: > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support > flag and DP tx lane0 and lane1 swing register array define. > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 57 >

Re: [PATCH] drm/amd/display: fix unused variable warning

2021-01-25 Thread Harry Wentland
On 2021-01-25 7:48 a.m., Arnd Bergmann wrote: From: Arnd Bergmann After all users of the 'dm' warnings got hidden in an #ifdef, the compiler started warning about it being unused: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: error: unused variable 'dm'

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-01-25 Thread Geert Uytterhoeven
Hi Phillip, On Fri, Jan 22, 2021 at 8:26 PM Phillip Susi wrote: > Geert Uytterhoeven writes: > Judging from some of the comments in the code, it looks like you were > one of the original authors of fbcon? I haven't been able to find any Indeed, a long time ago... Before DRM existed. > of

Re: [PATCH] drm/simple-kms: Drop drm_simple_kms_format_mod_supported.

2021-01-25 Thread Mario Kleiner
On Mon, Jan 25, 2021 at 1:13 PM Ville Syrjälä wrote: > On Sun, Jan 24, 2021 at 09:47:48PM +0100, Mario Kleiner wrote: > > The check was introduced to make sure that only the > > DRM_FORMAT_MOD_LINEAR modifier is accepted by tinydrm. > > > > However, if .format_mod_supported is not hooked up to >

Re: [PATCH v4 01/14] drm/ttm: Remap all page faults to per process dummy page.

2021-01-25 Thread Andrey Grodzovsky
On 1/19/21 8:56 AM, Daniel Vetter wrote: On Mon, Jan 18, 2021 at 04:01:10PM -0500, Andrey Grodzovsky wrote: On device removal reroute all CPU mappings to dummy page. v3: Remove loop to find DRM file and instead access it by vma->vm_file->private_data. Move dummy page installation into a

Re: [PATCH][next] drm/amdgpu: Fix masking binary not operator on two mask operations

2021-01-25 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Jan 24, 2021 at 11:36 PM Huang Rui wrote: > > On Fri, Jan 22, 2021 at 11:00:22PM +0800, Colin King wrote: > > From: Colin Ian King > > > > Currently the ! operator is incorrectly being used to flip bits on > > mask values. Fix this by using the bit-wise ~

Re: [PATCH v3 1/3] dt-bindings:drm/bridge:anx7625:add HDCP support flag and swing reg

2021-01-25 Thread Rob Herring
On Mon, 25 Jan 2021 19:12:21 +0800, Xin Ji wrote: > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support > flag and DP tx lane0 and lane1 swing register array define. > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 57 >

Re: [PATCH v6 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-25 Thread Laurentiu Palcu
Hi Liu Ying, Just some minor comments below. On Thu, Jan 21, 2021 at 03:14:22PM +0800, Liu Ying wrote: > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM support. > > DPU is comprised of two main components that include a blit engine for > 2D graphics accelerations(with

[PATCH 2/3] drm/ttm: move memory accounting into vmwgfx

2021-01-25 Thread Christian König
This is just another feature which is only used by VMWGFX, so move it into the driver instead. I've tried to add the accounting sysfs file to the kobject of the drm minor, but I'm not 100% sure if this works as expected. Signed-off-by: Christian König ---

[PATCH 3/3] drm/ttm: drop sysfs directory

2021-01-25 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_module.c | 50 drivers/gpu/drm/ttm/ttm_module.h | 2 -- 2 files changed, 52 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c index

[PATCH 1/3] drm/ttm: rework ttm_tt page limit v3

2021-01-25 Thread Christian König
TTM implements a rather extensive accounting of allocated memory. There are two reasons for this: 1. It tries to block userspace allocating a huge number of very small BOs without accounting for the kmalloced memory. 2. Make sure we don't over allocate and run into an OOM situation during

Re: [PATCH] drm/amd/display: use div_s64() for 64-bit division

2021-01-25 Thread Arnd Bergmann
On Mon, Jan 25, 2021 at 1:51 PM Chen, Guchun wrote: > > [AMD Public Use] > > Hi Arnd Bergmann, > > Thanks for your patch. This link error during compile has been fixed by below > commit and been submitted to drm-next branch already. > > 5da047444e82 drm/amd/display: fix 64-bit division issue on

Re: [PATCH] i915: Fix DRM_I915_WERROR dependencies

2021-01-25 Thread Arnd Bergmann
On Mon, Jan 25, 2021 at 1:33 PM Chris Wilson wrote: > > Quoting Arnd Bergmann (2021-01-25 12:26:44) > > From: Arnd Bergmann > > > > CONFIG_DRM_I915_DEBUG now selects CONFIG_DRM_I915_WERROR, but fails > > to honor its dependencies: > > > > WARNING: unmet direct dependencies detected for

RE: [PATCH] drm/amd/display: use div_s64() for 64-bit division

2021-01-25 Thread Chen, Guchun
[AMD Public Use] Hi Arnd Bergmann, Thanks for your patch. This link error during compile has been fixed by below commit and been submitted to drm-next branch already. 5da047444e82 drm/amd/display: fix 64-bit division issue on 32-bit OS Regards, Guchun -Original Message- From: amd-gfx

[PATCH] drm/amd/display: fix unused variable warning

2021-01-25 Thread Arnd Bergmann
From: Arnd Bergmann After all users of the 'dm' warnings got hidden in an #ifdef, the compiler started warning about it being unused: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: error: unused variable 'dm' [-Werror,-Wunused-variable] Add another such #ifdef. Fixes:

Re: [PATCH] drm/i915/gem: fix non-SMP build failure

2021-01-25 Thread Chris Wilson
Quoting Arnd Bergmann (2021-01-25 12:25:34) > From: Arnd Bergmann > > The x86-specific wbinvd_on_all_cpus() function is exported > through asm/smp.h, causing a build failure in the i915 driver > when SMP is disabled: > > drivers/gpu/drm/i915/i915_gem.c:1182:2: error: implicit declaration of >

Re: [PATCH] i915: Fix DRM_I915_WERROR dependencies

2021-01-25 Thread Chris Wilson
Quoting Arnd Bergmann (2021-01-25 12:26:44) > From: Arnd Bergmann > > CONFIG_DRM_I915_DEBUG now selects CONFIG_DRM_I915_WERROR, but fails > to honor its dependencies: > > WARNING: unmet direct dependencies detected for DRM_I915_WERROR > Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] &&

[PATCH] i915: Fix DRM_I915_WERROR dependencies

2021-01-25 Thread Arnd Bergmann
From: Arnd Bergmann CONFIG_DRM_I915_DEBUG now selects CONFIG_DRM_I915_WERROR, but fails to honor its dependencies: WARNING: unmet direct dependencies detected for DRM_I915_WERROR Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y] Selected by [m]: -

[PATCH] drm/i915/gem: fix non-SMP build failure

2021-01-25 Thread Arnd Bergmann
From: Arnd Bergmann The x86-specific wbinvd_on_all_cpus() function is exported through asm/smp.h, causing a build failure in the i915 driver when SMP is disabled: drivers/gpu/drm/i915/i915_gem.c:1182:2: error: implicit declaration of function 'wbinvd_on_all_cpus'

[PATCH] amdgpu: fix clang build warning

2021-01-25 Thread Arnd Bergmann
From: Arnd Bergmann clang warns about the -mhard-float command line arguments on architectures that do not support this: clang: error: argument unused during compilation: '-mhard-float' [-Werror,-Wunused-command-line-argument] Move this into the gcc-specific arguments. Fixes: e77165bf7b02

Re: [PATCH 2/2] drm/dp_mst: Align mst link rate with soure rate

2021-01-25 Thread Ville Syrjälä
On Wed, Jan 13, 2021 at 01:51:00PM +0200, Jani Nikula wrote: > On Wed, 13 Jan 2021, Koba Ko wrote: > > After read the link rate from MST hub, align with > > maximum source rate. > > > > Signed-off-by: Koba Ko > > --- > > drivers/gpu/drm/drm_dp_mst_topology.c | 8 > >

Re: [PATCH v3 2/4] drm/qxl: unpin release objects

2021-01-25 Thread Gerd Hoffmann
> > Just calling ttm_bo_unpin() here makes lockdep unhappy. > > How does that one splat? But yeah if that's a problem should be > explained in the comment. I'd then also only do a pin_count--; to make > sure you can still catch other pin leaks if you have them. Setting it > to 0 kinda defeats the

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-01-25 Thread Simon Ser
> This is not an uapi defintion anyway so fixing should be fine. Oh, my bad, I thought this was in drm_mode.h, but it's not. Then yeah should be completely fine to fix it. ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH] drm/simple-kms: Drop drm_simple_kms_format_mod_supported.

2021-01-25 Thread Ville Syrjälä
On Sun, Jan 24, 2021 at 09:47:48PM +0100, Mario Kleiner wrote: > The check was introduced to make sure that only the > DRM_FORMAT_MOD_LINEAR modifier is accepted by tinydrm. > > However, if .format_mod_supported is not hooked up to > drm_simple_kms_format_mod_supported then the core will > simply

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-01-25 Thread Ville Syrjälä
On Sun, Jan 24, 2021 at 10:04:54PM +0100, Mario Kleiner wrote: > On Sun, Jan 24, 2021 at 9:24 PM Simon Ser wrote: > > > On Sunday, January 24th, 2021 at 9:10 PM, Mario Kleiner < > > mario.kleiner...@gmail.com> wrote: > > > > > But it still needs to be fixed if we want working HDR. I thought > >

Re: [PATCH] drm/amd/display: change license of color_table.c

2021-01-25 Thread Jonathan Gray
This still needs to be corrected. On Thu, Nov 19, 2020 at 01:30:41PM +1100, Jonathan Gray wrote: > Change the license of color_table.c to match color_table.h granting > permission to modify and distribute. > > Signed-off-by: Jonathan Gray > --- > .../amd/display/modules/color/color_table.c |

Re: [PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-25 Thread Ville Syrjälä
On Mon, Jan 25, 2021 at 11:52:18AM +0100, Maxime Ripard wrote: > Hi Ville, > > On Fri, Jan 22, 2021 at 02:15:07PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 21, 2021 at 05:35:33PM +0100, Maxime Ripard wrote: > > > Some drivers are storing the plane->state pointer in atomic_update and > > >

[PATCH] drm/amd/display: use div_s64() for 64-bit division

2021-01-25 Thread Arnd Bergmann
From: Arnd Bergmann The open-coded 64-bit division causes a link error on 32-bit machines: ERROR: modpost: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Use the div_s64() to perform the division here.

RE: [PATCH][next] drm/i915/hdcp: Fix return of value in uninitialized variable ret

2021-01-25 Thread Gupta, Anshuman
It is already merged to drm-intel-next https://cgit.freedesktop.org/drm/drm-intel/commit/?h=drm-intel-next=40a6cead28f841ac350bd38dd7260ecacd5eab03 > -Original Message- > From: Jani Nikula > Sent: Friday, January 22, 2021 8:51 PM > To: Colin King ; Joonas Lahtinen > ; Vivi, Rodrigo ; >

Re: [PATCH] drm/i915/gvt: fix uninitialized return in intel_gvt_update_reg_whitelist()

2021-01-25 Thread Chris Wilson
Quoting Dan Carpenter (2021-01-25 08:48:30) > Smatch found an uninitialized variable bug in this code: > > drivers/gpu/drm/i915/gvt/cmd_parser.c:3191 > intel_gvt_update_reg_whitelist() > error: uninitialized symbol 'ret'. > > The first thing that Smatch complains about is that "ret"

Re: [PATCH v2] fbtft: add tearing signal detect

2021-01-25 Thread Greg KH
On Mon, Jan 25, 2021 at 04:44:12PM +0800, Carlis wrote: > From: "carlis.zhang_cp" I need a "real" name here, and in the signed-off-by: area as I do not think you sign documents with a "." and "_", right? thanks, greg k-h ___ dri-devel mailing list

[PATCH] drm/i915/gvt: fix uninitialized return in intel_gvt_update_reg_whitelist()

2021-01-25 Thread Dan Carpenter
Smatch found an uninitialized variable bug in this code: drivers/gpu/drm/i915/gvt/cmd_parser.c:3191 intel_gvt_update_reg_whitelist() error: uninitialized symbol 'ret'. The first thing that Smatch complains about is that "ret" isn't set if we don't enter the "for_each_engine(engine,

[PATCH] drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources()

2021-01-25 Thread Dan Carpenter
The devm_memremap() function never returns NULL, it returns error pointers so the test needs to be fixed. Also we need to call pci_release_regions() to avoid a memory leak. Fixes: be4f77ac6884 ("drm/vmwgfx: Cleanup fifo mmio handling") Signed-off-by: Dan Carpenter ---

[PATCH 0/2] Add support of Lontium lt8912 MIPI to HDMI bridge

2021-01-25 Thread Adrien Grassein
Hello, this patch set adds the support of the Lontium lt8912 MIPI to HDMI bridge in the kernel. It's only support the video part, not the audio part yet since I don't have the datasheet of this component. I get the current i2c configuration from Digi and Boundary drivers. Developed using the

Re: [PATCH V2] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

2021-01-25 Thread Marek Vasut
On 12/24/20 7:18 AM, Marek Vasut wrote: The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to select input pixel data sampling edge. Add DT property "pixelclk-active", same as the one used by display timings, and configure bus flags based on this DT property. Bump ?

Re: [PATCH 2/2] drm/dp_mst: Align mst link rate with soure rate

2021-01-25 Thread Koba Ko
On Wed, Jan 13, 2021 at 7:51 PM Jani Nikula wrote: > > On Wed, 13 Jan 2021, Koba Ko wrote: > > After read the link rate from MST hub, align with > > maximum source rate. > > > > Signed-off-by: Koba Ko > > --- > > drivers/gpu/drm/drm_dp_mst_topology.c | 8 > >

[PATCH 1/2] dt-bindings: display: bridge: Add documentation for LT8912

2021-01-25 Thread Adrien Grassein
Lontium LT8912 is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein --- .../display/bridge/lontium,lt8912.yaml| 92 +++ MAINTAINERS | 5 + 2 files changed, 97 insertions(+) create mode 100644

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting

2021-01-25 Thread Xin Ji
On Sat, Jan 23, 2021 at 12:16:02AM +0800, Rob Herring wrote: > On Tue, Jan 12, 2021 at 2:57 AM Xin Ji wrote: > > > > Hi Rob Herring, thanks for the comments. > > > > On Mon, Jan 11, 2021 at 04:14:35PM -0600, Rob Herring wrote: > > > On Thu, Dec 31, 2020 at 10:21:12AM +0800, Xin Ji wrote: > > > >

Re: [PATCH v4 0/3] Generic USB Display driver

2021-01-25 Thread Lubomir Rintel
On Wed, Jan 20, 2021 at 06:00:30PM +0100, Noralf Trønnes wrote: > Hi, > > A while back I had the idea to turn a Raspberry Pi Zero into a $5 > USB to HDMI/SDTV/DSI/DPI display adapter. > > The reason for calling it 'Generic' is so anyone can make a USB > display/adapter against this driver, all

[PATCH 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

2021-01-25 Thread Adrien Grassein
Lontium Lt8912 is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein --- MAINTAINERS | 1 + drivers/gpu/drm/bridge/Kconfig | 14 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/lontium-lt8912.c | 749 4

[PATCH] drm/etnaviv: fix NULL check before some freeing functions is not needed

2021-01-25 Thread Tian Tao
fixed the below warning: drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Tian Tao --- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] fbtft: add tearing signal detect

2021-01-25 Thread Carlis
From: "carlis.zhang_cp" For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: carlis.zhang_cp --- drivers/staging/fbtft/fb_st7789v.c | 133 - drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 133 insertions(+), 1

[PATCH v2] fbtft: add tearing signal detect

2021-01-25 Thread Carlis
From: "carlis.zhang_cp" For st7789v ic,add tearing signal detect to avoid screen tearing Signed-off-by: carlis.zhang_cp --- v2:add release te gpio after irq request fail --- drivers/staging/fbtft/fb_st7789v.c | 134 - drivers/staging/fbtft/fbtft.h |

[PATCH 1/2] dt-bindings: display: bridge: Add documentation for LT8912

2021-01-25 Thread Adrien Grassein
Lontium LT8912 is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein --- .../display/bridge/lontium,lt8912.yaml| 92 +++ MAINTAINERS | 5 + 2 files changed, 97 insertions(+) create mode 100644

  1   2   >