Re: [PATCH v11 07/12] drm/mediatek: cleaning up and refine

2017-01-17 Thread CK Hu
Hi, YT: On Wed, 2017-01-11 at 14:51 +0800, YT Shen wrote: > cleaning up unused define and refine function name and variable > > Signed-off-by: shaoming chen > Signed-off-by: YT Shen Acked-by: CK Hu > --- >

[Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #13 from Dieter Nützel --- Still there. But patch works, even with latest DRI3 updates. -- You are receiving this mail because: You are the assignee for the bug.___

Re: [PATCH v11 08/12] drm/mediatek: add dsi interrupt control

2017-01-17 Thread CK Hu
Hi, YT: On Wed, 2017-01-11 at 14:51 +0800, YT Shen wrote: > From: shaoming chen > > add dsi interrupt control > > Signed-off-by: shaoming chen Acked-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 92 >

Re: [PATCH v11 09/12] drm/mediatek: add dsi transfer function

2017-01-17 Thread CK Hu
Hi, YT: On Wed, 2017-01-11 at 14:51 +0800, YT Shen wrote: > From: shaoming chen > > add dsi read/write commands for transfer function > > Signed-off-by: shaoming chen Acked-by: CK Hu > --- >

[Bug 99350] libdrm-2.4.74/xf86drmMode.c:904:15: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99350 Thierry Reding changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH 2/8] drm: malidp: Remove event_list member from struct malidp_drm

2017-01-17 Thread Liviu Dudau
This struct member managed to outlive the submission process without being removed. It is useless. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_drv.c | 2 -- drivers/gpu/drm/arm/malidp_drv.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 0/8] drm/mali-dp: Fixes for v4.11

2017-01-17 Thread Liviu Dudau
Hello, Here is the collected list of patches that I have accumulated since last December in my inbox. They are offered for review and comments before I commit them to the mali-dp tree and they get added to linux-next. Best regards, Liviu Brian Starkey (4): drm: mali-dp: Don't force source

[PATCH 6/8] drm: mali-dp: Fix transposed horizontal/vertical flip

2017-01-17 Thread Liviu Dudau
From: Brian Starkey The horizontal and vertical flip flags were the wrong way around, causing reflect-x to result in reflect-y being applied and vice-versa. Fix them. Fixes: ad49f8602fe8 ("drm/arm: Add support for Mali Display Processors") Signed-off-by: Brian Starkey

[PATCH 5/8] drm: mali-dp: Fix destination size handling when rotating

2017-01-17 Thread Liviu Dudau
From: Brian Starkey The destination rectangle provided by userspace in the CRTC_X/Y/W/H properties is already expressed as the dimensions after rotation. This means we shouldn't swap the width and height ourselves when a 90/270 degree rotation is requested, so remove the

[PATCH 4/8] drm: mali-dp: Don't force source size == crtc size

2017-01-17 Thread Liviu Dudau
From: Brian Starkey Remove the check enforcing that src_w and src_h match crtc_w and crtc_h, as this prevents rotation from working. The check was intended to disallow scaling, but drm_plane_helper_check_state() does that for us, while also taking rotation into account,

[PATCH 7/8] drm: mali-dp: fix Lx_CONTROL register fields clobber

2017-01-17 Thread Liviu Dudau
From: Mihail Atanassov When updating the rotation fields, one of the assignments zeroes out the rest of the register fields, which include settings for chroma siting, inverse gamma, AMBA AXI caching, and alpha blending. Signed-off-by: Mihail Atanassov

[PATCH 1/8] drm/arm/malidp: Fix possible dereference of NULL

2017-01-17 Thread Liviu Dudau
From: Shailendra Verma There is possible deference of NULL pointer on return of malidp_duplicate_plane_state() if kmalloc fails. Check the returned kmalloc pointer before continuing. Signed-off-by: Shailendra Verma [cleaned up the code and

[PATCH 8/8] drm: mali-dp: Rename malidp_input_format to malidp_pixel_format

2017-01-17 Thread Liviu Dudau
From: Brian Starkey We're going to use the same format list for output formats, so rename everything related to input formats to avoid confusion. Signed-off-by: Brian Starkey [touched commit message to clarify the final struct name] Signed-off-by:

[PATCH 3/8] drm: mali-dp: Check more use cases in the plane's ->atomic_check()

2017-01-17 Thread Liviu Dudau
Mali DP's plane ->atomic_check() only checks for the new state submitting frame buffers with supported pixel formats and if there is enough rotation memory for rotated planes. Add a call to drm_plane_helper_check_state() to add additional checks for plane state validity and clipping issues.

[PATCH v2] drm: Clean up the 1366x768 fixup codes

2017-01-17 Thread Takashi Iwai
This is just a cleanup, no functional change. The fixup code for 1366x768 in drm_mode_create_from_cmdline_mode() is basically a copy of the existing code in drm_edid.c. Make the latter code public so that it can be called from the former function. Signed-off-by: Takashi Iwai ---

Re: [Intel-gfx] [PATCH 06/10] drm/i915/psr: set CHICKEN_TRANS for psr2

2017-01-17 Thread Rodrigo Vivi
On Mon, Jan 16, 2017 at 2:04 AM, Jani Nikula wrote: > On Fri, 13 Jan 2017, Rodrigo Vivi wrote: >> This and all the remaining patches on this series (6,7,8 and 9) got >> merged to dinq. > > Given that this patch series was not properly sent as

Re: [PATCH v4 1/3] DRM: add help to get ELD speaker allocation

2017-01-17 Thread Mark Brown
On Tue, Jan 03, 2017 at 04:52:50PM +0100, Arnaud Pouliquen wrote: > Add helper to allow users to retrieve the speaker allocations without > knowledge of the ELD structure. You don't appear to have sent this to any of the DRM maintainers - it does need review from them. signature.asc

[PATCH 1/2] drm/vc4: Fix an integer overflow in temporary allocation layout.

2017-01-17 Thread Eric Anholt
We copy the unvalidated ioctl arguments from the user into kernel temporary memory to run the validation from, to avoid a race where the user updates the unvalidate contents in between validating them and copying them into the validated BO. However, in setting up the layout of the kernel side, we

[PATCH 2/2] drm/vc4: Return -EINVAL on the overflow checks failing.

2017-01-17 Thread Eric Anholt
By failing to set the errno, we'd continue on to trying to set up the RCL, and then oops on trying to dereference the tile_bo that binning validation should have set up. Reported-by: Ingo Molnar Signed-off-by: Eric Anholt Fixes: d5b1a78a772f ("drm/vc4: Add

Re: [PATCH] drm/vc4: Fix memory leak of the CRTC state.

2017-01-17 Thread Eric Anholt
Stefan Wahren writes: >> Hi Eric, >> >> could you please resend this patch [1], because it's still not applied in >> Linux 4.10-rc2. >> >> Thanks >> Stefan >> >> [1] - https://patchwork.kernel.org/patch/9369793/ > > ping ... It's in drm-vc4-fixes now. I just sent out

Re: [Freedreno] [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

2017-01-17 Thread Jordan Crouse
On Sat, Jan 14, 2017 at 11:20:58PM -0600, Andy Gross wrote: > + Stanimir > > On Sat, Jan 14, 2017 at 09:49:01PM -0600, Andy Gross wrote: > > On Fri, Jan 13, 2017 at 04:24:38PM -0700, Jordan Crouse wrote: > > > On Fri, Jan 13, 2017 at 11:12:41AM -0600, Andy Gross wrote: > > > > On Mon, Nov 28,

Re: [PATCH v4 0/3] Generic HDMI codec: Add channel mapping control

2017-01-17 Thread Mark Brown
On Mon, Jan 16, 2017 at 09:54:31AM +0100, Arnaud Pouliquen wrote: > Hello, > > Any comments on this patch-set? > what about the introduction of pcm new callback in DAI ops to use chmap > helpers? > Is it something reasonable, or should i come back on V1? Please don't send content free pings and

[PATCH 4/4] drm/i915: Add support for DP Video pattern compliance tests

2017-01-17 Thread Manasi Navare
The intel_dp_autotest_video_pattern() function gets invoked through the compliance test handler on a HPD short pulse if the test type is set to DP_TEST_VIDEO_PATTERN. This performs the DPCD registers reads to read the requested test pattern, video pattern resolution, frame rate and bits per color

[PATCH 2/4] drm/i915: Fixes to support DP Compliance EDID tests

2017-01-17 Thread Manasi Navare
This patch addresses a few issues from the original patch for DP Compliance EDID test support submitted by Todd Previte Video Mode requested in the EDID test handler for the EDID Read test (CTS 4.2.2.3) should be set to PREFERRED as per the CTS spec. v2: * Added read

[PATCH 0/4] Add Automation Support for DP Compliance Testing (Rev 4)

2017-01-17 Thread Manasi Navare
This series is a rebased version of the previous series: https://patchwork.freedesktop.org/series/16643/ DP 1.2 compliance testing can be acheived using DPR-120's CTS suite. This compliance unit sends a short pulse to initiate link training and video pattern generation compliance tests and sends

[PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

2017-01-17 Thread Manasi Navare
v2: * Add all the other DP Complianec TEST register defs (Jani Nikula) Cc: dri-devel@lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare

[PATCH 1/4] drm/i915: Add support for DP link training compliance

2017-01-17 Thread Manasi Navare
This patch adds support to handle automated DP compliance link training test requests. This patch has been tested with Unigraf DPR-120 DP Compliance device for testing Link Training Compliance. After we get a short pulse Compliance test request, test request values are read and hotplug uevent is

Re: [PATCH v4 1/3] DRM: add help to get ELD speaker allocation

2017-01-17 Thread Eric Anholt
Mark Brown writes: > [ Unknown signature status ] > On Tue, Jan 03, 2017 at 04:52:50PM +0100, Arnaud Pouliquen wrote: >> Add helper to allow users to retrieve the speaker allocations without >> knowledge of the ELD structure. > > You don't appear to have sent this to any of

Re: [RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from plat_data

2017-01-17 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Tuesday 17 Jan 2017 13:31:34 Neil Armstrong wrote: > Some display pipelines can only provide non-RBG input pixels to the HDMI TX > Controller, this patch takes the pixel format from the plat_data if > provided. > > Signed-off-by: Neil Armstrong

Re: [RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-17 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Tuesday 17 Jan 2017 13:31:32 Neil Armstrong wrote: > The Synopsys DesignWare HDMI TX Controller support various Transceivers > (PHY) attached to the controller, but also allows fully custom PHYs to be > connected. > > Add PHY init, disable functions in

Re: [Freedreno] [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

2017-01-17 Thread Andy Gross
On Tue, Jan 17, 2017 at 10:04:59AM -0700, Jordan Crouse wrote: > On Sat, Jan 14, 2017 at 11:20:58PM -0600, Andy Gross wrote: > > + Stanimir > > > > On Sat, Jan 14, 2017 at 09:49:01PM -0600, Andy Gross wrote: > > > On Fri, Jan 13, 2017 at 04:24:38PM -0700, Jordan Crouse wrote: > > > > On Fri, Jan

Re: [PATCH 0/3] Fix DECON_UPDATE for TV

2017-01-17 Thread Inki Dae
Hi Andrzej, 2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > This is my final fight with DECON_UPDATE issues (I hope). My two previous > patches > fixed problems on panel path, this patchset fixes also TV path. > The root cause of all evil was in incorrect DECON_CMU programming. > >

Re: [PATCH 3/4] drm/amd/display: Switch to using atomic_helper for flip.

2017-01-17 Thread Michel Dänzer
On 17/01/17 07:16 AM, Laurent Pinchart wrote: > On Monday 16 Jan 2017 10:44:57 Andrey Grodzovsky wrote: >> Change-Id: Iad3e0b9b3546e4e4dc79be9233daf4fe4dba83e0 >> Signed-off-by: Andrey Grodzovsky >> --- >> .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c| 92

Re: [PATCH] drm/exynos: use atomic helper commit

2017-01-17 Thread Inki Dae
Hi Laurent, 2017년 01월 17일 18:17에 Laurent Pinchart 이(가) 쓴 글: > Hi Inki, > > Thank you for the patch. > > On Monday 16 Jan 2017 18:13:22 Inki Dae wrote: >> This patch relpaces specific atomic commit function >> with atomic helper commit one, which also includes >> atomic_commit_tail callback for

Re: [01/26] drm/rockchip: dw-mipi-dsi: use mode from display state

2017-01-17 Thread Mark yao
On 2017年01月17日 18:38, Chris Zhong wrote: @@ -821,8 +824,6 @@ static void dw_mipi_dsi_encoder_mode_set(struct drm_encoder *encoder, struct dw_mipi_dsi *dsi = encoder_to_dsi(encoder); int ret; -dsi->mode = adjusted_mode; - I prefer to keep the original method, although

[Bug 99444] [radeonsi] The Witcher 3 [Wine] starting menu is distorted

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99444 Bug ID: 99444 Summary: [radeonsi] The Witcher 3 [Wine] starting menu is distorted Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

[Bug 99444] [radeonsi] The Witcher 3 (GOG/1.31) [Wine] starting menu is distorted

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99444 Shmerl changed: What|Removed |Added Summary|[radeonsi] The Witcher 3|[radeonsi] The Witcher 3

[Bug 99444] [radeonsi] The Witcher 3 (GOG/1.31) [Wine] starting menu is distorted

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99444 --- Comment #1 from Shmerl --- For the reference, to run the game in Wine, you need to set: [HKEY_CURRENT_USER\Software\Wine\Direct3D] "DirectDrawRenderer"="opengl" "UseGLSL"="enabled" "MaxVersionGL"=dword:00040005 And

Re: Request API: stateless VPU: the buffer mechanism and DPB management

2017-01-17 Thread ayaka
On 01/17/2017 10:59 PM, Nicolas Dufresne wrote: Le mardi 17 janvier 2017 à 20:46 +0800, herman.c...@rock-chips.com a écrit : If we move parser or part of DPB management mechanism into kernel we will face a issue as follows: One customer requires dpb management do a flush when stream occurs in

[PATCH] firmware: qcom_scm: Add set remote state API

2017-01-17 Thread Andy Gross
This patch adds a set remote state SCM API. This will be used by the Venus and GPU subsystems to set state on the remote processors. This work was based on two patch sets by Jordan Crouse and Stanimir Varbanov. Signed-off-by: Andy Gross ---

Re: [PATCH v2 0/3] Allow ASYNC flip with atomic helpers.

2017-01-17 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 01/17/2017 04:16 PM, Andrey Grodzovsky wrote: > This series is a folow-up on > https://patchwork.kernel.org/patch/9501787/ > > The first patch makes changes to atomic helpers to allow for > drives with ASYNC flip

Re: [PATCH v2 0/7] Host1x IOMMU support + VIC support

2017-01-17 Thread Mikko Perttunen
On 12/14/2016 04:11 PM, Daniel Vetter wrote: On Wed, Dec 14, 2016 at 03:32:16PM +0200, Mikko Perttunen wrote: On 14.12.2016 15:05, Daniel Vetter wrote: On Wed, Dec 14, 2016 at 02:41:28PM +0200, Mikko Perttunen wrote: On 14.12.2016 14:30, Daniel Vetter wrote: On Wed, Dec 14, 2016 at

Re: Request API: stateless VPU: the buffer mechanism and DPB management

2017-01-17 Thread Nicolas Dufresne
Le mardi 17 janvier 2017 à 20:46 +0800, herman.c...@rock-chips.com a écrit : > If we move parser or part of DPB management mechanism into kernel we > will face a issue as follows: > One customer requires dpb management do a flush when stream occurs in > order to keep output frame clean. > While

Re: [PATCH] drm/vc4: Fix memory leak of the CRTC state.

2017-01-17 Thread Stefan Wahren
> Hi Eric, > > could you please resend this patch [1], because it's still not applied in > Linux 4.10-rc2. > > Thanks > Stefan > > [1] - https://patchwork.kernel.org/patch/9369793/ ping ... ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: Request API: stateless VPU: the buffer mechanism and DPB management

2017-01-17 Thread herman.c...@rock-chips.com
Hi all, If we move parser or part of DPB management mechanism into kernel we will face a issue as follows: One customer requires dpb management do a flush when stream occurs in order to keep output frame clean. While another one requires output frame with error to keep output frame smooth. And

Re: [PATCH] drm/exynos: g2d: fix overflow of cmdlist size

2017-01-17 Thread Joonyoung Shim
Hi Tobias, On 01/17/2017 11:24 PM, Tobias Jakobi wrote: > Joonyoung Shim wrote: >> The size of cmdlist is integer type, so it can be overflowed by cmd and >> cmd_buf that has too big size. This patch will fix overflow issue as >> checking maximum size of cmd and cmd_buf. > I don't understand/see

Re: [PATCH] drm/exynos: use atomic helper commit

2017-01-17 Thread Inki Dae
2017년 01월 17일 04:08에 Gustavo Padovan 이(가) 쓴 글: > Hi Inki, > > 2017-01-16 Inki Dae : > >> This patch relpaces specific atomic commit function >> with atomic helper commit one, which also includes >> atomic_commit_tail callback for Exynos SoC becasue >> crtc devices on

Re: drm: rockchip: CONFIG_DRM_FBDEV_EMULATION will crash the HDMI down sometimes

2017-01-17 Thread Mark yao
static void vop_plane_atomic_update(struct drm_plane *plane, struct drm_plane_state *old_state) { if (WARN_ON(!vop->is_enabled)) return; The issues seems vop is not enable. but commit planes is using DRM_PLANE_COMMIT_ACTIVE_ONLY... Hi Randy Can you add some print for

[PATCH v3 09/20] drm: bridge: dw-hdmi: Create connector in the bridge attach operation

2017-01-17 Thread Laurent Pinchart
The DRM device is not guaranteed by the bridge API to be available before the attach callback. The driver performs properly at the moment as it doesn't use the drm_bridge_add() registration method. As this will be changed later, move connector creation to attach time to ensure compatibility with

[PATCH v3 11/20] drm: bridge: dw-hdmi: Remove PHY configuration resolution parameter

2017-01-17 Thread Laurent Pinchart
From: Kieran Bingham The current code hard codes the call of hdmi_phy_configure() to be 8bpp and provides extraneous error checking to verify that this hardcoded value is correct. Simplify the implementation by removing the argument. Signed-off-by:

[PATCH v3 00/20] dw-hdmi: Cleanups, fixes and updates for v4.11

2017-01-17 Thread Laurent Pinchart
Hello, This patch series contains the part of my pending dw-hdmi patches that have been successfully tested on all three supported platforms (i.MX6, RK3288 and R-Car H3) and have been reviewed without any problem being reported. All patches here have been previously posted as part of the "[PATCH

[PATCH v3 12/20] drm: bridge: dw-hdmi: Rename CONF0 SPARECTRL bit to SVSRET

2017-01-17 Thread Laurent Pinchart
The bit is documented in a Rockchip BSP as #define m_SVSRET_SIG (1 << 5) /* depend on PHY_MHL_COMB0=1 */ This is confirmed by a Renesas platform, which uses a 2.0 DWC HDMI TX as the RK3288. Rename the bit accordingly. Signed-off-by: Laurent Pinchart

[PATCH v3 04/20] drm: bridge: dw-hdmi: Embed drm_bridge in struct dw_hdmi

2017-01-17 Thread Laurent Pinchart
The drm_bridge instance is always needed, there's no point in allocating it separately. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu --- drivers/gpu/drm/bridge/dw-hdmi.c | 13 +++-- 1 file changed, 3

[PATCH v3 05/20] drm: bridge: dw-hdmi: Remove encoder field from struct dw_hdmi

2017-01-17 Thread Laurent Pinchart
The field isn't needed, remove it. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu --- drivers/gpu/drm/bridge/dw-hdmi.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH v3 07/20] drm: bridge: dw-hdmi: Move IRQ and IO resource allocation to common code

2017-01-17 Thread Laurent Pinchart
There's no need to duplicate identical code in multiple drivers (two at the moment, one more to come soon). Move it to the dw-hdmi core where it can be shared. If resource allocation ever becomes device-specific later we'll always have the option of splitting it out again. While it at pass the

[PATCH v3 08/20] drm: bridge: dw-hdmi: Reorder functions to prepare for next commit

2017-01-17 Thread Laurent Pinchart
The next commit will reference structures and functions in a way that currently requires forward declarations. Reorder the functions to avoid that. No functional change to the code is performed. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu

[PATCH v3 01/20] drm: bridge: dw-hdmi: Merge __hdmi_phy_i2c_write and hdmi_phy_i2c_write

2017-01-17 Thread Laurent Pinchart
The latter is just an int wrapper around the former void function that unconditionally returns 0. As the return value is never checked, merge the two functions into one. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu ---

[PATCH v3 03/20] drm: bridge: dw-hdmi: Remove unused function parameter

2017-01-17 Thread Laurent Pinchart
From: Kieran Bingham The 'prep' parameter passed to hdmi_phy_configure() is useless. It is hardcoded as 0, and if set, simply prevents the configure function from executing. Remove it. Signed-off-by: Kieran Bingham

[PATCH v3 18/20] drm: bridge: dw-hdmi: Fix the name of the PHY reset macros

2017-01-17 Thread Laurent Pinchart
The PHY reset signal is controlled by bit PHYRSTZ in the MC_PHYRSTZ register. The signal is active low on Gen1 PHYs and active high on Gen2 PHYs. The driver toggles the signal high then low, which is correct for all currently supported platforms, but the register values macros are incorrectly

[PATCH v3 13/20] drm: bridge: dw-hdmi: Reject invalid product IDs

2017-01-17 Thread Laurent Pinchart
The DWC HDMI TX can be recognized by the two product identification registers. If the registers don't read as expect the IP will be very different than what the driver has been designed for, or will be misconfigured in a way that makes it non-operational (invalid memory address, incorrect clocks,

[PATCH v3 14/20] drm: bridge: dw-hdmi: Detect AHB audio DMA using correct register

2017-01-17 Thread Laurent Pinchart
Bit 0 in CONFIG1_ID tells whether the IP core uses an AHB slave interface for control. The correct way to identify AHB audio DMA support is through bit 1 in CONFIG3_ID. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu ---

[PATCH v3 06/20] drm: bridge: dw-hdmi: Don't forward HPD events to DRM core before attach

2017-01-17 Thread Laurent Pinchart
Hotplug events should only be forwarded to the DRM core by the interrupt handler when the bridge has been attached, otherwise the DRM device pointer will be NULL, resulting in a crash. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu

[PATCH v3 02/20] drm: bridge: dw-hdmi: Remove unneeded arguments to bind/unbind functions

2017-01-17 Thread Laurent Pinchart
The master argument isn't used. The data argument, a void pointer, is used by the bind function only where it's cast to a drm_device pointer, which can easily be obtained from the encoder argument instead. Remove them. Signed-off-by: Laurent Pinchart

[PATCH v3 15/20] drm: bridge: dw-hdmi: Handle overflow workaround based on device version

2017-01-17 Thread Laurent Pinchart
Use the device version queried at runtime instead of the device type provided through platform data to handle the overflow workaround. This will make support of other SoCs integrating the same HDMI TX controller version easier. Among the supported platforms only i.MX6DL and i.MX6Q have been

[PATCH v3 10/20] drm: bridge: dw-hdmi: Implement DRM bridge registration

2017-01-17 Thread Laurent Pinchart
As an option for drivers not based on the component framework, register the bridge with the DRM core with the DRM bridge API. Existing drivers based on dw_hdmi_bind() and dw_hdmi_unbind() are not affected as those functions are preserved with their current behaviour. Signed-off-by: Laurent

[PATCH v3 17/20] drm: bridge: dw-hdmi: Define and use macros for PHY register addresses

2017-01-17 Thread Laurent Pinchart
Replace the hardcoded register address numerical values with macros to clarify the code. This change has been tested by comparing the assembly code before and after the change. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu

[PATCH v3 19/20] drm: bridge: dw-hdmi: Assert SVSRET before resetting the PHY

2017-01-17 Thread Laurent Pinchart
According to the PHY IP core vendor, the SVSRET signal must be asserted before resetting the PHY. Tests on RK3288 and R-Car Gen3 showed no regression, the change should thus be safe. Signed-off-by: Laurent Pinchart Reviewed-by: Jose Abreu

[PATCH v3 16/20] drm: bridge: dw-hdmi: Detect PHY type at runtime

2017-01-17 Thread Laurent Pinchart
Detect the PHY type and use it to handle the PHY type-specific SVSRET signal. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/dw-hdmi.c | 68 ++-- include/drm/bridge/dw_hdmi.h | 10 ++ 2 files

[PATCH v3 20/20] dt-bindings: display: dw-hdmi: Clean up DT bindings documentation

2017-01-17 Thread Laurent Pinchart
Make it clear that the core bridge/dw_hdmi.txt document isn't a device tree binding by itself but is meant to be referenced by platform device tree bindings, and update the Rockchip and Freescale DWC HDMI TX bindings to reference it. Signed-off-by: Laurent Pinchart

[Bug 99418] DRI3 Stuttering while scrolling in Chromium/Chrome with VBLANK off

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99418 --- Comment #4 from lei.p...@gmail.com --- Created attachment 128995 --> https://bugs.freedesktop.org/attachment.cgi?id=128995=edit Xorg.1 DRI2 -- You are receiving this mail because: You are the assignee for the

[Bug 99418] DRI3 Stuttering while scrolling in Chromium/Chrome with VBLANK off

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99418 --- Comment #3 from lei.p...@gmail.com --- Created attachment 128994 --> https://bugs.freedesktop.org/attachment.cgi?id=128994=edit Xorg.0 -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 1/4] drm/atomic: Save flip flags in drm_plane_state

2017-01-17 Thread Laurent Pinchart
Hi Andrey, On Tuesday 17 Jan 2017 04:03:11 Grodzovsky, Andrey wrote: > On Monday, January 16, 2017 5:18 PM Laurent Pinchart wrote: > > On Monday 16 Jan 2017 10:44:55 Andrey Grodzovsky wrote: > > > Allows using atomic flip helpers for drivers using ASYNC flip. > > > Remove ASYNC_FLIP restriction

[Bug 99418] DRI3 Stuttering while scrolling in Chromium/Chrome with VBLANK off

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99418 --- Comment #2 from lei.p...@gmail.com --- Created attachment 128993 --> https://bugs.freedesktop.org/attachment.cgi?id=128993=edit glxinfo -- You are receiving this mail because: You are the assignee for the

Re: [PATCH] drm/exynos: use atomic helper commit

2017-01-17 Thread Laurent Pinchart
Hi Inki, Thank you for the patch. On Monday 16 Jan 2017 18:13:22 Inki Dae wrote: > This patch relpaces specific atomic commit function > with atomic helper commit one, which also includes > atomic_commit_tail callback for Exynos SoC becasue > crtc devices on Exynos SoC uses power domain device >

[Bug 99418] DRI3 Stuttering while scrolling in Chromium/Chrome with VBLANK off

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99418 --- Comment #5 from lei.p...@gmail.com --- (In reply to lei.pero from comment #2) > Created attachment 128993 [details] > glxinfo (In reply to Michel Dänzer from comment #1) > Please attach the corresponding Xorg log file and output of glxinfo.

Re: [PATCH 1/4] drm/atomic: Save flip flags in drm_plane_state

2017-01-17 Thread Ville Syrjälä
On Mon, Jan 16, 2017 at 10:44:55AM -0500, Andrey Grodzovsky wrote: > Allows using atomic flip helpers for drivers > using ASYNC flip. > Remove ASYNC_FLIP restriction in helpers and > caches the page flip flags in drm_plane_state > to be used in the low level drivers. > > Signed-off-by: Andrey

Re: [PATCH v2 11/11] drm/rockchip/dsi: fix insufficient bandwidth of some panel

2017-01-17 Thread Chris Zhong
Hi John On 01/16/2017 08:44 PM, John Keeping wrote: On Mon, 16 Jan 2017 18:08:31 +0800, Chris Zhong wrote: Set the lanes bps to 1 / 0.9 times of pclk, the margin is not enough for some panel, it will cause the screen display is not normal, so increases the badnwidth to 1 / 0.8.

Re: [05/26] drm/rockchip: dw-mipi-dsi: fix command header writes

2017-01-17 Thread Chris Zhong
same as https://patchwork.kernel.org/patch/9518417/ Tested-by: Chris Zhong Reviewed-by: Chris Zhong On 09/20/2016 01:17 AM, John Keeping wrote: In a couple of places here we use "val" for the value that is about to be written to a register but then

Re: [PATCH v2 11/11] drm/rockchip/dsi: fix insufficient bandwidth of some panel

2017-01-17 Thread John Keeping
On Tue, 17 Jan 2017 17:31:53 +0800, Chris Zhong wrote: > On 01/16/2017 08:44 PM, John Keeping wrote: > > On Mon, 16 Jan 2017 18:08:31 +0800, Chris Zhong wrote: > > > >> Set the lanes bps to 1 / 0.9 times of pclk, the margin is not enough > >> for some panel, it will cause the screen display is

[RFC/RFT PATCH 4/4] drm/bridge: dw-hdmi: Take input format from plat_data

2017-01-17 Thread Neil Armstrong
Some display pipelines can only provide non-RBG input pixels to the HDMI TX Controller, this patch takes the pixel format from the plat_data if provided. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/dw-hdmi.c | 7 +-- include/drm/bridge/dw_hdmi.h | 9

[RFC/RFT PATCH 2/4] drm/bridge: dw-hdmi: Add support for custom PHY handling

2017-01-17 Thread Neil Armstrong
The Synopsys DesignWare HDMI TX Controller support various Transceivers (PHY) attached to the controller, but also allows fully custom PHYs to be connected. Add PHY init, disable functions in plat_data to handle fully custom PHY init. Some custom PHYs also handles the HPD and RxSense separately

[RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI

2017-01-17 Thread Neil Armstrong
If the input pixel format is not RGB, the CSC must be enabled in order to provide valid pixel to DVI sinks. This patch removes the hdmi only dependency on the CSC enabling. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/dw-hdmi.c | 4 ++-- 1 file changed, 2

Re: [PATCH 2/3] drm: qxl: Open code probing sequence for qxl

2017-01-17 Thread Gabriel Krisman Bertazi
Gustavo Padovan writes: > I'm not confortable with exposing minor->type here and making qxl > the first driver to use it outside of drm core. Don't we have any other > way. > > I see that inside qxl_debugfs_add_files() we have a check for already > registered files.

[Bug 91880] Radeonsi on Grenada cards (r9 390) exceptionally unstable and poorly performing

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91880 --- Comment #147 from John Boero --- Would love to see this get pushed through. Frustrating having to manually build kernels each release. It looks like history of the Fedora kernels has this being disabled and re-enabled

Re: [PATCH 1/3] drm: qxl: Let DRM core handle connector registering

2017-01-17 Thread Gustavo Padovan
Hi Gabriel, 2017-01-12 Gabriel Krisman Bertazi : > Registering the connector explicitly right after creation is not > necessary for modesetting drivers, because drm_dev_register already takes > care of this on the core side, by calling drm_modeset_register_all. > > In

[RFC/RFT PATCH 0/4] drm/bridge: dw-hdmi: Add support for Custom PHYs

2017-01-17 Thread Neil Armstrong
The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. Thanks to Laurent Pinchart's changes, the HW report the following : Detected HDMI TX controller v2.01a with HDCP (Vendor PHY) The following differs from common PHY integration as

[RFC/RFT PATCH 1/4] drm/bridge: dw-hdmi: Switch to regmap for register access

2017-01-17 Thread Neil Armstrong
The Synopsys Designware HDMI TX Controller does not enforce register access on platforms instanciating it. The current driver supports two different types of memory-mapped flat register access, but in order to support the Amlogic Meson SoCs integration, and provide a more generic way to handle all

[Bug 99292] GPU hang in High Fidelity

2017-01-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99292 --- Comment #4 from Christoph Haag --- Someone said that with mesa with --enable-debug it runs in an assert before the gpu hang happens, so I tried it to add it to the bug report, but this did not happen for me. I get no

[PATCH v2 1/2] drm: qxl: Open code probing sequence for qxl

2017-01-17 Thread Gabriel Krisman Bertazi
This avoids using the deprecated drm_get_pci_dev() and load() hook interfaces in the qxl driver. The only tricky part is to ensure TTM debugfs initialization happens after the debugfs root node is created, which is done by moving that code into the debufs_init() hook. Tested on qemu with igt and

[PATCH v2 2/2] drm: qxl: Open code teardown function for qxl

2017-01-17 Thread Gabriel Krisman Bertazi
This avoids using the deprecated drm_put_dev() and unload() hook interfaces in the qxl driver. Signed-off-by: Gabriel Krisman Bertazi Cc: Dave Airlie Cc: Daniel Vetter Cc: Gustavo Padovan ---

Re: [patch] drm/vc4: fix a bounds check

2017-01-17 Thread Eric Anholt
Dan Carpenter writes: > We accidentally return success even if vc4_full_res_bounds_check() fails. > > Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.") > Signed-off-by: Dan Carpenter Thanks. Reviewed, added Eric's review,

Re: [01/26] drm/rockchip: dw-mipi-dsi: use mode from display state

2017-01-17 Thread Chris Zhong
On 09/20/2016 01:17 AM, John Keeping wrote: There is no need to keep a pointer to the mode around since we know it will be present in the connector state. Signed-off-by: John Keeping --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 31 --- 1 file

[PATCH 0/3] Fix DECON_UPDATE for TV

2017-01-17 Thread Andrzej Hajda
Hi Inki, This is my final fight with DECON_UPDATE issues (I hope). My two previous patches fixed problems on panel path, this patchset fixes also TV path. The root cause of all evil was in incorrect DECON_CMU programming. Now it works correctly on: - panel, - TV, - both. I have not observed (so

[PATCH 3/3] drm/exynos/decon5433: set STANDALONE_UPDATE_F on output enablement

2017-01-17 Thread Andrzej Hajda
DECON_TV requires STANDALONE_UPDATE after output enabling, otherwise it does not start. This change is neutral for DECON. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 1/3] drm/exynos/decon5433: do not disable video after reset

2017-01-17 Thread Andrzej Hajda
decon_commit is called just after reset so video is disabled anyway. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c

Re: [PATCH] drm/exynos: g2d: fix overflow of cmdlist size

2017-01-17 Thread Tobias Jakobi
Joonyoung Shim wrote: > The size of cmdlist is integer type, so it can be overflowed by cmd and > cmd_buf that has too big size. This patch will fix overflow issue as > checking maximum size of cmd and cmd_buf. I don't understand/see the issue here. Could you point out for which input of the

[PATCH 2/3] drm/exynos/decon5433: fix CMU programming

2017-01-17 Thread Andrzej Hajda
DECON_CMU register has reserved bits which should not be zeroed, otherwise IP can behave strangely and cause IOMMU faults. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 1 file changed, 4 deletions(-) diff --git

Re: [RFC/RFT PATCH 1/4] drm/bridge: dw-hdmi: Switch to regmap for register access

2017-01-17 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Tuesday 17 Jan 2017 13:31:31 Neil Armstrong wrote: > The Synopsys Designware HDMI TX Controller does not enforce register access > on platforms instanciating it. > The current driver supports two different types of memory-mapped flat > register access, but in

Re: [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI

2017-01-17 Thread Laurent Pinchart
Hi Neil, Thank you for the patch. On Tuesday 17 Jan 2017 13:31:33 Neil Armstrong wrote: > If the input pixel format is not RGB, the CSC must be enabled in order to > provide valid pixel to DVI sinks. > This patch removes the hdmi only dependency on the CSC enabling. > > Signed-off-by: Neil

Re: [PATCH v3 00/20] dw-hdmi: Cleanups, fixes and updates for v4.11

2017-01-17 Thread Archit Taneja
On 01/17/2017 01:58 PM, Laurent Pinchart wrote: Hello, This patch series contains the part of my pending dw-hdmi patches that have been successfully tested on all three supported platforms (i.MX6, RK3288 and R-Car H3) and have been reviewed without any problem being reported. All patches

  1   2   >