Re: [PATCH] drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR

2018-02-15 Thread Chris Wilson
Quoting Gustavo A. R. Silva (2018-02-15 16:09:09) > > > On 02/15/2018 03:13 AM, Jani Nikula wrote: > > On Wed, 14 Feb 2018, "Gustavo A. R. Silva" wrote: > >> Fix inconsistent IS_ERR and PTR_ERR in shrink_boom. > >> The proper pointer to use is _explode_ instead of _purge_. > >> > >> This issue w

Re: [PATCH] drm/doc: nerved -> nerfed in drm_ioctl.c

2018-02-15 Thread Daniel Stone
Hi Harry, On 15 February 2018 at 16:28, Harry Wentland wrote: > This threw me for a loop when I read the docs. I imagine this is the > intended definition: > http://www.dictionary.com/browse/nerf Yeah. I'm quite sure it was intended to be 'nerfed', but replacing it with something more cl

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-15 Thread Robin Murphy
On 15/02/18 04:17, Tomasz Figa wrote: [...] Could you elaborate on what kind of locking you are concerned about? As I explained before, the normally happening fast path would lock dev->power_lock only for the brief moment of incrementing the runtime PM usage counter. My bad, that's not even it.

Re: [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

2018-02-15 Thread Keith Packard
Jason Ekstrand writes: > It seems a little odd to me to default to opening the master node and then > fall back to the render node if it doesn't work. I suppose that's probably > ok so long as we ensure that vkGetPhysicalDeviceDisplayPropertiesKHR > returns no displays if we're on the render nod

[PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-02-15 Thread Giulio Benetti
Differently from other Lcd signals, HSYNC and VSYNC signals result inverted if their bits are cleared to 0. Invert their settings of IO_POL register. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

Re: [PATCH 2/2] drm/sun4i: Handle DRM_MODE_FLAG_**SYNC_POSITIVE correctly

2018-02-15 Thread Giulio Benetti
Hi, Il 08/02/2018 21:40, Maxime Ripard ha scritto: On Wed, Feb 07, 2018 at 01:49:59PM +0100, Giulio Benetti wrote: Hi, Il 07/02/2018 11:39, Maxime Ripard ha scritto: On Wed, Jan 24, 2018 at 08:37:28PM +0100, Giulio Benetti wrote: Also, how was it tested? This seems quite weird that we haven'

Re: [PATCH] drm/amdgpu_gem: fix error handling path in amdgpu_gem_va_update_vm

2018-02-15 Thread Gustavo A. R. Silva
On 02/15/2018 06:32 AM, Christian König wrote: Am 15.02.2018 um 06:20 schrieb Gustavo A. R. Silva: Currently, if amdgpu_vm_bo_update() fails, the returned error is being ignored. Fix this by properly checking _r_ after calling amdgpu_vm_bo_update. Also, remove redundant code just before label

Re: [PATCH] drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR

2018-02-15 Thread Gustavo A. R. Silva
On 02/15/2018 03:13 AM, Jani Nikula wrote: On Wed, 14 Feb 2018, "Gustavo A. R. Silva" wrote: Fix inconsistent IS_ERR and PTR_ERR in shrink_boom. The proper pointer to use is _explode_ instead of _purge_. This issue was detected with the help of Coccinelle. Fixes: fe215c8bc426 ("drm/i915/sel

[PATCH] gpu: ipu-v3: pre: fix device node leak in ipu_pre_lookup_by_phandle

2018-02-15 Thread Tobias Jordan
Before returning, call of_node_put() for the device node returned by of_parse_phandle(). Fixes: d2a34232580a ("gpu: ipu-v3: add driver for Prefetch Resolve Engine") Signed-off-by: Tobias Jordan --- drivers/gpu/ipu-v3/ipu-pre.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/ip

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-02-15 Thread Gustavo A. R. Silva
Hi Oded, On 02/15/2018 04:08 AM, Oded Gabbay wrote: Hi Gustavo, The patch is queued for the merge window of kernel 4.17 (opens in about 7 weeks from now). Awesome. Thanks for the info. -- Gustavo Oded On Wed, Feb 14, 2018 at 11:30 PM, Gustavo A. R. Silva wrote: Hi all, I was just wonde

[PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by_phandle

2018-02-15 Thread Tobias Jordan
Before returning, call of_node_put() for the device node returned by of_parse_phandle(). Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket") Signed-off-by: Tobias Jordan --- drivers/gpu/ipu-v3/ipu-prg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/ip

Re: [PATCH 04/10] drm: Add Plane Gamma properties

2018-02-15 Thread Harry Wentland
On 2018-02-15 12:32 AM, Daniele Castagna wrote: > From: "uma.shankar at intel.com (Uma Shankar)" > > Add plane gamma as blob property and size as a > range property. > Plane degamma & CTM make sense to me but I'm not sure why gamma would be on a per-plane basis. That said, HW sometimes has the

[PATCH] drm: mali-dp: Report underrun and axi bus errors

2018-02-15 Thread Alexandru Gheorghe
Errors will be reported in /sys/kernel/debug/tracing/trace, still not noisy enough, but better than silently ignoring them. E.g: -0 [000] d.h1 183.851864: malidp_de_irq: error occurred DE_STATUS is 0x0001 surfaceflinger-803 [000] d.h1 197.993003: malidp_de_irq: error occurred DE_ST

Re: [PATCH 01/10] drm/vblank: Data type fixes for 64-bit vblank sequences.

2018-02-15 Thread Rodrigo Vivi
Dave Airlie writes: > On 6 February 2018 at 06:32, Rodrigo Vivi wrote: >> On Sat, Feb 03, 2018 at 08:14:48AM +, Keith Packard wrote: >>> Dhinakaran Pandiyan writes: >>> >>> > From: "Pandiyan, Dhinakaran" >>> > >>> > drm_vblank_count() has an u32 type returning what is a 64-bit vblank >>>

Re: [PATCH] drm/doc: nerved -> nerfed in drm_ioctl.c

2018-02-15 Thread Harry Wentland
On 2018-02-15 11:40 AM, Daniel Stone wrote: > Hi Harry, > > On 15 February 2018 at 16:28, Harry Wentland wrote: >> This threw me for a loop when I read the docs. I imagine this is the >> intended definition: >> http://www.dictionary.com/browse/nerf > > Yeah. I'm quite sure it was intende

Re: [Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

2018-02-15 Thread Jordan Crouse
On Tue, Feb 13, 2018 at 02:18:13PM -0500, Sean Paul wrote: > Hi dri-devel, > Qualcomm has been working for the past few weeks on forward porting their > downstream drm driver from 4.14 to mainline. Please consider this PR as a > request for review, rather than an attempt at mainlining the code as i

Re: [Mesa-dev] [PATCH 07/21] vulkan: Add EXT_acquire_xlib_display

2018-02-15 Thread Keith Packard
Eric Engestrom writes: > Can be simplified a bit: > > _xlib_lease = get_option('xlib-lease') > if _xlib_lease == 'auto' > with_xlib_lease = with_platform_x11 and with_platform_display > else > with_xlib_lease = _xlib_lease == 'true' > endif > > (We also usually try to avoid changi

Re: [PATCH] drm/doc: nerved -> nerfed in drm_ioctl.c

2018-02-15 Thread Alex Deucher
On Thu, Feb 15, 2018 at 2:56 PM, Harry Wentland wrote: > On 2018-02-15 11:40 AM, Daniel Stone wrote: >> Hi Harry, >> >> On 15 February 2018 at 16:28, Harry Wentland wrote: >>> This threw me for a loop when I read the docs. I imagine this is the >>> intended definition: >>> http://www.dict

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-15 Thread Alex Deucher
On Thu, Feb 15, 2018 at 9:19 AM, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the access to the ww_mutex internals by p

[PATCH] drm/msm/dpu: Remove unused code and move the header

2018-02-15 Thread Jordan Crouse
Remove unused code from dpu_io_util.c. The functions are only used inside of the msm driver so remove the EXPORT_SYMBOL tags and move the header dpu_io_util.h from include/linux. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/dp/dp_parser.h | 2 +- drivers/gpu/drm/msm/dp

[pull] amdgpu drm-next-4.16

2018-02-15 Thread Alex Deucher
Hi Dave, Just one fix for a hybrid laptop for 4.16. The following changes since commit 94fc27ac487a80daf42f97b1a0503d029f3c1325: Merge tag 'drm-intel-next-fixes-2018-02-07' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2018-02-08 08:21:37 +1000) are available in the git repo

[Bug 105018] Kernel panic when waking up after screen goes blank.

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105018 Ainola changed: What|Removed |Added CC||b...@i--b.com --- Comment #19 from Ainola ---

[radeon-alex:amd-staging-dkms-4.13 2525/3830] drivers/staging/vboxvideo/vbox_ttm.c:392:8: error: too many arguments to function 'ttm_bo_validate'

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: 7f7a03f8049d505d450f27973d5c96af13bc8fe6 [2525/3830] drm/ttm: add operation ctx to ttm_bo_validate v2 config: i386-randconfig-a0-201806 (attached as .config) compile

[radeon-alex:amd-staging-dkms-4.13 3810/3830] drivers/gpu/drm/radeon/radeon_kfd.c:166:3: error: 'const struct kfd2kgd_calls' has no member named 'open_graphic_handle'

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: ac9c689b72b5f0fdb7bfecc427d0aa4b2a5eccf5 [3810/3830] drm/amdgpu: Remove unused definitions, functions and interfaces config: i386-randconfig-i1-201806 (attached as .

[radeon-alex:amd-staging-dkms-4.13 3177/3830] drivers/gpu/drm/radeon/radeon_kfd.c:184:2: warning: initialization from incompatible pointer type

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: c30b9ce3a991b4531329cad536b3d7681acb6108 [3177/3830] amd/amdkfd: Remove write_vmid_invalidate_request() from kfd2kgd interface config: i386-randconfig-a0-201806 (att

[radeon-alex:amd-staging-dkms-4.13 3272/3830] drivers/staging//vboxvideo/vbox_ttm.c:190:9: error: incompatible type for argument 2 of 'ttm_bo_move_memcpy'

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: d08b4d092e33c348cb01367e02e5dd2dd8104a46 [3272/3830] drm/ttm: use an ttm operation ctx for ttm_bo_move_xxx config: i386-randconfig-a0-201806 (attached as .config) co

[Bug 105046] Screen resolution reset to 1368x768 when turning monitor off

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105046 --- Comment #6 from Michael Zapf --- Created attachment 137386 --> https://bugs.freedesktop.org/attachment.cgi?id=137386&action=edit dmesg output after turning the monitor back on (2nd system) This is another dmesg output, created on my offic

[radeon-alex:amd-staging-dkms-4.13 3810/3830] drivers/gpu//drm/radeon/radeon_kfd.c:166:2: error: unknown field 'open_graphic_handle' specified in initializer

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: ac9c689b72b5f0fdb7bfecc427d0aa4b2a5eccf5 [3810/3830] drm/amdgpu: Remove unused definitions, functions and interfaces config: i386-randconfig-a0-201806 (attached as .

[radeon-alex:amd-staging-dkms-4.13 3469/3830] drivers/gpu/drm/amd/amdkfd/kfd_device.c:365:7: error: too many arguments to function 'pci_enable_atomic_ops_to_root'

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: 704c0ec9102104fba7fa522a1dac5c0f7f166a31 [3469/3830] drm/amdkcl: Update pci_enable_atomic_ops_to_root for upstreaming config: x86_64-allmodconfig (attached as .confi

[radeon-alex:amd-staging-dkms-4.13 3809/3830] drivers/gpu//drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:660:3: error: implicit declaration of function 'release_pages'; did you mean 'release_task'?

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: d3d63af4863b870bb0153c8fe24b41218d232b10 [3809/3830] drm/amdgpu: Remove unnecessary includes config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc

[radeon-alex:amd-staging-dkms-4.13 2529/3830] drivers/staging/vboxvideo/vbox_ttm.c:240:10: error: initialization from incompatible pointer type

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: 3f74ea1e32064cd589f8dd71cbb8fa4282c2 [2529/3830] drm/ttm: add context to driver move callback as well config: i386-allmodconfig (attached as .config) compiler: g

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-15 Thread Tomasz Figa
On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy wrote: > On 15/02/18 04:17, Tomasz Figa wrote: > [...] >>> >>> Could you elaborate on what kind of locking you are concerned about? >>> As I explained before, the normally happening fast path would lock >>> dev->power_lock only for the brief moment of

[radeon-alex:amd-staging-dkms-4.13 2525/3830] drivers/staging/vboxvideo/vbox_ttm.c:392:56: sparse: Using plain integer as NULL pointer

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: 7f7a03f8049d505d450f27973d5c96af13bc8fe6 [2525/3830] drm/ttm: add operation ctx to ttm_bo_validate v2 reproduce: # apt-get install sparse git checkou

[PATCH 1/2] selftests: ion: Remove some prints

2018-02-15 Thread Laura Abbott
There's no need to print messages each time we alloc and free. Remove them. Signed-off-by: Laura Abbott --- tools/testing/selftests/android/ion/ionutils.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/android/ion/ionutils.c b/tools/testing/selftests/android/i

[PATCH 2/2] selftests: ion: Add simple test with the vgem driver

2018-02-15 Thread Laura Abbott
Ion is designed to be a framework used by other clients who perform operations on the buffer. Use the DRM vgem client as a simple consumer. In conjunction with the dma-buf sync ioctls, this tests the full attach/map path for the system heap. Signed-off-by: Laura Abbott --- tools/testing/selftest

[RFC PATCH 0/2] Ion unit test with VGEM

2018-02-15 Thread Laura Abbott
Hi, Ion hasn't had much in the way of unit tests and fixing that is something that needs to happen before it can move out of staging. The difficult part of testing parts of Ion is that it relies on having a kernel driver to actually make some of the dma_buf calls. The vgem DRM driver exists mostly

Re: [RFC PULL] Add Display Support for Qualcomm SDM845

2018-02-15 Thread Rob Herring
On Tue, Feb 13, 2018 at 1:18 PM, Sean Paul wrote: > Hi dri-devel, > Qualcomm has been working for the past few weeks on forward porting their > downstream drm driver from 4.14 to mainline. Please consider this PR as a > request for review, rather than an attempt at mainlining the code as it > curr

[radeon-alex:amd-staging-dkms-4.13 3366/3830] include/drm/ttm/ttm_page_alloc.h:125:1: error: expected identifier or '(' before '{' token

2018-02-15 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-dkms-4.13 head: 7bde112fab15c0a28c1d056959167cd4393bf538 commit: ec96f6ceed1d387de0b264c59d31120c15888546 [3366/3830] drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver config: sparc64-allyesconfig (attached as .co

Re: [PATCH v5 03/12] drm/bridge/synopsys: dw-hdmi: Enable workaround for v1.32a

2018-02-15 Thread Archit Taneja
On Thursday 15 February 2018 01:38 AM, Jernej Skrabec wrote: Allwinner SoCs have dw hdmi controller v1.32a which exhibits same magenta line issue as i.MX6Q and i.MX6DL. Enable workaround for it. Tests show that one iteration is enough. Acked-by: Laurent Pinchart Reviewed-by: Archit Taneja

Re: [PATCH v5 04/12] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions

2018-02-15 Thread Archit Taneja
On Thursday 15 February 2018 01:38 AM, Jernej Skrabec wrote: Parts of PHY code could be useful also for custom PHYs. For example, Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY with few additional memory mapped registers, so most of the Synopsys PHY related code could be reus

Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

2018-02-15 Thread Archit Taneja
On Thursday 15 February 2018 01:38 AM, Jernej Skrabec wrote: dw_hdmi shouldn't set drvdata since some drivers might need to store it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi instead to store it in drvdata. This way drivers are responsible to store and pass structure wh

[git pull] drm fixes for 4.16-rc2

2018-02-15 Thread Dave Airlie
Hi Linus, One nouveau regression fix, one AMD quirk and a full set of i915 fixes. The i915 fixes are mostly for things caught by their CI system, main ones being DSI panel fixes and GEM fixes. Pretty quiet overall. Dave. The following changes since commit 7928b2cbe55b2a410a0f5c1f154610059c57b1

[Bug 104597] [bisected] Compton weird colors

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104597 --- Comment #11 from gloriouseggr...@gmail.com --- (In reply to Mario Kleiner from comment #10) > Created attachment 137087 [details] [review] > Possible fix, tested against server 1.19 branch. > > This patch fixes the problem with compton, as t

[Bug 104597] [bisected] Compton weird colors

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104597 --- Comment #12 from gloriouseggr...@gmail.com --- (In reply to Mario Kleiner from comment #5) > Can you try what happens if you add the following snippet > inside the section of your /etc/drirc and restart compton? > > > > > > The outp

Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

2018-02-15 Thread Heiko Stuebner
Am Mittwoch, 14. Februar 2018, 21:08:59 CET schrieb Jernej Skrabec: > dw_hdmi shouldn't set drvdata since some drivers might need to store > it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi > instead to store it in drvdata. This way drivers are responsible to > store and pass s

[Bug 105076] [CI] results file indicate incomplete run.log say other result

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105076 --- Comment #3 from Marta Löfstedt --- https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4258/shard-glkb1/igt@drm_vma_limiter_cached.html run.log has finished -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 105076] [CI] results file indicate incomplete run.log say other result

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105076 --- Comment #4 from Marta Löfstedt --- https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3779/shard-glkb1/igt@kms_...@pipe-b-bad-aux-stride.html -- You are receiving this mail because: You are the assignee for the bug.___

<    1   2