[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 Thomas Martitz changed: What|Removed |Added Attachment #140592|0 |1 is obsolete|

Re: [PATCH 05/13] drm: Add put callback for the coredump printer

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:22) > Add a put function for the coredump printer to bypass printf() > for constant strings for a speed boost. > > v2: Add EXPORT_SYMBOL for _drm_puts_coredump > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/drm_print.c | 43

Re: [PATCH 07/13] drm/msm/gpu: Convert the GPU show function to use the GPU state

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:24) > Convert the existing GPU show function to use the GPU state to > dump the information rather than reading it directly from the hardware. > This will require an additional step to capture the state before > dumping it for the existing nodes but it will

Re: [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 12:59:19PM -0600, Jordan Crouse wrote: > Add a drm printer suitable for use with the read callback for > devcoredump or other suitable buffer based output format that > isn't otherwise covered by seq_file. > > Signed-off-by: Jordan Crouse Hm, why not add seq_file support

[Bug 107153] 4.18-rc3 crash on hdmi (0010:dm_update_crtcs_state+0x41e/0x4a0)

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107153 --- Comment #8 from Leo Li --- Thanks for filing the ticket Patrik, can you please give the attached two patches a shot? I cp'ed them over 4.18-rc3 and they seem to fix it for me. -- You are receiving this mail because: You are the assignee

Re: [PATCH 10/13] drm/msm/adreno: Convert the show/crash file format

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 12:59:27PM -0600, Jordan Crouse wrote: > Convert the format of the 'show' debugfs file and the crash > dump to a format resembling YAML. This should be easier to > parse and be more flexible for future changes and expansions. > > Signed-off-by: Jordan Crouse > --- >

Re: [PATCH] drm/dp_helper: Add DP aux channel tracing

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 01:24:19PM -0400, Lyude Paul wrote: > This is something we've needed for a very long time now, as it makes > debugging issues with faulty MST hubs along with debugging issues > regarding us interfacing with hubs correctly vastly easier to debug. > Currently this can

Re: [PATCH 01/13] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:18) > The i915 DRM driver very cleverly used ascii85 encoding for their > GPU state file. Move the encode functions to a general header file to > support other drivers that might be interested in the same > functionality. > > v3: Fix error_puts -> err_puts

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #43 from Alex Deucher --- It's fine to have one of the patches to stop the segfault applied. that's just a symptom of the root cause: [ 54.734549] amdgpu :01:00.0: Refused to change power state, currently in D3 [ 54.810069]

[PATCH v2 19/21] dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU

2018-07-12 Thread Sean Paul
From: Jeykumar Sankaran Adds bindings for Snapdragon 845 display processing unit Changes in v2: - Use SoC specific compatibles for mdss and dpu - Use assigned-clocks to set initial clock frequency Signed-off-by: Jeykumar Sankaran Signed-off-by: Rajesh Yadav Signed-off-by: Sean Paul ---

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #44 from Thomas Martitz --- Disabling runtime pm probably result in poor battery life, right? This is a laptop with hybrid graphics afterall and the radeon should be disabled most of the time. Is there anything I can try? Like

Re: [PATCH 1/3] drm/scheduler: add a pointer to scheduler in the rq

2018-07-12 Thread Eric Anholt
Nayan Deshmukh writes: > Signed-off-by: Nayan Deshmukh > --- Acked-by: Eric Anholt signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 03/13] drm: Add drm_puts() to complement drm_printf()

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 12:59:20PM -0600, Jordan Crouse wrote: > Add drm_puts() for a much faster path to print constant strings > into a drm_printer object with memcpy and friends. This can > shave seconds off of really large outputs such as GPU dumps. > > If the drm_printer object supports a

Re: [PATCH 08/13] drm/msm/gpu: Rearrange the code that collects the task during a hang

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:25) > Do a bit of cleanup to prepare for upcoming changes to pass the > hanging task comm and cmdline to the crash dump function. > > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/msm/msm_gpu.c | 18 ++ > 1 file changed, 10

Re: [PATCH 04/13] drm: Add a -puts() function for the seq_file printer

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 12:59:21PM -0600, Jordan Crouse wrote: > Add a puts() function to use seq_puts() to help speed up > up print time for constant strings. > > Signed-off-by: Jordan Crouse Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_print.c | 6 ++ >

[PATCH v2 21/21] arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file

2018-07-12 Thread Sean Paul
DPU is short for the Display Processing Unit. It is the display controller on Qualcomm SDM845 chips. While the dts is pretty sparse for sdm845 atm, the only piece we're missing is the iommu. It's commented out for now, and should be uncommented once support is provided. Changes in v2: - Beefed

Re: [PATCH 3/3] drm/scheduler: modify args of drm_sched_entity_init

2018-07-12 Thread Eric Anholt
Nayan Deshmukh writes: > diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c > b/drivers/gpu/drm/scheduler/gpu_scheduler.c > index 3dc1a4f07e3f..b2dbd1c1ba69 100644 > --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c > +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c > @@ -162,26 +162,32 @@

[PATCH 07/13] drm/msm/gpu: Convert the GPU show function to use the GPU state

2018-07-12 Thread Jordan Crouse
Convert the existing GPU show function to use the GPU state to dump the information rather than reading it directly from the hardware. This will require an additional step to capture the state before dumping it for the existing nodes but it will greatly facilitate reusing the same code for dumping

[PATCH 12/13] drm/msm/adreno: Add a5xx specific registers for the GPU state

2018-07-12 Thread Jordan Crouse
HLSQ, SP and TP registers are only accessible from a special aperture and to make matters worse the aperture is blocked from the CPU on targets that can support secure rendering. Luckily the GPU hardware has its own purpose built register dumper that can access the registers from the aperture. Add

[PATCH 10/13] drm/msm/adreno: Convert the show/crash file format

2018-07-12 Thread Jordan Crouse
Convert the format of the 'show' debugfs file and the crash dump to a format resembling YAML. This should be easier to parse and be more flexible for future changes and expansions. Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 46

[PATCH 11/13] drm/msm/adreno: Add ringbuffer data to the GPU state

2018-07-12 Thread Jordan Crouse
Add the contents of each ringbuffer to the GPU state and dump the data in the crash file encoded with ascii85. To save space only the used portions of the ringbuffer are dumped. Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 5 +++

[PATCH 08/13] drm/msm/gpu: Rearrange the code that collects the task during a hang

2018-07-12 Thread Jordan Crouse
Do a bit of cleanup to prepare for upcoming changes to pass the hanging task comm and cmdline to the crash dump function. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gpu.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[PATCH 13/13] drm/msm/gpu: Add the buffer objects from the submit to the crash dump

2018-07-12 Thread Jordan Crouse
For hangs, dump copy out the contents of the buffer objects attached to the guilty submission and print them in the crash dump report. v2: Use %zd to print the size of the buffer correctly Signed-off-by: Jordan Crouse --- Documentation/gpu/drm-msm-crash-dump.txt | 7 +++

[PATCH 09/13] drm/msm/gpu: Capture the GPU state on a GPU hang

2018-07-12 Thread Jordan Crouse
Capture the GPU state on a GPU hang and store it for later playback via the devcoredump facility. Only one crash state is stored at a time on the assumption that the first hang is usually the most interesting. The existing crash state can be cleared after capturing it and then a new one will be

Re: [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:19) > Add a drm printer suitable for use with the read callback for > devcoredump or other suitable buffer based output format that > isn't otherwise covered by seq_file. > > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/drm_print.c | 74

[Bug 107153] 4.18-rc3 crash on hdmi (0010:dm_update_crtcs_state+0x41e/0x4a0)

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107153 --- Comment #7 from Leo Li --- Created attachment 140614 --> https://bugs.freedesktop.org/attachment.cgi?id=140614=edit Patch 2/2 -- You are receiving this mail because: You are the assignee for the

[Bug 107153] 4.18-rc3 crash on hdmi (0010:dm_update_crtcs_state+0x41e/0x4a0)

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107153 --- Comment #6 from Leo Li --- Created attachment 140613 --> https://bugs.freedesktop.org/attachment.cgi?id=140613=edit Patch 1/2 -- You are receiving this mail because: You are the assignee for the

[PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-12 Thread Jordan Crouse
Add a drm printer suitable for use with the read callback for devcoredump or other suitable buffer based output format that isn't otherwise covered by seq_file. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/drm_print.c | 74 + include/drm/drm_print.h |

[PATCH 01/13] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-07-12 Thread Jordan Crouse
The i915 DRM driver very cleverly used ascii85 encoding for their GPU state file. Move the encode functions to a general header file to support other drivers that might be interested in the same functionality. v3: Fix error_puts -> err_puts pointed out by the 01.org bot v2: Update API to be

[PATCH 04/13] drm: Add a -puts() function for the seq_file printer

2018-07-12 Thread Jordan Crouse
Add a puts() function to use seq_puts() to help speed up up print time for constant strings. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/drm_print.c | 6 ++ include/drm/drm_print.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_print.c

[PATCH 06/13] drm/msm/gpu: Capture the state of the GPU

2018-07-12 Thread Jordan Crouse
Add the infrastructure to capture the current state of the GPU and store it in memory so that it can be dumped later. For now grab the same basic ringbuffer information and registers that are provided by the debugfs 'gpu' node but obviously this should be extended to capture a much larger set of

[v7 00/13] drm/msm: Capture and dump the GPU crash state

2018-07-12 Thread Jordan Crouse
This is revision t implementing a GPU crash state for drm/msm (https://patchwork.freedesktop.org/series/36097/). This patchset fixes a few things that the build bot found. The object of this code is to store and provide enough information to debug software and hardware issues on the Adreno

[PATCH 03/13] drm: Add drm_puts() to complement drm_printf()

2018-07-12 Thread Jordan Crouse
Add drm_puts() for a much faster path to print constant strings into a drm_printer object with memcpy and friends. This can shave seconds off of really large outputs such as GPU dumps. If the drm_printer object supports a custom puts function then use that otherwise fall back to the slower legacy

[PATCH 05/13] drm: Add put callback for the coredump printer

2018-07-12 Thread Jordan Crouse
Add a put function for the coredump printer to bypass printf() for constant strings for a speed boost. v2: Add EXPORT_SYMBOL for _drm_puts_coredump Signed-off-by: Jordan Crouse --- drivers/gpu/drm/drm_print.c | 43 + include/drm/drm_print.h | 2 ++ 2

linux-next: build failure after merge of the drm-intel tree

2018-07-12 Thread Stephen Rothwell
Hi all, [Dave cc'd because this will probably turn up in the drm tree soon.] After merging the drm-intel tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/i915/gvt/kvmgt.c: In function 'gvt_dma_map_page': drivers/gpu/drm/i915/gvt/kvmgt.c:188:17: error: 'pfn'

[Bug 107213] [amdgpu/DisplayPort] KDE Wayland session is segfaulting right after login

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107213 Bug ID: 107213 Summary: [amdgpu/DisplayPort] KDE Wayland session is segfaulting right after login Product: DRI Version: unspecified Hardware: x86-64 (AMD64)

Re: [PATCH] drm/ttm: use swap macro in ttm_bo_handle_move_mem

2018-07-12 Thread Sinclair Yeh
On Mon, Jul 09, 2018 at 10:24:47AM -0500, Gustavo A. R. Silva wrote: > Make use of the swap macro and remove unnecessary variable *tmp_mem*. > This makes the code easier to read and maintain. Also, reduces the > stack usage. > > This code was detected with the help of Coccinelle. > >

[Bug 107082] With 4.18 rc kernel stop working video output on AMD GPU Vega 56

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107082 --- Comment #4 from mikhail.v.gavri...@gmail.com --- (In reply to Harry Wentland from comment #3) > Created attachment 140594 [details] [review] > [PATCH] drm/amd/display: Convert 10kHz clks from PPLib into kHz for Vega > > Don't think the

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #33 from Alex Deucher --- (In reply to Thomas Martitz from comment #21) > > I assume this is some mapped memory and some HW component in the GPU writes > to it while the CPU is using it, isn't it? If so, the proper fix would be to

[PATCH 3/3] drm/scheduler: modify args of drm_sched_entity_init

2018-07-12 Thread Nayan Deshmukh
replace run queue by a list of run queues and remove the sched arg as that is part of run queue itself Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++--

[GIT PULL] drm/tegra: Fixes for v4.18-rc5

2018-07-12 Thread Thierry Reding
Hi Dave, The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the Git repository at: git://anongit.freedesktop.org/tegra/linux tags/drm/tegra/for-4.18-rc5 for you to fetch changes up to

Re: [PATCH 0/3] drm/scheduler: preparation for load balancing

2018-07-12 Thread Christian König
Only a few more style nit picks: Patches #1 and #2 need a commit message. A one liner why we do this should be fine. On Patch #3 you have a couple of places like this: - r = drm_sched_entity_init(>sched, >mman.entity, - rq, NULL); + r =

Re: [PATCH v2] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Chris Wilson
Quoting Dominique Martinet (2018-07-12 00:24:46) > Change it to use strlcpy instead > > Signed-off-by: Dominique Martinet Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +

[PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 66

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-12 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should return a constant pointer to an array of crc sources list and update count according to the number

[PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner ---

Re: [PATCH] drm/sun4i: tcon-top: Fix return type warning

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 10:08:18AM +0200, Maxime Ripard wrote: > When commit af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling") > was merged, the error handling path of the of_property_match_string was > changed to take into account the fact that the returned value of that > function

[PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node. This will help in avoiding setting of wrong string for source. Changes since V1: - do not yet verify_crc_source during open. Signed-off-by: Mahesh Kumar Cc:

[PATCH 00/10] Improve crc-core driver interface

2018-07-12 Thread Mahesh Kumar
This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current source. - Setting of sorce will fail if provided source is not supported - cleanup

[PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-12 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst ---

[PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-12 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kumar Cc:

Re: [linux-sunxi] Re: [PATCH v2 00/18] Allwinner R40 HDMI refactoring

2018-07-12 Thread Jernej Škrabec
Dne sreda, 11. julij 2018 ob 11:30:16 CEST je Maxime Ripard napisal(a): > On Wed, Jul 11, 2018 at 10:41:54AM +0200, Jernej Škrabec wrote: > > Dne sreda, 11. julij 2018 ob 10:30:36 CEST je Maxime Ripard napisal(a): > > > On Tue, Jul 10, 2018 at 10:34:53PM +0200, Jernej Skrabec wrote: > > > > This

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-12 Thread Mark Rutland
On Mon, Jul 09, 2018 at 07:55:20PM +0200, Daniel Vetter wrote: > On Mon, Jul 9, 2018 at 6:12 PM, Mark Rutland wrote: > > On Mon, Jul 09, 2018 at 06:03:42PM +0200, Peter Zijlstra wrote: > >> On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: > >> > for_each_something(foo) > >> > if

Re: [PATCH] drm/probe-helper: Fix modes reporting for writeback connector

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 09:48:02AM +0100, Alexandru Gheorghe wrote: > Writeback connector is reported as disconnected, currently this causes > the setting of the edid property to null and then exit. > In order to properly get the modes for writeback we need to add an > exception when connector

[PATCH 0/3] drm/scheduler: preparation for load balancing

2018-07-12 Thread Nayan Deshmukh
This patch series is prepration for implementing better load balancing in the GPU scheduler. Patch #3 is the major change which modifies the drm_sched_entity_init, the driver is now expected to provide a list of potential run queue on which the jobs from this entity can be scheduled. In future

[PATCH 1/3] drm/scheduler: add a pointer to scheduler in the rq

2018-07-12 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 6 -- include/drm/gpu_scheduler.h | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index

[PATCH 2/3] drm/scheduler: add counter for total jobs in scheduler

2018-07-12 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 +++ include/drm/gpu_scheduler.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Joe Perches
On Wed, 2018-07-11 at 20:50 +0200, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: > > On 7/11/18 10:45 AM, Tejun Heo wrote: > > > On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > > > > On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > > > > >

Re: [PATCH V3 2/4] drm/vkms: Add framebuffer and plane helpers

2018-07-12 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 11:02:01PM -0300, Rodrigo Siqueira wrote: > This patch appends the minimum helpers related to framebuffer and plane > to make vkms minimally usable. > > Changes since V1: > - None > Changes since V2: > - Squash "Add plane helper struct" and "Add helper for framebuffer >

Re: [PATCH v3] drm/sun4i: mixer: Read id from DT

2018-07-12 Thread Maxime Ripard
On Wed, Jul 11, 2018 at 01:27:06PM +0200, Jernej Skrabec wrote: > Currently, TCON supports 2 ways to match TCON with engine (mixer in this > case). Old way is to just traverse of graph backwards and compare node > pointer. New way is to match TCON and engine by their respective ids. > All SoCs

Re: [PATCH] [v3] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

2018-07-12 Thread Maxime Ripard
On Wed, Jul 11, 2018 at 04:43:10PM +0200, Arnd Bergmann wrote: > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in > a link error, as we try to access a symbol from the sun8i_tcon_top.ko module: > > ERROR: "sun8i_tcon_top_of_table"

[PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 +

[PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-12 Thread Mahesh Kumar
This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source.

[PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Dominique Martinet
This is effectively no-op as the next line writes a nul at the final byte of the buffer, so copying one letter less does not change the behaviour. Signed-off-by: Dominique Martinet --- gcc 8 gives the following warning, which I am not sure why is treated as error for this file, thus making me

[PATCH -next] drm/sun4i: DW HDMI: Make symbol sun8i_dw_hdmi_pltfm_driver static

2018-07-12 Thread Wei Yongjun
Fixes the following sparse warning: drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:228:24: warning: symbol 'sun8i_dw_hdmi_pltfm_driver' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Regression on the sun4i-drm driver by cma helper change

2018-07-12 Thread Icenowy Zheng
Hi, Today, during testing the Banana Pi M2 Zero HDMI patch, I found a regression on the sun4i-drm driver, which happenes because of the cma helper change. The bad commit is 894a677f4b3e6d2ab8d01bb46c1fbd5f92e4591b ("drm/cma- helper: Use the generic fbdev emulation"). If this commit is present,

Re: [BUG 4.17] etnaviv-gpu f1840000.gpu: recover hung GPU!

2018-07-12 Thread Russell King - ARM Linux
On Tue, Jun 19, 2018 at 02:28:46PM +0200, Lucas Stach wrote: > See attached patch (which I apparently forgot to send out). The DRM GPU > scheduler has some tracepoints, which might be helpful. The attached > patch adds a drm_sched_job_run tracepoint when a job is queued in the > hardware ring.

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Jens Axboe
On 7/11/18 3:08 PM, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: >> On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: >>> I don't think there's a git easy way of sending it out outside of >>> just ensuring that everybody is CC'ed on everything. I don't mind

Re: [PATCH] drm/client: Fix: drm_client_new: Don't require DRM to be registered

2018-07-12 Thread Icenowy Zheng
在 2018-07-11三的 17:56 +0200,Noralf Trønnes写道: > Commit 894a677f4b3e ("drm/cma-helper: Use the generic fbdev > emulation") > broke almost all drivers that use the CMA helper. > > The reason is that drm_client_new() requires that the DRM device has > been registered, but the drivers register fbdev

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Jens Axboe
On 7/11/18 12:50 PM, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: >> On 7/11/18 10:45 AM, Tejun Heo wrote: >>> On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > Makes the macros

Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable

2018-07-12 Thread Sergey Senozhatsky
Hi, On (07/11/18 16:46), Thomas Zimmermann wrote: > Am 28.06.2018 um 11:03 schrieb Hans de Goede: > > Replace comments about places where the console lock should be held with > > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. > > Debugging fbcon sometimes requires to not

[PATCH] drm/client: Fix double free in error path

2018-07-12 Thread Noralf Trønnes
This fixes a static checker warning: drivers/gpu/drm/drm_client.c:289 drm_client_buffer_create() error: double free of 'buffer' drm_client_buffer_delete() frees the buffer so remove the extra free. Fixes: c76f0f7cb546 ("drm: Begin an API for in-kernel clients") Reported-by: Dan

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 03:13:00PM -0600, Jens Axboe wrote: > On 7/11/18 3:08 PM, Daniel Vetter wrote: > > On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: > >> On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: > >>> I don't think there's a git easy way of sending it out outside of >

Re: [PATCH] kernel.h: Add for_each_if()

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 1:05 AM, Andrew Morton wrote: > On Wed, 11 Jul 2018 13:51:08 +0200 Daniel Vetter wrote: >> But I still have the situation that a bunch of maintainers acked this >> and Andrew Morton defacto nacked it, which I guess means I'll keep the >> macro in drm? The common way to go

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #34 from Thomas Martitz --- Created attachment 140585 --> https://bugs.freedesktop.org/attachment.cgi?id=140585=edit dmesg with 0001-drm-amdgpu-pp-smu7-cache-smu-firmware-toc.patch This patch makes resume work, attached is the

[PATCH] drm/sun4i: tcon-top: Fix return type warning

2018-07-12 Thread Maxime Ripard
When commit af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling") was merged, the error handling path of the of_property_match_string was changed to take into account the fact that the returned value of that function wasn't an error pointer but an error code. Unfortunately, this introduced

[PATCH] drm: mali-dp: Set encoder possible_clones

2018-07-12 Thread Alexandru Gheorghe
Set possible_clones field to report that the writeback connector and the one driving the display could be enabled at the same time. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_drv.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH] drm/probe-helper: Fix modes reporting for writeback connector

2018-07-12 Thread Alexandru Gheorghe
Writeback connector is reported as disconnected, currently this causes the setting of the edid property to null and then exit. In order to properly get the modes for writeback we need to add an exception when connector type is DRM_MODE_CONNECTOR_WRITEBACK. Signed-off-by: Alexandru Gheorghe ---

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-12 Thread Stefan Agner
On 10.07.2018 11:11, Marek Vasut wrote: > On 07/10/2018 11:06 AM, Stefan Agner wrote: >> On 16.06.2018 01:32, Marek Vasut wrote: >>> On 06/16/2018 12:42 AM, Leonard Crestez wrote: On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote: > On 06/15/2018 10:58 PM, Leonard Crestez wrote: >>

Re: [PATCH 3/3] drm/scheduler: modify args of drm_sched_entity_init

2018-07-12 Thread Nayan Deshmukh
On Thu, Jul 12, 2018 at 12:07 PM Nayan Deshmukh wrote: > > replace run queue by a list of run queues and remove the > sched arg as that is part of run queue itself > > Signed-off-by: Nayan Deshmukh > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 ++-- >

Re: [PATCH -next] drm/sun4i: DW HDMI: Make symbol sun8i_dw_hdmi_pltfm_driver static

2018-07-12 Thread Maxime Ripard
On Wed, Jul 11, 2018 at 01:22:47PM +, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:228:24: warning: > symbol 'sun8i_dw_hdmi_pltfm_driver' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Applied, thanks! Maxime --

[Bug 107082] With 4.18 rc kernel stop working video output on AMD GPU Vega 56

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107082 --- Comment #2 from Michel Dänzer --- (In reply to Nicholas Kazlauskas from comment #1) > This should be fixed with: https://patchwork.freedesktop.org/patch/233283/ > The fix is also availble if you use amd-staging-drm-next. Since the

[PATCH v3] drm/sun4i: mixer: Read id from DT

2018-07-12 Thread Jernej Skrabec
Currently, TCON supports 2 ways to match TCON with engine (mixer in this case). Old way is to just traverse of graph backwards and compare node pointer. New way is to match TCON and engine by their respective ids. All SoCs with DE2 enabled till now used the old way, which means mixer id was never

[PATCH v2] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Dominique Martinet
Change it to use strlcpy instead Signed-off-by: Dominique Martinet --- drivers/gpu/drm/i915/intel_tv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c index b55b5c157e38..25fee7dba7e2 100644 ---

Re: [PATCH v2 00/18] Allwinner R40 HDMI refactoring

2018-07-12 Thread Jernej Škrabec
Dne sreda, 11. julij 2018 ob 10:30:36 CEST je Maxime Ripard napisal(a): > On Tue, Jul 10, 2018 at 10:34:53PM +0200, Jernej Skrabec wrote: > > This series fixes several issues found in R40 HDMI patch series after > > it was applied. Conversation can be found here: > >

Re: [PATCH] drm/etnaviv: bring back progress check in job timeout handler

2018-07-12 Thread Russell King - ARM Linux
On Wed, Jun 27, 2018 at 04:34:27PM +0200, Lucas Stach wrote: > When the hangcheck handler was replaced by the DRM scheduler timeout > handling we dropped the forward progress check, as this might allow > clients to hog the GPU for a long time with a big job. > > It turns out that even reasonably

Re: [PATCH 02/12] blk: use for_each_if

2018-07-12 Thread Jens Axboe
On 7/11/18 10:45 AM, Tejun Heo wrote: > On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: >> On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: >>> Makes the macros resilient against if {} else {} blocks right >>> afterwards. >>> >>> Signed-off-by: Daniel Vetter >>> Cc: Tejun

Re: [PATCH] drm/probe-helper: Fix modes reporting for writeback connector

2018-07-12 Thread Alexandru-Cosmin Gheorghe
On Thu, Jul 12, 2018 at 10:55:47AM +0200, Daniel Vetter wrote: > On Thu, Jul 12, 2018 at 09:48:02AM +0100, Alexandru Gheorghe wrote: > > Writeback connector is reported as disconnected, currently this causes > > the setting of the edid property to null and then exit. > > In order to properly get

Re: [PATCH v2] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Chris Wilson
Quoting Dominique Martinet (2018-07-12 00:24:46) > Change it to use strlcpy instead > > Signed-off-by: Dominique Martinet Thanks for the spotting the issue and providing a fix, pushed. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH 00/10] Improve crc-core driver interface

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patches. When resubmitting patch series, could you please add a version number to the [PATCH] prefix ? Otherwise it gets difficult to figure out which version is the latest. This can be done automatically with the -v argument to git-format- patch. On Thursday, 12

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:27 EEST Mahesh Kumar wrote: > This patch introduce a callback function "get_crc_sources" which > will be called during read of control node. It is an optional > callback function and if driver implements this callback, driver >

Re: [PATCH] drm: mali-dp: Set encoder possible_clones

2018-07-12 Thread Ville Syrjälä
On Thu, Jul 12, 2018 at 09:48:56AM +0100, Alexandru Gheorghe wrote: > Set possible_clones field to report that the writeback connector and > the one driving the display could be enabled at the same time. > > Signed-off-by: Alexandru Gheorghe > --- > drivers/gpu/drm/arm/malidp_drv.c | 10

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #38 from Alex Deucher --- (In reply to Thomas Martitz from comment #36) > Created attachment 140591 [details] [review] > workaround without memcpy > > I made the following patch as an alternative workaround. The printks I added >

Re: [PATCH v2] console: Replace #if 1 with a bool to ignore

2018-07-12 Thread Steven Rostedt
On Thu, 12 Jul 2018 09:29:38 -0400 Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > There's been discussion on the fb list about the addition of > WARN_CONSOLE_UNLOCKED() inside the fb code. The complaint is that when > the fb module is loaded with lockless_register_fb the console

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #40 from Thomas Martitz --- Further investigations show that toc->num_entires and toc->structure_version are set to -1 after the first call to smu7_request_smu_load_fw(). Does that makes sense? Since you say the GPU does not

Re: [PATCH 15/15] drm: drop drmP.h include from drm_crtc.c

2018-07-12 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:16AM +0200, Daniel Vetter wrote: > This is starting to become easy! > > Note: This needs the patch to move for_each_if from drmP.h to kernel.h > or it won't compile. > > Signed-off-by: Daniel Vetter Once for_each_if gets sorted out (however it goes). Reviewed-by:

[Bug 107204] GPU hang (ring gfx timeout) in OpenGL game

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107204 Bug ID: 107204 Summary: GPU hang (ring gfx timeout) in OpenGL game Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: normal

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-12 Thread Ville Syrjälä
On Wed, Jul 11, 2018 at 09:46:15AM +0200, Dominique Martinet wrote: > This is effectively no-op as the next line writes a nul at the final What is "This". Please write self contained commit messages. > byte of the buffer, so copying one letter less does not change the > behaviour. > >

[Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105760 --- Comment #35 from Alex Deucher --- Created attachment 140590 --> https://bugs.freedesktop.org/attachment.cgi?id=140590=edit use gtt for firmware buffers I still don't understand what's corrupting the cpu pointer. Ultimately, it looks

  1   2   >