Re: [PATCH 06/26] drm/dp_mst: Move PDT teardown for ports into destroy_connector_work

2019-08-13 Thread Daniel Vetter
On Wed, Jul 17, 2019 at 09:42:29PM -0400, Lyude Paul wrote: > This will allow us to add some locking for port PDTs, which can't be > done from drm_dp_destroy_port() since we don't know what locks the > caller might be holding. Also, this gets rid of a good bit of unneeded > code. > > Cc: Juston

[PATCH v2] drm/panfrost: Implement per FD address spaces

2019-08-13 Thread Rob Herring
Up until now, a single shared GPU address space was used. This is not ideal as there's no protection between processes and doesn't work for supporting the same GPU/CPU VA feature. Most importantly, this will hopefully mitigate Alyssa's fear of WebGL, whatever that is. Most of the changes here are

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #96 from Tom B --- Created attachment 145047 --> https://bugs.freedesktop.org/attachment.cgi?id=145047=edit logging anywhere the number of screens is set Again, no closer to a fix but another thing to rule out. In addition to

Re: [PATCH v3 5/8] drm/etnaviv: rework MMU handling

2019-08-13 Thread Guido Günther
Hi, On Fri, Aug 09, 2019 at 02:04:21PM +0200, Lucas Stach wrote: > This reworks the MMU handling to make it possible to have multiple MMU > contexts. > A context is basically one instance of GPU page tables. Currently we have one > set of page tables per GPU, which isn't all that clever, as it

Re: [PATCH v2 4/8] drm/etnaviv: replace MMU flush marker with flush sequence

2019-08-13 Thread Guido Günther
Hi, On Fri, Jul 05, 2019 at 07:17:23PM +0200, Lucas Stach wrote: > If a MMU is shared between multiple GPUs, all of them need to flush their > TLBs, so a single marker that gets reset on the first flush won't do. > Replace the flush marker with a sequence number, so that it's possible to > check

Re: [PATCH v3 5/9] drm/panel: Add driver for the NEC NL8048HL11 panel

2019-08-13 Thread Sam Ravnborg
On Tue, Aug 13, 2019 at 04:33:07PM +0300, Laurent Pinchart wrote: > This panel is used on the Zoom2/3/3630 SDP boards. > > The code is based on the omapdrm-specific panel-nec-nl8048hl11 driver > > Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg > --- > Changes since v2: > > - Call

Re: [PATCH v12 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-13 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-13 02:12:54) > On Tue, Aug 13, 2019 at 2:04 AM Brendan Higgins > wrote: > > > > On Mon, Aug 12, 2019 at 10:30 PM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-08-12 22:02:59) > > > > However, now that I added the kunit_resource_destroy, I thought

[PATCH v2 1/2] drm/msm: Remove Kconfig default

2019-08-13 Thread Jordan Crouse
Remove the default for CONFIG_DRM_MSM and let the user select the driver manually as one does. Additionally select QCOM_COMMAND_DB for ARCH_QCOM targets to make sure it doesn't get missed when we need it for a6xx targets. v2: Move from default 'm' to no default Signed-off-by: Jordan Crouse ---

Re: [PATCH 07/26] drm/dp_mst: Get rid of list clear in drm_dp_finish_destroy_port()

2019-08-13 Thread Daniel Vetter
On Wed, Jul 17, 2019 at 09:42:30PM -0400, Lyude Paul wrote: > This seems to be some leftover detritus from before the port/mstb kref > cleanup and doesn't do anything anymore, so get rid of it. > > Cc: Juston Li > Cc: Imre Deak > Cc: Ville Syrjälä > Cc: Harry Wentland > Signed-off-by: Lyude

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #87 from Mauro Gaspari --- (In reply to Pierre-Eric Pelloux-Prayer from comment #86) > (In reply to Mauro Gaspari from comment #85) > > I will first try to reintroduce the kernel parameters I previously used. > > Do you think those

Re: [PATCH v3 6/9] drm/panel: Add driver for the Sharp LS037V7DW01 panel

2019-08-13 Thread Sam Ravnborg
On Tue, Aug 13, 2019 at 04:33:08PM +0300, Laurent Pinchart wrote: > This panel is used on the TI SDP3430 board. > > The code is based on the omapdrm-specific panel-sharp-ls037v7dw01 > driver. > > Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg > --- > Changes since v1: > > -

Re: [PATCH v3 7/9] drm/panel: Add driver for the Sony ACX565AKM panel

2019-08-13 Thread Sam Ravnborg
Hi Laurent. On Tue, Aug 13, 2019 at 04:33:09PM +0300, Laurent Pinchart wrote: > This panel is used on the Nokia N900. > > The code is based on the omapdrm-specific panel-sony-acx565akm driver. > > Signed-off-by: Laurent Pinchart Looking at the backlight support in this driver there is some

Re: [PATCH 05/26] drm/dp_mst: Add sideband down request tracing + selftests

2019-08-13 Thread Daniel Vetter
On Wed, Jul 17, 2019 at 09:42:28PM -0400, Lyude Paul wrote: > Unfortunately the DP MST helpers do not have much in the way of > debugging utilities. So, let's add some! > > This adds basic debugging output for down sideband requests that we send > from the driver, so that we can actually discern

Re: [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-13 Thread Thierry Reding
On Mon, Aug 05, 2019 at 04:01:10PM +0200, Gerd Hoffmann wrote: > Drop vma_node from ttm_buffer_object, use the gem struct > (base.vma_node) instead. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- >

Re: [PATCH] drm/panfrost: Remove completed features still in TODO

2019-08-13 Thread Rob Herring
On Tue, Aug 13, 2019 at 7:07 AM Neil Armstrong wrote: > > On 02/08/2019 21:57, Rob Herring wrote: > > There's a few features the driver supports which we forgot to remove, so > > remove them now. > > > > Cc: Tomeu Vizoso > > Cc: Boris Brezillon > > Signed-off-by: Rob Herring > > --- > >

Re: [PATCH v12 09/18] kunit: test: add support for test abort

2019-08-13 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-13 00:52:03) > On Mon, Aug 12, 2019 at 10:56 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-12 21:57:55) > > > On Mon, Aug 12, 2019 at 9:22 PM Stephen Boyd wrote: > > > > > > > > Quoting Brendan Higgins (2019-08-12 11:24:12) > > > > > diff --git

Re: [PATCH v12 12/18] kunit: test: add tests for KUnit managed resources

2019-08-13 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-13 00:57:33) > On Mon, Aug 12, 2019 at 9:31 PM Stephen Boyd wrote: > > > > BTW, maybe kunit allocation APIs should > > fail the test if they fail to allocate in general. Unless we're unit > > testing failure to allocate problems. > > Yeah, I thought about that. I

Re: [PATCH v3 9/9] drm/panel: Add driver for the Toppoly TD043MTEA1 panel

2019-08-13 Thread Sam Ravnborg
On Tue, Aug 13, 2019 at 04:33:11PM +0300, Laurent Pinchart wrote: > This panel is used on the OMAP3 Pandora. > > The code is based on the omapdrm-specific panel-tpo-td043mtea1 driver. > > Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg > --- > Changes since v2: > > - Call

Re: [PATCH v3 6/8] drm/etnaviv: split out starting of FE idle loop

2019-08-13 Thread Guido Günther
Hi, On Fri, Aug 09, 2019 at 02:04:22PM +0200, Lucas Stach wrote: > Move buffer setup and starting of the FE loop in the kernel ringbuffer > into a separate function. This is a preparation to start the FE later > in the submit process. > > Signed-off-by: Lucas Stach > Reviewed-by: Philipp Zabel

Re: [PATCH 28/60] drm/omap: Factor out display type to connector type conversion

2019-08-13 Thread Laurent Pinchart
Hi Tomi, On Tue, Aug 13, 2019 at 10:32:10AM +0300, Tomi Valkeinen wrote: > On 07/07/2019 21:19, Laurent Pinchart wrote: > > Move the code that computes the DRM connector type for the > > omapdss_device display type to a new omapdss_device_connector_type() > > function for later reuse. > > > >

Re: [PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-13 Thread Noralf Trønnes
Den 12.08.2019 20.49, skrev Sam Ravnborg: > Hi Noralf. > >>> - drm_panel has proper support for modes. >>> This is today duplicated in mipi_dbi. >>> Could we make it so that when a panel is used then the panel >>> has the mode info - as we then use the panel more in the way we do >>> in

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #97 from Tom B --- I've been investigating this: https://github.com/torvalds/linux/commit/94ed6d0cfdb867be9bf05f03d682980bce5d0036 Because vega20 doesn't export display_configuration_change, it jumps to the newly added else block

Re: [PATCH 09/26] drm/dp_mst: Remove huge conditional in drm_dp_mst_handle_up_req()

2019-08-13 Thread Daniel Vetter
On Wed, Jul 17, 2019 at 09:42:32PM -0400, Lyude Paul wrote: > Which reduces indentation and makes this function more legible. Indeed, nice one. Reviewed-by: Daniel Vetter > > Cc: Juston Li > Cc: Imre Deak > Cc: Ville Syrjälä > Cc: Harry Wentland > Signed-off-by: Lyude Paul > --- >

Re: [PATCH v3 8/9] drm/panel: Add driver for the Toppoly TD028TTEC1 panel

2019-08-13 Thread Sam Ravnborg
Hi Laurent. On Tue, Aug 13, 2019 at 04:33:10PM +0300, Laurent Pinchart wrote: > This panel is used on the OpenMoko Neo FreeRunner and Neo 1973. > > The code is based on the omapdrm-specific panel-tpo-td028ttec1 driver. > > Signed-off-by: Laurent Pinchart This driver have everything in the

Re: [PATCH v3 4/8] drm/etnaviv: replace MMU flush marker with flush sequence

2019-08-13 Thread Guido Günther
Hi, On Fri, Aug 09, 2019 at 02:04:20PM +0200, Lucas Stach wrote: > If a MMU is shared between multiple GPUs, all of them need to flush their > TLBs, so a single marker that gets reset on the first flush won't do. > Replace the flush marker with a sequence number, so that it's possible to > check

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #98 from Sylvain BERTRAND --- > The code seems very similar to what we see in > vega20_notify_smc_display_config_after_ps_adjustment near where we get the " > [SetHardMinFreq] Set hard min uclk failed!" Maybe this >

[Bug 110509] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110509 Alessandro changed: What|Removed |Added CC||lifeis...@gmail.com --- Comment #15 from

[Bug 110509] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx timeout

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110509 Alessandro changed: What|Removed |Added Attachment #145050|dmsg drm amdgpu |dmsg drm amdgpu linux description|

Re: Best practice for embedded code samles? [Was: drm/drv: Use // for comments in example code]

2019-08-13 Thread Jonathan Corbet
On Sun, 11 Aug 2019 23:32:15 +0200 Sam Ravnborg wrote: > I wonder if there is a better way to embed a code sample > than reverting to // style comments. > > As the kernel do not like // comments we should try to avoid them in > examples. If you're embedding a code sample *into a code comment*

[Bug 110886] After S3 resume, kernel: [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:57:crtc-0] flip_done timed out

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110886 --- Comment #8 from Andrey Grodzovsky --- (In reply to Kai-Heng Feng from comment #6) > Created attachment 145044 [details] > failed log when iommu is disabled. What was the failur ewith IOMMU disabled ? Is it the same as with IOMMU enabled ?

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #104 from Adrian Przekwas --- The patch fixed the issue for me - Radeon RX 580, 1920x1080@75Hz, connected via DisplayPort. -- You are receiving this mail because: You are the assignee for the

Re: [PATCH v3 00/37] Introduce memory region concept (including device local memory)

2019-08-13 Thread Dave Airlie
On Sat, 10 Aug 2019 at 08:26, Matthew Auld wrote: > > In preparation for upcoming devices with device local memory, introduce the > concept of different memory regions, and a simple buddy allocator to manage > them in i915. > > One of the concerns raised from v1 was around not using enough of

Re: [PATCH] nouveau/hmm: map pages after migration

2019-08-13 Thread Jerome Glisse
On Wed, Aug 07, 2019 at 08:02:14AM -0700, Ralph Campbell wrote: > When memory is migrated to the GPU it is likely to be accessed by GPU > code soon afterwards. Instead of waiting for a GPU fault, map the > migrated memory into the GPU page tables with the same access permissions > as the source

[PATCH v4 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-13 Thread Laurent Pinchart
This panel is used on the Gumstix Overo Palo35. The code is based on the omapdrm-specific panel-lgphilips-lb035q02 driver. Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg --- Changes since v1: - Comments updates - Store width_mm and height_mm in drm_display_mode - Use

[PATCH v4 2/9] dt-bindings: Add legacy 'toppoly' vendor prefix

2019-08-13 Thread Laurent Pinchart
The 'toppoly' vendor prefix is in use and refers to TPO, whose DT vendor prefix is already defined as 'tpo'. Add 'toppoly' as an alternative and document it as legacy. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1: - Mark the prefix as deprecated ---

[PATCH v4 3/9] dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel

2019-08-13 Thread Laurent Pinchart
The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB parallel data interface and an SPI control interface. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v2: - Add reg and spi-max-frequency properties - Make the example pass the checks Changes

[PATCH v4 5/9] drm/panel: Add driver for the NEC NL8048HL11 panel

2019-08-13 Thread Laurent Pinchart
This panel is used on the Zoom2/3/3630 SDP boards. The code is based on the omapdrm-specific panel-nec-nl8048hl11 driver Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg --- Changes since v2: - Call drm_panel_unprepare() in .remove() handler Changes since v1: - Mention boards using

[PATCH v4 9/9] drm/panel: Add driver for the Toppoly TD043MTEA1 panel

2019-08-13 Thread Laurent Pinchart
This panel is used on the OMAP3 Pandora. The code is based on the omapdrm-specific panel-tpo-td043mtea1 driver. Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg --- Changes since v2: - Call drm_panel_disable() in .remove() handler Changes since v1: - Mention boards using the panel

[PATCH v4 6/9] drm/panel: Add driver for the Sharp LS037V7DW01 panel

2019-08-13 Thread Laurent Pinchart
This panel is used on the TI SDP3430 board. The code is based on the omapdrm-specific panel-sharp-ls037v7dw01 driver. Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg --- Changes since v1: - Mention boards using the panel in Kconfig - Renamed ls037v7dw01_device to ls037v7dw01_panel -

[PATCH v4 7/9] drm/panel: Add driver for the Sony ACX565AKM panel

2019-08-13 Thread Laurent Pinchart
This panel is used on the Nokia N900. The code is based on the omapdrm-specific panel-sony-acx565akm driver. The hardware-related logic has been changed as little as possible to avoid regressions as hardware availability is lacking to test the changes. Follow-up patches should address the items

[PATCH v4 8/9] drm/panel: Add driver for the Toppoly TD028TTEC1 panel

2019-08-13 Thread Laurent Pinchart
This panel is used on the OpenMoko Neo FreeRunner and Neo 1973. The code is based on the omapdrm-specific panel-tpo-td028ttec1 driver. Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg --- Changes since v3: - Split enable/disable in prepare/enable/disable/unprepare Changes since v2:

[PATCH v4 0/9] DRM panel drivers for omapdrm

2019-08-13 Thread Laurent Pinchart
Hello everybody, This patch series adds DT bindings and drivers for 6 panels used by omapdrm. They are meant to replace the corresponding omapdrm-specific drivers from drivers/gpu/drm/omapdrm/displays/ that will be removed in a subsequent patch series, once the omapdrm driver switches fully to

[PATCH v4 1/9] dt-bindings: Add vendor prefix for LG Display

2019-08-13 Thread Laurent Pinchart
LG Display is an LCD display manufacturer. Originally formed as a joint venture by LG Electronics and Philips Electronics, it was formerly known as LG.Philips LCD, hence the DT vendor prefix lgphilips (which is already in active use in the kernel). More information is available at

Re: [PATCH v3 04/37] drm/i915/region: support continuous allocations

2019-08-13 Thread Daniel Vetter
On Fri, Aug 09, 2019 at 11:26:10PM +0100, Matthew Auld wrote: > Some objects may need to be allocated as a continuous block, thinking > ahead the various kernel io_mapping interfaces seem to expect it. Not really, we can vmalloc for iomappings too. -Daniel > > Signed-off-by: Matthew Auld > Cc:

[PATCH AUTOSEL 4.19 45/68] drm/rockchip: Suspend DP late

2019-08-13 Thread Sasha Levin
From: Douglas Anderson [ Upstream commit f7ccbed656f78212593ca965d9a8f34bf24e0aab ] In commit fe64ba5c6323 ("drm/rockchip: Resume DP early") we moved resume to be early but left suspend at its normal time. This seems like it could be OK, but casues problems if a suspend gets interrupted

[PATCH AUTOSEL 4.19 61/68] drm/vmwgfx: fix memory leak when too many retries have occurred

2019-08-13 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 6b7c3b86f0b63134b2ab56508921a0853ffa687a ] Currently when too many retries have occurred there is a memory leak on the allocation for reply on the error return path. Fix this by kfree'ing reply before returning. Addresses-Coverity: ("Resource leak")

[PATCH AUTOSEL 4.9 31/33] drm/vmwgfx: fix memory leak when too many retries have occurred

2019-08-13 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 6b7c3b86f0b63134b2ab56508921a0853ffa687a ] Currently when too many retries have occurred there is a memory leak on the allocation for reply on the error return path. Fix this by kfree'ing reply before returning. Addresses-Coverity: ("Resource leak")

[PATCH -next] drm/panfrost: Fix missing unlock on error in panfrost_mmu_map_fault_addr()

2019-08-13 Thread Wei Yongjun
Add the missing unlock before return from function panfrost_mmu_map_fault_addr() in the error handling case. Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 - 1 file changed, 4

Re: [PATCH 04/15] mm: remove the pgmap field from struct hmm_vma_walk

2019-08-13 Thread Dan Williams
On Wed, Aug 7, 2019 at 11:59 PM Christoph Hellwig wrote: > > On Wed, Aug 07, 2019 at 11:47:22AM -0700, Dan Williams wrote: > > > Unrelated to this patch, but what is the point of getting checking > > > that the pgmap exists for the page and then immediately releasing it? > > > This code has this

[PATCH AUTOSEL 5.2 114/123] drm/vmwgfx: fix memory leak when too many retries have occurred

2019-08-13 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 6b7c3b86f0b63134b2ab56508921a0853ffa687a ] Currently when too many retries have occurred there is a memory leak on the allocation for reply on the error return path. Fix this by kfree'ing reply before returning. Addresses-Coverity: ("Resource leak")

[PATCH AUTOSEL 5.2 041/123] Staging: fbtft: Fix GPIO handling

2019-08-13 Thread Sasha Levin
From: Jan Sebastian Götte [ Upstream commit 92e3e884887c0d278042fbbb6f6c9b41d6addb71 ] Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") breaks GPIO handling. In several places, checks to only set a GPIO if it was configured ended up backwards. I have tested this

linux-next: manual merge of the drm-misc tree with the drm and drm-intel trees

2019-08-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c drivers/gpu/drm/i915/i915_vma.c drivers/gpu/drm/i915/i915_gem_batch_pool.c drivers/gpu/drm/i915/gem/i915_gem_object.c drivers/gpu/drm/i915/gt/intel_engine_pool.c between

linux-next: manual merge of the etnaviv tree with the drm-misc tree

2019-08-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the etnaviv tree got a conflict in: drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c between commit: 52791eeec1d9 ("dma-buf: rename reservation_object to dma_resv") from the drm-misc tree and commit: 6eae41fea750 ("drm/etnaviv: drop use of drmP.h")

Re: [PATCH AUTOSEL 5.2 42/76] drm/msm: stop abusing dma_map/unmap for cache

2019-08-13 Thread Sasha Levin
On Fri, Aug 02, 2019 at 05:14:35PM -0700, Rob Clark wrote: Hi Sasha, It's probably best *not* to backport this patch.. drm/msm abuses the DMA API in a way that it is not intended be used, to work around the lack of cache sync API exported to kernel modules on arm/arm64. I couldn't really

[PATCH AUTOSEL 5.2 089/123] drm/rockchip: Suspend DP late

2019-08-13 Thread Sasha Levin
From: Douglas Anderson [ Upstream commit f7ccbed656f78212593ca965d9a8f34bf24e0aab ] In commit fe64ba5c6323 ("drm/rockchip: Resume DP early") we moved resume to be early but left suspend at its normal time. This seems like it could be OK, but casues problems if a suspend gets interrupted

[PATCH AUTOSEL 5.2 105/123] drm/amdgpu: pin the csb buffer on hw init for gfx v8

2019-08-13 Thread Sasha Levin
From: Likun Gao [ Upstream commit 72cda9bb5e219aea0f2f62f56ae05198c59022a7 ] Without this pin, the csb buffer will be filled with inconsistent data after S3 resume. And that will causes gfx hang on gfxoff exit since this csb will be executed then. Signed-off-by: Likun Gao Tested-by: Paul

Re: linux-next: manual merge of the drm-msm tree with the drm tree

2019-08-13 Thread Stephen Rothwell
Hi all, On Wed, 14 Aug 2019 12:58:59 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the drm-msm tree got a conflict in: > > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > > between commit: > > e78ad7654179 ("drm/msm: Use drm_gem_fb_prepare_fb") > > from the drm tree and

[PATCH AUTOSEL 4.14 40/44] drm/vmwgfx: fix memory leak when too many retries have occurred

2019-08-13 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 6b7c3b86f0b63134b2ab56508921a0853ffa687a ] Currently when too many retries have occurred there is a memory leak on the allocation for reply on the error return path. Fix this by kfree'ing reply before returning. Addresses-Coverity: ("Resource leak")

linux-next: manual merge of the drm-msm tree with the drm tree

2019-08-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-msm tree got a conflict in: drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c between commit: e78ad7654179 ("drm/msm: Use drm_gem_fb_prepare_fb") from the drm tree and commit: ddc73f32ba95 ("drm/msm: drop use of drmP.h") from the drm-msm tree. I

[Bug 110886] After S3 resume, kernel: [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:57:crtc-0] flip_done timed out

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110886 --- Comment #9 from Kai-Heng Feng --- (In reply to Andrey Grodzovsky from comment #8) > (In reply to Kai-Heng Feng from comment #6) > > Created attachment 145044 [details] > > failed log when iommu is disabled. > > What was the failur ewith

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #86 from Pierre-Eric Pelloux-Prayer --- (In reply to Mauro Gaspari from comment #85) > I will first try to reintroduce the kernel parameters I previously used. > Do you think those can help at all? > [...] > GPU > amdgpu.dc=1 Not

Re: [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-08-13 Thread Gerd Hoffmann
> Hi Gerd, > > I've been seeing a regression on Nouveau with recent linux-next releases > and git bisect points at this commit as the first bad one. If I revert > it (there's a tiny conflict with a patch that was merged subsequently), > things are back to normal. > > I think the reason for this

[PATCH v13 15/18] Documentation: kunit: add documentation for KUnit

2019-08-13 Thread Brendan Higgins
Add documentation for KUnit, the Linux kernel unit testing framework. - Add intro and usage guide for KUnit - Add API reference Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins Cc: Jonathan Corbet Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe Reviewed-by: Stephen Boyd

[PATCH v13 16/18] MAINTAINERS: add entry for KUnit the unit testing framework

2019-08-13 Thread Brendan Higgins
Add myself as maintainer of KUnit, the Linux kernel's unit testing framework. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe Reviewed-by: Stephen Boyd --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS

[PATCH v13 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-08-13 Thread Brendan Higgins
From: Iurii Zaikin KUnit tests for initialized data behavior of proc_dointvec that is explicitly checked in the code. Includes basic parsing tests including int min/max overflow. Signed-off-by: Iurii Zaikin Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan

[PATCH v13 14/18] kunit: defconfig: add defconfigs for building KUnit tests

2019-08-13 Thread Brendan Higgins
Add defconfig for UML and a fragment that can be used to configure other architectures for building KUnit tests. Add option to kunit_tool to use a defconfig to create the kunitconfig. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe ---

[PATCH v13 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section

2019-08-13 Thread Brendan Higgins
Add entry for the new proc sysctl KUnit test to the PROC SYSCTL section, and add Iurii as a maintainer. Signed-off-by: Brendan Higgins Cc: Iurii Zaikin Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe Acked-by: Luis Chamberlain --- MAINTAINERS | 2 ++ 1 file changed, 2

[PATCH v13 07/18] kunit: test: add initial tests

2019-08-13 Thread Brendan Higgins
Add a test for string stream along with a simpler example. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe Reviewed-by: Stephen Boyd --- kunit/Kconfig | 21 + kunit/Makefile | 4 ++ kunit/example-test.c | 88

[PATCH v13 05/18] kunit: test: add the concept of expectations

2019-08-13 Thread Brendan Higgins
Add support for expectations, which allow properties to be specified and then verified in tests. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe Reviewed-by: Stephen Boyd --- include/kunit/test.h | 834 ++-

[PATCH v13 03/18] kunit: test: add string_stream a std::stream like string builder

2019-08-13 Thread Brendan Higgins
A number of test features need to do pretty complicated string printing where it may not be possible to rely on a single preallocated string with parameters. So provide a library for constructing the string as you go similar to C++'s std::string. string_stream is really just a string builder,

[PATCH v13 06/18] kbuild: enable building KUnit

2019-08-13 Thread Brendan Higgins
KUnit is a new unit testing framework for the kernel and when used is built into the kernel as a part of it. Add KUnit to the root Kconfig and Makefile to allow it to be actually built. Signed-off-by: Brendan Higgins Acked-by: Masahiro Yamada Cc: Michal Marek Reviewed-by: Greg Kroah-Hartman

[PATCH v13 01/18] kunit: test: add KUnit test runner core

2019-08-13 Thread Brendan Higgins
Add core facilities for defining unit tests; this provides a common way to define test cases, functions that execute code which is under test and determine whether the code under test behaves as expected; this also provides a way to group together related test cases in test suites (here we call

[PATCH v13 04/18] kunit: test: add assertion printing library

2019-08-13 Thread Brendan Higgins
Add `struct kunit_assert` and friends which provide a structured way to capture data from an expectation or an assertion (introduced later in the series) so that it may be printed out in the event of a failure. Signed-off-by: Brendan Higgins Reviewed-by: Stephen Boyd --- include/kunit/assert.h

[PATCH v13 13/18] kunit: tool: add Python wrappers for running KUnit tests

2019-08-13 Thread Brendan Higgins
From: Felix Guo The ultimate goal is to create minimal isolated test binaries; in the meantime we are using UML to provide the infrastructure to run tests, so define an abstract way to configure and run tests that allow us to change the context in which tests are built without affecting the

[PATCH v13 12/18] kunit: test: add tests for KUnit managed resources

2019-08-13 Thread Brendan Higgins
From: Avinash Kondareddy Add unit tests for KUnit managed resources. KUnit managed resources (struct kunit_resource) are resources that are automatically cleaned up at the end of a KUnit test, similar to the concept of devm_* managed resources. Signed-off-by: Avinash Kondareddy Signed-off-by:

[PATCH v13 10/18] kunit: test: add tests for kunit test abort

2019-08-13 Thread Brendan Higgins
Add KUnit tests for the KUnit test abort mechanism (see preceding commit). Add tests both for general try catch mechanism as well as non-architecture specific mechanism. Signed-off-by: Brendan Higgins Reviewed-by: Greg Kroah-Hartman Reviewed-by: Logan Gunthorpe Reviewed-by: Stephen Boyd ---

[PATCH v13 08/18] objtool: add kunit_try_catch_throw to the noreturn list

2019-08-13 Thread Brendan Higgins
Fix the following warning seen on GCC 7.3: kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() kunit_try_catch_throw is a function added in the following patch in this series; it allows KUnit, a unit testing framework for the

[PATCH v13 11/18] kunit: test: add the concept of assertions

2019-08-13 Thread Brendan Higgins
Add support for assertions which are like expectations except the test terminates if the assertion is not satisfied. The idea with assertions is that you use them to state all the preconditions for your test. Logically speaking, these are the premises of the test case, so if a premise isn't true,

[PATCH v13 09/18] kunit: test: add support for test abort

2019-08-13 Thread Brendan Higgins
Add support for aborting/bailing out of test cases, which is needed for implementing assertions. An assertion is like an expectation, but bails out of the test case early if the assertion is not met. The idea with assertions is that you use them to state all the preconditions for your test.

[PATCH v13 02/18] kunit: test: add test resource management API

2019-08-13 Thread Brendan Higgins
Create a common API for test managed resources like memory and test objects. A lot of times a test will want to set up infrastructure to be used in test cases; this could be anything from just wanting to allocate some memory to setting up a driver stack; this defines facilities for creating "test

[PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-08-13 Thread Brendan Higgins
## TL;DR This revision addresses comments from Stephen and Bjorn Helgaas. Most changes are pretty minor stuff that doesn't affect the API in anyway. One significant change, however, is that I added support for freeing kunit_resource managed resources before the test case is finished via

Re: [PATCH v12 13/18] kunit: tool: add Python wrappers for running KUnit tests

2019-08-13 Thread Stephen Boyd
Quoting Brendan Higgins (2019-08-12 11:24:16) > From: Felix Guo > > The ultimate goal is to create minimal isolated test binaries; in the > meantime we are using UML to provide the infrastructure to run tests, so > define an abstract way to configure and run tests that allow us to > change the

[Bug 111388] some problem on display hungarian sentences checking

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111388 Andre Klapper changed: What|Removed |Added Version|DRI git |unspecified

[Bug 111390] [CI][SHARDS] igt@kms_* - dmesg-warn - KSV list failed to become ready (-110)

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111390 Bug ID: 111390 Summary: [CI][SHARDS] igt@kms_* - dmesg-warn - KSV list failed to become ready (-110) Product: DRI Version: XOrg git Hardware: Other OS:

Re: [PATCH 28/60] drm/omap: Factor out display type to connector type conversion

2019-08-13 Thread Tomi Valkeinen
On 07/07/2019 21:19, Laurent Pinchart wrote: Move the code that computes the DRM connector type for the omapdss_device display type to a new omapdss_device_connector_type() function for later reuse. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/base.c | 23

[PATCH 0/2] drm/virtio: notify virtqueues without holding spinlock

2019-08-13 Thread Gerd Hoffmann
Gerd Hoffmann (2): drm/virtio: cleanup queue functions drm/virtio: notify virtqueues without holding spinlock drivers/gpu/drm/virtio/virtgpu_vq.c | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) -- 2.18.1

[PATCH 2/2] drm/virtio: notify virtqueues without holding spinlock

2019-08-13 Thread Gerd Hoffmann
Split virtqueue_kick() call into virtqueue_kick_prepare(), which requires serialization, and virtqueue_notify(), which does not. Move the virtqueue_notify() call out of the critical section protected by the queue lock. This avoids triggering a vmexit while holding the lock and thereby fixes a

[PATCH 1/2] drm/virtio: cleanup queue functions

2019-08-13 Thread Gerd Hoffmann
Make the queue functions return void, none of the call sites checks the return value. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_vq.c | 41 ++--- 1 file changed, 14 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-08-13 Thread Maxime Ripard
On Mon, Jul 29, 2019 at 08:59:04AM +0200, Michael Nazzareno Trimarchi wrote: > Hi > > On Wed, Jul 24, 2019 at 11:05 AM Maxime Ripard > wrote: > > > > On Mon, Jul 22, 2019 at 03:51:04PM +0530, Jagan Teki wrote: > > > Hi Maxime, > > > > > > On Sat, Jul 20, 2019 at 3:02 PM Maxime Ripard > > >

Re: [RFC PATCH 00/11] Simple QoS for exynos-bus driver using interconnect

2019-08-13 Thread Chanwoo Choi
Hi Artur, On 19. 8. 13. 오후 3:17, Chanwoo Choi wrote: > Hi Artur. > > The patch1-4 in this series depend on other patches[1] on mainline. > On next v2 version, please make some patches based on patches[1] > in order to prevent the merge conflict. > > [1] [RESEND PATCH v5 0/4] add coupled

Re: [PATCH 3/4] dma-fence: Refactor signaling for manual invocation

2019-08-13 Thread Koenig, Christian
Am 12.08.19 um 16:53 schrieb Chris Wilson: > Quoting Koenig, Christian (2019-08-12 15:50:59) >> Am 12.08.19 um 16:43 schrieb Chris Wilson: >>> Quoting Koenig, Christian (2019-08-12 15:34:32) Am 10.08.19 um 17:34 schrieb Chris Wilson: > Move the duplicated code within dma-fence.c into the

Re: [PATCH 29/60] drm/omap: Use the drm_panel_bridge API

2019-08-13 Thread Tomi Valkeinen
On 07/07/2019 21:19, Laurent Pinchart wrote: Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Laurent Pinchart ---

Re: [PATCH 31/60] drm/omap: Add infrastructure to support drm_bridge local to DSS outputs

2019-08-13 Thread Tomi Valkeinen
On 07/07/2019 21:19, Laurent Pinchart wrote: In order to support drm_bridge-based pipeline, the internal HDMI encoders will need to expose the EDID read operation through the drm_bridge API, and thus to expose a drm_bridge instance corresponding to the encoder. The HDMI encoders are however

Re: [PATCH 32/60] drm/omap: dss: Make omap_dss_device_ops optional

2019-08-13 Thread Tomi Valkeinen
On 07/07/2019 21:19, Laurent Pinchart wrote: As part of the move to drm_bridge ops for some of the internal encoders will be removed. Make them optional in the driver to ease the transition. I don't seem to be able to decipher the first sentence. Is there a word or two missing from it?

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-13 Thread Hans de Goede
Hi, On 13-08-19 08:25, Nishka Dasgupta wrote: The static structure vbox_fb_helper_funcs, of type drm_fb_helper_funcs, is used only when it is passed as the third argument to drm_fb_helper_fbdev_setup(), which does not modify it. Hence make it constant to protect it from unintended

Re: [PATCH v12 12/18] kunit: test: add tests for KUnit managed resources

2019-08-13 Thread Brendan Higgins
On Mon, Aug 12, 2019 at 9:31 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-08-12 11:24:15) > > + > > +static int kunit_resource_test_init(struct kunit *test) > > +{ > > + struct kunit_test_resource_context *ctx = > > + kzalloc(sizeof(*ctx), GFP_KERNEL); > >

Re: [PATCH 3/4] dma-fence: Refactor signaling for manual invocation

2019-08-13 Thread Chris Wilson
Quoting Koenig, Christian (2019-08-13 07:59:28) > Am 12.08.19 um 16:53 schrieb Chris Wilson: > > Quoting Koenig, Christian (2019-08-12 15:50:59) > >> Am 12.08.19 um 16:43 schrieb Chris Wilson: > >>> Quoting Koenig, Christian (2019-08-12 15:34:32) > Am 10.08.19 um 17:34 schrieb Chris Wilson: >

[Bug 110886] After S3 resume, kernel: [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:57:crtc-0] flip_done timed out

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110886 --- Comment #7 from Kai-Heng Feng --- I also tried disabling GFXOFF but the same issue still happens: diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c index a24beaa4fb01..62a8394b1f5f 100644

[Bug 107877] deepin-desktop: xdg-email: no method available for opening 'mailto:'

2019-08-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107877 Andre Klapper changed: What|Removed |Added URL|https://mywifiextlogn.com/ | -- You are receiving this mail

Re: [PATCH 30/60] drm/omap: dss: Fix output next device lookup in DT

2019-08-13 Thread Tomi Valkeinen
On 07/07/2019 21:19, Laurent Pinchart wrote: The DSS core looks up the next device connected to an output by traversing the OF graph. It currently hardcodes the local port number to 0, which breaks any output with a different port number (SDI on OMAP3 and any DPI output but the first one). Fix

  1   2   >