Rework TTMs busy handling

2024-01-04 Thread Christian König
Hi guys, I'm trying to make this functionality a bit more useful for years now since we multiple reports that behavior of drivers can be suboptimal when multiple placements be given. So basically instead of hacking around the TTM behavior in the driver once more I've gone ahead and changed the

Re: [PATCH 01/16] accel/ivpu: Dump MMU events in case of VPU boot timeout

2024-01-04 Thread Jeffrey Hugo
On 1/4/2024 4:56 AM, Jacek Lawrynowicz wrote: From: "Wachowski, Karol" Add ivpu_mmu_evtq_dump() function that dumps existing MMU events from MMU event queue. Call this function if VPU boot failed. Previously MMU events were only checked in interrupt handler, but if VPU failed to boot due to

Re: [RFC PATCH v3 23/23] drm/vkms: Add tests for CTM handling

2024-01-04 Thread Harry Wentland
On 2023-12-08 08:32, Pekka Paalanen wrote: > On Wed, 8 Nov 2023 11:36:42 -0500 > Harry Wentland wrote: > >> A whole slew of tests for CTM handling that greatly helped in >> debugging the CTM code. The extent of tests might seem a bit >> silly but they're fast and might someday help save

Re: [PATCH] drm/rockchip: vop2: Drop superfluous include

2024-01-04 Thread Heiko Stübner
Am Donnerstag, 4. Januar 2024, 15:39:49 CET schrieb Cristian Ciocaltea: > The rockchip_drm_fb.h header contains just a single function which is > not directly used by the VOP2 driver. Drop the unnecessary include. > > Signed-off-by: Cristian Ciocaltea applied to drm-misc-next-fixes as commit

[PATCH v2 0/3] Disable dynamic load balancing and support fixed balancing

2024-01-04 Thread Andi Shyti
Hi, This series aims to disable the CCS hardware load balancing, as recommended by hardware directives in Wa_16016805146. In the meantime, we need to define and support a fixed CCS mode of balancing that can be configured by the user. Thanks, Andi Changelog: == v1 -> v2: - update

[PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Andi Shyti
The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one CCS to all the slices. Based on a patch

[PATCH v2 2/3] drm/i915/gt: Allow user to set up the CSS mode

2024-01-04 Thread Andi Shyti
Now that the CCS mode is configurable, an interface has been exposed in the GT's sysfs set of files, allowing users to set the mode. Additionally, another interface has been added to display the number of available slices, named 'num_slices.' Signed-off-by: Andi Shyti Cc: Chris Wilson Cc:

[PATCH v2 3/3] drm/i915/gt: Disable HW load balancing for CCS

2024-01-04 Thread Andi Shyti
The hardware is not able to dynamically balance the load between CCS engines. Wa_16016805146 suggests disabling it for all platforms. Signed-off-by: Andi Shyti Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Niranjana Vishwanathapura Cc: Tejas Upadhyay --- drivers/gpu/drm/i915/gt/intel_gt_regs.h

[PULL] drm-misc-next-fixes

2024-01-04 Thread Maxime Ripard
Hi! Here's this week drm-misc-next-fixes PR Maxime drm-misc-next-fixes-2024-01-04: One fix for drm/plane to avoid a use-after-free and some additional warnings to prevent more of these occurences, a lock inversion dependency fix and an indentation fix for drm/rockchip, and some doc warning

[PATCH 3/4] drm/ttm: improve idle/busy handling v2

2024-01-04 Thread Christian König
Previously we would never try to move a BO into the preferred placements when it ever landed in a busy placement since those were considered compatible. Rework the whole handling and finally unify the idle and busy handling. ttm_bo_validate() is now responsible to try idle placement first and

[PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2024-01-04 Thread Christian König
Try to fill up VRAM as well by setting the busy flag on GTT allocations. This fixes the issue that when VRAM was evacuated for suspend it's never filled up again unless the application is restarted. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++ 1

[PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Christian König
Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index edf10618fe2b..8c1eaa74fa21 100644 ---

[PATCH 2/4] drm/ttm: replace busy placement with flags v4

2024-01-04 Thread Christian König
From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ERROR on drm-tip/drm-tip v4: fix some typos pointed

[RFC][PATCH v7 0/9] drm/panic: Add a drm panic handler

2024-01-04 Thread Jocelyn Falempe
This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when disabling VT/fbcon in the kernel: https://www.reddit.com/r/linux/comments/10eccv9/config_vtn_in_2023/ Fbcon

[PATCH v7 2/9] drm/panic: Add a drm panic handler

2024-01-04 Thread Jocelyn Falempe
This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer() instead of the drm client API. (Thomas Zimmermann) * Add the panic reason to the panic message (Nerdopolis)

[PATCH v7 5/9] drm/fb_dma: Add generic get_scanout_buffer() for drm_panic

2024-01-04 Thread Jocelyn Falempe
This was initialy done for imx6, but should work on most drivers using drm_fb_dma_helper. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_fb_dma_helper.c | 55 + include/drm/drm_fb_dma_helper.h | 4 +++ 2 files changed, 59 insertions(+) diff --git

[PATCH v7 4/9] drm/panic: Add drm_panic_is_format_supported()

2024-01-04 Thread Jocelyn Falempe
So driver knows early if drm_panic will be able to display something on the current scanout buffer. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 13 + include/drm/drm_panic.h | 4 2 files changed, 17 insertions(+) diff --git

[PATCH v7 1/9] drm/format-helper: Add drm_fb_blit_from_r1 and drm_fb_fill

2024-01-04 Thread Jocelyn Falempe
This is needed for drm_panic, to draw the font, and fill the background color, in multiple color format. v5: * Change the drawing API, use drm_fb_blit_from_r1() to draw the font. * Also add drm_fb_fill() to fill area with background color. v6: * fix __le32 conversion warning found by the

[PATCH v7 6/9] drm/simpledrm: Add drm_panic support

2024-01-04 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c

[PATCH v7 7/9] drm/mgag200: Add drm_panic support

2024-01-04 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v5: * Also check that the plane is visible and primary. (Thomas Zimmermann) v7: * use drm_for_each_primary_visible_plane() Signed-off-by: Jocelyn Falempe ---

[PATCH v7 3/9] drm/plane: Add drm_for_each_primary_visible_plane macro

2024-01-04 Thread Jocelyn Falempe
To support drm_panic, most drivers need to find the current primary visible plane with a framebuffer attached. Signed-off-by: Jocelyn Falempe --- include/drm/drm_plane.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index

[PATCH v7 9/9] drm/imx: Add drm_panic support

2024-01-04 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. v7: * use drm_panic_gem_get_scanout_buffer() helper Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v7 8/9] drm/ast: Add drm_panic support

2024-01-04 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. v7 * Use drm_for_each_primary_visible_plane() Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 26 -- 1 file changed, 24 insertions(+), 2

[PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-04 Thread Christian König
Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index edf10618fe2b..8c1eaa74fa21 100644 ---

Re: [PATCH] drm/rockchip: vop2: Drop unused if_dclk_rate variable

2024-01-04 Thread Heiko Stübner
Hi Christian, Andy, Am Donnerstag, 4. Januar 2024, 15:39:50 CET schrieb Cristian Ciocaltea: > Commit 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") > introduced a variable which ended up being unused. Remove it. > > rockchip_drm_vop2.c:1688:23: warning: variable ‘if_dclk_rate’ set

Re: [git pull] drm fixes for 6.8

2024-01-04 Thread Linus Torvalds
On Wed, 3 Jan 2024 at 18:30, Dave Airlie wrote: > > These were from over the holiday period, mainly i915, a couple of > qaic, bridge and an mgag200. > > I have a set of nouveau fixes that I'll send after this, that might be > too rich for you at this point. > > I expect there might also be some

DRM TTM stack trace dump on ancient hardware

2024-01-04 Thread Olliver Schinagl
Sorry for just dumping this here, but for those that think this is important, just rebooted after a weird btrfs crash (remounted r/o, no dataloss it seems), probably a new kernel, and got duped with the following. Things 'seem' to work fine however. I don't even know how or where to google for

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2024-01-04 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, December 15, 2023 2:24 PM > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Fri, Dec 15, 2023 at 01:25:48PM +, Biju Das wrote: > > Hi Maxime Ripard, > > > > > -Original

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Tvrtko Ursulin
On 04/01/2024 14:35, Andi Shyti wrote: The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one

Re: [PATCH 1/3] drm: property: One function call less in drm_property_create() after error detection

2024-01-04 Thread Dan Carpenter
On Wed, Jan 03, 2024 at 06:18:13PM +0100, Michel Dänzer wrote: > On 2024-01-03 17:24, Markus Elfring wrote: > > > >> Out of curiosity, what exactly did Coccinelle report? > > > > Some SmPL scripts from my own selection tend to point questionable > > implementation details out. > > That doesn't

Re: [PATCH 0/2] drm/panel: ltk050h3146w: error-path debug message improvements

2024-01-04 Thread Heiko Stuebner
On Thu, 4 Jan 2024 13:41:56 +0100, Quentin Schulz wrote: > This hides an error message if EPROBE_DEFER was returned when trying to > get the reset GPIO. > > This also makes use of dev_err_probe in lieu of hand-crafted logic > inside the driver. > > Thanks, > Quentin > > [...] Applied, thanks!

Re: linux-next: build warning after merge of the drm tree

2024-01-04 Thread Jani Nikula
On Wed, 03 Jan 2024, Stephen Rothwell wrote: > OK, the only thing I can find is that there are 2 intel_wakeref.h files > that have different definitions for intel_wakeref_t: > > ./drivers/gpu/drm/i915/intel_wakeref.h:typedef unsigned long intel_wakeref_t; >

[pull] amdgpu drm-fixes-6.7

2024-01-04 Thread Alex Deucher
Hi Dave, Sima, Happy New Year! Fixes for 6.7. The changes for SMU 13.0.6 are relatively big, but it's a new IP added in 6.7 and the changes are isolated to that IP so it should not affect anything else and this should make the IP fully functional for the 6.7 release. The rest are just bug fixes

Re: [git pull] drm fixes for 6.8

2024-01-04 Thread pr-tracker-bot
The pull request you sent on Thu, 4 Jan 2024 12:29:55 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-01-04 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5939a693dc6e6d6f293681017c70ff60c3723d43 Thank you! -- Deet-doot-dot, I am a bot.

[PATCH] drm/rockchip: vop2: Drop superfluous include

2024-01-04 Thread Cristian Ciocaltea
The rockchip_drm_fb.h header contains just a single function which is not directly used by the VOP2 driver. Drop the unnecessary include. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] drm/rockchip: vop2: Drop unused if_dclk_rate variable

2024-01-04 Thread Cristian Ciocaltea
Commit 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") introduced a variable which ended up being unused. Remove it. rockchip_drm_vop2.c:1688:23: warning: variable ‘if_dclk_rate’ set but not used [-Wunused-but-set-variable] Signed-off-by: Cristian Ciocaltea ---

Re: DRM TTM stack trace dump on ancient hardware

2024-01-04 Thread Christian König
Hi Olliver, well as long as you don't explicitly disable the support for the older hw generations the R7 250 is still supported and should still work perfectly fine. What you see here is basically some reference counting issue, most likely in the display code. Question to Alex and Harry

Re: DRM TTM stack trace dump on ancient hardware

2024-01-04 Thread Harry Wentland
Oland is DCE 6 and won't default to DC. Harry On 2024-01-04 10:51, Christian König wrote: > Hi Olliver, > > well as long as you don't explicitly disable the support for the older hw > generations the R7 250 is still supported and should still work perfectly > fine. > > What you see here is

[PATCH v3 1/3] drm/i915: Enable Wa_16019325821

2024-01-04 Thread John . C . Harrison
From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 19

[PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160

2024-01-04 Thread John . C . Harrison
From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar ---

[PATCH v3 2/3] drm/i915/guc: Add support for w/a KLVs

2024-01-04 Thread John . C . Harrison
From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison Reviewed-by: Vinay Belgaumkar --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 +

[PATCH v3 0/3] Enable Wa_14019159160 and Wa_16019325821 for MTL

2024-01-04 Thread John . C . Harrison
From: John Harrison Enable Wa_14019159160 and Wa_16019325821 for MTL RCS/CCS workarounds for MTL. v2: Fix bug in WA KLV implementation (offset not being reset to start of list). Add better comment to prep patch about how KLVs can be added. Add a module parameter override and disable the w/a

Re: [RFC PATCH v3 21/23] drm/vkms: add 3x4 matrix in color pipeline

2024-01-04 Thread Harry Wentland
On 2023-12-08 08:11, Pekka Paalanen wrote: > On Wed, 8 Nov 2023 11:36:40 -0500 > Harry Wentland wrote: > >> We add two 3x4 matrices into the VKMS color pipeline. The reason >> we're adding matrices is so that we can test that application >> of a matrix and its inverse yields an output equal

Re: [PATCH] drm/rockchip: vop2: Drop unused if_dclk_rate variable

2024-01-04 Thread Cristian Ciocaltea
Hi Heiko, On 1/4/24 17:58, Heiko Stübner wrote: > Hi Christian, Andy, > > Am Donnerstag, 4. Januar 2024, 15:39:50 CET schrieb Cristian Ciocaltea: >> Commit 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") >> introduced a variable which ended up being unused. Remove it. >> >>

Re: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe

2024-01-04 Thread Francesco Dolcini
On Mon, Dec 18, 2023 at 11:57:15AM +0100, Alexander Stein wrote: > This simplifies the code and gives additional information upon deferral. > > Signed-off-by: Alexander Stein Reviewed-by: Francesco Dolcini

Re: [PATCH v3 0/7] dma-buf: heaps: Add secure heap

2024-01-04 Thread Jeffrey Kardatzke
Any feedback from maintainers on what their preference is? I'm fine with 'restricted' as well, but the main reason we chose secure was because of its use in ARM nomenclature and this is more for ARM usage than x86. The main difference with similar buffers on AMD/Intel is that with AMD/Intel the

Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag

2024-01-04 Thread Jeffrey Kardatzke
On Mon, Dec 11, 2023 at 3:05 AM Hans Verkuil wrote: > > On 06/12/2023 09:15, Yunfei Dong wrote: > > From: Jeffrey Kardatzke > > > > Adds documentation for V4L2_MEMORY_FLAG_SECURE. > > > > Signed-off-by: Jeffrey Kardatzke > > Signed-off-by: Yunfei Dong > > --- > >

Re: [git pull] drm fixes for 6.8

2024-01-04 Thread Dave Airlie
On Fri, 5 Jan 2024 at 04:50, Linus Torvalds wrote: > > On Wed, 3 Jan 2024 at 18:30, Dave Airlie wrote: > > > > These were from over the holiday period, mainly i915, a couple of > > qaic, bridge and an mgag200. > > > > I have a set of nouveau fixes that I'll send after this, that might be > > too

Re: (subset) linux-next: build failure after merge of the pwm tree

2024-01-04 Thread Stephen Rothwell
Hi all, On Thu, 4 Jan 2024 12:50:28 + Sean Young wrote: > > On Thu, Jan 04, 2024 at 05:02:41PM +0700, Bagas Sanjaya wrote: > > [also add Jingoo (additional backlight maintainer) and Linus] > > > > On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote: > > > On Thu, Dec 21, 2023

RE: [EXT] Re: [PATCH v11 4/7] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-01-04 Thread Sandor Yu
Hi Alexander, Thanks for your comments, > > Hi Sandor, > > thanks for the patch. > > Am Dienstag, 17. Oktober 2023, 09:04:00 CEST schrieb Sandor Yu: > > Add a new DRM DisplayPort and HDMI bridge driver for Candence > MHDP8501 > > used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort >

RE: [EXT] Re: [PATCH v11 6/7] phy: freescale: Add DisplayPort PHY driver for i.MX8MQ

2024-01-04 Thread Sandor Yu
Hi Alexander, Thanks for your comments, > -Original Message- > From: Alexander Stein > > Hi Sandor, > > thanks for the patch. > > Am Dienstag, 17. Oktober 2023, 09:04:02 CEST schrieb Sandor Yu: > > Add Cadence HDP-TX DisplayPort PHY driver for i.MX8MQ > > > > Cadence HDP-TX PHY could be

RE: [EXT] Re: [PATCH v11 7/7] phy: freescale: Add HDMI PHY driver for i.MX8MQ

2024-01-04 Thread Sandor Yu
Hi Alexander, Thanks for your comments, > -Original Message- > From: Alexander Stein > Sent: 2023年10月17日 21:17 > To: dmitry.barysh...@linaro.org; andrzej.ha...@intel.com; > neil.armstr...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com;

RE: [EXT] Re: [PATCH v11 1/7] drm: bridge: Cadence: Creat mhdp helper driver

2024-01-04 Thread Sandor Yu
Hi Alexander, Thanks for your comments, > > Hi Sandor, > > thanks for the update. > > One small typo in the commit message: 'Creat' -> 'Create' > > Am Dienstag, 17. Oktober 2023, 09:03:57 CEST schrieb Sandor Yu: > > MHDP8546 mailbox access functions will be share to other mhdp driver > > and

[PATCH] fbdev/vt8500lcdfb: Remove unnecessary print function dev_err()

2024-01-04 Thread Jiapeng Chong
The print function dev_err() is redundant because platform_get_irq() already prints an error. ./drivers/video/fbdev/vt8500lcdfb.c:377:2-9: line 377 is redundant because platform_get_irq() already prints an error. Reported-by: Abaci Robot Closes:

[PATCH 3/3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2024-01-04 Thread Jani Nikula
hdmi-codec.h does not appear to directly need drm/drm_edid.h for anything. Remove it. There are some files that get drm/drm_edid.h by proxy; include it where needed. v2-v4: Fix build (kernel test robot ) Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: Marijn Suijten

[PATCH 1/3] drm/nouveau: include drm/drm_edid.h only where needed

2024-01-04 Thread Jani Nikula
Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 files when drm_edid.h is modified, while there are only a few files that actually need to include drm_edid.h. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula

[PATCH 2/3] drm/hisilicon: include drm/drm_edid.h only where needed

2024-01-04 Thread Jani Nikula
Reduce the need for rebuilds when drm_edid.h is modified by including it only where needed. Cc: Xinliang Liu Cc: Tian Tao Cc: Xinwei Kong Cc: Sumit Semwal Cc: Yongqin Liu Cc: John Stultz Signed-off-by: Jani Nikula --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 -

Re: (subset) linux-next: build failure after merge of the pwm tree

2024-01-04 Thread Bagas Sanjaya
On Thu, Jan 04, 2024 at 12:50:28PM +, Sean Young wrote: > On Thu, Jan 04, 2024 at 05:02:41PM +0700, Bagas Sanjaya wrote: > > [also add Jingoo (additional backlight maintainer) and Linus] > > > > On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote: > > > On Thu, Dec 21, 2023 at

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-04 Thread Andi Shyti
Hi Tvrtko, [1] > > + /* > > +* Loop over all available slices and assign each a user engine. > > +* > > +* With 1 engine (ccs0): > > +* slice 0, 1, 2, 3: ccs0 > > +* > > +* With 2 engines (ccs0, ccs1): > > +* slice 0, 2: ccs0 > > +* slice 1, 3: ccs1 > > +

Re: [PATCH v3,02/21] v4l2: handle secure memory flags in queue setup

2024-01-04 Thread Jeffrey Kardatzke
Yunfei, Can you please integrate these changes into the patch? Thanks, Jeff On Mon, Dec 11, 2023 at 2:45 AM Hans Verkuil wrote: > > Hi Yunfei, Jeffrey, > > Some comments below: > > On 06/12/2023 09:15, Yunfei Dong wrote: > > From: Jeffrey Kardatzke > > > > Validates the secure memory flags

Re: [PATCH 2/4] drm/ttm: replace busy placement with flags v4

2024-01-04 Thread Zack Rusin
On Thu, Jan 4, 2024 at 10:05 AM Christian König wrote: > > From: Somalapuram Amaranath > > Instead of a list of separate busy placement add flags which indicate > that a placement should only be used when there is room or if we need to > evict. > > v2: add missing TTM_PL_FLAG_IDLE for i915 > v3:

[RESEND] drm/edid: prefer forward declarations over includes in drm_edid.h

2024-01-04 Thread Jani Nikula
There's no need to include either linux/hdmi.h or drm/drm_mode.h. They can be removed by using forward declarations. While at it, group the forward declarations together, and remove the unnecessary ones. Signed-off-by: Jani Nikula --- include/drm/drm_edid.h | 12 +--- 1 file changed, 5

Re: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe

2024-01-04 Thread Francesco Dolcini
On Thu, Jan 04, 2024 at 08:20:37PM +0100, Francesco Dolcini wrote: > On Mon, Dec 18, 2023 at 11:57:15AM +0100, Alexander Stein wrote: > > This simplifies the code and gives additional information upon deferral. > > > > Signed-off-by: Alexander Stein > Reviewed-by: Francesco Dolcini mumble,

Re: [PATCH v3, 03/21] v4l2: verify secure dmabufs are used in secure queue

2024-01-04 Thread Jeffrey Kardatzke
On Mon, Dec 11, 2023 at 2:58 AM Hans Verkuil wrote: > > On 06/12/2023 09:15, Yunfei Dong wrote: > > From: Jeffrey Kardatzke > > > > Verfies in the dmabuf implementations that if the secure memory flag is > > Verfies -> Verifies Thanks. Yunfei, change that please. > > > set for a queue that the

Re: [PATCH] drm/i915/huc: Allow for very slow HuC loading

2024-01-04 Thread Daniele Ceraolo Spurio
On 1/2/2024 2:22 PM, john.c.harri...@intel.com wrote: From: John Harrison A failure to load the HuC is occasionally observed where the cause is believed to be a low GT frequency leading to very long load times. So a) increase the timeout so that the user still gets a working system even in

[git pull] drm fixes (part2) for 6.7 final

2024-01-04 Thread Dave Airlie
Hi Linus, Hopefully I got the version numbers right this time. This is the final set of fixes I think, some amdgpu and nouveau. Since I suspect this is a bit larger than you might be comfortable with, I'll give some more info: The amdgpu ones are fairly normal, the one that is a bit large is a

Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

2024-01-04 Thread 胡俊光

[PATCH v2 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02

2024-01-04 Thread Artur Weber
It turns out that I had misconfigured the device I was using the panel with; the bus data polarity is not high for this panel, I had to change the config on the display controller's side. Fix the panel config to properly reflect its accurate settings. Fixes: 6810bb390282 ("drm/panel: Add Samsung

[PATCH v2 0/2] Fix panel polarity mixup in S6D7AA0 panel driver and Galaxy Tab 3 8.0 DTSI

2024-01-04 Thread Artur Weber
Two small one-line patches to address a mixup in the Samsung S6D7AA0 panel driver and the Samsung Galaxy Tab 3 8.0 board it was initially added for. Signed-off-by: Artur Weber --- Changes in v2: - Add "Fixes" tag to both commits. - Link to v1:

[PATCH v2 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd

2024-01-04 Thread Artur Weber
After more investigation, I've found that it's not the panel driver config that needs to be modified to invert the data polarity, but the FIMD config. Add the missing invert-vclk option that is required to get the display to work correctly. Fixes: ee37a457af1d ("ARM: dts: exynos: Add Samsung

[linux-next:master] BUILD REGRESSION d0b3c8aa5e37775cd7c3ac07b256218df0fd6678

2024-01-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d0b3c8aa5e37775cd7c3ac07b256218df0fd6678 Add linux-next specific files for 20240104 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202401041942.qrb1amzm-...@intel.com Error

Re: [PATCH] drm: Check output polling initialized before disabling

2024-01-04 Thread Shradha Gupta
On Wed, Dec 27, 2023 at 02:33:17AM -0800, Saurabh Singh Sengar wrote: > On Tue, Dec 26, 2023 at 11:27:15PM -0800, Shradha Gupta wrote: > > In drm_mode_config_helper_suspend() check if output polling > > support is initialized before enabling/disabling polling. > > For drivers like hyperv-drm, that

Re: [PATCH -next] drm/nouveau: uapi: fix kerneldoc warnings

2024-01-04 Thread Randy Dunlap
On 1/2/24 19:10, Randy Dunlap wrote: > Hi Vegard, > > On 12/25/23 09:08, Randy Dunlap wrote: >> >> >> On 12/25/23 00:30, Vegard Nossum wrote: >>> >>> On 25/12/2023 08:40, Randy Dunlap wrote: I do see one thing that I don't like in the generated html output. It's not a problem with

Re: [PATCH v7 4/9] drm/panic: Add drm_panic_is_format_supported()

2024-01-04 Thread kernel test robot
Hi Jocelyn, kernel test robot noticed the following build warnings: [auto build test WARNING on 50a3c772bd927dd409c484832ddd9f6bf00b7389] url: https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-format-helper-Add-drm_fb_blit_from_r1-and-drm_fb_fill/20240105-001038 base:

linux-next: build warning after merge of the drm tree

2024-01-04 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced this warning: Warning: /sys/devices/.../hwmon/hwmon/curr1_crit is defined 2 times: /home/s fr/next/next/Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:35 /home/sfr

Re: [PATCH] drm: Check output polling initialized before disabling

2024-01-04 Thread Saurabh Singh Sengar
On Thu, Jan 04, 2024 at 09:19:42PM -0800, Shradha Gupta wrote: > On Wed, Dec 27, 2023 at 02:33:17AM -0800, Saurabh Singh Sengar wrote: > > On Tue, Dec 26, 2023 at 11:27:15PM -0800, Shradha Gupta wrote: > > > In drm_mode_config_helper_suspend() check if output polling > > > support is initialized

Re: [PATCH v4 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

2024-01-04 Thread Krzysztof Kozlowski
On 04/01/2024 09:41, Dario Binacchi wrote: > The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the > Novatek NT35510-based panel family. > > Signed-off-by: Dario Binacchi > > --- > > Changes in v4: > - Put the "enum" list in alphabetical order > Acked-by: Krzysztof

[PATCH v1] drm/ci: add sc7180-trogdor-kingoftown

2024-01-04 Thread Vignesh Raman
Add job that executes the IGT test suite for sc7180-trogdor-kingoftown. This commit also updates xfails for sc7180-trogdor-lazor-limozeen. Signed-off-by: Vignesh Raman --- See pipeline: https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1069934 --- drivers/gpu/drm/ci/build.sh

Re: (subset) [PATCH v4 00/29] Add HDMI support for RK3128

2024-01-04 Thread Heiko Stuebner
On Fri, 22 Dec 2023 18:41:51 +0100, Alex Bee wrote: > This is version 4 of my series that aims to add support for the display > controller (VOP) and the HDMI controller block of RK3128 (which is very > similar to the one found in RK3036). The original intention of this series > was to add support

Re: [PATCH] drm/rockchip: analogix_dp: get encoder port ID from DT

2024-01-04 Thread Heiko Stuebner
On Wed, 3 Jan 2024 19:13:01 +0100, Lucas Stach wrote: > The VOP2 driver needs this port ID to properly configure the > display data routing. > > Applied, thanks! [1/1] drm/rockchip: analogix_dp: get encoder port ID from DT commit: bb056046c2139c72e20a5b6fc39c9caaf9eac2b8 Best regards,

Re: [PATCH v3 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

2024-01-04 Thread Krzysztof Kozlowski
On 04/01/2024 08:23, Dario Binacchi wrote: > The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the > Novatek NT35510-based panel family. > > Signed-off-by: Dario Binacchi > > --- > > Changes in v3: > - Use "enum" to have less code changed > > Changes in v2: > - Add a dash in

Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

2024-01-04 Thread 胡俊光

Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

2024-01-04 Thread 胡俊光

[PATCH v4 8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK

2024-01-04 Thread Dario Binacchi
The initialization commands are taken from the STMicroelectronics driver found at [1]. To ensure backward compatibility, flags have been added to enable gamma correction setting and display control. In other cases, registers have been set to their default values according to the specifications

[PATCH v4 0/8] Add display support for stm32f769-disco board

2024-01-04 Thread Dario Binacchi
The series adds display support for the stm32f769-disco board. It has been tested on hardware revisions MB1225-B03 and MB1166-A09. This required modifications to the nt35510 driver. As I do not have the Hydis HVA40WV1 display, it would be better if someone tested the driver in that configuration.

[PATCH v4 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

2024-01-04 Thread Dario Binacchi
The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the Novatek NT35510-based panel family. Signed-off-by: Dario Binacchi --- Changes in v4: - Put the "enum" list in alphabetical order Changes in v3: - Use "enum" to have less code changed Changes in v2: - Add a dash in front

[PATCH v4 7/8] drm/panel: nt35510: move hardwired parameters to configuration

2024-01-04 Thread Dario Binacchi
This patch, preparatory for future developments, move the hardwired parameters to configuration data to allow the addition of new NT35510-based panels. Signed-off-by: Dario Binacchi --- (no changes since v2) Changes in v2: - Re-write the patch [7/8] "drm/panel: nt35510: refactor panel

Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

2024-01-04 Thread 胡俊光

Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

2024-01-04 Thread 胡俊光

[bug report] drm/xe: Introduce a new DRM driver for Intel GPUs

2024-01-04 Thread Dan Carpenter
Hello Matthew Brost, The patch dd08ebf6c352: "drm/xe: Introduce a new DRM driver for Intel GPUs" from Mar 30, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/tests/xe_bo.c:298 evict_test_run_tile() error: double unlocked

Re: [1/3] drm: property: One function call less in drm_property_create() after error detection

2024-01-04 Thread Michel Dänzer
On 2024-01-03 19:08, Markus Elfring wrote: > >> Without seeing the actual Coccinelle report, > > There is no “official” report according to the discussed patch which is > triggered > by known advices for the application of labels in goto chains. The commit log says: This issue was detected

Re: [PATCH v2 0/2] drm/rockchip: lvds: improve erroring out when drm_of_find_panel_or_bridge fails

2024-01-04 Thread Heiko Stuebner
On Mon, 20 Nov 2023 13:29:47 +0100, Quentin Schulz wrote: > drm_of_find_panel_or_bridge may return a different error code than > EPROBE_DEFER so let's not overwrite it. > > At the same time, let's demote the DRM_DEV_ERROR message to > dev_err_probe so that the scary message isn't shown (by

RE: [PATCH v2] drm: rcar-du: Fix memory leak in rcar_du_vsps_init()

2024-01-04 Thread Biju Das
Hi Laurent, > Subject: Re: [PATCH v2] drm: rcar-du: Fix memory leak in > rcar_du_vsps_init() > > Hi Biju, > > Thank you for the patch. > > On Thu, Nov 16, 2023 at 12:24:24PM +, Biju Das wrote: > > The rcar_du_vsps_init() doesn't free the np allocated by > >

Re: (subset) linux-next: build failure after merge of the pwm tree

2024-01-04 Thread Bagas Sanjaya
[also add Jingoo (additional backlight maintainer) and Linus] On Thu, Dec 21, 2023 at 07:34:57PM +0100, Thierry Reding wrote: > On Thu, Dec 21, 2023 at 12:58:01PM +, Lee Jones wrote: > > On Thu, 21 Dec 2023, Lee Jones wrote: > > > > > On Thu, 21 Dec 2023 16:58:05 +1100, Stephen Rothwell

[PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-01-04 Thread Jouni Högander
Add definitions for panel replay selective update Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index

Re: [PATCH 10/12] drm/panelreplay: dpcd register definition for panelreplay SU

2024-01-04 Thread Dmitry Baryshkov
On Thu, 4 Jan 2024 at 12:49, Jouni Högander wrote: > > Add definitions for panel replay selective update > > Cc: dri-devel@lists.freedesktop.org > 1) This CC should not be necessary. It is already a part of maintainers entry for this file 2) It probably doesn't work as expected. It is separated

RE: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()

2024-01-04 Thread Biju Das
Hi Laurent, > Subject: Re: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the > comment in rzg2l_mipi_dsi_start_video() > > Hi Biju, > > On Thu, Nov 16, 2023 at 10:58:56AM +, Biju Das wrote: > > Hi All, > > > > Gentle ping. It is reviewed by both Laurent and Geert. > > > > Can it be

[Bug 213145] AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!"

2024-01-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213145 mikkk (mikk...@gmail.com) changed: What|Removed |Added CC||mikk...@gmail.com ---

Re: [PATCH 08/11] nouveau/gsp: don't free ctrl messages on errors

2024-01-04 Thread Dan Carpenter
On Thu, Jan 04, 2024 at 10:41:50AM +1000, Dave Airlie wrote: > On Thu, 4 Jan 2024 at 00:47, Dan Carpenter wrote: > > > > Hi Dave, > > > > kernel test robot noticed the following build warnings: > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: > >

RE: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI panel

2024-01-04 Thread Ritesh Kumar
Hi Krzysztof, >-Original Message- >From: Krzysztof Kozlowski >Sent: Friday, December 22, 2023 9:02 PM >To: Ritesh Kumar (QUIC) ; dri- >de...@lists.freedesktop.org; devicet...@vger.kernel.org; linux- >ker...@vger.kernel.org >Cc: neil.armstr...@linaro.org; Jessica Zhang (QUIC) >;

  1   2   >