Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-23 Thread Intel
On 2/23/21 11:59 AM, Daniel Vetter wrote: tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices,

Re: linux-next: Tree for Feb 24 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko]

2021-02-23 Thread Randy Dunlap
On 2/23/21 7:36 PM, Stephen Rothwell wrote: > Hi all, > > Please do not add any changes destined for v5.13 to your linux-next > included branches until after v5.12-rc1 has been released. > > Changes since 20210223: > on i386: ERROR: modpost: "__udivdi3" [drive

[PATCH v4 2/2] drm/bridge: anx7625: disable regulators when power off

2021-02-23 Thread Hsin-Yi Wang
When suspending the driver, anx7625_power_standby() will be called to turn off reset-gpios and enable-gpios. However, power supplies are not disabled. To save power, the driver can get the power supply regulators and turn off them in anx7625_power_standby(). Signed-off-by: Hsin-Yi Wang

[PATCH v4 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

2021-02-23 Thread Hsin-Yi Wang
anx7625 requires 3 power supply regulators. Signed-off-by: Hsin-Yi Wang Reviewed-by: Rob Herring Reviewed-by: Robert Foss --- v3->v4: rebase to drm-misc/for-linux-next --- .../bindings/display/bridge/analogix,anx7625.yaml | 15 +++ 1 file changed, 15 insertions(+) diff --git

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 16:45 schrieb Alan Stern: On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -29,6 +29,7 @@ #include #include #include

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 18:30 schrieb Greg KH: On Tue, Feb 23, 2021 at 11:00:54AM -0500, Alan Stern wrote: On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: Hi Am 23.02.21 um 14:44 schrieb Takashi Iwai: Aside from the discussion whether this "workaround" is needed, the use of

RE: [PATCH] drm/ttm: Do not add non-system domain BO into swap list

2021-02-23 Thread Chen, Guchun
[AMD Public Use] Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, February 24, 2021 11:35 AM To: Pan, Xinhui Cc: Deucher, Alexander ; Maling list - DRI developers ; Koenig, Christian ; amd-gfx list Subject: Re:

[PATCH V1 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5

2021-02-23 Thread Kiran Gunda
Currently, for WLED5, after FSC register update MOD_SYNC_BIT is toggled instead of SYNC_BIT. MOD_SYNC_BIT has to be toggled after the brightness update and SYNC_BIT has to be toggled after FSC update for WLED5. Fix it. Signed-off-by: Kiran Gunda --- drivers/video/backlight/qcom-wled.c | 25

[PATCH V1 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

2021-02-23 Thread Kiran Gunda
Currently the FSC SYNC_BIT and MOD_SYNC_BIT are toggled from 1 to 0 to update the FSC and brightenss settings. Change this sequence form 0 to 1 as per the hardware team recommendation to update the FSC and brightness correctly. Signed-off-by: Kiran Gunda --- drivers/video/backlight/qcom-wled.c

[PATCH V1 0/2] Fix WLED FSC Sync and brightness Sync settings

2021-02-23 Thread Kiran Gunda
The FSC (Full scale current) setting is not updated properly due to the wrong register toggling for WLED5. Also the ILED_SYNC toggle and MOD_SYNC toggle sequence is updated as per the hardware team recommendation to fix the FSC update and brightness update issue. Kiran Gunda (2): backlight:

Re: [PATCH V1 0/2] Fix WLED FSC Sync and brightness Sync settings

2021-02-23 Thread kgunda
On 2021-02-19 23:38, Pavel Machek wrote: Hi! The FSC (Full scale current) setting is not updated properly due to the wrong register toggling for WLED5. Also the ILED_SYNC toggle and MOD_SYNC toggle sequence is updated as per the hardware team recommendation to fix the FSC update and

Re: [PATCH] drm/ttm: Do not add non-system domain BO into swap list

2021-02-23 Thread Alex Deucher
On Tue, Feb 23, 2021 at 10:28 PM xinhui pan wrote: > > BO would be added into swap list if it is validated into system domain. > If BO is validated again into non-system domain, say, VRAM domain. It > actually should not be in the swap list. > > Signed-off-by: xinhui pan Acked-by: Alex Deucher

[PATCH] drm/ttm: Do not add non-system domain BO into swap list

2021-02-23 Thread xinhui pan
BO would be added into swap list if it is validated into system domain. If BO is validated again into non-system domain, say, VRAM domain. It actually should not be in the swap list. Signed-off-by: xinhui pan --- drivers/gpu/drm/ttm/ttm_bo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2] drm/nouveau/kms/nvd9-nv138: Fix CRC calculation for the cursor channel

2021-02-23 Thread Lyude Paul
Something that didn't get noticed until I started running cursor tests: we're accidentally disabling an option for CRC calculation that's enabled by default: WidePipeCrc, which controls whether we use the full width of the data in the display pipe in order calculate CRCs. Having this disabled

[PATCH] dt-bindings: display: mediatek, dpi: Convert to use graph schema

2021-02-23 Thread Rob Herring
Update the mediatek,dpi binding to use the graph schema. Missed this one from the mass conversion since it's not part of drm-misc. Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Matthias Brugger Cc: CK Hu Cc: Jitao shi Cc: dri-devel@lists.freedesktop.org Cc: linux-media...@lists.infradead.org

Re: [PATCH] drm/panel: kd35t133: allow using non-continuous dsi clock

2021-02-23 Thread Heiko Stuebner
On Sat, 6 Feb 2021 14:50:20 +0100, Heiko Stuebner wrote: > The panel is able to work when dsi clock is non-continuous, thus > the system power consumption can be reduced using such feature. > > Add MIPI_DSI_CLOCK_NON_CONTINUOUS to panel's mode_flags. > > Also the flag actually becomes necessary

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Heiko Stuebner
On Tue, 11 Aug 2020 16:26:31 -0400, Alyssa Rosenzweig wrote: > The AFBC decoder used in the Rockchip VOP assumes the use of the > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > buffers, which covers the RGBA8 and RGB565 formats supported in > vop_convert_afbc_format. Use of YTR

[PATCH] drm/xen: adjust Kconfig

2021-02-23 Thread Jan Beulich
By having selected DRM_XEN, I was assuming I would build the frontend driver. As it turns out this is a dummy option, and I have really not been building this (because I had DRM disabled). Make it a promptless one, moving the "depends on" to the other, real option, and "select"ing the dummy one.

[PATCH][next] drm/i915/hdcp: Fix null pointer dereference of connector->encoder

2021-02-23 Thread Colin King
From: Colin Ian King The recent commit 6c63e6e14da7 ("drm/i915/hdcp: No HDCP when encoder is't initialized") added a null pointer check on connector->encoder hence implying that it could potentially be null. This means that the initialization of dig_port via the call intel_attached_dig_port may

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Daniel Stone
Hi Brian, On Tue, 23 Feb 2021 at 18:34, Brian Starkey wrote: > On Tue, Feb 23, 2021 at 05:10:16PM +, Alyssa Rosenzweig wrote: > > But it seems to me allowing > > both BGR+YTR and RGB+YTR upstream is the better route than simply > > preventing hardware from using AFBC at all, and there are

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
On Tue, Feb 23, 2021 at 05:10:16PM +, Alyssa Rosenzweig wrote: > > If YTR can't be turned off, then according to the AFBC spec - correct. > > There is no public AFBC spec, so I'm not sure how to respond to this. > > > If the hardware allows it to be configured to use YTR with other > >

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-02-23 Thread Simon Ser
Pushed, thanks! ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Ilia Mirkin
On Tue, Feb 23, 2021 at 11:23 AM Alex Riesen wrote: > > Alex Riesen, Tue, Feb 23, 2021 16:51:26 +0100: > > Ilia Mirkin, Tue, Feb 23, 2021 16:46:52 +0100: > > > I'd recommend using xf86-video-nouveau in any case, but some distros > > > > I would like try this out. Do you know how to force the xorg

[PATCH v4 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

2021-02-23 Thread Adrien Grassein
Lontium Lt8912 is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein --- MAINTAINERS | 1 + drivers/gpu/drm/bridge/Kconfig | 14 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/lontium-lt8912.c | 764 4

[PATCH v4 1/2] dt-bindings: display: bridge: Add documentation for LT8912

2021-02-23 Thread Adrien Grassein
Lontium LT8912 is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein Reviewed-by: Rob Herring --- .../display/bridge/lontium,lt8912.yaml| 102 ++ MAINTAINERS | 5 + 2 files changed, 107 insertions(+) create mode 100644

[PATCH v4 0/2] Add support of Lontium lt8912 MIPI to HDMI bridge

2021-02-23 Thread Adrien Grassein
Hi, this patch set adds the support of the Lontium lt8912 MIPI to HDMI bridge in the kernel. It's only support the video part, not the audio part yet since I don't have the datasheet of this component. I get the current i2c configuration from Digi and Boundary drivers. Developed using the

Re: [PATCH] drm: Fix HDMI_STATIC_METADATA_TYPE1 constant.

2021-02-23 Thread Mario Kleiner
On Wed, Feb 10, 2021 at 10:14 PM Simon Ser wrote: > > On Wednesday, February 10th, 2021 at 10:04 PM, Mario Kleiner > wrote: > > > Ping! > > I now understand the problem better. > > Reviewed-by: Simon Ser > > I'll push to drm-misc-next in a few days if no-one complains. Ping me > again if I

Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-02-23 Thread Alex Deucher
On Mon, Feb 22, 2021 at 10:44 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion > to bool not needed

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-23 Thread Alex Deucher
On Mon, Feb 22, 2021 at 3:13 PM Souptick Joarder wrote: > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > >> warning: variable 'i' is uninitialized when used here > >> [-Wuninitialized] >timing = >detailed_timings[i]; >

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-23 Thread Simon Ser
On Tuesday, February 23rd, 2021 at 6:42 PM, Alex Deucher wrote: > yeah, fdo ran out of disk space so I moved to gitlab: > > https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-next Ah, thanks for the info, my bad! ___ dri-devel mailing list

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-23 Thread Alex Deucher
yeah, fdo ran out of disk space so I moved to gitlab: https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-next Alex On Mon, Feb 22, 2021 at 7:26 PM Bas Nieuwenhuizen wrote: > > I think Alex moved to gitlab for his branches > > On Tue, Feb 23, 2021, 12:50 AM Simon Ser wrote: >> >> On

Re: [PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-23 Thread Alex Deucher
On Wed, Feb 10, 2021 at 8:14 AM Daniel Vetter wrote: > > On Wed, Feb 10, 2021 at 08:45:56AM +0100, Christian König wrote: > > Reviewed-by: Christian König for the series. > > Smash it into -misc? @Christian Koenig did these ever land? I don't see them in drm-misc. Alex > -Daniel > > > > > Am

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 11:00:54AM -0500, Alan Stern wrote: > On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 14:44 schrieb Takashi Iwai: > > > > Aside from the discussion whether this "workaround" is needed, the use > > > of udev->bus->controller

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Alyssa Rosenzweig
> If YTR can't be turned off, then according to the AFBC spec - correct. There is no public AFBC spec, so I'm not sure how to respond to this. > If the hardware allows it to be configured to use YTR with other > component orders, I don't know exactly what the impact would be - > maybe nothing.

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
On Tue, Feb 23, 2021 at 03:29:13PM +, Daniel Stone wrote: > On Tue, 23 Feb 2021 at 14:58, Brian Starkey wrote: > > On Tue, Feb 23, 2021 at 02:27:11PM +, Daniel Stone wrote: > > > Mark, or others from Rockchip, can you please: > > > - explain if there is a way to enable/disable the YTR

Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 4:59 PM Neil Roberts wrote: > > Daniel Vetter writes: > > > drm_gem_shmem_fault() does not seem to check for purged objects at all. > > > > No idea how this works, or if it ever worked, but yeah something is > > clearly still busted. > > Oh of course, the fault handler

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Alex Riesen
Alex Riesen, Tue, Feb 23, 2021 16:51:26 +0100: > Ilia Mirkin, Tue, Feb 23, 2021 16:46:52 +0100: > > I'd recommend using xf86-video-nouveau in any case, but some distros > > I would like try this out. Do you know how to force the xorg server to > choose this driver instead of modesetting? Found

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Takashi Iwai
On Tue, 23 Feb 2021 17:00:54 +0100, Alan Stern wrote: > > On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 14:44 schrieb Takashi Iwai: > > > > Aside from the discussion whether this "workaround" is needed, the use > > > of udev->bus->controller

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-02-23 Thread Alex Deucher
This was already fixed by a patch from Yang Li . Alex On Tue, Feb 23, 2021 at 1:13 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8260:16-21: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Alex Riesen
Ilia Mirkin, Tue, Feb 23, 2021 16:46:52 +0100: > On Tue, Feb 23, 2021 at 10:36 AM Alex Riesen > wrote: > > Ilia Mirkin, Tue, Feb 23, 2021 15:56:21 +0100: > > > On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen > > > wrote: > > > > > > > > This change broke X cursor in my setup, and reverting the

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Alan Stern
On Tue, Feb 23, 2021 at 03:06:07PM +0100, Thomas Zimmermann wrote: > Hi > > Am 23.02.21 um 14:44 schrieb Takashi Iwai: > > Aside from the discussion whether this "workaround" is needed, the use > > of udev->bus->controller here looks a bit suspicious. As the old USB > > code (before the commit

Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-23 Thread Neil Roberts
Daniel Vetter writes: > drm_gem_shmem_fault() does not seem to check for purged objects at all. > > No idea how this works, or if it ever worked, but yeah something is > clearly still busted. Oh of course, the fault handler doesn’t check this. I’ve added a second patch to make it check and

[PATCH v2 2/2] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-23 Thread Neil Roberts
When mmapping the shmem, it would previously adjust the pgoff in the vm_area_struct to remove the fake offset that is added to be able to identify the buffer. This patch removes the adjustment and makes the fault handler use the vm_fault address to calculate the page offset instead. Although using

[PATCH 1/2] drm/shmem-helper: Check for purged buffers in fault handler

2021-02-23 Thread Neil Roberts
When a buffer is madvised as not needed and then purged, any attempts to access the buffer from user-space should cause a bus fault. This patch adds a check for that. Cc: sta...@vger.kernel.org Fixes: 17acb9f35ed7 ("drm/shmem: Add madvise state and purge helpers") Signed-off-by: Neil Roberts ---

[PATCH 0/2] Fix purging buffers in the shmem helpers

2021-02-23 Thread Neil Roberts
These two patches fix a problem with the madvise purging code for the shmem helpers where the mmaping for a purged buffer wouldn't get invalidated correctly. This presumably ends up as a security hole where the mapping can be accessed from user-space to read and write random pages from other

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Ilia Mirkin
On Tue, Feb 23, 2021 at 10:36 AM Alex Riesen wrote: > > Ilia Mirkin, Tue, Feb 23, 2021 15:56:21 +0100: > > On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen > > wrote: > > > Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > > > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > >

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Alex Riesen
Ilia Mirkin, Tue, Feb 23, 2021 15:56:21 +0100: > On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen > wrote: > > Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > > index

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Alan Stern
On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > --- a/drivers/gpu/drm/drm_prime.c > > +++ b/drivers/gpu/drm/drm_prime.c > > @@ -29,6 +29,7 @@ > > #include > > #include > > #include > > +#include > > > >

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Daniel Stone
On Tue, 23 Feb 2021 at 14:58, Brian Starkey wrote: > On Tue, Feb 23, 2021 at 02:27:11PM +, Daniel Stone wrote: > > Mark, or others from Rockchip, can you please: > > - explain if there is a way to enable/disable the YTR transform in the > > VOP's AFBC decoder, similar to the split-block

Re: [PATCH v3 2/2] drm/bridge: anx7625: disable regulators when power off

2021-02-23 Thread Robert Foss
Hey Hsin-Yi, This patch looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Fri, 15 Jan 2021 at 08:05, Hsin-Yi Wang wrote: > > When suspending the driver, anx7625_power_standby() will be called to > turn off reset-gpios and enable-gpios. However, power supplies are not >

Re: [Freedreno] [v4] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-23 Thread kalyan_t
On 2021-02-22 21:38, Rob Clark wrote: On Thu, Feb 18, 2021 at 4:36 AM Kalyan Thota wrote: Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups

Re: [PATCH 2/2] drm/vgem: use shmem helpers

2021-02-23 Thread kernel test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip linus/master next-20210223] [cannot apply to tegra-drm/drm/tegra/for-next drm-exynos/exynos-drm-next drm/drm-next v5.11] [If your patch

Re: [RESEND v3 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

2021-02-23 Thread Robert Foss
Hey Hsin-Yi, Thanks for the patch, and sorry about the delays in reviewing this. This patch does not apply to the drm-misc/for-linux-next branch due to some other changes having been merged. On Sat, 20 Feb 2021 at 07:10, Hsin-Yi Wang wrote: > > anx7625 requires 3 power supply regulators. > >

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Brian Starkey
Hi, On Tue, Feb 23, 2021 at 02:27:11PM +, Daniel Stone wrote: > Mark, or others from Rockchip, can you please: > - explain if there is a way to enable/disable the YTR transform in the > VOP's AFBC decoder, similar to the split-block control bit? > - ack this patch which correctly declares

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Ilia Mirkin
On Tue, Feb 23, 2021 at 9:26 AM Alex Riesen wrote: > > Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > index c6367035970e..5f4f09a601d4 100644 > > ---

Re: [Intel-gfx] [PATCH 19/30] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-02-23 Thread Rodrigo Vivi
On Fri, Feb 19, 2021 at 04:53:15PM -0500, Lyude Paul wrote: > So that we can start using drm_dbg_*() in > drm_dp_link_train_clock_recovery_delay(). > > Signed-off-by: Lyude Paul I wonder if we could have a drm_dp so we encapsulate both aux and dpcd related information... But this one already

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Daniel Stone
Hi, On Tue, 23 Feb 2021 at 14:27, Daniel Stone wrote: > Bumping this one: it seems like the Rockchip VOP either always applies > the YTR transform, or has a YTR control bit which is not documented in > the driver's register definitions. This means that it is incorrect to > advertise the

Re: [PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-02-23 Thread Maxime Ripard
Hi Thomas, On Mon, Feb 22, 2021 at 10:12:49AM +0100, Thomas Zimmermann wrote: > Am 19.02.21 um 13:00 schrieb Maxime Ripard: > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atomic_check hook, which would be the old > > plane state in the

Re: [PATCH] drm/rockchip: Require the YTR modifier for AFBC

2021-02-23 Thread Daniel Stone
Hi, On Wed, 12 Aug 2020 at 08:05, Alyssa Rosenzweig wrote: > The AFBC decoder used in the Rockchip VOP assumes the use of the > YUV-like colourspace transform (YTR). YTR is lossless for RGB(A) > buffers, which covers the RGBA8 and RGB565 formats supported in > vop_convert_afbc_format. Use of YTR

Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace

2021-02-23 Thread Alex Riesen
Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100: > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c > b/drivers/gpu/drm/nouveau/dispnv50/disp.c > index c6367035970e..5f4f09a601d4 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -2663,6

Re: [PATCH 2/2] drm/vgem: use shmem helpers

2021-02-23 Thread kernel test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip linus/master next-20210223] [cannot apply to drm/drm-next v5.11] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 14:44 schrieb Takashi Iwai: On Tue, 23 Feb 2021 11:58:42 +0100, Thomas Zimmermann wrote: USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Importing dmabuf into a USB-based driver fails, which break joining and mirroring of display in

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Takashi Iwai
On Tue, 23 Feb 2021 11:58:42 +0100, Thomas Zimmermann wrote: > > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Importing dmabuf into a USB-based driver fails, which > break joining and mirroring of display in X11. > > For USB devices, pick the

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 13:52 schrieb Greg KH: On Tue, Feb 23, 2021 at 01:49:50PM +0100, Daniel Vetter wrote: On Tue, Feb 23, 2021 at 1:44 PM Greg KH wrote: On Tue, Feb 23, 2021 at 01:37:09PM +0100, Thomas Zimmermann wrote: Hi Am 23.02.21 um 12:19 schrieb Greg KH: On Tue, Feb 23, 2021 at

Re: [PATCH 1/2] drm/dp_mst: Revise broadcast msg lct & lcr

2021-02-23 Thread Ville Syrjälä
On Tue, Feb 23, 2021 at 05:32:32AM +, Lin, Wayne wrote: > [AMD Public Use] > > > -Original Message- > > From: Ville Syrjälä > > Sent: Tuesday, February 23, 2021 1:09 AM > > To: Lin, Wayne > > Cc: Brol, Eryk ; Zhuo, Qingqing ; > > sta...@vger.kernel.org; Zuo, Jerry > > ;

Re: [PATCH 2/2] drm/dp_mst: Set CLEAR_PAYLOAD_ID_TABLE as broadcast

2021-02-23 Thread Ville Syrjälä
On Tue, Feb 23, 2021 at 05:32:36AM +, Lin, Wayne wrote: > [AMD Public Use] > > > -Original Message- > > From: Ville Syrjälä > > Sent: Tuesday, February 23, 2021 1:00 AM > > To: Lin, Wayne > > Cc: dri-devel@lists.freedesktop.org; Brol, Eryk ; Zhuo, > > Qingqing ; > >

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:51:09PM +0100, Thomas Zimmermann wrote: > Hi > > Am 23.02.21 um 13:24 schrieb Greg KH: > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH > > > wrote: > > > > > > > > On Tue, Feb 23, 2021 at 12:46:20PM

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:50 PM Greg KH wrote: > > On Tue, Feb 23, 2021 at 01:40:51PM +0100, Daniel Vetter wrote: > > On Tue, Feb 23, 2021 at 1:24 PM Greg KH wrote: > > > > > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH > > >

Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:42 PM Neil Roberts wrote: > > Daniel Vetter writes: > > > Yeah plus Cc: stable for backporting and I think an igt or similar for > > panfrost to check this works correctly would be pretty good too. Since > > if it took us over 1 year to notice this bug it's pretty clear

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:49:50PM +0100, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 1:44 PM Greg KH wrote: > > > > On Tue, Feb 23, 2021 at 01:37:09PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 23.02.21 um 12:19 schrieb Greg KH: > > > > On Tue, Feb 23, 2021 at 11:58:42AM +0100,

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 13:24 schrieb Greg KH: On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: On Tue, Feb 23, 2021 at 1:02 PM Greg KH wrote: On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: On Tue, Feb 23,

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:40:51PM +0100, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 1:24 PM Greg KH wrote: > > > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH > > > wrote: > > > > > > > > On Tue, Feb 23, 2021 at 12:46:20PM

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:44 PM Greg KH wrote: > > On Tue, Feb 23, 2021 at 01:37:09PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 23.02.21 um 12:19 schrieb Greg KH: > > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > > > USB devices cannot perform DMA and hence have

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:37 PM Thomas Zimmermann wrote: > > Hi > > Am 23.02.21 um 12:19 schrieb Greg KH: > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > >> USB devices cannot perform DMA and hence have no dma_mask set in their > >> device structure. Importing dmabuf into

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:37:09PM +0100, Thomas Zimmermann wrote: > Hi > > Am 23.02.21 um 12:19 schrieb Greg KH: > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > > USB devices cannot perform DMA and hence have no dma_mask set in their > > > device structure. Importing

Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-23 Thread Neil Roberts
Daniel Vetter writes: > Yeah plus Cc: stable for backporting and I think an igt or similar for > panfrost to check this works correctly would be pretty good too. Since > if it took us over 1 year to notice this bug it's pretty clear that > normal testing doesn't catch this. So very likely we'll

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:24 PM Greg KH wrote: > > On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > > On Tue, Feb 23, 2021 at 1:02 PM Greg KH wrote: > > > > > > On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: > > > > On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 12:19 schrieb Greg KH: On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Importing dmabuf into a USB-based driver fails, which break joining and mirroring of display in

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 01:14:30PM +0100, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 1:02 PM Greg KH wrote: > > > > On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: > > > On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > > > > On Tue, Feb 23, 2021 at 11:58:42AM +0100,

Re: [RFC PATCH 3/3] drm/vkms: add overlay support

2021-02-23 Thread Melissa Wen
On 02/23, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 11:21 AM Melissa Wen wrote: > > > > On 02/22, Daniel Vetter wrote: > > > On Sat, Feb 20, 2021 at 11:42:12AM -0300, Melissa Wen wrote: > > > > Add support to overlay plane, in addition to primary and cursor > > > > planes. In this approach,

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 1:02 PM Greg KH wrote: > > On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: > > On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > > > USB devices cannot perform DMA and hence

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2021-02-23 Thread Daniel Vetter
On Thu, Feb 18, 2021 at 5:02 PM Andrzej Hajda wrote: > > Hi Michael, > > W dniu 18.02.2021 o 09:04, Michael Tretter pisze: > > On Wed, 10 Feb 2021 10:10:37 +0100, Frieder Schrempf wrote: > >> On 04.02.21 18:46, Daniel Vetter wrote: > >>> On Thu, Feb 4, 2021 at 6:26 PM Laurent Pinchart > >>>

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 12:46:20PM +0100, Daniel Vetter wrote: > On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > > USB devices cannot perform DMA and hence have no dma_mask set in their > > > device structure.

Re: [PATCH v3 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

2021-02-23 Thread Robert Foss
On Tue, 23 Feb 2021 at 11:51, Adrien Grassein wrote: > > Hey Robert, > > Le ven. 19 févr. 2021 à 22:47, Adrien Grassein > a écrit : > > > > Le ven. 19 févr. 2021 à 22:28, Robert Foss a écrit > > : > > > > > > On Fri, 19 Feb 2021 at 16:01, Adrien Grassein > > > wrote: > > > > > > > > Hey

Re: [PATCH 00/11] dma_fence critical sections annotations for atomic

2021-02-23 Thread Daniel Vetter
On Thu, Jan 21, 2021 at 04:29:48PM +0100, Daniel Vetter wrote: > Hi all, > > Finally gotten around to refreshing all the various fence anntotions I've > hast last summer. Or well parts of it: > > - entire amdgpu and drm/scheduler annotations postponed for now, because > there's way too many

[PATCH] drm/vgem: use shmem helpers

2021-02-23 Thread Daniel Vetter
Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a struct page behind that, touching it and mucking

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > USB devices cannot perform DMA and hence have no dma_mask set in their > > device structure. Importing dmabuf into a USB-based driver fails, which > > break joining and

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 12:19:56PM +0100, Greg KH wrote: > On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > > USB devices cannot perform DMA and hence have no dma_mask set in their > > device structure. Importing dmabuf into a USB-based driver fails, which > > break joining and

Re: [PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 11:58:42AM +0100, Thomas Zimmermann wrote: > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Importing dmabuf into a USB-based driver fails, which > break joining and mirroring of display in X11. > > For USB devices, pick the

Re: [PATCH 2/2] drm/vgem: use shmem helpers

2021-02-23 Thread Thomas Zimmermann
Hi Am 23.02.21 um 11:59 schrieb Daniel Vetter: Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a

[PATCH 2/2] drm/vgem: use shmem helpers

2021-02-23 Thread Daniel Vetter
Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a struct page behind that, touching it and mucking

[PATCH 1/2] dma-buf: Require VM_PFNMAP vma for mmap

2021-02-23 Thread Daniel Vetter
tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices, where all buffers are actually all resident

[PATCH v3] drm: Use USB controller's DMA mask when importing dmabufs

2021-02-23 Thread Thomas Zimmermann
USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Importing dmabuf into a USB-based driver fails, which break joining and mirroring of display in X11. For USB devices, pick the associated USB controller as attachment device, so that it can perform DMA. If

Re: [PATCH v3 2/2] drm/bridge: Introduce LT8912 DSI to HDMI bridge

2021-02-23 Thread Adrien Grassein
Hey Robert, Le ven. 19 févr. 2021 à 22:47, Adrien Grassein a écrit : > > Le ven. 19 févr. 2021 à 22:28, Robert Foss a écrit : > > > > On Fri, 19 Feb 2021 at 16:01, Adrien Grassein > > wrote: > > > > > > Hey Robert, > > > > > > Le ven. 19 févr. 2021 à 14:27, Robert Foss a > > > écrit : > > >

Re: [RFC PATCH 3/3] drm/vkms: add overlay support

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 11:21 AM Melissa Wen wrote: > > On 02/22, Daniel Vetter wrote: > > On Sat, Feb 20, 2021 at 11:42:12AM -0300, Melissa Wen wrote: > > > Add support to overlay plane, in addition to primary and cursor > > > planes. In this approach, the plane composition still requires an > >

Re: [RFC PATCH 3/3] drm/vkms: add overlay support

2021-02-23 Thread Melissa Wen
On 02/22, Daniel Vetter wrote: > On Sat, Feb 20, 2021 at 11:42:12AM -0300, Melissa Wen wrote: > > Add support to overlay plane, in addition to primary and cursor > > planes. In this approach, the plane composition still requires an > > active primary plane and planes are composed associatively in

Re: [PATCH] drm/prime: Only call dma_map_sgtable() for devices with DMA support

2021-02-23 Thread Daniel Vetter
On Mon, Feb 22, 2021 at 06:30:35PM +0100, Noralf Trønnes wrote: > > > Den 22.02.2021 08.54, skrev Thomas Zimmermann: > > Hi > > > > Am 20.02.21 um 14:02 schrieb Noralf Trønnes: > >> > >> > >> Den 19.02.2021 14.40, skrev Thomas Zimmermann: > >>> Fixes a regression for udl and probably other

Re: [RFC PATCH 1/3] drm/vkms: decouple cursor plane setup from crtc_init

2021-02-23 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 10:42 AM Melissa Wen wrote: > > On 02/22, Daniel Vetter wrote: > > On Sat, Feb 20, 2021 at 11:38:50AM -0300, Melissa Wen wrote: > > > Initialize CRTC only with primary plane (without cursor) as a preparation > > > to init overlay plane before cursor plane and keep cursor

Re: [RFC PATCH 1/3] drm/vkms: decouple cursor plane setup from crtc_init

2021-02-23 Thread Melissa Wen
On 02/22, Daniel Vetter wrote: > On Sat, Feb 20, 2021 at 11:38:50AM -0300, Melissa Wen wrote: > > Initialize CRTC only with primary plane (without cursor) as a preparation > > to init overlay plane before cursor plane and keep cursor on the top. > > > > Signed-off-by: Melissa Wen > > Why can't

Re: [PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy

2021-02-23 Thread Romain Perier
Le lun. 22 févr. 2021 à 17:36, Shuah Khan a écrit : > > Cool. A quick check shows me 1031 strscpy() calls with no return > checks. All or some of these probably need to be reviewed and add > return checks. Is this something that is in the plan to address as > part of this work? > > thanks, > --

  1   2   >