Re: [PATCH 2/2] drm/i915/mtl: Add C6 residency support for MTL SAMedia

2022-10-14 Thread Dixit, Ashutosh
On Tue, 20 Sep 2022 01:06:52 -0700, Jani Nikula wrote: > > On Mon, 19 Sep 2022, "Dixit, Ashutosh" wrote: > > On Mon, 19 Sep 2022 05:13:18 -0700, Jani Nikula wrote: > >> > >> On Mon, 19 Sep 2022, Badal Nilawar wrote: > >> > For MTL SAMedia updated relevant functions and places in the code to get

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-14 Thread Dixit, Ashutosh
On Mon, 19 Sep 2022 09:49:07 -0700, Andi Shyti wrote: > > Hi Badal, Hi Andi, Badal is out for a bit so I am sending out this version. > On Mon, Sep 19, 2022 at 05:29:05PM +0530, Badal Nilawar wrote: > > Updated the CAGF functions to get actual resolved frequency of > > 3D and SAMedia > > can

Re: [PATCH 1/2] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-14 Thread Dixit, Ashutosh
On Mon, 19 Sep 2022 15:49:17 -0700, Matt Roper wrote: > > On Mon, Sep 19, 2022 at 03:46:47PM -0700, Matt Roper wrote: > > On Mon, Sep 19, 2022 at 05:29:05PM +0530, Badal Nilawar wrote: > > > Updated the CAGF functions to get actual resolved frequency of > > > 3D and SAMedia > > > > > > Bspec:

[PATCH 3/3] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-14 Thread Ashutosh Dixit
From: Badal Nilawar Add support for C6 residency and C state type for MTL SAMedia. Also add mtl_drpc. v2: Fixed review comments (Ashutosh) v3: Sort registers and fix whitespace errors in intel_gt_regs.h (Matt R) Remove MTL_CC_SHIFT (Ashutosh) Adapt to RC6 residency register code

[PATCH 2/3] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-14 Thread Ashutosh Dixit
From: Badal Nilawar Update CAGF functions for MTL to get actual resolved frequency of 3D and SAMedia. v2: Update MTL_MIRROR_TARGET_WP1 position/formatting (MattR) Move MTL branches in cagf functions to top (MattR) Fix commit message (Andi) Bspec: 66300 Signed-off-by: Ashutosh Dixit

[PATCH 0/3] i915: CAGF and RC6 changes for MTL

2022-10-14 Thread Ashutosh Dixit
This series includes the code changes to get CAGF, RC State and C6 Residency of MTL. v2: Included "Use GEN12 RPSTAT register" patch v3: - Rebased - Dropped "Use GEN12 RPSTAT register" patch from this series going to send separate series for it v4: - Included "drm/i915/gt: Change RC6

[PATCH 1/3] drm/i915/gt: Change RC6 residency functions to accept register ID's

2022-10-14 Thread Ashutosh Dixit
Previously RC6 residency functions directly accepted RC6 residency register MMIO offsets (there are four RC6 residency registers). This worked but required an assumption on the residency register layout so was not future proof. Therefore change RC6 residency functions to accept register ID's

Re: [PATCH v3] drm/i915/huc: bump timeout for delayed load and reduce print verbosity

2022-10-14 Thread John Harrison
On 10/13/2022 13:32, Daniele Ceraolo Spurio wrote: We're observing sporadic HuC delayed load timeouts in CI, due to mei_pxp binding completing later than we expected. HuC is still loaded when the bind occurs, but in the meantime i915 has started allowing submission to the VCS engines even if HuC

Re: [PATCH v2 7/7] drm/i915/guc: handle interrupts from media GuC

2022-10-14 Thread Matt Roper
On Wed, Oct 12, 2022 at 05:03:32PM -0700, Daniele Ceraolo Spurio wrote: > The render and media GuCs share the same interrupt enable register, so > we can no longer disable interrupts when we disable communication for > one of the GuCs as this would impact the other GuC. Instead, we keep the >

[PATCH] drm/i915/pvc: Update forcewake domain for CCS register ranges

2022-10-14 Thread Matt Roper
The bspec was just updated with a correction to the forcewake domain required when accessing registers in the CCS engine ranges (0x1a000 - 0x1 and 0x26000 - 0x27fff) on PVC; these ranges require a wake on the RENDER domain, not the GT domain. Bspec: 67609 Signed-off-by: Matt Roper ---

[PATCH] drm/panel/panel-sitronix-st7701: Remove panel on DSI attach failure

2022-10-14 Thread Marek Vasut
In case mipi_dsi_attach() fails, call drm_panel_remove() to avoid memory leak. Fixes: 849b2e3ff9698 ("drm/panel: Add Sitronix ST7701 panel driver") Signed-off-by: Marek Vasut --- Cc: Guido Günther Cc: Jagan Teki Cc: Laurent Pinchart Cc: Linus Walleij Cc: Sam Ravnborg Cc: Thierry Reding ---

[PATCH] drm/panel/panel-sitronix-st7701: Clean up CMDnBKx selection

2022-10-14 Thread Marek Vasut
There are two command register files, CMD1 and CMD2, where only the CMD2 contains additional register sub-files BK0..3 . Pull the register file selection call into separate function instead of duplicating it all over the driver. The CMD2BK2 file is undocumented in datasheet, and is used for BIST.

[PATCH v3 13/14] drm/i915/xelpg: Add multicast steering

2022-10-14 Thread Matt Roper
MTL's graphics IP (Xe_LPG) once again changes the multicast register types and steering details. Key changes from past platforms: * The number of instances of some MCR types (NODE, OAAL2, and GAM) vary according to the MTL subplatform and cannot be read from fuse registers. However

[PATCH v3 14/14] drm/i915/xelpmp: Add multicast steering for media GT

2022-10-14 Thread Matt Roper
MTL's media IP (Xe_LPM+) only has a single type of steering ("OAADDRM") which selects between media slice 0 and media slice 1. We'll always steer to media slice 0 unless it is fused off (which is the case when VD0, VE0, and SFC0 are all reported as unavailable). Bspec: 67789 Signed-off-by: Matt

[PATCH v3 12/14] drm/i915: Define multicast registers as a new type

2022-10-14 Thread Matt Roper
Rather than treating multicast registers as 'i915_reg_t' let's define them as a completely new type. This will allow the compiler to help us make sure we're using multicast-aware functions to operate on multicast registers. This plan does break down a bit in places where we're just maintaining

[PATCH v3 11/14] drm/i915/gt: Add MCR-specific workaround initializers

2022-10-14 Thread Matt Roper
Let's be more explicit about which of our workarounds are updating MCR registers. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 433 +++--- .../gpu/drm/i915/gt/intel_workarounds_types.h | 4 +- 2 files changed, 263 insertions(+), 174 deletions(-)

[PATCH v3 06/14] drm/i915/xehp: Check for faults on primary GAM

2022-10-14 Thread Matt Roper
On Xe_HP the fault registers are now in a multicast register range. However as part of the GAM these registers follow special rules and we need only read from the "primary" GAM's instance to get the information we need. So a single intel_gt_mcr_read_any() (which will automatically steer to the

[PATCH v3 07/14] drm/i915/gt: Add intel_gt_mcr_wait_for_reg_fw()

2022-10-14 Thread Matt Roper
Xe_HP has some MCR registers that need to be polled for completion of operations like TLB invalidation. Those registers are in the GAM range, which rolls up the status from each unit into the 'primary' instance's value. This makes it useful to have a dedicated 'wait for register' function that

[PATCH v3 03/14] drm/i915/gt: Drop a few unused register definitions

2022-10-14 Thread Matt Roper
Let's drop a few register definitions that are unused anywhere in the driver today. Since the referenced offsets are part of what is now considered a multicast register region, the current definitions would not be correct for use on any future platform. Signed-off-by: Matt Roper ---

[PATCH v3 05/14] drm/i915/gt: Add intel_gt_mcr_multicast_rmw() operation

2022-10-14 Thread Matt Roper
There are cases where we wish to read from any non-terminated MCR register instance (or the primary instance in the case of GAM ranges), clear/set some bits, and then write the value back out to the register in a multicast manner. Adding a "multicast RMW" will avoid the need to open-code this.

[PATCH v3 08/14] drm/i915: Define MCR registers explicitly

2022-10-14 Thread Matt Roper
Rather than using the same _MMIO() macro to define MCR registers as singleton registers, let's use a new MCR_REG() macro to make it clear that these registers are special and should be handled accordingly. For now MCR_REG() will still generate an i915_reg_t with the given offset, but we'll change

[PATCH v3 09/14] drm/i915/gt: Always use MCR functions on multicast registers

2022-10-14 Thread Matt Roper
Rather than relying on the implicit behavior of intel_uncore_*() functions, let's always use the intel_gt_mcr_*() functions to operate on multicast/replicated registers. v2: - Add TLB invalidation registers v3: - Switch more uncore operations in mmio_invalidate_full() to MCR operations for

[PATCH v3 10/14] drm/i915/guc: Handle save/restore of MCR registers explicitly

2022-10-14 Thread Matt Roper
MCR registers can be placed on the GuC's save/restore list, but at the moment they are always handled in a multicast manner (i.e., the GuC reads one instance to save the value and then does a multicast write to restore that single value to all instances). In the future the GuC will probably give

[PATCH v3 01/14] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-10-14 Thread Matt Roper
Gen8 was the first time our hardware had multicast registers (or at least the first time the multicast nature was exposed and MMIO accesses could be steered). There are some registers that transitioned from singleton behavior to multicast during the gen7 -> gen8 transition; let's duplicate the

[PATCH v3 02/14] drm/i915/xehp: Create separate reg definitions for new MCR registers

2022-10-14 Thread Matt Roper
Starting in Xe_HP, several registers our driver works with have been converted from singleton registers into replicated registers with multicast behavior. Although the registers are still located at the same MMIO offsets as on previous platforms, let's duplicate the register definitions in

[PATCH v3 04/14] drm/i915/gt: Correct prefix on a few registers

2022-10-14 Thread Matt Roper
We have a few registers that have existed for several hardware generations, but are only used by the driver on Xe_HP and beyond. In cases where the Xe_HP version of the register is now replicated and uses multicast behavior, but earlier generations were singleton, let's change the register prefix

Re: [PATCH v2 13/14] drm/i915/mtl: Add multicast steering for render GT

2022-10-14 Thread Matt Roper
On Fri, Oct 14, 2022 at 09:32:55PM +0530, Balasubramani Vivekanandan wrote: > On 30.09.2022 17:45, Matt Roper wrote: > > MTL once again changes the multicast register types and steering > > details. Key changes from past platforms: > > * The number of instances of some MCR types (NODE, OAAL2,

Re: [PATCH v2 2/2] drm/i915: Use graphics ver, rel info for media on old platforms

2022-10-14 Thread Lucas De Marchi
On Tue, Oct 11, 2022 at 08:38:51AM -0700, Radhakrishna Sripada wrote: Platforms prior to MTL do not have a separate media and graphics version. On platforms where GMD id is not supported, reuse the graphics ip version, release info for media. The rest of the IP graphics, display versions would

Re: [PATCH] dt-bindings: display: panel: use spi-peripheral-props.yaml

2022-10-14 Thread Rob Herring
On Tue, 04 Oct 2022 14:09:07 +0200, Krzysztof Kozlowski wrote: > For devices connectable by SPI bus (e.g. already using > "spi-max-frequency" property), reference the "spi-peripheral-props.yaml" > schema to allow using all SPI device properties, even these which device > bindings author did not

[PATCH] dt-bindings: Remove "status" from schema examples, again

2022-10-14 Thread Rob Herring
There's no reason to have "status" properties in examples. "okay" is the default, and "disabled" turns off some schema checks ('required' specifically). A meta-schema check for this is pending, so hopefully the last time to fix these. Fix the indentation in intel,phy-thunderbay-emmc while we're

Re: [PATCH v3 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate

2022-10-14 Thread Florian Fainelli
On 10/13/22 02:13, Maxime Ripard wrote: The firmware allows to query for its clocks the operating range of a given clock. We'll need this for some drivers (KMS, in particular) to infer the state of some configuration options, so let's create a function to do so. Acked-by: Stephen Boyd

Re: [PATCH v3 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header

2022-10-14 Thread Florian Fainelli
On 10/13/22 02:13, Maxime Ripard wrote: We'll need the clock IDs in more drivers than just the clock driver from now on, so let's move them in the firmware header. Signed-off-by: Maxime Ripard Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node()

2022-10-14 Thread Florian Fainelli
On 10/13/22 02:13, Maxime Ripard wrote: A significant number of RaspberryPi drivers using the firmware don't have a phandle to it, so end up scanning the device tree to find a node with the firmware compatible. That code is duplicated everywhere, so let's introduce a helper instead.

Re: [PATCH v3 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header

2022-10-14 Thread Stephen Boyd
Quoting Maxime Ripard (2022-10-13 02:13:09) > We'll need the clock IDs in more drivers than just the clock driver from > now on, so let's move them in the firmware header. > > Signed-off-by: Maxime Ripard > --- Acked-by: Stephen Boyd

Re: [RFC PATCH v5] media: mediatek: vcodec: support stateless AV1 decoder

2022-10-14 Thread Daniel Almeida
Hi Xiaoyong! I have tested this and arrived at the same Fluster score: 173/239 - AOM 11/13 - Chromium 8bit Reviewed-by: Daniel Almeida Tested-by: Daniel Almeida

Re: [PATCH] drm/amd/display: Fix build breakage with CONFIG_DEBUG_FS=n

2022-10-14 Thread Linus Torvalds
On Fri, Oct 14, 2022 at 8:22 AM Nathan Chancellor wrote: > > After commit 8799c0be89eb ("drm/amd/display: Fix vblank refcount in vrr > transition"), a build with CONFIG_DEBUG_FS=n is broken due to a > misplaced brace, along the lines of: Thanks, applied. Linus

Re: [PATCH v3 2/2] drm/i915/uapi: expose GTT alignment

2022-10-14 Thread Matthew Auld
On 14/10/2022 17:51, Jordan Justen wrote: On 2022-10-14 03:58:12, Matthew Auld wrote: On 14/10/2022 08:20, Jordan Justen wrote: Acked-by: Jordan Justen Thanks. Can I take that as ack for merging the series from Mesa POV? I think Lionel was going to test this, but I think keeps getting

Re: [PATCH] drm/stm: Fix resolution bitmasks

2022-10-14 Thread Marek Vasut
On 10/14/22 17:55, Marek Vasut wrote: On 10/14/22 15:42, Yannick FERTRE wrote: Hi Marek, Hello Yannick, The genmask of regsiter SSCR, BPCR & others were setted accordly to the chipset stm32f4. So that means: F4 -> 2048x2048 framebuffer H7/MP1 -> 4096x4096 framebuffer ? Worse F4 is

Re: [PATCH v9] drm: Add initial ci/ subdirectory

2022-10-14 Thread Rob Clark
On Mon, Sep 12, 2022 at 12:29 AM Tomeu Vizoso wrote: > > And use it to store expectations about what the DRM drivers are > supposed to pass in the IGT test suite. > > Also include a configuration file that points to the out-of-tree CI > scripts. > > By storing the test expectations along the code

Re: [PATCH v3 2/2] drm/i915/uapi: expose GTT alignment

2022-10-14 Thread Jordan Justen
On 2022-10-14 03:58:12, Matthew Auld wrote: > On 14/10/2022 08:20, Jordan Justen wrote: > > Acked-by: Jordan Justen > > Thanks. Can I take that as ack for merging the series from Mesa POV? I > think Lionel was going to test this, but I think keeps getting swamped > with other stuff. We kind of

Re: [PATCH v3 2/2] gpu/drm/panel: Add Sony TD4353 JDI panel driver

2022-10-14 Thread Konrad Dybcio
On 30.09.2022 20:08, Konrad Dybcio wrote: > Add support for the Sony TD4353 JDI 2160x1080 display panel used in > some Sony Xperia XZ2 and XZ2 Compact smartphones. Due to the specifics > of smartphone manufacturing, it is impossible to retrieve a better name > for this panel. > > This revision

Re: [PATCH v2 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-10-14 Thread Krzysztof Kozlowski
On 14/10/2022 11:15, Guillaume Ranquet wrote: > Add mt8195 SoC bindings for hdmi and hdmi-ddc > > Signed-off-by: Guillaume Ranquet > --- > .../bindings/display/mediatek/mediatek,hdmi.yaml | 67 > +- > .../display/mediatek/mediatek,mt8195-hdmi-ddc.yaml | 51

Re: [PATCH v2 13/14] drm/i915/mtl: Add multicast steering for render GT

2022-10-14 Thread Balasubramani Vivekanandan
On 30.09.2022 17:45, Matt Roper wrote: > MTL once again changes the multicast register types and steering > details. Key changes from past platforms: > * The number of instances of some MCR types (NODE, OAAL2, and GAM) vary >according to the MTL subplatform and cannot be read from fuse >

Re: [PATCH] drm/stm: Fix resolution bitmasks

2022-10-14 Thread Marek Vasut
On 10/14/22 15:42, Yannick FERTRE wrote: Hi Marek, Hello Yannick, The genmask of regsiter SSCR, BPCR & others were setted accordly to the chipset stm32f4. So that means: F4 -> 2048x2048 framebuffer H7/MP1 -> 4096x4096 framebuffer ? We should then also update

[PATCH] drm/amd/display: add a WARN() to irq service functions

2022-10-14 Thread Hamza Mahfooz
Currently, if we encounter unimplemented functions, it is difficult to tell what caused them just by looking at dmesg and that is compounded by the fact that it is often hard to reproduce said issues. So, to have access to more detailed debugging information, add a WARN() to dal_irq_service_ack()

[PATCH] drm/amd/display: Fix build breakage with CONFIG_DEBUG_FS=n

2022-10-14 Thread Nathan Chancellor
After commit 8799c0be89eb ("drm/amd/display: Fix vblank refcount in vrr transition"), a build with CONFIG_DEBUG_FS=n is broken due to a misplaced brace, along the lines of: In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_trace.h:39, from

[PATCH v2 11/12] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195

2022-10-14 Thread Guillaume Ranquet
Add dt-binding documentation of dpi for MediaTek MT8195 SoC. Acked-by: Krzysztof Kozlowski Signed-off-by: Guillaume Ranquet --- Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 10/12] phy: mediatek: add support for phy-mtk-hdmi-mt8195

2022-10-14 Thread Guillaume Ranquet
Add basic support for the mediatek hdmi phy on MT8195 SoC Signed-off-by: Guillaume Ranquet --- drivers/phy/mediatek/Makefile | 1 + drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 546 + drivers/phy/mediatek/phy-mtk-hdmi-mt8195.h | 131 +++

[PATCH v2 12/12] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver

2022-10-14 Thread Guillaume Ranquet
Add the DPI1 hdmi path support in mtk dpi driver Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dpi.c | 143 ++-- drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 5 ++ 2 files changed, 141 insertions(+), 7 deletions(-) diff --git

[PATCH v2 07/12] drm/mediatek: hdmi: add v2 support

2022-10-14 Thread Guillaume Ranquet
Adds hdmi and hdmi-ddc support for v2 IP. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/Makefile |2 + drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 14 + drivers/gpu/drm/mediatek/mtk_hdmi_common.h |1 + drivers/gpu/drm/mediatek/mtk_hdmi_ddc_v2.c | 367

[PATCH v2 08/12] drm/mediatek: hdmi: v2: add audio support

2022-10-14 Thread Guillaume Ranquet
Add HDMI audio support for v2 Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 1 + drivers/gpu/drm/mediatek/mtk_hdmi_ddc_v2.c | 2 +- drivers/gpu/drm/mediatek/mtk_hdmi_v2.c | 213 + drivers/gpu/drm/mediatek/mtk_hdmi_v2.h

[PATCH v2 05/12] drm/mediatek: hdmi: make the cec dev optional

2022-10-14 Thread Guillaume Ranquet
Make cec device optional in order to support newer versions of the hdmi IP which doesn't require it Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi.c| 8 +++-- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 54 --

[PATCH v2 04/12] drm/mediatek: extract common functions from the mtk hdmi driver

2022-10-14 Thread Guillaume Ranquet
Create a common "framework" that can be used to add support for different hdmi IPs within the mediatek range of products. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_hdmi.c| 620 ++---

[PATCH v2 06/12] drm/mediatek: hdmi: add frame_colorimetry flag

2022-10-14 Thread Guillaume Ranquet
Add a flag to indicate support for frame colorimetry. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 11 +++ drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c

[PATCH v2 03/12] drm/mediatek: hdmi: use a regmap instead of iomem

2022-10-14 Thread Guillaume Ranquet
To prepare support for newer chips that need to share their address range with a dedicated ddc driver, use a regmap. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 43 +++-- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git

[PATCH v2 09/12] phy: phy-mtk-hdmi: Add generic phy configure callback

2022-10-14 Thread Guillaume Ranquet
Some phys, such as mt8195, needs to have a configure callback defined. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Guillaume Ranquet --- drivers/phy/mediatek/phy-mtk-hdmi.c | 12 drivers/phy/mediatek/phy-mtk-hdmi.h | 1 + 2 files changed, 13 insertions(+) diff --git

[PATCH v2 01/12] dt-bindings: phy: mediatek: hdmi-phy: Add mt8195 compatible

2022-10-14 Thread Guillaume Ranquet
Add a compatible for the HDMI PHY on MT8195 Acked-by: Krzysztof Kozlowski Signed-off-by: Guillaume Ranquet --- Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml

[PATCH v2 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-10-14 Thread Guillaume Ranquet
Add mt8195 SoC bindings for hdmi and hdmi-ddc Signed-off-by: Guillaume Ranquet --- .../bindings/display/mediatek/mediatek,hdmi.yaml | 67 +- .../display/mediatek/mediatek,mt8195-hdmi-ddc.yaml | 51 2 files changed, 104 insertions(+), 14 deletions(-) diff

[PATCH v2 00/12] Add MT8195 HDMI support

2022-10-14 Thread Guillaume Ranquet
and the dpi/drm_drv adjustements to support hdmi. Based on next-20221014 test branch with dts and various "in flight" patches available here: https://gitlab.com/granquet/linux/-/tree/granquet/linux-next_HDMI I haven't updated the vdosys/mmsys/ethdr and mutex patches in a while in that test

Re: [PATCH] drm/i915: Refactor ttm ghost obj detection

2022-10-14 Thread Das, Nirmoy
On 10/14/2022 4:58 PM, Matthew Auld wrote: On 14/10/2022 14:14, Nirmoy Das wrote: Currently i915_ttm_to_gem() returns NULL for ttm ghost object which makes it unclear when we should add a NULL check for a caller of i915_ttm_to_gem() as ttm ghost objects are expected behaviour for certain

Re: [PATCH] drm/i915: Refactor ttm ghost obj detection

2022-10-14 Thread Matthew Auld
On 14/10/2022 14:14, Nirmoy Das wrote: Currently i915_ttm_to_gem() returns NULL for ttm ghost object which makes it unclear when we should add a NULL check for a caller of i915_ttm_to_gem() as ttm ghost objects are expected behaviour for certain cases. Create a separate function to detect ttm

Re: [PATCH v3 2/4] dt-bindings: display: add new bus-format property for panel-dpi

2022-10-14 Thread Dave Stevenson
Hi Francesco On Thu, 13 Oct 2022 at 13:58, Francesco Dolcini wrote: > > Hello Max, Marek, Dave et al. > > On Tue, Jun 28, 2022 at 08:18:36PM +0200, Max Krummenacher wrote: > > From: Max Krummenacher > > > > The property is used to set the enum bus_format and infer the bpc > > for a panel

Re: [PATCH] drm/stm: Fix resolution bitmasks

2022-10-14 Thread Yannick FERTRE
Hi Marek, The genmask of regsiter SSCR, BPCR & others were setted accordly to the chipset stm32f4. You can see more details on page 493 of reference manual RM0090: https://www.st.com/resource/en/reference_manual/DM00031020-.pdf With future hardware, all of these registers will aligned on

Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support

2022-10-14 Thread Guillaume Ranquet
On Tue, 20 Sep 2022 13:04, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Adds hdmi and hdmi-ddc support for mt8195. >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/Makefile >> b/drivers/gpu/drm/mediatek/Makefile >>

[PATCH] drm/i915: Refactor ttm ghost obj detection

2022-10-14 Thread Nirmoy Das
Currently i915_ttm_to_gem() returns NULL for ttm ghost object which makes it unclear when we should add a NULL check for a caller of i915_ttm_to_gem() as ttm ghost objects are expected behaviour for certain cases. Create a separate function to detect ttm ghost object and use that in places where

Re: [PATCH] drm/stm: Fix resolution bitmasks

2022-10-14 Thread Yannick FERTRE
Hi Marek, thanks for the patch. Reviewed-by: Yannick Fertre On 10/12/22 01:10, Marek Vasut wrote: STM32MP15xx RM0436 Rev 6 "35.7.3 LTDC synchronization size configuration register (LTDC_SSCR)" on page 1784 and onward indicates VSH and similar bits are all [11:0] instead of [10:0] wide. Fix

Re: [PATCH v4] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-10-14 Thread Daniel Stone
Hi, On Fri, 14 Oct 2022 at 08:46, AngeloGioacchino Del Regno < angelogioacchino.delre...@collabora.com> wrote: > Il 13/10/22 21:31, Justin Green ha scritto: > > Signed-off-by: Justin Green > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delre...@collabora.com> > And also:

Re: [PATCH drm-misc-next v3 4/7] drm/arm/hdlcd: use drm_dev_unplug()

2022-10-14 Thread Liviu Dudau
On Fri, Oct 14, 2022 at 02:07:09AM +0200, Danilo Krummrich wrote: > Hi Liviu, > > On 10/12/22 17:07, Liviu Dudau wrote: > > Hi Danilo, > > > > Appologies again for the delay in reviewing this as I was at XDC last week. > > No worries, thanks for following up. > > > Looking at the documentation

[Bug 216583] [AMDGPU] Black screen after resume + Failed to pin framebuffer -19

2022-10-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216583 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v3 2/2] drm/i915/uapi: expose GTT alignment

2022-10-14 Thread Matthew Auld
On 14/10/2022 08:20, Jordan Justen wrote: Acked-by: Jordan Justen Thanks. Can I take that as ack for merging the series from Mesa POV? I think Lionel was going to test this, but I think keeps getting swamped with other stuff. We kind of urgently need to land this series. On 2022-10-04

[PATCH 09/13] drm/amdgpu: use scheduler depenencies for UVD msgs

2022-10-14 Thread Christian König
Instead of putting that into the job sync object. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c index

[PATCH 13/13] drm/scheduler: rename dependency callback into prepare_job

2022-10-14 Thread Christian König
This now matches much better what this is doing. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 ++-- drivers/gpu/drm/scheduler/sched_entity.c | 4 ++-- include/drm/gpu_scheduler.h | 13 ++--- 3 files changed, 10 insertions(+), 11

[PATCH 08/13] drm/amdgpu: use scheduler depenencies for VM updates

2022-10-14 Thread Christian König
Instead of putting that into the job sync object. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c| 56 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.h| 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 10 +++- 3 files changed, 52

[PATCH 04/13] drm/amdgpu: drop the fence argument from amdgpu_vmid_grab

2022-10-14 Thread Christian König
This is always the job anyway. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 20 drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 3 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 +--- 3 files changed, 10 insertions(+), 17 deletions(-) diff

[PATCH 02/13] drm/scheduler: add drm_sched_job_add_resv_dependencies

2022-10-14 Thread Christian König
Add a new function to update job dependencies from a resv obj. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 49 ++ include/drm/gpu_scheduler.h| 5 +++ 2 files changed, 39 insertions(+), 15 deletions(-) diff --git

[PATCH 06/13] drm/amdgpu: cleanup scheduler job initialization

2022-10-14 Thread Christian König
Init the DRM scheduler base class while allocating the job. This makes the whole handling much more cleaner. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 8 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c

[PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-10-14 Thread Christian König
Entirely remove the sync obj in the job. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 21 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 1 -

[PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-10-14 Thread Christian König
This was buggy because when we had to wait for entities which were killed as well we would just deadlock. Instead move all the dependency handling into the callbacks so that will all happen asynchronously. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_entity.c | 197

[PATCH 05/13] drm/amdgpu: drop amdgpu_sync from amdgpu_vmid_grab

2022-10-14 Thread Christian König
Instead return the fence directly. Avoids memory allocation to store the fence. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 42 + drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 12 +++ 3

[PATCH 11/13] drm/scheduler: remove drm_sched_dependency_optimized

2022-10-14 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 26 -- include/drm/gpu_scheduler.h| 2 -- 2 files changed, 28 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c

[PATCH 07/13] drm/amdgpu: move explicit sync check into the CS

2022-10-14 Thread Christian König
This moves the memory allocation out of the critical code path. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 13 - drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 12 +++-

[PATCH 03/13] drm/amdgpu: use drm_sched_job_add_resv_dependencies for moves

2022-10-14 Thread Christian König
Use the new common scheduler functions to figure out what to wait for. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

[PATCH 01/13] drm/scheduler: fix fence ref counting

2022-10-14 Thread Christian König
We leaked dependency fences when processes were beeing killed. Additional to that grab a reference to the last scheduled fence. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_entity.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Fixes for scheduler hang when killing a process

2022-10-14 Thread Christian König
Hi guys, rebased those patches on top of amd-staging-drm-next since the amdgpu changes are quite substencial. Please review and comment, Christian.

[PATCH 2/2] drm/amdgpu: use DRM_SCHED_FENCE_DONT_PIPELINE for VM updates

2022-10-14 Thread Christian König
Make sure that we always have a CPU round trip to let the submission code correctly decide if a TLB flush is necessary or not. Signed-off-by: Christian König CC: sta...@vger.kernel.org # 5.19+ --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 9 - 1 file changed, 8 insertions(+), 1

[PATCH 1/2] drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag

2022-10-14 Thread Christian König
Setting this flag on a scheduler fence prevents pipelining of jobs depending on this fence. In other words we always insert a full CPU round trip before dependen jobs are pushed to the pipeline. Signed-off-by: Christian König CC: sta...@vger.kernel.org # 5.19+ ---

Re: [PATCH 01/15] drm/i915/hdmi: do dual mode detect only if connected

2022-10-14 Thread Jani Nikula
On Thu, 13 Oct 2022, Ville Syrjälä wrote: > On Thu, Oct 13, 2022 at 09:41:21PM +0300, Ville Syrjälä wrote: >> On Tue, Oct 11, 2022 at 04:49:35PM +0300, Jani Nikula wrote: >> > For normal connector detect, there's really no point in trying dual mode >> > detect if the connector is disconnected. We

Re: [PATCH v4] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-10-14 Thread AngeloGioacchino Del Regno
Il 13/10/22 21:31, Justin Green ha scritto: Tested on MT8195 and confirmed both correct video output and improved DRAM bandwidth performance. v4: * Move modifier validation to format_mod_supported function. * Add modifiers to drm_universal_plane_init() call. * Make comparisons to

Re: [PATCH v5 22/22] drm/sun4i: tv: Convert to the new TV mode property

2022-10-14 Thread Maxime Ripard
Hi Jernej, On Thu, Oct 13, 2022 at 08:23:51PM +0200, Jernej Škrabec wrote: > Dne četrtek, 13. oktober 2022 ob 15:19:06 CEST je Maxime Ripard napisal(a): > > Now that the core can deal fine with analog TV modes, let's convert the > > sun4i TV driver to leverage those new features. > > > >

Re: [PATCH v3 2/2] drm/i915/uapi: expose GTT alignment

2022-10-14 Thread Jordan Justen
Acked-by: Jordan Justen On 2022-10-04 04:49:15, Matthew Auld wrote: > On some platforms we potentially have different alignment restrictions > depending on the memory type. We also now have different alignment > restrictions for the same region across different kernel versions. > Extend the

Re: [PATCH] drm/radeon: Replace kmap() with kmap_local_page()

2022-10-14 Thread Christian König
Am 13.10.22 um 23:07 schrieb Fabio M. De Francesco: The use of kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as the mapping space is restricted and protected by a global lock for synchronization and (2) it also

Re: [PATCH 0/3] drm/msm/a6xx: devcore dump fixes

2022-10-14 Thread Akhil P Oommen
On 10/14/2022 4:25 AM, Rob Clark wrote: From: Rob Clark First patch fixes a recently introduced memory corruption, the remaining two are cleanups. Rob Clark (3): drm/msm/a6xx: Fix kvzalloc vs state_kcalloc usage drm/msm/a6xx: Skip snapshotting unused GMU buffers drm/msm/a6xx: Remove

Re: [Intel-gfx] [PATCH v3 09/17] drm/i915/vm_bind: Add out fence support

2022-10-14 Thread Niranjana Vishwanathapura
On Sun, Oct 09, 2022 at 11:58:18PM -0700, Niranjana Vishwanathapura wrote: Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti ---

Re: [PATCH v3 06/17] drm/i915/vm_bind: Support for VM private BOs

2022-10-14 Thread Niranjana Vishwanathapura
On Tue, Oct 11, 2022 at 06:41:23PM +0100, Matthew Auld wrote: On 11/10/2022 17:27, Matthew Auld wrote: On 10/10/2022 07:58, Niranjana Vishwanathapura wrote: Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage